It's ok now. Your full name and e-mail please so I can commit it.

Changes looks fine, but I can't apply it because you updated it incorrectly.

Looks good, but please rename the folder to lowercase middleclickloader.

You can either update this or create new revision.

It still needs to keep GConf code for systems without gsettings pulseaudio module (eg. pulseaudio < 12.0).

Sorry, I won't accept simple plugins like this written in C++ anymore. They should be done in Python or QML/JS (when available).

Sorry, bad merge. Should be ok now.

In D13734#291184, @apol wrote:

What's the advantage?

Ping

Is it still available in Dolphin?

Looks much better now.

In D13931#290544, @nicolasfella wrote:

I can get the PulseObject, that is not the problem, the problem is that I can't access the model outside of a delegate. model[index] does not work because QAbstractItemModel does not implement the {} operator.

And the whole ComboBox/SinkModel code needs to be changed. You should be able to get the PulseObject from the model just with QML code (see invokables in https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/itemmodels/qabstractitemmodel.h).
Also I don't see purpose of that "changed" property.

In T9091#149003, @ngraham wrote:

Strongly agree. Technically, this would solve a lot of problems, including allowing us to finally implement "Automatically switch all running streams when a new output becomes available" by default. See https://mail.kde.org/pipermail/plasma-devel/2018-March/083156.html (and the rest of the thread, for context).

I don't think hiding it makes sense, indicating that it is unavailable/unplugged as pavucontrol does is enough.
User should see that pulse knows about those ports, but they are just not plugged so if user choose them, it won't play audio.

In D13736#283377, @rjvbb wrote:

In D13736#283140, @chrstphrchvz wrote:

In D13736#283134, @drosca wrote:

Do you have dev account?

Nope.

I do - is there a way I can push (from here) while retaining Christopher's authorship? I've seen others do it with my patches but have no idea how.

Do you have dev account?

In D13694#282499, @nicolasfella wrote:

This breaks the profile selection Combobox in the KCM.

In D13673#281629, @jcimalando wrote:

I regret this decision but at the same time I respect it.
Adding manually has an inconvenient for users, it does not permit to set up the search suggestions.

It would, if Bing supported OpenSearch as other search engines.

Sorry, I don't want Bing by default. You can always add it manually.

There was a reason it was like that, because QtWebEngine did in some version set QWebEngineDownloadItem::path() as percent encoded string. I'm not sure in which version it was fixed (if it was?), but in any case this patch seems wrong. If the path() is no longer percent encoded, QUrl::fromPercentEncoded can be just removed, instead of percent encoding the string and then decoding it again.

This should go to Falkon/3.0.

In D13268#273516, @andreysemenov wrote:

In D13268#273515, @drosca wrote:

Do you have a dev account?

I think i don't.

Do you have a dev account?

Is there any reason for this, except save some cycles?

Looks fine, except some issues with methods that should be hidden:

I think it should keep whitelisted cookies every time (it worked like that in QtWebKit version), so it's not needed to make it configurable.

Into Falkon/3.0 please.

In D12833#261316, @kkofler wrote:

Also, all the existing macros in config.h.cmake are #cmakedefine, not #cmakedefine01, so are you sure you want the latter even though it would be inconsistent?

This should be done for all QtWebEngine checks (5.10, 5.11) and should be in config.h with #cmakedefine01 so it can be used as #if HAVE_QTWEBENGINE_5_10

In D4140#259101, @apol wrote:

Could we maybe accept this?