drosca (David Rosca)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (277 w, 1 d)
Availability
Available

Recent Activity

May 16 2020

drosca added a comment to D29007: Make wheel-event fixup version dependent.

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

May 16 2020, 12:23 PM · Falkon

Apr 20 2020

drosca accepted D29007: Make wheel-event fixup version dependent.
Apr 20 2020, 9:58 AM · Falkon

Mar 25 2020

drosca requested changes to D27655: Open all URLs in command line arguments.
Mar 25 2020, 6:20 AM · Falkon
drosca requested changes to D28198: QFile is open but not closed.

QFile is closed in the destructor, this is not needed.

Mar 25 2020, 6:19 AM · Falkon
drosca requested changes to D28240: special character shown in warning dialog.

It should be <br/> instead.

Mar 25 2020, 6:18 AM · Falkon

Mar 12 2020

drosca accepted D27574: Remove bold formatting of device name.
Mar 12 2020, 6:51 AM · Plasma
drosca accepted D27572: [kcm] Drop 'Enable bluetooth integration' setting.

Applet doesn't need the KDED module, it only talks with BlueZ directly. This is for stuff like bluetooth:// kio protocol and receiving files.

Mar 12 2020, 6:51 AM · Plasma

Mar 6 2020

drosca added inline comments to D27655: Open all URLs in command line arguments.
Mar 6 2020, 5:19 PM · Falkon
drosca added inline comments to D27655: Open all URLs in command line arguments.
Mar 6 2020, 12:33 PM · Falkon
drosca accepted D27112: Fix errors in the QRegularExpression porting commit.
Mar 6 2020, 9:36 AM · Frameworks
drosca requested changes to D27655: Open all URLs in command line arguments.
Mar 6 2020, 7:31 AM · Falkon
drosca requested changes to D27691: Be able to launch a new non-private window from a private window.
Mar 6 2020, 7:23 AM · Falkon

Feb 27 2020

drosca requested changes to D27691: Be able to launch a new non-private window from a private window.

There shouldn't be more than one Falkon process sharing one profile. The only exception is the private process, that is using (should be) all profile data in read-only mode.

Feb 27 2020, 3:25 PM · Falkon

Feb 19 2020

drosca requested changes to D27440: autofill input fields failing for some sites.

I don't really like, there is ton of duplicated code. Also coding style is wrong.

Feb 19 2020, 12:08 PM · Falkon

Feb 9 2020

drosca accepted D27095: SearchBar - Show number of matches found on page search.
Feb 9 2020, 2:12 PM · Falkon

Feb 7 2020

drosca accepted D26932: Prompt user when KWallet is disabled.
Feb 7 2020, 5:06 PM · Falkon
drosca requested changes to D26932: Prompt user when KWallet is disabled.
Feb 7 2020, 2:28 PM · Falkon

Feb 3 2020

drosca added inline comments to D27095: SearchBar - Show number of matches found on page search.
Feb 3 2020, 6:57 AM · Falkon
drosca added inline comments to D27095: SearchBar - Show number of matches found on page search.
Feb 3 2020, 6:56 AM · Falkon

Feb 2 2020

drosca accepted D27102: Autotests Qml - fix compilation with Qt 5.9.
Feb 2 2020, 5:13 PM · Falkon
drosca requested changes to D27095: SearchBar - Show number of matches found on page search.
Feb 2 2020, 5:13 PM · Falkon

Feb 1 2020

drosca accepted D27081: Speeddial: decode initialScript data as Utf8.
Feb 1 2020, 7:27 AM · Falkon

Jan 29 2020

drosca requested changes to D26932: Prompt user when KWallet is disabled.
Jan 29 2020, 2:34 PM · Falkon

Jan 24 2020

drosca accepted D26872: Fix crash when KWallet is not available..
Jan 24 2020, 12:53 PM · Falkon

Jan 23 2020

drosca added a comment to D26872: Fix crash when KWallet is not available..

In such case it should be totally rethought since the false can be triggered also by not having write permissions.

Jan 23 2020, 5:10 PM · Falkon
drosca requested changes to D26872: Fix crash when KWallet is not available..
Jan 23 2020, 4:57 PM · Falkon
drosca requested changes to D26872: Fix crash when KWallet is not available..

This check should be in every place where m_wallet is being used.

Jan 23 2020, 3:38 PM · Falkon

Jan 13 2020

drosca accepted D25860: [plasmoid] Show device battery percentage.
Jan 13 2020, 12:08 PM · Plasma
drosca accepted D26120: [Wizard] Show notification instead of finished page when pairing succeeds.
Jan 13 2020, 12:02 PM · Plasma

Jan 5 2020

drosca accepted D26436: GreaseMonkey: Fix detecting *.user.js urls.
Jan 5 2020, 4:40 PM · Falkon

Dec 18 2019

drosca accepted D25992: [Wizard] Allow choosing device by double click.
Dec 18 2019, 10:17 AM · Plasma

Dec 14 2019

drosca accepted D26007: Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate.
Dec 14 2019, 9:42 PM · Falkon

Dec 13 2019

drosca accepted D25911: Fix lupdate warnings.
Dec 13 2019, 1:31 PM · Falkon
drosca accepted D25859: Add Battery1 interface.
Dec 13 2019, 1:30 PM · Frameworks

Nov 19 2019

drosca accepted D25383: Remove some unused includes.
Nov 19 2019, 9:02 AM · Plasma

Nov 9 2019

drosca added a comment to T12001: Phabrikator is losing ownership on contributions.

I did use arc patch Dxxx to get the commit, but I didn't notice the ownership was wrong. This happens if you manually upload the patch to website instead of using arc utility. Yes, it's a stupid feature of phabricator, and I forgot about it unfortunately. Sorry.

Nov 9 2019, 7:46 PM · Phabricator

Oct 31 2019

drosca committed R875:2d5bf8d45fe0: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Oct 31 2019, 10:24 AM
drosca committed R875:8f2cf8611723: Set current tab as parent for duplicated tab (authored by SGOrava).
Set current tab as parent for duplicated tab
Oct 31 2019, 10:10 AM
drosca closed D24967: CookieManager: Add support for selecting more than one cookie at once.
Oct 31 2019, 10:10 AM · Falkon
drosca committed R875:7b404e73a84d: CookieManager: Add support for selecting more than one cookie at once (authored by drosca).
CookieManager: Add support for selecting more than one cookie at once
Oct 31 2019, 10:10 AM
drosca closed D24933: Set current tab as parent for duplicated tab.
Oct 31 2019, 10:10 AM · Falkon
drosca committed R875:bfb9420cbb8e: PyFalkon: Fix C linkage issues (authored by drosca).
PyFalkon: Fix C linkage issues
Oct 31 2019, 10:10 AM
drosca accepted D24967: CookieManager: Add support for selecting more than one cookie at once.
Oct 31 2019, 9:14 AM · Falkon
drosca accepted D24933: Set current tab as parent for duplicated tab.
Oct 31 2019, 9:13 AM · Falkon

Sep 16 2019

drosca accepted D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method..
Sep 16 2019, 12:46 PM · Frameworks

Aug 24 2019

drosca accepted D21770: Added QLoggingCategory to Falkon.
Aug 24 2019, 2:56 PM · Falkon

Aug 6 2019

drosca accepted D22961: [Microphone Indicator] Don't show if there are no microphones.
Aug 6 2019, 8:14 AM · Plasma

Jul 12 2019

drosca accepted D20834: Remove the padding of the bookmark bar.
Jul 12 2019, 2:17 PM · Falkon

Jul 9 2019

drosca added a comment to D22346: Should we install bluezqt_dbustypes.h?.

Sorry, that slipped in the review.

Jul 9 2019, 5:28 PM · Frameworks
drosca committed R269:185e2c70331f: Don't include bluezqt_dbustypes.h from installed headers (authored by drosca).
Don't include bluezqt_dbustypes.h from installed headers
Jul 9 2019, 5:27 PM
drosca committed R269:840979094a36: Fix compiler warnings (authored by drosca).
Fix compiler warnings
Jul 9 2019, 5:27 PM

Jun 28 2019

drosca accepted D22107: Add MediaTransport API.
Jun 28 2019, 8:29 AM · Frameworks

Jun 27 2019

drosca requested changes to D22107: Add MediaTransport API.
Jun 27 2019, 5:45 AM · Frameworks

Jun 10 2019

drosca committed R875:dfb3d2357d21: Vertical Tabs: Add child tab with middle click on "New Tab" button (authored by SGOrava).
Vertical Tabs: Add child tab with middle click on "New Tab" button
Jun 10 2019, 10:08 AM
drosca committed R875:493421dd843e: RunAction: Fix string conversion from bytestring, correct codestyle (authored by SGOrava).
RunAction: Fix string conversion from bytestring, correct codestyle
Jun 10 2019, 10:08 AM
drosca closed D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 10 2019, 10:08 AM · Falkon
drosca closed D21718: RunAction: Fix string conversion from bytestring, correct codestyle.
Jun 10 2019, 10:08 AM · Falkon
drosca accepted D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 10 2019, 10:06 AM · Falkon
drosca accepted D21718: RunAction: Fix string conversion from bytestring, correct codestyle.
Jun 10 2019, 10:04 AM · Falkon

Jun 9 2019

drosca requested changes to D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 9 2019, 10:07 AM · Falkon
drosca requested changes to D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 9 2019, 7:47 AM · Falkon

Jun 7 2019

drosca added a comment to D21584: Add LE Advertising and GATT APIs.

What is the net effect of this patch? What does it improve?

Jun 7 2019, 4:19 PM · Frameworks
drosca accepted D21584: Add LE Advertising and GATT APIs.
Jun 7 2019, 2:42 PM · Frameworks
drosca requested changes to D21584: Add LE Advertising and GATT APIs.

After this, it should be good to go.

Jun 7 2019, 8:10 AM · Frameworks

Jun 6 2019

drosca requested changes to D21584: Add LE Advertising and GATT APIs.

It seems you uploaded only diff with latest changes, you need to upload the entire diff against master.

Jun 6 2019, 6:18 AM · Frameworks

Jun 5 2019

drosca requested changes to D21584: Add LE Advertising and GATT APIs.

Looks really good!

Jun 5 2019, 7:47 AM · Frameworks

Jun 3 2019

drosca committed R875:4b85dab3d7fa: Vertical tabs: Draw unloaded tabs with "Disabled" color palette (authored by drosca).
Vertical tabs: Draw unloaded tabs with "Disabled" color palette
Jun 3 2019, 3:43 PM
drosca closed D21548: Vertical tabs: Draw unloaded tabs with "Disabled" color palette.
Jun 3 2019, 3:43 PM · Falkon
drosca accepted D21548: Vertical tabs: Draw unloaded tabs with "Disabled" color palette.
Jun 3 2019, 3:42 PM · Falkon

Jun 1 2019

drosca committed R875:107e75b4690f: Hello Python: Remove semicolons from sidebar.py (E703) (authored by drosca).
Hello Python: Remove semicolons from sidebar.py (E703)
Jun 1 2019, 8:28 AM
drosca committed R875:721d20336636: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Jun 1 2019, 8:28 AM
drosca closed D21386: Hello Python: Remove semicolons from sidebar.py (E703).
Jun 1 2019, 8:28 AM · Falkon

May 31 2019

drosca accepted D21511: Make falkon icon a real SVG.
May 31 2019, 1:08 PM · Frameworks
drosca accepted D21265: Add Bluez API to DBus XML parser/generator.
May 31 2019, 10:15 AM · Frameworks

May 30 2019

drosca added a comment to D21265: Add Bluez API to DBus XML parser/generator.

How different is the C++ generator from qdbusxml2cpp?

May 30 2019, 10:14 AM · Frameworks

May 28 2019

drosca added inline comments to D21265: Add Bluez API to DBus XML parser/generator.
May 28 2019, 2:12 PM · Frameworks

May 24 2019

drosca committed R875:307547749291: IconProvider: Add mutex around icon cache (authored by drosca).
IconProvider: Add mutex around icon cache
May 24 2019, 7:48 PM
drosca accepted D21382: Cancel helper when agent is canceled.
May 24 2019, 1:47 PM · Plasma

May 20 2019

drosca committed R875:2098d69ad1e0: PyFalkon: Fix build with clang (authored by drosca).
PyFalkon: Fix build with clang
May 20 2019, 1:22 PM
drosca closed D21304: VerticalTabs: Corectly recognize tree collapse / expand button.
May 20 2019, 1:22 PM · Falkon
drosca committed R875:fb09c266a71d: VerticalTabs: Corectly recognize tree collapse / expand button (authored by drosca).
VerticalTabs: Corectly recognize tree collapse / expand button
May 20 2019, 1:22 PM
drosca committed R875:bb8a3a799f65: RunAction plugin: set alternatingRowColors for listWidget (authored by drosca).
RunAction plugin: set alternatingRowColors for listWidget
May 20 2019, 1:22 PM
drosca closed D21227: RunAction plugin: set alternatingRowColors for listWidget.
May 20 2019, 1:22 PM · Falkon
drosca accepted D21304: VerticalTabs: Corectly recognize tree collapse / expand button.
May 20 2019, 1:02 PM · Falkon
drosca requested changes to D21265: Add Bluez API to DBus XML parser/generator.

Please use KDE coding style - https://community.kde.org/Policies/Kdelibs_Coding_Style

May 20 2019, 12:47 PM · Frameworks
drosca added a comment to T10810: New store category for Falkon.

Yes, everything works now. Thanks!

May 20 2019, 12:45 PM · KDE Store

May 15 2019

drosca accepted D21227: RunAction plugin: set alternatingRowColors for listWidget.
May 15 2019, 3:36 PM · Falkon

May 13 2019

drosca accepted D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI.
May 13 2019, 3:01 PM · Plasma

May 9 2019

drosca accepted D21087: Fix name and set desktop entry for notifications.
May 9 2019, 6:12 AM · Falkon

May 6 2019

drosca accepted D21048: There's no virtual sources, just source outputs.
May 6 2019, 3:34 PM · Plasma
drosca accepted D20871: Don't delete profiles and ports on update.
May 6 2019, 3:34 PM · Plasma
drosca accepted D21047: [Microphone Indicator] Schedule update initially.
May 6 2019, 3:27 PM · Plasma
drosca accepted D21045: Don't play sound when muting.
May 6 2019, 8:47 AM · Plasma

May 1 2019

drosca added a comment to T10810: New store category for Falkon.

I'm sorry it took that long, it should be ready now: https://phabricator.kde.org/R896:020b830f06d841cf801bf189c875a8e8e95d1c5a

May 1 2019, 7:51 AM · KDE Store

Apr 30 2019

drosca accepted D20915: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed.
Apr 30 2019, 10:46 AM · Plasma

Apr 29 2019

drosca accepted D19994: Add microphone indicator.
Apr 29 2019, 5:11 PM · Plasma

Apr 28 2019

drosca accepted D20872: Use override.
Apr 28 2019, 2:34 PM · Plasma

Apr 27 2019

drosca added a comment to D20834: Remove the padding of the bookmark bar.

Did you test with other Qt styles (fusion, windows, ...) ?

Apr 27 2019, 5:38 AM · Falkon

Apr 23 2019

drosca committed R875:7ddb3b898564: WIP: Shared QML engine for plugins (authored by drosca).
WIP: Shared QML engine for plugins
Apr 23 2019, 8:39 AM

Apr 22 2019

drosca committed R875:2cce43a1c389: plugins: Port to KI18n (authored by drosca).
plugins: Port to KI18n
Apr 22 2019, 1:11 PM