drosca (David Rosca)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (157 w, 4 d)
Availability
Available

Recent Activity

Yesterday

drosca added a comment to D7724: [ListItemBase] Open options menu on right click.

Should we go for it or abandon this?

Tue, Apr 24, 3:18 PM · Plasma

Sun, Apr 22

drosca committed R875:a5ba6df96669: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sun, Apr 22, 4:55 PM
drosca committed R875:ad2466f2faf5: WebView: Fix finding correct rwhvqt (authored by drosca).
WebView: Fix finding correct rwhvqt
Sun, Apr 22, 4:55 PM
drosca committed R875:1290354f1476: Use QOverload::of instead of qOverload (authored by drosca).
Use QOverload::of instead of qOverload
Sun, Apr 22, 2:51 PM
drosca committed R875:452d332cfde1: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sun, Apr 22, 2:11 PM
drosca committed R875:af89a1b8d4de: WebViewTest: Adjust expected loadFinished signal count (authored by drosca).
WebViewTest: Adjust expected loadFinished signal count
Sun, Apr 22, 2:11 PM
drosca committed R875:f61a957ca0b2: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sun, Apr 22, 1:54 PM
drosca committed R875:9f0817ca7180: WebView: Fix finding rwhvqt with QtWebEngine 5.11 (authored by drosca).
WebView: Fix finding rwhvqt with QtWebEngine 5.11
Sun, Apr 22, 1:54 PM
drosca committed R875:1d74b41420ec: WebView: Don't prevent tabbing out of webview with QtWebEngine 5.11 (authored by drosca).
WebView: Don't prevent tabbing out of webview with QtWebEngine 5.11
Sun, Apr 22, 1:54 PM
drosca committed R875:53919ce9de49: CookieJar: Clear filter function in destructor (authored by drosca).
CookieJar: Clear filter function in destructor
Sun, Apr 22, 1:54 PM

Thu, Apr 19

drosca accepted D12356: Move volume constants into functions.

Yeah, sorry, it would actually build, but it wouldn't do what you wanted.

Thu, Apr 19, 5:32 PM · Plasma
drosca requested changes to D12356: Move volume constants into functions.

Yes, that's what I had in mind. But please make it build (MinimalVolume in header vs minimalVolume in source).

Thu, Apr 19, 4:34 PM · Plasma
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

.h

static const int NormalVolume;
Thu, Apr 19, 6:29 AM · Plasma, KDE Connect, Frameworks

Wed, Apr 18

drosca committed R875:8034ace416d6: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Wed, Apr 18, 8:16 AM
drosca committed R875:30f5cd2d7e40: SpeedDial: Allow to save settings when there are no pages (authored by drosca).
SpeedDial: Allow to save settings when there are no pages
Wed, Apr 18, 8:16 AM
drosca committed R875:82a9c398a649: AutoSaver: Save when app is about to quit (authored by drosca).
AutoSaver: Save when app is about to quit
Wed, Apr 18, 8:16 AM

Fri, Apr 13

drosca requested changes to D12096: Added feature to remember the zoom set on a host.

I don't see why this is called DefaultZoomManager when it doesn't change default zoom, but it changes current zoom for pages.

Fri, Apr 13, 8:03 AM · Falkon

Thu, Apr 12

drosca accepted D12142: Drop wayland support.
Thu, Apr 12, 10:52 AM

Wed, Apr 11

drosca committed R875:62334cf8abe5: added missing icons in menus (authored by anmolgautam).
added missing icons in menus
Wed, Apr 11, 4:36 PM
drosca closed D12104: added missing icons in menus.
Wed, Apr 11, 4:36 PM · Falkon
drosca committed R875:751ef3988dc3: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Wed, Apr 11, 4:35 PM
drosca committed R875:17d45d718cb2: WebPage: Use load finished workaround unconditionally (authored by drosca).
WebPage: Use load finished workaround unconditionally
Wed, Apr 11, 4:35 PM
drosca accepted D12104: added missing icons in menus.
Wed, Apr 11, 4:35 PM · Falkon
drosca committed R875:8d1a8671ea4b: IconProvider: Add memory cache for imageForUrl (authored by drosca).
IconProvider: Add memory cache for imageForUrl
Wed, Apr 11, 4:31 PM
drosca committed R875:977bce9886c4: IconProvider: Use SqlQueryJob to save icons to database (authored by drosca).
IconProvider: Use SqlQueryJob to save icons to database
Wed, Apr 11, 4:31 PM
drosca committed R875:8a5c69b8a1d7: Add SqlQueryJob to run queries on separate thread (authored by drosca).
Add SqlQueryJob to run queries on separate thread
Wed, Apr 11, 4:31 PM
drosca committed R875:e61352c70cac: History: Use SqlQueryJob when adding history entry (authored by drosca).
History: Use SqlQueryJob when adding history entry
Wed, Apr 11, 4:31 PM

Tue, Apr 10

drosca accepted D12083: Show OSD when default output changes.
Tue, Apr 10, 12:27 PM · Plasma
drosca requested changes to D12083: Show OSD when default output changes.
Tue, Apr 10, 10:53 AM · Plasma

Sun, Apr 8

drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

I've made some changes that I wrote about in last comment.

Sun, Apr 8, 2:39 PM · Plasma, KDE Connect, Frameworks
drosca committed R994:03d820d4ef73: Add test utility - painspector (authored by drosca).
Add test utility - painspector
Sun, Apr 8, 2:34 PM
drosca committed R994:043c65a6b26a: Make constructors private where appropriate (authored by drosca).
Make constructors private where appropriate
Sun, Apr 8, 2:34 PM
drosca committed R994:33e3fe851395: Context: Pass ContextPrivate to all callbacks (authored by drosca).
Context: Pass ContextPrivate to all callbacks
Sun, Apr 8, 2:34 PM
drosca committed R994:76d9e2a50982: Make d-ptr private (authored by drosca).
Make d-ptr private
Sun, Apr 8, 2:34 PM
drosca committed R994:284aba67f982: Use full type in lists and replace QList -> QVector (authored by drosca).
Use full type in lists and replace QList -> QVector
Sun, Apr 8, 2:34 PM

Fri, Apr 6

drosca added a comment to D11890: remove suggestion for duplicate search engine.

Either we should compare the contents of OpenSearch xml file to check if two search engines are the same (but those xml files are not stored in Falkon), or check the URL from which the OpenSearch file was downloaded (not stored either, but is easier to do).

Fri, Apr 6, 6:02 PM · Falkon
drosca committed R875:19684a73cf12: LocationBar: Update icon after requesting url load (authored by drosca).
LocationBar: Update icon after requesting url load
Fri, Apr 6, 4:51 PM
drosca committed R875:f6f54efc5965: Fix building PyFalkon tests (authored by drosca).
Fix building PyFalkon tests
Fri, Apr 6, 4:51 PM
drosca committed R875:6dc8624a93c3: LocationBar: Update icon after requesting url load (authored by drosca).
LocationBar: Update icon after requesting url load
Fri, Apr 6, 4:51 PM

Thu, Apr 5

drosca added a comment to D11890: remove suggestion for duplicate search engine.

It doesn't necessarily mean that two search engines are identical if they have same name.

Thu, Apr 5, 10:44 AM · Falkon

Wed, Apr 4

drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

I agree with Nicolas, if you want to use this library in KDE Connect asap, then it should be released as a standalone library first. I will go over the API and make changes where needed by the end of this week and then it should be ready I think.
After that, the boring work will have to be done for the first frameworks release.

Wed, Apr 4, 7:09 PM · Plasma, KDE Connect, Frameworks
drosca committed R256:378f0f43b207: Falkon: Use 5.10 runtime and fix icon (authored by drosca).
Falkon: Use 5.10 runtime and fix icon
Wed, Apr 4, 6:59 PM
drosca closed D11809: Falkon: Use 5.10 platform and fix icon.
Wed, Apr 4, 6:59 PM

Tue, Apr 3

drosca added a comment to T6857: Falkon Incubation.

I've updated the wiki page. The last thing is manifesto compliance, can we check this and finish the incubation?

Tue, Apr 3, 3:17 PM · Falkon

Mon, Apr 2

drosca committed R875:ec1c2c80312e: Plugins: Load KDE Frameworks Integration by default inside KDE session (authored by drosca).
Plugins: Load KDE Frameworks Integration by default inside KDE session
Mon, Apr 2, 1:07 PM
drosca committed R875:daf5be1dbae4: Enable KWallet passwords backend by default inside KDE session (authored by drosca).
Enable KWallet passwords backend by default inside KDE session
Mon, Apr 2, 1:07 PM
drosca committed R875:fb95cc81d608: Add support for Drag (on) and Drop (off) the bookmark toolbar (authored by anmolgautam).
Add support for Drag (on) and Drop (off) the bookmark toolbar
Mon, Apr 2, 8:14 AM
drosca closed D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Mon, Apr 2, 8:14 AM · Falkon
drosca accepted D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Mon, Apr 2, 8:13 AM · Falkon

Sat, Mar 31

drosca committed R875:c09b6f632cb6: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sat, Mar 31, 3:18 PM
drosca committed R875:f10ef7d0aa1e: AdBlock: Open AdBlock dialog with plugin settings button (authored by drosca).
AdBlock: Open AdBlock dialog with plugin settings button
Sat, Mar 31, 3:18 PM
drosca committed R875:b6fa82aa8ebe: DownloadManager: Don't try to close not restored tabs (authored by drosca).
DownloadManager: Don't try to close not restored tabs
Sat, Mar 31, 3:18 PM
drosca committed R875:96f17baa46d7: Rename KDESupport -> KDEFrameworksIntegration plugin (authored by drosca).
Rename KDESupport -> KDEFrameworksIntegration plugin
Sat, Mar 31, 2:56 PM
drosca committed R875:05fa1338d802: KDESupport: Use KCrash for crash reporting (authored by drosca).
KDESupport: Use KCrash for crash reporting
Sat, Mar 31, 2:56 PM
drosca committed R875:05772edbeecb: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sat, Mar 31, 1:49 PM
drosca committed R875:7c078ad70eda: ProfileManager: Implement profile migration from QupZilla (authored by drosca).
ProfileManager: Implement profile migration from QupZilla
Sat, Mar 31, 1:49 PM
drosca committed R875:3dae3edff5e7: QzTools: Add copyRecursively and removeRecursively (authored by drosca).
QzTools: Add copyRecursively and removeRecursively
Sat, Mar 31, 1:49 PM
drosca requested changes to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.

Asserts when trying to drop bookmark on free space at the end of toolbar.

Sat, Mar 31, 10:44 AM · Falkon
drosca committed R875:b0b4b2b2683f: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sat, Mar 31, 10:18 AM
drosca committed R875:93af3896ee8a: WebView: Use direct url download when contents is not web page (authored by drosca).
WebView: Use direct url download when contents is not web page
Sat, Mar 31, 10:18 AM
drosca committed R875:d7dc9ba9f6df: WebView: Don't show "Show image" action when showing image (authored by drosca).
WebView: Don't show "Show image" action when showing image
Sat, Mar 31, 10:18 AM
drosca committed R875:94e1421d3086: DownloadManager: Set default download path to Downloads folder (authored by drosca).
DownloadManager: Set default download path to Downloads folder
Sat, Mar 31, 10:18 AM
drosca requested changes to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Sat, Mar 31, 9:27 AM · Falkon
drosca committed R994:ab2e711953d9: AbstractModel: Check if index is valid in setData (authored by drosca).
AbstractModel: Check if index is valid in setData
Sat, Mar 31, 8:21 AM
drosca committed R115:d6d7090c8a9c: Merge branch 'Plasma/5.12' (authored by drosca).
Merge branch 'Plasma/5.12'
Sat, Mar 31, 8:14 AM
drosca committed R115:0284a425f3db: AbstractModel: Check if index is valid in setData (authored by drosca).
AbstractModel: Check if index is valid in setData
Sat, Mar 31, 8:14 AM
drosca closed D11807: AbstractModel: Check if index is valid in setData.
Sat, Mar 31, 8:14 AM · Plasma
drosca requested changes to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Sat, Mar 31, 8:04 AM · Falkon

Fri, Mar 30

drosca requested review of D11809: Falkon: Use 5.10 platform and fix icon.
Fri, Mar 30, 4:34 PM
drosca committed R875:fc6f6cddd203: Fix focus and move cursor to end in SpeedDial (authored by anmolgautam).
Fix focus and move cursor to end in SpeedDial
Fri, Mar 30, 3:34 PM
drosca closed D11765: fixed focus and move cursor to end in sd.
Fri, Mar 30, 3:34 PM · Falkon
drosca committed R875:eb0977445572: Add Q_OBJECT to StatusBar and TipLabel (authored by drosca).
Add Q_OBJECT to StatusBar and TipLabel
Fri, Mar 30, 3:34 PM
drosca accepted D11765: fixed focus and move cursor to end in sd.
Fri, Mar 30, 3:33 PM · Falkon
drosca updated the task description for T8372: Windows builds.
Fri, Mar 30, 2:43 PM · Falkon
drosca triaged T8372: Windows builds as Normal priority.
Fri, Mar 30, 2:33 PM · Falkon
drosca requested review of D11807: AbstractModel: Check if index is valid in setData.
Fri, Mar 30, 2:17 PM · Plasma
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Do you have any more API changes in mind?

Fri, Mar 30, 12:27 PM · Plasma, KDE Connect, Frameworks
drosca added a comment to D11765: fixed focus and move cursor to end in sd.

Can you please describe what is the issue there? Better commit message should be enough.

Fri, Mar 30, 10:47 AM · Falkon
drosca requested changes to D11328: Added check for duplicate bookmarks.
Fri, Mar 30, 10:45 AM · Falkon
drosca added inline comments to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Fri, Mar 30, 10:43 AM · Falkon
drosca committed R875:6f9e6c540544: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Fri, Mar 30, 7:48 AM
drosca committed R875:525b929d38cd: Remove favicons from browsedata.sql (authored by drosca).
Remove favicons from browsedata.sql
Fri, Mar 30, 7:48 AM
drosca committed R875:04341b0981e9: Change homepage to falkon.org (authored by drosca).
Change homepage to falkon.org
Fri, Mar 30, 7:47 AM
drosca committed R875:b03e79f9a5e5: LocationBar: Only complete domain when not empty (authored by drosca).
LocationBar: Only complete domain when not empty
Fri, Mar 30, 7:47 AM

Thu, Mar 29

drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Just link errors, fixed now. Maybe we should just build static library for tests, like NetworkManagerQt is doing.

Thu, Mar 29, 12:32 PM · Plasma, KDE Connect, Frameworks
drosca committed R994:15b36f60eb49: Use d-ptr MapBase also for Module (authored by drosca).
Use d-ptr MapBase also for Module
Thu, Mar 29, 12:31 PM
drosca committed R994:674530cf345d: Context: Add getters and signals for all object collections (authored by drosca).
Context: Add getters and signals for all object collections
Thu, Mar 29, 11:30 AM
drosca committed R994:fc95b5aed8f4: Don't include maps.h in public headers (authored by drosca).
Don't include maps.h in public headers
Thu, Mar 29, 10:27 AM
drosca committed R994:41c3fb9f6393: Get rid of duplicated maps_dptr (authored by drosca).
Get rid of duplicated maps_dptr
Thu, Mar 29, 10:23 AM
drosca committed R994:32722f7afde4: Rewrite Maps to use QHash + QVector (authored by drosca).
Rewrite Maps to use QHash + QVector
Thu, Mar 29, 10:23 AM
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

I was trying to get rid of the maps.h by replacing it with a QMap, but it proved tough. Is there any reason for the API user to know the indices? If not, a QList should be sufficient.

Thu, Mar 29, 9:33 AM · Plasma, KDE Connect, Frameworks
drosca committed R994:04b3b62e921c: Maps: Don't use keys() and instead directly iterate QMap (authored by drosca).
Maps: Don't use keys() and instead directly iterate QMap
Thu, Mar 29, 9:05 AM

Wed, Mar 28

drosca committed R875:d329db7a08c2: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Wed, Mar 28, 4:58 PM
drosca committed R875:2f6cd7a559b5: LocationBar: Fix resolving correct LoadAction when url contains %20 (authored by drosca).
LocationBar: Fix resolving correct LoadAction when url contains %20
Wed, Mar 28, 4:58 PM
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Yes, it doesn't make sense here - it should stay only in plasma-pa. Removed now.

Wed, Mar 28, 4:16 PM · Plasma, KDE Connect, Frameworks
drosca committed R994:eb6d0d66cf73: MapsTest: Add basicTest and pendingRemovalsTest (authored by drosca).
MapsTest: Add basicTest and pendingRemovalsTest
Wed, Mar 28, 4:11 PM
drosca committed R994:6303b615dd52: Use org.kde.pulseaudio logging category (authored by drosca).
Use org.kde.pulseaudio logging category
Wed, Mar 28, 3:33 PM
drosca committed R994:55f4efee02d4: Unexport Maps (authored by drosca).
Unexport Maps
Wed, Mar 28, 3:33 PM
drosca committed R994:8c5c0989ecee: Remove ModuleManager and GConfItem (authored by drosca).
Remove ModuleManager and GConfItem
Wed, Mar 28, 3:33 PM
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Alright, would be great if you push only code that builds. I know that it is very very WIP, but still. Also please follow KDE code style (eg. Pointer *d, not Pointer* d) and fix your text editor to strip trailing whitespace (git will also highlight this in diff).

Wed, Mar 28, 2:54 PM · Plasma, KDE Connect, Frameworks