drosca (David Rosca)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (191 w, 3 d)
Availability
Available

Recent Activity

Thu, Dec 13

drosca closed D17568: Fixed Markdown headlines in readme.
Thu, Dec 13, 6:01 PM · Falkon
drosca committed R875:8a06d38f3ff4: Fixed Markdown headlines in readme (authored by janpr).
Fixed Markdown headlines in readme
Thu, Dec 13, 6:01 PM
drosca accepted D17568: Fixed Markdown headlines in readme.
Thu, Dec 13, 5:22 PM · Falkon

Wed, Dec 12

drosca added a comment to D17422: Falkon inserts incorrect history `count` data in sql.

If by incorrect history count you mean that one page load results in counter incrementing by 2 instead of 1 then it is actually side-effect of this workaround: https://cgit.kde.org/falkon.git/tree/src/lib/webengine/webpage.cpp#n106

Wed, Dec 12, 8:07 PM · Falkon
drosca closed D13385: Fix #394905.

https://cgit.kde.org/falkon.git/commit/?id=29fbbf5dc4cc55102752e20d1f85cbd49ee7333a

Wed, Dec 12, 8:03 PM · Falkon, Windows
drosca added a comment to D11890: remove suggestion for duplicate search engine.

Shall we abandon this request?

Wed, Dec 12, 7:40 PM · Falkon
drosca accepted D14930: Create new bookmark items near the current one (over it).
Wed, Dec 12, 7:34 PM · Falkon
drosca committed R875:4ff7ccc73782: Don't include qmlpluginloader.h in plugin.sh (authored by drosca).
Don't include qmlpluginloader.h in plugin.sh
Wed, Dec 12, 6:05 PM
drosca added a reverting change for R875:3ea935b1439a: Fix PyFalkon build: R875:eefd9cd0464b: Revert "Fix PyFalkon build".
Wed, Dec 12, 6:05 PM
drosca committed R875:eefd9cd0464b: Revert "Fix PyFalkon build" (authored by drosca).
Revert "Fix PyFalkon build"
Wed, Dec 12, 6:05 PM
drosca committed R875:3ea935b1439a: Fix PyFalkon build (authored by drosca).
Fix PyFalkon build
Wed, Dec 12, 6:03 PM
drosca committed R875:d25c34901c94: Use QTWEBENGINEWIDGETS_VERSION for determining QtWebEngine version (authored by drosca).
Use QTWEBENGINEWIDGETS_VERSION for determining QtWebEngine version
Wed, Dec 12, 6:03 PM

Sun, Dec 9

drosca accepted D17288: Fix hardcoded private browsing icon.
Sun, Dec 9, 7:31 PM · Falkon
drosca added a comment to D17419: Add view-private icon.

Ah yeah, I guess that makes sense.

Falkon folks, is this acceptable?

Sun, Dec 9, 6:56 PM · VDG, Frameworks, Breeze

Sun, Dec 2

drosca accepted D17307: Fix unreadable Falkon logo text when using a dark theme.
Sun, Dec 2, 1:27 PM · Falkon
drosca added a comment to D17307: Fix unreadable Falkon logo text when using a dark theme.

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

Sun, Dec 2, 1:22 PM · Falkon
drosca accepted D17286: Enable page sharing.
Sun, Dec 2, 12:35 PM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

That's for discussion with Breeze devs.

Sun, Dec 2, 10:30 AM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

Then just use this icon, but make a symlink to private-mode.

Sun, Dec 2, 10:25 AM · Falkon
drosca added inline comments to D17286: Enable page sharing.
Sun, Dec 2, 10:09 AM · Falkon
drosca added a comment to D17286: Enable page sharing.

Looks good, but please use KDE/KF5 coding style - QMenu *menu.

Sun, Dec 2, 10:08 AM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

Yes, so there should be new icon in Breeze theme (eg. private-browsing or maybe better private-mode so it is more generic) and then Falkon can use it.

Sun, Dec 2, 10:07 AM · Falkon

Sat, Dec 1

drosca added a comment to D17288: Fix hardcoded private browsing icon.
In D17288#369538, @GB_2 wrote:

But it looks very similar the original one.
What other icon should it be?

Sat, Dec 1, 8:12 PM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

im-user has completely different meaning than "private browsing".

Sat, Dec 1, 8:09 PM · Falkon

Nov 13 2018

drosca added a comment to D16082: Notify headphone being plugged in on some hardware.

Maybe we could use a generic icon, or make a new one that depicts speakers plus headphones or something?

Nov 13 2018, 9:00 PM · Plasma

Nov 8 2018

drosca added a comment to D16082: Notify headphone being plugged in on some hardware.

So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack.

Nov 8 2018, 9:27 AM · Plasma
drosca added a comment to D16082: Notify headphone being plugged in on some hardware.

So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ?

Nov 8 2018, 9:07 AM · Plasma

Nov 4 2018

drosca committed R875:cda838a35ea2: Adblock uses outdated Spanish filters (Filtros Naucópicos) (authored by krishremya).
Adblock uses outdated Spanish filters (Filtros Naucópicos)
Nov 4 2018, 3:17 PM
drosca closed D16656: Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos).
Nov 4 2018, 3:17 PM · Falkon
drosca accepted D16656: Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos).

Looks good now, thanks. If you don't have dev account please send me your full name + email and I will commit it for you.

Nov 4 2018, 10:25 AM · Falkon
drosca requested changes to D16656: Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos).

This will change the default list (EasyList) to be Spanish variant for all users.
You should instead change the url to Spanish subscriptions in AdBlockAddSubscriptionDialog

Nov 4 2018, 9:10 AM · Falkon

Oct 27 2018

drosca accepted D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 27 2018, 6:01 AM · Plasma

Oct 24 2018

drosca closed D16238: Replace Qt foreach with C++ foreach.
Oct 24 2018, 3:21 PM · Falkon
drosca committed R875:c85f4f889422: Replace Qt foreach with C++ foreach (authored by pflynn).
Replace Qt foreach with C++ foreach
Oct 24 2018, 3:21 PM
drosca accepted D16238: Replace Qt foreach with C++ foreach.
Oct 24 2018, 3:16 PM · Falkon

Oct 23 2018

drosca committed R269:a65823a9aa43: Add Media and MediaEndpoint API header generation (authored by mweichselbaumer).
Add Media and MediaEndpoint API header generation
Oct 23 2018, 3:41 PM
drosca closed D16084: Add Media and MediaEndpoint API header generation.
Oct 23 2018, 3:41 PM · Frameworks
drosca requested changes to D16238: Replace Qt foreach with C++ foreach.

You should always use for on const Qt containers, as otherwise it will detach.
So it should be:

Oct 23 2018, 3:40 PM · Falkon
drosca accepted D16084: Add Media and MediaEndpoint API header generation.
Oct 23 2018, 3:38 PM · Frameworks

Oct 15 2018

drosca committed R875:a039da158ae4: Update to latest upstream QtSingleApplication (authored by drosca).
Update to latest upstream QtSingleApplication
Oct 15 2018, 6:40 PM
drosca committed R875:6d445edb44a8: Context menu for statusbar (authored by pflynn).
Context menu for statusbar
Oct 15 2018, 6:24 PM
drosca closed D16158: Context menu for statusbar.
Oct 15 2018, 6:24 PM · Falkon
drosca added a comment to D16158: Context menu for statusbar.

The patch doesn't apply:

INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16158.
Checking patch src/lib/other/statusbar.cpp...
error: while searching for:
void StatusBar::mousePressEvent(QMouseEvent *event)
{
    if (event->button()==Qt::RightButton) {
        QMenu *context = new QMenu;
        QAction *hide_bar = new QAction(tr("Hide"),this);
        connect(hide_bar,&QAction::triggered,m_window,&BrowserWindow::toggleShowStatusBar);
        context->addAction(hide_bar);
        context->exec(QCursor::pos());
    }
    QStatusBar::mousePressEvent(event);
error: patch failed: src/lib/other/statusbar.cpp:245
Applying patch src/lib/other/statusbar.cpp with 1 reject...
Rejected hunk #1.
Oct 15 2018, 4:24 PM · Falkon
drosca committed R875:907e2e49380d: Fix crash during download when the main window have been closed (authored by chcuris).
Fix crash during download when the main window have been closed
Oct 15 2018, 4:20 PM
drosca closed D14711: Fix crash during download when the main window have been closed.
Oct 15 2018, 4:20 PM · Falkon
drosca accepted D16158: Context menu for statusbar.

Your full name + email please, so I can push it for you.

Oct 15 2018, 4:17 PM · Falkon

Oct 12 2018

drosca requested changes to D16158: Context menu for statusbar.
Oct 12 2018, 3:38 PM · Falkon

Oct 4 2018

drosca committed R269:5f12404807cc: Implement Media and MediaEndpoint API (authored by mweichselbaumer).
Implement Media and MediaEndpoint API
Oct 4 2018, 6:29 PM
drosca closed D15745: Implement Media and MediaEndpoint API.
Oct 4 2018, 6:29 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Thanks.
I'll need your full name + e-mail if you don't have dev account to push it.

Oct 4 2018, 6:22 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Remove NoInputNoOutputAgent and it's good to go.

Agree. Is it ok to move it to mediaendpointconnector?

Oct 4 2018, 5:09 PM · Frameworks
drosca added a comment to D15930: Add more icons to actions.

These icon names are too specific and most likely only available in Breeze icon theme, so I don't think it should be used there.

Oct 4 2018, 5:08 PM · Falkon
drosca accepted D15745: Implement Media and MediaEndpoint API.

Remove NoInputNoOutputAgent and it's good to go.

Oct 4 2018, 4:42 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Alright, last thing:

Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway.

Yes, i also thought this should be application specific. However, i could not imagine another use case of a NoInputNoOutputAgent, except from doing auto connecting to a limited set of UUIDs. So, i thought it is generic enough to be part of the library.

Oct 4 2018, 4:28 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Alright, last thing:

Oct 4 2018, 3:36 PM · Frameworks
drosca accepted D14711: Fix crash during download when the main window have been closed.

Alright,
I'll need your full name + email to commit it for you.

Oct 4 2018, 7:51 AM · Falkon
drosca requested changes to D15745: Implement Media and MediaEndpoint API.
Oct 4 2018, 7:49 AM · Frameworks
drosca added a comment to D15827: [applet] Avoid showing a generic audio-card icon.

I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "input-volume" icons.

Oct 4 2018, 7:39 AM · Plasma
drosca accepted D15925: Add icon to Fullscreen action.
Oct 4 2018, 7:37 AM · Falkon
drosca accepted D15926: Add icon to Web Search action.
Oct 4 2018, 7:37 AM · Falkon

Oct 3 2018

drosca accepted D15921: Add icon to DownloadManager action.
Oct 3 2018, 2:32 PM · Falkon

Oct 1 2018

drosca accepted D15886: set resizeMode for QQuickWidget in sidebar.
Oct 1 2018, 7:20 PM · Falkon
drosca accepted D14519: Added HelloQml Extension.
Oct 1 2018, 6:19 PM · Falkon

Sep 29 2018

drosca accepted D15832: fixed build for qt versions < 5.11.

Translations should work on FreeBSD though, so please fix it another commit.

Sep 29 2018, 3:08 PM · Falkon
drosca requested changes to D15832: fixed build for qt versions < 5.11.

Also please fix build on FreeBSD: https://build.kde.org/job/Extragear/job/falkon/job/kf5-qt5%20FreeBSDQt5.11/6/console

Sep 29 2018, 2:23 PM · Falkon
drosca added a comment to D14774: Add QML Extensions API.

Build is broken now: https://build.kde.org/job/Extragear/job/falkon/

Sep 29 2018, 7:35 AM · Falkon

Sep 28 2018

drosca accepted D14774: Add QML Extensions API.
Sep 28 2018, 10:06 AM · Falkon

Sep 27 2018

drosca added a comment to D15304: [KCM] Port (almost) entirely to QQC2.

Plasma items should not be used in KCM.

Hmm, what you you recommend then for showing an icon item? The old QIconItem breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to import Kirigami.

I suggest to fix QIconItem, as it is used in other places too.

Sep 27 2018, 2:08 PM · Plasma
drosca closed D15751: Center content & banner.

It's now live at falkon.org

Sep 27 2018, 7:49 AM
drosca accepted D15751: Center content & banner.

Centered navigation looks bad.

Sep 27 2018, 7:44 AM
drosca added inline comments to D15304: [KCM] Port (almost) entirely to QQC2.
Sep 27 2018, 7:42 AM · Plasma
drosca added inline comments to D15745: Implement Media and MediaEndpoint API.
Sep 27 2018, 7:40 AM · Frameworks

Sep 26 2018

drosca requested changes to D15304: [KCM] Port (almost) entirely to QQC2.

There is ScrollView in QQC2 (since Qt 5.9), so please use it.
Also as @davidedmundson said, please edit the commit message.

Sep 26 2018, 2:56 PM · Plasma
drosca added a comment to D15751: Center content & banner.

Can you please also upload screenshot of page with blog post? Like https://www.falkon.org/2018/05/08/falkon-301-released/

Sep 26 2018, 2:48 PM
drosca accepted D15769: Show "muted" icon in panel and disable shortcuts for Dummy Output.
Sep 26 2018, 2:47 PM · Plasma

Sep 25 2018

drosca added inline comments to D15745: Implement Media and MediaEndpoint API.
Sep 25 2018, 3:42 PM · Frameworks
drosca requested changes to D15745: Implement Media and MediaEndpoint API.

Looks good apart from the coding style.
Also it would be great to have at least basic autotest.

Sep 25 2018, 1:29 PM · Frameworks

Sep 24 2018

drosca added inline comments to D14774: Add QML Extensions API.
Sep 24 2018, 2:18 PM · Falkon
drosca added inline comments to D14774: Add QML Extensions API.
Sep 24 2018, 8:10 AM · Falkon

Sep 23 2018

drosca added inline comments to D14774: Add QML Extensions API.
Sep 23 2018, 10:50 AM · Falkon

Sep 21 2018

drosca requested changes to D14774: Add QML Extensions API.
Sep 21 2018, 7:48 AM · Falkon

Sep 6 2018

drosca added a comment to D15304: [KCM] Port (almost) entirely to QQC2.

I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items.

Sep 6 2018, 6:24 AM · Plasma

Sep 2 2018

drosca requested changes to D14775: Added tests for QML Extension API.
Sep 2 2018, 8:37 PM · Falkon
drosca accepted D14519: Added HelloQml Extension.
Sep 2 2018, 8:33 PM · Falkon
drosca requested changes to D14774: Add QML Extensions API.
Sep 2 2018, 8:32 PM · Falkon

Sep 1 2018

drosca closed D15104: Add "Made by KDE" logo.

I do not have commit access, so unless somebody has any objections to this change I'd be glad if you could land it for me. Thanks!

Sep 1 2018, 7:18 AM

Aug 28 2018

drosca accepted D15104: Add "Made by KDE" logo.
Aug 28 2018, 8:51 AM

Aug 18 2018

drosca added inline comments to D14774: Add QML Extensions API.
Aug 18 2018, 12:01 PM · Falkon
drosca added inline comments to D14774: Add QML Extensions API.
Aug 18 2018, 5:44 AM · Falkon

Aug 17 2018

drosca added inline comments to D14774: Add QML Extensions API.
Aug 17 2018, 6:46 PM · Falkon
drosca added inline comments to D14774: Add QML Extensions API.
Aug 17 2018, 3:33 PM · Falkon
drosca requested changes to D14774: Add QML Extensions API.
Aug 17 2018, 7:22 AM · Falkon

Aug 12 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 12 2018, 9:35 AM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 12 2018, 6:15 AM · Falkon

Aug 11 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:56 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:27 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:15 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:08 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 3:45 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 3:17 PM · Falkon