User Details
User Details
- User Since
- Apr 18 2015, 6:08 AM (157 w, 4 d)
- Availability
- Available
Yesterday
Yesterday
drosca added a comment to D7724: [ListItemBase] Open options menu on right click.
Sun, Apr 22
Sun, Apr 22
Merge branch 'Falkon/3.0'
WebView: Fix finding correct rwhvqt
Use QOverload::of instead of qOverload
Merge branch 'Falkon/3.0'
drosca committed R875:af89a1b8d4de: WebViewTest: Adjust expected loadFinished signal count (authored by drosca).
WebViewTest: Adjust expected loadFinished signal count
Merge branch 'Falkon/3.0'
drosca committed R875:9f0817ca7180: WebView: Fix finding rwhvqt with QtWebEngine 5.11 (authored by drosca).
WebView: Fix finding rwhvqt with QtWebEngine 5.11
drosca committed R875:1d74b41420ec: WebView: Don't prevent tabbing out of webview with QtWebEngine 5.11 (authored by drosca).
WebView: Don't prevent tabbing out of webview with QtWebEngine 5.11
drosca committed R875:53919ce9de49: CookieJar: Clear filter function in destructor (authored by drosca).
CookieJar: Clear filter function in destructor
Thu, Apr 19
Thu, Apr 19
Yeah, sorry, it would actually build, but it wouldn't do what you wanted.
drosca requested changes to D12356: Move volume constants into functions.
Yes, that's what I had in mind. But please make it build (MinimalVolume in header vs minimalVolume in source).
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
.h
static const int NormalVolume;
Wed, Apr 18
Wed, Apr 18
Merge branch 'Falkon/3.0'
drosca committed R875:30f5cd2d7e40: SpeedDial: Allow to save settings when there are no pages (authored by drosca).
SpeedDial: Allow to save settings when there are no pages
AutoSaver: Save when app is about to quit
Fri, Apr 13
Fri, Apr 13
drosca requested changes to D12096: Added feature to remember the zoom set on a host.
I don't see why this is called DefaultZoomManager when it doesn't change default zoom, but it changes current zoom for pages.
Thu, Apr 12
Thu, Apr 12
Wed, Apr 11
Wed, Apr 11
added missing icons in menus
Merge branch 'Falkon/3.0'
drosca committed R875:17d45d718cb2: WebPage: Use load finished workaround unconditionally (authored by drosca).
WebPage: Use load finished workaround unconditionally
drosca committed R875:8d1a8671ea4b: IconProvider: Add memory cache for imageForUrl (authored by drosca).
IconProvider: Add memory cache for imageForUrl
drosca committed R875:977bce9886c4: IconProvider: Use SqlQueryJob to save icons to database (authored by drosca).
IconProvider: Use SqlQueryJob to save icons to database
drosca committed R875:8a5c69b8a1d7: Add SqlQueryJob to run queries on separate thread (authored by drosca).
Add SqlQueryJob to run queries on separate thread
drosca committed R875:e61352c70cac: History: Use SqlQueryJob when adding history entry (authored by drosca).
History: Use SqlQueryJob when adding history entry
Tue, Apr 10
Tue, Apr 10
drosca requested changes to D12083: Show OSD when default output changes.
Sun, Apr 8
Sun, Apr 8
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
I've made some changes that I wrote about in last comment.
Add test utility - painspector
drosca committed R994:043c65a6b26a: Make constructors private where appropriate (authored by drosca).
Make constructors private where appropriate
drosca committed R994:33e3fe851395: Context: Pass ContextPrivate to all callbacks (authored by drosca).
Context: Pass ContextPrivate to all callbacks
Make d-ptr private
drosca committed R994:284aba67f982: Use full type in lists and replace QList -> QVector (authored by drosca).
Use full type in lists and replace QList -> QVector
Fri, Apr 6
Fri, Apr 6
drosca added a comment to D11890: remove suggestion for duplicate search engine.
Either we should compare the contents of OpenSearch xml file to check if two search engines are the same (but those xml files are not stored in Falkon), or check the URL from which the OpenSearch file was downloaded (not stored either, but is easier to do).
drosca committed R875:19684a73cf12: LocationBar: Update icon after requesting url load (authored by drosca).
LocationBar: Update icon after requesting url load
Fix building PyFalkon tests
drosca committed R875:6dc8624a93c3: LocationBar: Update icon after requesting url load (authored by drosca).
LocationBar: Update icon after requesting url load
Thu, Apr 5
Thu, Apr 5
drosca added a comment to D11890: remove suggestion for duplicate search engine.
It doesn't necessarily mean that two search engines are identical if they have same name.
Wed, Apr 4
Wed, Apr 4
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
I agree with Nicolas, if you want to use this library in KDE Connect asap, then it should be released as a standalone library first. I will go over the API and make changes where needed by the end of this week and then it should be ready I think.
After that, the boring work will have to be done for the first frameworks release.
Falkon: Use 5.10 runtime and fix icon
Tue, Apr 3
Tue, Apr 3
drosca added a comment to T6857: Falkon Incubation.
I've updated the wiki page. The last thing is manifesto compliance, can we check this and finish the incubation?
Mon, Apr 2
Mon, Apr 2
drosca committed R875:ec1c2c80312e: Plugins: Load KDE Frameworks Integration by default inside KDE session (authored by drosca).
Plugins: Load KDE Frameworks Integration by default inside KDE session
drosca committed R875:daf5be1dbae4: Enable KWallet passwords backend by default inside KDE session (authored by drosca).
Enable KWallet passwords backend by default inside KDE session
drosca committed R875:fb95cc81d608: Add support for Drag (on) and Drop (off) the bookmark toolbar (authored by anmolgautam).
Add support for Drag (on) and Drop (off) the bookmark toolbar
Sat, Mar 31
Sat, Mar 31
Merge branch 'Falkon/3.0'
drosca committed R875:f10ef7d0aa1e: AdBlock: Open AdBlock dialog with plugin settings button (authored by drosca).
AdBlock: Open AdBlock dialog with plugin settings button
drosca committed R875:b6fa82aa8ebe: DownloadManager: Don't try to close not restored tabs (authored by drosca).
DownloadManager: Don't try to close not restored tabs
drosca committed R875:96f17baa46d7: Rename KDESupport -> KDEFrameworksIntegration plugin (authored by drosca).
Rename KDESupport -> KDEFrameworksIntegration plugin
drosca committed R875:05fa1338d802: KDESupport: Use KCrash for crash reporting (authored by drosca).
KDESupport: Use KCrash for crash reporting
Merge branch 'Falkon/3.0'
drosca committed R875:7c078ad70eda: ProfileManager: Implement profile migration from QupZilla (authored by drosca).
ProfileManager: Implement profile migration from QupZilla
drosca committed R875:3dae3edff5e7: QzTools: Add copyRecursively and removeRecursively (authored by drosca).
QzTools: Add copyRecursively and removeRecursively
drosca requested changes to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Asserts when trying to drop bookmark on free space at the end of toolbar.
Merge branch 'Falkon/3.0'
drosca committed R875:93af3896ee8a: WebView: Use direct url download when contents is not web page (authored by drosca).
WebView: Use direct url download when contents is not web page
drosca committed R875:d7dc9ba9f6df: WebView: Don't show "Show image" action when showing image (authored by drosca).
WebView: Don't show "Show image" action when showing image
drosca committed R875:94e1421d3086: DownloadManager: Set default download path to Downloads folder (authored by drosca).
DownloadManager: Set default download path to Downloads folder
drosca requested changes to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
drosca committed R994:ab2e711953d9: AbstractModel: Check if index is valid in setData (authored by drosca).
AbstractModel: Check if index is valid in setData
Merge branch 'Plasma/5.12'
drosca committed R115:0284a425f3db: AbstractModel: Check if index is valid in setData (authored by drosca).
AbstractModel: Check if index is valid in setData
drosca requested changes to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Fri, Mar 30
Fri, Mar 30
drosca requested review of D11809: Falkon: Use 5.10 platform and fix icon.
drosca committed R875:fc6f6cddd203: Fix focus and move cursor to end in SpeedDial (authored by anmolgautam).
Fix focus and move cursor to end in SpeedDial
Add Q_OBJECT to StatusBar and TipLabel
drosca updated the task description for T8372: Windows builds.
drosca requested review of D11807: AbstractModel: Check if index is valid in setData.
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
Do you have any more API changes in mind?
drosca added a comment to D11765: fixed focus and move cursor to end in sd.
Can you please describe what is the issue there? Better commit message should be enough.
drosca requested changes to D11328: Added check for duplicate bookmarks.
drosca added inline comments to D11664: added support for Drag (on) and Drop (off) the bookmark toolbar.
Merge branch 'Falkon/3.0'
Remove favicons from browsedata.sql
Change homepage to falkon.org
drosca committed R875:b03e79f9a5e5: LocationBar: Only complete domain when not empty (authored by drosca).
LocationBar: Only complete domain when not empty
Thu, Mar 29
Thu, Mar 29
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
Just link errors, fixed now. Maybe we should just build static library for tests, like NetworkManagerQt is doing.
Use d-ptr MapBase also for Module
drosca committed R994:674530cf345d: Context: Add getters and signals for all object collections (authored by drosca).
Context: Add getters and signals for all object collections
Don't include maps.h in public headers
Get rid of duplicated maps_dptr
Rewrite Maps to use QHash + QVector
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
I was trying to get rid of the maps.h by replacing it with a QMap, but it proved tough. Is there any reason for the API user to know the indices? If not, a QList should be sufficient.
drosca committed R994:04b3b62e921c: Maps: Don't use keys() and instead directly iterate QMap (authored by drosca).
Maps: Don't use keys() and instead directly iterate QMap
Wed, Mar 28
Wed, Mar 28
Merge branch 'Falkon/3.0'
drosca committed R875:2f6cd7a559b5: LocationBar: Fix resolving correct LoadAction when url contains %20 (authored by drosca).
LocationBar: Fix resolving correct LoadAction when url contains %20
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
Yes, it doesn't make sense here - it should stay only in plasma-pa. Removed now.
drosca committed R994:eb6d0d66cf73: MapsTest: Add basicTest and pendingRemovalsTest (authored by drosca).
MapsTest: Add basicTest and pendingRemovalsTest
Use org.kde.pulseaudio logging category
Unexport Maps
Remove ModuleManager and GConfItem
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
Alright, would be great if you push only code that builds. I know that it is very very WIP, but still. Also please follow KDE code style (eg. Pointer *d, not Pointer* d) and fix your text editor to strip trailing whitespace (git will also highlight this in diff).