In D29007#663905, @carewolf wrote:

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

QFile is closed in the destructor, this is not needed.

It should be <br/> instead.

Applet doesn't need the KDED module, it only talks with BlueZ directly. This is for stuff like bluetooth:// kio protocol and receiving files.

There shouldn't be more than one Falkon process sharing one profile. The only exception is the private process, that is using (should be) all profile data in read-only mode.

I don't really like, there is ton of duplicated code. Also coding style is wrong.

In D26872#599903, @SGOrava wrote:

In such case it should be totally rethought since the false can be triggered also by not having write permissions.

This check should be in every place where m_wallet is being used.

I did use arc patch Dxxx to get the commit, but I didn't notice the ownership was wrong. This happens if you manually upload the patch to website instead of using arc utility. Yes, it's a stupid feature of phabricator, and I forgot about it unfortunately. Sorry.

Sorry, that slipped in the review.

In D21584#475914, @ngraham wrote:

What is the net effect of this patch? What does it improve?

After this, it should be good to go.

It seems you uploaded only diff with latest changes, you need to upload the entire diff against master.

Looks really good!

How different is the C++ generator from qdbusxml2cpp?

Please use KDE coding style - https://community.kde.org/Policies/Kdelibs_Coding_Style

Yes, everything works now. Thanks!

I'm sorry it took that long, it should be ready now: https://phabricator.kde.org/R896:020b830f06d841cf801bf189c875a8e8e95d1c5a

Did you test with other Qt styles (fusion, windows, ...) ?