Take a look in src/plugins src/scripts

I meant that I don't want this feature. Context menu on page is already very long, and if it contained every action that someone requested on bugzilla, it would not even fit on screen.

As with similar actions, this should be in plugin (preferably only script) and not in main code.

Looks good now!

I don't really like that this port became full of workarounds to be honest, but if it works and there's no other way then fine.

In D15304#398048, @ngraham wrote:

Thanks for the approval, but the scrollviews still don't actually scroll when the window is too small to fit all the content! I haven't been able to figure out why this is yet, so help would be appreciated if you have the time. :)

In D17784#396418, @sharhalakis wrote:

Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity.

As I already wrote, it has to be added as new option.

Actually I myself am not really fan of closing only the window with Ctrl+Q, there is Alt+F4 for that.

Related patch to plasma-pa D16443

I think it would be better to edit the check only to contains("Glib") as it still makes sense to check for GLib event loop, as otherwise the code will just silently fail.

This doesn't fix anything.

If by incorrect history count you mean that one page load results in counter incrementing by 2 instead of 1 then it is actually side-effect of this workaround: https://cgit.kde.org/falkon.git/tree/src/lib/webengine/webpage.cpp#n106

https://cgit.kde.org/falkon.git/commit/?id=29fbbf5dc4cc55102752e20d1f85cbd49ee7333a

In D11890#376177, @cullmann wrote:

Shall we abandon this request?

In D17419#374064, @ngraham wrote:

Ah yeah, I guess that makes sense.

Falkon folks, is this acceptable?

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

That's for discussion with Breeze devs.

Then just use this icon, but make a symlink to private-mode.

Looks good, but please use KDE/KF5 coding style - QMenu *menu.

Yes, so there should be new icon in Breeze theme (eg. private-browsing or maybe better private-mode so it is more generic) and then Falkon can use it.

In D17288#369538, @GB_2 wrote:

But it looks very similar the original one.
What other icon should it be?

im-user has completely different meaning than "private browsing".

In D16082#359173, @ngraham wrote:

Maybe we could use a generic icon, or make a new one that depicts speakers plus headphones or something?

In D16082#356111, @thsurrel wrote:

So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack.

In D16082#356099, @thsurrel wrote:

So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ?

Looks good now, thanks. If you don't have dev account please send me your full name + email and I will commit it for you.

This will change the default list (EasyList) to be Spanish variant for all users.
You should instead change the url to Spanish subscriptions in AdBlockAddSubscriptionDialog

You should always use for on const Qt containers, as otherwise it will detach.
So it should be: