People drosca

drosca (David Rosca)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (226 w, 5 d)
Availability
Available

Recent Activity
View All

Tue, Aug 6

drosca accepted D22961: [Microphone Indicator] Don't show if there are no microphones.
Tue, Aug 6, 8:14 AM · Plasma

Jul 12 2019

drosca accepted D20834: Remove the padding of the bookmark bar.
Jul 12 2019, 2:17 PM · Falkon

Jul 9 2019

drosca added a comment to D22346: Should we install bluezqt_dbustypes.h?.

Sorry, that slipped in the review.

Jul 9 2019, 5:28 PM · Frameworks
drosca committed R269:185e2c70331f: Don't include bluezqt_dbustypes.h from installed headers (authored by drosca).
Don't include bluezqt_dbustypes.h from installed headers
Jul 9 2019, 5:27 PM
drosca committed R269:840979094a36: Fix compiler warnings (authored by drosca).
Fix compiler warnings
Jul 9 2019, 5:27 PM

Jun 28 2019

drosca accepted D22107: Add MediaTransport API.
Jun 28 2019, 8:29 AM · Frameworks

Jun 27 2019

drosca requested changes to D22107: Add MediaTransport API.
Jun 27 2019, 5:45 AM · Frameworks

Jun 10 2019

drosca committed R875:dfb3d2357d21: Vertical Tabs: Add child tab with middle click on "New Tab" button (authored by SGOrava).
Vertical Tabs: Add child tab with middle click on "New Tab" button
Jun 10 2019, 10:08 AM
drosca committed R875:493421dd843e: RunAction: Fix string conversion from bytestring, correct codestyle (authored by SGOrava).
RunAction: Fix string conversion from bytestring, correct codestyle
Jun 10 2019, 10:08 AM
drosca closed D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 10 2019, 10:08 AM · Falkon
drosca closed D21718: RunAction: Fix string conversion from bytestring, correct codestyle.
Jun 10 2019, 10:08 AM · Falkon
drosca accepted D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 10 2019, 10:06 AM · Falkon
drosca accepted D21718: RunAction: Fix string conversion from bytestring, correct codestyle.
Jun 10 2019, 10:04 AM · Falkon

Jun 9 2019

drosca requested changes to D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 9 2019, 10:07 AM · Falkon
drosca requested changes to D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button.
Jun 9 2019, 7:47 AM · Falkon

Jun 7 2019

drosca added a comment to D21584: Add LE Advertising and GATT APIs.
In D21584#475914, @ngraham wrote:

What is the net effect of this patch? What does it improve?

Jun 7 2019, 4:19 PM · Frameworks
drosca accepted D21584: Add LE Advertising and GATT APIs.
Jun 7 2019, 2:42 PM · Frameworks
drosca requested changes to D21584: Add LE Advertising and GATT APIs.

After this, it should be good to go.

Jun 7 2019, 8:10 AM · Frameworks

Jun 6 2019

drosca requested changes to D21584: Add LE Advertising and GATT APIs.

It seems you uploaded only diff with latest changes, you need to upload the entire diff against master.

Jun 6 2019, 6:18 AM · Frameworks

Jun 5 2019

drosca requested changes to D21584: Add LE Advertising and GATT APIs.

Looks really good!

Jun 5 2019, 7:47 AM · Frameworks

Jun 3 2019

drosca committed R875:4b85dab3d7fa: Vertical tabs: Draw unloaded tabs with "Disabled" color palette (authored by drosca).
Vertical tabs: Draw unloaded tabs with "Disabled" color palette
Jun 3 2019, 3:43 PM
drosca closed D21548: Vertical tabs: Draw unloaded tabs with "Disabled" color palette.
Jun 3 2019, 3:43 PM · Falkon
drosca accepted D21548: Vertical tabs: Draw unloaded tabs with "Disabled" color palette.
Jun 3 2019, 3:42 PM · Falkon

Jun 1 2019

drosca committed R875:107e75b4690f: Hello Python: Remove semicolons from sidebar.py (E703) (authored by drosca).
Hello Python: Remove semicolons from sidebar.py (E703)
Jun 1 2019, 8:28 AM
drosca committed R875:721d20336636: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Jun 1 2019, 8:28 AM
drosca closed D21386: Hello Python: Remove semicolons from sidebar.py (E703).
Jun 1 2019, 8:28 AM · Falkon

May 31 2019

drosca accepted D21511: Make falkon icon a real SVG.
May 31 2019, 1:08 PM · Frameworks
drosca accepted D21265: Add Bluez API to DBus XML parser/generator.
May 31 2019, 10:15 AM · Frameworks

May 30 2019

drosca added a comment to D21265: Add Bluez API to DBus XML parser/generator.

How different is the C++ generator from qdbusxml2cpp?

May 30 2019, 10:14 AM · Frameworks

May 28 2019

drosca added inline comments to D21265: Add Bluez API to DBus XML parser/generator.
May 28 2019, 2:12 PM · Frameworks

May 24 2019

drosca committed R875:307547749291: IconProvider: Add mutex around icon cache (authored by drosca).
IconProvider: Add mutex around icon cache
May 24 2019, 7:48 PM
drosca accepted D21382: Cancel helper when agent is canceled.
May 24 2019, 1:47 PM · Plasma

May 20 2019

drosca committed R875:2098d69ad1e0: PyFalkon: Fix build with clang (authored by drosca).
PyFalkon: Fix build with clang
May 20 2019, 1:22 PM
drosca closed D21304: VerticalTabs: Corectly recognize tree collapse / expand button.
May 20 2019, 1:22 PM · Falkon
drosca committed R875:fb09c266a71d: VerticalTabs: Corectly recognize tree collapse / expand button (authored by drosca).
VerticalTabs: Corectly recognize tree collapse / expand button
May 20 2019, 1:22 PM
drosca committed R875:bb8a3a799f65: RunAction plugin: set alternatingRowColors for listWidget (authored by drosca).
RunAction plugin: set alternatingRowColors for listWidget
May 20 2019, 1:22 PM
drosca closed D21227: RunAction plugin: set alternatingRowColors for listWidget.
May 20 2019, 1:22 PM · Falkon
drosca accepted D21304: VerticalTabs: Corectly recognize tree collapse / expand button.
May 20 2019, 1:02 PM · Falkon
drosca requested changes to D21265: Add Bluez API to DBus XML parser/generator.

Please use KDE coding style - https://community.kde.org/Policies/Kdelibs_Coding_Style

May 20 2019, 12:47 PM · Frameworks
drosca added a comment to T10810: New store category for Falkon.

Yes, everything works now. Thanks!

May 20 2019, 12:45 PM · KDE Store

May 15 2019

drosca accepted D21227: RunAction plugin: set alternatingRowColors for listWidget.
May 15 2019, 3:36 PM · Falkon

May 13 2019

drosca accepted D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI.
May 13 2019, 3:01 PM · Plasma

May 9 2019

drosca accepted D21087: Fix name and set desktop entry for notifications.
May 9 2019, 6:12 AM · Falkon

May 6 2019

drosca accepted D21048: There's no virtual sources, just source outputs.
May 6 2019, 3:34 PM · Plasma
drosca accepted D20871: Don't delete profiles and ports on update.
May 6 2019, 3:34 PM · Plasma
drosca accepted D21047: [Microphone Indicator] Schedule update initially.
May 6 2019, 3:27 PM · Plasma
drosca accepted D21045: Don't play sound when muting.
May 6 2019, 8:47 AM · Plasma

May 1 2019

drosca added a comment to T10810: New store category for Falkon.

I'm sorry it took that long, it should be ready now: https://phabricator.kde.org/R896:020b830f06d841cf801bf189c875a8e8e95d1c5a

May 1 2019, 7:51 AM · KDE Store

Apr 30 2019

drosca accepted D20915: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed.
Apr 30 2019, 10:46 AM · Plasma

Apr 29 2019

drosca accepted D19994: Add microphone indicator.
Apr 29 2019, 5:11 PM · Plasma

Apr 28 2019

drosca accepted D20872: Use override.
Apr 28 2019, 2:34 PM · Plasma

Apr 27 2019

drosca added a comment to D20834: Remove the padding of the bookmark bar.

Did you test with other Qt styles (fusion, windows, ...) ?

Apr 27 2019, 5:38 AM · Falkon

Apr 23 2019

drosca committed R875:7ddb3b898564: WIP: Shared QML engine for plugins (authored by drosca).
WIP: Shared QML engine for plugins
Apr 23 2019, 8:39 AM

Apr 22 2019

drosca committed R875:2cce43a1c389: plugins: Port to KI18n (authored by drosca).
plugins: Port to KI18n
Apr 22 2019, 1:11 PM
drosca committed R875:0d3fea1c932f: QmlPlugins: Port to KI18n (authored by drosca).
QmlPlugins: Port to KI18n
Apr 22 2019, 1:11 PM
drosca committed R875:3f37ada90678: lib: Port to KI18n (authored by drosca).
lib: Port to KI18n
Apr 22 2019, 1:11 PM
drosca committed R875:66d6e81e2336: main: Remove backtrace handler (authored by drosca).
main: Remove backtrace handler
Apr 22 2019, 7:53 AM
drosca committed R875:ee4dbad67680: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Apr 22 2019, 7:53 AM

Apr 21 2019

drosca committed R875:f38265230de9: SideBarManager: Clear active sidebar upon close (authored by drosca).
SideBarManager: Clear active sidebar upon close
Apr 21 2019, 9:22 AM
drosca committed R875:b9fb89a31ca6: Remove GnomeKeyringPasswords plugin (authored by drosca).
Remove GnomeKeyringPasswords plugin
Apr 21 2019, 9:05 AM
drosca committed R875:98282371596b: Plugins: Use embedded JSON metadata for shared library plugins (authored by drosca).
Plugins: Use embedded JSON metadata for shared library plugins
Apr 21 2019, 9:05 AM

Apr 20 2019

drosca committed R875:92721449c05d: VerticalTabs: Also override Ctrl+PgUp/PgDown shortcuts (authored by drosca).
VerticalTabs: Also override Ctrl+PgUp/PgDown shortcuts
Apr 20 2019, 5:26 PM
drosca committed R875:dc3063fc632b: Fix loading Python/QML extensions on startup (authored by drosca).
Fix loading Python/QML extensions on startup
Apr 20 2019, 2:54 PM
drosca committed R875:0b261874cb5c: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Apr 20 2019, 2:15 PM
drosca committed R875:514097ef4c3a: BookmarksManager: Don't allow to create bookmark without parent (authored by drosca).
BookmarksManager: Don't allow to create bookmark without parent
Apr 20 2019, 12:09 PM
drosca committed R875:e7a873cb5b6a: QmlTabsApiTest: Try to fix failure on FreeBSD CI (authored by drosca).
QmlTabsApiTest: Try to fix failure on FreeBSD CI
Apr 20 2019, 11:03 AM
drosca committed R875:3137cdfca278: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Apr 20 2019, 10:31 AM
drosca added a comment to T10810: New store category for Falkon.
In T10810#182383, @starbuck wrote:

That I dont know. The chosen url just needs to point to the same IP adress
than store.kde.org.

Apr 20 2019, 9:54 AM · KDE Store
drosca committed R875:8e4328b03c50: QmlUserScript: Automatically install/uninstall underlying script (authored by drosca).
QmlUserScript: Automatically install/uninstall underlying script
Apr 20 2019, 9:53 AM
drosca committed R875:a8d43ed0c8c2: QmlStaticData: Prevent deleting singletons by QML engine (authored by drosca).
QmlStaticData: Prevent deleting singletons by QML engine
Apr 20 2019, 9:53 AM
drosca committed R875:10eb20c162bf: QmlExtensionScheme: Fix warning about QQmlParserStatus qobject_cast (authored by drosca).
QmlExtensionScheme: Fix warning about QQmlParserStatus qobject_cast
Apr 20 2019, 9:53 AM
drosca committed R875:231101151e55: QmlPluginLoader: Fallback to main.qml as entrypoint if not set (authored by drosca).
QmlPluginLoader: Fallback to main.qml as entrypoint if not set
Apr 20 2019, 9:53 AM
drosca added a comment to T10810: New store category for Falkon.

Oh, that's nice!

Apr 20 2019, 9:19 AM · KDE Store
drosca committed R875:f792104be55f: ThemeManager: Implement removing locally installed themes (authored by drosca).
ThemeManager: Implement removing locally installed themes
Apr 20 2019, 8:24 AM
drosca committed R875:8e5c478c908a: Preferences: Add links to KDE store for installing themes/extensions (authored by drosca).
Preferences: Add links to KDE store for installing themes/extensions
Apr 20 2019, 8:24 AM
drosca committed R875:b5988bbe1f43: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Apr 20 2019, 8:24 AM
drosca committed R875:eb4b68fdd9c9: MainApplication: Create private browsing QWebEngineProfile without parent (authored by drosca).
MainApplication: Create private browsing QWebEngineProfile without parent
Apr 20 2019, 8:24 AM

Apr 19 2019

drosca added a comment to T10810: New store category for Falkon.

Yes, it works perfectly. Thanks

Apr 19 2019, 4:46 PM · KDE Store
drosca committed R875:d2d3d4593223: Don't use subfolders for QML/Python extensions (authored by drosca).
Don't use subfolders for QML/Python extensions
Apr 19 2019, 11:49 AM

Apr 18 2019

drosca added a comment to T10810: New store category for Falkon.

Not really, that's already taken care of in Falkon code: https://cgit.kde.org/falkon.git/tree/src/lib/plugins/ocssupport.cpp - it's detected by the contents of the archive.

Apr 18 2019, 7:52 PM · KDE Store
drosca added a comment to T10810: New store category for Falkon.

With themes it's just a matter of extracting the archive to ~/.config/falkon/themes. Falkon will register the new theme without restart.

Apr 18 2019, 7:18 PM · KDE Store
drosca added a comment to T10810: New store category for Falkon.

Would it be possible to enable the "ocs://" links for both Falkon categories?
I have implemented the url handler in Falkon, so it will only work when installing from Falkon itself, but in case of web browser I don't think it makes much sense to install the addons with external tools.

Apr 18 2019, 7:07 PM · KDE Store
drosca committed R875:6dd33dd803cf: QmlBookmarksApiTest: Fix testBookmarksCreation (authored by drosca).
QmlBookmarksApiTest: Fix testBookmarksCreation
Apr 18 2019, 2:40 PM
drosca committed R875:ff9c70dccbe8: Fix build with QtWebEngine 5.9 (authored by drosca).
Fix build with QtWebEngine 5.9
Apr 18 2019, 2:40 PM
drosca committed R875:5e6f92f7bc97: OcsSupport: Add initial support for downloading themes/extensions (authored by drosca).
OcsSupport: Add initial support for downloading themes/extensions
Apr 18 2019, 2:27 PM
drosca committed R875:13449605eb70: QmlPlugin: Change entrypoint to always be main.qml (authored by drosca).
QmlPlugin: Change entrypoint to always be main.qml
Apr 18 2019, 9:59 AM
drosca committed R875:7a562a4847c2: Plugins: Implement removing locally installed plugins (authored by drosca).
Plugins: Implement removing locally installed plugins
Apr 18 2019, 9:59 AM
drosca committed R875:a3e320fb47b8: KWalletPasswordBackend: Add overrides (authored by drosca).
KWalletPasswordBackend: Add overrides
Apr 18 2019, 9:59 AM
drosca created T10810: New store category for Falkon.
Apr 18 2019, 9:38 AM · KDE Store
drosca committed R875:e44ba37063d5: Merge branch 'Falkon/3.1' (authored by drosca).
Merge branch 'Falkon/3.1'
Apr 18 2019, 8:31 AM

Apr 17 2019

drosca committed R875:232eaa54bd37: KDEFrameworksIntegration: Create Purpose menu in init (authored by drosca).
KDEFrameworksIntegration: Create Purpose menu in init
Apr 17 2019, 2:34 PM

Apr 11 2019

drosca accepted D20450: [StreamRestore] Don't mess with channels.
Apr 11 2019, 6:08 AM · Plasma
drosca accepted D20451: [Context] Update StreamRestore before inserting it.
Apr 11 2019, 6:07 AM · Plasma

Apr 10 2019

drosca committed R875:e66835b4bfd3: Added focus for searchbar in history sidebar & bookmark sidebar (authored by saishm).
Added focus for searchbar in history sidebar & bookmark sidebar
Apr 10 2019, 3:14 PM
drosca closed D20022: Added focus for searchbar in history sidebar & bookmark sidebar.
Apr 10 2019, 3:14 PM · Falkon
drosca added a comment to D20022: Added focus for searchbar in history sidebar & bookmark sidebar.

Full name + email please so I can commit it for you.

Apr 10 2019, 2:31 PM · Falkon
drosca accepted D20022: Added focus for searchbar in history sidebar & bookmark sidebar.
Apr 10 2019, 2:30 PM · Falkon

Apr 9 2019

drosca requested changes to D19960: bluez-qt: remove warnings.

Actually ...

Apr 9 2019, 5:35 PM · Frameworks
drosca accepted D19960: bluez-qt: remove warnings.
Apr 9 2019, 5:07 PM · Frameworks

Apr 5 2019

drosca accepted D14775: Added tests for QML Extension API.
Apr 5 2019, 6:50 PM · Falkon