drosca (David Rosca)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (183 w, 1 d)
Availability
Available

Recent Activity

Mon, Oct 15

drosca committed R875:a039da158ae4: Update to latest upstream QtSingleApplication (authored by drosca).
Update to latest upstream QtSingleApplication
Mon, Oct 15, 6:40 PM
drosca committed R875:6d445edb44a8: Context menu for statusbar (authored by pflynn).
Context menu for statusbar
Mon, Oct 15, 6:24 PM
drosca closed D16158: Context menu for statusbar.
Mon, Oct 15, 6:24 PM · Falkon
drosca added a comment to D16158: Context menu for statusbar.

The patch doesn't apply:

INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16158.
Checking patch src/lib/other/statusbar.cpp...
error: while searching for:
void StatusBar::mousePressEvent(QMouseEvent *event)
{
    if (event->button()==Qt::RightButton) {
        QMenu *context = new QMenu;
        QAction *hide_bar = new QAction(tr("Hide"),this);
        connect(hide_bar,&QAction::triggered,m_window,&BrowserWindow::toggleShowStatusBar);
        context->addAction(hide_bar);
        context->exec(QCursor::pos());
    }
    QStatusBar::mousePressEvent(event);
error: patch failed: src/lib/other/statusbar.cpp:245
Applying patch src/lib/other/statusbar.cpp with 1 reject...
Rejected hunk #1.
Mon, Oct 15, 4:24 PM · Falkon
drosca committed R875:907e2e49380d: Fix crash during download when the main window have been closed (authored by chcuris).
Fix crash during download when the main window have been closed
Mon, Oct 15, 4:20 PM
drosca closed D14711: Fix crash during download when the main window have been closed.
Mon, Oct 15, 4:20 PM · Falkon
drosca accepted D16158: Context menu for statusbar.

Your full name + email please, so I can push it for you.

Mon, Oct 15, 4:17 PM · Falkon

Fri, Oct 12

drosca requested changes to D16158: Context menu for statusbar.
Fri, Oct 12, 3:38 PM · Falkon

Thu, Oct 4

drosca committed R269:5f12404807cc: Implement Media and MediaEndpoint API (authored by mweichselbaumer).
Implement Media and MediaEndpoint API
Thu, Oct 4, 6:29 PM
drosca closed D15745: Implement Media and MediaEndpoint API.
Thu, Oct 4, 6:29 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Thanks.
I'll need your full name + e-mail if you don't have dev account to push it.

Thu, Oct 4, 6:22 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Remove NoInputNoOutputAgent and it's good to go.

Agree. Is it ok to move it to mediaendpointconnector?

Thu, Oct 4, 5:09 PM · Frameworks
drosca added a comment to D15930: Add more icons to actions.

These icon names are too specific and most likely only available in Breeze icon theme, so I don't think it should be used there.

Thu, Oct 4, 5:08 PM · Falkon
drosca accepted D15745: Implement Media and MediaEndpoint API.

Remove NoInputNoOutputAgent and it's good to go.

Thu, Oct 4, 4:42 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Alright, last thing:

Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway.

Yes, i also thought this should be application specific. However, i could not imagine another use case of a NoInputNoOutputAgent, except from doing auto connecting to a limited set of UUIDs. So, i thought it is generic enough to be part of the library.

Thu, Oct 4, 4:28 PM · Frameworks
drosca added a comment to D15745: Implement Media and MediaEndpoint API.

Alright, last thing:

Thu, Oct 4, 3:36 PM · Frameworks
drosca accepted D14711: Fix crash during download when the main window have been closed.

Alright,
I'll need your full name + email to commit it for you.

Thu, Oct 4, 7:51 AM · Falkon
drosca requested changes to D15745: Implement Media and MediaEndpoint API.
Thu, Oct 4, 7:49 AM · Frameworks
drosca added a comment to D15827: [applet] Avoid showing a generic audio-card icon.

I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "input-volume" icons.

Thu, Oct 4, 7:39 AM · Plasma
drosca accepted D15925: Add icon to Fullscreen action.
Thu, Oct 4, 7:37 AM · Falkon
drosca accepted D15926: Add icon to Web Search action.
Thu, Oct 4, 7:37 AM · Falkon

Wed, Oct 3

drosca accepted D15921: Add icon to DownloadManager action.
Wed, Oct 3, 2:32 PM · Falkon

Mon, Oct 1

drosca accepted D15886: set resizeMode for QQuickWidget in sidebar.
Mon, Oct 1, 7:20 PM · Falkon
drosca accepted D14519: Added HelloQml Extension.
Mon, Oct 1, 6:19 PM · Falkon

Sat, Sep 29

drosca accepted D15832: fixed build for qt versions < 5.11.

Translations should work on FreeBSD though, so please fix it another commit.

Sat, Sep 29, 3:08 PM · Falkon
drosca requested changes to D15832: fixed build for qt versions < 5.11.

Also please fix build on FreeBSD: https://build.kde.org/job/Extragear/job/falkon/job/kf5-qt5%20FreeBSDQt5.11/6/console

Sat, Sep 29, 2:23 PM · Falkon
drosca added a comment to D14774: Add QML Extensions API.

Build is broken now: https://build.kde.org/job/Extragear/job/falkon/

Sat, Sep 29, 7:35 AM · Falkon

Fri, Sep 28

drosca accepted D14774: Add QML Extensions API.
Fri, Sep 28, 10:06 AM · Falkon

Thu, Sep 27

drosca added a comment to D15304: [KCM] Port (almost) entirely to QQC2.

Plasma items should not be used in KCM.

Hmm, what you you recommend then for showing an icon item? The old QIconItem breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to import Kirigami.

I suggest to fix QIconItem, as it is used in other places too.

Thu, Sep 27, 2:08 PM · Plasma
drosca closed D15751: Center content & banner.

It's now live at falkon.org

Thu, Sep 27, 7:49 AM
drosca accepted D15751: Center content & banner.

Centered navigation looks bad.

Thu, Sep 27, 7:44 AM
drosca added inline comments to D15304: [KCM] Port (almost) entirely to QQC2.
Thu, Sep 27, 7:42 AM · Plasma
drosca added inline comments to D15745: Implement Media and MediaEndpoint API.
Thu, Sep 27, 7:40 AM · Frameworks

Wed, Sep 26

drosca requested changes to D15304: [KCM] Port (almost) entirely to QQC2.

There is ScrollView in QQC2 (since Qt 5.9), so please use it.
Also as @davidedmundson said, please edit the commit message.

Wed, Sep 26, 2:56 PM · Plasma
drosca added a comment to D15751: Center content & banner.

Can you please also upload screenshot of page with blog post? Like https://www.falkon.org/2018/05/08/falkon-301-released/

Wed, Sep 26, 2:48 PM
drosca accepted D15769: Show "muted" icon in panel and disable shortcuts for Dummy Output.
Wed, Sep 26, 2:47 PM · Plasma

Tue, Sep 25

drosca added inline comments to D15745: Implement Media and MediaEndpoint API.
Tue, Sep 25, 3:42 PM · Frameworks
drosca requested changes to D15745: Implement Media and MediaEndpoint API.

Looks good apart from the coding style.
Also it would be great to have at least basic autotest.

Tue, Sep 25, 1:29 PM · Frameworks

Mon, Sep 24

drosca added inline comments to D14774: Add QML Extensions API.
Mon, Sep 24, 2:18 PM · Falkon
drosca added inline comments to D14774: Add QML Extensions API.
Mon, Sep 24, 8:10 AM · Falkon

Sun, Sep 23

drosca added inline comments to D14774: Add QML Extensions API.
Sun, Sep 23, 10:50 AM · Falkon

Sep 21 2018

drosca requested changes to D14774: Add QML Extensions API.
Sep 21 2018, 7:48 AM · Falkon

Sep 6 2018

drosca added a comment to D15304: [KCM] Port (almost) entirely to QQC2.

I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items.

Sep 6 2018, 6:24 AM · Plasma

Sep 2 2018

drosca requested changes to D14775: Added tests for QML Extension API.
Sep 2 2018, 8:37 PM · Falkon
drosca accepted D14519: Added HelloQml Extension.
Sep 2 2018, 8:33 PM · Falkon
drosca requested changes to D14774: Add QML Extensions API.
Sep 2 2018, 8:32 PM · Falkon

Sep 1 2018

drosca closed D15104: Add "Made by KDE" logo.

I do not have commit access, so unless somebody has any objections to this change I'd be glad if you could land it for me. Thanks!

Sep 1 2018, 7:18 AM

Aug 28 2018

drosca accepted D15104: Add "Made by KDE" logo.
Aug 28 2018, 8:51 AM

Aug 18 2018

drosca added inline comments to D14774: Add QML Extensions API.
Aug 18 2018, 12:01 PM · Falkon
drosca added inline comments to D14774: Add QML Extensions API.
Aug 18 2018, 5:44 AM · Falkon

Aug 17 2018

drosca added inline comments to D14774: Add QML Extensions API.
Aug 17 2018, 6:46 PM · Falkon
drosca added inline comments to D14774: Add QML Extensions API.
Aug 17 2018, 3:33 PM · Falkon
drosca requested changes to D14774: Add QML Extensions API.
Aug 17 2018, 7:22 AM · Falkon

Aug 12 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 12 2018, 9:35 AM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 12 2018, 6:15 AM · Falkon

Aug 11 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:56 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:27 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:15 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 4:08 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 3:45 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 3:17 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 2:31 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 11 2018, 10:45 AM · Falkon

Aug 10 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 7:09 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 6:40 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 6:32 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 5:01 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 4:30 PM · Falkon
drosca requested changes to D14519: Added HelloQml Extension.
Aug 10 2018, 4:02 PM · Falkon
drosca added a comment to D14513: Add QML Extensions API.

Again, if I say to change one thing there and it is also in multiple other places, please change it everywhere.

Aug 10 2018, 4:00 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 3:54 PM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 10 2018, 7:55 AM · Falkon
drosca requested changes to D14711: Fix crash during download when the main window have been closed.

Why not just

Aug 10 2018, 7:48 AM · Falkon

Aug 8 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 8 2018, 10:19 AM · Falkon
drosca added inline comments to D14513: Add QML Extensions API.
Aug 8 2018, 9:51 AM · Falkon

Aug 7 2018

drosca requested changes to D14513: Add QML Extensions API.

If I noted something that occurs in multiple places, my note applies to all other places too, so you should change it everywhere.

Aug 7 2018, 5:06 PM · Falkon

Aug 4 2018

drosca added inline comments to D14513: Add QML Extensions API.
Aug 4 2018, 3:55 PM · Falkon

Aug 2 2018

drosca requested changes to D14519: Added HelloQml Extension.

It's missing Messages.sh script for extracting translatable strings (it also seems it doesn't use translations at all).

Aug 2 2018, 4:36 PM · Falkon
drosca requested changes to D14513: Add QML Extensions API.

Also documentation should be only in headers, so move the function docs to headers from source files.

Aug 2 2018, 4:34 PM · Falkon
drosca added a comment to D14513: Add QML Extensions API.

So the only new thing that is stored in database is whether the plugin should be loaded in private mode? I don't really see a reason to move it from .ini to database then. Also please move it to separate review.

Aug 2 2018, 3:17 PM · Falkon

Aug 1 2018

drosca added a comment to T9122: Promoting KDE as a brand through KDE apps.
In T9122#153244, @paulb wrote:

They look good, right? And the branding is not intrusive at all.

Aug 1 2018, 3:27 PM · KDE Promo

Jul 29 2018

drosca added a comment to T9122: Promoting KDE as a brand through KDE apps.
In T9122#150138, @paulb wrote:

Here the logo integrates very nicely, +1.

Jul 29 2018, 7:46 AM · KDE Promo

Jul 23 2018

drosca accepted D14156: Show "muted" icon for dummy output.
Jul 23 2018, 10:59 AM · Plasma

Jul 22 2018

drosca committed R875:d5fc3ebc8881: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Jul 22 2018, 1:21 PM
drosca committed R875:a7d2f8757919: FalkonSchemeHandler: Make sure to load data on main thread (authored by drosca).
FalkonSchemeHandler: Make sure to load data on main thread
Jul 22 2018, 1:21 PM

Jul 19 2018

drosca committed R875:6357e983131e: RunAction: Close UI file after it is loaded (authored by SGOrava).
RunAction: Close UI file after it is loaded
Jul 19 2018, 3:39 PM
drosca closed D14197: RunAction: Close UI file after it is loaded.
Jul 19 2018, 3:39 PM · Falkon
drosca committed R875:6556ade5c98a: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu (authored by SGOrava).
[Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu
Jul 19 2018, 3:39 PM
drosca closed D14214: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu.
Jul 19 2018, 3:39 PM · Falkon
drosca accepted D14197: RunAction: Close UI file after it is loaded.
Jul 19 2018, 3:38 PM · Falkon
drosca added a comment to D14109: Add plugin MiddleClickLoader which fix issue 395688.

Please close this

Jul 19 2018, 3:38 PM · Falkon
drosca accepted D14214: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu.
Jul 19 2018, 3:36 PM · Falkon

Jul 18 2018

drosca requested changes to D14214: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu.
Jul 18 2018, 7:06 PM · Falkon

Jul 17 2018

drosca committed R875:82c8d50f9a7f: [Feature] Add python plugin MiddleClickLoader (authored by SGOrava).
[Feature] Add python plugin MiddleClickLoader
Jul 17 2018, 10:14 AM
drosca closed D14155: [Feature] Add python plugin MiddleClickLoader.
Jul 17 2018, 10:14 AM · Falkon
drosca accepted D14155: [Feature] Add python plugin MiddleClickLoader.
Jul 17 2018, 10:13 AM · Falkon
drosca added a comment to D14155: [Feature] Add python plugin MiddleClickLoader.

It's ok now. Your full name and e-mail please so I can commit it.

Jul 17 2018, 9:42 AM · Falkon
drosca added a comment to D14155: [Feature] Add python plugin MiddleClickLoader.

Changes looks fine, but I can't apply it because you updated it incorrectly.

Jul 17 2018, 9:28 AM · Falkon
drosca added inline comments to D14147: Port from GConf to GSettings.
Jul 17 2018, 6:45 AM · Plasma

Jul 16 2018

drosca requested changes to D14147: Port from GConf to GSettings.
Jul 16 2018, 7:40 PM · Plasma