drosca (David Rosca)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (200 w, 3 d)
Availability
Available

Recent Activity

Today

drosca committed R875:102bd219b752: QtSingleApplication: Add DBus backend for Linux (authored by drosca).
QtSingleApplication: Add DBus backend for Linux
Tue, Feb 19, 10:13 AM

Sat, Feb 16

drosca added a comment to D19008: Add context menu entry to copy link text.

Take a look in src/plugins src/scripts

Sat, Feb 16, 8:43 AM · Falkon

Fri, Feb 15

drosca added a comment to D19008: Add context menu entry to copy link text.

I meant that I don't want this feature. Context menu on page is already very long, and if it contained every action that someone requested on bugzilla, it would not even fit on screen.

Fri, Feb 15, 3:09 PM · Falkon
drosca requested changes to D19008: Add context menu entry to copy link text.

As with similar actions, this should be in plugin (preferably only script) and not in main code.

Fri, Feb 15, 2:12 PM · Falkon

Thu, Feb 14

drosca committed R875:eac5673656d7: Register custom schemes with QtWebEngine 5.12 (authored by drosca).
Register custom schemes with QtWebEngine 5.12
Thu, Feb 14, 7:54 AM
drosca committed R875:b508ed2260a9: WebHitTestResult: Expect null href attribute (authored by drosca).
WebHitTestResult: Expect null href attribute
Thu, Feb 14, 7:54 AM

Wed, Feb 13

drosca accepted D15304: [KCM] Port to QQC2.

Looks good now!

Wed, Feb 13, 7:42 AM · Plasma

Sat, Feb 2

drosca accepted D18667: Add --wmclass argument to linux completion files.
Sat, Feb 2, 1:32 PM · Falkon

Mon, Jan 28

drosca committed R875:db9d506cf5c5: Add support for Navigator.registerProtocolHandler() (authored by drosca).
Add support for Navigator.registerProtocolHandler()
Mon, Jan 28, 4:54 PM
drosca committed R875:38b2631de97f: SiteInfoWidget: Add site name header (authored by drosca).
SiteInfoWidget: Add site name header
Mon, Jan 28, 4:54 PM

Sun, Jan 27

drosca updated the task description for T10405: Download Manager rewrite.
Sun, Jan 27, 12:03 PM · Falkon
drosca created T10405: Download Manager rewrite.
Sun, Jan 27, 11:51 AM · Falkon

Sat, Jan 26

drosca accepted D15304: [KCM] Port to QQC2.

I don't really like that this port became full of workarounds to be honest, but if it works and there's no other way then fine.

Sat, Jan 26, 3:37 PM · Plasma
drosca committed R875:e15bcbf877c7: QmlPluginLoader: Register i18n functions also without libintl (authored by drosca).
QmlPluginLoader: Register i18n functions also without libintl
Sat, Jan 26, 3:34 PM
drosca committed R875:9a03f197caaa: PyFalkon: Fix generating bindings for signals (authored by drosca).
PyFalkon: Fix generating bindings for signals
Sat, Jan 26, 3:34 PM
drosca committed R875:4990eed417ef: SqlDatabase: Remove existing database before adding new (authored by drosca).
SqlDatabase: Remove existing database before adding new
Sat, Jan 26, 3:34 PM
drosca committed R875:b9c4a92aef6b: Fix coding style (authored by drosca).
Fix coding style
Sat, Jan 26, 3:34 PM
drosca committed R875:6678a98d91f4: WebHitTestResult: Trim value of src/href attributes (authored by drosca).
WebHitTestResult: Trim value of src/href attributes
Sat, Jan 26, 11:30 AM
drosca committed R875:0bb78c850160: WebView: Use Qt::Back/ForwardButton instead of XButton1/2 (authored by drosca).
WebView: Use Qt::Back/ForwardButton instead of XButton1/2
Sat, Jan 26, 9:38 AM
drosca committed R875:ab43af9958a1: WebView: Fix detecting rwhvqt change with QtWebEngine 5.12 (authored by drosca).
WebView: Fix detecting rwhvqt change with QtWebEngine 5.12
Sat, Jan 26, 9:38 AM

Thu, Jan 24

drosca committed R875:a237c8ff874a: SearchToolBar: Add Shift+Enter shortcut to find previous (authored by drosca).
SearchToolBar: Add Shift+Enter shortcut to find previous
Thu, Jan 24, 2:54 PM
drosca committed R875:25a6008e6d56: WebPage: Fix scroll to anchor workaround to also look for element ids (authored by drosca).
WebPage: Fix scroll to anchor workaround to also look for element ids
Thu, Jan 24, 2:37 PM
drosca committed R115:5dc7cca58a72: Don't ignore default virtual devices (authored by sharhalakis).
Don't ignore default virtual devices
Thu, Jan 24, 9:48 AM
drosca closed D17784: Don't ignore default virtual devices.
Thu, Jan 24, 9:48 AM · Plasma
drosca committed R875:675f148598a9: FalkonSchemeHandler: Load contents immediately (authored by drosca).
FalkonSchemeHandler: Load contents immediately
Thu, Jan 24, 9:11 AM

Wed, Jan 23

drosca committed R875:0389da311c2f: Fix leaking QWebEngineUrlRequestJob reply (authored by drosca).
Fix leaking QWebEngineUrlRequestJob reply
Wed, Jan 23, 4:42 PM
drosca committed R875:1c4a8ddd6f8e: PyFalkon: Fix build with PySide 5.12 (authored by drosca).
PyFalkon: Fix build with PySide 5.12
Wed, Jan 23, 2:56 PM

Tue, Jan 22

drosca added a comment to D15304: [KCM] Port to QQC2.

Thanks for the approval, but the scrollviews still don't actually scroll when the window is too small to fit all the content! I haven't been able to figure out why this is yet, so help would be appreciated if you have the time. :)

Tue, Jan 22, 3:31 PM · Plasma
drosca accepted D15304: [KCM] Port to QQC2.
Tue, Jan 22, 3:10 PM · Plasma
drosca requested changes to D15304: [KCM] Port to QQC2.
Tue, Jan 22, 2:29 PM · Plasma
drosca added a comment to D17784: Don't ignore default virtual devices.

Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity.

Tue, Jan 22, 1:55 PM · Plasma

Mon, Jan 21

drosca added a comment to D18295: CTRL+Q should only close current window, not all windows.

As I already wrote, it has to be added as new option.

Mon, Jan 21, 9:21 AM · Falkon

Jan 18 2019

drosca accepted D17784: Don't ignore default virtual devices.
Jan 18 2019, 10:44 AM · Plasma

Jan 17 2019

drosca requested changes to D18295: CTRL+Q should only close current window, not all windows.

Actually I myself am not really fan of closing only the window with Ctrl+Q, there is Alt+F4 for that.

Jan 17 2019, 6:12 PM · Falkon
drosca accepted D18327: fixed settings spelling in gm_manager.
Jan 17 2019, 6:10 PM · Falkon
drosca requested review of D18315: Device: Check object path in interfaces removed slot.
Jan 17 2019, 12:42 PM · Frameworks
drosca committed R269:5b3f8f2f81be: Fix fall-through warning (authored by drosca).
Fix fall-through warning
Jan 17 2019, 11:57 AM

Jan 15 2019

drosca accepted D18276: Fix KDE Connect volume control.

Related patch to plasma-pa D16443

Jan 15 2019, 7:50 PM · Plasma
drosca requested changes to D18276: Fix KDE Connect volume control.

I think it would be better to edit the check only to contains("Glib") as it still makes sense to check for GLib event loop, as otherwise the code will just silently fail.

Jan 15 2019, 7:30 PM · Plasma

Jan 11 2019

drosca committed R98:47baff3a624a: Gtk2: Fix scrollbar background color in Firefox (authored by drosca).
Gtk2: Fix scrollbar background color in Firefox
Jan 11 2019, 4:36 PM

Jan 8 2019

drosca requested changes to D18090: PyFalkon build with pyside 5.12 version.

This doesn't fix anything.

Jan 8 2019, 9:30 AM · Falkon

Dec 29 2018

drosca committed R875:246951e474cf: Fix build (authored by drosca).
Fix build
Dec 29 2018, 11:14 AM
drosca accepted D17811: Fix build.
Dec 29 2018, 11:13 AM · Falkon

Dec 25 2018

drosca committed R875:5fcd29c5074a: Preferences: Add DNS Prefetch option (authored by drosca).
Preferences: Add DNS Prefetch option
Dec 25 2018, 10:54 AM
drosca committed R875:7429d1d8ef4e: WebPage: Add basic support for client certificates (authored by drosca).
WebPage: Add basic support for client certificates
Dec 25 2018, 10:54 AM
drosca added a reverting change for R875:19cce0c8381e: Change minimum Qt version to 5.10: R875:38ea9974b490: Revert "Change minimum Qt version to 5.10".
Dec 25 2018, 10:21 AM
drosca committed R875:38ea9974b490: Revert "Change minimum Qt version to 5.10" (authored by drosca).
Revert "Change minimum Qt version to 5.10"
Dec 25 2018, 10:21 AM
drosca committed R875:5fd9cb92ee7b: Use QWebEnginePage::printRequested with QtWebEngine 5.12 (authored by drosca).
Use QWebEnginePage::printRequested with QtWebEngine 5.12
Dec 25 2018, 10:03 AM
drosca committed R875:f19f443c1cb2: DownloadManager: Correctly detect originating page (authored by drosca).
DownloadManager: Correctly detect originating page
Dec 25 2018, 10:03 AM
drosca committed R875:19cce0c8381e: Change minimum Qt version to 5.10 (authored by drosca).
Change minimum Qt version to 5.10
Dec 25 2018, 10:03 AM

Dec 24 2018

drosca committed R875:cba7f32666ef: WebTab: Fix size of web inspector in splitter (authored by drosca).
WebTab: Fix size of web inspector in splitter
Dec 24 2018, 8:02 PM
drosca committed R875:47f2a1697ca8: AdBlockManager: Parse also invalid abp: urls (authored by drosca).
AdBlockManager: Parse also invalid abp: urls
Dec 24 2018, 8:02 PM
drosca committed R875:53d35dbdbdf0: BookmarksToolBarButton: Don't show empty title in tooltip (authored by drosca).
BookmarksToolBarButton: Don't show empty title in tooltip
Dec 24 2018, 2:20 PM
drosca committed R875:fe45d36cdafc: VerticalTabs: Close tree if middle clicking on collapsed item (authored by drosca).
VerticalTabs: Close tree if middle clicking on collapsed item
Dec 24 2018, 2:20 PM
drosca committed R875:956b99c1cb2a: BrowserWindow: Use LoadRequest in loadAddress (authored by drosca).
BrowserWindow: Use LoadRequest in loadAddress
Dec 24 2018, 2:20 PM
drosca committed R875:cbb322c1a59a: X11: Add --wmclass command line option (authored by drosca).
X11: Add --wmclass command line option
Dec 24 2018, 2:20 PM
drosca committed R875:51eb65ecec76: SearchToolBar: Ignore old search callbacks (authored by drosca).
SearchToolBar: Ignore old search callbacks
Dec 24 2018, 2:20 PM
drosca committed R875:a6c266b6c6e3: SpeedDial: Base64 encode initial script (authored by drosca).
SpeedDial: Base64 encode initial script
Dec 24 2018, 2:20 PM
drosca committed R875:9e7011cbed50: DownloadManager: Start download timer when download is created (authored by drosca).
DownloadManager: Start download timer when download is created
Dec 24 2018, 2:20 PM
drosca committed R875:7f8b3183154b: README.md: Fix syntax to work with GitHub parser (authored by drosca).
README.md: Fix syntax to work with GitHub parser
Dec 24 2018, 2:20 PM

Dec 13 2018

drosca closed D17568: Fixed Markdown headlines in readme.
Dec 13 2018, 6:01 PM · Falkon
drosca committed R875:8a06d38f3ff4: Fixed Markdown headlines in readme (authored by janpr).
Fixed Markdown headlines in readme
Dec 13 2018, 6:01 PM
drosca accepted D17568: Fixed Markdown headlines in readme.
Dec 13 2018, 5:22 PM · Falkon

Dec 12 2018

drosca added a comment to D17422: Falkon inserts incorrect history `count` data in sql.

If by incorrect history count you mean that one page load results in counter incrementing by 2 instead of 1 then it is actually side-effect of this workaround: https://cgit.kde.org/falkon.git/tree/src/lib/webengine/webpage.cpp#n106

Dec 12 2018, 8:07 PM · Falkon
drosca closed D13385: Fix #394905.

https://cgit.kde.org/falkon.git/commit/?id=29fbbf5dc4cc55102752e20d1f85cbd49ee7333a

Dec 12 2018, 8:03 PM · Falkon, Windows
drosca added a comment to D11890: remove suggestion for duplicate search engine.

Shall we abandon this request?

Dec 12 2018, 7:40 PM · Falkon
drosca accepted D14930: Create new bookmark items near the current one (over it).
Dec 12 2018, 7:34 PM · Falkon
drosca committed R875:4ff7ccc73782: Don't include qmlpluginloader.h in plugin.sh (authored by drosca).
Don't include qmlpluginloader.h in plugin.sh
Dec 12 2018, 6:05 PM
drosca added a reverting change for R875:3ea935b1439a: Fix PyFalkon build: R875:eefd9cd0464b: Revert "Fix PyFalkon build".
Dec 12 2018, 6:05 PM
drosca committed R875:eefd9cd0464b: Revert "Fix PyFalkon build" (authored by drosca).
Revert "Fix PyFalkon build"
Dec 12 2018, 6:05 PM
drosca committed R875:3ea935b1439a: Fix PyFalkon build (authored by drosca).
Fix PyFalkon build
Dec 12 2018, 6:03 PM
drosca committed R875:d25c34901c94: Use QTWEBENGINEWIDGETS_VERSION for determining QtWebEngine version (authored by drosca).
Use QTWEBENGINEWIDGETS_VERSION for determining QtWebEngine version
Dec 12 2018, 6:03 PM

Dec 9 2018

drosca accepted D17288: Fix hardcoded private browsing icon.
Dec 9 2018, 7:31 PM · Falkon
drosca added a comment to D17419: Add view-private icon.

Ah yeah, I guess that makes sense.

Falkon folks, is this acceptable?

Dec 9 2018, 6:56 PM · VDG, Breeze, Frameworks

Dec 2 2018

drosca accepted D17307: Fix unreadable Falkon logo text when using a dark theme.
Dec 2 2018, 1:27 PM · Falkon
drosca added a comment to D17307: Fix unreadable Falkon logo text when using a dark theme.

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

Dec 2 2018, 1:22 PM · Falkon
drosca accepted D17286: Enable page sharing.
Dec 2 2018, 12:35 PM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

That's for discussion with Breeze devs.

Dec 2 2018, 10:30 AM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

Then just use this icon, but make a symlink to private-mode.

Dec 2 2018, 10:25 AM · Falkon
drosca added inline comments to D17286: Enable page sharing.
Dec 2 2018, 10:09 AM · Falkon
drosca added a comment to D17286: Enable page sharing.

Looks good, but please use KDE/KF5 coding style - QMenu *menu.

Dec 2 2018, 10:08 AM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

Yes, so there should be new icon in Breeze theme (eg. private-browsing or maybe better private-mode so it is more generic) and then Falkon can use it.

Dec 2 2018, 10:07 AM · Falkon

Dec 1 2018

drosca added a comment to D17288: Fix hardcoded private browsing icon.
In D17288#369538, @GB_2 wrote:

But it looks very similar the original one.
What other icon should it be?

Dec 1 2018, 8:12 PM · Falkon
drosca added a comment to D17288: Fix hardcoded private browsing icon.

im-user has completely different meaning than "private browsing".

Dec 1 2018, 8:09 PM · Falkon

Nov 13 2018

drosca added a comment to D16082: Notify headphone being plugged in on some hardware.

Maybe we could use a generic icon, or make a new one that depicts speakers plus headphones or something?

Nov 13 2018, 9:00 PM · Plasma

Nov 8 2018

drosca added a comment to D16082: Notify headphone being plugged in on some hardware.

So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack.

Nov 8 2018, 9:27 AM · Plasma
drosca added a comment to D16082: Notify headphone being plugged in on some hardware.

So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ?

Nov 8 2018, 9:07 AM · Plasma

Nov 4 2018

drosca committed R875:cda838a35ea2: Adblock uses outdated Spanish filters (Filtros Naucópicos) (authored by krishremya).
Adblock uses outdated Spanish filters (Filtros Naucópicos)
Nov 4 2018, 3:17 PM
drosca closed D16656: Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos).
Nov 4 2018, 3:17 PM · Falkon
drosca accepted D16656: Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos).

Looks good now, thanks. If you don't have dev account please send me your full name + email and I will commit it for you.

Nov 4 2018, 10:25 AM · Falkon
drosca requested changes to D16656: Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos).

This will change the default list (EasyList) to be Spanish variant for all users.
You should instead change the url to Spanish subscriptions in AdBlockAddSubscriptionDialog

Nov 4 2018, 9:10 AM · Falkon

Oct 27 2018

drosca accepted D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 27 2018, 6:01 AM · Plasma

Oct 24 2018

drosca closed D16238: Replace Qt foreach with C++ foreach.
Oct 24 2018, 3:21 PM · Falkon
drosca committed R875:c85f4f889422: Replace Qt foreach with C++ foreach (authored by pflynn).
Replace Qt foreach with C++ foreach
Oct 24 2018, 3:21 PM
drosca accepted D16238: Replace Qt foreach with C++ foreach.
Oct 24 2018, 3:16 PM · Falkon

Oct 23 2018

drosca committed R269:a65823a9aa43: Add Media and MediaEndpoint API header generation (authored by mweichselbaumer).
Add Media and MediaEndpoint API header generation
Oct 23 2018, 3:41 PM
drosca closed D16084: Add Media and MediaEndpoint API header generation.
Oct 23 2018, 3:41 PM · Frameworks
drosca requested changes to D16238: Replace Qt foreach with C++ foreach.

You should always use for on const Qt containers, as otherwise it will detach.
So it should be:

Oct 23 2018, 3:40 PM · Falkon
drosca accepted D16084: Add Media and MediaEndpoint API header generation.
Oct 23 2018, 3:38 PM · Frameworks

Oct 15 2018

drosca committed R875:a039da158ae4: Update to latest upstream QtSingleApplication (authored by drosca).
Update to latest upstream QtSingleApplication
Oct 15 2018, 6:40 PM