The patch doesn't apply:

INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16158.
Checking patch src/lib/other/statusbar.cpp...
error: while searching for:
void StatusBar::mousePressEvent(QMouseEvent *event)
{
    if (event->button()==Qt::RightButton) {
        QMenu *context = new QMenu;
        QAction *hide_bar = new QAction(tr("Hide"),this);
        connect(hide_bar,&QAction::triggered,m_window,&BrowserWindow::toggleShowStatusBar);
        context->addAction(hide_bar);
        context->exec(QCursor::pos());
    }
    QStatusBar::mousePressEvent(event);
error: patch failed: src/lib/other/statusbar.cpp:245
Applying patch src/lib/other/statusbar.cpp with 1 reject...
Rejected hunk #1.

Your full name + email please, so I can push it for you.

Thanks.
I'll need your full name + e-mail if you don't have dev account to push it.

In D15745#336662, @mweichselbaumer wrote:

In D15745#336644, @drosca wrote:

Remove NoInputNoOutputAgent and it's good to go.

Agree. Is it ok to move it to mediaendpointconnector?

These icon names are too specific and most likely only available in Breeze icon theme, so I don't think it should be used there.

Remove NoInputNoOutputAgent and it's good to go.

In D15745#336615, @mweichselbaumer wrote:

In D15745#336593, @drosca wrote:

Alright, last thing:

Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway.

Yes, i also thought this should be application specific. However, i could not imagine another use case of a NoInputNoOutputAgent, except from doing auto connecting to a limited set of UUIDs. So, i thought it is generic enough to be part of the library.

Alright, last thing:

Alright,
I'll need your full name + email to commit it for you.

I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "input-volume" icons.

Translations should work on FreeBSD though, so please fix it another commit.

Also please fix build on FreeBSD: https://build.kde.org/job/Extragear/job/falkon/job/kf5-qt5%20FreeBSDQt5.11/6/console

Build is broken now: https://build.kde.org/job/Extragear/job/falkon/

In D15304#332755, @ngraham wrote:

Plasma items should not be used in KCM.

Hmm, what you you recommend then for showing an icon item? The old QIconItem breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to import Kirigami.

I suggest to fix QIconItem, as it is used in other places too.

It's now live at falkon.org

Centered navigation looks bad.

There is ScrollView in QQC2 (since Qt 5.9), so please use it.
Also as @davidedmundson said, please edit the commit message.

Can you please also upload screenshot of page with blog post? Like https://www.falkon.org/2018/05/08/falkon-301-released/

Looks good apart from the coding style.
Also it would be great to have at least basic autotest.

I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items.

In D15104#317776, @xyquadrat wrote:

I do not have commit access, so unless somebody has any objections to this change I'd be glad if you could land it for me. Thanks!

Again, if I say to change one thing there and it is also in multiple other places, please change it everywhere.

Why not just

If I noted something that occurs in multiple places, my note applies to all other places too, so you should change it everywhere.

It's missing Messages.sh script for extracting translatable strings (it also seems it doesn't use translations at all).

Also documentation should be only in headers, so move the function docs to headers from source files.

So the only new thing that is stored in database is whether the plugin should be loaded in private mode? I don't really see a reason to move it from .ini to database then. Also please move it to separate review.

In T9122#153244, @paulb wrote:

They look good, right? And the branding is not intrusive at all.

In T9122#150138, @paulb wrote:

Here the logo integrates very nicely, +1.

Please close this

It's ok now. Your full name and e-mail please so I can commit it.

Changes looks fine, but I can't apply it because you updated it incorrectly.