If by incorrect history count you mean that one page load results in counter incrementing by 2 instead of 1 then it is actually side-effect of this workaround: https://cgit.kde.org/falkon.git/tree/src/lib/webengine/webpage.cpp#n106

https://cgit.kde.org/falkon.git/commit/?id=29fbbf5dc4cc55102752e20d1f85cbd49ee7333a

In D11890#376177, @cullmann wrote:

Shall we abandon this request?

In D17419#374064, @ngraham wrote:

Ah yeah, I guess that makes sense.

Falkon folks, is this acceptable?

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

That's for discussion with Breeze devs.

Then just use this icon, but make a symlink to private-mode.

Looks good, but please use KDE/KF5 coding style - QMenu *menu.

Yes, so there should be new icon in Breeze theme (eg. private-browsing or maybe better private-mode so it is more generic) and then Falkon can use it.

In D17288#369538, @GB_2 wrote:

But it looks very similar the original one.
What other icon should it be?

im-user has completely different meaning than "private browsing".

In D16082#359173, @ngraham wrote:

Maybe we could use a generic icon, or make a new one that depicts speakers plus headphones or something?

In D16082#356111, @thsurrel wrote:

So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack.

In D16082#356099, @thsurrel wrote:

So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ?

Looks good now, thanks. If you don't have dev account please send me your full name + email and I will commit it for you.

This will change the default list (EasyList) to be Spanish variant for all users.
You should instead change the url to Spanish subscriptions in AdBlockAddSubscriptionDialog

You should always use for on const Qt containers, as otherwise it will detach.
So it should be:

The patch doesn't apply:

INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16158.
Checking patch src/lib/other/statusbar.cpp...
error: while searching for:
void StatusBar::mousePressEvent(QMouseEvent *event)
{
    if (event->button()==Qt::RightButton) {
        QMenu *context = new QMenu;
        QAction *hide_bar = new QAction(tr("Hide"),this);
        connect(hide_bar,&QAction::triggered,m_window,&BrowserWindow::toggleShowStatusBar);
        context->addAction(hide_bar);
        context->exec(QCursor::pos());
    }
    QStatusBar::mousePressEvent(event);
error: patch failed: src/lib/other/statusbar.cpp:245
Applying patch src/lib/other/statusbar.cpp with 1 reject...
Rejected hunk #1.

Your full name + email please, so I can push it for you.

Thanks.
I'll need your full name + e-mail if you don't have dev account to push it.

In D15745#336662, @mweichselbaumer wrote:

In D15745#336644, @drosca wrote:

Remove NoInputNoOutputAgent and it's good to go.

Agree. Is it ok to move it to mediaendpointconnector?

These icon names are too specific and most likely only available in Breeze icon theme, so I don't think it should be used there.

Remove NoInputNoOutputAgent and it's good to go.

In D15745#336615, @mweichselbaumer wrote:

In D15745#336593, @drosca wrote:

Alright, last thing:

Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway.

Yes, i also thought this should be application specific. However, i could not imagine another use case of a NoInputNoOutputAgent, except from doing auto connecting to a limited set of UUIDs. So, i thought it is generic enough to be part of the library.

Alright, last thing:

Alright,
I'll need your full name + email to commit it for you.

I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and "input-volume" icons.

Translations should work on FreeBSD though, so please fix it another commit.

Also please fix build on FreeBSD: https://build.kde.org/job/Extragear/job/falkon/job/kf5-qt5%20FreeBSDQt5.11/6/console

Build is broken now: https://build.kde.org/job/Extragear/job/falkon/

In D15304#332755, @ngraham wrote:

Plasma items should not be used in KCM.

Hmm, what you you recommend then for showing an icon item? The old QIconItem breaks for fractional scale factors. Kirigami has a nice icon, but then we'd need to import Kirigami.

I suggest to fix QIconItem, as it is used in other places too.

It's now live at falkon.org

Centered navigation looks bad.

There is ScrollView in QQC2 (since Qt 5.9), so please use it.
Also as @davidedmundson said, please edit the commit message.

Can you please also upload screenshot of page with blog post? Like https://www.falkon.org/2018/05/08/falkon-301-released/

Looks good apart from the coding style.
Also it would be great to have at least basic autotest.

I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items.

In D15104#317776, @xyquadrat wrote:

I do not have commit access, so unless somebody has any objections to this change I'd be glad if you could land it for me. Thanks!