drosca (David Rosca)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 6:08 AM (169 w, 5 d)
Availability
Available

Recent Activity

Yesterday

drosca requested changes to D14214: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu.
Wed, Jul 18, 7:06 PM · Falkon

Tue, Jul 17

drosca committed R875:82c8d50f9a7f: [Feature] Add python plugin MiddleClickLoader (authored by SGOrava).
[Feature] Add python plugin MiddleClickLoader
Tue, Jul 17, 10:14 AM
drosca closed D14155: [Feature] Add python plugin MiddleClickLoader.
Tue, Jul 17, 10:14 AM · Falkon
drosca accepted D14155: [Feature] Add python plugin MiddleClickLoader.
Tue, Jul 17, 10:13 AM · Falkon
drosca added a comment to D14155: [Feature] Add python plugin MiddleClickLoader.

It's ok now. Your full name and e-mail please so I can commit it.

Tue, Jul 17, 9:42 AM · Falkon
drosca added a comment to D14155: [Feature] Add python plugin MiddleClickLoader.

Changes looks fine, but I can't apply it because you updated it incorrectly.

Tue, Jul 17, 9:28 AM · Falkon
drosca added inline comments to D14147: Port from GConf to GSettings.
Tue, Jul 17, 6:45 AM · Plasma

Mon, Jul 16

drosca requested changes to D14147: Port from GConf to GSettings.
Mon, Jul 16, 7:40 PM · Plasma
drosca added inline comments to D14155: [Feature] Add python plugin MiddleClickLoader.
Mon, Jul 16, 1:39 PM · Falkon
drosca requested changes to D14155: [Feature] Add python plugin MiddleClickLoader.

Looks good, but please rename the folder to lowercase middleclickloader.

Mon, Jul 16, 1:37 PM · Falkon
drosca added a comment to D14109: Add plugin MiddleClickLoader which fix issue 395688.

You can either update this or create new revision.

Mon, Jul 16, 7:27 AM · Falkon
drosca requested changes to D14147: Port from GConf to GSettings.

It still needs to keep GConf code for systems without gsettings pulseaudio module (eg. pulseaudio < 12.0).

Mon, Jul 16, 5:57 AM · Plasma

Sat, Jul 14

drosca accepted D13931: [KCM] Add speaker placement test.
Sat, Jul 14, 4:07 PM · Plasma
drosca added a comment to D14109: Add plugin MiddleClickLoader which fix issue 395688.

Sorry, I won't accept simple plugins like this written in C++ anymore. They should be done in Python or QML/JS (when available).

Sat, Jul 14, 11:54 AM · Falkon
drosca accepted D14056: Remove FileItemActionPlugin in favor of Purpose plugin.
Sat, Jul 14, 11:53 AM · Plasma
drosca added inline comments to D13931: [KCM] Add speaker placement test.
Sat, Jul 14, 11:51 AM · Plasma
drosca committed R115:8d7543ebd79e: Fix last merge - missing changes in src/CMakeLists.txt (authored by drosca).
Fix last merge - missing changes in src/CMakeLists.txt
Sat, Jul 14, 10:04 AM
drosca added a comment to D13734: Make GConf optional dependency.

Sorry, bad merge. Should be ok now.

Sat, Jul 14, 10:01 AM · Plasma
drosca added inline comments to D13931: [KCM] Add speaker placement test.
Sat, Jul 14, 7:15 AM · Plasma

Fri, Jul 13

drosca committed R115:c9fae1fb3f8e: Make GConf optional dependency (authored by drosca).
Make GConf optional dependency
Fri, Jul 13, 11:34 AM
drosca committed R115:d1cdada88baa: Merge branch 'Plasma/5.13' (authored by drosca).
Merge branch 'Plasma/5.13'
Fri, Jul 13, 11:34 AM
drosca closed D13734: Make GConf optional dependency.
Fri, Jul 13, 11:34 AM · Plasma

Thu, Jul 12

drosca added a comment to D13734: Make GConf optional dependency.
In D13734#291184, @apol wrote:

What's the advantage?

Thu, Jul 12, 2:51 PM · Plasma
drosca added a comment to D13734: Make GConf optional dependency.

Ping

Thu, Jul 12, 2:43 PM · Plasma
drosca resigned from D13935: Remove audio setup from Phonon KCM.
Thu, Jul 12, 2:43 PM · Plasma
drosca added a comment to D14056: Remove FileItemActionPlugin in favor of Purpose plugin.

Is it still available in Dolphin?

Thu, Jul 12, 2:42 PM · Plasma
drosca requested changes to D13931: [KCM] Add speaker placement test.

Looks much better now.

Thu, Jul 12, 2:28 PM · Plasma

Wed, Jul 11

drosca added a comment to D13931: [KCM] Add speaker placement test.

I can get the PulseObject, that is not the problem, the problem is that I can't access the model outside of a delegate. model[index] does not work because QAbstractItemModel does not implement the {} operator.

Wed, Jul 11, 4:00 PM · Plasma
drosca requested changes to D13931: [KCM] Add speaker placement test.

And the whole ComboBox/SinkModel code needs to be changed. You should be able to get the PulseObject from the model just with QML code (see invokables in https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/itemmodels/qabstractitemmodel.h).
Also I don't see purpose of that "changed" property.

Wed, Jul 11, 3:41 PM · Plasma

Sun, Jul 8

drosca committed R875:1cc053c7f1a0: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Sun, Jul 8, 7:13 PM
drosca committed R875:95e2232d39c0: DownloadManager: Don't try to percent decode filenames (authored by drosca).
DownloadManager: Don't try to percent decode filenames
Sun, Jul 8, 7:13 PM
drosca committed R875:53e0a4376252: NavigationBar: Correctly reconnect to page actions (authored by drosca).
NavigationBar: Correctly reconnect to page actions
Sun, Jul 8, 7:13 PM
drosca requested changes to D13931: [KCM] Add speaker placement test.
Sun, Jul 8, 6:48 AM · Plasma

Fri, Jun 29

drosca committed R115:ba737f478208: Fix wrong availability of profiles and ports. (authored by akrutzler).
Fix wrong availability of profiles and ports.
Fri, Jun 29, 7:41 AM
drosca closed D13694: Fix wrong availability of profiles and ports..
Fri, Jun 29, 7:41 AM · Plasma

Thu, Jun 28

drosca added a comment to T9091: Merge PulseAudio and Phonon KCM.

Strongly agree. Technically, this would solve a lot of problems, including allowing us to finally implement "Automatically switch all running streams when a new output becomes available" by default. See https://mail.kde.org/pipermail/plasma-devel/2018-March/083156.html (and the rest of the thread, for context).

Thu, Jun 28, 7:53 AM · Plasma
drosca added a comment to D13770: Only show available ports in port selection.

I don't think hiding it makes sense, indicating that it is unavailable/unplugged as pavucontrol does is enough.
User should see that pulse knows about those ports, but they are just not plugged so if user choose them, it won't play audio.

Thu, Jun 28, 7:47 AM · Plasma

Wed, Jun 27

drosca committed R875:60b7cbd9b6b0: Fix location of Info.plist file for macOS build (authored by chrstphrchvz).
Fix location of Info.plist file for macOS build
Wed, Jun 27, 3:42 PM
drosca closed D13736: Fix location of Info.plist file for macOS build.
Wed, Jun 27, 3:42 PM · Falkon
drosca added a comment to D13736: Fix location of Info.plist file for macOS build.

Do you have dev account?

Nope.

I do - is there a way I can push (from here) while retaining Christopher's authorship? I've seen others do it with my patches but have no idea how.

Wed, Jun 27, 1:17 PM · Falkon
drosca accepted D13751: [Device Monitor] Create KFilePlacesModel on demand.
Wed, Jun 27, 9:16 AM · Plasma

Tue, Jun 26

drosca accepted D13736: Fix location of Info.plist file for macOS build.

Do you have dev account?

Tue, Jun 26, 11:30 AM · Falkon
drosca committed R115:974bd408f719: SinkModel: Ignore virtual sinks for preferredSink (authored by drosca).
SinkModel: Ignore virtual sinks for preferredSink
Tue, Jun 26, 9:17 AM
drosca closed D13568: SinkModel: Ignore virtual sinks for preferredSink.
Tue, Jun 26, 9:17 AM · Plasma
drosca added a comment to D13694: Fix wrong availability of profiles and ports..

This breaks the profile selection Combobox in the KCM.

Tue, Jun 26, 9:11 AM · Plasma
drosca accepted D13225: Move methods to private class.
Tue, Jun 26, 9:08 AM · Plasma
drosca requested review of D13734: Make GConf optional dependency.
Tue, Jun 26, 8:58 AM · Plasma

Fri, Jun 22

drosca added a comment to D13673: Add Bing as search engine choice.

I regret this decision but at the same time I respect it.
Adding manually has an inconvenient for users, it does not permit to set up the search suggestions.

It would, if Bing supported OpenSearch as other search engines.

Fri, Jun 22, 9:49 AM · Falkon
drosca requested changes to D13673: Add Bing as search engine choice.

Sorry, I don't want Bing by default. You can always add it manually.

Fri, Jun 22, 9:01 AM · Falkon

Thu, Jun 21

drosca requested changes to D13648: fix for BUG 395424.
Thu, Jun 21, 10:28 AM · Falkon
drosca added a comment to D13648: fix for BUG 395424.

There was a reason it was like that, because QtWebEngine did in some version set QWebEngineDownloadItem::path() as percent encoded string. I'm not sure in which version it was fixed (if it was?), but in any case this patch seems wrong. If the path() is no longer percent encoded, QUrl::fromPercentEncoded can be just removed, instead of percent encoding the string and then decoding it again.

Thu, Jun 21, 10:28 AM · Falkon

Jun 18 2018

drosca committed R875:633748a815de: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Jun 18 2018, 11:42 AM
drosca committed R875:4c83ba3d6c60: PyFalkon: Fix build with PySide2 release (authored by drosca).
PyFalkon: Fix build with PySide2 release
Jun 18 2018, 11:42 AM

Jun 16 2018

drosca requested review of D13568: SinkModel: Ignore virtual sinks for preferredSink.
Jun 16 2018, 10:58 AM · Plasma

Jun 12 2018

drosca committed R875:7b2ff1600478: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Jun 12 2018, 7:14 AM
drosca committed R875:9f0f688ee8ed: Use QTWEBENGINE_VERSION instead of QT_VERSION (authored by drosca).
Use QTWEBENGINE_VERSION instead of QT_VERSION
Jun 12 2018, 7:14 AM

Jun 6 2018

drosca accepted D13385: Fix #394905.

This should go to Falkon/3.0.

Jun 6 2018, 7:04 PM · Windows, Falkon

Jun 5 2018

drosca accepted D13346: Use more contextual strings for some button labels.
Jun 5 2018, 7:48 AM · Plasma

Jun 4 2018

drosca committed R269:41b41939c028: Add signal for devices's address changing (authored by andreysemenov).
Add signal for devices's address changing
Jun 4 2018, 9:06 AM
drosca closed D13268: Add signal for devices's address changing.
Jun 4 2018, 9:06 AM · Frameworks
drosca added a comment to D13268: Add signal for devices's address changing.

Do you have a dev account?

I think i don't.

Jun 4 2018, 8:58 AM · Frameworks
drosca added a comment to D13268: Add signal for devices's address changing.

Do you have a dev account?

Jun 4 2018, 8:53 AM · Frameworks

Jun 1 2018

drosca accepted D13268: Add signal for devices's address changing.
Jun 1 2018, 3:55 PM · Frameworks
drosca committed R875:72547e0bd932: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
Jun 1 2018, 10:59 AM
drosca committed R875:35d8f25fd4a1: GreaseMonkey: Return undefined when value was not found in GM_getValue (authored by drosca).
GreaseMonkey: Return undefined when value was not found in GM_getValue
Jun 1 2018, 10:59 AM

May 30 2018

drosca accepted D13199: Move updateDevice to private class.
May 30 2018, 8:52 AM · Plasma

May 28 2018

drosca added a comment to D13178: Compress calls to configuration slots upon new connections.

Is there any reason for this, except save some cycles?

May 28 2018, 6:04 PM · Plasma

May 26 2018

drosca committed R875:0f1c46d0e760: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
May 26 2018, 6:13 PM
drosca committed R875:7c07af64feba: AdBlockManager: Temporarily remove url interceptor when updating matcher (authored by drosca).
AdBlockManager: Temporarily remove url interceptor when updating matcher
May 26 2018, 6:13 PM
drosca committed R875:42f70c5252d4: Add missing config.h include for HAVE_QTWEBENGINE_5_10 define (authored by drosca).
Add missing config.h include for HAVE_QTWEBENGINE_5_10 define
May 26 2018, 6:13 PM
drosca committed R994:ab8b006f5104: Use C++ keywords instead of Qt compat macros (authored by drosca).
Use C++ keywords instead of Qt compat macros
May 26 2018, 6:02 PM
drosca committed R994:a1d30716d271: Remove Q_INVOKABLE from methods (authored by drosca).
Remove Q_INVOKABLE from methods
May 26 2018, 6:02 PM
drosca added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Looks fine, except some issues with methods that should be hidden:

May 26 2018, 5:59 PM · Plasma, KDE Connect, Frameworks

May 25 2018

drosca accepted D13109: Added sorting in cookie filter list.
May 25 2018, 6:20 PM · Falkon
drosca committed R875:326be38a45d4: Allow whitelisted cookies to be kept (authored by tuomisto).
Allow whitelisted cookies to be kept
May 25 2018, 7:36 AM
drosca closed D13097: Allow whitelisted cookies to be kept.
May 25 2018, 7:36 AM · Falkon

May 24 2018

drosca accepted D13097: Allow whitelisted cookies to be kept.
May 24 2018, 7:05 PM · Falkon
drosca requested changes to D13097: Allow whitelisted cookies to be kept.

I think it should keep whitelisted cookies every time (it worked like that in QtWebKit version), so it's not needed to make it configurable.

May 24 2018, 5:08 PM · Falkon

May 20 2018

drosca committed R875:52d4e3583b67: Fix build (authored by drosca).
Fix build
May 20 2018, 8:19 AM

May 19 2018

drosca accepted D12980: Use IMPORTED_TARGET for GnomeKeyring..

Into Falkon/3.0 please.

May 19 2018, 12:22 PM · Falkon

May 14 2018

drosca committed R875:148d2d94c11d: Use QTWEBENGINE_VERSION instead of QT_VERSION (authored by drosca).
Use QTWEBENGINE_VERSION instead of QT_VERSION
May 14 2018, 11:56 AM
drosca committed R875:e01024942fa1: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
May 14 2018, 11:56 AM
drosca committed R875:e8fa25e058ac: WebSearchBar: Set as focus proxy of engines button (authored by drosca).
WebSearchBar: Set as focus proxy of engines button
May 14 2018, 11:56 AM

May 13 2018

drosca accepted D12846: KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla.
May 13 2018, 10:10 AM · Falkon

May 12 2018

drosca accepted D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.
May 12 2018, 11:16 AM · Falkon
drosca added a comment to D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.

Also, all the existing macros in config.h.cmake are #cmakedefine, not #cmakedefine01, so are you sure you want the latter even though it would be inconsistent?

May 12 2018, 10:53 AM · Falkon
drosca requested changes to D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.

This should be done for all QtWebEngine checks (5.10, 5.11) and should be in config.h with #cmakedefine01 so it can be used as #if HAVE_QTWEBENGINE_5_10

May 12 2018, 7:09 AM · Falkon

May 9 2018

drosca committed R875:3760a9ffd173: AppImage: Bundle KWindowSystem plugins (authored by drosca).
AppImage: Bundle KWindowSystem plugins
May 9 2018, 4:12 PM

May 8 2018

drosca committed R875:4bf77cd4d1c3: Version 3.0.1 (authored by drosca).
Version 3.0.1
May 8 2018, 2:18 PM
drosca committed R875:5c557c8484ba: Preferences: Add checkboxes to spellcheck language list (authored by drosca).
Preferences: Add checkboxes to spellcheck language list
May 8 2018, 9:56 AM
drosca committed R875:3ad6b80d49a7: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
May 8 2018, 9:39 AM
drosca committed R875:4454ac714c99: NavigationBar: Focus webview when navigating back/forward (authored by drosca).
NavigationBar: Focus webview when navigating back/forward
May 8 2018, 9:39 AM
drosca committed R875:6e3da02d7dc1: ClosedTabsManager: Save and restore parent tab (authored by drosca).
ClosedTabsManager: Save and restore parent tab
May 8 2018, 9:39 AM

May 7 2018

drosca added a comment to D4140: Rework playing of volume feedback.
In D4140#259101, @apol wrote:

Could we maybe accept this?

May 7 2018, 2:35 PM · Plasma
drosca committed R875:68ff092b4ced: Update AppImage build Dockerfile (authored by drosca).
Update AppImage build Dockerfile
May 7 2018, 11:34 AM

May 3 2018

drosca committed R875:7fce81feaa65: Merge branch 'Falkon/3.0' (authored by drosca).
Merge branch 'Falkon/3.0'
May 3 2018, 11:46 AM
drosca committed R875:9375b474bac5: BrowserWindow: Track webview that initiated html fullscreen (authored by drosca).
BrowserWindow: Track webview that initiated html fullscreen
May 3 2018, 11:46 AM

May 2 2018

drosca accepted D12666: Use security state icon in popup location bar.
May 2 2018, 3:18 PM · Falkon
drosca requested changes to D12666: Use security state icon in popup location bar.
May 2 2018, 3:06 PM · Falkon

May 1 2018

drosca committed R875:dd8d8b9007c9: Add Dockerfile for building AppImage (authored by drosca).
Add Dockerfile for building AppImage
May 1 2018, 9:01 PM