[kdecoration] Make shadows lighter
ClosedPublic

Authored by zzag on Jul 15 2018, 2:02 PM.

Details

Summary
Small

Before:

After:

Medium

Before:

After:

Large

Before:

After:

Very large

Before:

After:

With normal background

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 15 2018, 2:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 15 2018, 2:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Jul 15 2018, 2:02 PM
zzag edited the summary of this revision. (Show Details)Jul 15 2018, 2:04 PM
zzag edited the summary of this revision. (Show Details)
zzag retitled this revision from [kdecoration] Make shadows lighter to WIP: [kdecoration] Make shadows lighter.Jul 15 2018, 2:07 PM
ngraham added a comment.EditedJul 15 2018, 2:07 PM

A little lightening is OK, but IMHO the problem here is not so much the darkness, but how much darker the bottom edge is than the sides. It's just a bit too much. My recommendation would be to move the shadow boxes up a few pixels.

zzag updated this revision to Diff 37803.Jul 15 2018, 2:35 PM

Move box shadows up

zzag added a comment.Jul 15 2018, 2:37 PM

Slightly moved box shadows

Small:

Medium:

Large:

Very large:

zzag added a comment.Jul 15 2018, 2:43 PM

Maybe, we should make contrast/ambiance shadows lighter...

zzag updated this revision to Diff 37805.Jul 15 2018, 2:48 PM

Make key shadow lighter for Large and Very large shadows

+1, I definitely prefer the version with the shadow box moved up a bit with a little bit of lightening. I think that looks fantastic!

zzag updated this revision to Diff 37810.Jul 15 2018, 3:28 PM

Tweak small and medium shadows

zzag edited the summary of this revision. (Show Details)Jul 15 2018, 3:30 PM
ngraham accepted this revision.Jul 15 2018, 3:32 PM

An excellent tweak. I think this looks better--more subtle and more professional, but still retains the original goal. Good for you for listening to user feedback, too. :)

This revision is now accepted and ready to land.Jul 15 2018, 3:32 PM
zzag retitled this revision from WIP: [kdecoration] Make shadows lighter to [kdecoration] Make shadows lighter.Jul 15 2018, 3:34 PM
zzag edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.