BUG: 396262
Details
Details
Diff Detail
Diff Detail
- Repository
- R219 KIO GDrive
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The <screenshot> tag is not closed, thus creating an invalid XML. Use appstreamcli validate org.kde.kio_gdrive.appdata.xml to make sure it is also a valid appstream XML.
Also, please provide better commit message for this patch, not just "re: bug #..." and a bugzilla link -- describe what the commit does, i.e. adding a screenshot to the appdata file.
Comment Actions
Hi Pino,
Thanks for catching that error, I'm embarrassed to have missed it. My commit message is in the subject header of the patch, suitable for use with git am. Does phabricator support git remotes as sources? If so, please pull from the upstream-PR branch of https://salsa.debian.org/qt-kde-team/extras/kio-gdrive.git
Cheers,
Nicholas
Comment Actions
Thanks for the patch!
You can edit the revision using the buttons in the web interface on the right-hand side of the page, or under the Actions button. Which is handy to know, because this patch needs a few formatting changes:
- The title becomes the commit message, so please adjust it to follow commit message best practices. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
- In the Summary section, please change https://bugs.kde.org/show_bug.cgi?id=396262 to BUG: 396262. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords
Since this patch was submitted using the web interface rather than arc, we'll need a real name and email address to associate with you when it lands. Can you provide this information?
Also, since it seems that you're familiar with git and source control, you might find it more enjoyable to post patches using the arc command-line tool. This simplifies things and makes use of the metadata in your git commit for the patch here. See https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Oh, and also please fix the issue @pino described. :)
Comment Actions
There, I rebased on master, squashed the fixup commit, and used arc diff to submit. https://phabricator.kde.org/D14937
I tried arc diff --update 14119 (and other numeric revision-like numbers in this thread) to try to update it, without success.
Comment Actions
arc diff --update D14119
Please close D14937: Add screenshot to gdrive.appdata.xml., and update this one instead.
| desktop/org.kde.kio_gdrive.appdata.xml | ||
|---|---|---|
| 90 | Qupzilla is not longer the name of the browser, it's Falkon. | |
| desktop/org.kde.kio_gdrive.appdata.xml | ||
|---|---|---|
| 90 |
The screenshot contains QupZilla, not Falkon. It would be awkward to say "here is Falkon" while actually it is not. | |
Comment Actions
@pino thank you, I was replying with that message too :-)
@anthonyfieroni maybe file bugs for any packages that still have screenshots using QupZilla? I agree that it would be better for them to use Falkon!
Comment Actions
The screenshot needs to be on cdn.kde.org anyway, so while at it I'd just make a new one with Falkon instead of Qupzilla (I'll try to do it later today)
| desktop/org.kde.kio_gdrive.appdata.xml | ||
|---|---|---|
| 91 | Please use https://cdn.kde.org/screenshots/kio-gdrive/kio-gdrive.png (as soon as the CDN loads it). | |
Comment Actions
@elvisangelaccio, does the Information Panel not load and show metadata on gdrive, or is your information panel just broken in master? If it's broken on master for you, then we need to fix something because mine is too...
Comment Actions
The information panel does not load metadata for remote urls (which gdrive is). It should work for local urls though, try to do a clean build for dolphin.
Comment Actions
Weird, I thought using arc would have taken care of inheriting this from my
commits... Here is the relevant info from my gitconfig:
Nicholas D Steeves
email = nsteeves@gmail.com signingkey = E2A6261E3900AED7CDC667085A8830475F7D1061
That key is on public keyservers and is the one I use in Debian...not
sure if that matters, since from what I can tell Arcanist/Phabricator
discards signatures.
Cheers,
Nicholas