- User Since
- Jul 27 2015, 2:36 PM (155 w, 3 d)
Fix accepting of left key event and use Row instead of ButtonRow
Wed, Jul 18
Do not yet introduce any keyboard handling (escape snuck in) and remove clutter (assert, visible:true).
Fixed keyboard bindings breaking all the time, as indicated in review
Fix hiding of osds
Tue, Jul 17
return qstring without ref
Awesome! I'll incorporate the ideas, that's great. Any chance to get https://phabricator.kde.org/D14143 in? It's required for this since it changes the window type. I'd also like to make the global shortcut show and hide the osd (right now pressing it again makes the osd fade out and in again).
I'd say make the casing consistent, otherwise it's a clear improvement in my opinion.
Re-added the const
Mon, Jul 16
Remove string ref in return.
Sun, Jul 15
arc squashed https://phabricator.kde.org/D14143 into this :( Tool failure.
Sat, Jul 14
Fixed placement of *
Added * to auto pointers
Thu, Jul 12
Is this a duplicate of https://phabricator.kde.org/T3464 ?
I think micro-optimizing the tests further is simply not worth anyone's time. I'd propose taking this in (and if you spot more things, do them on top of this change).
Fixed some of Kai's comments, some minor things are still to do.
Wed, Jul 11
Yes, this is partially to shut up clazy.
Pushed, sadly without the phabricator tag, since I'm struggling to manage > 1 patch with phabricator.