- User Since
- Jul 27 2015, 2:36 PM (211 w, 6 d)
Fri, Aug 16
Yes, so for size hints, this should be fine. For actually placing individual chars and calculating their width in the terminal window I didn't dare changing things.
Wed, Aug 14
Tue, Aug 13
Use #if defined consistently
This is interesting, since it's around the corner from this crash: https://bugs.kde.org/show_bug.cgi?id=399499 - But of course this patch won't change anything, just make it slightly easier to see what's going on.
Mon, Aug 12
Hi @romangg, I did not test this. I added inline comments explaining why the code is completely unchanged. It does 100% the same as before, just without the duplication. All you need is to invert the two conditions inside the ifs and switch the else branch with the first branch of the if and you'll arrive at this.
Sun, Aug 11
OK, now this should apply :)
Put the check back for now, we spin a nested event loop. Let's remove the check in an independent patch - if at all.
Also add curly braces.
Removed to nullptr checks - after testing manually, I cannot get it to crash with the close menu entry, so I assume this is fine indeed.
I played with this after spending some time to get a working wayland session. I could not see any problems, decorations work, the touch point visualization also works.
The patch should apply cleanly on top of https://phabricator.kde.org/D23067
Fix up commit message
I hope this is now making the code slightly easier to read, without changing the functionallity, except for shuffling things around a tiny bit where we discussed. It also adds a few extra checks, to play safe with the smart pointers. These nullptr checks are extremely cheap.
Removed, cast, made if one line.
Also removed shortCaption which was only used by tab group.
Fix up a few more places (mostly isCurrentTab related)
Sat, Aug 10
Restored tabbox code
Attempt to remove entire tabgroup feature.
Removed first nullptr check
better commit message
improve commit message
And that's exactly it: there is no QSharedPointer involved here at all.
Improve commit message
Fix commit message
I just removed the obviously dead bits behind an if (false). If someone wants to bring it back, it's always in the git history. I don't care either way, but to me reducing lines of code is generally a good thing.