gladhorn (Frederik Gladhorn)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 27 2015, 2:36 PM (172 w, 1 d)
Availability
Available

Recent Activity

Mon, Nov 12

gladhorn added a comment to T10019: Kate issues.

https://codereview.qt-project.org/#/c/245319/ presumably fixes the keys not being sent.

Mon, Nov 12, 8:02 PM · Plasma Accessibility

Sat, Nov 10

gladhorn triaged T10019: Kate issues as Normal priority.
Sat, Nov 10, 10:17 AM · Plasma Accessibility

Wed, Nov 7

gladhorn closed T7034: Accessibility in KWin window switcher as Resolved.
Wed, Nov 7, 7:38 AM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Yes, I hope so :) it would be great to have anyone else report success, but I think it's done.

Wed, Nov 7, 7:38 AM · Plasma Accessibility

Mon, Nov 5

gladhorn committed R120:bf9e6a4062dc: Add accessibility and set focus on the actual items in the window switcher (authored by gladhorn).
Add accessibility and set focus on the actual items in the window switcher
Mon, Nov 5, 8:54 PM
gladhorn moved T9933: Lock Screen Password dialog from Todo to Done on the Plasma Accessibility board.

I just tested again, it doesn't read what I'm typing as long as the input is focused, so I guess this was a false alarm.

Mon, Nov 5, 8:54 PM · Plasma Accessibility
gladhorn closed D16638: Add accessibility and set focus on the actual items in the window switcher.

This is in I'm unsure why "arc land" didn't close it.

Mon, Nov 5, 8:52 PM · Plasma
gladhorn moved T7034: Accessibility in KWin window switcher from In progress to Done on the Plasma Accessibility board.
Mon, Nov 5, 8:49 PM · Plasma Accessibility
gladhorn updated the diff for D16638: Add accessibility and set focus on the actual items in the window switcher.

Changed it to be more pleasant by using client as role and set the focus on the top level, so that the geometry is also more sensible.

Mon, Nov 5, 5:49 PM · Plasma
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Yes, it looks like this will work.

Mon, Nov 5, 5:37 PM · Plasma Accessibility
gladhorn updated the diff for D16638: Add accessibility and set focus on the actual items in the window switcher.

After the change in KWin only this is needed

Mon, Nov 5, 5:30 PM · Plasma
gladhorn committed R108:66986d4afddc: Make QPA think the tabbox is the active window (authored by gladhorn).
Make QPA think the tabbox is the active window
Mon, Nov 5, 5:22 PM
gladhorn closed D16664: Make QPA think the tabbox is the active window.
Mon, Nov 5, 5:22 PM · KWin
gladhorn added a comment to D16664: Make QPA think the tabbox is the active window.

Awesome, thanks.

Mon, Nov 5, 5:21 PM · KWin
gladhorn updated the diff for D16664: Make QPA think the tabbox is the active window.

Use qpa api instead of actually requesting the window to be activated.

Mon, Nov 5, 5:16 PM · KWin
gladhorn committed R365:41c6b345d433: Add perl-yaml-libyaml for arch and make FirstRun use pacman (authored by gladhorn).
Add perl-yaml-libyaml for arch and make FirstRun use pacman
Mon, Nov 5, 5:16 PM

Sun, Nov 4

gladhorn added a comment to D16638: Add accessibility and set focus on the actual items in the window switcher.

It looks like I need either forceActiveFocus or to remove the window manager bypass hint. Or find some other way to get the focus on the window...

Sun, Nov 4, 7:50 PM · Plasma
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

OK, I seem to have reached something surprisingly simple: D16638 and D16664 give me a tab box that works with Orca.
The requestActivate is needed to get the focus into the window, the window manager hint has to go (are there side-effects?) and after that pressing alt-tab announces a window containing labels for all other windows. The role should be adjusted, but compared to everything else that should be rather trivial.

Sun, Nov 4, 7:37 PM · Plasma Accessibility
gladhorn requested review of D16664: Make QPA think the tabbox is the active window.
Sun, Nov 4, 4:37 PM · KWin
gladhorn updated the diff for D16638: Add accessibility and set focus on the actual items in the window switcher.

Removed Qt.X11BypassWindowManagerHint which makes everything work

Sun, Nov 4, 4:32 PM · Plasma
gladhorn closed D16655: Remove unused private Qt include.
Sun, Nov 4, 4:02 PM · KWin
gladhorn committed R108:456cbb9bf73c: Remove unused private Qt include (authored by gladhorn).
Remove unused private Qt include
Sun, Nov 4, 4:02 PM
gladhorn committed R108:503661579fff: Remove unused FindQt5PlatformSupport.cmake (authored by gladhorn).
Remove unused FindQt5PlatformSupport.cmake
Sun, Nov 4, 4:01 PM
gladhorn closed D16654: Remove unused FindQt5PlatformSupport.cmake.
Sun, Nov 4, 4:01 PM · KWin
gladhorn added inline comments to D16638: Add accessibility and set focus on the actual items in the window switcher.
Sun, Nov 4, 12:31 PM · Plasma
gladhorn updated the diff for D16654: Remove unused FindQt5PlatformSupport.cmake.

Updated to remove more legacy code.

Sun, Nov 4, 12:25 PM · KWin
gladhorn added a comment to D16654: Remove unused FindQt5PlatformSupport.cmake.

Ouch, I overlooked that, good catch.

Sun, Nov 4, 12:21 PM · KWin
gladhorn requested review of D16655: Remove unused private Qt include.
Sun, Nov 4, 8:12 AM · KWin
gladhorn accepted D16383: Add accessibility information to tabbar in dash starter.

I think this looks good :) Feel free to push.

Sun, Nov 4, 8:09 AM · Plasma Accessibility
gladhorn requested review of D16654: Remove unused FindQt5PlatformSupport.cmake.
Sun, Nov 4, 7:46 AM · KWin

Sat, Nov 3

gladhorn added a task to D16638: Add accessibility and set focus on the actual items in the window switcher: T7034: Accessibility in KWin window switcher.
Sat, Nov 3, 4:19 PM · Plasma
gladhorn added a revision to T7034: Accessibility in KWin window switcher: D16638: Add accessibility and set focus on the actual items in the window switcher.
Sat, Nov 3, 4:19 PM · Plasma Accessibility
gladhorn requested review of D16638: Add accessibility and set focus on the actual items in the window switcher.
Sat, Nov 3, 4:17 PM · Plasma
gladhorn requested review of D16634: Add command line app to dump accessibility tree of apps.
Sat, Nov 3, 11:30 AM
gladhorn requested review of D16632: Add helper to print state of an AccessibleObject.
Sat, Nov 3, 11:30 AM
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

I have been a fool :) I just found that KWin actually does create accessible interfaces for the window switcher since it uses QML and we added accessibility information in some form... What is missing is only pretending that the task switcher window is the active window and maybe sending focus events. That should make this task quite a bit smaller (and I get to throw away my proof of concept code and start over).

Sat, Nov 3, 9:39 AM · Plasma Accessibility

Fri, Nov 2

gladhorn committed R108:501c6806c72a: cleanup (authored by gladhorn).
cleanup
Fri, Nov 2, 4:27 PM
gladhorn committed R108:cf58ecfedb47: namespace and get the focus on the virtual window (authored by gladhorn).
namespace and get the focus on the virtual window
Fri, Nov 2, 3:08 PM
gladhorn committed R108:eb9e864ad2cb: More sensible updates, stuff (authored by gladhorn).
More sensible updates, stuff
Fri, Nov 2, 3:08 PM
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Yes, I'd love it if we do give KWin focus - it would make things just work for accessibility, so in that sense it's the right solution. I just had the feeling that it would be close to impossible to convince the KWin maintainers to go that way.
I already have a proof of concept that informs of the Windows that are open - I just need to figure out how to best send updates and do a proper model for memory management of the stuff I wrote, currently I wouldn't be surprised if it crashes and leaks, I just wanted to see that it's doable at all...

Fri, Nov 2, 1:43 PM · Plasma Accessibility
gladhorn committed R108:8ce12fa13b25: Add children for the windows (authored by gladhorn).
Add children for the windows
Fri, Nov 2, 6:34 AM
gladhorn committed R108:814de0315583: Implement accessibility for TabBox (window switcher) (authored by gladhorn).
Implement accessibility for TabBox (window switcher)
Fri, Nov 2, 6:34 AM

Thu, Nov 1

gladhorn added a comment to T7034: Accessibility in KWin window switcher.

I now have a very hackish proof of concept. It shows KWin as application on the accessibility dbus session. It has one child (a virtual main window) with children for the "clients" as KWin calls the windows. There are no updates sent yet, so Orca will not read anything. In addition I'm leaking memory, so this needs a day of cleanup. But I think in principle it will work.

Thu, Nov 1, 8:32 PM · Plasma Accessibility

Wed, Oct 31

gladhorn committed R108:abceccbb6600: Remove unused captures from lambdas (authored by gladhorn).
Remove unused captures from lambdas
Wed, Oct 31, 8:40 AM
gladhorn closed D16481: Remove unused captures from lambdas.
Wed, Oct 31, 8:40 AM · KWin
gladhorn committed R108:04bbe1003882: Remove dead default branches (authored by gladhorn).
Remove dead default branches
Wed, Oct 31, 8:24 AM
gladhorn closed D16480: Remove dead default branches.
Wed, Oct 31, 8:24 AM · KWin
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

My plan was not to change anything regarding x11/wayland at all. It can be done purely on the accessibility level - faking it completely.

Wed, Oct 31, 8:19 AM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

My only concern is that if I implement a (virtual) window for accessibility only for the task switcher, Orca would probably read the window before reading the focus inside it. But that may be fine.
"task switcher" -> "firefox window". I'll try writing it in the near future and let others play with it. In the worst case we can then use Orca scripts, if people find announcing the tab switcher window to be a nuisance.

Wed, Oct 31, 7:45 AM · Plasma Accessibility
gladhorn added a comment to D16479: Use override for tabbox classes.

So far I always said no to such changes as it doesn't really offer advantages for done code and just clutters the commit history.

I do think there is a bit advantage: When refactoring and a base classes' function gets renamed, any overriding virtuals will stop compiling, so this kind of change makes the code more future-proof.

I fully understand the advantage of override. I do add it to new code. I'm questioning the advantage of adding it to old and done code. Nobody has touched these classes for years and there won't be any reason to do so for years. And even if one would touch it, it's as simple as doing the change to add override then.

My point against such a change is that we either need to do this for all of KWin or not at all. And for all of KWin I think it's a bad idea as it introduces a commit breaking any git blame. Would you +1 such a change in Qt changing all overriding methods to override?

Wed, Oct 31, 7:41 AM · KWin

Tue, Oct 30

gladhorn added a comment to D16383: Add accessibility information to tabbar in dash starter.

Nice, this looks good to me. I don't know the code though, so it would be great to hear what people more familiar with it say.

Tue, Oct 30, 8:48 AM · Plasma Accessibility

Mon, Oct 29

gladhorn added a comment to D16479: Use override for tabbox classes.

So far I always said no to such changes as it doesn't really offer advantages for done code and just clutters the commit history.

Mon, Oct 29, 8:47 AM · KWin

Sun, Oct 28

gladhorn added a comment to T9878: Default application starter menu is missing a11y Labels.

@chempfling let's chat about Qt Quick focus indeed, it's complicated. The problem comes mostly from the fact that initially Qt Quick provided only basic primitives, which were not on the right semantic level for accessibility. We tried some experiments to automatically give every text element an accessible name, but that was not really the way to go as for example buttons should have more properties and would contain the text as child. Therefore the level to implement accessibility became a duty for those building on top of the primitives. Which makes it hard to enforce it. I agree we should try to write rules. There is movement in the human interface guidelines department for KDE, maybe they should be extended. For a long time nobody was pushing to fix these issues, so they have been spreading. On the other hand nowadays things have become much more stable, so making an effort is certainly worth it and appreciated by everyone. Some of the plasmoid code is very old and has simply grown before the standard components were available.

Sun, Oct 28, 12:33 PM · Plasma Accessibility
gladhorn added a comment to D16383: Add accessibility information to tabbar in dash starter.

@chempfling what do you think? Would it be possible to label the buttons inside the tab bar instead?

Sun, Oct 28, 12:28 PM · Plasma Accessibility
gladhorn moved T7038: System settings: keyboard navigation in the sidebar from In progress to Todo on the Plasma Accessibility board.
Sun, Oct 28, 12:21 PM · Plasma Accessibility
gladhorn added a comment to T7038: System settings: keyboard navigation in the sidebar.

I don't think there's any ongoing progress, @mart any plans about this?

Sun, Oct 28, 12:21 PM · Plasma Accessibility
gladhorn moved T7033: Improve NetworkManager applet navigation from In progress to Todo on the Plasma Accessibility board.
Sun, Oct 28, 12:20 PM · Plasma Accessibility
gladhorn updated subscribers of T7033: Improve NetworkManager applet navigation.

@davidedmundson do you have plans about this? @chempfling did you play with the network settings? Is there even any way to open the plasmoid at this point in time? I'll put this back to todo for now.

Sun, Oct 28, 12:20 PM · Plasma Accessibility
gladhorn added a comment to T7031: Panel focus on shortcut.

Hmm, deviating too much from what sighted users see is always a problem because it will not be maintained when the other code changes. The flexibility of plasma is hard here in many ways - we cannot make assumptions what kind of panels there will be etc.
On the other hand I'd really try to get the defaults to work first. So assuming there is one panel, making sure that can be navigated with the keyboard and we can get the relevant information conveyed to blind users would be my starting point.

Sun, Oct 28, 12:18 PM · Plasma Accessibility
gladhorn requested review of D16481: Remove unused captures from lambdas.
Sun, Oct 28, 11:55 AM · KWin
gladhorn requested review of D16480: Remove dead default branches.
Sun, Oct 28, 11:55 AM · KWin
gladhorn requested review of D16479: Use override for tabbox classes.
Sun, Oct 28, 11:54 AM · KWin
gladhorn committed R108:951dfd10366b: Minor grammar fixup in comment (authored by gladhorn).
Minor grammar fixup in comment
Sun, Oct 28, 11:53 AM
gladhorn committed R108:7d1d28ea2cd5: Remove extra semicolon (authored by gladhorn).
Remove extra semicolon
Sun, Oct 28, 11:53 AM
gladhorn claimed T7034: Accessibility in KWin window switcher.
Sun, Oct 28, 9:45 AM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

My current thinking is:
KWin shows up as accessible application with no children.
Create an accessible window inside that application. This window has no relation to any other object but will probably make things less confusing for screen readers. It can also become the active window for screen reader purposes when interacting with KWin.

Sun, Oct 28, 9:44 AM · Plasma Accessibility

Sat, Oct 27

gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Next to the window switching, there is also desktop switching (virtual desktops) which I consider secondary (but it may be fixed with the same change).

Sat, Oct 27, 5:26 PM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

The common way is to use Alt-Tab to switch windows. Currently Orca does not react to alt-tab while alt is held, but once a new window gains focus, it is read.
So for me this would mostly about enabling the reading of window titles while alt is pressed.
My understanding is that there is luckily a centralized component in KWin which deals with this. kwin/tabbox seems like the relevant files.

Sat, Oct 27, 5:24 PM · Plasma Accessibility
gladhorn triaged T9933: Lock Screen Password dialog as Normal priority.
Sat, Oct 27, 5:21 PM · Plasma Accessibility

Mon, Oct 22

gladhorn added a comment to T9869: Desktop Icons should have an a11y Label.

Congratulations :)

Mon, Oct 22, 12:17 PM · Plasma Accessibility

Fri, Oct 19

gladhorn added a comment to D16309: Add accessibility information to desktop icons.

I guess we can go with this for now, let's be pragmatic. Qt doesn't have icon or desktop_icon at the moment. I can add, if Joanie suggests doing that on the Orca mailing list.

Fri, Oct 19, 2:58 PM · Plasma
gladhorn accepted D16309: Add accessibility information to desktop icons.
Fri, Oct 19, 12:44 PM · Plasma

Thu, Oct 18

gladhorn added a comment to T9878: Default application starter menu is missing a11y Labels.

I think the menus live in git://anongit.kde.org/plasma-desktop - there is all kinds of desktop related stuff - kicker and kickoff are subdirectories in that repository.

Thu, Oct 18, 7:00 PM · Plasma Accessibility
gladhorn added a comment to T9869: Desktop Icons should have an a11y Label.

We have some information on https://community.kde.org/Infrastructure/Phabricator - there are two options, uploading the file to https://phabricator.kde.org/differential/ or using a command line tool. Please add "gladhorn" and "hein" as reviewers so we can get it in quickly :)

Thu, Oct 18, 11:32 AM · Plasma Accessibility
gladhorn added a comment to T9869: Desktop Icons should have an a11y Label.

Oh wow, this is super awesome! Yay!!!!
The next step is to get your patch in of course. Do you want to put it up for review on phabricator?

Thu, Oct 18, 8:05 AM · Plasma Accessibility

Wed, Oct 17

gladhorn added a comment to T9869: Desktop Icons should have an a11y Label.

@chempfling is that enough to get you started? I'm a bit short on time, so if you make progress alone that's perfect, but as soon as you are stuck in any way you can ask @hein and me for help. Please ask away. You can probably even modify the installed file to test changes directly and then just restart plasma-shell - to make quick iterations possible. Just be careful not to lose the changes when they work :)

Wed, Oct 17, 2:01 PM · Plasma Accessibility
gladhorn updated subscribers of T9869: Desktop Icons should have an a11y Label.

OK, let's work on that! @hein will help as well.

Wed, Oct 17, 1:51 PM · Plasma Accessibility

Mon, Oct 15

gladhorn added a comment to T9870: Kicker "Application Overview" missing a11y Label for "apps and documentation" and "Miniprograms".

With kicker you mean the default start menu?

Mon, Oct 15, 9:22 PM · Plasma Accessibility
gladhorn added a comment to T9869: Desktop Icons should have an a11y Label.

I don't even see how to keyboard focus the desktop. Do you manage that somehow?

Mon, Oct 15, 9:19 PM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

I think this is one of the most important tasks for screen reader users. I assume we'll have to contact the KWin developers. Ideally after doing a bit of research how other window managers solve this.

Mon, Oct 15, 9:16 PM · Plasma Accessibility
gladhorn moved T7030: Merge QtWayland support from In progress to Done on the Plasma Accessibility board.

https://codereview.qt-project.org/#/c/205728/ made it in :)

Mon, Oct 15, 9:15 PM · Plasma Accessibility

Oct 14 2018

gladhorn committed R954:c5c3da805e62: Add Frederik's newer blog (authored by gladhorn).
Add Frederik's newer blog
Oct 14 2018, 12:27 PM
gladhorn added a comment to T7030: Merge QtWayland support.

https://codereview.qt-project.org/#/c/205728/ - @gladhorn needs to get this sorted out...

Oct 14 2018, 12:02 PM · Plasma Accessibility
gladhorn renamed T7033: Improve NetworkManager applet navigation from Improve NM applet navigation to Improve NetworkManager applet navigation.
Oct 14 2018, 12:01 PM · Plasma Accessibility

Sep 29 2018

gladhorn committed R37:3f7918c4c747: Fix warnings about implicit cast when using newer Vc (authored by gladhorn).
Fix warnings about implicit cast when using newer Vc
Sep 29 2018, 9:08 AM
gladhorn committed R37:dfdc8484b095: Remove unused local variable (authored by gladhorn).
Remove unused local variable
Sep 29 2018, 9:08 AM

Aug 24 2018

gladhorn accepted D14855: Add applet with screen layouts and presentation mode.

OK, let's do it :)

Aug 24 2018, 1:09 PM · Plasma

Aug 20 2018

gladhorn added a comment to T9451: Find a way to produce multiple Conan packages from a single repo.

Having a clean solution to this would indeed be great.

Aug 20 2018, 4:06 PM · Conan
gladhorn accepted D14950: Add screen to the keyword of kscreen KCM.

Yes please :)

Aug 20 2018, 3:52 PM · Plasma

Aug 17 2018

gladhorn added a comment to D14855: Add applet with screen layouts and presentation mode.

This looks generally nice, I like it. Since we're short on people maintaining this stuff, I'd like more of the code to be shared though.

Aug 17 2018, 11:13 AM · Plasma
gladhorn added a comment to F6196713: Screenshot_20180815_095827.png.

Looks nice, but I think it would be nice to have captions for the icons. The same is true for the normal OSD, there it shows some caption on hover at least.

Aug 17 2018, 10:58 AM

Aug 13 2018

gladhorn committed R110:13bc5bcd4bf4: EDID parsing: replace non-printable characters with '-' (authored by gladhorn).
EDID parsing: replace non-printable characters with '-'
Aug 13 2018, 3:43 PM
gladhorn closed D14549: EDID parsing: replace non-printable characters with '-'.
Aug 13 2018, 3:43 PM · Plasma

Aug 12 2018

gladhorn committed R110:0f32d126d73c: Fix some doc strings (authored by gladhorn).
Fix some doc strings
Aug 12 2018, 1:28 PM
gladhorn committed R110:50dcd973c1c7: Use reinterpret_cast instead of c-style cast (authored by gladhorn).
Use reinterpret_cast instead of c-style cast
Aug 12 2018, 1:28 PM
gladhorn requested review of D14764: Simplify XRandR::outputChanged.
Aug 12 2018, 12:06 PM · Plasma

Aug 2 2018

gladhorn committed R110:c9955376ed2d: testedid: make sure to use uint consistently (authored by gladhorn).
testedid: make sure to use uint consistently
Aug 2 2018, 1:55 PM
gladhorn closed D14548: testedid: make sure to use uint consistently.
Aug 2 2018, 1:55 PM · Plasma
gladhorn requested review of D14549: EDID parsing: replace non-printable characters with '-'.
Aug 2 2018, 9:25 AM · Plasma
gladhorn requested review of D14548: testedid: make sure to use uint consistently.
Aug 2 2018, 9:25 AM · Plasma