gladhorn (Frederik Gladhorn)
User

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 27 2015, 2:36 PM (155 w, 3 d)
Availability
Available

Recent Activity

Yesterday

gladhorn requested review of D14229: Make OSD buttons' accessible.
Thu, Jul 19, 9:49 AM · Plasma
gladhorn requested review of D14228: Make OSD buttons' accessible.
Thu, Jul 19, 9:49 AM · Plasma
gladhorn updated the diff for D14165: Handle keyboard in action selector OSD.

Fix accepting of left key event and use Row instead of ButtonRow

Thu, Jul 19, 9:46 AM · Plasma
gladhorn added inline comments to D14165: Handle keyboard in action selector OSD.
Thu, Jul 19, 9:45 AM · Plasma
gladhorn added a reviewer for D14224: Make kcm size hint bigger: Plasma.
Thu, Jul 19, 7:44 AM · Plasma
gladhorn added a reviewer for D14225: Use hideOsd function instead of its code copied: Plasma.
Thu, Jul 19, 7:44 AM · Plasma
gladhorn requested review of D14225: Use hideOsd function instead of its code copied.
Thu, Jul 19, 7:43 AM · Plasma
gladhorn committed R104:0597035f8611: Fix duplicate object name in ui file (authored by gladhorn).
Fix duplicate object name in ui file
Thu, Jul 19, 7:36 AM
gladhorn closed D14223: Fix duplicate object name in ui file.
Thu, Jul 19, 7:36 AM · Plasma
gladhorn requested review of D14224: Make kcm size hint bigger.
Thu, Jul 19, 7:32 AM · Plasma
gladhorn committed R104:64e03b1e7b2b: Simplify if/else that all make the same call (authored by gladhorn).
Simplify if/else that all make the same call
Thu, Jul 19, 7:05 AM
gladhorn closed D14213: Simplify if/else that all make the same call.
Thu, Jul 19, 7:05 AM · Plasma
gladhorn requested review of D14223: Fix duplicate object name in ui file.
Thu, Jul 19, 7:05 AM · Plasma

Wed, Jul 18

gladhorn committed R104:58f5bb623d14: Turn OsdManager into a regular class (authored by gladhorn).
Turn OsdManager into a regular class
Wed, Jul 18, 5:00 PM
gladhorn closed D14166: Turn OsdManager into a regular class.
Wed, Jul 18, 5:00 PM · Plasma
gladhorn requested review of D14213: Simplify if/else that all make the same call.
Wed, Jul 18, 4:55 PM · Plasma
gladhorn updated the diff for D14143: Make the action selector OSD independent of the other OSDs.

Do not yet introduce any keyboard handling (escape snuck in) and remove clutter (assert, visible:true).

Wed, Jul 18, 4:43 PM · Plasma
gladhorn added inline comments to D14143: Make the action selector OSD independent of the other OSDs.
Wed, Jul 18, 4:33 PM · Plasma
gladhorn updated the diff for D14165: Handle keyboard in action selector OSD.

Fixed keyboard bindings breaking all the time, as indicated in review

Wed, Jul 18, 9:27 AM · Plasma
gladhorn added inline comments to D14143: Make the action selector OSD independent of the other OSDs.
Wed, Jul 18, 8:24 AM · Plasma
gladhorn updated the diff for D14143: Make the action selector OSD independent of the other OSDs.

Fix hiding of osds

Wed, Jul 18, 8:22 AM · Plasma

Tue, Jul 17

gladhorn updated the diff for D14143: Make the action selector OSD independent of the other OSDs.

return qstring without ref

Tue, Jul 17, 7:27 PM · Plasma
gladhorn added a comment to D14165: Handle keyboard in action selector OSD.

Awesome! I'll incorporate the ideas, that's great. Any chance to get https://phabricator.kde.org/D14143 in? It's required for this since it changes the window type. I'd also like to make the global shortcut show and hide the osd (right now pressing it again makes the osd fade out and in again).

Tue, Jul 17, 7:14 PM · Plasma
gladhorn accepted D14118: Improve "Remove this [widget]" text.

I'd say make the casing consistent, otherwise it's a clear improvement in my opinion.

Tue, Jul 17, 7:11 PM · Frameworks
gladhorn committed R104:97f7b9cff782: Remove ref from returned QString (authored by gladhorn).
Remove ref from returned QString
Tue, Jul 17, 7:04 PM
gladhorn closed D14152: Remove ref from returned QString.
Tue, Jul 17, 7:04 PM · Plasma
gladhorn added a dependency for D14165: Handle keyboard in action selector OSD: D14143: Make the action selector OSD independent of the other OSDs.
Tue, Jul 17, 7:02 PM · Plasma
gladhorn added a dependent revision for D14143: Make the action selector OSD independent of the other OSDs: D14165: Handle keyboard in action selector OSD.
Tue, Jul 17, 7:02 PM · Plasma
gladhorn added a dependent revision for D14165: Handle keyboard in action selector OSD: D14166: Turn OsdManager into a regular class.
Tue, Jul 17, 7:01 PM · Plasma
gladhorn added a dependency for D14166: Turn OsdManager into a regular class: D14165: Handle keyboard in action selector OSD.
Tue, Jul 17, 7:01 PM · Plasma
gladhorn updated the diff for D14143: Make the action selector OSD independent of the other OSDs.

re-added const

Tue, Jul 17, 5:31 AM · Plasma
gladhorn updated the diff for D14152: Remove ref from returned QString.

Re-added the const

Tue, Jul 17, 5:30 AM · Plasma
gladhorn committed R110:3e990216dca6: Fix spaces in error messages (authored by gladhorn).
Fix spaces in error messages
Tue, Jul 17, 5:27 AM
gladhorn closed D14167: Fix spaces in error messages.
Tue, Jul 17, 5:27 AM · Plasma

Mon, Jul 16

gladhorn updated the diff for D14167: Fix spaces in error messages.

Added colon

Mon, Jul 16, 7:10 PM · Plasma
gladhorn added a reviewer for D14167: Fix spaces in error messages: Plasma.
Mon, Jul 16, 7:09 PM · Plasma
gladhorn requested review of D14167: Fix spaces in error messages.
Mon, Jul 16, 7:08 PM · Plasma
gladhorn added inline comments to D14165: Handle keyboard in action selector OSD.
Mon, Jul 16, 6:55 PM · Plasma
gladhorn added a reviewer for D14165: Handle keyboard in action selector OSD: Plasma.
Mon, Jul 16, 6:54 PM · Plasma
gladhorn requested review of D14166: Turn OsdManager into a regular class.
Mon, Jul 16, 6:53 PM · Plasma
gladhorn requested review of D14165: Handle keyboard in action selector OSD.
Mon, Jul 16, 6:51 PM · Plasma
gladhorn requested review of D14152: Remove ref from returned QString.
Mon, Jul 16, 7:51 AM · Plasma
gladhorn updated the diff for D14143: Make the action selector OSD independent of the other OSDs.

Remove string ref in return.

Mon, Jul 16, 7:48 AM · Plasma
gladhorn added inline comments to D14143: Make the action selector OSD independent of the other OSDs.
Mon, Jul 16, 7:46 AM · Plasma

Sun, Jul 15

gladhorn committed R110:20c88fd906dd: Fix types, improve readability (authored by gladhorn).
Fix types, improve readability
Sun, Jul 15, 7:19 PM
gladhorn closed D14081: Fix types, improve readability.
Sun, Jul 15, 7:19 PM · Plasma
gladhorn abandoned D14144: Make the action selector OSD independent of the other OSDs.
Sun, Jul 15, 7:17 PM · Plasma
gladhorn added a comment to D14144: Make the action selector OSD independent of the other OSDs.

arc squashed https://phabricator.kde.org/D14143 into this :( Tool failure.

Sun, Jul 15, 7:16 PM · Plasma
gladhorn requested review of D14144: Make the action selector OSD independent of the other OSDs.
Sun, Jul 15, 7:14 PM · Plasma
gladhorn requested review of D14143: Make the action selector OSD independent of the other OSDs.
Sun, Jul 15, 7:12 PM · Plasma

Sat, Jul 14

gladhorn updated the diff for D14081: Fix types, improve readability.

Fixed placement of *

Sat, Jul 14, 10:58 AM · Plasma
gladhorn updated the diff for D14081: Fix types, improve readability.

Added * to auto pointers

Sat, Jul 14, 5:58 AM · Plasma

Thu, Jul 12

gladhorn added a comment to T4066: KScreen UI rework.

Is this a duplicate of https://phabricator.kde.org/T3464 ?

Thu, Jul 12, 8:50 PM · Plasma
gladhorn requested review of D14081: Fix types, improve readability.
Thu, Jul 12, 3:58 PM · Plasma
gladhorn committed R110:2ecd720c1018: Fix typo REflect_Y (authored by gladhorn).
Fix typo REflect_Y
Thu, Jul 12, 3:35 PM
gladhorn committed R110:4b101b28fb18: Use the same variable name in function declaration and definition (authored by gladhorn).
Use the same variable name in function declaration and definition
Thu, Jul 12, 3:35 PM
gladhorn committed R104:ccbee3e89925: Use QStringLiteral when a conversion to QString will happen (authored by gladhorn).
Use QStringLiteral when a conversion to QString will happen
Thu, Jul 12, 12:52 PM
gladhorn closed D14076: Use QStringLiteral when a conversion to QString will happen.
Thu, Jul 12, 12:51 PM · Plasma
gladhorn committed R104:5327746f81c5: Use normal connection to slot instead of lambda (authored by gladhorn).
Use normal connection to slot instead of lambda
Thu, Jul 12, 12:43 PM
gladhorn added inline comments to D14074: Use context argument in lambda connect.
Thu, Jul 12, 12:40 PM · Plasma
gladhorn committed R104:f62f316ab207: In function returning void, use plain return (authored by gladhorn).
In function returning void, use plain return
Thu, Jul 12, 12:38 PM
gladhorn closed D14075: In function returning void, use plain return.
Thu, Jul 12, 12:38 PM · Plasma
gladhorn committed R104:439feca241e8: Use context argument in lambda connect (authored by gladhorn).
Use context argument in lambda connect
Thu, Jul 12, 12:35 PM
gladhorn closed D14074: Use context argument in lambda connect.
Thu, Jul 12, 12:35 PM · Plasma
gladhorn committed R104:94d19d7e335f: Improve wording in comment (authored by gladhorn).
Improve wording in comment
Thu, Jul 12, 12:34 PM
gladhorn closed D14073: Improve wording in comment.
Thu, Jul 12, 12:34 PM · Plasma
gladhorn committed R110:9694b4a511e4: Simplify string comparison (authored by gladhorn).
Simplify string comparison
Thu, Jul 12, 12:23 PM
gladhorn closed D14078: Simplify string comparison.
Thu, Jul 12, 12:23 PM · Plasma
gladhorn requested review of D14078: Simplify string comparison.
Thu, Jul 12, 12:16 PM · Plasma
gladhorn added a reviewer for D14074: Use context argument in lambda connect: Plasma.
Thu, Jul 12, 11:08 AM · Plasma
gladhorn requested review of D14076: Use QStringLiteral when a conversion to QString will happen.
Thu, Jul 12, 11:07 AM · Plasma
gladhorn requested review of D14075: In function returning void, use plain return.
Thu, Jul 12, 11:04 AM · Plasma
gladhorn requested review of D14074: Use context argument in lambda connect.
Thu, Jul 12, 11:03 AM · Plasma
gladhorn requested review of D14073: Improve wording in comment.
Thu, Jul 12, 10:54 AM · Plasma
gladhorn committed R104:e9cca953e8bc: Be strict about implicit string casts (authored by gladhorn).
Be strict about implicit string casts
Thu, Jul 12, 9:39 AM
gladhorn closed D14065: Be strict about implicit string casts.
Thu, Jul 12, 9:39 AM · Plasma
gladhorn committed R110:973bef8349d2: Clean up string casts (authored by gladhorn).
Clean up string casts
Thu, Jul 12, 9:19 AM
gladhorn closed D14060: Clean up string casts.
Thu, Jul 12, 9:19 AM · Plasma
gladhorn added a comment to D14060: Clean up string casts.

I think micro-optimizing the tests further is simply not worth anyone's time. I'd propose taking this in (and if you spot more things, do them on top of this change).

Thu, Jul 12, 8:48 AM · Plasma
gladhorn added a reviewer for D14065: Be strict about implicit string casts: Plasma.
Thu, Jul 12, 8:10 AM · Plasma
gladhorn committed R110:967f21ac54f2: Fix fake parser copy and paste error (authored by gladhorn).
Fix fake parser copy and paste error
Thu, Jul 12, 8:08 AM
gladhorn closed D14048: Fix fake parser copy and paste error.
Thu, Jul 12, 8:08 AM · Plasma
gladhorn requested review of D14065: Be strict about implicit string casts.
Thu, Jul 12, 8:07 AM · Plasma
gladhorn added inline comments to D14060: Clean up string casts.
Thu, Jul 12, 6:50 AM · Plasma
gladhorn updated the diff for D14060: Clean up string casts.

Fixed some of Kai's comments, some minor things are still to do.

Thu, Jul 12, 6:48 AM · Plasma
gladhorn added inline comments to D14060: Clean up string casts.
Thu, Jul 12, 6:47 AM · Plasma

Wed, Jul 11

gladhorn added a reviewer for D14060: Clean up string casts: Plasma.
Wed, Jul 11, 9:49 PM · Plasma
gladhorn requested review of D14060: Clean up string casts.
Wed, Jul 11, 9:48 PM · Plasma
gladhorn added a comment to D14058: Give connect to lambda a context object.

Yes, this is partially to shut up clazy.

Wed, Jul 11, 9:47 PM · Plasma
gladhorn committed R110:bd4fa7d318e8: Give connect to lambda a context object (authored by gladhorn).
Give connect to lambda a context object
Wed, Jul 11, 9:47 PM
gladhorn closed D14058: Give connect to lambda a context object.
Wed, Jul 11, 9:47 PM · Plasma
gladhorn requested review of D14058: Give connect to lambda a context object.
Wed, Jul 11, 8:26 PM · Plasma
gladhorn closed D14025: Move scale and unify button to the top, next to primary combo.

Pushed, sadly without the phabricator tag, since I'm struggling to manage > 1 patch with phabricator.
b01b567296b70b9b593eaa438d86dffe7b663afa

Wed, Jul 11, 7:49 PM · Plasma
gladhorn committed R104:ce68ee44e099: Move KCM to UI file (authored by gladhorn).
Move KCM to UI file
Wed, Jul 11, 7:48 PM
gladhorn committed R104:b01b567296b7: Move scale and unify button to the top, next to primary combo (authored by gladhorn).
Move scale and unify button to the top, next to primary combo
Wed, Jul 11, 7:48 PM
gladhorn closed D14024: Move KCM to UI file.
Wed, Jul 11, 7:48 PM · Plasma
gladhorn committed R110:544191ae46a2: Fix string usage (authored by gladhorn).
Fix string usage
Wed, Jul 11, 1:55 PM
gladhorn committed R110:f347c190f79c: Fix fake parser copy and paste error (authored by gladhorn).
Fix fake parser copy and paste error
Wed, Jul 11, 1:55 PM
gladhorn committed R104:522c2a6d6e5d: WIP: QT_NO_CAST_FROM_ASCII (authored by gladhorn).
WIP: QT_NO_CAST_FROM_ASCII
Wed, Jul 11, 1:54 PM
gladhorn requested review of D14048: Fix fake parser copy and paste error.
Wed, Jul 11, 1:54 PM · Plasma