gladhorn (Frederik Gladhorn)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 27 2015, 2:36 PM (195 w, 3 d)
Availability
Available

Recent Activity

Yesterday

gladhorn added a comment to T10837: Plasma Accessibility Sprint.

Hi, I very much think we should meet :) The Plasma sprint is a good option, since we can then influence the right people. Do you think it would be possible to travel to Valencia for you Chrys?

Wed, Apr 24, 1:53 PM · Plasma Accessibility

Sun, Apr 21

gladhorn added a comment to T10019: Kate issues.

You can build Qt and run Kate with the patched Qt version. Sadly the change to Qt needs more work and I haven't gotten around to it for a long time :(

Sun, Apr 21, 3:49 PM · Plasma Accessibility
gladhorn added a comment to T10609: Orca doesnt interrupt on switching window in KWin.

It seems like adding icon needs a patch to Qt. I can do that, what is the preferred role though?

Sun, Apr 21, 12:50 PM · Plasma Accessibility
gladhorn added a comment to T10099: Make Konsole accessible.

https://codereview.qt-project.org/#/c/259401 adds the "terminal" role to Qt.

Sun, Apr 21, 12:50 PM · Plasma Accessibility
gladhorn added a comment to T10609: Orca doesnt interrupt on switching window in KWin.

Very nice :) We should probably change the "role" of the task switcher items. I think Joanie suggested "Icon"?

Sun, Apr 21, 9:37 AM · Plasma Accessibility
gladhorn added a comment to T10099: Make Konsole accessible.

The initial implementation was written, but lacked testing by actual users. I guess setting the terminal role should be rather simple (just setting the property in the right place). I haven't looked at this in ages, let me know if you want help :)

Sun, Apr 21, 9:36 AM · Plasma Accessibility

Dec 17 2018

gladhorn added a comment to D17533: Make the button's purpose more clear.

I also find the text rather confusing (thank you for working on this!).
What is AccessX? And why should I care as a user? I need the feature...

Dec 17 2018, 8:49 AM · Plasma

Nov 26 2018

gladhorn added a comment to T10096: Kicker: expose number of childs for kicker start menu.

Yes, we've been sloppy with that kind of thing in Qt Quick accessibility, I assume this will need some work in Qt.

Nov 26 2018, 6:14 PM · Plasma Accessibility
gladhorn added a comment to T9885: KDE Connect Accessibility.

Is this task about the desktop part or the android app?

Nov 26 2018, 6:13 PM · KDE Connect, Plasma Accessibility

Nov 25 2018

gladhorn committed R110:e6b197b47b8a: Define ownership of edid in output and do not leak it (authored by gladhorn).
Define ownership of edid in output and do not leak it
Nov 25 2018, 9:04 AM
gladhorn closed D14428: Define ownership of edid in output and do not leak it.
Nov 25 2018, 9:04 AM · Plasma

Nov 23 2018

gladhorn abandoned D14514: Install the OSD icons to hicolor.
Nov 23 2018, 10:01 PM · Plasma

Nov 20 2018

gladhorn added a comment to T7033: Improve NetworkManager applet navigation.

I don't see any spam. It makes a lot of sense to have many small well-defined tasks in my opinion.

Nov 20 2018, 9:09 AM · Plasma Accessibility
gladhorn closed T9933: Lock Screen Password dialog as Resolved.

Argh, somehow I thought moving it to the done column in the board would close it. Thanks for the reminder :)

Nov 20 2018, 9:08 AM · Plasma Accessibility
gladhorn closed T7030: Merge QtWayland support as Resolved.

Yes, thanks :) Should be in Qt 5.12.0.

Nov 20 2018, 9:07 AM · Plasma Accessibility

Nov 19 2018

gladhorn added a comment to D16988: [Kickoff] Make the visible search field unfocused by default.

@gladhorn More food for thought by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input even though you've technically navigated away from it. Should this functionality be kept (regardless of if the search field remains visibly focused or not), or should we prevent the user from typing into the search field while the focus is on the search results?

I think it's a good idea to let the user type to search from wherever they may be in Kickoff, but to draw the focus away from the search field (like Kicker).

Nov 19 2018, 9:46 AM · Plasma
gladhorn added a comment to D16988: [Kickoff] Make the visible search field unfocused by default.

There are a lot of good changes in here, like those keyboard navigation improvements! And I appreciate all the work that clearly went into this. However, the problem with huge patches like this is that if we like some but not all of it, you end up needing to re-work a lot of the patch. That's generally why we prefer "atomic" changes with one change per patch/commit. It makes that kind of thing way saner.

And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how important focus is. Making sure that the active element both has and looks like it has focus is critical to making sure the UI is accessible for screen readers. As such, we need to keep it visually focused by default when it opens.

Nov 19 2018, 9:14 AM · Plasma

Nov 18 2018

gladhorn closed T10076: New release of libqaccessibilityclient as Resolved.

http://blogs.fsfe.org/gladhorn/2018/11/18/libqaccessibilityclient-v0-3-0/

Nov 18 2018, 11:28 AM · Plasma Accessibility
gladhorn moved T10076: New release of libqaccessibilityclient from In progress to Done on the Plasma Accessibility board.
Nov 18 2018, 11:27 AM · Plasma Accessibility
gladhorn added a comment to T10076: New release of libqaccessibilityclient.

https://download.kde.org/stable/libqaccessibilityclient/ has version 0.3.0 now.

Nov 18 2018, 10:58 AM · Plasma Accessibility
gladhorn added a comment to T7031: Panel focus on shortcut.

@davidedmundson any progress on this? Where would we in general do this? I think adding a keyboard shortcut to cycle the focus through panels might be a good idea.

Nov 18 2018, 10:42 AM · Plasma Accessibility
gladhorn added a comment to T10076: New release of libqaccessibilityclient.

Tarballs are created, waiting for sysadmin for 0.3.0 to be pushed out.

Nov 18 2018, 9:48 AM · Plasma Accessibility
gladhorn edited Description on Plasma Accessibility.
Nov 18 2018, 9:47 AM
gladhorn set the image for Plasma Accessibility to F6430214: profile.
Nov 18 2018, 9:46 AM
gladhorn committed R578:8b407995bc37: Add some notes about creating releases (authored by gladhorn).
Add some notes about creating releases
Nov 18 2018, 9:40 AM
gladhorn committed R578:e7a4d9650aab: Use ecm version magic (authored by gladhorn).
Use ecm version magic
Nov 18 2018, 9:24 AM
gladhorn committed R578:b5129b5b3955: Fix moc includes (authored by gladhorn).
Fix moc includes
Nov 18 2018, 9:24 AM
gladhorn committed R578:bfd7b598a09e: Simplify library name variable (authored by gladhorn).
Simplify library name variable
Nov 18 2018, 9:24 AM
gladhorn committed R578:15de2bdd238a: Use markdown for the readme (authored by gladhorn).
Use markdown for the readme
Nov 18 2018, 8:19 AM

Nov 17 2018

gladhorn committed R578:b36f593878f6: Clean up some casts and signedness (authored by gladhorn).
Clean up some casts and signedness
Nov 17 2018, 8:06 PM
gladhorn committed R578:8a6ef9ab5cee: Use nullptr (authored by gladhorn).
Use nullptr
Nov 17 2018, 8:06 PM
gladhorn committed R578:b5f4a973cb57: Allow packagers to override the LIB_INSTALL_DIR (authored by maximilianocuria).
Allow packagers to override the LIB_INSTALL_DIR
Nov 17 2018, 6:49 PM
gladhorn added a comment to T10019: Kate issues.

This is kinda blocked on getting the patch into Qt, that's a more general solution instead of hacking around it in Kate.

Nov 17 2018, 6:40 PM · Plasma Accessibility
gladhorn triaged T10076: New release of libqaccessibilityclient as Normal priority.
Nov 17 2018, 6:40 PM · Plasma Accessibility
gladhorn closed D16634: Add command line app to dump accessibility tree of apps.
Nov 17 2018, 6:38 PM
gladhorn committed R578:9ddb09ba8cb3: Add command line app to dump accessibility tree of apps (authored by gladhorn).
Add command line app to dump accessibility tree of apps
Nov 17 2018, 6:38 PM
gladhorn added a watcher for Plasma Accessibility: gladhorn.
Nov 17 2018, 6:31 PM
gladhorn added a comment to T10065: Default application starter does not handle focus.

Thanks, good mail :) Let's see what comes out of this.

Nov 17 2018, 6:17 PM · Plasma Accessibility
gladhorn updated subscribers of T10067: KWin Zoom Plugin: Should work in fullscreen game windows as well.

@graesslin and @davidedmundson do you have opinions on this? Is it possible to have magnification for fullscreen apps?

Nov 17 2018, 6:16 PM · Plasma Accessibility

Nov 16 2018

gladhorn committed R578:817798854a6b: Add helper to print state of an AccessibleObject (authored by gladhorn).
Add helper to print state of an AccessibleObject
Nov 16 2018, 4:07 PM
gladhorn closed D16632: Add helper to print state of an AccessibleObject.
Nov 16 2018, 4:07 PM

Nov 12 2018

gladhorn added a comment to T10019: Kate issues.

https://codereview.qt-project.org/#/c/245319/ presumably fixes the keys not being sent.

Nov 12 2018, 8:02 PM · Plasma Accessibility

Nov 10 2018

gladhorn triaged T10019: Kate issues as Normal priority.
Nov 10 2018, 10:17 AM · Plasma Accessibility

Nov 7 2018

gladhorn closed T7034: Accessibility in KWin window switcher as Resolved.
Nov 7 2018, 7:38 AM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Yes, I hope so :) it would be great to have anyone else report success, but I think it's done.

Nov 7 2018, 7:38 AM · Plasma Accessibility

Nov 5 2018

gladhorn committed R120:bf9e6a4062dc: Add accessibility and set focus on the actual items in the window switcher (authored by gladhorn).
Add accessibility and set focus on the actual items in the window switcher
Nov 5 2018, 8:54 PM
gladhorn moved T9933: Lock Screen Password dialog from Todo to Done on the Plasma Accessibility board.

I just tested again, it doesn't read what I'm typing as long as the input is focused, so I guess this was a false alarm.

Nov 5 2018, 8:54 PM · Plasma Accessibility
gladhorn closed D16638: Add accessibility and set focus on the actual items in the window switcher.

This is in I'm unsure why "arc land" didn't close it.

Nov 5 2018, 8:52 PM · Plasma
gladhorn moved T7034: Accessibility in KWin window switcher from In progress to Done on the Plasma Accessibility board.
Nov 5 2018, 8:49 PM · Plasma Accessibility
gladhorn updated the diff for D16638: Add accessibility and set focus on the actual items in the window switcher.

Changed it to be more pleasant by using client as role and set the focus on the top level, so that the geometry is also more sensible.

Nov 5 2018, 5:49 PM · Plasma
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Yes, it looks like this will work.

Nov 5 2018, 5:37 PM · Plasma Accessibility
gladhorn updated the diff for D16638: Add accessibility and set focus on the actual items in the window switcher.

After the change in KWin only this is needed

Nov 5 2018, 5:30 PM · Plasma
gladhorn committed R108:66986d4afddc: Make QPA think the tabbox is the active window (authored by gladhorn).
Make QPA think the tabbox is the active window
Nov 5 2018, 5:22 PM
gladhorn closed D16664: Make QPA think the tabbox is the active window.
Nov 5 2018, 5:22 PM · KWin
gladhorn added a comment to D16664: Make QPA think the tabbox is the active window.

Awesome, thanks.

Nov 5 2018, 5:21 PM · KWin
gladhorn updated the diff for D16664: Make QPA think the tabbox is the active window.

Use qpa api instead of actually requesting the window to be activated.

Nov 5 2018, 5:16 PM · KWin
gladhorn committed R365:41c6b345d433: Add perl-yaml-libyaml for arch and make FirstRun use pacman (authored by gladhorn).
Add perl-yaml-libyaml for arch and make FirstRun use pacman
Nov 5 2018, 5:16 PM

Nov 4 2018

gladhorn added a comment to D16638: Add accessibility and set focus on the actual items in the window switcher.

It looks like I need either forceActiveFocus or to remove the window manager bypass hint. Or find some other way to get the focus on the window...

Nov 4 2018, 7:50 PM · Plasma
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

OK, I seem to have reached something surprisingly simple: D16638 and D16664 give me a tab box that works with Orca.
The requestActivate is needed to get the focus into the window, the window manager hint has to go (are there side-effects?) and after that pressing alt-tab announces a window containing labels for all other windows. The role should be adjusted, but compared to everything else that should be rather trivial.

Nov 4 2018, 7:37 PM · Plasma Accessibility
gladhorn requested review of D16664: Make QPA think the tabbox is the active window.
Nov 4 2018, 4:37 PM · KWin
gladhorn updated the diff for D16638: Add accessibility and set focus on the actual items in the window switcher.

Removed Qt.X11BypassWindowManagerHint which makes everything work

Nov 4 2018, 4:32 PM · Plasma
gladhorn closed D16655: Remove unused private Qt include.
Nov 4 2018, 4:02 PM · KWin
gladhorn committed R108:456cbb9bf73c: Remove unused private Qt include (authored by gladhorn).
Remove unused private Qt include
Nov 4 2018, 4:02 PM
gladhorn committed R108:503661579fff: Remove unused FindQt5PlatformSupport.cmake (authored by gladhorn).
Remove unused FindQt5PlatformSupport.cmake
Nov 4 2018, 4:01 PM
gladhorn closed D16654: Remove unused FindQt5PlatformSupport.cmake.
Nov 4 2018, 4:01 PM · KWin
gladhorn added inline comments to D16638: Add accessibility and set focus on the actual items in the window switcher.
Nov 4 2018, 12:31 PM · Plasma
gladhorn updated the diff for D16654: Remove unused FindQt5PlatformSupport.cmake.

Updated to remove more legacy code.

Nov 4 2018, 12:25 PM · KWin
gladhorn added a comment to D16654: Remove unused FindQt5PlatformSupport.cmake.

Ouch, I overlooked that, good catch.

Nov 4 2018, 12:21 PM · KWin
gladhorn requested review of D16655: Remove unused private Qt include.
Nov 4 2018, 8:12 AM · KWin
gladhorn accepted D16383: Add accessibility information to tabbar in dash starter.

I think this looks good :) Feel free to push.

Nov 4 2018, 8:09 AM · Plasma Accessibility
gladhorn requested review of D16654: Remove unused FindQt5PlatformSupport.cmake.
Nov 4 2018, 7:46 AM · KWin

Nov 3 2018

gladhorn added a task to D16638: Add accessibility and set focus on the actual items in the window switcher: T7034: Accessibility in KWin window switcher.
Nov 3 2018, 4:19 PM · Plasma
gladhorn added a revision to T7034: Accessibility in KWin window switcher: D16638: Add accessibility and set focus on the actual items in the window switcher.
Nov 3 2018, 4:19 PM · Plasma Accessibility
gladhorn requested review of D16638: Add accessibility and set focus on the actual items in the window switcher.
Nov 3 2018, 4:17 PM · Plasma
gladhorn requested review of D16634: Add command line app to dump accessibility tree of apps.
Nov 3 2018, 11:30 AM
gladhorn requested review of D16632: Add helper to print state of an AccessibleObject.
Nov 3 2018, 11:30 AM
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

I have been a fool :) I just found that KWin actually does create accessible interfaces for the window switcher since it uses QML and we added accessibility information in some form... What is missing is only pretending that the task switcher window is the active window and maybe sending focus events. That should make this task quite a bit smaller (and I get to throw away my proof of concept code and start over).

Nov 3 2018, 9:39 AM · Plasma Accessibility

Nov 2 2018

gladhorn committed R108:501c6806c72a: cleanup (authored by gladhorn).
cleanup
Nov 2 2018, 4:27 PM
gladhorn committed R108:cf58ecfedb47: namespace and get the focus on the virtual window (authored by gladhorn).
namespace and get the focus on the virtual window
Nov 2 2018, 3:08 PM
gladhorn committed R108:eb9e864ad2cb: More sensible updates, stuff (authored by gladhorn).
More sensible updates, stuff
Nov 2 2018, 3:08 PM
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

Yes, I'd love it if we do give KWin focus - it would make things just work for accessibility, so in that sense it's the right solution. I just had the feeling that it would be close to impossible to convince the KWin maintainers to go that way.
I already have a proof of concept that informs of the Windows that are open - I just need to figure out how to best send updates and do a proper model for memory management of the stuff I wrote, currently I wouldn't be surprised if it crashes and leaks, I just wanted to see that it's doable at all...

Nov 2 2018, 1:43 PM · Plasma Accessibility
gladhorn committed R108:8ce12fa13b25: Add children for the windows (authored by gladhorn).
Add children for the windows
Nov 2 2018, 6:34 AM
gladhorn committed R108:814de0315583: Implement accessibility for TabBox (window switcher) (authored by gladhorn).
Implement accessibility for TabBox (window switcher)
Nov 2 2018, 6:34 AM

Nov 1 2018

gladhorn added a comment to T7034: Accessibility in KWin window switcher.

I now have a very hackish proof of concept. It shows KWin as application on the accessibility dbus session. It has one child (a virtual main window) with children for the "clients" as KWin calls the windows. There are no updates sent yet, so Orca will not read anything. In addition I'm leaking memory, so this needs a day of cleanup. But I think in principle it will work.

Nov 1 2018, 8:32 PM · Plasma Accessibility

Oct 31 2018

gladhorn committed R108:abceccbb6600: Remove unused captures from lambdas (authored by gladhorn).
Remove unused captures from lambdas
Oct 31 2018, 8:40 AM
gladhorn closed D16481: Remove unused captures from lambdas.
Oct 31 2018, 8:40 AM · KWin
gladhorn committed R108:04bbe1003882: Remove dead default branches (authored by gladhorn).
Remove dead default branches
Oct 31 2018, 8:24 AM
gladhorn closed D16480: Remove dead default branches.
Oct 31 2018, 8:24 AM · KWin
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

My plan was not to change anything regarding x11/wayland at all. It can be done purely on the accessibility level - faking it completely.

Oct 31 2018, 8:19 AM · Plasma Accessibility
gladhorn added a comment to T7034: Accessibility in KWin window switcher.

My only concern is that if I implement a (virtual) window for accessibility only for the task switcher, Orca would probably read the window before reading the focus inside it. But that may be fine.
"task switcher" -> "firefox window". I'll try writing it in the near future and let others play with it. In the worst case we can then use Orca scripts, if people find announcing the tab switcher window to be a nuisance.

Oct 31 2018, 7:45 AM · Plasma Accessibility
gladhorn added a comment to D16479: Use override for tabbox classes.

So far I always said no to such changes as it doesn't really offer advantages for done code and just clutters the commit history.

I do think there is a bit advantage: When refactoring and a base classes' function gets renamed, any overriding virtuals will stop compiling, so this kind of change makes the code more future-proof.

I fully understand the advantage of override. I do add it to new code. I'm questioning the advantage of adding it to old and done code. Nobody has touched these classes for years and there won't be any reason to do so for years. And even if one would touch it, it's as simple as doing the change to add override then.

My point against such a change is that we either need to do this for all of KWin or not at all. And for all of KWin I think it's a bad idea as it introduces a commit breaking any git blame. Would you +1 such a change in Qt changing all overriding methods to override?

Oct 31 2018, 7:41 AM · KWin

Oct 30 2018

gladhorn added a comment to D16383: Add accessibility information to tabbar in dash starter.

Nice, this looks good to me. I don't know the code though, so it would be great to hear what people more familiar with it say.

Oct 30 2018, 8:48 AM · Plasma Accessibility

Oct 29 2018

gladhorn added a comment to D16479: Use override for tabbox classes.

So far I always said no to such changes as it doesn't really offer advantages for done code and just clutters the commit history.

Oct 29 2018, 8:47 AM · KWin

Oct 28 2018

gladhorn added a comment to T9878: Default application starter menu is missing a11y Labels.

@chempfling let's chat about Qt Quick focus indeed, it's complicated. The problem comes mostly from the fact that initially Qt Quick provided only basic primitives, which were not on the right semantic level for accessibility. We tried some experiments to automatically give every text element an accessible name, but that was not really the way to go as for example buttons should have more properties and would contain the text as child. Therefore the level to implement accessibility became a duty for those building on top of the primitives. Which makes it hard to enforce it. I agree we should try to write rules. There is movement in the human interface guidelines department for KDE, maybe they should be extended. For a long time nobody was pushing to fix these issues, so they have been spreading. On the other hand nowadays things have become much more stable, so making an effort is certainly worth it and appreciated by everyone. Some of the plasmoid code is very old and has simply grown before the standard components were available.

Oct 28 2018, 12:33 PM · Plasma Accessibility
gladhorn added a comment to D16383: Add accessibility information to tabbar in dash starter.

@chempfling what do you think? Would it be possible to label the buttons inside the tab bar instead?

Oct 28 2018, 12:28 PM · Plasma Accessibility
gladhorn moved T7038: System settings: keyboard navigation in the sidebar from In progress to Todo on the Plasma Accessibility board.
Oct 28 2018, 12:21 PM · Plasma Accessibility
gladhorn added a comment to T7038: System settings: keyboard navigation in the sidebar.

I don't think there's any ongoing progress, @mart any plans about this?

Oct 28 2018, 12:21 PM · Plasma Accessibility
gladhorn moved T7033: Improve NetworkManager applet navigation from In progress to Todo on the Plasma Accessibility board.
Oct 28 2018, 12:20 PM · Plasma Accessibility
gladhorn updated subscribers of T7033: Improve NetworkManager applet navigation.

@davidedmundson do you have plans about this? @chempfling did you play with the network settings? Is there even any way to open the plasmoid at this point in time? I'll put this back to todo for now.

Oct 28 2018, 12:20 PM · Plasma Accessibility
gladhorn added a comment to T7031: Panel focus on shortcut.

Hmm, deviating too much from what sighted users see is always a problem because it will not be maintained when the other code changes. The flexibility of plasma is hard here in many ways - we cannot make assumptions what kind of panels there will be etc.
On the other hand I'd really try to get the defaults to work first. So assuming there is one panel, making sure that can be navigated with the keyboard and we can get the relevant information conveyed to blind users would be my starting point.

Oct 28 2018, 12:18 PM · Plasma Accessibility