gladhorn (Frederik Gladhorn)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 27 2015, 2:36 PM (164 w, 6 d)
Availability
Available

Recent Activity

Aug 24 2018

gladhorn accepted D14855: Add applet with screen layouts and presentation mode.

OK, let's do it :)

Aug 24 2018, 1:09 PM · Plasma

Aug 20 2018

gladhorn added a comment to T9451: Find a way to produce multiple Conan packages from a single repo.

Having a clean solution to this would indeed be great.

Aug 20 2018, 4:06 PM · Conan
gladhorn accepted D14950: Add screen to the keyword of kscreen KCM.

Yes please :)

Aug 20 2018, 3:52 PM · Plasma

Aug 17 2018

gladhorn added a comment to D14855: Add applet with screen layouts and presentation mode.

This looks generally nice, I like it. Since we're short on people maintaining this stuff, I'd like more of the code to be shared though.

Aug 17 2018, 11:13 AM · Plasma
gladhorn added a comment to F6196713: Screenshot_20180815_095827.png.

Looks nice, but I think it would be nice to have captions for the icons. The same is true for the normal OSD, there it shows some caption on hover at least.

Aug 17 2018, 10:58 AM

Aug 13 2018

gladhorn committed R110:13bc5bcd4bf4: EDID parsing: replace non-printable characters with '-' (authored by gladhorn).
EDID parsing: replace non-printable characters with '-'
Aug 13 2018, 3:43 PM
gladhorn closed D14549: EDID parsing: replace non-printable characters with '-'.
Aug 13 2018, 3:43 PM · Plasma

Aug 12 2018

gladhorn committed R110:0f32d126d73c: Fix some doc strings (authored by gladhorn).
Fix some doc strings
Aug 12 2018, 1:28 PM
gladhorn committed R110:50dcd973c1c7: Use reinterpret_cast instead of c-style cast (authored by gladhorn).
Use reinterpret_cast instead of c-style cast
Aug 12 2018, 1:28 PM
gladhorn requested review of D14764: Simplify XRandR::outputChanged.
Aug 12 2018, 12:06 PM · Plasma

Aug 2 2018

gladhorn committed R110:c9955376ed2d: testedid: make sure to use uint consistently (authored by gladhorn).
testedid: make sure to use uint consistently
Aug 2 2018, 1:55 PM
gladhorn closed D14548: testedid: make sure to use uint consistently.
Aug 2 2018, 1:55 PM · Plasma
gladhorn requested review of D14549: EDID parsing: replace non-printable characters with '-'.
Aug 2 2018, 9:25 AM · Plasma
gladhorn requested review of D14548: testedid: make sure to use uint consistently.
Aug 2 2018, 9:25 AM · Plasma

Jul 31 2018

gladhorn added a comment to D14514: Install the OSD icons to hicolor.

Why are they not in the Plasma theme, though?

Jul 31 2018, 4:45 PM · Plasma
gladhorn committed R104:a6929de88b89: QMLScreen: do not declare the engine a member (authored by gladhorn).
QMLScreen: do not declare the engine a member
Jul 31 2018, 4:44 PM
gladhorn closed D14476: QMLScreen: do not declare the engine a member.
Jul 31 2018, 4:44 PM · Plasma
gladhorn updated the diff for D14476: QMLScreen: do not declare the engine a member.

Remove more cruft

Jul 31 2018, 4:36 PM · Plasma
gladhorn requested review of D14514: Install the OSD icons to hicolor.
Jul 31 2018, 2:56 PM · Plasma
gladhorn abandoned D14353: Improve alignment of types.

seems like this is not wanted

Jul 31 2018, 2:40 PM · Plasma
gladhorn committed R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when QMLScreen is destroyed (authored by gladhorn).
Do not leak all instances of QMLOutput when QMLScreen is destroyed
Jul 31 2018, 12:50 PM
gladhorn closed D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed.
Jul 31 2018, 12:50 PM · Plasma

Jul 30 2018

gladhorn added inline comments to D14476: QMLScreen: do not declare the engine a member.
Jul 30 2018, 7:42 AM · Plasma
gladhorn committed R104:749ab17d5e48: Do not leak Widget::ui (authored by gladhorn).
Do not leak Widget::ui
Jul 30 2018, 7:39 AM
gladhorn closed D14477: Do not leak Widget::ui.
Jul 30 2018, 7:39 AM · Plasma
gladhorn committed R104:098ae52e0086: Use nullptr instead of Q_NULLPTR (authored by gladhorn).
Use nullptr instead of Q_NULLPTR
Jul 30 2018, 7:12 AM
gladhorn requested review of D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed.
Jul 30 2018, 7:08 AM · Plasma
gladhorn requested review of D14477: Do not leak Widget::ui.
Jul 30 2018, 7:08 AM · Plasma
gladhorn requested review of D14476: QMLScreen: do not declare the engine a member.
Jul 30 2018, 7:07 AM · Plasma

Jul 28 2018

gladhorn added a comment to D14428: Define ownership of edid in output and do not leak it.

The alternative would be to deprecate this and add a new function. I think this is nonetheless sensible.

Jul 28 2018, 6:36 AM · Plasma

Jul 27 2018

gladhorn committed R104:49ea560a67b4: Fix typos (authored by gladhorn).
Fix typos
Jul 27 2018, 7:21 PM
gladhorn committed R110:15aa08f36561: Let edidDecodeFraction return float (authored by gladhorn).
Let edidDecodeFraction return float
Jul 27 2018, 7:07 PM
gladhorn closed D14368: Let edidDecodeFraction return float.
Jul 27 2018, 7:07 PM · Plasma
gladhorn added a comment to D14353: Improve alignment of types.
In D14353#299282, @zzag wrote:

I suggest to describe in the summary why data members are ordered from largest to smallest.

Jul 27 2018, 2:20 PM · Plasma
gladhorn added a comment to D14405: Use short pnp id as fallback when the DB file is not found.

I think the qml code should not do logic fiddling with the EDID :) but needs investigation.

Jul 27 2018, 2:16 PM · Plasma
gladhorn committed R110:b80bbeb2e419: Add test for edid parsing and fix reading gamma (authored by gladhorn).
Add test for edid parsing and fix reading gamma
Jul 27 2018, 2:09 PM
gladhorn closed D14418: Add test for edid parsing and fix reading gamma.
Jul 27 2018, 2:09 PM · Plasma
gladhorn committed R110:931cead9c138: Fix memory leak in test (authored by gladhorn).
Fix memory leak in test
Jul 27 2018, 1:51 PM
gladhorn updated the diff for D14428: Define ownership of edid in output and do not leak it.

Messed up merge :(

Jul 27 2018, 1:45 PM · Plasma
gladhorn updated the diff for D14428: Define ownership of edid in output and do not leak it.

Add note about the edid pointer becoming invalid

Jul 27 2018, 1:42 PM · Plasma
gladhorn requested review of D14428: Define ownership of edid in output and do not leak it.
Jul 27 2018, 1:41 PM · Plasma
gladhorn updated the diff for D14353: Improve alignment of types.

initializer order fixed

Jul 27 2018, 1:02 PM · Plasma
gladhorn updated the diff for D14353: Improve alignment of types.

Move two more members to the right spot

Jul 27 2018, 12:59 PM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

arc messup, it squashed another patch into this one

Jul 27 2018, 12:48 PM · Plasma
gladhorn updated the diff for D14368: Let edidDecodeFraction return float.

arc mangled two patches again :(

Jul 27 2018, 12:46 PM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Updated commit message and rebased.

Jul 27 2018, 12:45 PM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Sort edids in test rows. I still think this is completely pointless and a waste of time.

Jul 27 2018, 12:41 PM · Plasma
gladhorn added a comment to D14405: Use short pnp id as fallback when the DB file is not found.

Good catch, I'll have to look into it, right now I get an empty string for both.

Jul 27 2018, 12:38 PM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Removed xfail, it was fixed by the string parsing fix

Jul 27 2018, 12:34 PM · Plasma
gladhorn committed R104:ed42cf46ae2c: Remove unused function (authored by gladhorn).
Remove unused function
Jul 27 2018, 12:25 PM
gladhorn closed D14361: Remove unused function.
Jul 27 2018, 12:25 PM · Plasma
gladhorn committed R104:f4b0d85fe061: Create m_saveTimer lazily (authored by gladhorn).
Create m_saveTimer lazily
Jul 27 2018, 12:24 PM
gladhorn closed D14359: Create m_saveTimer lazily.
Jul 27 2018, 12:24 PM · Plasma
gladhorn committed R110:7cbccda5a273: Make sure for loop does not detach (authored by gladhorn).
Make sure for loop does not detach
Jul 27 2018, 12:23 PM
gladhorn closed D14350: Make sure for loop does not detach.
Jul 27 2018, 12:23 PM · Plasma
gladhorn committed R110:106251461674: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone (authored by gladhorn).
When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone
Jul 27 2018, 12:23 PM
gladhorn closed D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone.
Jul 27 2018, 12:23 PM · Plasma
gladhorn updated the diff for D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone.

Moved Q_REQUIRED_RESULT to the front

Jul 27 2018, 12:23 PM · Plasma
gladhorn added a comment to D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone.

It's been there for ages, it's mentioned in the changelog at least... but actually it seems more common to put the attribute before the function, I'll update with that.

Jul 27 2018, 12:19 PM · Plasma
gladhorn added a comment to D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone.

I'll check, if it's not public API, I'll make it. Thanks for the pointer.

Jul 27 2018, 12:17 PM · Plasma
gladhorn added a comment to D14410: EDID parsing: strings are up to 13 bytes.

Yes, my laptop screen uses all 13 bytes, that's how I noticed (the model had one character cut off and I happened to debug and see that it was there, so I did the math :)).

Jul 27 2018, 12:16 PM · Plasma
gladhorn committed R110:c66291ec8307: EDID parsing: strings are up to 13 bytes (authored by gladhorn).
EDID parsing: strings are up to 13 bytes
Jul 27 2018, 12:16 PM
gladhorn closed D14410: EDID parsing: strings are up to 13 bytes.
Jul 27 2018, 12:16 PM · Plasma
gladhorn added a comment to D14418: Add test for edid parsing and fix reading gamma.

I'm not sure if you could really say that the current code is with a bug, since data[GCM_EDID_OFFSET_GAMMA] should be dividable by 100. I.e. the result is again an integer and nothing gets truncated. But we can still go with the updated code, which looks nicer. Maybe one could add a comment why divide by 100 and add 1.

In regards to the parser test in the edid test:

  • How did you choose the four brands/models to test?
  • Pls order the rows alphabetically by brand/model name.
Jul 27 2018, 12:11 PM · Plasma
gladhorn added inline comments to D14364: Test configId in TestSerializer.
Jul 27 2018, 9:22 AM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Added one more edid

Jul 27 2018, 8:13 AM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Removed some extra parenthesis

Jul 27 2018, 8:10 AM · Plasma
gladhorn accepted D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled.
Jul 27 2018, 8:08 AM · Plasma
gladhorn abandoned D14371: Simplify Edid::Private::parse gamma.

D14418 is nicer

Jul 27 2018, 7:56 AM · Plasma
gladhorn requested review of D14422: Add edid converter.
Jul 27 2018, 7:46 AM · Plasma
gladhorn added reviewers for D14418: Add test for edid parsing and fix reading gamma: Plasma, romangg.
Jul 27 2018, 6:25 AM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Remove extra newline

Jul 27 2018, 6:11 AM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Minor cleanup

Jul 27 2018, 6:07 AM · Plasma
gladhorn updated the diff for D14418: Add test for edid parsing and fix reading gamma.

Simplify gamma parsing code

Jul 27 2018, 6:05 AM · Plasma
gladhorn requested review of D14418: Add test for edid parsing and fix reading gamma.
Jul 27 2018, 6:04 AM · Plasma
gladhorn committed R104:5b6e9767a73e: Fix layout of resolution selection (authored by gladhorn).
Fix layout of resolution selection
Jul 27 2018, 5:35 AM
gladhorn closed D14326: Fix layout of resolution selection.
Jul 27 2018, 5:35 AM · Plasma

Jul 26 2018

gladhorn requested review of D14410: EDID parsing: strings are up to 13 bytes.
Jul 26 2018, 7:43 PM · Plasma
gladhorn requested review of D14405: Use short pnp id as fallback when the DB file is not found.
Jul 26 2018, 5:48 PM · Plasma
gladhorn updated the diff for D14364: Test configId in TestSerializer.

Add more explanations

Jul 26 2018, 4:45 PM · Plasma
gladhorn updated the diff for D14359: Create m_saveTimer lazily.

Only touch saveTimer

Jul 26 2018, 4:35 PM · Plasma
gladhorn updated the diff for D14359: Create m_saveTimer lazily.

Initialize m_changeCompressor to nullptr

Jul 26 2018, 4:30 PM · Plasma
gladhorn updated the summary of D14326: Fix layout of resolution selection.
Jul 26 2018, 4:24 PM · Plasma
gladhorn updated the diff for D14326: Fix layout of resolution selection.

Fix the layout

Jul 26 2018, 3:50 PM · Plasma
gladhorn committed R104:6dd05a592d48: Change screen orientation label from Normal to No Rotation (authored by gladhorn).
Change screen orientation label from Normal to No Rotation
Jul 26 2018, 1:10 PM
gladhorn closed D14403: Change screen orientation label from Normal to No Rotation.
Jul 26 2018, 1:10 PM · Plasma
gladhorn requested review of D14403: Change screen orientation label from Normal to No Rotation.
Jul 26 2018, 1:08 PM · Plasma
gladhorn committed R104:200cdd782e5f: Change rotation icons to be a rotated preview icon (authored by gladhorn).
Change rotation icons to be a rotated preview icon
Jul 26 2018, 12:55 PM
gladhorn closed D14339: Change rotation icons to be a rotated preview icon.
Jul 26 2018, 12:55 PM · Plasma
gladhorn added inline comments to D14361: Remove unused function.
Jul 26 2018, 12:49 PM · Plasma
gladhorn added a comment to D14326: Fix layout of resolution selection.

The alignment previous to this commit is also not given, it just happens to look a hint better.

Jul 26 2018, 12:43 PM · Plasma
gladhorn added a comment to D14353: Improve alignment of types.

Of course it's questionable if this is worth it, it's unlikely that we'll have so many instances of it that it'll ever make a difference.

Jul 26 2018, 12:42 PM · Plasma
gladhorn added a comment to D14353: Improve alignment of types.

Why push id down? It should stay at the top imo (or alphabetically). Rest is fine.

Jul 26 2018, 12:16 PM · Plasma
gladhorn added a comment to D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled.

Looks good, please finish up cleanup/indentation and I'll accept.

Jul 26 2018, 12:10 PM · Plasma
gladhorn committed R110:2dfbe8d8a6cc: Simplify Edid::Private::edidParseString (authored by gladhorn).
Simplify Edid::Private::edidParseString
Jul 26 2018, 11:57 AM
gladhorn closed D14370: Simplify Edid::Private::edidParseString.
Jul 26 2018, 11:56 AM · Plasma
gladhorn accepted D14398: [dict applet] Fix translation catalog name to match pluginid.
Jul 26 2018, 9:46 AM · Plasma
gladhorn updated the summary of D14339: Change rotation icons to be a rotated preview icon.
Jul 26 2018, 9:43 AM · Plasma
gladhorn updated the diff for D14339: Change rotation icons to be a rotated preview icon.

Updated message hopefully

Jul 26 2018, 9:42 AM · Plasma
gladhorn added a comment to D14339: Change rotation icons to be a rotated preview icon.

And I see that arc just threw away my updated commit message :(, that's just weird.

Jul 26 2018, 9:35 AM · Plasma