gladhorn (Frederik Gladhorn)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 27 2015, 2:36 PM (227 w, 3 d)
Availability
Available

Recent Activity

Mon, Nov 18

brot awarded T11601: Primary Clipboard (middle click) Support a Mountain of Wealth token.
Mon, Nov 18, 8:41 AM · Plasma on Wayland

Tue, Nov 12

laitl awarded T11601: Primary Clipboard (middle click) Support a Like token.
Tue, Nov 12, 2:31 PM · Plasma on Wayland

Sep 25 2019

gladhorn added a comment to T11753: Get plain Qt in shape to be usable by KDE stuff on Windows.

So how about putting the data into either the bundle location or in Library/Application Support/KDE or some other shared common place?
From the Qt perspective, we want to play by the platforms rules. And the task seems to be very much stuck, so it's maybe worthwhile to re-think if KDE cannot better accommodate the various platforms. QStandardPaths::GenericDataLocation sounds great for shared data.

Sep 25 2019, 2:42 PM
gladhorn added a comment to T11753: Get plain Qt in shape to be usable by KDE stuff on Windows.

I don't quite understand the whole data location situation. Are the KDE apps doing something completely non-standard? Maybe it's worthwhile to question KDE's approach at this point, since there seems to be no agreement on that it could possibly viable for mac/win from the Qt people. See comments on https://codereview.qt-project.org/c/qt/qtbase/+/239952

Sep 25 2019, 8:07 AM

Sep 20 2019

gladhorn added inline comments to D24003: kwaylandScanner produce version enum per class.
Sep 20 2019, 1:25 PM · Frameworks
gladhorn updated subscribers of D24004: Teach kwaylandscanner about PrimarySelection.

@romangg and @davidedmundson any comments? I think @zzag prefers the class names without the V1. I'd like to progress on this step by step and the generator at least gives a good starting point.

Sep 20 2019, 1:24 PM · Frameworks

Sep 17 2019

gladhorn accepted D24018: Keep things sorted alphabetically in CMakeLists.txt.
Sep 17 2019, 8:20 AM · KWin
gladhorn closed D24002: Sort files alphabetically in cmake list.
Sep 17 2019, 7:34 AM · Frameworks
gladhorn committed R127:6c8f110f3a22: Sort files alphabetically in cmake list (authored by gladhorn).
Sort files alphabetically in cmake list
Sep 17 2019, 7:34 AM
gladhorn accepted D23909: Pass area by const reference to placeFoo methods.
Sep 17 2019, 7:30 AM · KWin
gladhorn added a comment to D24003: kwaylandScanner produce version enum per class.

The unstable primary selection v1 protocol produces code that doesn't compile, after this change it does compile - since it expects the version enums for three classes, but only the first one is actually written into the file.

Sep 17 2019, 7:26 AM · Frameworks
gladhorn updated the diff for D24002: Sort files alphabetically in cmake list.

Actually sort all files

Sep 17 2019, 7:24 AM · Frameworks

Sep 16 2019

gladhorn requested review of D24004: Teach kwaylandscanner about PrimarySelection.
Sep 16 2019, 6:58 PM · Frameworks
gladhorn requested review of D24003: kwaylandScanner produce version enum per class.
Sep 16 2019, 6:57 PM · Frameworks
gladhorn requested review of D24002: Sort files alphabetically in cmake list.
Sep 16 2019, 6:57 PM · Frameworks
gladhorn added a comment to T11645: Update address in FLA.

Done, now it just needs review and someone needs to push it out on the site.

Sep 16 2019, 1:17 PM · KDE e.V.
gladhorn added a revision to T11645: Update address in FLA: D23992: Update the e.V. office address.
Sep 16 2019, 1:16 PM · KDE e.V.
gladhorn requested review of D23992: Update the e.V. office address.
Sep 16 2019, 1:16 PM
gladhorn committed R917:7e8191c66912: Setup for usage with arc (authored by gladhorn).
Setup for usage with arc
Sep 16 2019, 1:13 PM
gladhorn added a comment to T11645: Update address in FLA.

https://cgit.kde.org/others/fiduciary-licensing-agreement.git/

Sep 16 2019, 11:58 AM · KDE e.V.
gladhorn added a comment to T11645: Update address in FLA.

Note to self: https://cgit.kde.org/websites/ev-kde-org.git/ seems where the document lives.

Sep 16 2019, 11:54 AM · KDE e.V.
gladhorn added a comment to D23415: Improve comprehensibility and consistency of window placement mode names.

I really like the change. I have read a bunch of the KWin code and I had no idea what "Smart" was, despite using KWin for over ten years. Simple terms and consistency are clear winners in my opinion.

Sep 16 2019, 11:36 AM · Documentation, KWin
gladhorn accepted D23923: Drop checkArea helper.
Sep 16 2019, 9:03 AM · KWin

Sep 15 2019

gladhorn closed D23915: Improve documentation.
Sep 15 2019, 7:03 PM · Frameworks
gladhorn committed R127:6388d550e3a2: Improve documentation (authored by gladhorn).
Improve documentation
Sep 15 2019, 7:03 PM

Sep 14 2019

gladhorn accepted D23580: [platforms/virtual] Make VirtualOutput::init() private.
Sep 14 2019, 9:01 PM · KWin
gladhorn accepted D23581: [platforms/wayland] Make WaylandOutput::init() private.
Sep 14 2019, 9:00 PM · KWin
gladhorn added inline comments to D23586: Improve code that detects useful elements in an Svg file.
Sep 14 2019, 8:59 PM · Frameworks
gladhorn added a comment to D23923: Drop checkArea helper.

Looks good to me.

Sep 14 2019, 8:45 PM · KWin
gladhorn added inline comments to D23909: Pass area by const reference to placeFoo methods.
Sep 14 2019, 8:28 PM · KWin
gladhorn added a comment to D23918: RFC: Drop Outputs class.

Yes, it really depends on how many casts it ends up being. Maybe with a helper function. I personally think the vector_cast is almost as bad as inheriting the vector.

Sep 14 2019, 8:25 PM · KWin
gladhorn added inline comments to D23923: Drop checkArea helper.
Sep 14 2019, 8:23 PM · KWin
gladhorn accepted D23947: [platforms/x11] Get rid of some code duplication in windowed backend.

Nice, makes it easier to read :)

Sep 14 2019, 8:18 PM · KWin
gladhorn accepted D23948: Don't initialize QFlags<T> with 0 value.

Makes sense.

Sep 14 2019, 8:10 PM · KWin
gladhorn updated the diff for D23915: Improve documentation.

Thank you arc for messing up my commit message XD

Sep 14 2019, 5:57 PM · Frameworks
gladhorn added inline comments to D23918: RFC: Drop Outputs class.
Sep 14 2019, 5:49 PM · KWin
gladhorn added a comment to D23918: RFC: Drop Outputs class.

How would it be to only keep one vector of AbstractOutputs in Platform? Then there is no vector copying. A cast should in my opinion not be a memory intense operation in the first place, but just a change of how types are interpreted.
In the sub-classes the outputs could then actually be cast as needed (in a convenience function, in case it's more than one or two places). Hopefully this would also reduce code duplication. Of course it only works if there is only one platform in use at a time (I assume that is the case right now already).

Sep 14 2019, 5:43 PM · KWin
gladhorn added a comment to D23918: RFC: Drop Outputs class.

In general I agree with @zzag - composition is better than inheritance since it decouples things.
Many modern programming languages don't even really allow inheritance any more at all.
I wonder if there isn't a solution that avoids all the casting, I cannot say that I'm a fan of the qvector_cast. I didn't really read the code though, just glanced over it.

Sep 14 2019, 4:50 PM · KWin
gladhorn closed D23917: Use const_iterator.
Sep 14 2019, 9:09 AM · Frameworks
gladhorn committed R127:28841048d555: Use const_iterator (authored by gladhorn).
Use const_iterator
Sep 14 2019, 9:09 AM
gladhorn added inline comments to D23915: Improve documentation.
Sep 14 2019, 9:07 AM · Frameworks
gladhorn updated the diff for D23915: Improve documentation.
  1. Updating D23915: Improve documentation
Sep 14 2019, 9:06 AM · Frameworks
gladhorn committed R108:b64e67ce7c0c: Remove disabled TabGroup feature (authored by gladhorn).
Remove disabled TabGroup feature
Sep 14 2019, 8:59 AM
gladhorn closed D23069: Remove disabled TabGroup feature.
Sep 14 2019, 8:59 AM · Documentation, KWin
gladhorn committed R108:a98b8207eb64: Fix invalid tabstop (authored by gladhorn).
Fix invalid tabstop
Sep 14 2019, 8:55 AM
gladhorn closed D23936: Fix invalid tabstop.
Sep 14 2019, 8:55 AM · KWin
gladhorn updated the diff for D23917: Use const_iterator.

Fixed two missing spots

Sep 14 2019, 8:29 AM · Frameworks
gladhorn added a comment to D23917: Use const_iterator.

Yes, for me always using constBegin/constEnd makes reading the code slightly easier.

Sep 14 2019, 8:28 AM · Frameworks
gladhorn requested review of D23936: Fix invalid tabstop.
Sep 14 2019, 8:26 AM · KWin
gladhorn updated the diff for D23069: Remove disabled TabGroup feature.

Removed stuff from .ui files

Sep 14 2019, 8:22 AM · Documentation, KWin
gladhorn committed R108:c870a29f911d: Remove stray semicolon (authored by gladhorn).
Remove stray semicolon
Sep 14 2019, 8:21 AM

Sep 13 2019

gladhorn removed a watcher for KWin: gladhorn.
Sep 13 2019, 6:00 AM

Sep 12 2019

gladhorn updated the diff for D23917: Use const_iterator.

fixup

Sep 12 2019, 8:08 PM · Frameworks
gladhorn requested review of D23917: Use const_iterator.
Sep 12 2019, 8:07 PM · Frameworks
gladhorn closed D23916: Remove capture of this in lambda.
Sep 12 2019, 8:06 PM · Frameworks
gladhorn committed R127:858d9255f722: Remove capture of this in lambda (authored by gladhorn).
Remove capture of this in lambda
Sep 12 2019, 8:06 PM
gladhorn updated the diff for D23916: Remove capture of this in lambda.

Remove more lambda this captures

Sep 12 2019, 8:04 PM · Frameworks
gladhorn requested review of D23916: Remove capture of this in lambda.
Sep 12 2019, 7:38 PM · Frameworks
gladhorn requested review of D23915: Improve documentation.
Sep 12 2019, 7:35 PM · Frameworks

Sep 11 2019

gladhorn added a comment to T11601: Primary Clipboard (middle click) Support.

I seem to have /usr/share/wayland-protocols/unstable/primary-selection/primary-selection-unstable-v1.xml which I'll start with.

Sep 11 2019, 10:42 PM · Plasma on Wayland
gladhorn updated the diff for D23069: Remove disabled TabGroup feature.

Merged in removal of UI

Sep 11 2019, 10:05 PM · Documentation, KWin
gladhorn added a comment to T11601: Primary Clipboard (middle click) Support.

So from what I understand the protocol is defined by the gtk folks, keeping the middle click out of the "core" copy and paste protocol. It needs a bunch of duplication of the copy and paste stuff to implement this. Presumably mostly in kwayland.

Sep 11 2019, 10:03 PM · Plasma on Wayland
gladhorn added a member for Plasma on Wayland: gladhorn.
Sep 11 2019, 10:01 PM
gladhorn added a watcher for KWin: gladhorn.
Sep 11 2019, 9:58 PM
gladhorn added a member for KWin: gladhorn.
Sep 11 2019, 9:58 PM
gladhorn abandoned D23767: Remove UI options related to window tabbing.

Merged into parent change.

Sep 11 2019, 9:57 PM · Documentation, KWin

Sep 10 2019

gladhorn committed R108:26b4b6580c37: Remove unused variable (authored by gladhorn).
Remove unused variable
Sep 10 2019, 12:28 PM
gladhorn closed D23829: Remove unused variable.
Sep 10 2019, 12:28 PM · KWin
gladhorn added a reviewer for D23829: Remove unused variable: KWin.
Sep 10 2019, 12:21 PM · KWin
gladhorn requested review of D23829: Remove unused variable.
Sep 10 2019, 12:21 PM · KWin
gladhorn updated the diff for D23767: Remove UI options related to window tabbing.

Rebased

Sep 10 2019, 12:04 PM · Documentation, KWin
gladhorn updated the diff for D23069: Remove disabled TabGroup feature.

Rebased

Sep 10 2019, 12:03 PM · Documentation, KWin
gladhorn accepted D23799: Get rid of khtml usage (kill classic mode).

Based on all the +1s, this should clearly go in. Go for it :)

Sep 10 2019, 10:58 AM · Plasma

Sep 9 2019

gladhorn added a comment to T11074: Make KDE more Accessible for Everybody.

Thanks! I do think that we will work towards better accessibility independent of this. I think we'll have the support of many other developers, but sadly accessibility is not the most mainstream topic. I do intend to meet up with at least @chempfling some time soon (sadly I end up being busy way too often).
I think it was a good exercise to formulate the goal in any case and I think we'll continue to influence other developers to make good choices for all users :)

Sep 9 2019, 2:07 PM · Goal Setting 2019

Sep 7 2019

gladhorn updated the diff for D23767: Remove UI options related to window tabbing.

Remove two more lines

Sep 7 2019, 10:30 AM · Documentation, KWin
gladhorn added a comment to D23069: Remove disabled TabGroup feature.

I did the UI changes and kept them separate for now. https://phabricator.kde.org/D23767

Sep 7 2019, 10:09 AM · Documentation, KWin
gladhorn requested review of D23767: Remove UI options related to window tabbing.
Sep 7 2019, 10:08 AM · Documentation, KWin
gladhorn added a comment to D23069: Remove disabled TabGroup feature.

I can do the UI changes (and I don't mind re-basing the change if the other one goes in first). Should I squash the UI changes into this patch or create a new change?

Sep 7 2019, 9:32 AM · Documentation, KWin
gladhorn added a comment to D23069: Remove disabled TabGroup feature.

On this change: we also have window tabs in the window rule system and also in the configuration system (e.g. middle click to move tabs).

@gladhorn Can you please remove these leftovers?

Sep 7 2019, 8:14 AM · Documentation, KWin

Aug 16 2019

gladhorn added a comment to D23144: Port from QFontMetrics::width() to boundingRect().width().

Yes, so for size hints, this should be fine. For actually placing individual chars and calculating their width in the terminal window I didn't dare changing things.

Aug 16 2019, 5:42 PM · Konsole

Aug 14 2019

gladhorn committed R108:1296ad39865c: Remove custom menu positioning code (authored by gladhorn).
Remove custom menu positioning code
Aug 14 2019, 9:50 AM
gladhorn closed D23142: Remove custom menu positioning code.
Aug 14 2019, 9:50 AM · KWin
gladhorn added a comment to D23144: Port from QFontMetrics::width() to boundingRect().width().

See also https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

Aug 14 2019, 7:53 AM · Konsole
gladhorn requested review of D23144: Port from QFontMetrics::width() to boundingRect().width().
Aug 14 2019, 7:49 AM · Konsole
gladhorn requested review of D23143: Use QCommandLineOption::HiddenFromHelp instead of deprecated API.
Aug 14 2019, 7:46 AM · Konsole
gladhorn committed R108:25ec024ab591: Use compiler __SSE2__ definitions and C++11 alignas (authored by gladhorn).
Use compiler __SSE2__ definitions and C++11 alignas
Aug 14 2019, 7:31 AM
gladhorn closed D23120: Use compiler __SSE2__ definitions and C++11 alignas.
Aug 14 2019, 7:31 AM · KWin
gladhorn requested review of D23142: Remove custom menu positioning code.
Aug 14 2019, 7:31 AM · KWin

Aug 13 2019

gladhorn updated the diff for D23120: Use compiler __SSE2__ definitions and C++11 alignas.

Use #if defined consistently

Aug 13 2019, 7:40 PM · KWin
gladhorn added a comment to D23120: Use compiler __SSE2__ definitions and C++11 alignas.
In D23120#511135, @zzag wrote:

There seem to be frequent crashes in the quad version of this code, but
this change should not make any difference from what I can tell.

I doubt that kwin crashes because of alignment issues. I suggest looking into whether GLVertexBuffer::streamingBuffer() is still valid.

Aug 13 2019, 7:35 PM · KWin
gladhorn committed R108:ce404f52a80f: Use C++ cast instead of c-style (authored by gladhorn).
Use C++ cast instead of c-style
Aug 13 2019, 6:43 AM
gladhorn closed D23121: Use C++ cast instead of c-style.
Aug 13 2019, 6:43 AM · KWin
gladhorn added inline comments to D23102: Reduce duplicate code calculating popup position.
Aug 13 2019, 6:41 AM · KWin
gladhorn committed R108:0a5b029a391f: Reduce duplicate code calculating popup position (authored by gladhorn).
Reduce duplicate code calculating popup position
Aug 13 2019, 6:39 AM
gladhorn closed D23102: Reduce duplicate code calculating popup position.
Aug 13 2019, 6:39 AM · KWin
gladhorn added a reviewer for D23120: Use compiler __SSE2__ definitions and C++11 alignas: KWin.
Aug 13 2019, 6:32 AM · KWin
gladhorn added a comment to D23121: Use C++ cast instead of c-style.

This is interesting, since it's around the corner from this crash: https://bugs.kde.org/show_bug.cgi?id=399499 - But of course this patch won't change anything, just make it slightly easier to see what's going on.

Aug 13 2019, 6:32 AM · KWin
gladhorn added a reviewer for D23121: Use C++ cast instead of c-style: KWin.
Aug 13 2019, 6:31 AM · KWin
gladhorn requested review of D23121: Use C++ cast instead of c-style.
Aug 13 2019, 6:30 AM · KWin
gladhorn requested review of D23120: Use compiler __SSE2__ definitions and C++11 alignas.
Aug 13 2019, 6:23 AM · KWin