Use DEBUGCATEGORIESDIR and debug-categories5

In D21312#468223, @cfeck wrote:

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

Example Canon thumbnail attached:

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

I think what bugs me is the fact that the bar is below Root as well. If the only Places panel entries to get capacity bars were actual devices, I think it might feel better. And we're actually planning to remove the Root entry soon anyway: D15739. I just need to get around to fixing the test...

Use KColorScheme's NegativeText color

In D21312#467721, @ndavis wrote:

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Go right ahead!

update

I wonder if it was necessary to do the whole move into core :P.

In T10891#185624, @abetts wrote:

Would it be possible in this evolution to explore more streamlined spin boxes? I have always felt, our current version mixes the control with the content and it would probably be cooler to have them look separate. Maybe more like this:

https://images.app.goo.gl/TmNs1cWBrH2oyiRc7

Or this

https://images.app.goo.gl/PLed1isQZcSMwGiE9

Sync copyright headers to existing style

Hope this helps ^^'

• Addressing code review comments
• Adding back macro
• Allow window activation without forceActiveWindow()
• Avoiding duplication of tabs
• Distributing URLs among all instances
• Making ShowFolders/ShowItems also check if URLs are open in other tabs
• Ensuring current instance is considered when needed
• Removing unnecessary include
• Overloading openFiles/openDirectories
• Removing unnecessary new line
• Amend test
• Fixing header file

errata: the setDontChangeHlOnSave() function has nothing to do here.
more time I upload a patch.

I'm not going to pretend i understand the code, but you wrote lots of unittests, so that's good, let's get this in :)

So I will keep it this way.

This article on designing systemic colours (and comment) explores some of the challenges faced with designing color palettes. Example implementation in JS

Their user interfaces are different; the selection button offers three different types of selections, but allows a click-and-don't-hold to activate the last one. I'm not the hugest fan of this UI; I would prefer three different buttons or a dropdown menu that opens on click-and-don't-hold. But there's no reason to emulate it since the UI you have here is different.

The bugs Alvin reported are fixed in this version. As for item no. 4 in my previous comment, it only works if I use WinTab as the source API. Windows Ink still doesn't work.

In D21195#468008, @ngraham wrote:

+1 for this. I think it makes sense. Trying it out, I like it a lot.

I'm on Surface Pro 4/Windows 10 and everything goes well except for (2):

In D20585#465924, @mart wrote:

I don't like adding a new property to separator for doing duck typing...

even is really ugly and errorprone as well, but i would prefer
Layout.topMargin: item.toString().indexOf("Separator")===0 ? Kirigami.Units.smallSpacing : 0

with a comment:
// FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 5.11

minor fix

use mart's solution

There even is a bug report about this: https://bugs.kde.org/show_bug.cgi?id=381532
In this bug report, there is also an example of how sublime text handles this, namely "Document name - path/bla", i.e. the path is appended behind the document name. What about this solution?

In D21202#466067, @joaonetto wrote:

In D21202#466066, @aacid wrote:

Do you have some files that exercise this?

Who would we autotest this?

I intend to test this when all the functions needed to work are implemented.

Or would you like a test for every function?

In D20972#465912, @davidedmundson wrote:

When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it

From what? Should they be there?

Closed because of: https://phabricator.kde.org/D21123