patrickelectric (patrick j pereira)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2016, 2:30 AM (136 w, 4 d)
Availability
Available

Recent Activity

Tue, Oct 23

patrickelectric accepted D14136: Basic SD Write Support.
Tue, Oct 23, 1:40 PM · Atelier: AtCore
patrickelectric accepted D16200: Use SerialLayer()->pushCommand in only in processQueue.
Tue, Oct 23, 1:37 PM · Atelier: AtCore

Mon, Oct 15

patrickelectric accepted D16205: Cleanup warning replace deprecated call to serialLayer.
Mon, Oct 15, 11:35 PM · Atelier: General Development
patrickelectric added a comment to D16206: Use AtCore::pushedCommand.

Why this is in a different review if needs D16199 ?

Mon, Oct 15, 11:34 PM · Atelier: General Development
patrickelectric requested changes to D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 11:33 PM · Atelier: AtCore
patrickelectric added a comment to D16199: Make SerialLayer completely private.

What is the logic behind this change ?

Mon, Oct 15, 11:32 PM · Atelier: AtCore

Oct 14 2018

patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 14 2018, 1:35 PM

Oct 13 2018

patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:39 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:09 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:07 PM
patrickelectric added a comment to D16181: Move final terminator in firmware plugin side.

How do we send commands now before connected to a firmware?

There is a generic function when a plugin is not loaded.

M115 has to be sent before any firmware connection.

Yes, you can use the default function like I said before.

Oct 13 2018, 9:25 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 8:10 PM
patrickelectric added a comment to D16181: Move final terminator in firmware plugin side.

Can you please "fix" the other plugins with \r\n so this does not break them

Oct 13 2018, 7:25 PM
patrickelectric accepted D15858: Warning Roundup.
Oct 13 2018, 7:23 PM · Atelier: General Development
patrickelectric accepted D16002: QUrl.toString() is not a valid local file.
Oct 13 2018, 6:59 PM
patrickelectric requested changes to D14136: Basic SD Write Support.
Oct 13 2018, 6:36 PM · Atelier: AtCore
patrickelectric requested changes to D15858: Warning Roundup.
Oct 13 2018, 6:23 PM · Atelier: General Development
patrickelectric accepted D15861: Warning Clean.
Oct 13 2018, 6:03 PM · Atelier: AtCore
patrickelectric requested review of D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 5:53 PM
patrickelectric accepted D16180: Switch to C++11 scoped enums.

I'm ok with it.
Wait @tcanabrava and @rizzitello to review as well.

Oct 13 2018, 5:46 PM
patrickelectric added reviewers for D16180: Switch to C++11 scoped enums: rizzitello, tcanabrava.
Oct 13 2018, 5:45 PM

Oct 12 2018

patrickelectric updated subscribers of T9542: Atelier QML Interface - Discussion.
Oct 12 2018, 11:59 AM · Atelier, VDG
patrickelectric updated subscribers of T9542: Atelier QML Interface - Discussion.
Oct 12 2018, 11:42 AM · Atelier, VDG

Oct 10 2018

patrickelectric requested changes to D15858: Warning Roundup.
Oct 10 2018, 12:00 PM · Atelier: General Development
patrickelectric added inline comments to D15861: Warning Clean.
Oct 10 2018, 11:44 AM · Atelier: AtCore

Sep 30 2018

patrickelectric requested changes to D15861: Warning Clean.
Sep 30 2018, 3:55 PM · Atelier: AtCore

Sep 25 2018

patrickelectric accepted D15701: More Cleanup.
Sep 25 2018, 1:42 PM · Atelier: AtCore

Sep 23 2018

patrickelectric requested changes to D15701: More Cleanup.
Sep 23 2018, 1:09 AM · Atelier: AtCore
patrickelectric accepted D15700: Use bit percentage for fan speed.
Sep 23 2018, 12:24 AM · Atelier: AtCore

Sep 18 2018

patrickelectric accepted D15547: Add Connect for new Movement Widget.
Sep 18 2018, 2:27 PM · Atelier
patrickelectric accepted D15224: Allow for fractional Movement.
Sep 18 2018, 2:20 PM · Atelier: AtCore

Sep 10 2018

patrickelectric added inline comments to D15281: New AxisControl Widget.
Sep 10 2018, 3:01 PM · Atelier: AtCore
patrickelectric added inline comments to D15281: New AxisControl Widget.
Sep 10 2018, 2:45 PM · Atelier: AtCore

Sep 9 2018

patrickelectric added inline comments to D14136: Basic SD Write Support.
Sep 9 2018, 5:44 PM · Atelier: AtCore
patrickelectric added inline comments to D14136: Basic SD Write Support.
Sep 9 2018, 2:38 PM · Atelier: AtCore
patrickelectric added inline comments to D14136: Basic SD Write Support.
Sep 9 2018, 2:36 PM · Atelier: AtCore
patrickelectric accepted D15281: New AxisControl Widget.

I think that need the unit showing in the textbox, like mm, cm, m.

Sep 9 2018, 1:28 AM · Atelier: AtCore
patrickelectric accepted D12456: Enable a notification system.
Sep 9 2018, 1:00 AM
patrickelectric requested changes to D15281: New AxisControl Widget.
Sep 9 2018, 12:58 AM · Atelier: AtCore
patrickelectric requested changes to D14136: Basic SD Write Support.
Sep 9 2018, 12:54 AM · Atelier: AtCore

Sep 7 2018

patrickelectric accepted D15122: Check if file exists before print.
Sep 7 2018, 9:01 PM

Sep 5 2018

patrickelectric accepted D15280: Code Cleanup.
Sep 5 2018, 12:10 PM · Atelier: AtCore
patrickelectric added a comment to D15280: Code Cleanup.

int32_t

Sep 5 2018, 11:40 AM · Atelier: AtCore
patrickelectric requested changes to D15122: Check if file exists before print.
Sep 5 2018, 1:51 AM
patrickelectric requested changes to D15280: Code Cleanup.
Sep 5 2018, 12:44 AM · Atelier: AtCore

Sep 3 2018

patrickelectric edited projects for T9542: Atelier QML Interface - Discussion, added: Atelier; removed Atelier: AtCore.
Sep 3 2018, 3:15 PM · Atelier, VDG
patrickelectric edited projects for T9542: Atelier QML Interface - Discussion, added: Atelier: AtCore; removed Atelier.
Sep 3 2018, 3:15 PM · Atelier, VDG
patrickelectric added a comment to T9542: Atelier QML Interface - Discussion.

@abetts One of the most important things in a 3D printer are:

  • 4 Axis control
    • To control X, Y, Z, and E (the extruder, the guy that extrude plastic to create the 3D object)
    • The control need to be able to move with steps from 10cm to 0.01mm. (This values can change from printer to printer).
    • The extruder control should have a extruder multiplier that changes the extrusion quantity from 0.5x to 2x.
  • Temperature control
    • This sets the temperature in the extruder and the heated bed. The max values should be set by the user.
  • Command mode
    • The user should be able to send machine code to the printer, allowing some personalization.
    • This command code should output data from the printer and show to the user as well, like a normal terminal.
Sep 3 2018, 3:14 PM · Atelier, VDG

Sep 2 2018

patrickelectric added a comment to T9542: Atelier QML Interface - Discussion.

Hello Andres, Thank you for your first mockup.
But I would like to comment some points.

Sep 2 2018, 11:02 PM · Atelier, VDG
patrickelectric added inline comments to D15214: axiscontrol: Add spindle in text.
Sep 2 2018, 9:58 PM · Atelier: AtCore
patrickelectric updated the diff for D15214: axiscontrol: Add spindle in text.
  • WIP
Sep 2 2018, 9:44 PM · Atelier: AtCore
patrickelectric added a comment to D15224: Allow for fractional Movement.

If you want to put a scale, we should remove the intern circles and only let one xyz control without 0.1,1,10 buttons, only 1x.

This is a way to allow fractional movement on the pie controller. do u think i should just change the defaults to 0.1 1 10 and drop the scale completely ?

Sep 2 2018, 9:40 PM · Atelier: AtCore
patrickelectric added a comment to D15224: Allow for fractional Movement.

If you want to put a scale, we should remove the intern circles and only let one xyz control without 0.1,1,10 buttons, only 1x.

Sep 2 2018, 9:11 PM · Atelier: AtCore
patrickelectric added inline comments to D15214: axiscontrol: Add spindle in text.
Sep 2 2018, 1:51 PM · Atelier: AtCore
patrickelectric added inline comments to D15214: axiscontrol: Add spindle in text.
Sep 2 2018, 1:33 PM · Atelier: AtCore
patrickelectric added a comment to D15214: axiscontrol: Add spindle in text.

I DON'T WANT TO BREAK THE BINARY COMPATIBILITY BETWEEN THE PLUGINS !!!!
pls, review with love.

Sep 2 2018, 3:00 AM · Atelier: AtCore
patrickelectric added a project to D15214: axiscontrol: Add spindle in text: Atelier: AtCore.
Sep 2 2018, 3:00 AM · Atelier: AtCore
patrickelectric requested review of D15214: axiscontrol: Add spindle in text.
Sep 2 2018, 2:59 AM · Atelier: AtCore

Aug 29 2018

patrickelectric added a comment to T9542: Atelier QML Interface - Discussion.

Some corrections/notes:

  • Should be able to use in smartphones as well.
  • 3D rendering of the gcode and update of the viewer while showing the printing progress.
  • View for multiple camera monitoring
  • The extruder and extrusion/retract need to handle multiple extruders.
  • The extrusion and retract should allow the user to control the length of the filament (not a simple up down arrow).
  • Panel for connectivity configuration (connecting to remote service of atcore).
  • Show notifications for when:
    • print start
    • print finish
    • Something is wrong (YOUR PRINTER IS IN FIRE !)
      • If possible, showing a picture with the notification, showing the actual state of the printer.
    • Allow specific notifications like: Changing layer and etc.
Aug 29 2018, 4:55 PM · Atelier, VDG

Aug 27 2018

patrickelectric requested changes to D14136: Basic SD Write Support.
Aug 27 2018, 11:43 AM · Atelier: AtCore
patrickelectric accepted D15080: Handle serialErrors.
Aug 27 2018, 11:36 AM · Atelier: AtCore
patrickelectric accepted D13576: Allow non reset on connect.
Aug 27 2018, 11:34 AM · Atelier: AtCore

Aug 25 2018

patrickelectric accepted D15031: Let go of the useless enabled calls.
Aug 25 2018, 3:52 PM
patrickelectric added inline comments to D15080: Handle serialErrors.
Aug 25 2018, 3:25 PM · Atelier: AtCore
patrickelectric requested changes to D15080: Handle serialErrors.
Aug 25 2018, 2:59 PM · Atelier: AtCore
patrickelectric added inline comments to D12456: Enable a notification system.
Aug 25 2018, 1:59 PM
patrickelectric accepted D15028: Cleanup the unused fps code.
Aug 25 2018, 12:20 PM

Aug 24 2018

patrickelectric accepted D14981: Check for plugins using newer atcore method.
Aug 24 2018, 9:15 PM · Atelier: General Development
patrickelectric added a comment to D15046: Add our own simple camera controller and use it.

I'll need to test this patch. Probably in the weekend.

Aug 24 2018, 12:20 PM
patrickelectric accepted D15043: Center the camera on the LineMesh bounding box.
Aug 24 2018, 11:14 AM
patrickelectric accepted D15045: Add an axis gnomon entity to the scene.
Aug 24 2018, 11:03 AM

Aug 21 2018

patrickelectric accepted D14964: Ensure runtime paths are correct.

Tested and working on mac

Aug 21 2018, 12:31 PM · Atelier: AtCore

Aug 18 2018

patrickelectric added a comment to D14891: fix potentially bug on accessing global variable on instance of AtCore.

Yes, if someone is forcing a int is because he knows what he is doing (or
not).
In either case, if you are using a int as argument the compiler will not
accept.

Aug 18 2018, 11:59 AM
patrickelectric added inline comments to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Aug 18 2018, 11:51 AM
patrickelectric accepted D14891: fix potentially bug on accessing global variable on instance of AtCore.
Aug 18 2018, 8:40 AM

Aug 14 2018

patrickelectric added inline comments to D14842: Check if file exists - ChooseFileDialog.
Aug 14 2018, 8:21 PM
patrickelectric added inline comments to D14842: Check if file exists - ChooseFileDialog.
Aug 14 2018, 8:02 PM

Aug 13 2018

patrickelectric added inline comments to D14792: Improve regex to get bed target tmp.
Aug 13 2018, 2:06 PM

Jul 25 2018

patrickelectric accepted D13978: Atelier Aware if a file is modified on close/ print.
Jul 25 2018, 3:48 PM · Atelier: General Development

Jul 17 2018

patrickelectric requested changes to D13978: Atelier Aware if a file is modified on close/ print.
Jul 17 2018, 11:10 AM · Atelier: General Development

Jul 15 2018

patrickelectric added a comment to D14136: Basic SD Write Support.

Are this patch rebased on master ? It appears to be not.

Jul 15 2018, 9:16 PM · Atelier: AtCore

Jun 28 2018

patrickelectric committed R232:16d93b730612: widgets: Fix potential detach of non-const Qt containers (authored by patrickelectric).
widgets: Fix potential detach of non-const Qt containers
Jun 28 2018, 3:16 PM
patrickelectric committed R232:86cd40c2b992: core: Fix potential detach of non-const Qt containers (authored by patrickelectric).
core: Fix potential detach of non-const Qt containers
Jun 28 2018, 3:16 PM
patrickelectric committed R232:369f610d8b30: widgets: Fix potential detach of non-const Qt containers (authored by patrickelectric).
widgets: Fix potential detach of non-const Qt containers
Jun 28 2018, 3:16 PM
patrickelectric closed D13780: widgets: Fix potential detach of non-const Qt containers.
Jun 28 2018, 3:16 PM
patrickelectric requested changes to D13576: Allow non reset on connect.
Jun 28 2018, 12:49 PM · Atelier: AtCore
patrickelectric added a comment to D13780: widgets: Fix potential detach of non-const Qt containers.

They are const variables inside the scope.

Jun 28 2018, 12:40 PM
patrickelectric added a comment to D13780: widgets: Fix potential detach of non-const Qt containers.

Why ? and why only for these two

Jun 28 2018, 12:19 PM
patrickelectric committed R232:21c9b798d6c7: core: Correct emit signal call (authored by patrickelectric).
core: Correct emit signal call
Jun 28 2018, 12:18 PM
patrickelectric committed R232:cb847fabb2d2: plugins: Add missing emit (authored by patrickelectric).
plugins: Add missing emit
Jun 28 2018, 12:18 PM
patrickelectric committed R232:c34e80fcd6cd: widgets: Correct emit signal call (authored by patrickelectric).
widgets: Correct emit signal call
Jun 28 2018, 12:18 PM
patrickelectric committed R232:554c14b0505f: core: Correct emit signal call (authored by patrickelectric).
core: Correct emit signal call
Jun 28 2018, 12:18 PM
patrickelectric closed D13778: core: Correct emit signal call.
Jun 28 2018, 12:18 PM
patrickelectric committed R232:ac9fa0b68377: core: Use mult args QString in arg (authored by patrickelectric).
core: Use mult args QString in arg
Jun 28 2018, 12:17 PM
patrickelectric committed R232:0807155091d1: testclient: Use mult args QString in arg (authored by patrickelectric).
testclient: Use mult args QString in arg
Jun 28 2018, 12:17 PM
patrickelectric committed R232:802f5162bc7d: core: Use mult args QString in arg (authored by patrickelectric).
core: Use mult args QString in arg
Jun 28 2018, 12:17 PM
patrickelectric closed D13779: core: Use mult args QString in arg.
Jun 28 2018, 12:17 PM
patrickelectric added reviewers for D13780: widgets: Fix potential detach of non-const Qt containers: tcanabrava, rizzitello, laysrodrigues.
Jun 28 2018, 12:11 PM
patrickelectric requested review of D13780: widgets: Fix potential detach of non-const Qt containers.
Jun 28 2018, 12:10 PM
patrickelectric updated the diff for D13778: core: Correct emit signal call.
  • plugins: Add missing emit
Jun 28 2018, 12:08 PM