patrickelectric (patrick j pereira)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2016, 2:30 AM (198 w, 4 d)
Availability
Available

Recent Activity

Mon, Jan 20

patrickelectric added a comment to D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.

@apol I did update the commit body to explain why.
For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2
Let me know if you agree with this to land the patch, this is necessary to continue D26752

Mon, Jan 20, 12:09 PM · Build System, Frameworks
patrickelectric updated the diff for D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.

Add commit body

Mon, Jan 20, 12:03 PM · Build System, Frameworks
patrickelectric added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here.

Mon, Jan 20, 10:46 AM · Build System, Frameworks

Sun, Jan 19

patrickelectric added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?

Sun, Jan 19, 10:57 PM · Build System, Frameworks
patrickelectric committed R1034:e215c1ba296b: gstreamer: Run clang-format in .c (authored by patrickelectric).
gstreamer: Run clang-format in .c
Sun, Jan 19, 4:51 PM
patrickelectric committed R1034:b93cd9561123: gstreamerintegration: Add test for videoOutput pointer (authored by patrickelectric).
gstreamerintegration: Add test for videoOutput pointer
Sun, Jan 19, 4:49 PM
patrickelectric committed R1034:d0a4f5136785: gstreamerintegration: Add assert for pipeline (authored by patrickelectric).
gstreamerintegration: Add assert for pipeline
Sun, Jan 19, 4:49 PM

Sat, Jan 18

patrickelectric committed R1034:58669f5edaeb: vehiclesupportpluginmodel: Use any_of (authored by patrickelectric).
vehiclesupportpluginmodel: Use any_of
Sat, Jan 18, 4:26 PM
patrickelectric committed R1034:67af51e165c1: vehicleparameters: Add Q_UNUSED in loadDescriptionFile (authored by patrickelectric).
vehicleparameters: Add Q_UNUSED in loadDescriptionFile
Sat, Jan 18, 4:26 PM
patrickelectric committed R1034:6356857d8b46: mavlink: Move GSC check to mavlinkconnection (authored by patrickelectric).
mavlink: Move GSC check to mavlinkconnection
Sat, Jan 18, 4:26 PM
patrickelectric committed R1034:fc905a1b26bb: abstractvehicle: Add missing Q_INVOKABLE in setControllerGpsPosition (authored by patrickelectric).
abstractvehicle: Add missing Q_INVOKABLE in setControllerGpsPosition
Sat, Jan 18, 4:25 PM
patrickelectric retitled D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build from ECMAddAppIcon: Do not warn about mac icons if isnt a mac build to ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sat, Jan 18, 2:08 PM · Build System, Frameworks
patrickelectric added reviewers for D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build: apol, tcanabrava.
Sat, Jan 18, 2:04 PM · Build System, Frameworks
patrickelectric requested review of D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sat, Jan 18, 2:03 PM · Build System, Frameworks
patrickelectric added a reviewer for D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names: apol.
Sat, Jan 18, 1:50 PM · Build System, Frameworks
patrickelectric added a comment to D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.

From ECMInstallIcons:

Sat, Jan 18, 1:46 PM · Build System, Frameworks
patrickelectric requested review of D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
Sat, Jan 18, 1:44 PM · Build System, Frameworks

Fri, Jan 3

patrickelectric committed R1034:f0646437fb8a: Vehicle: Update item to use the new role style (authored by patrickelectric).
Vehicle: Update item to use the new role style
Fri, Jan 3, 1:00 PM
patrickelectric committed R1034:7810bc0980fc: mavlink: Fetch parameters and use parametermodel (authored by patrickelectric).
mavlink: Fetch parameters and use parametermodel
Fri, Jan 3, 1:00 PM
patrickelectric committed R1034:4d944939c86c: vehiclesupportpluginmodel: Remove capitalized role names (authored by patrickelectric).
vehiclesupportpluginmodel: Remove capitalized role names
Fri, Jan 3, 1:00 PM
patrickelectric committed R1034:7a2c48d0a59c: vehicleparameters: First version (authored by patrickelectric).
vehicleparameters: First version
Fri, Jan 3, 1:00 PM

Thu, Dec 26

patrickelectric committed R1034:951969814065: positionsource: Add missing periods (authored by patrickelectric).
positionsource: Add missing periods
Thu, Dec 26, 10:59 PM
patrickelectric committed R1034:0a1af2d2754d: FlightControls: Use new position source from kirogi plugin (authored by patrickelectric).
FlightControls: Use new position source from kirogi plugin
Thu, Dec 26, 10:21 PM
patrickelectric committed R1034:555e2f459ac0: positionsource: First version (authored by patrickelectric).
positionsource: First version
Thu, Dec 26, 10:21 PM
patrickelectric committed R1034:0680e5dd8794: main: Use PositionSource (authored by patrickelectric).
main: Use PositionSource
Thu, Dec 26, 10:21 PM

Tue, Dec 24

patrickelectric committed R1034:1b3654c8a8b9: Merge branch 'fix_style' into 'master' (authored by patrickelectric).
Merge branch 'fix_style' into 'master'
Tue, Dec 24, 5:19 PM
patrickelectric committed R1034:d669a4d0130c: mavlinkvehicle: Fix code style (authored by patrickelectric).
mavlinkvehicle: Fix code style
Tue, Dec 24, 5:19 PM
patrickelectric committed R1034:df49d2825ddd: Merge branch 'position_invalidate' into 'master' (authored by patrickelectric).
Merge branch 'position_invalidate' into 'master'
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:a47a080e5e8b: mavlinkvehicle: Invalidate position information if values are invalid (authored by patrickelectric).
mavlinkvehicle: Invalidate position information if values are invalid
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:87921560e5d4: YawBar: Allow vehicle feedback if the vehicle is not ready to fly (authored by patrickelectric).
YawBar: Allow vehicle feedback if the vehicle is not ready to fly
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:81823f0932c6: Merge branch 'remove_ready' into 'master' (authored by patrickelectric).
Merge branch 'remove_ready' into 'master'
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:bb9198cda3f4: vehicle: Allow vehicle feedback if the vehicle is not ready to fly (authored by patrickelectric).
vehicle: Allow vehicle feedback if the vehicle is not ready to fly
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:1ae2565fa4a4: PitchBar: Allow vehicle feedback if the vehicle is not ready to fly (authored by patrickelectric).
PitchBar: Allow vehicle feedback if the vehicle is not ready to fly
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:6e3870b26e9c: FlightControls: Allow vehicle feedback if the vehicle is not ready to fly (authored by patrickelectric).
FlightControls: Allow vehicle feedback if the vehicle is not ready to fly
Tue, Dec 24, 4:38 PM
patrickelectric committed R1034:3826f8e1cfbd: CMakeLists: Add DEBUG_QML option to enable QML profiller (authored by patrickelectric).
CMakeLists: Add DEBUG_QML option to enable QML profiller
Tue, Dec 24, 4:37 PM
patrickelectric committed R1034:01b04b6f5210: Merge branch 'qt_debug_profiller' into 'master' (authored by patrickelectric).
Merge branch 'qt_debug_profiller' into 'master'
Tue, Dec 24, 4:37 PM
patrickelectric committed R1034:a72da0ca73e7: Merge branch 'move_yaw' into 'master' (authored by patrickelectric).
Merge branch 'move_yaw' into 'master'
Tue, Dec 24, 4:37 PM
patrickelectric committed R1034:f24e0072f9c4: FlightControls: Move yaw indicator if the inputMode changes visibility (authored by patrickelectric).
FlightControls: Move yaw indicator if the inputMode changes visibility
Tue, Dec 24, 4:37 PM
patrickelectric committed R1034:a073ef4607a8: Merge branch 'do_not_trust_udp' into 'master' (authored by patrickelectric).
Merge branch 'do_not_trust_udp' into 'master'
Tue, Dec 24, 4:36 PM
patrickelectric committed R1034:6348a7fe4752: mavlinkconnection: Do not trust UDP to set the vehicle as connected (authored by patrickelectric).
mavlinkconnection: Do not trust UDP to set the vehicle as connected
Tue, Dec 24, 4:36 PM
patrickelectric committed R1034:658cfb96fa4a: Merge branch 'new_altitude' into 'master' (authored by patrickelectric).
Merge branch 'new_altitude' into 'master'
Tue, Dec 24, 4:36 PM
patrickelectric committed R1034:327caaf8d896: mavlinkvehicle: Use global_position_int if altitude messages is not valid (authored by patrickelectric).
mavlinkvehicle: Use global_position_int if altitude messages is not valid
Tue, Dec 24, 4:36 PM
patrickelectric committed R1034:3497b86093c5: FlightControls: Set yaw property (authored by patrickelectric).
FlightControls: Set yaw property
Tue, Dec 24, 2:58 AM
patrickelectric committed R1034:79a4ded6a444: FlightControls: Remove limit checks (authored by patrickelectric).
FlightControls: Remove limit checks
Tue, Dec 24, 2:57 AM

Mon, Dec 23

patrickelectric added a comment to D26130: Simplify return logic.

This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly obliterated by the ternary operator. This is a pessimisation you're proposing here, not an optimization.

I don't know what you are talking about, this is using return time optimization. have you tested the code or just assumed that ternaries will not do NRVO?

OK, let me try again.

I did benchmark old and new before my first reply (and I wonder why I wrote pessimisation previously, I think I got carried away a bit, apologies). What I meant was that: if and when there is a small measurable gain, I don't think it is as dramatic as you make it sound. The point I was trying to make was that since the ternary will prevent NRVO, you're trading one return optimization (NRVO) for another (RVO). In other words, the same amount of objects will be involved. It's far from the "there was no return optimization now there's one" that I understood you're trumping. Thus the gain between the two versions when there is, is unlikely to come from RVO. It is mostly about avoiding the move assignment in the newer version (roughly a couple pointers copy).

Now, the really interesting bit you did is wrapping "d->" in QStringLiteral, that's what gives a large gain for the dpointer case (when I did the benchmarking I did it with QStringLiteral in both versions, otherwise I knew it was just unfair).

Obviously I'd be totally cool with just a QStringLiteral change since it would have real value (divides time by three roughly, this is definitely a large gain).

Mon, Dec 23, 8:55 PM · Frameworks
patrickelectric committed R1034:40e25611e4b3: parrot: Use pragma once (authored by patrickelectric).
parrot: Use pragma once
Mon, Dec 23, 4:42 PM
patrickelectric committed R1034:d502a90b184d: ryzetello: Use pragma once (authored by patrickelectric).
ryzetello: Use pragma once
Mon, Dec 23, 4:42 PM
patrickelectric committed R1034:c0f4d0320513: src: Use pragma once (authored by patrickelectric).
src: Use pragma once
Mon, Dec 23, 4:42 PM
patrickelectric committed R1034:6c55ef2078bd: lib: Use pragma once (authored by patrickelectric).
lib: Use pragma once
Mon, Dec 23, 4:42 PM
patrickelectric committed R1034:69d4699bd707: gstreamer: Use pragma once (authored by patrickelectric).
gstreamer: Use pragma once
Mon, Dec 23, 4:42 PM
patrickelectric committed R1034:8a6160c6bea0: PitchBar: Fix readonly usage (authored by patrickelectric).
PitchBar: Fix readonly usage
Mon, Dec 23, 4:41 PM

Dec 23 2019

patrickelectric committed R1034:31352a8d435a: README: Update MAVLink information (authored by patrickelectric).
README: Update MAVLink information
Dec 23 2019, 4:26 PM
patrickelectric committed R1034:6823704d9b02: CMakelists: Add BUILD_MAVLINNK option (authored by patrickelectric).
CMakelists: Add BUILD_MAVLINNK option
Dec 23 2019, 4:26 PM
patrickelectric committed R1034:8df091445576: FlightControls: Add YawBar (authored by patrickelectric).
FlightControls: Add YawBar
Dec 23 2019, 4:00 PM
patrickelectric committed R1034:932483a3fe6f: Add YawBar component (authored by patrickelectric).
Add YawBar component
Dec 23 2019, 4:00 PM
patrickelectric committed R1034:d917262a2bbf: gitignore: First commit (authored by patrickelectric).
gitignore: First commit
Dec 23 2019, 3:58 PM
patrickelectric committed R1034:95f021b06145: VirtualHorizon: Use Item to clip circle (authored by patrickelectric).
VirtualHorizon: Use Item to clip circle
Dec 23 2019, 2:46 AM
patrickelectric committed R1034:4a1657247877: PitchBar: Improve design (authored by patrickelectric).
PitchBar: Improve design
Dec 23 2019, 2:25 AM
patrickelectric committed R1034:6c829a0f08ed: mavlink: Plugin first version (authored by patrickelectric).
mavlink: Plugin first version
Dec 23 2019, 2:20 AM

Dec 22 2019

patrickelectric committed R1034:da07afdecf59: CMakeLists: Add KDEClangFormat (authored by patrickelectric).
CMakeLists: Add KDEClangFormat
Dec 22 2019, 9:20 PM
patrickelectric committed R1034:078ff5ec5058: Format code with new provided ECM clang-format target (authored by patrickelectric).
Format code with new provided ECM clang-format target
Dec 22 2019, 9:20 PM
patrickelectric committed R1034:a6d53089c5cf: main: Add author Patrick (authored by patrickelectric).
main: Add author Patrick
Dec 22 2019, 8:47 PM
patrickelectric committed R1034:490bd95ecbb2: AUTHORS: Add Patrick (authored by patrickelectric).
AUTHORS: Add Patrick
Dec 22 2019, 8:47 PM

Dec 20 2019

patrickelectric accepted D26130: Simplify return logic.
Dec 20 2019, 7:41 PM · Frameworks
patrickelectric added inline comments to D26131: Braces around for, break early..
Dec 20 2019, 7:40 PM · Frameworks

Dec 15 2019

patrickelectric committed R1034:ef3d2c9f1b89: FlighControls: Show roll and pitch indicator if vehicle is not flying (authored by patrickelectric).
FlighControls: Show roll and pitch indicator if vehicle is not flying
Dec 15 2019, 3:19 PM
patrickelectric committed R1034:5e83486ff5dd: FlighControls: Show altitude information when vehicle is not flying (authored by patrickelectric).
FlighControls: Show altitude information when vehicle is not flying
Dec 15 2019, 3:19 PM
patrickelectric committed R1034:e1797fc74b66: FlightControls: Send interface joystick signals when the vehicle is not flying (authored by patrickelectric).
FlightControls: Send interface joystick signals when the vehicle is not flying
Dec 15 2019, 3:00 PM
patrickelectric committed R1034:f1c42e1bf471: Gamepad: Improve gamepad signal logic (authored by patrickelectric).
Gamepad: Improve gamepad signal logic
Dec 15 2019, 3:00 PM
patrickelectric committed R1034:fd85177913f2: vehiclesupportpluginmodel: Look for plugins in relative path (authored by patrickelectric).
vehiclesupportpluginmodel: Look for plugins in relative path
Dec 15 2019, 2:57 PM
patrickelectric committed R1034:377adc5ac983: main: Add relative path for lib/qml to avoid unnecessary system installation (authored by patrickelectric).
main: Add relative path for lib/qml to avoid unnecessary system installation
Dec 15 2019, 2:57 PM

Sep 21 2019

patrickelectric committed R232:045684197b8f: Merge branch 'ReadMeUpdates' into 'master' (authored by patrickelectric).
Merge branch 'ReadMeUpdates' into 'master'
Sep 21 2019, 1:22 PM

Aug 28 2019

patrickelectric committed R1034:643fbeeecd61: main: Check if object is valid before accessing it (authored by patrickelectric).
main: Check if object is valid before accessing it
Aug 28 2019, 9:43 PM

Aug 25 2019

patrickelectric accepted D23455: Fix Crash on Tab Close.
Aug 25 2019, 9:03 PM · Atelier: General Development

Aug 17 2019

patrickelectric accepted D22927: Clean up detection of plugins..
Aug 17 2019, 1:07 PM · Atelier: AtCore

Aug 12 2019

patrickelectric committed R1034:01d71470196c: main: Update position without a connected device (authored by patrickelectric).
main: Update position without a connected device
Aug 12 2019, 5:45 AM

Aug 11 2019

patrickelectric committed R1034:46df5a68a886: main: Check if there is item before setWindow call for player (authored by patrickelectric).
main: Check if there is item before setWindow call for player
Aug 11 2019, 1:55 AM

Aug 5 2019

patrickelectric accepted D22931: Safer MachineInfo Key Reads.
Aug 5 2019, 11:52 AM · Atelier: AtCore
patrickelectric added inline comments to D22931: Safer MachineInfo Key Reads.
Aug 5 2019, 11:37 AM · Atelier: AtCore
patrickelectric accepted D22928: ProfileManager update deprecated method use.
Aug 5 2019, 11:18 AM · Atelier: AtCore
patrickelectric accepted D22939: Keep Dock titles for floating docks.
Aug 5 2019, 11:17 AM · Atelier: AtCore

Jul 18 2019

patrickelectric accepted D22383: For profileNames function uses Q_PROPERTY.
Jul 18 2019, 2:24 PM

Jul 10 2019

patrickelectric accepted D22334: Add method to return temperature pointer for qml.
Jul 10 2019, 4:01 PM
patrickelectric accepted D22331: Add method to store settings using QVariantMap.
Jul 10 2019, 4:00 PM
patrickelectric accepted D22347: Use newer Atcore::Temperature() return.
Jul 10 2019, 3:59 PM · Atelier

Jul 9 2019

patrickelectric requested changes to D22334: Add method to return temperature pointer for qml.
Jul 9 2019, 12:09 AM

Jun 29 2019

patrickelectric committed R353:01a099c481dd: kcalc_core: Fix initialization order (authored by patrickelectric).
kcalc_core: Fix initialization order
Jun 29 2019, 12:22 AM
patrickelectric closed D22007: kcalc_core: Fix initialization order.
Jun 29 2019, 12:22 AM

Jun 22 2019

patrickelectric added a reviewer for D22007: kcalc_core: Fix initialization order: tcanabrava.
Jun 22 2019, 4:36 PM
patrickelectric requested review of D22007: kcalc_core: Fix initialization order.
Jun 22 2019, 4:35 PM

Jun 16 2019

patrickelectric accepted D21847: Call AtCore::close when deconstructing the AtCoreInstanceWidget..
Jun 16 2019, 2:41 PM · Atelier: General Development
patrickelectric accepted D21846: Honor the Profiles AutoTemperatureReport Setting.
Jun 16 2019, 1:48 PM · Atelier: AtCore

Jun 15 2019

patrickelectric accepted D21768: Change tab name format to ProfileName @ Port..
Jun 15 2019, 12:01 PM · Atelier

Jun 3 2019

patrickelectric accepted D21567: Use QString::replace(QChar, QString) in place of QString::replace(QRegEx, QString) in LogWidget::appendSLog.
Jun 3 2019, 8:09 PM

May 21 2019

patrickelectric committed R319:8ba91ade5518: template: check order before access (authored by patrickelectric).
template: check order before access
May 21 2019, 9:24 PM
patrickelectric closed D21325: template: check order before access.
May 21 2019, 9:24 PM · Konsole
patrickelectric added a reviewer for D21325: template: check order before access: tcanabrava.
May 21 2019, 9:21 PM · Konsole
patrickelectric requested review of D21325: template: check order before access.
May 21 2019, 9:21 PM · Konsole
patrickelectric abandoned D21324: Move from Qt foreach to C++11 for loop.

Closed because of: https://phabricator.kde.org/D21123

May 21 2019, 9:17 PM · Konsole
patrickelectric accepted D18472: Create Bed Deform Object.
May 21 2019, 8:47 PM · Atelier: AtCore