patrickelectric (patrick j pereira)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2016, 2:30 AM (146 w, 2 d)
Availability
Available

Recent Activity

Sat, Jan 19

patrickelectric requested changes to D18350: Add support for auto temperature reporting.
Sat, Jan 19, 12:39 PM · Atelier: AtCore
patrickelectric accepted D18334: Add Support for M155 command.
Sat, Jan 19, 12:34 PM · Atelier: AtCore
patrickelectric accepted D18349: Ensure that when we request firmware info nothing else is in the queue.
Sat, Jan 19, 12:34 PM · Atelier: AtCore

Wed, Jan 16

patrickelectric requested changes to D18265: Retry for resend requests.
Wed, Jan 16, 1:16 PM · Atelier: AtCore

Tue, Jan 15

patrickelectric accepted D18268: Adjust our Timer Fix.
Tue, Jan 15, 10:11 PM · Atelier: AtCore
patrickelectric requested changes to D18268: Adjust our Timer Fix.
Tue, Jan 15, 10:08 PM · Atelier: AtCore
patrickelectric accepted D18268: Adjust our Timer Fix.
Tue, Jan 15, 10:08 PM · Atelier: AtCore
patrickelectric requested changes to D18268: Adjust our Timer Fix.
Tue, Jan 15, 9:12 PM · Atelier: AtCore

Fri, Dec 28

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@sandsmark Corrections done.

Fri, Dec 28, 3:54 PM · Konsole
patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

Add ui correction and remove tooltip

Fri, Dec 28, 3:50 PM · Konsole
patrickelectric added a comment to D17759: Correct includes.

@hindenburg corrections done.

Fri, Dec 28, 2:45 PM · Konsole
patrickelectric updated the diff for D17759: Correct includes.

Add missing QList

Fri, Dec 28, 2:44 PM · Konsole

Thu, Dec 27

patrickelectric accepted D17819: Reset post list on refresh.
Thu, Dec 27, 2:54 PM · Atelier

Mon, Dec 24

patrickelectric committed R232:69512133b160: mainwindow: Remove unused QSerialPort (authored by patrickelectric).
mainwindow: Remove unused QSerialPort
Mon, Dec 24, 1:38 PM
patrickelectric committed R232:ffd2d72867c3: Correct QtTest include (authored by patrickelectric).
Correct QtTest include
Mon, Dec 24, 1:38 PM
patrickelectric committed R232:9c464acff040: mainwindow: Remove unused QSerialPort (authored by patrickelectric).
mainwindow: Remove unused QSerialPort
Mon, Dec 24, 1:38 PM
patrickelectric closed D17761: mainwindow: Remove unused QSerialPort.
Mon, Dec 24, 1:38 PM
patrickelectric added a comment to D17759: Correct includes.

Are you using a tool to determine this?

Mon, Dec 24, 1:29 PM · Konsole

Sun, Dec 23

patrickelectric added reviewers for D17761: mainwindow: Remove unused QSerialPort: rizzitello, tcanabrava.
Sun, Dec 23, 1:52 PM
patrickelectric requested review of D17761: mainwindow: Remove unused QSerialPort.
Sun, Dec 23, 1:52 PM
patrickelectric added reviewers for D17759: Correct includes: tcanabrava, hindenburg.
Sun, Dec 23, 1:46 PM · Konsole
patrickelectric requested review of D17759: Correct includes.
Sun, Dec 23, 1:45 PM · Konsole

Dec 22 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@hindenburg can you take a look ?

Dec 22 2018, 2:20 PM · Konsole

Dec 18 2018

patrickelectric added a reviewer for D17513: drkonqi: Add blueprint: vonreth.
Dec 18 2018, 11:53 AM

Dec 17 2018

patrickelectric accepted D17106: Atelier Clazy-tidy.
Dec 17 2018, 1:30 PM · Atelier

Dec 16 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@hindenburg @tcanabrava this PR is ready to review.
There is a problem with visibility if the windows is in a "opening state" when it's starting.


This only happens if I call show() or setVisibility(true) when the application is not visible yet.
That's why we have oldVisibility variable in this PR.

Dec 16 2018, 9:56 PM · Konsole
patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

Try to make Tomaz happy

Dec 16 2018, 9:42 PM · Konsole

Dec 14 2018

patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

remove debug message

Dec 14 2018, 10:09 PM · Konsole
patrickelectric requested review of D17588: MainWindow: Add Frameless option.
Dec 14 2018, 10:08 PM · Konsole

Dec 13 2018

patrickelectric accepted D17520: Add options to set Temperature Timer.
Dec 13 2018, 4:46 PM · Atelier: AtCore
patrickelectric accepted D17566: Prevent Empty commands or messages from being sent.
Dec 13 2018, 4:42 PM · Atelier: AtCore
patrickelectric accepted D17541: Replace deprecated QChart calls..
Dec 13 2018, 11:35 AM · Atelier: AtCore
patrickelectric accepted D17540: Replace QTimer pointer with QTimer.
Dec 13 2018, 11:02 AM · Atelier: AtCore

Dec 12 2018

patrickelectric accepted D17519: Connect z_delta_dimensionSB to delta height.
Dec 12 2018, 1:37 AM · Atelier: General Development

Dec 11 2018

patrickelectric committed R877:482bda20650e: libbfd: Update lib to 2.31 (authored by patrickelectric).
libbfd: Update lib to 2.31
Dec 11 2018, 11:33 PM
patrickelectric closed D17512: libbfd: Update lib to 2.31.
Dec 11 2018, 11:33 PM
patrickelectric added a comment to D17512: libbfd: Update lib to 2.31.

@vonreth Corrections done.

Dec 11 2018, 10:20 PM
patrickelectric updated the diff for D17512: libbfd: Update lib to 2.31.

Add sha256 and libz

Dec 11 2018, 10:20 PM
patrickelectric added a comment to D17513: drkonqi: Add blueprint.

This is in WIP, right now is failing to build.

Dec 11 2018, 9:06 PM
patrickelectric requested review of D17513: drkonqi: Add blueprint.
Dec 11 2018, 9:05 PM
patrickelectric requested review of D17512: libbfd: Update lib to 2.31.
Dec 11 2018, 9:03 PM
patrickelectric requested changes to D17106: Atelier Clazy-tidy.
Dec 11 2018, 7:37 PM · Atelier

Nov 26 2018

patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

@rjvbb I got it to work here ! Took some time to figure out the problems with relative paths and KConfig, I am working to bundle kcrash in a .dmg :)

Nov 26 2018, 11:50 PM · Plasma
patrickelectric accepted D17146: Private Static consts.
Nov 26 2018, 11:16 PM · Atelier: AtCore

Nov 25 2018

patrickelectric requested changes to D17146: Private Static consts.
Nov 25 2018, 4:38 PM · Atelier: AtCore

Nov 24 2018

patrickelectric accepted D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 8:36 PM · Atelier
patrickelectric accepted D17142: Further Improve asktoSave.
Nov 24 2018, 8:36 PM · Atelier
patrickelectric accepted D17116: Improve the UI for MainWindow::askToSave.
Nov 24 2018, 5:56 PM · Atelier
patrickelectric accepted D17101: Make atcore Clazy tidy.
Nov 24 2018, 3:50 PM · Atelier: AtCore
patrickelectric requested changes to D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 3:48 PM · Atelier
patrickelectric added inline comments to D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 12:03 AM · Atelier

Nov 23 2018

patrickelectric requested changes to D17101: Make atcore Clazy tidy.
Nov 23 2018, 9:51 AM · Atelier: AtCore
patrickelectric accepted D16976: Temperature Object Improvements.
Nov 23 2018, 9:48 AM · Atelier: AtCore
patrickelectric requested changes to D17117: Prevent Canceled FileChooser from calling print.
Nov 23 2018, 9:48 AM · Atelier

Nov 22 2018

patrickelectric committed R871:4210953618ee: Debugger: Add missing include (authored by patrickelectric).
Debugger: Add missing include
Nov 22 2018, 8:34 PM
patrickelectric added a reviewer for D4929: DrKonqi : lldb and Mac support: davidedmundson.
Nov 22 2018, 8:11 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

a find_packge for KF5::WindowSystem is missing in the root CMakeLists file.

CMake Error at src/CMakeLists.txt:84 (add_executable):
  Target "drkonqi" links to target "KF5::WindowSystem" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Nov 22 2018, 8:02 PM · Plasma
patrickelectric committed R871:515425143cb3: debugger: DataLocation is deprecated, move to AppDataLocation (authored by patrickelectric).
debugger: DataLocation is deprecated, move to AppDataLocation
Nov 22 2018, 7:42 PM
patrickelectric closed D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
Nov 22 2018, 7:42 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

After taking a second look on it, I was able to merge the patch from the srcfolder and not from the repository root folder, weird..
Will do the tests here and now !

Nov 22 2018, 7:06 PM · Plasma
patrickelectric added inline comments to D17101: Make atcore Clazy tidy.
Nov 22 2018, 6:33 PM · Atelier: AtCore
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

Can you rebase it over the last master branch ?

Nov 22 2018, 5:07 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

I agree, with your points.
About the mac compatibility, kcrash and drkonqi (It was merged yesterday) are already in KDE-mac brew repository, looking forward for this to be accepted !
I'll try to do some tests with your patch here today.

Nov 22 2018, 4:57 PM · Plasma
patrickelectric requested changes to D17101: Make atcore Clazy tidy.

A great patch, thank you for cleaning this stuff.

Nov 22 2018, 2:23 PM · Atelier: AtCore
D4929: DrKonqi : lldb and Mac support now requires changes to proceed.

What is the actual state of this patch ?

Nov 22 2018, 2:00 PM · Plasma

Nov 19 2018

patrickelectric added a reviewer for D17024: debugger: DataLocation is deprecated, move to AppDataLocation: mart.
Nov 19 2018, 5:56 PM · Plasma
patrickelectric updated the diff for D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
  • debugger: Use c++11 for
Nov 19 2018, 5:49 PM · Plasma
patrickelectric updated the diff for D17024: debugger: DataLocation is deprecated, move to AppDataLocation.

Typo

Nov 19 2018, 5:46 PM · Plasma
patrickelectric requested review of D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
Nov 19 2018, 5:43 PM · Plasma

Nov 18 2018

patrickelectric requested changes to D16976: Temperature Object Improvements.
Nov 18 2018, 2:28 PM · Atelier: AtCore
patrickelectric accepted D16855: Adjust formula for lateral area's icon size.
Nov 18 2018, 12:28 PM · Atelier: General Development
patrickelectric accepted D16853: Remove Unaccelerated &s from LateralArea button text.
Nov 18 2018, 12:19 PM · Atelier: General Development
patrickelectric accepted D16854: Set the parent of the newly created instance in Atelier::newAtCoreInstance.
Nov 18 2018, 12:19 PM · Atelier: General Development

Oct 23 2018

patrickelectric accepted D14136: [WIP]Basic SD Write Support.
Oct 23 2018, 1:40 PM · Atelier: AtCore
patrickelectric accepted D16200: Use SerialLayer()->pushCommand in only in processQueue.
Oct 23 2018, 1:37 PM · Atelier: AtCore

Oct 15 2018

patrickelectric accepted D16205: Cleanup warning replace deprecated call to serialLayer.
Oct 15 2018, 11:35 PM · Atelier: General Development
patrickelectric added a comment to D16206: Use AtCore::pushedCommand.

Why this is in a different review if needs D16199 ?

Oct 15 2018, 11:34 PM · Atelier: General Development
patrickelectric requested changes to D16200: Use SerialLayer()->pushCommand in only in processQueue.
Oct 15 2018, 11:33 PM · Atelier: AtCore
patrickelectric added a comment to D16199: Make SerialLayer completely private.

What is the logic behind this change ?

Oct 15 2018, 11:32 PM · Atelier: AtCore

Oct 14 2018

patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 14 2018, 1:35 PM

Oct 13 2018

patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:39 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:09 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:07 PM
patrickelectric added a comment to D16181: Move final terminator in firmware plugin side.

How do we send commands now before connected to a firmware?

There is a generic function when a plugin is not loaded.

M115 has to be sent before any firmware connection.

Yes, you can use the default function like I said before.

Oct 13 2018, 9:25 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 8:10 PM
patrickelectric added a comment to D16181: Move final terminator in firmware plugin side.

Can you please "fix" the other plugins with \r\n so this does not break them

Oct 13 2018, 7:25 PM
patrickelectric accepted D15858: Warning Roundup.
Oct 13 2018, 7:23 PM · Atelier: General Development
patrickelectric accepted D16002: QUrl.toString() is not a valid local file.
Oct 13 2018, 6:59 PM
patrickelectric requested changes to D14136: [WIP]Basic SD Write Support.
Oct 13 2018, 6:36 PM · Atelier: AtCore
patrickelectric requested changes to D15858: Warning Roundup.
Oct 13 2018, 6:23 PM · Atelier: General Development
patrickelectric accepted D15861: Warning Clean.
Oct 13 2018, 6:03 PM · Atelier: AtCore
patrickelectric requested review of D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 5:53 PM
patrickelectric accepted D16180: Switch to C++11 scoped enums.

I'm ok with it.
Wait @tcanabrava and @rizzitello to review as well.

Oct 13 2018, 5:46 PM
patrickelectric added reviewers for D16180: Switch to C++11 scoped enums: rizzitello, tcanabrava.
Oct 13 2018, 5:45 PM

Oct 12 2018

patrickelectric updated subscribers of T9542: Atelier QML Interface - Discussion.
Oct 12 2018, 11:59 AM · Atelier, VDG
patrickelectric updated subscribers of T9542: Atelier QML Interface - Discussion.
Oct 12 2018, 11:42 AM · Atelier, VDG

Oct 10 2018

patrickelectric requested changes to D15858: Warning Roundup.
Oct 10 2018, 12:00 PM · Atelier: General Development
patrickelectric added inline comments to D15861: Warning Clean.
Oct 10 2018, 11:44 AM · Atelier: AtCore

Sep 30 2018

patrickelectric requested changes to D15861: Warning Clean.
Sep 30 2018, 3:55 PM · Atelier: AtCore

Sep 25 2018

patrickelectric accepted D15701: More Cleanup.
Sep 25 2018, 1:42 PM · Atelier: AtCore