patrickelectric (patrick j pereira)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2016, 2:30 AM (99 w, 23 h)
Availability
Available

Recent Activity

Today

patrickelectric requested changes to D10299: Begin support for Sd cards.
Sun, Feb 25, 12:06 AM

Yesterday

patrickelectric requested changes to D10787: Part 1.
Sat, Feb 24, 11:59 PM
patrickelectric requested changes to D10299: Begin support for Sd cards.
Sat, Feb 24, 5:13 PM
patrickelectric requested changes to D10788: Part 2 Clean up MainWindow.
Sat, Feb 24, 4:50 PM
patrickelectric requested changes to D10787: Part 1.
Sat, Feb 24, 4:20 PM
patrickelectric requested changes to D10789: Part 3 Feature: Open more that one file.
Sat, Feb 24, 3:52 PM
patrickelectric accepted D10648: Update Profiles Dialog.
Sat, Feb 24, 4:02 AM

Mon, Feb 19

patrickelectric added a comment to D10645: Solve T6826 +.

@rizzitello I'll ping the #Solid people about this.

it not so much solid does not work on windows , its more we were not deploying it .. and qt provides us with a system independent way to do this with objects we are already using

Mon, Feb 19, 12:22 AM

Sun, Feb 18

patrickelectric accepted D10647: Embed the kxmlgui rc file.
Sun, Feb 18, 11:46 PM
patrickelectric accepted D10645: Solve T6826 +.

Good patch, but before merging it, I would ask for two days after this message to talk with the Solid people about this issue.

Sun, Feb 18, 11:26 PM
patrickelectric added a comment to D10645: Solve T6826 +.

@rizzitello I'll ping the #Solid people about this.

Sun, Feb 18, 11:14 PM
patrickelectric requested changes to D10645: Solve T6826 +.
Sun, Feb 18, 11:07 PM
patrickelectric added a comment to T6826: Solid doesn't detect serial device on Windows.

isn't this a solid bug ?

Sun, Feb 18, 9:58 PM · Atelier
patrickelectric requested changes to D10645: Solve T6826 +.
Sun, Feb 18, 9:53 PM
patrickelectric added a comment to D10640: Refactor of main window.

A last thing, this patch have some trailing spaces !

Sun, Feb 18, 6:25 PM
patrickelectric added inline comments to D10640: Refactor of main window.
Sun, Feb 18, 6:20 PM
patrickelectric requested changes to D10640: Refactor of main window.
Sun, Feb 18, 6:20 PM

Tue, Feb 13

patrickelectric accepted D10436: Improve GCodeCommands.

Great job ! LGTM !

Tue, Feb 13, 3:13 PM
patrickelectric requested changes to D10436: Improve GCodeCommands.
Tue, Feb 13, 3:04 PM
patrickelectric added inline comments to D10436: Improve GCodeCommands.
Tue, Feb 13, 2:07 PM
patrickelectric added inline comments to D10436: Improve GCodeCommands.
Tue, Feb 13, 2:07 PM
patrickelectric added inline comments to D10436: Improve GCodeCommands.
Tue, Feb 13, 11:30 AM

Mon, Feb 12

patrickelectric requested changes to D10436: Improve GCodeCommands.
Mon, Feb 12, 2:55 PM

Sun, Feb 11

patrickelectric added a comment to D10436: Improve GCodeCommands.

Why we are doing tests with descriptions ?

For exactly the same reason we were checking the toString calls to have full test coverage.

Sun, Feb 11, 9:14 PM
patrickelectric requested changes to D10299: Begin support for Sd cards.
Sun, Feb 11, 6:20 PM
patrickelectric added a comment to D10436: Improve GCodeCommands.

Why we are doing tests with descriptions ?

Sun, Feb 11, 1:33 PM
patrickelectric accepted D10422: Uniform install paths.
Sun, Feb 11, 12:13 PM

Sat, Feb 10

patrickelectric added a comment to D10423: Extruder Control on Axis widget.

Future tooltips for any other rectify buttons may need to be tweaked when
we have them.

Sat, Feb 10, 8:07 PM
patrickelectric added inline comments to D10423: Extruder Control on Axis widget.
Sat, Feb 10, 7:52 PM
patrickelectric added inline comments to D10423: Extruder Control on Axis widget.
Sat, Feb 10, 5:27 PM
patrickelectric abandoned D10244: Change lambdas to use reference and not copy.

merged.

Sat, Feb 10, 4:42 PM

Fri, Feb 9

patrickelectric committed R232:1deedb1b3637: Change lambdas to use reference and not copy (authored by patrickelectric).
Change lambdas to use reference and not copy
Fri, Feb 9, 9:18 PM
patrickelectric added a comment to D10331: Cleanup Gcodecommands.

The best thing is to replace the gcode class to more generic classes. But
remove this abstraction is a kickback, we can use this class to provide a
lot of important information to the graphic interface, gcode editor, gcode
information and etc.. besides that, isn't hard to maintain what is standard
protocol, only small things change between this main class.
If the gcode class isn't helpfully we need to reformulate it and no remove.

Fri, Feb 9, 1:49 AM
patrickelectric added a comment to D10331: Cleanup Gcodecommands.
  • Remove Use of gcodecommands
  • Remove GcodeCommands

why ??

  • Less code to maintain
  • Lots of code for little gain
  • Code is slightly more readabe in atcore with only QStringLiteral("G28") instead of GCode::toCommand(GCode::G28));
  • GCode::toString was used 5 times. Strings returned by this might not be accurate for your firmware. This class contained lots of strings for the translators that we never used. Maybe this could be used in atelier to help users make gcodes ? ?
Fri, Feb 9, 1:30 AM

Thu, Feb 8

patrickelectric added a comment to D10331: Cleanup Gcodecommands.
  • Remove Use of gcodecommands
  • Remove GcodeCommands
Thu, Feb 8, 11:11 PM
patrickelectric accepted D10330: Safer Disconnect from printer.
Thu, Feb 8, 12:23 PM

Wed, Feb 7

patrickelectric added inline comments to D10330: Safer Disconnect from printer.
Wed, Feb 7, 6:40 PM
patrickelectric requested changes to D10331: Cleanup Gcodecommands.
Wed, Feb 7, 6:38 PM
patrickelectric abandoned D7691: TimerJobDelegate: Correct icon name.
Wed, Feb 7, 6:36 PM
patrickelectric requested review of D10244: Change lambdas to use reference and not copy.

we can merge this ?

Wed, Feb 7, 6:35 PM

Sun, Feb 4

patrickelectric requested changes to D10299: Begin support for Sd cards.
Sun, Feb 4, 5:59 PM
patrickelectric requested changes to D10299: Begin support for Sd cards.
Sun, Feb 4, 4:18 PM

Fri, Feb 2

patrickelectric updated the diff for D10244: Change lambdas to use reference and not copy.

Use this and not ref

Fri, Feb 2, 4:34 PM
patrickelectric added reviewers for D10244: Change lambdas to use reference and not copy: tcanabrava, rizzitello, laysrodrigues.
Fri, Feb 2, 12:46 AM

Jan 20 2018

patrickelectric added a comment to D9934: Atcore: Add more qml calls.

@rizzitello I think that this need more love from our part.

Jan 20 2018, 11:57 PM
patrickelectric committed R232:269dde58095f: Firmware: Add default validateCommand Firmware: Add default translate binary… (authored by patrickelectric).
Firmware: Add default validateCommand Firmware: Add default translate binary…
Jan 20 2018, 11:55 PM
patrickelectric committed R232:161f47e55033: Merge branch 'arcpatch-D9935' (authored by patrickelectric).
Merge branch 'arcpatch-D9935'
Jan 20 2018, 11:55 PM
patrickelectric closed D9935: Firmware: Add default validateCommand.
Jan 20 2018, 11:55 PM

Jan 17 2018

patrickelectric updated the diff for D9935: Firmware: Add default validateCommand.
  • Firmware: Add default validateCommand
  • Firmware: Add default translate
  • binary compatibility ftw !
Jan 17 2018, 12:34 AM
patrickelectric added inline comments to D9934: Atcore: Add more qml calls.
Jan 17 2018, 12:27 AM
patrickelectric updated the diff for D9934: Atcore: Add more qml calls.

Sith comments

Jan 17 2018, 12:26 AM
patrickelectric abandoned D9936: Atcore: Add more qml calls.
Jan 17 2018, 12:26 AM
patrickelectric updated the diff for D9935: Firmware: Add default validateCommand.
  • Firmware: Add default translate
Jan 17 2018, 12:20 AM
patrickelectric added reviewers for D9935: Firmware: Add default validateCommand: rizzitello, laysrodrigues, tcanabrava.
Jan 17 2018, 12:15 AM
patrickelectric added inline comments to D9934: Atcore: Add more qml calls.
Jan 17 2018, 12:12 AM

Jan 16 2018

patrickelectric added reviewers for D9934: Atcore: Add more qml calls: rizzitello, laysrodrigues, tcanabrava.
Jan 16 2018, 11:55 PM

Jan 14 2018

patrickelectric created T7749: remote communication.
Jan 14 2018, 2:40 PM · Atelier: AtCore

Jan 7 2018

patrickelectric accepted D9709: Move Document building to make doc.
Jan 7 2018, 2:07 PM

Nov 27 2017

patrickelectric updated the diff for D9007: Do not change to printing states if disconnected.
  • atcore: Only print if connected
Nov 27 2017, 11:25 PM
patrickelectric updated the diff for D9007: Do not change to printing states if disconnected.
  • Do not send serial commands if serial isn't open
  • atcore: Only print if connected
Nov 27 2017, 11:16 PM
patrickelectric added a comment to D9007: Do not change to printing states if disconnected.

Update.

Nov 27 2017, 10:21 PM
patrickelectric updated the diff for D9007: Do not change to printing states if disconnected.
  • Do not change to printing states if disconnected
  • Do not send serial commands if serial isn't open
Nov 27 2017, 10:20 PM

Nov 26 2017

patrickelectric accepted D8680: Generate DMG with travis as well.
Nov 26 2017, 7:48 PM
patrickelectric added reviewers for D9007: Do not change to printing states if disconnected: rizzitello, tcanabrava, laysrodrigues.
Nov 26 2017, 7:46 PM
patrickelectric created D9007: Do not change to printing states if disconnected.
Nov 26 2017, 7:43 PM
patrickelectric accepted D8973: Clean up more of the codebase.

Merge asap

Nov 26 2017, 6:51 PM

Nov 23 2017

patrickelectric accepted D8969: Basic support for disabling motors.
Nov 23 2017, 5:04 PM
patrickelectric added inline comments to D8969: Basic support for disabling motors.
Nov 23 2017, 4:33 PM
patrickelectric requested changes to D8969: Basic support for disabling motors.
Nov 23 2017, 4:02 PM
patrickelectric added a comment to D8969: Basic support for disabling motors.

should this be M18, no ?

Nov 23 2017, 3:47 PM

Nov 17 2017

patrickelectric added a comment to D8717: New Widget: Video Monitor.

This is working with udp h264 encode ?

Nov 17 2017, 1:11 PM

Nov 13 2017

patrickelectric requested changes to D8680: Generate DMG with travis as well.

Maybe we can add a message output to a bot or something like.

Nov 13 2017, 6:13 PM

Nov 12 2017

patrickelectric requested changes to D8680: Generate DMG with travis as well.
Nov 12 2017, 6:45 PM

Nov 6 2017

patrickelectric requested changes to D8680: Generate DMG with travis as well.
Nov 6 2017, 2:35 PM

Oct 31 2017

patrickelectric committed R232:be4283b99aef: Fix building from non git checkout, update version to reflect patch (authored by rizzitello).
Fix building from non git checkout, update version to reflect patch
Oct 31 2017, 1:20 PM

Oct 24 2017

patrickelectric accepted D8452: Small fixes.
Oct 24 2017, 9:48 PM · Atelier: AtCore

Oct 20 2017

patrickelectric added a comment to D8370: Prepare for AtCore beta release.

Maybe would be nice to have the commit id in help/about or something like this in testclient.

Oct 20 2017, 11:41 AM · Atelier: AtCore

Oct 15 2017

patrickelectric added a comment to T2760: Create a docker image to Cantor.

Oct 15 2017, 4:20 PM · Cantor
patrickelectric added a comment to T2760: Create a docker image to Cantor.

@filipesaraiva Sorry I never responded to this! It's working without problem. This docker is a script over the kdesrc-build, it will run anything that kdesrc-build is able to compile :)

Oct 15 2017, 4:00 PM · Cantor

Oct 13 2017

patrickelectric accepted D8200: Fix T6906.
Oct 13 2017, 4:38 PM · Atelier: AtCore
patrickelectric abandoned D6497: First commit of 3D viewer.
Oct 13 2017, 4:35 PM

Oct 10 2017

patrickelectric requested changes to D8200: Fix T6906.
Oct 10 2017, 2:41 PM · Atelier: AtCore

Sep 24 2017

patrickelectric accepted D7961: Let clients know of new serialPorts.

Good.

Sep 24 2017, 3:14 PM
patrickelectric requested changes to D7961: Let clients know of new serialPorts.
Sep 24 2017, 2:59 PM
patrickelectric added inline comments to D7961: Let clients know of new serialPorts.
Sep 24 2017, 2:13 PM
patrickelectric requested changes to D7961: Let clients know of new serialPorts.
Sep 24 2017, 2:06 PM
patrickelectric requested changes to D7961: Let clients know of new serialPorts.

You need to check your else logic.

Sep 24 2017, 1:55 PM
patrickelectric requested changes to D7961: Let clients know of new serialPorts.
Sep 24 2017, 1:00 PM

Sep 23 2017

patrickelectric accepted D7759: Prep for use with QML.
Sep 23 2017, 2:48 PM · Atelier: AtCore
patrickelectric requested changes to D7759: Prep for use with QML.
Sep 23 2017, 2:23 PM · Atelier: AtCore

Sep 17 2017

patrickelectric added a comment to D6103: scan the whole install folder for qml dependencies.

I don't know if is related to this commit, but when compiling my application via kirigami with make create-* and uploading to my cellphone, a white screen appears.
Using adb to debug with logcat, this error took my attention: libatcore-gui.so: qrc:///main.qml:2 ((null)): qrc:///main.qml:2:1: module "QtQuick.Controls" plugin "qtquickcontrols2plugin" not found, and than searching about it, this site took my attention.
I don't know if it's a bug or related to this PR.

Sep 17 2017, 6:18 PM · Build System, Frameworks

Sep 10 2017

patrickelectric accepted D7759: Prep for use with QML.
Sep 10 2017, 2:43 PM · Atelier: AtCore

Sep 7 2017

patrickelectric accepted D7730: Better Grbl.
Sep 7 2017, 11:45 PM

Sep 5 2017

patrickelectric updated the diff for D7691: TimerJobDelegate: Correct icon name.
Sep 5 2017, 2:42 AM
patrickelectric updated the diff for D7691: TimerJobDelegate: Correct icon name.
Sep 5 2017, 1:08 AM
patrickelectric updated the diff for D7691: TimerJobDelegate: Correct icon name.
Sep 5 2017, 1:07 AM

Sep 4 2017

patrickelectric created D7691: TimerJobDelegate: Correct icon name.
Sep 4 2017, 7:26 PM
patrickelectric committed R169:0ed1256a5ce5: Update android build information (authored by patrickelectric).
Update android build information
Sep 4 2017, 11:28 AM
patrickelectric committed R169:0cab988351ff: Correct text style (authored by patrickelectric).
Correct text style
Sep 4 2017, 11:28 AM
patrickelectric committed R169:26eac95eca74: Update deploy information (authored by patrickelectric).
Update deploy information
Sep 4 2017, 11:28 AM