patrickelectric (patrick j pereira)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2016, 2:30 AM (234 w, 9 h)
Availability
Available

Recent Activity

May 11 2020

patrickelectric accepted D29502: kwidgetsaddons: Add a named colors support in KColorCombo..
May 11 2020, 12:43 PM · Frameworks
patrickelectric added inline comments to D29502: kwidgetsaddons: Add a named colors support in KColorCombo..
May 11 2020, 12:42 PM · Frameworks

May 10 2020

patrickelectric added a comment to D29502: kwidgetsaddons: Add a named colors support in KColorCombo..

Just some small tips.

May 10 2020, 10:33 PM · Frameworks

May 7 2020

patrickelectric added a comment to D29511: Label: Add ping-pong logic.

Thanks @davidedmundson and @ognarb, I was able to replicate the issue, I'll think a bit more in my approach

May 7 2020, 4:09 PM · Frameworks
patrickelectric added a comment to D29511: Label: Add ping-pong logic.

@cblack Yeah, I was uploading it :)
Output:

May 7 2020, 3:48 PM · Frameworks
patrickelectric updated the diff for D29511: Label: Add ping-pong logic.

Update style

May 7 2020, 3:46 PM · Frameworks
patrickelectric requested review of D29511: Label: Add ping-pong logic.
May 7 2020, 3:43 PM · Frameworks

May 4 2020

patrickelectric committed R163:2f03914112ac: main: Improve anchor code (authored by patrickelectric).
main: Improve anchor code
May 4 2020, 6:33 PM

Apr 28 2020

patrickelectric closed D29203: kirigami.pri: Add missing includes.

Merged.

Apr 28 2020, 4:45 PM · Kirigami
patrickelectric committed R169:77eab7266d48: kirigami.pri: Add missing includes (authored by patrickelectric).
kirigami.pri: Add missing includes
Apr 28 2020, 4:45 PM
patrickelectric committed R163:4490d9bef2e0: xdgdatadirs: Use clang-format (authored by patrickelectric).
xdgdatadirs: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:56d58c05d0fd: iuicontroller: Use clang-format (authored by patrickelectric).
iuicontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:800d634ab65a: isoundcontroller: Use clang-format (authored by patrickelectric).
isoundcontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:0444e9730b9d: iplugincontroller: Use clang-format (authored by patrickelectric).
iplugincontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:04d6d0882f75: iplugin: Use clang-format (authored by patrickelectric).
iplugin: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:743eec3dae6a: iexercisecontroller: Use clang-format (authored by patrickelectric).
iexercisecontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:babf6f87b53b: icore: Use clang-format (authored by patrickelectric).
icore: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:cc71726082bf: uicontroller: Use clang-format (authored by patrickelectric).
uicontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:5d58fef9f775: main: Use clang-format (authored by patrickelectric).
main: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:5560c9ff45c3: plugincontroller: Use clang-format (authored by patrickelectric).
plugincontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:f5b5c9472edb: core: Use clang-format (authored by patrickelectric).
core: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:b5623855bbff: exercisecontroller: Use clang-format (authored by patrickelectric).
exercisecontroller: Use clang-format
Apr 28 2020, 2:49 PM
patrickelectric committed R163:d88a43d38725: CMakeLists: Add KDEClangFormat (authored by patrickelectric).
CMakeLists: Add KDEClangFormat
Apr 28 2020, 2:49 PM

Apr 26 2020

patrickelectric committed R163:3c1707bcf6cc: fluidsynthsoundcontroller: Fix includes (authored by patrickelectric).
fluidsynthsoundcontroller: Fix includes
Apr 26 2020, 10:09 PM
patrickelectric committed R163:efc34e6238ea: Merge branch 'remove_phabricator_support' into 'master' (authored by patrickelectric).
Merge branch 'remove_phabricator_support' into 'master'
Apr 26 2020, 8:21 PM
patrickelectric committed R163:3bf1e2200970: fluidsynthsoundcontroller: Try XDG_DATA_DIRS in macos (authored by patrickelectric).
fluidsynthsoundcontroller: Try XDG_DATA_DIRS in macos
Apr 26 2020, 8:20 PM
patrickelectric committed R163:bf9cf6a7559a: Merge branch 'fix_mac_load_thing' into 'master' (authored by patrickelectric).
Merge branch 'fix_mac_load_thing' into 'master'
Apr 26 2020, 8:20 PM
patrickelectric committed R163:fdb95e3d75c2: exercisecontroller: Search for exercises in XDG_DATA_DIRS for macos (authored by patrickelectric).
exercisecontroller: Search for exercises in XDG_DATA_DIRS for macos
Apr 26 2020, 8:20 PM
patrickelectric committed R163:550d607667d7: Add utils namespace (authored by patrickelectric).
Add utils namespace
Apr 26 2020, 8:20 PM
patrickelectric closed D29202: Remove unused QtConcurrent from colorutils.
Apr 26 2020, 7:33 PM · Kirigami
patrickelectric committed R169:061a750068a4: Remove unused QtConcurrent from colorutils (authored by patrickelectric).
Remove unused QtConcurrent from colorutils
Apr 26 2020, 7:33 PM
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.

@apol done.

Apr 26 2020, 5:02 PM · Kirigami
patrickelectric updated the diff for D29202: Remove unused QtConcurrent from colorutils.
Apr 26 2020, 5:02 PM · Kirigami
patrickelectric updated the diff for D29202: Remove unused QtConcurrent from colorutils.
Apr 26 2020, 5:00 PM · Kirigami
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.
In D29202#657700, @apol wrote:

Then remove it from CMakeLists.txt as well?

Can you point what exactly should be removed ?

Apr 26 2020, 4:54 PM · Kirigami
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.
In D29202#657700, @apol wrote:

Then remove it from CMakeLists.txt as well?

Apr 26 2020, 4:41 PM · Kirigami
patrickelectric added a comment to D29202: Remove unused QtConcurrent from colorutils.

It fails to build when QtConcurrent can't be found.

Apr 26 2020, 2:52 PM · Kirigami
patrickelectric requested review of D29203: kirigami.pri: Add missing includes.
Apr 26 2020, 2:16 PM · Kirigami
patrickelectric requested review of D29202: Remove unused QtConcurrent from colorutils.
Apr 26 2020, 2:15 PM · Kirigami
patrickelectric abandoned D29114: Fix search for GeneralUser soundfonts for MacOS.

Moved to https://invent.kde.org/kde/minuet/-/merge_requests/7

Apr 26 2020, 12:28 AM · KDE Edu
patrickelectric abandoned D29128: Search for exercises in XDG_DATA_DIRS for macos.

Moved to https://invent.kde.org/kde/minuet/-/merge_requests/7

Apr 26 2020, 12:28 AM · Minuet, KDE Edu
patrickelectric committed R1034:06e0dc537b53: NavigationMap: Add visual front, back and rotation for uav (authored by patrickelectric).
NavigationMap: Add visual front, back and rotation for uav
Apr 26 2020, 12:28 AM

Apr 25 2020

patrickelectric closed D29078: Add missing overrides.

Merged.

Apr 25 2020, 4:58 PM · KDE Edu
patrickelectric committed R163:c6b7bdba2c22: Add missing overrides (authored by patrickelectric).
Add missing overrides
Apr 25 2020, 4:58 PM
patrickelectric closed D29077: Fix MacOS build for missing bundle.

Merged.

Apr 25 2020, 4:45 PM · KDE Edu
patrickelectric committed R1034:6ad54c904bc2: settings: Move to lib (authored by patrickelectric).
settings: Move to lib
Apr 25 2020, 3:32 PM
patrickelectric committed R163:a557c69488f2: app: Add missing BUNDLE for MACOSX (authored by patrickelectric).
app: Add missing BUNDLE for MACOSX
Apr 25 2020, 2:42 PM
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.

@apol @pino This fix the problem, RUNTIME DESTINATION is already specified by KDE_INSTALL_TARGETS_DEFAULT_ARGS, that's why I was getting the error message.

Apr 25 2020, 12:48 AM · KDE Edu
patrickelectric updated the diff for D29077: Fix MacOS build for missing bundle.
Apr 25 2020, 12:47 AM · KDE Edu
patrickelectric updated the diff for D29077: Fix MacOS build for missing bundle.
Apr 25 2020, 12:24 AM · KDE Edu

Apr 24 2020

patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.

Hm, Ok, I'll debug it later so.

Apr 24 2020, 1:01 PM · KDE Edu
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.

@pino if you can, please the history if of this patch to see my first and working version.
https://phabricator.kde.org/D29077?id=80827

Apr 24 2020, 12:54 PM · KDE Edu
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.

@pino It was a simple if(apple) message(potato) endif() to test if apple was true and the correct variable was by kdeinstalldir, with everything stashed and only this patch applied:

CMake Error at src/app/CMakeLists.txt:84 (install):
  install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
  target "minuet".
Apr 24 2020, 12:52 PM · KDE Edu
patrickelectric updated the diff for D29077: Fix MacOS build for missing bundle.
Apr 24 2020, 12:37 PM · KDE Edu
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.

@apol doing so results in

CMake Error at src/app/CMakeLists.txt:87 (install):
  install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
  target "minuet".
Apr 24 2020, 12:36 PM · KDE Edu

Apr 23 2020

patrickelectric committed R1034:cf7f99c6a3cc: wip (authored by patrickelectric).
wip
Apr 23 2020, 6:19 PM
patrickelectric requested review of D29128: Search for exercises in XDG_DATA_DIRS for macos.
Apr 23 2020, 10:19 AM · Minuet, KDE Edu
patrickelectric requested review of D29114: Fix search for GeneralUser soundfonts for MacOS.
Apr 23 2020, 3:08 AM · KDE Edu
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.

@apol is that what you mean ?

Apr 23 2020, 1:15 AM · KDE Edu
patrickelectric updated the diff for D29077: Fix MacOS build for missing bundle.
Apr 23 2020, 1:15 AM · KDE Edu

Apr 22 2020

patrickelectric requested review of D29078: Add missing overrides.
Apr 22 2020, 1:41 AM · KDE Edu
patrickelectric requested review of D29077: Fix MacOS build for missing bundle.
Apr 22 2020, 1:35 AM · KDE Edu

Apr 7 2020

patrickelectric committed R361:da8c799e5daf: Add a .arcconfig file to use arcanist (authored by araujoluis).
Add a .arcconfig file to use arcanist
Apr 7 2020, 10:05 PM
patrickelectric committed R361:32fbeb89bdbf: Add a .arcconfig file to use arcanist (authored by araujoluis).
Add a .arcconfig file to use arcanist
Apr 7 2020, 10:05 PM
patrickelectric closed D28607: Add a .arcconfig file to use arcanist.
Apr 7 2020, 10:05 PM
patrickelectric added a comment to D28607: Add a .arcconfig file to use arcanist.

@dakon It's @araujoluis first MR and we are still here in phabricator, so I don't see why not merge if we are not in gitlab yet.

Apr 7 2020, 9:18 PM

Apr 6 2020

patrickelectric accepted D28607: Add a .arcconfig file to use arcanist.
Apr 6 2020, 1:01 PM
patrickelectric committed R954:e94fb776a2a7: planet: Add patrickelectric back (authored by patrickelectric).
planet: Add patrickelectric back
Apr 6 2020, 12:50 AM

Mar 9 2020

patrickelectric committed R1034:f243a145052b: README: Add badges (authored by patrickelectric).
README: Add badges
Mar 9 2020, 1:22 AM

Mar 8 2020

patrickelectric added a comment to D27712: Fix kirogi compilation on binary-factory.

Hi @jjazeix this did fix the android build, but now it's failing with libQtZeroConf, and after your fix with:

qrc:/FlightControls.qml:29 module "org.kde.kirogi.video" is not installed
Mar 8 2020, 5:49 PM

Mar 4 2020

patrickelectric committed R1034:2ffd8dec0319: parrotconnection: Use default (authored by patrickelectric).
parrotconnection: Use default
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:d5a16d5e98b5: parrotprotocol: Use default (authored by patrickelectric).
parrotprotocol: Use default
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:7649533e0c3a: vehiclesupportpluginmodel: Remove else before return (authored by patrickelectric).
vehiclesupportpluginmodel: Remove else before return
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:df34989c061d: vehiclesupportplugin: Set constructor as explicit (authored by patrickelectric).
vehiclesupportplugin: Set constructor as explicit
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:548b4804b8e9: main: Use static member of QApplication (authored by patrickelectric).
main: Use static member of QApplication
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:7ec1cba1405d: positionsource: Define setPositionSourceError as static (authored by patrickelectric).
positionsource: Define setPositionSourceError as static
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:dc919403733d: vehiclesupportplugin: Use default (authored by patrickelectric).
vehiclesupportplugin: Use default
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:b957bdcaa974: abstractvehicle: Set constructor as explicit (authored by patrickelectric).
abstractvehicle: Set constructor as explicit
Mar 4 2020, 12:06 PM
patrickelectric committed R1034:ef6322d72dfa: gstreamerintegration: Move processPipelineMessage to static function (authored by patrickelectric).
gstreamerintegration: Move processPipelineMessage to static function
Mar 4 2020, 12:06 PM

Mar 3 2020

patrickelectric committed R1034:9f073faa82c3: FlightControls: Fix YawBar anchors (authored by patrickelectric).
FlightControls: Fix YawBar anchors
Mar 3 2020, 9:58 PM
patrickelectric committed R1034:ecbc741ad4cc: CMakeLists: Move to C++17 (authored by patrickelectric).
CMakeLists: Move to C++17
Mar 3 2020, 5:47 PM
patrickelectric committed R1034:9935caa6a3a0: mavlinkvehicle: Use new generic sendMessage (authored by patrickelectric).
mavlinkvehicle: Use new generic sendMessage
Mar 3 2020, 5:47 PM
patrickelectric committed R1034:392fe6633982: mavlinkconnection: Use generic type in sendMessage (authored by patrickelectric).
mavlinkconnection: Use generic type in sendMessage
Mar 3 2020, 5:47 PM
patrickelectric committed R1034:b293a1174fe4: FlightControls: Check if vehicle exist before updating joystick values (authored by patrickelectric).
FlightControls: Check if vehicle exist before updating joystick values
Mar 3 2020, 5:03 PM
patrickelectric committed R1034:43a77e8e32bf: FlightControls: Use new setNewStickPosition over duplicated code (authored by patrickelectric).
FlightControls: Use new setNewStickPosition over duplicated code
Mar 3 2020, 5:03 PM
patrickelectric committed R1034:1074651646b4: gstreamerintegration: Does not force aspect ratio (authored by patrickelectric).
gstreamerintegration: Does not force aspect ratio
Mar 3 2020, 4:53 PM
patrickelectric committed R1034:b75836af6456: Settings: Add Video section with stretchVideo settings (authored by patrickelectric).
Settings: Add Video section with stretchVideo settings
Mar 3 2020, 4:53 PM
patrickelectric committed R1034:37c3944b936c: kirogi: Add stretchVideo settings (authored by patrickelectric).
kirogi: Add stretchVideo settings
Mar 3 2020, 4:53 PM
patrickelectric committed R1034:c0cccac10ed3: FlightControls: Use stretchVideo settings (authored by patrickelectric).
FlightControls: Use stretchVideo settings
Mar 3 2020, 4:53 PM

Feb 24 2020

patrickelectric committed R1034:31a3b5338133: NavigatorMap: Fix tooltip (authored by patrickelectric).
NavigatorMap: Fix tooltip
Feb 24 2020, 10:46 AM
patrickelectric committed R1034:b202be9effd7: FlightControls: Fix tooltip (authored by patrickelectric).
FlightControls: Fix tooltip
Feb 24 2020, 10:46 AM

Feb 21 2020

patrickelectric committed R1034:a391fce9e259: README: Move from webp to png (authored by patrickelectric).
README: Move from webp to png
Feb 21 2020, 7:16 PM
patrickelectric committed R1035:1b6eb98ffb59: assets: imgs: Add kirogi.png (authored by patrickelectric).
assets: imgs: Add kirogi.png
Feb 21 2020, 7:10 PM
patrickelectric committed R1035:47b4160cf4b4: assets: imgs: Add goose.png (authored by patrickelectric).
assets: imgs: Add goose.png
Feb 21 2020, 7:10 PM
patrickelectric committed R1034:39ce18fc2cba: vehiclesupportpluginmodel: Fix private q shadow (authored by patrickelectric).
vehiclesupportpluginmodel: Fix private q shadow
Feb 21 2020, 5:27 PM
patrickelectric committed R1034:2e659d5b6798: abstractvehicle: Fix private q shadow (authored by patrickelectric).
abstractvehicle: Fix private q shadow
Feb 21 2020, 5:27 PM
patrickelectric committed R1034:eb0b8335cdba: parrot: Add more warning flags (authored by patrickelectric).
parrot: Add more warning flags
Feb 21 2020, 5:27 PM
patrickelectric committed R1034:a48a0274e267: ryzetello: Add more warning flags (authored by patrickelectric).
ryzetello: Add more warning flags
Feb 21 2020, 5:27 PM
patrickelectric committed R1034:a48eac4f09b6: mavlink: Add more warning flags (authored by patrickelectric).
mavlink: Add more warning flags
Feb 21 2020, 5:27 PM
patrickelectric committed R1034:3a4e784a189b: vehicleparameters: Add more warning flags (authored by patrickelectric).
vehicleparameters: Add more warning flags
Feb 21 2020, 5:27 PM