patrickelectric (patrick j pereira)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2016, 2:30 AM (119 w, 5 d)
Availability
Available

Recent Activity

Tue, Jul 17

patrickelectric requested changes to D13978: Atelier Aware if a file is modified on close/ print.
Tue, Jul 17, 11:10 AM · Atelier: General Development

Sun, Jul 15

patrickelectric added a comment to D14136: Basic SD Write Support.

Are this patch rebased on master ? It appears to be not.

Sun, Jul 15, 9:16 PM · Atelier: AtCore

Thu, Jun 28

patrickelectric committed R232:16d93b730612: widgets: Fix potential detach of non-const Qt containers (authored by patrickelectric).
widgets: Fix potential detach of non-const Qt containers
Thu, Jun 28, 3:16 PM
patrickelectric committed R232:86cd40c2b992: core: Fix potential detach of non-const Qt containers (authored by patrickelectric).
core: Fix potential detach of non-const Qt containers
Thu, Jun 28, 3:16 PM
patrickelectric committed R232:369f610d8b30: widgets: Fix potential detach of non-const Qt containers (authored by patrickelectric).
widgets: Fix potential detach of non-const Qt containers
Thu, Jun 28, 3:16 PM
patrickelectric closed D13780: widgets: Fix potential detach of non-const Qt containers.
Thu, Jun 28, 3:16 PM
patrickelectric requested changes to D13576: Allow non reset on connect.
Thu, Jun 28, 12:49 PM · Atelier: AtCore
patrickelectric added a comment to D13780: widgets: Fix potential detach of non-const Qt containers.

They are const variables inside the scope.

Thu, Jun 28, 12:40 PM
patrickelectric added a comment to D13780: widgets: Fix potential detach of non-const Qt containers.

Why ? and why only for these two

Thu, Jun 28, 12:19 PM
patrickelectric committed R232:21c9b798d6c7: core: Correct emit signal call (authored by patrickelectric).
core: Correct emit signal call
Thu, Jun 28, 12:18 PM
patrickelectric committed R232:cb847fabb2d2: plugins: Add missing emit (authored by patrickelectric).
plugins: Add missing emit
Thu, Jun 28, 12:18 PM
patrickelectric committed R232:c34e80fcd6cd: widgets: Correct emit signal call (authored by patrickelectric).
widgets: Correct emit signal call
Thu, Jun 28, 12:18 PM
patrickelectric committed R232:554c14b0505f: core: Correct emit signal call (authored by patrickelectric).
core: Correct emit signal call
Thu, Jun 28, 12:18 PM
patrickelectric closed D13778: core: Correct emit signal call.
Thu, Jun 28, 12:18 PM
patrickelectric committed R232:ac9fa0b68377: core: Use mult args QString in arg (authored by patrickelectric).
core: Use mult args QString in arg
Thu, Jun 28, 12:17 PM
patrickelectric committed R232:0807155091d1: testclient: Use mult args QString in arg (authored by patrickelectric).
testclient: Use mult args QString in arg
Thu, Jun 28, 12:17 PM
patrickelectric committed R232:802f5162bc7d: core: Use mult args QString in arg (authored by patrickelectric).
core: Use mult args QString in arg
Thu, Jun 28, 12:17 PM
patrickelectric closed D13779: core: Use mult args QString in arg.
Thu, Jun 28, 12:17 PM
patrickelectric added reviewers for D13780: widgets: Fix potential detach of non-const Qt containers: tcanabrava, rizzitello, laysrodrigues.
Thu, Jun 28, 12:11 PM
patrickelectric requested review of D13780: widgets: Fix potential detach of non-const Qt containers.
Thu, Jun 28, 12:10 PM
patrickelectric updated the diff for D13778: core: Correct emit signal call.
  • plugins: Add missing emit
Thu, Jun 28, 12:08 PM
patrickelectric updated the diff for D13779: core: Use mult args QString in arg.
  • testclient: Use mult args QString in arg
Thu, Jun 28, 12:06 PM
patrickelectric added reviewers for D13779: core: Use mult args QString in arg: rizzitello, tcanabrava, laysrodrigues.
Thu, Jun 28, 11:56 AM
patrickelectric requested review of D13779: core: Use mult args QString in arg.
Thu, Jun 28, 11:55 AM
patrickelectric added reviewers for D13778: core: Correct emit signal call: laysrodrigues, tcanabrava, rizzitello.
Thu, Jun 28, 11:50 AM
patrickelectric requested review of D13778: core: Correct emit signal call.
Thu, Jun 28, 11:47 AM

Thu, Jun 21

patrickelectric requested changes to D13258: Add Welcome Screen.
Thu, Jun 21, 2:51 AM

Jun 17 2018

patrickelectric added inline comments to D13561: Scale icons in laterial area based on dpi.
Jun 17 2018, 11:41 AM · Atelier: General Development

Jun 2 2018

patrickelectric accepted D13282: update for newest AtCore.
Jun 2 2018, 1:03 PM · Atelier: General Development
patrickelectric accepted D13281: More 2.0 cleanups.

I think that everything is ok, but I would prefer others review to see if this PR is suitable. I have my doubts

Jun 2 2018, 1:03 PM · Atelier: AtCore
patrickelectric requested changes to D13281: More 2.0 cleanups.
Jun 2 2018, 12:54 PM · Atelier: AtCore
patrickelectric accepted D13259: Filter ttyS Devices.
Jun 2 2018, 12:32 PM · Atelier: General Development
patrickelectric requested changes to D13281: More 2.0 cleanups.
Jun 2 2018, 12:26 PM · Atelier: AtCore

Jun 1 2018

patrickelectric accepted D13264: Add more log messages be sure its all translated.
Jun 1 2018, 12:48 PM · Atelier: General Development
patrickelectric requested changes to D13259: Filter ttyS Devices.
Jun 1 2018, 12:47 PM · Atelier: General Development
patrickelectric accepted D13241: Update tests and Documents.
Jun 1 2018, 1:08 AM · Atelier: AtCore
patrickelectric added a comment to D13258: Add Welcome Screen.

Thinking something like..

ttyS0 ? How is that possible ?

idk this is just there with my ryzen machine

Jun 1 2018, 12:42 AM
patrickelectric added a comment to D13258: Add Welcome Screen.

Thinking something like..

Jun 1 2018, 12:40 AM
patrickelectric requested changes to D13258: Add Welcome Screen.

I think that is a nice thing to have in atelier, but not in atcore widgets. Everything else appears to be ok (layout and code).

Jun 1 2018, 12:26 AM
patrickelectric requested changes to D13241: Update tests and Documents.
Jun 1 2018, 12:23 AM · Atelier: AtCore

May 30 2018

patrickelectric accepted D12771: GrblPlugin CNC Love.

Everything appears to be fine now, but we need to test before pushing. Please ping me in the weekend to do it.

May 30 2018, 7:38 PM · Atelier: AtCore
patrickelectric requested changes to D12771: GrblPlugin CNC Love.
May 30 2018, 7:04 PM · Atelier: AtCore

May 28 2018

patrickelectric accepted D13149: Change file on the 3d view when editor file changes.
May 28 2018, 7:22 PM · Atelier: General Development
patrickelectric committed R231:780d8ab9b0de: fieloader: Allow empty update (authored by patrickelectric).
fieloader: Allow empty update
May 28 2018, 6:58 PM
patrickelectric committed R231:a97ca9cdd5c2: fieloader: Allow empty update (authored by patrickelectric).
fieloader: Allow empty update
May 28 2018, 6:58 PM
patrickelectric closed D13177: fieloader: Allow empty update.
May 28 2018, 6:58 PM
patrickelectric updated the diff for D13177: fieloader: Allow empty update.

rebase

May 28 2018, 6:57 PM
patrickelectric added reviewers for D13177: fieloader: Allow empty update: rizzitello, tcanabrava, laysrodrigues.
May 28 2018, 5:35 PM
patrickelectric requested review of D13177: fieloader: Allow empty update.
May 28 2018, 5:33 PM
patrickelectric committed R474:77df3c16dd7f: webcamcontrol: Solve crash when calling gst_element_set_state twice (authored by patrickelectric).
webcamcontrol: Solve crash when calling gst_element_set_state twice
May 28 2018, 4:48 PM
patrickelectric closed D13140: webcamcontrol: Solve crash when calling gst_element_set_state twice.
May 28 2018, 4:48 PM
patrickelectric requested changes to D13149: Change file on the 3d view when editor file changes.
May 28 2018, 1:08 PM · Atelier: General Development

May 27 2018

patrickelectric added a comment to D13140: webcamcontrol: Solve crash when calling gst_element_set_state twice.

The app was crashing in the start, this patch solve the problem.
I'll try to put more love in Kamoso, maybe watching multiple cameras at the same time (I'm working with stereo cameras here).

May 27 2018, 1:13 AM
patrickelectric added reviewers for D13140: webcamcontrol: Solve crash when calling gst_element_set_state twice: apol, afiestas.
May 27 2018, 1:12 AM
patrickelectric requested review of D13140: webcamcontrol: Solve crash when calling gst_element_set_state twice.
May 27 2018, 1:11 AM

May 26 2018

patrickelectric accepted D13129: Show asterisk by modified filenames.
May 26 2018, 3:51 PM · Atelier: General Development
patrickelectric added inline comments to D13129: Show asterisk by modified filenames.
May 26 2018, 12:27 PM · Atelier: General Development

May 20 2018

patrickelectric accepted D12719: Atelier enable drag and drop.
May 20 2018, 1:22 PM · Atelier: General Development

May 19 2018

patrickelectric accepted D12456: Enable a notification system.
May 19 2018, 5:34 PM
patrickelectric requested changes to D12719: Atelier enable drag and drop.
May 19 2018, 5:33 PM · Atelier: General Development

May 16 2018

patrickelectric added inline comments to D12771: GrblPlugin CNC Love.
May 16 2018, 12:31 AM · Atelier: AtCore
patrickelectric accepted D12690: GCodeWidget Improvements.
May 16 2018, 12:27 AM · Atelier: General Development

May 15 2018

patrickelectric added a comment to D12719: Atelier enable drag and drop.

foo
{

for(...)
{
May 15 2018, 12:26 AM · Atelier: General Development
patrickelectric requested changes to D12719: Atelier enable drag and drop.
May 15 2018, 12:18 AM · Atelier: General Development

May 14 2018

patrickelectric requested changes to D12719: Atelier enable drag and drop.
May 14 2018, 2:26 AM · Atelier: General Development

May 11 2018

patrickelectric requested changes to D12690: GCodeWidget Improvements.
May 11 2018, 11:41 AM · Atelier: General Development
patrickelectric added inline comments to D12771: GrblPlugin CNC Love.
May 11 2018, 11:38 AM · Atelier: AtCore
patrickelectric accepted D12772: Remove the other GCode comments.
May 11 2018, 11:37 AM · Atelier: AtCore
patrickelectric accepted D12773: Report when Waiting on printer.
May 11 2018, 11:36 AM · Atelier: AtCore
patrickelectric accepted D12814: Only show the KTextEditor actions when the GCodeEditorWidget is the active widget.
May 11 2018, 11:35 AM · Atelier: General Development

May 9 2018

patrickelectric added inline comments to D12771: GrblPlugin CNC Love.
May 9 2018, 3:31 AM · Atelier: AtCore
patrickelectric requested changes to D12773: Report when Waiting on printer.
May 9 2018, 3:14 AM · Atelier: AtCore
patrickelectric requested changes to D12772: Remove the other GCode comments.
May 9 2018, 3:13 AM · Atelier: AtCore
patrickelectric requested changes to D12771: GrblPlugin CNC Love.
May 9 2018, 3:10 AM · Atelier: AtCore

May 8 2018

patrickelectric accepted D12752: Email / Document update.

May 8 2018, 1:29 PM · Atelier: AtCore

May 5 2018

patrickelectric requested changes to D12691: Close Files in the KTextEditor.
May 5 2018, 12:30 PM · Atelier: General Development
patrickelectric requested changes to D12690: GCodeWidget Improvements.
May 5 2018, 12:21 PM · Atelier: General Development

May 4 2018

patrickelectric requested changes to D12691: Close Files in the KTextEditor.
May 4 2018, 2:29 AM · Atelier: General Development
patrickelectric added inline comments to D12690: GCodeWidget Improvements.
May 4 2018, 2:28 AM · Atelier: General Development

May 3 2018

patrickelectric requested changes to D12675: Fix crash on deconstruction.

@patrickelectric Kate has a view manager, that changes the factory when something changes see https://github.com/KDE/kate/blob/master/kate/kateviewmanager.cpp#L610
As you can see to activate a new view it removes the previous one.

May 3 2018, 7:08 PM · Atelier: General Development
patrickelectric added a comment to D12675: Fix crash on deconstruction.

@patrickelectric The problem is that since we dont remove the views, they start to have conflict and the files are not managed properly by KTextEditor and guiFactory(Main Window).
See the discussion on telegram.

May 3 2018, 5:36 PM · Atelier: General Development
patrickelectric accepted D12675: Fix crash on deconstruction.

@laysrodrigues What is the problem of this PR ?

May 3 2018, 2:24 PM · Atelier: General Development
patrickelectric committed R231:228ebee86054: MainWindow: Change comma position in initialization list (authored by patrickelectric).
MainWindow: Change comma position in initialization list
May 3 2018, 1:39 AM
patrickelectric committed R231:101a80d841b7: FileLoader: Move lastPerc inside file open function (authored by patrickelectric).
FileLoader: Move lastPerc inside file open function
May 3 2018, 1:39 AM
patrickelectric committed R231:ea1840a7f7d2: MainWindow: Move m_theme to initialization list (authored by patrickelectric).
MainWindow: Move m_theme to initialization list
May 3 2018, 1:39 AM
patrickelectric committed R231:025d38a5112a: MainWindow: Change comma position in initialization list (authored by patrickelectric).
MainWindow: Change comma position in initialization list
May 3 2018, 1:39 AM
patrickelectric closed D12667: MainWindow: Change comma position in initialization list.
May 3 2018, 1:39 AM

May 2 2018

patrickelectric added inline comments to D12675: Fix crash on deconstruction.
May 2 2018, 10:25 PM · Atelier: General Development
patrickelectric added inline comments to D12667: MainWindow: Change comma position in initialization list.
May 2 2018, 9:02 PM
patrickelectric accepted D12654: Set a minimumSize.
May 2 2018, 8:55 PM · Atelier: General Development
patrickelectric accepted D12651: Preserve QUrl.
May 2 2018, 8:54 PM · Atelier: General Development
patrickelectric accepted D12653: Remove Duplicate Filelists.
May 2 2018, 8:53 PM · Atelier: General Development
patrickelectric added inline comments to D12660: Enforce use of C++11 flags and update minimum version of cmake.
May 2 2018, 7:20 PM
patrickelectric added reviewers for D12667: MainWindow: Change comma position in initialization list: tcanabrava, rizzitello, laysrodrigues.
May 2 2018, 6:54 PM
patrickelectric requested review of D12667: MainWindow: Change comma position in initialization list.
May 2 2018, 6:53 PM

May 1 2018

patrickelectric updated the task description for T8624: contributor trainings.
May 1 2018, 4:10 PM · KDE e.V.

Apr 28 2018

patrickelectric accepted D12585: Show log on unconnected instances..
Apr 28 2018, 4:02 PM · Atelier: General Development
patrickelectric accepted D12570: Remove remaining Solid includes.
Apr 28 2018, 2:10 AM

Apr 27 2018

patrickelectric committed R498:b19e124f81c7: jenkins: Add atcore (authored by patrickelectric).
jenkins: Add atcore
Apr 27 2018, 12:13 AM

Apr 25 2018

patrickelectric accepted D12500: Update Build Status Badges.
Apr 25 2018, 2:58 PM