Make limtedrowcountproxymodel usable from QML
AbandonedPublic
Actions

Authored by davidedmundson on May 21 2019, 9:27 PM.

Details

Reviewers

None

Group Reviewers

Plasma

Summary

For intended moving into KItemModels

Repository

R120 Plasma Workspace

Branch

Plasma/5.16

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12043
Build 12061: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.May 21 2019, 9:27 PM

apol added inline comments.

libnotificationmanager/limitedrowcountproxymodel.cpp
40	it could make sense to check if it's different to the current one.

update

Before moving to frameworks also needs d-pointer

libnotificationmanager/limitedrowcountproxymodel_p.h
47	Should we use `-1` as the default instead and have 0 actually mean limit of zero items = empty?
54	Move above `limitChanged` so the order is consistent with the setter

Discover has a pagniation model which if you only use the first page covers this case.

Lets try and get that one in frameworks instead

			Path	Packages
M			libnotificationmanager/limitedrowcountproxymodel.cpp (4 lines)
M			libnotificationmanager/limitedrowcountproxymodel_p.h (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58442	d61ff93		May 21 2019, 9:27 PM	★	★
Diff 2	58451	a282bc9	update	May 22 2019, 1:24 AM	★	★