davidhurka (David Hurka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2018, 3:14 PM (44 w, 4 d)
Availability
Available

Recent Activity

Sat, Jul 6

davidhurka added a comment to D22297: Add id="current-color-scheme" to collapse-all icons.

(Added screenshots)

Sat, Jul 6, 12:19 PM · Frameworks
davidhurka updated the summary of D22297: Add id="current-color-scheme" to collapse-all icons.
Sat, Jul 6, 12:19 PM · Frameworks
davidhurka accepted D22297: Add id="current-color-scheme" to collapse-all icons.

Yes, problem solved. The icon is now visible with a dark color theme.

Sat, Jul 6, 11:55 AM · Frameworks

Fri, Jul 5

davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

Show the local file path, which handles the case of locally-downloaded remote files

Fri, Jul 5, 6:20 PM · Okular

Mon, Jul 1

davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

How does it work when the document is not local, or is deleted?
E. g. do

okular https://20years.kde.org/book/20yearsofKDE.pdf
Mon, Jul 1, 3:26 PM · Okular

Mon, Jun 24

davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.
Mon, Jun 24, 8:09 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.
  • Forgot to de-rename out_firstpage in doxygen
  • Fix compilation by renaming a parameter I named “default”
  • Fix grammar in PageViewItem
Mon, Jun 24, 8:08 PM · Okular
davidhurka updated the summary of D21266: Improve documentation of area classes.
Mon, Jun 24, 2:54 PM · Okular
davidhurka added a comment to D21266: Improve documentation of area classes.

Changed 3 more lines yesterday.
Now removing [WIP]; I have some remaining questions (inline coments without “done”), but these are not important for this patch.

Mon, Jun 24, 2:50 PM · Okular

Sun, Jun 23

davidhurka updated the diff for D21266: Improve documentation of area classes.
  • Describe consequences of negative width/height
  • Add note to RegularArea::contains() concerning simplify()
Sun, Jun 23, 8:08 PM · Okular
davidhurka added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Not sure, but that one looks like the inductive stylus I once had. (That one worked pretty bad.)

Sun, Jun 23, 7:27 PM · Okular
davidhurka retitled D21271: Improve documentation of TextEntity stuff from [WIP] Improve documentation of TextEntity stuff to Improve documentation of TextEntity stuff.
Sun, Jun 23, 5:35 PM · Okular
davidhurka added a comment to D21271: Improve documentation of TextEntity stuff.

You don't have a committer account, right?

Sun, Jun 23, 5:20 PM · Okular
davidhurka added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

AFAIK these events are only generated for inductive styluses, because a capacitive touchscreen can’t detect proximity with acceptable quality, even less for a stylus.

Sun, Jun 23, 4:45 PM · Okular
davidhurka added a comment to D21759: Hold zoom center below center/mouse position.

Hi @aacid,
thanks for testing,

Also it doesn't work? or not how i would expect it?

I'm doing ctrl+wheel zoom here with the mouse over the a and ends up being over the p.

I was expecting it to end up being over the a too?

to begin the width of the document is smaller than the viewport with, so we have no horizontal scrollbar and we can not make a horizontal scrolling.

Sure, but at some point there will be a scrollbar, and at that point you can make it scroll to the "correct", position, no?

Sun, Jun 23, 2:19 PM · Okular

Sat, Jun 22

davidhurka added a comment to D21196: [RFC] Move Continuous option to View Mode submenu.

Would it make sense to request icons for the view modes?

  • For Single Page, something like tool_pagelayout would be nice. (It’s just a page, i. e. a rectangle with a folded corner.)
  • Facing Pages would have two pages.
  • Overview would have 2 or 3 pages, arranged like the discs in save-all. Arranging in a horizontal row would be misleading if the user configured the Overview column count.
Sat, Jun 22, 10:24 PM · Documentation, Okular
davidhurka updated the diff for D21196: [RFC] Move Continuous option to View Mode submenu.
  • Replace function-like macro by lambda, like done for Color Mode menu in D21195

View mode actions are now organized in QActionGroup * PageView::viewModeActionGroup.
(Uhm, ignore the last commit)

Sat, Jun 22, 9:55 PM · Documentation, Okular
davidhurka updated the diff for D21196: [RFC] Move Continuous option to View Mode submenu.
  • Replace function-like macro by lambda, like done for Color Mode menu in D21195
Sat, Jun 22, 9:52 PM · Documentation, Okular
davidhurka added inline comments to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Sat, Jun 22, 8:27 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I tried it by only adding the actions to it and it does not work, no menu is shown. Adding the signal connection is also not enough. After that I gave up for now (I am lazy). But I think it needs to be a little more user-friendly.

Sat, Jun 22, 7:45 PM · Okular
davidhurka added a comment to D18719: [WIP]Create context menu entry to rotate individual pages.

Sometimes I think it makes sense to move the context menu to the widget it belongs to. That widget would accept the context menu event, and create a context menu. Basically the same context menu that is currently created by Part.

Sat, Jun 22, 7:01 PM · Okular
davidhurka updated the diff for D21266: Improve documentation of area classes.
  • Small improvements based on latest comments by Albert.
Sat, Jun 22, 6:15 PM · Okular
davidhurka added a comment to D21266: Improve documentation of area classes.

Thanks for marking the typos.

Sat, Jun 22, 6:14 PM · Okular
davidhurka added inline comments to D21271: Improve documentation of TextEntity stuff.
Sat, Jun 22, 5:35 PM · Okular
davidhurka updated the diff for D21271: Improve documentation of TextEntity stuff.
  • Remove comment on vertical text, remove the word concatenate
  • Don’t export text entity reordering functions
Sat, Jun 22, 5:34 PM · Okular
davidhurka updated the diff for D21281: [WIP] Write Documentation for Okular::Part.

Left some changes lying arround, here they are.
Rename m_topMessage, improve callflow description, improve fitWindowToPage description.

Sat, Jun 22, 4:49 PM · Okular
davidhurka added inline comments to D21281: [WIP] Write Documentation for Okular::Part.
Sat, Jun 22, 3:59 PM · Okular

Fri, Jun 21

davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

To be more clear, I think that the code below should provide a default working action menu (basically as it was before, but customizable if necessary):

d->aMouseModeMenu = new ToggleActionMenu( this );
d->aMouseModeMenu->addAction( d->aMouseSelect );
d->aMouseModeMenu->addAction( d->aMouseTextSelect );
d->aMouseModeMenu->addAction( d->aMouseTableSelect );
Fri, Jun 21, 7:12 PM · Okular
davidhurka requested review of D21971: [DEMO] Enhance ToggleActionMenu with ImplicitDefaultAction mode..
Fri, Jun 21, 7:08 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I could imagine to add a parameter ToggleActionMenu::MenuLogic to the constructor.

enum MenuLogic {
    DefaultLogic = 0x0,
    /**
     * Automatically makes the triggered action the default action, even if in a submenu.
     * When a toolbar button is constructed, the default action is set to the first checked action in the menu.
     * setDefaultAction() provides a fallback if no action is checked.
     */
    ImplicitDefaultAction = 0x1
};
Fri, Jun 21, 4:41 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Fix parent object QWidget to QObject, remove redundant function call
Fri, Jun 21, 4:27 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I have tested this patch and added some inline comments. It seems to me that ToggleActionMenu requires way more external code to make it work, compared to ToolAction, which is quite automated. I think that some things could be made default in ToggleActionMenu, and some aspect hidden as well e.g. manage the QActionGroup internally without having the user have to manage it and set the action eveytime.

Fri, Jun 21, 4:22 PM · Okular

Thu, Jun 20

davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Set popup mode of Color Mode menu, because ToggleActionMenu respects it now.
Thu, Jun 20, 3:45 PM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Thu, Jun 20, 3:30 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Select correct default action at startup
  • Describe name ToggleActionMenu
  • Let the toolbar buttons respect menu properties like enabled state, and add the menu to updateActionStates().
  • Make popup mode configurable correctly, and set popup mode of mouse mode menu.
Thu, Jun 20, 3:30 PM · Okular
davidhurka added a dependency for D21195: [RFC] Create a Change Colors menu (with toolbar button): D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Thu, Jun 20, 11:33 AM · Okular
davidhurka added a dependent revision for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”: D21195: [RFC] Create a Change Colors menu (with toolbar button).
Thu, Jun 20, 11:33 AM · Okular
davidhurka updated the test plan for D21195: [RFC] Create a Change Colors menu (with toolbar button).
Thu, Jun 20, 11:26 AM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

I would recommend making the toolbar button show the text of the actual color change mode that's currently active, much like how the selection tools toolbar button currently does. Otherwise you won't know which mode it will invoke.

Thu, Jun 20, 11:01 AM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
Thu, Jun 20, 10:51 AM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Rebase on D21755, to use ToggleActionMenu.
  • Show the last used color mode on the toolbar button of the Color Mode menu. (Normal Colors is a radio option now, like the other color modes.)
  • Add color mode menu to updateActionState().
Thu, Jun 20, 10:49 AM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Thu, Jun 20, 10:46 AM · Okular

Mon, Jun 17

davidhurka added a comment to D15580: [WIP] New annotation toolbar.

Don’t have UI feedback that asks for action already in this patch. :)

Mon, Jun 17, 7:16 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, Jun 17, 6:46 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Add license headers
Mon, Jun 17, 5:17 PM · Okular
davidhurka updated the test plan for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Mon, Jun 17, 5:01 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

Currently I am using ToolAction in the new annotation toolbar to selected among different geometrical annotation. [...]
For this purpose I need that the action are checkable, and that the ToggleActionMenu is checkable displaying the selected action (exaclty as ToolAction).

[...] For my use case, I would probably need to be able to display tooltips for each action in the ToggleActionMenu, to describe what they are.

[...] I need to use it for Geometrical annotations and for the Stamp annotation. For this last one I would need to display the different available stamps, so each action in the ToggleActionMenu should just be a checkable action with a full width image and no text. [...]

Mon, Jun 17, 4:47 PM · Okular
davidhurka added a comment to T10201: Window titlebars.

Is there a consensus that the titlebars are not liked enough by the users, possibly because they appear to waste too much space while looking empty?

If so, I want to suggest this: Make the menubar titlebar button expandable, so the menubar can be shown inside the titlebar.

Are you suggesting this in addition or replacement of Nate's idea of tools area with the same color?

Mon, Jun 17, 4:14 PM · KDE Applications, VDG

Sun, Jun 16

davidhurka updated subscribers of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

From my point of view, this is complete now. 3 TODOs left (see revision description at the top).

Sun, Jun 16, 8:03 PM · Okular
davidhurka updated the test plan for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Sun, Jun 16, 7:58 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Remove accidentally inserted #include
  • remove repeated calls to QToolButton::setMenu()
  • Update class documentation
Sun, Jun 16, 7:54 PM · Okular
davidhurka added a comment to D15580: [WIP] New annotation toolbar.

For now I am more interested in feedback on the UI/UX

Sun, Jun 16, 7:40 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Work arround connection problem by using QPointer
Sun, Jun 16, 5:31 PM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Sun, Jun 16, 5:26 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I couldn’t find a reason why disconnecting my slot at destruction fails, but it indeed fails.

Sun, Jun 16, 5:22 PM · Okular
davidhurka added inline comments to D15580: [WIP] New annotation toolbar.
Sun, Jun 16, 5:02 PM · Okular

Jun 14 2019

davidhurka added inline comments to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 14 2019, 4:44 PM · Okular

Jun 13 2019

davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

Theoretically works, but signal-slot is tricking me.

Jun 13 2019, 7:14 PM · Okular

Jun 12 2019

davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Oh, does someone know any intended purpose division between setupActions(), setupViewerActions(), and setupBaseActions()?

someone does yes.

it has to do with part's m_embedMode check part.cpp it's actually pretty easy to see the use case for them

Jun 12 2019, 9:58 PM · Okular
davidhurka added a comment to D21759: Hold zoom center below center/mouse position.

Using cursor position for Ctrl+Scroll, but not for Ctrl+Plus/Minus makes sense to me.

Jun 12 2019, 9:52 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.
  • De-rename parameter out_pagenumber
Jun 12 2019, 9:44 PM · Okular
davidhurka added inline comments to D21734: [WIP] Improve class documentation for PageView and PageViewItem.
Jun 12 2019, 9:43 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Looked over the whole patch again.

Jun 12 2019, 9:21 PM · Okular
davidhurka added a comment to T10201: Window titlebars.

That looks perfect to me.

Jun 12 2019, 9:11 PM · KDE Applications, VDG
davidhurka added a comment to T10201: Window titlebars.

You have the menubar labels vertically centered, I would have them moved a little downwards.

Jun 12 2019, 7:21 PM · KDE Applications, VDG
davidhurka added a comment to T10201: Window titlebars.

Is there a consensus that the titlebars are not liked enough by the users, possibly because they appear to waste too much space while looking empty?

Jun 12 2019, 6:34 PM · KDE Applications, VDG

Jun 11 2019

davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Thanks for your comments, I will look over my patch soon.

Jun 11 2019, 10:24 PM · Okular
davidhurka added inline comments to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 11 2019, 10:09 PM · Okular
davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Part calls them like this:

Jun 11 2019, 9:59 PM · Okular
davidhurka added inline comments to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 11 2019, 9:50 PM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 11 2019, 9:45 PM · Okular
davidhurka updated subscribers of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I suggested to use KActionMenu in D21622 (although not really focussed on that patch). Turned out that KActionMenu can not access already constructed toolbar buttons, so that approach is not possible.

Jun 11 2019, 9:36 PM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 11 2019, 9:29 PM · Okular
davidhurka requested review of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 11 2019, 9:27 PM · Okular

Jun 10 2019

davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

OK, got to test this out. It works well! I would recommend making the toolbar button show the text of the actual color change mode that's currently active, much like how the selection tools toolbar button currently does. Otherwise you won't know which mode it will invoke.

Jun 10 2019, 10:04 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Jun 10 2019, 9:58 PM · Okular
davidhurka added a reviewer for D21734: [WIP] Improve class documentation for PageView and PageViewItem: Okular.

Oh, does someone know any intended purpose division between setupActions(), setupViewerActions(), and setupBaseActions()?

Jun 10 2019, 7:58 PM · Okular
davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Documenting these classes wasn’t really difficult, they already have helpful inline comments and member names.

Jun 10 2019, 7:56 PM · Okular
davidhurka requested review of D21734: [WIP] Improve class documentation for PageView and PageViewItem.
Jun 10 2019, 7:42 PM · Okular
davidhurka added a comment to T8076: Fix design of annotation toolbar.

Is it intended to fix Bug 398108 - Annotation toolbar works only in Browse mode, not in e. g. Text Selection mode?

Jun 10 2019, 6:08 PM · VDG, Okular
davidhurka added a comment to T10997: Improve check box design.
In T10997#187755, @mglb wrote:

[...] indeterminate is used in one place - tree views. And everything there is a problem:

  • square - mentioned before, it is used right now, so would be confusing for current users
  • horizontal line - might be confused with a button for folding tree
  • colored/transparent check mark - color-only differences are bad
  • ellipsis - "open..."
  • ⠴ - conceived while writing this note, intended meaning: "not all"/"something missing"

    Any ideas?

    [...]

    Re check meaning around the world: "Check mark" meaning does not always apply to check boxes. E.g. teachers in Poland use ✓/✗ or ✓/― or +/- as "correct"/"wrong", but in tests, forms and voting cards ✗ is almost always placed in a square as the choice marker.

    [...]
Jun 10 2019, 6:03 PM · VDG, Breeze
davidhurka added a comment to T10997: Improve check box design.

We can't make everything configurable, and configurability is never a substitute for good default behavior. What if I want the letter Z or an Emoji in my checkbox? Should we go out of our way to support those too? Let's not bikeshed this too much and derail the task.

Jun 10 2019, 3:08 PM · VDG, Breeze
davidhurka added a comment to T10997: Improve check box design.

I think it makes much more sense to have this automatically set according to the locale (or language, or whatever makes the most sense) than making it user-configurable. Nobody would ever find it.

Jun 10 2019, 2:59 PM · VDG, Breeze
davidhurka added a comment to T10997: Improve check box design.

the current locale

Jun 10 2019, 2:34 PM · VDG, Breeze

Jun 9 2019

davidhurka added a comment to D20437: Make selection scrolling go at 60 fps.

By the way, this also affects the magnifier tool (Ctrl+6), which calls scrollPosIntoView() when dragged against or beyond the viewport edges.

Jun 9 2019, 6:16 PM · Okular
davidhurka added a comment to D20437: Make selection scrolling go at 60 fps.

Sorry for testing it so late, now that I’m working on PageView.

Jun 9 2019, 1:32 PM · Okular

Jun 8 2019

davidhurka added a comment to D21622: Use a more conventional dropdown menu style instead of press-and-hold.

Couldn’t the whole class ToolAction be replaced by KActionMenu now?

Jun 8 2019, 10:26 PM · Okular

Jun 7 2019

davidhurka added a comment to T10997: Improve check box design.

+1 for using a checkmark instead of a sqare. (Although I like the animation of folding and unfolding the sqare.)
-1 for using ... for tristate/indeterminate. That looks like the checkbox will open a dialog (https://hig.kde.org/style/writing/labels.html?highlight=ellipsis). If looking fast, it even looks like a hamburger button, which will open a menu. At least, it looks more like a pushbutton than a checkbox.

Jun 7 2019, 3:45 PM · VDG, Breeze
davidhurka added a comment to D21622: Use a more conventional dropdown menu style instead of press-and-hold.

clicking on the arrow on the right side of the button will open the pop-up and allow choosing another tool, which is a more common method of implementing the feature.

Jun 7 2019, 3:26 PM · Okular
davidhurka added a comment to D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement.

The current keyboard shortcuts aren't a problem if we don't re-arrange the items in the Selection Mode toolbar button.

Jun 7 2019, 2:55 PM · Okular

Jun 6 2019

davidhurka added a comment to T10201: Window titlebars.

So yes, we should and must consider "Pro" apps, but we cannot fix apps that are already have very problematic user interfaces.

Jun 6 2019, 10:29 PM · KDE Applications, VDG

Jun 5 2019

davidhurka added a comment to D15580: [WIP] New annotation toolbar.

Or: Why is this still PageViewToolBar? It is not anymore in the PageView?

I'll move it, added to TODO

Actually the code of the other toolbar (Browse, Zoom, Selection) is managed in the file pageview.cpp. In which file would you move the code of PageViewToolBar?

Jun 5 2019, 8:28 AM · Okular

Jun 4 2019

davidhurka added a comment to T10201: Window titlebars.

SierraBreezeEnhanced to the rescue again - what about different window buttons if the window is active or inactive?

Obviously this exact solution would be seen as copying macOS, but maybe just having circles or rings in the active window would help.

I suppose inactive windows could be set to not show the circle around the close button by default, but there should always be visible symbols.

The close button is good to find a window corner, even if the window is mostly hidden by other windows. I think it shouldn’t be circle-less when the window is inactive, that way a visual aid on the window geometry is lost.

Jun 4 2019, 7:34 PM · KDE Applications, VDG
davidhurka updated the diff for D21266: Improve documentation of area classes.

Removed references to pages from methods.

Jun 4 2019, 6:49 PM · Okular
davidhurka added a comment to D15580: [WIP] New annotation toolbar.

Sticky-by-default would probably be okay as long as we can make it very clear how to un-select the tool. Probably implementing multiple methods would be good (hit esc key, left-click again on the tool, right-click anywhere, etc).

Jun 4 2019, 5:43 PM · Okular

Jun 3 2019

davidhurka added a comment to D15580: [WIP] New annotation toolbar.
  • I can't figure out what Pin Annotation actually does

If checked the current annotation tool is kept selected after use (as double-click does in the current Okular). Needs a better name/tooltip. Added to TODO.

Can't we just keep the old double-click behavior? I think that's good. Various other similar tools use a double-click to mean "activate this tool and then keep it active after you've used it once" so it's not a totally alien UI. Then we could keep the pin icon as an additional visual status indicator of whether the current tool is "sticky" or not.

Using double-click is probably used to some [how many?] Okular users, but others asked for something like a sticky button. An option to make selected actions sticky by default, without sticky button, would be perfect for me.
From other applications I know left-click: use the tool, right-click: stop using the tool. If there is no fallback tool (see below), the tool will be remembered for the next left click.

Jun 3 2019, 5:12 PM · Okular

Jun 2 2019

davidhurka added inline comments to D21266: Improve documentation of area classes.
Jun 2 2019, 11:34 PM · Okular
davidhurka added a comment to D21266: Improve documentation of area classes.

I will remove page sizes from member documentations and describe the coordinate system with a more abstract reference rectangle.

Jun 2 2019, 10:51 PM · Okular
davidhurka updated the summary of D21281: [WIP] Write Documentation for Okular::Part.
Jun 2 2019, 10:09 PM · Okular
davidhurka added inline comments to D21271: Improve documentation of TextEntity stuff.
Jun 2 2019, 10:08 PM · Okular