davidhurka (David Hurka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2018, 3:14 PM (82 w, 4 d)
Availability
Available

Recent Activity

Yesterday

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

@ngraham How’s your progress with the bash script? I’m currently trying to understand bash syntax. Maybe I can do it, if you don’t have done it already.

Mon, Apr 6, 9:36 PM · VDG, Frameworks
davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

Now we have less than 130 icons which are different in icons/ and icons-dark/, and less than 100 icons which we should keep as dark version. Maybe we can keep event less.

Mon, Apr 6, 3:35 PM · VDG, Frameworks

Sun, Apr 5

davidhurka committed R266:07487651e13c: Remove border from format-border-set-* icons (authored by davidhurka).
Remove border from format-border-set-* icons
Sun, Apr 5, 11:23 AM
davidhurka closed D28561: Remove border from format-border-set-* icons.
Sun, Apr 5, 11:23 AM · Frameworks
davidhurka updated the summary of D28561: Remove border from format-border-set-* icons.
Sun, Apr 5, 10:45 AM · Frameworks
davidhurka updated the diff for D28561: Remove border from format-border-set-* icons.
  • Remove border elements in 22px versions of format-border-*
Sun, Apr 5, 10:43 AM · Frameworks

Sat, Apr 4

davidhurka added a comment to D28561: Remove border from format-border-set-* icons.

There are 22px versions of these icons. They passed the auto-generation, because they use a different approach. They have a border, but it is not in ViewBackground, but in Text with transparency 0.1. Should I add such a border to the 16px version, or remove it in the 22px version?

Sat, Apr 4, 5:21 PM · Frameworks
davidhurka updated the summary of D28561: Remove border from format-border-set-* icons.
Sat, Apr 4, 2:56 PM · Frameworks
davidhurka requested review of D28561: Remove border from format-border-set-* icons.
Sat, Apr 4, 2:51 PM · Frameworks
davidhurka abandoned D28553: Rename stylesheet color ButtonFocus -> Highlight.

Ok, then I’ll let you do it.

Sat, Apr 4, 12:48 PM · Frameworks
davidhurka added a comment to D28553: Rename stylesheet color ButtonFocus -> Highlight.

Cuttlefish (Ubuntu release)?

Sat, Apr 4, 12:22 PM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

@ndavis commited (excerpt):

diff --git a/icons-dark/actions/22/document-export-ocal.svg b/icons-dark/actions/22/document-export-ocal.svg
index 4bfca303..ace4fe41 120000
--- a/icons-dark/actions/22/document-export-ocal.svg
+++ b/icons-dark/actions/22/document-export-ocal.svg
@@ -1 +1 @@
-/home/david/kde/breeze-icons/icons-dark/actions/22/document-export.svg
\ No newline at end of file
+document-export.svg
\ No newline at end of file
Sat, Apr 4, 11:32 AM · Frameworks
davidhurka requested review of D28553: Rename stylesheet color ButtonFocus -> Highlight.
Sat, Apr 4, 10:24 AM · Frameworks
davidhurka closed T12806: Move corner fold to the top-right for all document icons as Resolved by committing R266:2808396a7bb8: Move corner fold to top right in 24 icons.
Sat, Apr 4, 9:55 AM · VDG
davidhurka committed R266:2808396a7bb8: Move corner fold to top right in 24 icons (authored by davidhurka).
Move corner fold to top right in 24 icons
Sat, Apr 4, 9:55 AM
davidhurka closed D28203: Move corner fold to top right in 24 icons.
Sat, Apr 4, 9:55 AM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

I created revision D28204 accidentally when I tried to update this revision. That made my initial commit point to D28204 instead of D28203, so I couldn’t tell arc to land this revision. So I made git commit --amend on the initial commit to change the revision number, and rebased the other commits on the new commit. Phabricator UI tells me that the patch content stayed identical, so I land this now.

Sat, Apr 4, 9:54 AM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.

Rebase on an initial commit which points to D28203, not D28204.

Sat, Apr 4, 9:50 AM · Frameworks
davidhurka committed R266:aff4a3e23d92: Make find-location show a magnifier on a map, to be different to mark-location (authored by davidhurka).
Make find-location show a magnifier on a map, to be different to mark-location
Sat, Apr 4, 9:26 AM
davidhurka closed D27983: Make find-location show a magnifier on a map, to be different to mark-location.
Sat, Apr 4, 9:26 AM · Frameworks
davidhurka committed R230:de1e2fd97aae: Add myself (davidhurka) to relicensecheck.pl (authored by davidhurka).
Add myself (davidhurka) to relicensecheck.pl
Sat, Apr 4, 9:22 AM
davidhurka closed D28437: Add myself (davidhurka) to relicensecheck.pl.
Sat, Apr 4, 9:22 AM

Mon, Mar 30

davidhurka updated the diff for D28437: Add myself (davidhurka) to relicensecheck.pl.

Where can I verify the SSH fingerprint of git.kde.org?

Mon, Mar 30, 2:11 PM
davidhurka requested review of D28437: Add myself (davidhurka) to relicensecheck.pl.
Mon, Mar 30, 2:10 PM

Sat, Mar 28

davidhurka requested review of D28203: Move corner fold to top right in 24 icons.

One potentially important thing: See inline comment.

Sat, Mar 28, 3:37 PM · Frameworks

Fri, Mar 27

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it doesn’t look intended.

Fri, Mar 27, 10:47 PM · VDG, Frameworks
davidhurka updated the diff for D28362: Fix stylesheet linking in 8 icons.
  • Fix spelling
Fri, Mar 27, 8:24 PM · Frameworks
davidhurka updated the diff for D28362: Fix stylesheet linking in 8 icons.

@ndavis

Fri, Mar 27, 8:21 PM · Frameworks
davidhurka requested review of D28362: Fix stylesheet linking in 8 icons.
Fri, Mar 27, 8:20 PM · Frameworks

Thu, Mar 26

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

By the way I looked through the 319 icons.

  • Some icons actually need fixing in icons/.
  • The emblem rating is blue in icons-dark/, because it links to another class. We can:
    • Leave rating in icons-dark/
    • Change the light version to be blue too
  • (Probably) All mimetype icons in size 32px and 64px look significantly different in light and dark
Thu, Mar 26, 11:55 PM · VDG, Frameworks
davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

I have to take some short notes here.

Thu, Mar 26, 11:49 PM · VDG, Frameworks
davidhurka requested review of D28323: Fix some stylesheet colors in 2 icon files.
Thu, Mar 26, 10:58 PM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

I would need a developer account to land this. Same for D27983 I assume?

Thu, Mar 26, 6:07 PM · Frameworks

Wed, Mar 25

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

Can you write a bash script which copies the icon files to icons-dark/ and substitutes the colors? Apparently you know how to do that, my bash skills are a bit worse.

Wed, Mar 25, 11:11 PM · VDG, Frameworks
davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

I have created montages of the different icons. The original files to the left, the generated to the right. (Hover the images to see the file path)

Wed, Mar 25, 11:09 PM · VDG, Frameworks
davidhurka added inline comments to D28203: Move corner fold to top right in 24 icons.
Wed, Mar 25, 6:01 PM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.
  • Give **/acrobat.svg its fixed color back
Wed, Mar 25, 6:01 PM · Frameworks
davidhurka added inline comments to D28203: Move corner fold to top right in 24 icons.
Wed, Mar 25, 3:28 PM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.
  • Fix symlinks: make relative
Wed, Mar 25, 3:23 PM · Frameworks

Tue, Mar 24

davidhurka added projects to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/: Frameworks, VDG.
Tue, Mar 24, 10:22 PM · VDG, Frameworks
davidhurka created T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.
Tue, Mar 24, 10:20 PM · VDG, Frameworks

Mon, Mar 23

davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not in 22px. What are 12px and 32px good for?

Mon, Mar 23, 6:48 PM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.
  • link 32px document-preview-archive and document-preview
  • Move corner fold to top for 6 32px icons
Mon, Mar 23, 6:48 PM · Frameworks
davidhurka abandoned D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).

garg.

Mon, Mar 23, 6:45 PM · Frameworks
davidhurka updated the diff for D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).
  • link 32px document-preview-archive and document-preview
  • Move corner fold to top for 6 32px icons
Mon, Mar 23, 6:44 PM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

I understand the concerns. It looks unbalanced. But these icons also look unbalanced now: acrobat, filename-title-amarok.

Mon, Mar 23, 5:08 PM · Frameworks

Sun, Mar 22

davidhurka updated the task description for T12806: Move corner fold to the top-right for all document icons.
Sun, Mar 22, 3:30 PM · VDG
davidhurka updated the summary of D28203: Move corner fold to top right in 24 icons.
Sun, Mar 22, 3:29 PM · Frameworks
davidhurka added a reviewer for D28203: Move corner fold to top right in 24 icons: VDG.
Sun, Mar 22, 3:29 PM · Frameworks
davidhurka abandoned D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).

Whoops duplicate.

Sun, Mar 22, 3:26 PM · Frameworks
davidhurka requested review of D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).
Sun, Mar 22, 3:24 PM · Frameworks
davidhurka requested review of D28203: Move corner fold to top right in 24 icons.
Sun, Mar 22, 3:24 PM · Frameworks

Mon, Mar 16

davidhurka committed R223:2bee66d22580: Set buddy and alignment for some QLabels in configuration dialogs (authored by davidhurka).
Set buddy and alignment for some QLabels in configuration dialogs
Mon, Mar 16, 10:31 PM
davidhurka added a comment to T12825: Need icons for Okular color modes.

I made some experiments.

  1. color-mode-black-white
  2. color-mode-change-dark-light
  3. color-mode-hue-shift-240
  4. color-mode-hue-shift-120
  5. paper-color
  6. color-mode-invert-text
  7. color-mode-invert-image
  8. Alternative to color-mode-invert-image
  9. Alternative to color-mode-invert-image
  10. color-mode-invert
  11. Alternative to color-mode-invert
  12. Alternative to color-mode-invert-text
Mon, Mar 16, 3:56 PM · Okular, VDG
davidhurka created T12825: Need icons for Okular color modes.
Mon, Mar 16, 12:13 AM · Okular, VDG

Sun, Mar 15

davidhurka committed R223:6c5244cae3ea: Add new page layout icons to all view mode actions (authored by davidhurka).
Add new page layout icons to all view mode actions
Sun, Mar 15, 3:41 PM

Fri, Mar 13

davidhurka added a comment to T11950: Reduce the pain of working on monochrome Breeze icons.

This is how my source file for find-location (D27983) looks in inkscape.

Fri, Mar 13, 7:36 PM · Frameworks, VDG

Wed, Mar 11

davidhurka updated the test plan for D27983: Make find-location show a magnifier on a map, to be different to mark-location.
Wed, Mar 11, 2:48 PM · Frameworks
davidhurka requested review of D27983: Make find-location show a magnifier on a map, to be different to mark-location.
Wed, Mar 11, 2:46 PM · Frameworks

Tue, Mar 10

davidhurka created T12806: Move corner fold to the top-right for all document icons.
Tue, Mar 10, 11:51 PM · VDG
davidhurka added a comment to T11950: Reduce the pain of working on monochrome Breeze icons.

Whoops, this Task went past me while I created breeze-icon-cleaner. What a pity!

Tue, Mar 10, 11:39 PM · Frameworks, VDG

Feb 22 2020

davidhurka added a comment to D15580: New annotation toolbar.

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

It’s okay to me that you write the autotests. If you wish, I could do that instead.

I am new to autotests, so I will have to learn how to do that. I am also unsure about what should be tested. The ToggleActionMenu itself, or its behaviour in Okular?

davidhurka (David Hurka)

User

Feb 22 2020, 6:31 PM · Documentation, Okular

Feb 4 2020

davidhurka added a comment to D15580: New annotation toolbar.

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

Feb 4 2020, 3:11 PM · Documentation, Okular

Jan 25 2020

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Do modifications suggested by @simgunz
Jan 25 2020, 6:47 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

I’m getting a bit dizy about the repository. I thought I merged master, but apparently I made a mistake. Thanks for pointing me along the right way.

Jan 25 2020, 6:46 PM · Okular
davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Merge branch 'master' into create-configurable-toggleactionmenu
Jan 25 2020, 6:26 PM · Okular

Jan 18 2020

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.

pong :) Sorry, I wasn’t available for the last weeks.

Jan 18 2020, 6:55 PM · Okular

Nov 30 2019

davidhurka added a comment to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

Hey Yegor, I like this idea. I’m not sure what you mean with adding visual controls.

Nov 30 2019, 6:25 PM · Okular

Nov 23 2019

davidhurka added a comment to D25484: Enable closing a tab by middle click.

To prevent some accidental middle-mouse-clicks on the tab bar, we could lock the cursor while middle-mouse-button-zoom.

Nov 23 2019, 7:16 PM · Okular

Nov 18 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Sorry, what is it that you'd like my input on?

Nov 18 2019, 9:38 PM · Okular

Nov 11 2019

davidhurka added a comment to T10997: Improve check box design.
In T10997#207761, @mglb wrote:

Color scheme issue. Highlight background color is used. I could change it to something like background color of selected item in unfocused sidebar, but then it won't look that good in light Breeze.

We need to change the colorschemes anyway, so think about how colorscheme colors should be used based on semantics rather than what the actual colors are.

Nov 11 2019, 2:48 PM · VDG, Breeze

Nov 10 2019

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum
Nov 10 2019, 8:19 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)

Yes, but how? It can’t simply be forbidden in the constructor argument list. Remove it from the body of the constructor, so KActionMenu is set to MenuButtonPopup instead?

Create a new enum ToggleActionMenu::ToolButtonPopupMode with only DelayedPopup and MenuButtonPopup.

Nov 10 2019, 8:06 PM · Okular
davidhurka added a comment to T10997: Improve check box design.

There's also an option for gray background, like "checked" tool buttons. I think it would be more consistent.

Current look:

Checked gray:

Nov 10 2019, 6:17 PM · VDG, Breeze

Nov 9 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)
Nov 9 2019, 9:06 PM · Okular

Nov 7 2019

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Try to improve documentation, exspecially how to set the default action
Nov 7 2019, 12:07 AM · Okular

Nov 6 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To answer your second comment first, and to be sure you understand everything how I understand you understand it...

I also would like to get rid of DefaultLogic and just use ImplicitDefaultAction, but I am not sure if this creates problem when ToggleActionMenu is placed in a menu.

No, creates no problem.

Nov 6 2019, 11:53 PM · Okular

Nov 4 2019

davidhurka added inline comments to D15580: New annotation toolbar.
Nov 4 2019, 8:09 PM · Documentation, Okular

Nov 3 2019

davidhurka abandoned D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

Obsolete now, because ImplicitDefaultAction mode from D21971 is needed for D15580.

Nov 3 2019, 6:57 PM · Okular
davidhurka updated the test plan for D21971: Replace ToolAction by ToggleActionMenu.
Nov 3 2019, 6:56 PM · Okular
davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Rebase on master
Nov 3 2019, 6:55 PM · Okular
davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • checkedAction() also looks in submenus for checked actions
Nov 3 2019, 6:10 PM · Okular
davidhurka updated subscribers of D21971: Replace ToolAction by ToggleActionMenu.

D15580 depends on this code (not this Differential Revision, currently) now. Before landing this, I have to think about checkedAction(). Theoretically, it doesn’t find checked actions in submenus, while the connection to the signal QActionGroup::triggered(QAction*) does.

Nov 3 2019, 12:22 AM · Okular

Nov 2 2019

davidhurka added a comment to D15580: New annotation toolbar.

I managed to test your patch now.

Nov 2 2019, 11:30 PM · Documentation, Okular

Oct 25 2019

davidhurka added inline comments to D15580: New annotation toolbar.
Oct 25 2019, 10:07 PM · Documentation, Okular
davidhurka added a comment to D15580: New annotation toolbar.

Should I configure the toolbar so that if the user changes to "text alongside icons" the toolbar appears like this?
(the user can then expand the remaining icon-only buttons one by one by right clicking on them if he needs to visualize the text)

Oct 25 2019, 9:38 PM · Documentation, Okular

Oct 22 2019

davidhurka added a comment to D15580: New annotation toolbar.

Didn’t yet test this, but I like some of Nate’s ideas.

Oct 22 2019, 7:43 PM · Documentation, Okular

Oct 20 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

simgunz added a dependent revision: D15580: [WIP] New annotation toolbar.

Oct 20 2019, 4:54 PM · Okular

Oct 13 2019

davidhurka added a comment to D15580: New annotation toolbar.

Typically the color chooser includes a "transparent" item.

Oct 13 2019, 5:56 PM · Documentation, Okular

Oct 5 2019

davidhurka added a comment to T10107: Survey on diversity.

If this survey is a circular dependency, we probably should turn this whole task into a survey.

Oct 5 2019, 7:43 PM · KDE Promo

Aug 20 2019

davidhurka added a comment to D15580: New annotation toolbar.
  • How would you fit the annotation actions in the Reviews tab?
  • Would you create a sub-tab in it (as in Gwenview where the tabs are at the bottom)? -
  • Can you provide a minimal mockup of this?

Having it tabbed like Gwenview was what I was envisioning, yeah. Basically copy the UX of Gwenview's sidebar, but inside Okular's Reviews tab.

Aug 20 2019, 3:21 PM · Documentation, Okular

Aug 17 2019

davidhurka added a comment to D15580: New annotation toolbar.

Some thoughts:

Aug 17 2019, 11:45 AM · Documentation, Okular

Jul 28 2019

davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

What I am probably not understanding is. Is ToggleActionMenu meant to be a general component that you want to use in other parts of KDE? Or is it just meant for Okular?

Jul 28 2019, 4:43 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Suggested changes:

  • Make QToolButton::MenuButtonPopup, and ToggleActionMenu::ImplicitDefaultAction the defaults in the constructor so we can call it as d->aMouseModeMenu = new ToggleActionMenu( QIcon(),QString(), this);
Jul 28 2019, 4:36 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

@simgunz Thanks for your feedback. I have just got some more private to-do, so if I do not look at your feedback later today, please wait at least until wednesday. :)

Jul 28 2019, 3:16 PM · Okular

Jul 26 2019

davidhurka added a comment to D21196: [RFC] Move Continuous option to View Mode submenu.

Icons are there: D22617.

Jul 26 2019, 2:19 PM · Documentation, Okular
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Add missing .ColorScheme-Text { to 24px versions of snap-page.svg
Jul 26 2019, 1:14 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Add missing id=currentColorScheme to 24px versions of snap-page
Jul 26 2019, 1:04 PM · Frameworks

Jul 23 2019

davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

What does fill:currentColor mean, by the way?

Jul 23 2019, 3:47 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Remove color attributes, which were added by scour-icon
Jul 23 2019, 3:46 PM · Frameworks