davidhurka (David Hurka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2018, 3:14 PM (61 w, 4 d)
Availability
Available

Recent Activity

Today

davidhurka added a comment to T10997: Improve check box design.
In T10997#207761, @mglb wrote:

Color scheme issue. Highlight background color is used. I could change it to something like background color of selected item in unfocused sidebar, but then it won't look that good in light Breeze.

We need to change the colorschemes anyway, so think about how colorscheme colors should be used based on semantics rather than what the actual colors are.

Mon, Nov 11, 2:48 PM · VDG, Breeze

Yesterday

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum
Sun, Nov 10, 8:19 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)

Yes, but how? It can’t simply be forbidden in the constructor argument list. Remove it from the body of the constructor, so KActionMenu is set to MenuButtonPopup instead?

Create a new enum ToggleActionMenu::ToolButtonPopupMode with only DelayedPopup and MenuButtonPopup.

Sun, Nov 10, 8:06 PM · Okular
davidhurka added a comment to T10997: Improve check box design.

There's also an option for gray background, like "checked" tool buttons. I think it would be more consistent.

Current look:

Checked gray:

Sun, Nov 10, 6:17 PM · VDG, Breeze

Sat, Nov 9

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)
Sat, Nov 9, 9:06 PM · Okular

Thu, Nov 7

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Try to improve documentation, exspecially how to set the default action
Thu, Nov 7, 12:07 AM · Okular

Wed, Nov 6

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To answer your second comment first, and to be sure you understand everything how I understand you understand it...

I also would like to get rid of DefaultLogic and just use ImplicitDefaultAction, but I am not sure if this creates problem when ToggleActionMenu is placed in a menu.

No, creates no problem.

Wed, Nov 6, 11:53 PM · Okular

Mon, Nov 4

davidhurka added inline comments to D15580: New annotation toolbar.
Mon, Nov 4, 8:09 PM · Documentation, Okular

Sun, Nov 3

davidhurka abandoned D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

Obsolete now, because ImplicitDefaultAction mode from D21971 is needed for D15580.

Sun, Nov 3, 6:57 PM · Okular
davidhurka updated the test plan for D21971: Replace ToolAction by ToggleActionMenu.
Sun, Nov 3, 6:56 PM · Okular
davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Rebase on master
Sun, Nov 3, 6:55 PM · Okular
davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • checkedAction() also looks in submenus for checked actions
Sun, Nov 3, 6:10 PM · Okular
davidhurka updated subscribers of D21971: Replace ToolAction by ToggleActionMenu.

D15580 depends on this code (not this Differential Revision, currently) now. Before landing this, I have to think about checkedAction(). Theoretically, it doesn’t find checked actions in submenus, while the connection to the signal QActionGroup::triggered(QAction*) does.

Sun, Nov 3, 12:22 AM · Okular

Sat, Nov 2

davidhurka added a comment to D15580: New annotation toolbar.

I managed to test your patch now.

Sat, Nov 2, 11:30 PM · Documentation, Okular

Fri, Oct 25

davidhurka added inline comments to D15580: New annotation toolbar.
Fri, Oct 25, 10:07 PM · Documentation, Okular
davidhurka added a comment to D15580: New annotation toolbar.

Should I configure the toolbar so that if the user changes to "text alongside icons" the toolbar appears like this?
(the user can then expand the remaining icon-only buttons one by one by right clicking on them if he needs to visualize the text)

Fri, Oct 25, 9:38 PM · Documentation, Okular

Tue, Oct 22

davidhurka added a comment to D15580: New annotation toolbar.

Didn’t yet test this, but I like some of Nate’s ideas.

Tue, Oct 22, 7:43 PM · Documentation, Okular

Sun, Oct 20

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

simgunz added a dependent revision: D15580: [WIP] New annotation toolbar.

Sun, Oct 20, 4:54 PM · Okular

Sun, Oct 13

davidhurka added a comment to D15580: New annotation toolbar.

Typically the color chooser includes a "transparent" item.

Sun, Oct 13, 5:56 PM · Documentation, Okular

Oct 5 2019

davidhurka added a comment to T10107: Survey on diversity.

If this survey is a circular dependency, we probably should turn this whole task into a survey.

Oct 5 2019, 7:43 PM · KDE Promo

Aug 20 2019

davidhurka added a comment to D15580: New annotation toolbar.
  • How would you fit the annotation actions in the Reviews tab?
  • Would you create a sub-tab in it (as in Gwenview where the tabs are at the bottom)? -
  • Can you provide a minimal mockup of this?

Having it tabbed like Gwenview was what I was envisioning, yeah. Basically copy the UX of Gwenview's sidebar, but inside Okular's Reviews tab.

Aug 20 2019, 3:21 PM · Documentation, Okular

Aug 17 2019

davidhurka added a comment to D15580: New annotation toolbar.

Some thoughts:

Aug 17 2019, 11:45 AM · Documentation, Okular

Jul 28 2019

davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

What I am probably not understanding is. Is ToggleActionMenu meant to be a general component that you want to use in other parts of KDE? Or is it just meant for Okular?

Jul 28 2019, 4:43 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Suggested changes:

  • Make QToolButton::MenuButtonPopup, and ToggleActionMenu::ImplicitDefaultAction the defaults in the constructor so we can call it as d->aMouseModeMenu = new ToggleActionMenu( QIcon(),QString(), this);
Jul 28 2019, 4:36 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

@simgunz Thanks for your feedback. I have just got some more private to-do, so if I do not look at your feedback later today, please wait at least until wednesday. :)

Jul 28 2019, 3:16 PM · Okular

Jul 26 2019

davidhurka added a comment to D21196: [RFC] Move Continuous option to View Mode submenu.

Icons are there: D22617.

Jul 26 2019, 2:19 PM · Documentation, Okular
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Add missing .ColorScheme-Text { to 24px versions of snap-page.svg
Jul 26 2019, 1:14 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Add missing id=currentColorScheme to 24px versions of snap-page
Jul 26 2019, 1:04 PM · Frameworks

Jul 23 2019

davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

What does fill:currentColor mean, by the way?

Jul 23 2019, 3:47 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Remove color attributes, which were added by scour-icon
Jul 23 2019, 3:46 PM · Frameworks
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

I assume that fill="currentColor" also doesn’t work as expected, fixing that now...

Jul 23 2019, 3:24 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Fix id=current-color-scheme attributes which were removed by scour-icon.
Jul 23 2019, 3:22 PM · Frameworks

Jul 22 2019

davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Why does the stylesheet need a background?

You only need to add the classes that you will use. If you want to use the window background color, you can use the Background class.

Jul 22 2019, 5:46 PM · Frameworks
davidhurka added a comment to D21376: RFC: In annotations list show highlighted text.

This would help to fix/implement bug 377886. The missing part is tweaking the search field above the annotation tree view.

Jul 22 2019, 5:35 PM · Okular
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I can understand it.

  • Why does the stylesheet need a background?
  • How are the color scheme properties in the stylesheet mapped to the reduced breeze palette in the HIG? (I think neutral or Beware Orange do not clearly map.)
Jul 22 2019, 5:15 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Adapt view-pages-facing and -facing-first-centered to use ndavis' suggested files
Jul 22 2019, 5:10 PM · Frameworks
davidhurka updated the summary of D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
Jul 22 2019, 5:08 PM · Frameworks
davidhurka updated the test plan for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
Jul 22 2019, 5:06 PM · Frameworks
davidhurka added a comment to D15580: New annotation toolbar.

@davidhurka Thanks for looking up the bug numbers

Do you know if adding the bug numbers separated by a comma without repeating the keyword BUG would work?

Jul 22 2019, 4:46 PM · Documentation, Okular
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

I can’t follow you here. Centering the first page is a feature / technical detail of Okular, but it indicates that the first page is somehow special, like the cover page of a book. But your document could be a single chapter of the book as well, so the first page is just a regular odd-numbered page. That page should be aligned right.

Since it's an icon for Okular and the feature is called "Facing Pages (Center First Page), I don't understand what the problem is with making the top symbol centered.

Here's what I had in mind:

Jul 22 2019, 4:07 PM · Frameworks
davidhurka added a comment to D15580: New annotation toolbar.

You could consider to add these bugs as BUG keywords to this patch: 386578, 374728, 352310, 330518, 341914, 157289

Jul 22 2019, 3:51 PM · Documentation, Okular
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

Nice work!

I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right clashes with our convention of putting additional symbols in the bottom right and all of our color icons use the top right for the corner fold.

Jul 22 2019, 3:01 PM · Frameworks
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

I'll give the latest changes a proper review in a little while.

What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.

Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG standard for coloring symbolic/monochrome icons will fix that and then we can drop icons-dark.

Jul 22 2019, 2:35 PM · Frameworks
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.

Jul 22 2019, 1:51 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Rename pagelayout-* to view-pages-*
Jul 22 2019, 1:44 PM · Frameworks
davidhurka updated the diff for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
  • Remove 24px icons
  • Flip snap-page icons vertically, so the corner fold is at the top-right
  • Make pagelayout-single link to snap-page
  • Flip pagelayout-* icons, except pagelayout-single
Jul 22 2019, 1:39 PM · Frameworks
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

Nice work!

I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right clashes with our convention of putting additional symbols in the bottom right and all of our color icons use the top right for the corner fold.

Jul 22 2019, 1:25 PM · Frameworks

Jul 21 2019

davidhurka updated the test plan for D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
Jul 21 2019, 5:39 PM · Frameworks
davidhurka updated subscribers of D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
Jul 21 2019, 5:38 PM · Frameworks
davidhurka added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

I’m not sure whether I did everything correctly. If I did, this is too complicated.

Jul 21 2019, 5:37 PM · Frameworks
davidhurka requested review of D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
Jul 21 2019, 5:30 PM · Frameworks
davidhurka added a comment to T11093: Improve Consistency across the Board.
  • Plotting applications: KmPlot, LabPlot and KAlgebra overlap in the feature of plotting functions - KAlgebra and KmPlot especially should probably be the same applications, as they provide very similiar features, but both apps lack features of the other one.
Jul 21 2019, 1:36 PM · Goal: Consistency, Goal Setting 2019
davidhurka added a comment to T11093: Improve Consistency across the Board.

I want to add another example of inconsistency: Automatic scrolling (that scrolling that happens when you drag something to the edges of a scrollable view.)

Jul 21 2019, 1:24 PM · Goal: Consistency, Goal Setting 2019

Jul 16 2019

davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

Sorry, I forgot about this.

Jul 16 2019, 10:56 AM · Okular

Jul 6 2019

davidhurka added a comment to D22297: Add id="current-color-scheme" to collapse-all icons.

(Added screenshots)

Jul 6 2019, 12:19 PM · Frameworks
davidhurka updated the summary of D22297: Add id="current-color-scheme" to collapse-all icons.
Jul 6 2019, 12:19 PM · Frameworks
davidhurka accepted D22297: Add id="current-color-scheme" to collapse-all icons.

Yes, problem solved. The icon is now visible with a dark color theme.

Jul 6 2019, 11:55 AM · Frameworks

Jul 5 2019

davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

Show the local file path, which handles the case of locally-downloaded remote files

Jul 5 2019, 6:20 PM · Okular

Jul 1 2019

davidhurka added a comment to D22145: Add "Open Containing Folder" feature.

How does it work when the document is not local, or is deleted?
E. g. do

okular https://20years.kde.org/book/20yearsofKDE.pdf
Jul 1 2019, 3:26 PM · Okular

Jun 24 2019

davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.
Jun 24 2019, 8:09 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.
  • Forgot to de-rename out_firstpage in doxygen
  • Fix compilation by renaming a parameter I named “default”
  • Fix grammar in PageViewItem
Jun 24 2019, 8:08 PM · Okular
davidhurka updated the summary of D21266: Improve documentation of area classes.
Jun 24 2019, 2:54 PM · Okular
davidhurka added a comment to D21266: Improve documentation of area classes.

Changed 3 more lines yesterday.
Now removing [WIP]; I have some remaining questions (inline coments without “done”), but these are not important for this patch.

Jun 24 2019, 2:50 PM · Okular

Jun 23 2019

davidhurka updated the diff for D21266: Improve documentation of area classes.
  • Describe consequences of negative width/height
  • Add note to RegularArea::contains() concerning simplify()
Jun 23 2019, 8:08 PM · Okular
davidhurka added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Not sure, but that one looks like the inductive stylus I once had. (That one worked pretty bad.)

Jun 23 2019, 7:27 PM · Okular
davidhurka retitled D21271: Improve documentation of TextEntity stuff from [WIP] Improve documentation of TextEntity stuff to Improve documentation of TextEntity stuff.
Jun 23 2019, 5:35 PM · Okular
davidhurka added a comment to D21271: Improve documentation of TextEntity stuff.

You don't have a committer account, right?

Jun 23 2019, 5:20 PM · Okular
davidhurka added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

AFAIK these events are only generated for inductive styluses, because a capacitive touchscreen can’t detect proximity with acceptable quality, even less for a stylus.

Jun 23 2019, 4:45 PM · Okular
davidhurka added a comment to D21759: Hold zoom center below center/mouse position.

Hi @aacid,
thanks for testing,

Also it doesn't work? or not how i would expect it?

I'm doing ctrl+wheel zoom here with the mouse over the a and ends up being over the p.

I was expecting it to end up being over the a too?

to begin the width of the document is smaller than the viewport with, so we have no horizontal scrollbar and we can not make a horizontal scrolling.

Sure, but at some point there will be a scrollbar, and at that point you can make it scroll to the "correct", position, no?

Jun 23 2019, 2:19 PM · Okular

Jun 22 2019

davidhurka added a comment to D21196: [RFC] Move Continuous option to View Mode submenu.

Would it make sense to request icons for the view modes?

  • For Single Page, something like tool_pagelayout would be nice. (It’s just a page, i. e. a rectangle with a folded corner.)
  • Facing Pages would have two pages.
  • Overview would have 2 or 3 pages, arranged like the discs in save-all. Arranging in a horizontal row would be misleading if the user configured the Overview column count.
Jun 22 2019, 10:24 PM · Documentation, Okular
davidhurka updated the diff for D21196: [RFC] Move Continuous option to View Mode submenu.
  • Replace function-like macro by lambda, like done for Color Mode menu in D21195

View mode actions are now organized in QActionGroup * PageView::viewModeActionGroup.
(Uhm, ignore the last commit)

Jun 22 2019, 9:55 PM · Documentation, Okular
davidhurka updated the diff for D21196: [RFC] Move Continuous option to View Mode submenu.
  • Replace function-like macro by lambda, like done for Color Mode menu in D21195
Jun 22 2019, 9:52 PM · Documentation, Okular
davidhurka added inline comments to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 22 2019, 8:27 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I tried it by only adding the actions to it and it does not work, no menu is shown. Adding the signal connection is also not enough. After that I gave up for now (I am lazy). But I think it needs to be a little more user-friendly.

Jun 22 2019, 7:45 PM · Okular
davidhurka added a comment to D18719: [WIP]Create context menu entry to rotate individual pages.

Sometimes I think it makes sense to move the context menu to the widget it belongs to. That widget would accept the context menu event, and create a context menu. Basically the same context menu that is currently created by Part.

Jun 22 2019, 7:01 PM · Okular
davidhurka updated the diff for D21266: Improve documentation of area classes.
  • Small improvements based on latest comments by Albert.
Jun 22 2019, 6:15 PM · Okular
davidhurka added a comment to D21266: Improve documentation of area classes.

Thanks for marking the typos.

Jun 22 2019, 6:14 PM · Okular
davidhurka added inline comments to D21271: Improve documentation of TextEntity stuff.
Jun 22 2019, 5:35 PM · Okular
davidhurka updated the diff for D21271: Improve documentation of TextEntity stuff.
  • Remove comment on vertical text, remove the word concatenate
  • Don’t export text entity reordering functions
Jun 22 2019, 5:34 PM · Okular
davidhurka updated the diff for D21281: [WIP] Write Documentation for Okular::Part.

Left some changes lying arround, here they are.
Rename m_topMessage, improve callflow description, improve fitWindowToPage description.

Jun 22 2019, 4:49 PM · Okular
davidhurka added inline comments to D21281: [WIP] Write Documentation for Okular::Part.
Jun 22 2019, 3:59 PM · Okular

Jun 21 2019

davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

To be more clear, I think that the code below should provide a default working action menu (basically as it was before, but customizable if necessary):

d->aMouseModeMenu = new ToggleActionMenu( this );
d->aMouseModeMenu->addAction( d->aMouseSelect );
d->aMouseModeMenu->addAction( d->aMouseTextSelect );
d->aMouseModeMenu->addAction( d->aMouseTableSelect );
Jun 21 2019, 7:12 PM · Okular
davidhurka requested review of D21971: Replace ToolAction by ToggleActionMenu.
Jun 21 2019, 7:08 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I could imagine to add a parameter ToggleActionMenu::MenuLogic to the constructor.

enum MenuLogic {
    DefaultLogic = 0x0,
    /**
     * Automatically makes the triggered action the default action, even if in a submenu.
     * When a toolbar button is constructed, the default action is set to the first checked action in the menu.
     * setDefaultAction() provides a fallback if no action is checked.
     */
    ImplicitDefaultAction = 0x1
};
Jun 21 2019, 4:41 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Fix parent object QWidget to QObject, remove redundant function call
Jun 21 2019, 4:27 PM · Okular
davidhurka added a comment to D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.

I have tested this patch and added some inline comments. It seems to me that ToggleActionMenu requires way more external code to make it work, compared to ToolAction, which is quite automated. I think that some things could be made default in ToggleActionMenu, and some aspect hidden as well e.g. manage the QActionGroup internally without having the user have to manage it and set the action eveytime.

Jun 21 2019, 4:22 PM · Okular

Jun 20 2019

davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Set popup mode of Color Mode menu, because ToggleActionMenu respects it now.
Jun 20 2019, 3:45 PM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 20 2019, 3:30 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Select correct default action at startup
  • Describe name ToggleActionMenu
  • Let the toolbar buttons respect menu properties like enabled state, and add the menu to updateActionStates().
  • Make popup mode configurable correctly, and set popup mode of mouse mode menu.
Jun 20 2019, 3:30 PM · Okular
davidhurka added a dependency for D21195: [RFC] Create a Change Colors menu (with toolbar button): D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 20 2019, 11:33 AM · Okular
davidhurka added a dependent revision for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”: D21195: [RFC] Create a Change Colors menu (with toolbar button).
Jun 20 2019, 11:33 AM · Okular
davidhurka updated the test plan for D21195: [RFC] Create a Change Colors menu (with toolbar button).
Jun 20 2019, 11:26 AM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

I would recommend making the toolbar button show the text of the actual color change mode that's currently active, much like how the selection tools toolbar button currently does. Otherwise you won't know which mode it will invoke.

Jun 20 2019, 11:01 AM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
Jun 20 2019, 10:51 AM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Rebase on D21755, to use ToggleActionMenu.
  • Show the last used color mode on the toolbar button of the Color Mode menu. (Normal Colors is a radio option now, like the other color modes.)
  • Add color mode menu to updateActionState().
Jun 20 2019, 10:49 AM · Okular
davidhurka updated the summary of D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 20 2019, 10:46 AM · Okular

Jun 17 2019

davidhurka added a comment to D15580: New annotation toolbar.

Don’t have UI feedback that asks for action already in this patch. :)

Jun 17 2019, 7:16 PM · Documentation, Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Jun 17 2019, 6:46 PM · Okular
davidhurka updated the diff for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Add license headers
Jun 17 2019, 5:17 PM · Okular
davidhurka updated the test plan for D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”.
Jun 17 2019, 5:01 PM · Okular