- User Since
- Sep 6 2018, 3:14 PM (36 w, 6 d)
Probably it should be described how dropped URLs are handled in general? Sometimes the Part uses them and wildly opens files, sometimes not.
- Part::Part() 'QObject is a widget' -> 'QObject is an object'
- Document some D-Bus methods and Part signals, minor improvements in Document
So I will keep it this way.
Mon, May 20
- NormalizedPoint: Revert some stuff and mention mouse click events
Should the section “Coordinate System” of NormalizedPoint mention the “Trimmed Margins” feature? To prevent that someone sloppily codes a feature, which draws something on the page and fails if Trim Margins is active.
Sun, May 19
- Fix typos spotted by yurchor
- Fix typos spotted by Albert
Sat, May 18
Didn’t get far yet. Much information is visible in the source code, but what should I put into the class/member documentation, and what is clear just because it’s a Part?
TextPagePrivate::correctTextOrder() calls some complex functions, which are yet undocumented. Interesting stuff is happening in them, so they should get some documentation. I added their prototypes to core/textpage_p.h, so I can add documentation to them.
Fri, May 17
This is part of my goal to understand how TextEntity reordering works. There will probably be more patches like this soon.
Wed, May 15
I have figured out, what was going on in the QToolButton.
- Toolbar button finally shows the intended menu
- Add icon for Configure... action
- Corrected action-slot connections
- Named enable/disable action "Change Colors" again, looks better in the toolbar
I have added CheckableActionMenu, which cuts the default action connection between the KActionMenu itself and the toolbar button. Now it is possible to make the toolbar button checkable, but not the submenu.
Removed checkbox from submenu, but toolbar button invents other menu structure
Tue, May 14
The lambda looks much better, but it uses still int as action data, not Okular::SettingsCore::EnumRenderMode::type, which would make more sense. Is it possible to put Okular::SettingsCore::EnumRenderMode::type into the action’s QVariant? It didn’t work because I couldn’t register it as metatype.
- Renamed the menu entries to Color Mode and Enable Color Changing
- Use lambda function instead of function-like macro
Mon, May 13
Nate suggested almost exactly this patch in Bug 407326. But instead of hiding Continuous when accessed from the menubar, I moved Continuous completely to the View Mode submenu.
Okular does not follow the KDELibs coding style, so I tried to follow the existing coding style. Maybe I didn’t understand something right, if so, please correct me.
Wed, May 8
Tue, May 7
I suggested this in D18744#441906.
Sun, Apr 28
How about the following approach (not tested)? This way, other parameters (like nameddest) wouldn’t break it and can be added later.
Thu, Apr 25
Isn’t there a coding convention against non-ascii symbols in source code?
Apr 22 2019
Apr 1 2019
Mar 25 2019
Mar 11 2019
Mar 6 2019
After reading some Wikipedia, I can say:
- Checkmarks use luma (NTSC)
- Your approach uses luma (sRGB)
- QColor::lightness() uses lightness (HSL-bi-hexcone)
Erm, my Okular 1.6.2 already does this, just with another threshold. Below value() = 129, the text (and the header) become white, above value() = 128, they become black.
Mar 5 2019
Isn’t auto a bit confusing as item type? A beginner like me wouldn’t understand that.
Mar 4 2019
Joining KDE would make it easy to offer up-to-date packages to KDE Neon users, right?
Mar 2 2019
Feb 27 2019
Feb 26 2019
You have little conversation output, and I have little understanding of QEvent.
Feb 21 2019
Up and down arrows are equivalent to arrow key behavior, both in the view area and the PageNumberEdit. It also fits better to documents with RTL page layout (mangas) (if there are such documents).
Feb 16 2019
Feb 5 2019
Feb 4 2019
That would be Add Panel -> Application Menu Bar, right?
Feb 2 2019
There could be a menu item “Help...”, which explains all the terms like Panel, Widget, Launcher, Task Manager, System Tray,... It could just open Help Center -> Plasma Manual -> Using Plasma (-> The Panel). There would be a screenshot like this:
Even in my mother tongue I didn’t know what exactly the “Systemabschnitt der Kontrollleiste” (System Tray) is. Everything could be related to the system...
Jan 31 2019
Jan 22 2019
Maybe these questions would help me to imagine which people I would meet on KDE events:
Additionally: General/special interests.
Jan 19 2019
I think this is okay for graphic areas, while the color scheme is good for generic GUI elements (text areas without graphics).
Yes, but it also uses "View Background", while the background color of a PDF file can be different.
Picture with search (find bar, thumbnails panel) in PDF from https://www.dpdhl.com/content/dam/dpdhl/en/media-center/investors/documents/annual-reports/DPDHL_2017_Annual_Report.pdf
How about just inverting the color?
Jan 15 2019
From a user point of view, KiCad could benefit from a KDE user interface. It’s a well known and probably great EDA tool, but every time I try to get started, the bad UI stops me. (But that’s common for almost all EDA tools I know.) (Yes, it’s UI could also be great with wxWidgets, which it uses currently.)