davidhurka (David Hurka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2018, 3:14 PM (100 w, 4 d)
Availability
Available

Recent Activity

Sat, Jul 11

davidhurka abandoned D29163: RFC: Add document-replace icon (Like for Overwrite action).

Moved to https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/18

Sat, Jul 11, 10:10 PM · Frameworks

Jun 3 2020

davidhurka committed R223:cb81a9dccf5f: Move Fullscreen action from Settings to View menu in docbook (authored by davidhurka).
Move Fullscreen action from Settings to View menu in docbook
Jun 3 2020, 10:58 AM

May 5 2020

davidhurka added a comment to D29418: Strip trailing binary operators.

The problem is that the original author wanted input errors to be visible while typing.

May 5 2020, 5:37 PM · KDE Edu
davidhurka added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.
In T10034#229198, @mart wrote:

I feel honored that you are considering Kirigami for rewriting parts of the application UI, tough I know how hugely complex that is, and how much QtQuick is still subpar for many desktop-specific things unfortunately.

May I add a question here, a bit offtopic? It appeared to me that there is a general trend towards QtQuick because a) it looks great and b) tends to be touch and mobile friendly. While I disagree with a, I wonder whether an inherently complex UI like that of FreeCad would benefit from b. KXmlGui is great for customizing the toolbars and QDockWidgets are nice to rearrange the UI components on the screen. While I have nothing to say about the technical implemenation, would/could these features (which FreeCAD already has) be kept with QtQuick?

May 5 2020, 9:35 AM · KDE Promo
davidhurka added a comment to D29418: Strip trailing binary operators.

Wouldn’t it be possible to check whether there are trailing binary operators, and then append something that reliably causes a syntax error in Mathematica?

May 5 2020, 7:15 AM · KDE Edu
davidhurka added a comment to D29418: Strip trailing binary operators.

Thanks for working on this. While this is an improvement, this solution is not what I had in mind. I think if the user enters a syntactically invalid expression, it should be recognized as syntax error.

May 5 2020, 7:04 AM · KDE Edu

Apr 29 2020

davidhurka added a comment to D29163: RFC: Add document-replace icon (Like for Overwrite action).

Then I will remove the border. I think it looks slightly better, because the bottom-left corner is visible this way; and the 16px version looks to chunky otherwise.

Apr 29 2020, 8:21 AM · Frameworks
davidhurka added a comment to D29027: Move document corner fold to top right in two icons.

Is it possible to land this without arc? I can’t get arc running on my current system. :(

Apr 29 2020, 8:15 AM · Frameworks

Apr 25 2020

davidhurka committed R223:bacc39f8705e: Merge remote-tracking branch 'origin_invent/release/20.04' (authored by davidhurka).
Merge remote-tracking branch 'origin_invent/release/20.04'
Apr 25 2020, 1:27 PM
davidhurka committed R223:8fdfeeb6c7fe: Fix action collection names of Facing Pages [Center Fist Page] and Overview (authored by davidhurka).
Fix action collection names of Facing Pages [Center Fist Page] and Overview
Apr 25 2020, 1:20 PM

Apr 24 2020

davidhurka updated the summary of D29163: RFC: Add document-replace icon (Like for Overwrite action).
Apr 24 2020, 8:22 PM · Frameworks
davidhurka planned changes to D29163: RFC: Add document-replace icon (Like for Overwrite action).

The current state is as follows:


Apr 24 2020, 8:20 PM · Frameworks
davidhurka requested review of D29163: RFC: Add document-replace icon (Like for Overwrite action).
Apr 24 2020, 8:12 PM · Frameworks

Apr 21 2020

davidhurka added a comment to D29027: Move document corner fold to top right in two icons.

I looked at the other gnumeric icons. Those which are not a symlink use fixed colors, while the linked icons use Highlight. I don’t see the point to use fixed colors.

Apr 21 2020, 9:42 AM · Frameworks

Apr 20 2020

davidhurka updated the summary of D29027: Move document corner fold to top right in two icons.
Apr 20 2020, 9:25 PM · Frameworks
davidhurka updated the diff for D29027: Move document corner fold to top right in two icons.
  • Use Highlight instead of ButtonFocus, Noah already decided that somewhere else
Apr 20 2020, 9:25 PM · Frameworks
davidhurka updated the summary of D29027: Move document corner fold to top right in two icons.
Apr 20 2020, 9:18 PM · Frameworks
davidhurka added a reviewer for D29027: Move document corner fold to top right in two icons: ndavis.
Apr 20 2020, 9:14 PM · Frameworks
davidhurka requested review of D29027: Move document corner fold to top right in two icons.
Apr 20 2020, 9:12 PM · Frameworks

Apr 19 2020

davidhurka abandoned D21195: [RFC] Create a Change Colors menu (with toolbar button).

Merge request at https://invent.kde.org/kde/okular/-/merge_requests/141

Apr 19 2020, 5:12 PM · Okular

Apr 16 2020

davidhurka added a comment to T11579: Unify navigation through sidebar categories/views.

Yeah, show me how to use QDockWidget in a KPart! I tried it, but found no way.

Apr 16 2020, 10:09 PM · Goal: Consistency, KDE Human Interface Guidelines, VDG

Apr 11 2020

davidhurka added a comment to T11093: Improve Consistency across the Board.

Music applications. Currently, KDE has four of them: Amarok, Elisa, JuK and Elisa.

That confuses me. I read that Amarok is unmaintained (well, it is still using Qt4 and KDElibs...), JuK is more a music management application than a music player.

Apr 11 2020, 10:06 PM · Goal: Consistency, Goal Setting 2019

Apr 7 2020

davidhurka added a comment to D27557: Auto-generate 24px monochrome icons.
Apr 7 2020, 2:05 PM · Frameworks

Apr 6 2020

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

@ngraham How’s your progress with the bash script? I’m currently trying to understand bash syntax. Maybe I can do it, if you don’t have done it already.

Apr 6 2020, 9:36 PM · VDG, Frameworks
davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

Now we have less than 130 icons which are different in icons/ and icons-dark/, and less than 100 icons which we should keep as dark version. Maybe we can keep even less.

Apr 6 2020, 3:35 PM · VDG, Frameworks

Apr 5 2020

davidhurka committed R266:07487651e13c: Remove border from format-border-set-* icons (authored by davidhurka).
Remove border from format-border-set-* icons
Apr 5 2020, 11:23 AM
davidhurka closed D28561: Remove border from format-border-set-* icons.
Apr 5 2020, 11:23 AM · Frameworks
davidhurka updated the summary of D28561: Remove border from format-border-set-* icons.
Apr 5 2020, 10:45 AM · Frameworks
davidhurka updated the diff for D28561: Remove border from format-border-set-* icons.
  • Remove border elements in 22px versions of format-border-*
Apr 5 2020, 10:43 AM · Frameworks

Apr 4 2020

davidhurka added a comment to D28561: Remove border from format-border-set-* icons.

There are 22px versions of these icons. They passed the auto-generation, because they use a different approach. They have a border, but it is not in ViewBackground, but in Text with transparency 0.1. Should I add such a border to the 16px version, or remove it in the 22px version?

Apr 4 2020, 5:21 PM · Frameworks
davidhurka updated the summary of D28561: Remove border from format-border-set-* icons.
Apr 4 2020, 2:56 PM · Frameworks
davidhurka requested review of D28561: Remove border from format-border-set-* icons.
Apr 4 2020, 2:51 PM · Frameworks
davidhurka abandoned D28553: Rename stylesheet color ButtonFocus -> Highlight.

Ok, then I’ll let you do it.

Apr 4 2020, 12:48 PM · Frameworks
davidhurka added a comment to D28553: Rename stylesheet color ButtonFocus -> Highlight.

Cuttlefish (Ubuntu release)?

Apr 4 2020, 12:22 PM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

@ndavis commited (excerpt):

diff --git a/icons-dark/actions/22/document-export-ocal.svg b/icons-dark/actions/22/document-export-ocal.svg
index 4bfca303..ace4fe41 120000
--- a/icons-dark/actions/22/document-export-ocal.svg
+++ b/icons-dark/actions/22/document-export-ocal.svg
@@ -1 +1 @@
-/home/david/kde/breeze-icons/icons-dark/actions/22/document-export.svg
\ No newline at end of file
+document-export.svg
\ No newline at end of file
Apr 4 2020, 11:32 AM · Frameworks
davidhurka requested review of D28553: Rename stylesheet color ButtonFocus -> Highlight.
Apr 4 2020, 10:24 AM · Frameworks
davidhurka closed T12806: Move corner fold to the top-right for all document icons as Resolved by committing R266:2808396a7bb8: Move corner fold to top right in 24 icons.
Apr 4 2020, 9:55 AM · VDG
davidhurka committed R266:2808396a7bb8: Move corner fold to top right in 24 icons (authored by davidhurka).
Move corner fold to top right in 24 icons
Apr 4 2020, 9:55 AM
davidhurka closed D28203: Move corner fold to top right in 24 icons.
Apr 4 2020, 9:55 AM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

I created revision D28204 accidentally when I tried to update this revision. That made my initial commit point to D28204 instead of D28203, so I couldn’t tell arc to land this revision. So I made git commit --amend on the initial commit to change the revision number, and rebased the other commits on the new commit. Phabricator UI tells me that the patch content stayed identical, so I land this now.

Apr 4 2020, 9:54 AM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.

Rebase on an initial commit which points to D28203, not D28204.

Apr 4 2020, 9:50 AM · Frameworks
davidhurka committed R266:aff4a3e23d92: Make find-location show a magnifier on a map, to be different to mark-location (authored by davidhurka).
Make find-location show a magnifier on a map, to be different to mark-location
Apr 4 2020, 9:26 AM
davidhurka closed D27983: Make find-location show a magnifier on a map, to be different to mark-location.
Apr 4 2020, 9:26 AM · Frameworks
davidhurka committed R230:de1e2fd97aae: Add myself (davidhurka) to relicensecheck.pl (authored by davidhurka).
Add myself (davidhurka) to relicensecheck.pl
Apr 4 2020, 9:22 AM
davidhurka closed D28437: Add myself (davidhurka) to relicensecheck.pl.
Apr 4 2020, 9:22 AM

Mar 30 2020

davidhurka updated the diff for D28437: Add myself (davidhurka) to relicensecheck.pl.

Where can I verify the SSH fingerprint of git.kde.org?

Mar 30 2020, 2:11 PM
davidhurka requested review of D28437: Add myself (davidhurka) to relicensecheck.pl.
Mar 30 2020, 2:10 PM

Mar 28 2020

davidhurka requested review of D28203: Move corner fold to top right in 24 icons.

One potentially important thing: See inline comment.

Mar 28 2020, 3:37 PM · Frameworks

Mar 27 2020

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it doesn’t look intended.

Mar 27 2020, 10:47 PM · VDG, Frameworks
davidhurka updated the diff for D28362: Fix stylesheet linking in 8 icons.
  • Fix spelling
Mar 27 2020, 8:24 PM · Frameworks
davidhurka updated the diff for D28362: Fix stylesheet linking in 8 icons.

@ndavis

Mar 27 2020, 8:21 PM · Frameworks
davidhurka requested review of D28362: Fix stylesheet linking in 8 icons.
Mar 27 2020, 8:20 PM · Frameworks

Mar 26 2020

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

By the way I looked through the 319 icons.

  • Some icons actually need fixing in icons/.
  • The emblem rating is blue in icons-dark/, because it links to another class. We can:
    • Leave rating in icons-dark/
    • Change the light version to be blue too
  • (Probably) All mimetype icons in size 32px and 64px look significantly different in light and dark
Mar 26 2020, 11:55 PM · VDG, Frameworks
davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

I have to take some short notes here.

Mar 26 2020, 11:49 PM · VDG, Frameworks
davidhurka requested review of D28323: Fix some stylesheet colors in 2 icon files.
Mar 26 2020, 10:58 PM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

I would need a developer account to land this. Same for D27983 I assume?

Mar 26 2020, 6:07 PM · Frameworks

Mar 25 2020

davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

Can you write a bash script which copies the icon files to icons-dark/ and substitutes the colors? Apparently you know how to do that, my bash skills are a bit worse.

Mar 25 2020, 11:11 PM · VDG, Frameworks
davidhurka added a comment to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.

I have created montages of the different icons. The original files to the left, the generated to the right. (Hover the images to see the file path)

Mar 25 2020, 11:09 PM · VDG, Frameworks
davidhurka added inline comments to D28203: Move corner fold to top right in 24 icons.
Mar 25 2020, 6:01 PM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.
  • Give **/acrobat.svg its fixed color back
Mar 25 2020, 6:01 PM · Frameworks
davidhurka added inline comments to D28203: Move corner fold to top right in 24 icons.
Mar 25 2020, 3:28 PM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.
  • Fix symlinks: make relative
Mar 25 2020, 3:23 PM · Frameworks

Mar 24 2020

davidhurka added projects to T12855: [Breeze Icons] Get rid of redundancy in icons-dark/: Frameworks, VDG.
Mar 24 2020, 10:22 PM · VDG, Frameworks
davidhurka created T12855: [Breeze Icons] Get rid of redundancy in icons-dark/.
Mar 24 2020, 10:20 PM · VDG, Frameworks

Mar 23 2020

davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not in 22px. What are 12px and 32px good for?

Mar 23 2020, 6:48 PM · Frameworks
davidhurka updated the diff for D28203: Move corner fold to top right in 24 icons.
  • link 32px document-preview-archive and document-preview
  • Move corner fold to top for 6 32px icons
Mar 23 2020, 6:48 PM · Frameworks
davidhurka abandoned D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).

garg.

Mar 23 2020, 6:45 PM · Frameworks
davidhurka updated the diff for D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).
  • link 32px document-preview-archive and document-preview
  • Move corner fold to top for 6 32px icons
Mar 23 2020, 6:44 PM · Frameworks
davidhurka added a comment to D28203: Move corner fold to top right in 24 icons.

I understand the concerns. It looks unbalanced. But these icons also look unbalanced now: acrobat, filename-title-amarok.

Mar 23 2020, 5:08 PM · Frameworks

Mar 22 2020

davidhurka updated the task description for T12806: Move corner fold to the top-right for all document icons.
Mar 22 2020, 3:30 PM · VDG
davidhurka updated the summary of D28203: Move corner fold to top right in 24 icons.
Mar 22 2020, 3:29 PM · Frameworks
davidhurka added a reviewer for D28203: Move corner fold to top right in 24 icons: VDG.
Mar 22 2020, 3:29 PM · Frameworks
davidhurka abandoned D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).

Whoops duplicate.

Mar 22 2020, 3:26 PM · Frameworks
davidhurka requested review of D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light).
Mar 22 2020, 3:24 PM · Frameworks
davidhurka requested review of D28203: Move corner fold to top right in 24 icons.
Mar 22 2020, 3:24 PM · Frameworks

Mar 16 2020

davidhurka committed R223:2bee66d22580: Set buddy and alignment for some QLabels in configuration dialogs (authored by davidhurka).
Set buddy and alignment for some QLabels in configuration dialogs
Mar 16 2020, 10:31 PM
davidhurka added a comment to T12825: Need icons for Okular color modes.

I made some experiments.

  1. color-mode-black-white
  2. color-mode-change-dark-light
  3. color-mode-hue-shift-240
  4. color-mode-hue-shift-120
  5. paper-color
  6. color-mode-invert-text
  7. color-mode-invert-image
  8. Alternative to color-mode-invert-image
  9. Alternative to color-mode-invert-image
  10. color-mode-invert
  11. Alternative to color-mode-invert
  12. Alternative to color-mode-invert-text
Mar 16 2020, 3:56 PM · Okular, VDG
davidhurka created T12825: Need icons for Okular color modes.
Mar 16 2020, 12:13 AM · Okular, VDG

Mar 15 2020

davidhurka committed R223:6c5244cae3ea: Add new page layout icons to all view mode actions (authored by davidhurka).
Add new page layout icons to all view mode actions
Mar 15 2020, 3:41 PM

Mar 13 2020

davidhurka added a comment to T11950: Reduce the pain of working on monochrome Breeze icons.

This is how my source file for find-location (D27983) looks in inkscape.

Mar 13 2020, 7:36 PM · Frameworks, VDG

Mar 11 2020

davidhurka updated the test plan for D27983: Make find-location show a magnifier on a map, to be different to mark-location.
Mar 11 2020, 2:48 PM · Frameworks
davidhurka requested review of D27983: Make find-location show a magnifier on a map, to be different to mark-location.
Mar 11 2020, 2:46 PM · Frameworks

Mar 10 2020

davidhurka created T12806: Move corner fold to the top-right for all document icons.
Mar 10 2020, 11:51 PM · VDG
davidhurka added a comment to T11950: Reduce the pain of working on monochrome Breeze icons.

Whoops, this Task went past me while I created breeze-icon-cleaner. What a pity!

Mar 10 2020, 11:39 PM · Frameworks, VDG

Feb 22 2020

davidhurka added a comment to D15580: New annotation toolbar.

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

It’s okay to me that you write the autotests. If you wish, I could do that instead.

I am new to autotests, so I will have to learn how to do that. I am also unsure about what should be tested. The ToggleActionMenu itself, or its behaviour in Okular?

davidhurka (David Hurka)

User

Feb 22 2020, 6:31 PM · Documentation, Okular

Feb 4 2020

davidhurka added a comment to D15580: New annotation toolbar.

aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon.

Feb 4 2020, 3:11 PM · Documentation, Okular

Jan 25 2020

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Do modifications suggested by @simgunz
Jan 25 2020, 6:47 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

I’m getting a bit dizy about the repository. I thought I merged master, but apparently I made a mistake. Thanks for pointing me along the right way.

Jan 25 2020, 6:46 PM · Okular
davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Merge branch 'master' into create-configurable-toggleactionmenu
Jan 25 2020, 6:26 PM · Okular

Jan 18 2020

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.

pong :) Sorry, I wasn’t available for the last weeks.

Jan 18 2020, 6:55 PM · Okular

Nov 30 2019

davidhurka added a comment to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

Hey Yegor, I like this idea. I’m not sure what you mean with adding visual controls.

Nov 30 2019, 6:25 PM · Okular

Nov 23 2019

davidhurka added a comment to D25484: Enable closing a tab by middle click.

To prevent some accidental middle-mouse-clicks on the tab bar, we could lock the cursor while middle-mouse-button-zoom.

Nov 23 2019, 7:16 PM · Okular

Nov 18 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Sorry, what is it that you'd like my input on?

Nov 18 2019, 9:38 PM · Okular

Nov 11 2019

davidhurka added a comment to T10997: Improve check box design.
In T10997#207761, @mglb wrote:

Color scheme issue. Highlight background color is used. I could change it to something like background color of selected item in unfocused sidebar, but then it won't look that good in light Breeze.

We need to change the colorschemes anyway, so think about how colorscheme colors should be used based on semantics rather than what the actual colors are.

Nov 11 2019, 2:48 PM · VDG, Breeze

Nov 10 2019

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum
Nov 10 2019, 8:19 PM · Okular
davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)

Yes, but how? It can’t simply be forbidden in the constructor argument list. Remove it from the body of the constructor, so KActionMenu is set to MenuButtonPopup instead?

Create a new enum ToggleActionMenu::ToolButtonPopupMode with only DelayedPopup and MenuButtonPopup.

Nov 10 2019, 8:06 PM · Okular
davidhurka added a comment to T10997: Improve check box design.

There's also an option for gray background, like "checked" tool buttons. I think it would be more consistent.

Current look:

Checked gray:

Nov 10 2019, 6:17 PM · VDG, Breeze

Nov 9 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To sum it up, if I understand correctly:

  • we can remove InstantPopup given that we can use KActionMenu or KSelectAction to provide that use case (so no need to raise exceptions)
Nov 9 2019, 9:06 PM · Okular

Nov 7 2019

davidhurka updated the diff for D21971: Replace ToolAction by ToggleActionMenu.
  • Try to improve documentation, exspecially how to set the default action
Nov 7 2019, 12:07 AM · Okular

Nov 6 2019

davidhurka added a comment to D21971: Replace ToolAction by ToggleActionMenu.

To answer your second comment first, and to be sure you understand everything how I understand you understand it...

I also would like to get rid of DefaultLogic and just use ImplicitDefaultAction, but I am not sure if this creates problem when ToggleActionMenu is placed in a menu.

No, creates no problem.

Nov 6 2019, 11:53 PM · Okular