davidhurka (David Hurka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 6 2018, 3:14 PM (36 w, 6 d)
Availability
Available

Recent Activity

Today

davidhurka added a comment to D21281: [RFC] Write a bit Documentation for Part and PageView.

Probably it should be described how dropped URLs are handled in general? Sometimes the Part uses them and wildly opens files, sometimes not.

Wed, May 22, 7:02 PM · Okular
davidhurka updated the diff for D21281: [RFC] Write a bit Documentation for Part and PageView.
  • Part::Part() 'QObject is a widget' -> 'QObject is an object'
  • Document some D-Bus methods and Part signals, minor improvements in Document
Wed, May 22, 6:48 PM · Okular

Yesterday

davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

So I will keep it this way.

Tue, May 21, 10:17 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Tue, May 21, 10:16 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

+1 for this. I think it makes sense. Trying it out, I like it a lot.

Tue, May 21, 9:53 PM · Okular
davidhurka added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
Tue, May 21, 12:24 PM · Okular

Mon, May 20

davidhurka updated the diff for D21266: [WIP] Improve documentation of area classes.
  • NormalizedPoint: Revert some stuff and mention mouse click events
Mon, May 20, 6:41 PM · Okular
davidhurka added a comment to D21266: [WIP] Improve documentation of area classes.

Should the section “Coordinate System” of NormalizedPoint mention the “Trimmed Margins” feature? To prevent that someone sloppily codes a feature, which draws something on the page and fails if Trim Margins is active.

Mon, May 20, 6:40 PM · Okular
davidhurka added a comment to D21281: [RFC] Write a bit Documentation for Part and PageView.

Is there some more KParts literature? I could find KParts on api.kde.org and the tutorials on community.kde.org, but couldn’t really transfer that to Okular.

Why you couldn't transfer it to okular? If you don't say what you don't understand is hard to explain *everything*

Mon, May 20, 4:18 PM · Okular

Sun, May 19

davidhurka added inline comments to D21271: [WIP] Improve documentation of TextEntity stuff.
Sun, May 19, 9:31 PM · Okular
davidhurka updated the diff for D21271: [WIP] Improve documentation of TextEntity stuff.
  • Fix typos spotted by yurchor
  • Fix typos spotted by Albert
Sun, May 19, 9:00 PM · Okular

Sat, May 18

davidhurka added a comment to D21281: [RFC] Write a bit Documentation for Part and PageView.

Didn’t get far yet. Much information is visible in the source code, but what should I put into the class/member documentation, and what is clear just because it’s a Part?

Sat, May 18, 11:57 PM · Okular
davidhurka requested review of D21281: [RFC] Write a bit Documentation for Part and PageView.
Sat, May 18, 11:52 PM · Okular
davidhurka added a comment to D21271: [WIP] Improve documentation of TextEntity stuff.

TextPagePrivate::correctTextOrder() calls some complex functions, which are yet undocumented. Interesting stuff is happening in them, so they should get some documentation. I added their prototypes to core/textpage_p.h, so I can add documentation to them.

Sat, May 18, 12:47 PM · Okular
davidhurka requested review of D21271: [WIP] Improve documentation of TextEntity stuff.
Sat, May 18, 12:26 PM · Okular

Fri, May 17

davidhurka added a comment to D21266: [WIP] Improve documentation of area classes.

This is part of my goal to understand how TextEntity reordering works. There will probably be more patches like this soon.

Fri, May 17, 11:46 PM · Okular
davidhurka requested review of D21266: [WIP] Improve documentation of area classes.
Fri, May 17, 11:06 PM · Okular

Wed, May 15

davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

I have figured out, what was going on in the QToolButton.

Wed, May 15, 4:38 PM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Toolbar button finally shows the intended menu
  • Add icon for Configure... action
  • Corrected action-slot connections
  • Named enable/disable action "Change Colors" again, looks better in the toolbar
Wed, May 15, 4:09 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

I have added CheckableActionMenu, which cuts the default action connection between the KActionMenu itself and the toolbar button. Now it is possible to make the toolbar button checkable, but not the submenu.

Wed, May 15, 3:16 PM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).

Removed checkbox from submenu, but toolbar button invents other menu structure

Wed, May 15, 2:53 PM · Okular

Tue, May 14

davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

The lambda looks much better, but it uses still int as action data, not Okular::SettingsCore::EnumRenderMode::type, which would make more sense. Is it possible to put Okular::SettingsCore::EnumRenderMode::type into the action’s QVariant? It didn’t work because I couldn’t register it as metatype.

Tue, May 14, 11:51 PM · Okular
davidhurka updated the diff for D21195: [RFC] Create a Change Colors menu (with toolbar button).
  • Renamed the menu entries to Color Mode and Enable Color Changing
  • Use lambda function instead of function-like macro
Tue, May 14, 11:40 PM · Okular

Mon, May 13

davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

That menu is ultra hard to understand, it's a checked action + menu with an action with the same name inside that is also a checked action

Mon, May 13, 10:04 PM · Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Screenshots are appreciated when submitting patches that change or add UI elements. :)

https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

Mon, May 13, 6:48 PM · Okular
davidhurka added a comment to D21196: [RFC] Move Continuous option to View Mode submenu.

Nate suggested almost exactly this patch in Bug 407326. But instead of hiding Continuous when accessed from the menubar, I moved Continuous completely to the View Mode submenu.

Mon, May 13, 6:47 PM · Documentation, Okular
davidhurka added a comment to D21195: [RFC] Create a Change Colors menu (with toolbar button).

Okular does not follow the KDELibs coding style, so I tried to follow the existing coding style. Maybe I didn’t understand something right, if so, please correct me.

Mon, May 13, 6:36 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, May 13, 6:11 PM · Okular
davidhurka updated the summary of D21196: [RFC] Move Continuous option to View Mode submenu.
Mon, May 13, 6:04 PM · Documentation, Okular
davidhurka requested review of D21196: [RFC] Move Continuous option to View Mode submenu.
Mon, May 13, 5:56 PM · Documentation, Okular
davidhurka requested review of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, May 13, 5:47 PM · Okular

Wed, May 8

davidhurka added a reviewer for D21069: [RFC] Improve documentation of Document::setPageTextSelection(): Okular.
Wed, May 8, 7:48 PM · Okular

Tue, May 7

davidhurka added a comment to D21069: [RFC] Improve documentation of Document::setPageTextSelection().

I suggested this in D18744#441906.

Tue, May 7, 11:13 AM · Okular
davidhurka requested review of D21069: [RFC] Improve documentation of Document::setPageTextSelection().
Tue, May 7, 10:49 AM · Okular

Sun, Apr 28

davidhurka added a comment to D20868: Support '#page=<pagenum>' fragment to open at page <pagenum>.

How about the following approach (not tested)? This way, other parameters (like nameddest) wouldn’t break it and can be added later.

Sun, Apr 28, 12:24 PM · Okular

Thu, Apr 25

davidhurka added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Indeed, I thought about PDF alone (that’s my most pressing use case). In that case, should this combobox mention something like “only for PDF documents”?

Thu, Apr 25, 8:29 PM · Okular
davidhurka added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Isn’t there a coding convention against non-ascii symbols in source code?

Thu, Apr 25, 8:15 PM · Okular

Apr 22 2019

davidhurka added a comment to D19717: Search function fails to find phrases split over two lines.

It should work now, can you test it?

Apr 22 2019, 6:33 PM · Okular
davidhurka added a comment to D19717: Search function fails to find phrases split over two lines.

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D

Opinions?

The use case to insert a newline could be:
Someone is testing a LaTeX document, and searches for a passage from the source code (maybe some verbatim code).
One would just copy the passage in Kate and paste it into the search box in Okular.

Hmmmmm, I can treat things differently if there's a new line in the search box.

Or maybe I should find a way to treat spaces the same as newline chars.

I'll have to take a look in the compare function to see how it would handle, maybe compare alphanumeric only?

If I can't do that, I'll have to treat them differently.

Apr 22 2019, 1:23 PM · Okular
davidhurka added a comment to D19717: Search function fails to find phrases split over two lines.

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D

Opinions?

Apr 22 2019, 11:59 AM · Okular

Apr 1 2019

davidhurka added a comment to D18744: Add action in Edit menu to select the text on current page.

Do not delete area

Apr 1 2019, 9:28 PM · Documentation, Okular

Mar 25 2019

davidhurka added a comment to D18744: Add action in Edit menu to select the text on current page.

@aacid area is a RegularAreaRect object which is a QRect bounding the selected text. "area" is to be deleted in all the cases except the case in which it is not possible to delete it since "area" will not contain any text in it and hence it will be nullptr. (case: if text is empty string) and hence return is called instead of deleting the "area".

Mar 25 2019, 8:36 PM · Documentation, Okular

Mar 11 2019

davidhurka added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

There is also asteroidOS that is interesting. It's an open source system for smartwatch build with qt quick. Maybe some collaboration with plasma mobile and/or kde connect could be interesting.

Mar 11 2019, 8:57 AM · KDE Promo

Mar 6 2019

davidhurka added a comment to D19542: [WIP] Make pop-up note text visible whatever background color is.

After reading some Wikipedia, I can say:

  • Checkmarks use luma (NTSC)
  • Your approach uses luma (sRGB)
  • QColor::lightness() uses lightness (HSL-bi-hexcone)
Mar 6 2019, 2:35 PM · Okular
davidhurka added a comment to D19542: [WIP] Make pop-up note text visible whatever background color is.

Do you mean that the attached test case (text.pdf) works for you (the text in annotation window for the right blue pop-up note is visible)?

Mar 6 2019, 11:41 AM · Okular
davidhurka added a comment to D19542: [WIP] Make pop-up note text visible whatever background color is.

Erm, my Okular 1.6.2 already does this, just with another threshold. Below value() = 129, the text (and the header) become white, above value() = 128, they become black.

Mar 6 2019, 10:35 AM · Okular

Mar 5 2019

davidhurka added a comment to D19539: Replace some iterator loops by range-based for.

Isn’t auto a bit confusing as item type? A beginner like me wouldn’t understand that.

Mar 5 2019, 12:41 PM · Okular

Mar 4 2019

davidhurka added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

Joining KDE would make it easy to offer up-to-date packages to KDE Neon users, right?

Mar 4 2019, 2:18 PM · KDE Promo

Mar 2 2019

davidhurka added a comment to D19123: Added option to search for whole words only.

This works properly for most cases, but still, it has some limitations.
If searching for r on a text, and the text contains R$, the R will be found.
Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
I guess that's a good trade-off, but we can work to improve it, if wanted.

Mar 2 2019, 12:39 PM · Okular

Feb 27 2019

davidhurka added a comment to D19183: Use logically correct icon for direction arrows.

Isn't this broken when using a RTL layout?

Feb 27 2019, 1:38 PM · Okular

Feb 26 2019

davidhurka added a comment to D18816: Accept and ignore event.

You have little conversation output, and I have little understanding of QEvent.

Feb 26 2019, 10:59 PM · Okular

Feb 21 2019

davidhurka added a comment to D19183: Use logically correct icon for direction arrows.

Up and down arrows are equivalent to arrow key behavior, both in the view area and the PageNumberEdit. It also fits better to documents with RTL page layout (mangas) (if there are such documents).

Feb 21 2019, 12:19 PM · Okular

Feb 16 2019

davidhurka added a comment to D18744: Add action in Edit menu to select the text on current page.

Do not use Alt+Letter for a shortcut, it's bad.

Feb 16 2019, 8:48 PM · Documentation, Okular

Feb 5 2019

davidhurka added a comment to D18744: Add action in Edit menu to select the text on current page.

However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there?

Feb 5 2019, 8:43 PM · Documentation, Okular

Feb 4 2019

davidhurka added a comment to T10047: Guerilla UX testing: a GNOME switcher.

Yep, agreed. However Bob wasn't looking for a dashboard UI; he very explicitly wanted a "Dock" on the left.

with or without a top/finder bar?

That would be Add Panel -> Application Menu Bar, right?

Feb 4 2019, 8:55 PM · VDG, Plasma

Feb 2 2019

davidhurka added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

From a user point of view, KiCad could benefit from a KDE user interface. […]

Feb 2 2019, 8:45 PM · KDE Promo
davidhurka added a comment to T10047: Guerilla UX testing: a GNOME switcher.

There could be a menu item “Help...”, which explains all the terms like Panel, Widget, Launcher, Task Manager, System Tray,... It could just open Help Center -> Plasma Manual -> Using Plasma (-> The Panel). There would be a screenshot like this:


Even in my mother tongue I didn’t know what exactly the “Systemabschnitt der Kontrollleiste” (System Tray) is. Everything could be related to the system...

Feb 2 2019, 8:24 PM · VDG, Plasma
davidhurka added a comment to T10047: Guerilla UX testing: a GNOME switcher.
@ngraham wrote:
  • Bob right-clicks on empty area of panel and sees "Alternatives..." It does not occur to him to click on it.
Feb 2 2019, 7:47 PM · VDG, Plasma

Jan 31 2019

davidhurka added a comment to D18623: Add a new RenderMode in the accessibility settings: Use System Colors.

Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests.

Jan 31 2019, 5:10 PM · Okular

Jan 22 2019

davidhurka added a comment to T10107: Survey on diversity.

Maybe these questions would help me to imagine which people I would meet on KDE events:

Just for the sake of brainstorming (stupid/funny included): […] current country, political preferences, music preferences, movie preferences, book preferences, sport preferences, videogame preferences, number of pets and their species…

Additionally: General/special interests.

Jan 22 2019, 10:30 PM · KDE Promo

Jan 19 2019

davidhurka added a comment to D18238: Implements a new button on findbar that allows users to choose the color that highlights the text.

I'm not really sold either. No other app has this setting. It seems like one of the major reasons why we have a color scheme and color chooser system is precisely so individual apps don't have to implement features like these themselves.

I think this is okay for graphic areas, while the color scheme is good for generic GUI elements (text areas without graphics).

Kate uses the "Selection Background" color to highlight search results and it works okay.

Yes, but it also uses "View Background", while the background color of a PDF file can be different.
Picture with search (find bar, thumbnails panel) in PDF from https://www.dpdhl.com/content/dam/dpdhl/en/media-center/investors/documents/annual-reports/DPDHL_2017_Annual_Report.pdf
How about just inverting the color?

Jan 19 2019, 4:44 PM · Okular

Jan 15 2019

davidhurka added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

From a user point of view, KiCad could benefit from a KDE user interface. It’s a well known and probably great EDA tool, but every time I try to get started, the bad UI stops me. (But that’s common for almost all EDA tools I know.) (Yes, it’s UI could also be great with wxWidgets, which it uses currently.)

Jan 15 2019, 11:41 AM · KDE Promo

Oct 24 2018

davidhurka added a comment to D16345: Create new "Zoom to 100%" action.

I think, this action should be in the menu, under “Zoom in” and “Zoom out”. That’s the way I learn about available actions, when I customize my toolbars.

Oct 24 2018, 11:27 AM · Okular