nibags (Nibaldo González)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2017, 7:25 AM (116 w, 2 d)
Availability
Available

Recent Activity

Tue, Nov 5

nibags committed R216:467bea3525cc: LaTeX: fix backslash delimiter in some keywords (authored by nibags).
LaTeX: fix backslash delimiter in some keywords
Tue, Nov 5, 2:10 AM
nibags closed D25139: LaTeX: fix backslash delimiter in some keywords.
Tue, Nov 5, 2:10 AM · Frameworks, Kate
nibags updated the summary of D25139: LaTeX: fix backslash delimiter in some keywords.
Tue, Nov 5, 2:08 AM · Frameworks, Kate

Mon, Nov 4

nibags updated the summary of D25139: LaTeX: fix backslash delimiter in some keywords.
Mon, Nov 4, 8:23 AM · Frameworks, Kate
nibags requested review of D25139: LaTeX: fix backslash delimiter in some keywords.
Mon, Nov 4, 8:21 AM · Frameworks, Kate

Sat, Nov 2

nibags committed R216:5f0306281a95: VHDL: all keywords are insensitive (authored by nibags).
VHDL: all keywords are insensitive
Sat, Nov 2, 1:40 AM
nibags closed D25102: VHDL: all keywords are insensitive.
Sat, Nov 2, 1:39 AM · Frameworks, Kate

Fri, Nov 1

nibags committed R39:11ebecd1f795: KateModeMenuList: improve word wrap (authored by nibags).
KateModeMenuList: improve word wrap
Fri, Nov 1, 10:23 AM
nibags closed D24983: KateModeMenuList: improve word wrap.
Fri, Nov 1, 10:22 AM · Frameworks, Kate
nibags requested review of D25102: VHDL: all keywords are insensitive.
Fri, Nov 1, 9:20 AM · Frameworks, Kate
nibags updated the diff for D24983: KateModeMenuList: improve word wrap.
  • Increase the menu size according to the font size, to improve the display
Fri, Nov 1, 9:09 AM · Frameworks, Kate

Wed, Oct 30

nibags updated the diff for D24983: KateModeMenuList: improve word wrap.
  • Increase margin of list - search bar in Windows
Wed, Oct 30, 5:36 AM · Frameworks, Kate

Tue, Oct 29

nibags updated the diff for D24983: KateModeMenuList: improve word wrap.
  • Restore scroll bar margins
Tue, Oct 29, 8:07 PM · Frameworks, Kate
nibags updated the diff for D24983: KateModeMenuList: improve word wrap.
  • Fix font size/style
Tue, Oct 29, 1:04 PM · Frameworks, Kate

Mon, Oct 28

nibags added a comment to D24982: Small improvements in some XML files.

No, the dynamic flag is used to insert the captures already stored in %N (the captures are stored in the RegExpr rules and then "inserted" in the rules with the dynamic flag)

Mon, Oct 28, 9:26 PM · Frameworks, Kate
nibags committed R216:73489a79f9fd: Modelines: fix end of comment (authored by nibags).
Modelines: fix end of comment
Mon, Oct 28, 8:32 AM
nibags closed D24981: Modelines: fix end of comment.
Mon, Oct 28, 8:32 AM · Frameworks, Kate
nibags added a comment to D24983: KateModeMenuList: improve word wrap.

QFontMetrics::boundingRect(text).width() doesn't deliver an exact value of the text width, since I detected that in some translations and some desktop themes the text goes below the scroll bar. This problem doesn't exist with QFontMetrics::horizontalAdvance(text).

Mon, Oct 28, 8:26 AM · Frameworks, Kate
nibags added a comment to D24982: Small improvements in some XML files.

I had also thought about using QRegularExpression::DontCaptureOption, which is equivalent to using (?:...), but I wasn't sure how much the real improvement in performance is. However, disabling captures avoids allocating unnecessary QString for each capture.

Mon, Oct 28, 8:19 AM · Frameworks, Kate

Sun, Oct 27

nibags updated the diff for D24983: KateModeMenuList: improve word wrap.
  • Fixes
Sun, Oct 27, 12:09 PM · Frameworks, Kate
nibags requested review of D24983: KateModeMenuList: improve word wrap.
Sun, Oct 27, 11:18 AM · Frameworks, Kate
nibags updated the diff for D24982: Small improvements in some XML files.
  • Increase version of javascript.xml
Sun, Oct 27, 10:21 AM · Frameworks, Kate
nibags requested review of D24982: Small improvements in some XML files.
Sun, Oct 27, 10:14 AM · Frameworks, Kate
nibags requested review of D24981: Modelines: fix end of comment.
Sun, Oct 27, 9:40 AM · Frameworks, Kate

Oct 10 2019

nibags committed R216:c6f2bd8ba96d: TypeScript: update grammar and fixes (authored by nibags).
TypeScript: update grammar and fixes
Oct 10 2019, 4:06 PM
nibags closed D24355: TypeScript: update grammar and fixes.
Oct 10 2019, 4:06 PM · Frameworks, Kate
nibags committed R39:c077b29f92f2: KateModeMenuList: force the vertical position above the button (authored by nibags).
KateModeMenuList: force the vertical position above the button
Oct 10 2019, 6:23 AM
nibags closed D24357: KateModeMenuList: force the vertical position above the button.
Oct 10 2019, 6:02 AM · Frameworks, Kate
nibags updated the diff for D24355: TypeScript: update grammar and fixes.
  • TypeScript React: fix end-line regex
Oct 10 2019, 4:55 AM · Frameworks, Kate
nibags updated the diff for D24355: TypeScript: update grammar and fixes.

typescript-react: increase version.
javascript: use non-capturing groups in RegExpr

Oct 10 2019, 4:40 AM · Frameworks, Kate
nibags added a comment to D24355: TypeScript: update grammar and fixes.

ups! i will correct it

Oct 10 2019, 4:38 AM · Frameworks, Kate

Oct 4 2019

nibags committed R216:fc24cc9e819e: Mustache/Handlebars: minor fixes (authored by nibags).
Mustache/Handlebars: minor fixes
Oct 4 2019, 9:06 AM
nibags closed D24354: Mustache/Handlebars: minor fixes.
Oct 4 2019, 9:06 AM · Frameworks, Kate
nibags added a comment to D24354: Mustache/Handlebars: minor fixes.

As the delimiters in WordDetect rules were changed in D24378, I updated this diff only by making minor fixes in the Mustache/Handlebars definition.

Oct 4 2019, 3:37 AM · Frameworks, Kate
nibags updated the summary of D24354: Mustache/Handlebars: minor fixes.
Oct 4 2019, 3:34 AM · Frameworks, Kate
nibags retitled D24354: Mustache/Handlebars: minor fixes from Mustache/Handlebars: fix delimiters in HTML tags to Mustache/Handlebars: minor fixes.
Oct 4 2019, 3:28 AM · Frameworks, Kate
nibags updated the diff for D24354: Mustache/Handlebars: minor fixes.

Minor corrections:

  • Restore WordDetect rules
  • Use kateversion="5.44" (WordDetect with insensitive).
Oct 4 2019, 3:27 AM · Frameworks, Kate
nibags committed R216:61988aa5a1dd: WordDetect rule: detect delimiters at the inner edge of the string (authored by nibags).
WordDetect rule: detect delimiters at the inner edge of the string
Oct 4 2019, 3:20 AM
nibags closed D24378: WordDetect rule: detect delimiters at the inner edge of the string.
Oct 4 2019, 3:13 AM · Frameworks, Kate

Oct 3 2019

nibags updated the diff for D24378: WordDetect rule: detect delimiters at the inner edge of the string.
  • Add comment
Oct 3 2019, 6:47 AM · Frameworks, Kate
nibags added a comment to D24354: Mustache/Handlebars: minor fixes.

i did it in: D24378

Oct 3 2019, 6:27 AM · Frameworks, Kate
nibags requested review of D24378: WordDetect rule: detect delimiters at the inner edge of the string.
Oct 3 2019, 6:24 AM · Frameworks, Kate
nibags added a comment to D24354: Mustache/Handlebars: minor fixes.

I think it makes sense to change this in WorDetect: verify delimiter characters on the left and right edge of the string, either inside or outside the string. I will make another diff with this.

Oct 3 2019, 5:16 AM · Frameworks, Kate

Oct 2 2019

nibags added a comment to D24354: Mustache/Handlebars: minor fixes.

Indeed, WordDetect checks only the boundaries. What happens is that when using WordDetect with <tag, you need a border character before <, when it shouldn't.
That is, <tag will not match in the text: "word<tag>".
It's correct to use RegExpr with <tag\b instead of WordDetect.

Oct 2 2019, 10:02 AM · Frameworks, Kate
nibags requested review of D24357: KateModeMenuList: force the vertical position above the button.
Oct 2 2019, 9:35 AM · Frameworks, Kate
nibags requested review of D24355: TypeScript: update grammar and fixes.
Oct 2 2019, 5:37 AM · Frameworks, Kate
nibags requested review of D24354: Mustache/Handlebars: minor fixes.
Oct 2 2019, 5:31 AM · Frameworks, Kate

Sep 29 2019

nibags updated the diff for D24210: KadeModeMenuList: fix memory leaks and others.
  • Fix allocation in search names
Sep 29 2019, 11:33 AM · Frameworks, Kate

Sep 26 2019

nibags added a comment to D24210: KadeModeMenuList: fix memory leaks and others.

m_searchName is a pointer to an attribute of a KateFileType object (which may be the string translatedName or name), but in some cases a new string is created.

Sep 26 2019, 5:15 AM · Frameworks, Kate
nibags updated the diff for D24210: KadeModeMenuList: fix memory leaks and others.
  • Add boolean m_bHasNewSearchName to verify removal of m_searchName.
  • Correct format in some comments.
  • Remove friend KateModeMenuList and replace it with the "Factory" class.
Sep 26 2019, 5:10 AM · Frameworks, Kate
nibags updated the diff for D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.
  • Undo changes in Mustache
Sep 26 2019, 4:15 AM · Frameworks, Kate

Sep 25 2019

nibags added a comment to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

Sorry, that could go in another diff.
In the definition of Mustashe, I realized that using WordDetect requires a delimiter before <name. For example, writing text<table> doesn't match the WordDetect rule, so I changed it to RegExpr.

Sep 25 2019, 9:00 AM · Frameworks, Kate
nibags requested review of D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.
Sep 25 2019, 7:18 AM · Frameworks, Kate
nibags requested review of D24210: KadeModeMenuList: fix memory leaks and others.
Sep 25 2019, 7:16 AM · Frameworks, Kate

Sep 23 2019

nibags added a comment to D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared.

In the function KateModeMenuList::updateSelectedItem() an empty QIcon is also created when selecting an item. It would be better to put emptyIcon as an attribute of the class and use it every time.

Sep 23 2019, 10:32 PM · Frameworks, Kate

Sep 14 2019

nibags added inline comments to D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sep 14 2019, 8:37 PM · Frameworks, Kate
nibags committed R39:3aa9c13f5a8b: KateModeMenuList: use QString() for empty strings (authored by nibags).
KateModeMenuList: use QString() for empty strings
Sep 14 2019, 8:35 PM
nibags committed R39:983db24203c0: KateModeMenuList: add "Best Search Matches" section and fixes for Windows (authored by nibags).
KateModeMenuList: add "Best Search Matches" section and fixes for Windows
Sep 14 2019, 9:35 AM
nibags closed D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sep 14 2019, 9:33 AM · Frameworks, Kate
nibags added reviewers for D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows: KTextEditor, cullmann, dhaumann.
Sep 14 2019, 8:28 AM · Frameworks, Kate
nibags requested review of D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sep 14 2019, 8:25 AM · Frameworks, Kate

Sep 3 2019

nibags updated the summary of D23691: C & ISO C++: add digraphs (folding & preprocessor).
Sep 3 2019, 9:04 AM · Frameworks, Kate
nibags requested review of D23691: C & ISO C++: add digraphs (folding & preprocessor).
Sep 3 2019, 9:02 AM · Frameworks, Kate
nibags retitled D23688: Allow to customize attributes for KSyntaxHighligting themes from Allow customizing theme attributes in KSyntaxHighligting themes to Allow to customize attributes for KSyntaxHighligting themes.
Sep 3 2019, 5:52 AM · Frameworks, Kate
nibags requested review of D23688: Allow to customize attributes for KSyntaxHighligting themes.
Sep 3 2019, 5:49 AM · Frameworks, Kate

Sep 2 2019

nibags committed R216:828912485120: Markdown, TypeScript & Logcat: some fixes (authored by nibags).
Markdown, TypeScript & Logcat: some fixes
Sep 2 2019, 6:31 AM
nibags closed D23657: Markdown, TypeScript & Logcat: some fixes.
Sep 2 2019, 6:30 AM · Frameworks, Kate
nibags requested review of D23657: Markdown, TypeScript & Logcat: some fixes.
Sep 2 2019, 3:57 AM · Frameworks, Kate

Aug 30 2019

nibags updated the diff for D23516: Fix for all themes: allow turn off attributes in XML highlighting files.
  • Update function names
Aug 30 2019, 9:15 PM · Frameworks, Kate
nibags updated the diff for D23515: Format class: add functions to know if XML files set style attributes.
  • Update function names
Aug 30 2019, 9:11 PM · Frameworks, Kate
nibags added a comment to D23515: Format class: add functions to know if XML files set style attributes.

I also like hasXXOverride().

Aug 30 2019, 4:19 PM · Frameworks, Kate

Aug 27 2019

nibags added a dependent revision for D23515: Format class: add functions to know if XML files set style attributes: D23516: Fix for all themes: allow turn off attributes in XML highlighting files.
Aug 27 2019, 9:47 PM · Frameworks, Kate
nibags requested review of D23516: Fix for all themes: allow turn off attributes in XML highlighting files.
Aug 27 2019, 9:47 PM · Frameworks, Kate
nibags requested review of D23515: Format class: add functions to know if XML files set style attributes.
Aug 27 2019, 9:43 PM · Frameworks, Kate

Aug 25 2019

nibags committed R39:e8207a736a7e: Fix: allow turn off attributes in XML highlighting files (authored by nibags).
Fix: allow turn off attributes in XML highlighting files
Aug 25 2019, 10:36 AM
nibags closed D23422: Fix: allow turn off attributes in XML highlighting files.
Aug 25 2019, 10:35 AM · Frameworks, Kate
nibags added a comment to D23422: Fix: allow turn off attributes in XML highlighting files.

Yes, it has to do with that bug.
Later I will add the functions to the KSyntaxHighlighting API to correct this.

Aug 25 2019, 10:33 AM · Frameworks, Kate
nibags requested review of D23422: Fix: allow turn off attributes in XML highlighting files.
Aug 25 2019, 10:22 AM · Frameworks, Kate

Aug 24 2019

nibags committed R216:c461c5a78fc8: Markdown: multiple improvements and fixes (authored by nibags).
Markdown: multiple improvements and fixes
Aug 24 2019, 9:51 AM
nibags closed D23371: Markdown: multiple improvements and fixes.
Aug 24 2019, 9:45 AM · Frameworks, Kate
nibags updated the diff for D23371: Markdown: multiple improvements and fixes.
  • Fix bug in blockquotes and improve integration with R Markdown
Aug 24 2019, 9:05 AM · Frameworks, Kate

Aug 23 2019

nibags added a reviewer for D23371: Markdown: multiple improvements and fixes: Framework: Syntax Highlighting.
Aug 23 2019, 8:37 AM · Frameworks, Kate
nibags added reviewers for D23371: Markdown: multiple improvements and fixes: cullmann, dhaumann.
Aug 23 2019, 8:37 AM · Frameworks, Kate
nibags requested review of D23371: Markdown: multiple improvements and fixes.
Aug 23 2019, 8:18 AM · Frameworks, Kate

Aug 20 2019

nibags closed D23272: JavaScript: remove unnecessary "Conditional Expression" context.
Aug 20 2019, 11:04 AM · Frameworks, Kate
nibags committed R216:4bc333ee2509: JavaScript: remove unnecessary "Conditional Expression" context (authored by nibags).
JavaScript: remove unnecessary "Conditional Expression" context
Aug 20 2019, 11:04 AM

Aug 19 2019

nibags requested review of D23272: JavaScript: remove unnecessary "Conditional Expression" context.
Aug 19 2019, 8:05 PM · Frameworks, Kate

Aug 9 2019

nibags committed R40:6c2f6d88e8d3: Highlight documentation: add include keywords (authored by nibags).
Highlight documentation: add include keywords
Aug 9 2019, 6:29 PM
nibags closed D23050: Highlight documentation: add include keywords.
Aug 9 2019, 6:29 PM · Documentation, Kate
nibags requested review of D23050: Highlight documentation: add include keywords.
Aug 9 2019, 3:51 PM · Documentation, Kate
nibags added a comment to D23034: implicit fallthough if there is fallthoughContext.

I think it's an improvement, but the ideal would be to maintain support for fallthrough="bool". That is, if the fallthroughContext attribute is present, assume fallthrough="true", unless "fallthrough=" is explicitly written.

Aug 9 2019, 3:47 PM · Frameworks, Kate

Aug 8 2019

nibags added a comment to D23013: Latex: several fixes (math mode, nested verbatim, ...).

There are many improvements to the Latex highlighter!
Recently I marked bugs 274440, 322081 and others as duplicates (in fact, this patch fixes them well)

Aug 8 2019, 10:26 PM · Frameworks, Kate

Aug 2 2019

nibags committed R216:9bcbad1ae247: Rust: add missing keywords and minor improvements (authored by nibags).
Rust: add missing keywords and minor improvements
Aug 2 2019, 3:41 AM
nibags closed D22848: Rust: add missing keywords and minor improvements.
Aug 2 2019, 3:41 AM · Frameworks, Kate

Jul 31 2019

nibags requested review of D22848: Rust: add missing keywords and minor improvements.
Jul 31 2019, 6:28 AM · Frameworks, Kate

Jul 20 2019

nibags committed R216:1766185fe580: TypeScript: fix keywords in conditional expressions (authored by nibags).
TypeScript: fix keywords in conditional expressions
Jul 20 2019, 8:15 PM
nibags closed D22567: TypeScript: fix keywords in conditional expressions.
Jul 20 2019, 8:15 PM · Frameworks, Kate
nibags closed D22568: Fix generator and test paths of CMake.
Jul 20 2019, 8:14 PM · Frameworks, Kate
nibags committed R216:0b7e23a81a94: Fix generator and test paths of CMake (authored by nibags).
Fix generator and test paths of CMake
Jul 20 2019, 8:14 PM

Jul 19 2019

nibags requested review of D22568: Fix generator and test paths of CMake.
Jul 19 2019, 7:41 PM · Frameworks, Kate