nibags (Nibaldo González)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2017, 7:25 AM (108 w, 5 d)
Availability
Available

Recent Activity

Sat, Sep 14

nibags added inline comments to D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sat, Sep 14, 8:37 PM · Frameworks, Kate
nibags committed R39:3aa9c13f5a8b: KateModeMenuList: use QString() for empty strings (authored by nibags).
KateModeMenuList: use QString() for empty strings
Sat, Sep 14, 8:35 PM
nibags committed R39:983db24203c0: KateModeMenuList: add "Best Search Matches" section and fixes for Windows (authored by nibags).
KateModeMenuList: add "Best Search Matches" section and fixes for Windows
Sat, Sep 14, 9:35 AM
nibags closed D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sat, Sep 14, 9:33 AM · Frameworks, Kate
nibags added reviewers for D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows: KTextEditor, cullmann, dhaumann.
Sat, Sep 14, 8:28 AM · Frameworks, Kate
nibags requested review of D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sat, Sep 14, 8:25 AM · Frameworks, Kate

Tue, Sep 3

nibags updated the summary of D23691: C & ISO C++: add digraphs (folding & preprocessor).
Tue, Sep 3, 9:04 AM · Frameworks, Kate
nibags requested review of D23691: C & ISO C++: add digraphs (folding & preprocessor).
Tue, Sep 3, 9:02 AM · Frameworks, Kate
nibags retitled D23688: Allow to customize attributes for KSyntaxHighligting themes from Allow customizing theme attributes in KSyntaxHighligting themes to Allow to customize attributes for KSyntaxHighligting themes.
Tue, Sep 3, 5:52 AM · Frameworks, Kate
nibags requested review of D23688: Allow to customize attributes for KSyntaxHighligting themes.
Tue, Sep 3, 5:49 AM · Frameworks, Kate

Mon, Sep 2

nibags committed R216:828912485120: Markdown, TypeScript & Logcat: some fixes (authored by nibags).
Markdown, TypeScript & Logcat: some fixes
Mon, Sep 2, 6:31 AM
nibags closed D23657: Markdown, TypeScript & Logcat: some fixes.
Mon, Sep 2, 6:30 AM · Frameworks, Kate
nibags requested review of D23657: Markdown, TypeScript & Logcat: some fixes.
Mon, Sep 2, 3:57 AM · Frameworks, Kate

Fri, Aug 30

nibags updated the diff for D23516: Fix for all themes: allow turn off attributes in XML highlighting files.
  • Update function names
Fri, Aug 30, 9:15 PM · Frameworks, Kate
nibags updated the diff for D23515: Format class: add functions to know if XML files set style attributes.
  • Update function names
Fri, Aug 30, 9:11 PM · Frameworks, Kate
nibags added a comment to D23515: Format class: add functions to know if XML files set style attributes.

I also like hasXXOverride().

Fri, Aug 30, 4:19 PM · Frameworks, Kate

Tue, Aug 27

nibags added a dependent revision for D23515: Format class: add functions to know if XML files set style attributes: D23516: Fix for all themes: allow turn off attributes in XML highlighting files.
Tue, Aug 27, 9:47 PM · Frameworks, Kate
nibags requested review of D23516: Fix for all themes: allow turn off attributes in XML highlighting files.
Tue, Aug 27, 9:47 PM · Frameworks, Kate
nibags requested review of D23515: Format class: add functions to know if XML files set style attributes.
Tue, Aug 27, 9:43 PM · Frameworks, Kate

Sun, Aug 25

nibags committed R39:e8207a736a7e: Fix: allow turn off attributes in XML highlighting files (authored by nibags).
Fix: allow turn off attributes in XML highlighting files
Sun, Aug 25, 10:36 AM
nibags closed D23422: Fix: allow turn off attributes in XML highlighting files.
Sun, Aug 25, 10:35 AM · Frameworks, Kate
nibags added a comment to D23422: Fix: allow turn off attributes in XML highlighting files.

Yes, it has to do with that bug.
Later I will add the functions to the KSyntaxHighlighting API to correct this.

Sun, Aug 25, 10:33 AM · Frameworks, Kate
nibags requested review of D23422: Fix: allow turn off attributes in XML highlighting files.
Sun, Aug 25, 10:22 AM · Frameworks, Kate

Sat, Aug 24

nibags committed R216:c461c5a78fc8: Markdown: multiple improvements and fixes (authored by nibags).
Markdown: multiple improvements and fixes
Sat, Aug 24, 9:51 AM
nibags closed D23371: Markdown: multiple improvements and fixes.
Sat, Aug 24, 9:45 AM · Frameworks, Kate
nibags updated the diff for D23371: Markdown: multiple improvements and fixes.
  • Fix bug in blockquotes and improve integration with R Markdown
Sat, Aug 24, 9:05 AM · Frameworks, Kate

Aug 23 2019

nibags added a reviewer for D23371: Markdown: multiple improvements and fixes: Framework: Syntax Highlighting.
Aug 23 2019, 8:37 AM · Frameworks, Kate
nibags added reviewers for D23371: Markdown: multiple improvements and fixes: cullmann, dhaumann.
Aug 23 2019, 8:37 AM · Frameworks, Kate
nibags requested review of D23371: Markdown: multiple improvements and fixes.
Aug 23 2019, 8:18 AM · Frameworks, Kate

Aug 20 2019

nibags closed D23272: JavaScript: remove unnecessary "Conditional Expression" context.
Aug 20 2019, 11:04 AM · Frameworks, Kate
nibags committed R216:4bc333ee2509: JavaScript: remove unnecessary "Conditional Expression" context (authored by nibags).
JavaScript: remove unnecessary "Conditional Expression" context
Aug 20 2019, 11:04 AM

Aug 19 2019

nibags requested review of D23272: JavaScript: remove unnecessary "Conditional Expression" context.
Aug 19 2019, 8:05 PM · Frameworks, Kate

Aug 9 2019

nibags committed R40:6c2f6d88e8d3: Highlight documentation: add include keywords (authored by nibags).
Highlight documentation: add include keywords
Aug 9 2019, 6:29 PM
nibags closed D23050: Highlight documentation: add include keywords.
Aug 9 2019, 6:29 PM · Documentation, Kate
nibags requested review of D23050: Highlight documentation: add include keywords.
Aug 9 2019, 3:51 PM · Documentation, Kate
nibags added a comment to D23034: implicit fallthough if there is fallthoughContext.

I think it's an improvement, but the ideal would be to maintain support for fallthrough="bool". That is, if the fallthroughContext attribute is present, assume fallthrough="true", unless "fallthrough=" is explicitly written.

Aug 9 2019, 3:47 PM · Frameworks, Kate

Aug 8 2019

nibags added a comment to D23013: Latex: several fixes (math mode, nested verbatim, ...).

There are many improvements to the Latex highlighter!
Recently I marked bugs 274440, 322081 and others as duplicates (in fact, this patch fixes them well)

Aug 8 2019, 10:26 PM · Frameworks, Kate

Aug 2 2019

nibags committed R216:9bcbad1ae247: Rust: add missing keywords and minor improvements (authored by nibags).
Rust: add missing keywords and minor improvements
Aug 2 2019, 3:41 AM
nibags closed D22848: Rust: add missing keywords and minor improvements.
Aug 2 2019, 3:41 AM · Frameworks, Kate

Jul 31 2019

nibags requested review of D22848: Rust: add missing keywords and minor improvements.
Jul 31 2019, 6:28 AM · Frameworks, Kate

Jul 20 2019

nibags committed R216:1766185fe580: TypeScript: fix keywords in conditional expressions (authored by nibags).
TypeScript: fix keywords in conditional expressions
Jul 20 2019, 8:15 PM
nibags closed D22567: TypeScript: fix keywords in conditional expressions.
Jul 20 2019, 8:15 PM · Frameworks, Kate
nibags closed D22568: Fix generator and test paths of CMake.
Jul 20 2019, 8:14 PM · Frameworks, Kate
nibags committed R216:0b7e23a81a94: Fix generator and test paths of CMake (authored by nibags).
Fix generator and test paths of CMake
Jul 20 2019, 8:14 PM

Jul 19 2019

nibags requested review of D22568: Fix generator and test paths of CMake.
Jul 19 2019, 7:41 PM · Frameworks, Kate
nibags requested review of D22567: TypeScript: fix keywords in conditional expressions.
Jul 19 2019, 7:37 PM · Frameworks, Kate

Jul 6 2019

nibags moved T9775: Integrate Fortran Free/Fixed from Backlog to Done on the Framework: Syntax Highlighting board.

Done in: c579929d8667 and 9c5875af2713

Jul 6 2019, 7:36 AM · Framework: Syntax Highlighting
nibags added a comment to D21713: Fortran: implement free & fixed formats.

The files are re-licensed to MIT at: 9c5875af2713

Jul 6 2019, 7:27 AM · Frameworks, Kate
nibags added a comment to R216:9c5875af2713: Fortran: relicense to MIT.

See:
https://mail.kde.org/pipermail/kwrite-devel/2019-July/004714.html
https://mail.kde.org/pipermail/kwrite-devel/2019-July/004715.html

Jul 6 2019, 7:26 AM
nibags committed R216:9c5875af2713: Fortran: relicense to MIT (authored by nibags).
Fortran: relicense to MIT
Jul 6 2019, 7:22 AM
nibags committed R216:fdd4d8defb11: Improve the Fortran fixed format syntax highlighting (authored by nononux).
Improve the Fortran fixed format syntax highlighting
Jul 6 2019, 6:48 AM
nibags closed D22253: Improve the Fortran fixed format syntax highlighting.
Jul 6 2019, 6:44 AM · Frameworks, Kate
nibags accepted D22253: Improve the Fortran fixed format syntax highlighting.

That is complicated to do, we would have to make rules for all the columns before 72 and for all the possible matchings, which is a lot of work and would make the code difficult to maintain.
I think a better solution is to add the functionality to the highlighting engine, for example, allowing a rule to be forced in a column, so that it can be applied above of any context. It can be something like this:

<RegExpr attribute="Comment" context="comment" String="." column="72" forceColumn="true" />

Another option is to allow having a set of rules that are applied above of the rest of the syntax highlighting; something like "injecting" rules. Such a feature could also be used in the PHP highlighter, instead of the generator script. For example:

<InjectRules>
    <RegExpr attribute="Comment" context="comment" String="." column="72" />
</InjectRules>
Jul 6 2019, 6:30 AM · Frameworks, Kate

Jul 4 2019

nibags added a comment to D22253: Improve the Fortran fixed format syntax highlighting.

Now I checked the patch well and I want to add some final recommendations before merging.
I think it's okay.

Jul 4 2019, 8:16 AM · Frameworks, Kate
nibags added inline comments to D21713: Fortran: implement free & fixed formats.
Jul 4 2019, 5:30 AM · Frameworks, Kate

Jul 3 2019

nibags added a comment to D21713: Fortran: implement free & fixed formats.

Franchin Matteo & Janus Weil responded and agree to the MIT license.

Jul 3 2019, 9:33 PM · Frameworks, Kate
nibags added a comment to D22253: Improve the Fortran fixed format syntax highlighting.

Only a small detail needs to be added. You also have to increase the version of the file.

Jul 3 2019, 9:18 PM · Frameworks, Kate
nibags added a comment to D21713: Fortran: implement free & fixed formats.

Is there any progress with the licensing?
Otherwise I assume LGPL would be good enough, if a change isn't possible.

Jul 3 2019, 3:30 AM · Frameworks, Kate

Jun 23 2019

nibags committed R216:6924eab39840: AppArmor: update syntax (authored by nibags).
AppArmor: update syntax
Jun 23 2019, 10:59 AM
nibags closed D21960: AppArmor: update syntax.
Jun 23 2019, 10:58 AM · Frameworks, Kate

Jun 21 2019

nibags requested review of D21960: AppArmor: update syntax.
Jun 21 2019, 12:06 PM · Frameworks, Kate

Jun 15 2019

nibags committed R39:0c5279a661ce: KateModeMenuList: move to QListView (authored by nibags).
KateModeMenuList: move to QListView
Jun 15 2019, 9:39 AM
nibags closed D21712: KateModeMenuList: move to QListView.
Jun 15 2019, 9:20 AM · Frameworks, Kate
nibags committed R216:c91c2554215d: Julia: update syntax and add constants keywords (authored by nibags).
Julia: update syntax and add constants keywords
Jun 15 2019, 9:14 AM
nibags closed D21711: Julia: update syntax and add constants keywords.
Jun 15 2019, 9:14 AM · Frameworks, Kate

Jun 12 2019

nibags updated the diff for D21712: KateModeMenuList: move to QListView.
  • Update tooltip of search bar
Jun 12 2019, 7:03 AM · Frameworks, Kate

Jun 11 2019

nibags updated the diff for D21712: KateModeMenuList: move to QListView.
  • Correct code style

Remove this-> and return at the end of void functions.

Jun 11 2019, 6:40 AM · Frameworks, Kate

Jun 10 2019

nibags updated the summary of D21713: Fortran: implement free & fixed formats.
Jun 10 2019, 9:00 AM · Frameworks, Kate
nibags requested review of D21713: Fortran: implement free & fixed formats.
Jun 10 2019, 8:58 AM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

I changed QListWidget by QListView in D21712

Jun 10 2019, 8:08 AM · Frameworks, Kate
nibags updated the summary of D21712: KateModeMenuList: move to QListView.
Jun 10 2019, 8:04 AM · Frameworks, Kate
nibags requested review of D21712: KateModeMenuList: move to QListView.
Jun 10 2019, 8:03 AM · Frameworks, Kate
nibags requested review of D21711: Julia: update syntax and add constants keywords.
Jun 10 2019, 7:51 AM · Frameworks, Kate

May 31 2019

nibags committed R216:28b11e39fba0: YAML: only comments after spaces and other improvements/fixes (authored by nibags).
YAML: only comments after spaces and other improvements/fixes
May 31 2019, 6:58 PM
nibags closed D21411: YAML: only comments after spaces and other improvements/fixes.
May 31 2019, 6:58 PM · Frameworks, Kate
nibags added a comment to D21411: YAML: only comments after spaces and other improvements/fixes.

Could one adapt the theme and remove the color later?

May 31 2019, 11:37 AM · Frameworks, Kate
nibags added a comment to D21411: YAML: only comments after spaces and other improvements/fixes.

Btw., would it be possible to remove the hardcoded color here: <itemData name="Alert" defStyleNum="dsAlert" backgroundColor="#EF9A9A" />

May 31 2019, 11:24 AM · Frameworks, Kate
nibags updated the summary of D21411: YAML: only comments after spaces and other improvements/fixes.
May 31 2019, 11:08 AM · Frameworks, Kate
nibags updated the diff for D21411: YAML: only comments after spaces and other improvements/fixes.
  • Some fixes in attributes and update test file
May 31 2019, 11:07 AM · Frameworks, Kate

May 30 2019

nibags committed R216:4ec759613433: Markdown: use includeAttrib in code blocks (authored by nibags).
Markdown: use includeAttrib in code blocks
May 30 2019, 10:12 AM
nibags closed D21410: Markdown: use includeAttrib in code blocks.
May 30 2019, 10:12 AM · Frameworks, Kate

May 25 2019

nibags added reviewers for D21411: YAML: only comments after spaces and other improvements/fixes: dhaumann, cullmann, Framework: Syntax Highlighting.
May 25 2019, 8:20 PM · Frameworks, Kate
nibags requested review of D21411: YAML: only comments after spaces and other improvements/fixes.
May 25 2019, 8:17 PM · Frameworks, Kate
nibags added reviewers for D21410: Markdown: use includeAttrib in code blocks: dhaumann, cullmann, Framework: Syntax Highlighting.
May 25 2019, 8:13 PM · Frameworks, Kate
nibags requested review of D21410: Markdown: use includeAttrib in code blocks.
May 25 2019, 8:10 PM · Frameworks, Kate

May 22 2019

nibags committed R39:b2064042daa1: Fix: don't reset Highlight when saving some files (authored by nibags).
Fix: don't reset Highlight when saving some files
May 22 2019, 11:32 AM
nibags closed D21331: Fix: don't reset Highlight when saving some files.
May 22 2019, 11:25 AM · Frameworks, Kate
nibags requested review of D21331: Fix: don't reset Highlight when saving some files.
May 22 2019, 9:02 AM · Frameworks, Kate

May 21 2019

nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

errata: the setDontChangeHlOnSave() function has nothing to do here.
more time I upload a patch.

May 21 2019, 10:50 PM · Frameworks, Kate
nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

The function setDontChangeHlOnSave() uses the m_hlSetByUser variable to avoid resetting the syntax highlighting, which I removed in updateFileType().
I could use another binary for this.

May 21 2019, 9:07 PM · Frameworks, Kate

May 19 2019

nibags committed R216:71446d3e9e5e: Remove .conf extension from "INI Files" hl, to determine the highlighter using… (authored by nibags).
Remove .conf extension from "INI Files" hl, to determine the highlighter using…
May 19 2019, 11:48 AM
nibags closed D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.
May 19 2019, 11:48 AM · Frameworks, Kate
nibags committed R216:4cf3a7e9825d: Perl: fix the // operator (authored by nibags).
Perl: fix the // operator
May 19 2019, 11:43 AM
nibags closed D21286: Perl: fix the // operator.
May 19 2019, 11:41 AM · Frameworks, Kate
nibags requested review of D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.
May 19 2019, 11:35 AM · Frameworks, Kate
nibags requested review of D21286: Perl: fix the // operator.
May 19 2019, 9:48 AM · Frameworks, Kate

May 11 2019

nibags committed R39:1d9fc111fc78: New menu of syntax highlighting in the status bar (authored by nibags).
New menu of syntax highlighting in the status bar
May 11 2019, 8:33 PM
nibags closed D20958: New menu of syntax highlighting in the status bar.
May 11 2019, 8:15 PM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Now it's OK

May 11 2019, 8:14 PM · Frameworks, Kate
nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Add delimiters « »
May 11 2019, 1:21 PM · Frameworks, Kate