nibags (Nibaldo González)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2017, 7:25 AM (91 w, 6 d)
Availability
Available

Recent Activity

Sat, May 25

nibags added reviewers for D21411: YAML: only comments after spaces and other improvements/fixes: dhaumann, cullmann, Framework: Syntax Highlighting.
Sat, May 25, 8:20 PM · Frameworks, Kate
nibags requested review of D21411: YAML: only comments after spaces and other improvements/fixes.
Sat, May 25, 8:17 PM · Frameworks, Kate
nibags added reviewers for D21410: Markdown: use includeAttrib in code blocks: dhaumann, cullmann, Framework: Syntax Highlighting.
Sat, May 25, 8:13 PM · Frameworks, Kate
nibags requested review of D21410: Markdown: use includeAttrib in code blocks.
Sat, May 25, 8:10 PM · Frameworks, Kate

Wed, May 22

nibags committed R39:b2064042daa1: Fix: don't reset Highlight when saving some files (authored by nibags).
Fix: don't reset Highlight when saving some files
Wed, May 22, 11:32 AM
nibags closed D21331: Fix: don't reset Highlight when saving some files.
Wed, May 22, 11:25 AM · Frameworks, Kate
nibags requested review of D21331: Fix: don't reset Highlight when saving some files.
Wed, May 22, 9:02 AM · Frameworks, Kate

Tue, May 21

nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

errata: the setDontChangeHlOnSave() function has nothing to do here.
more time I upload a patch.

Tue, May 21, 10:50 PM · Frameworks, Kate
nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

The function setDontChangeHlOnSave() uses the m_hlSetByUser variable to avoid resetting the syntax highlighting, which I removed in updateFileType().
I could use another binary for this.

Tue, May 21, 9:07 PM · Frameworks, Kate

Sun, May 19

nibags committed R216:71446d3e9e5e: Remove .conf extension from "INI Files" hl, to determine the highlighter using… (authored by nibags).
Remove .conf extension from "INI Files" hl, to determine the highlighter using…
Sun, May 19, 11:48 AM
nibags closed D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.
Sun, May 19, 11:48 AM · Frameworks, Kate
nibags committed R216:4cf3a7e9825d: Perl: fix the // operator (authored by nibags).
Perl: fix the // operator
Sun, May 19, 11:43 AM
nibags closed D21286: Perl: fix the // operator.
Sun, May 19, 11:41 AM · Frameworks, Kate
nibags requested review of D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.
Sun, May 19, 11:35 AM · Frameworks, Kate
nibags requested review of D21286: Perl: fix the // operator.
Sun, May 19, 9:48 AM · Frameworks, Kate

Sat, May 11

nibags committed R39:1d9fc111fc78: New menu of syntax highlighting in the status bar (authored by nibags).
New menu of syntax highlighting in the status bar
Sat, May 11, 8:33 PM
nibags closed D20958: New menu of syntax highlighting in the status bar.
Sat, May 11, 8:15 PM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Now it's OK

Sat, May 11, 8:14 PM · Frameworks, Kate
nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Add delimiters « »
Sat, May 11, 1:21 PM · Frameworks, Kate

Fri, May 10

nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Fixes the menu alignment of the previous update
Fri, May 10, 8:36 AM · Frameworks, Kate

Thu, May 9

nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.

Some fixes for locations:

  • Before, the word wrap was only applied in spaces and, in languages such as German, there are large words that pass under the scroll bar. This is corrected.
  • Improves the alignment of the menu with respect to the trigger button in languages with Right-to-left layouts, such as Arabic or Hebrew. In those cases the menu is aligned to the left of the button (the idea is that the menu is aligned towards the center of the window, since it's shown on the edge of the window).
Thu, May 9, 8:06 PM · Frameworks, Kate

Tue, May 7

nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

I'm going to move it to QListView (or QTreeView) in a future diff, I have checked and it isn't complicated to do.

Tue, May 7, 11:31 PM · Frameworks, Kate

Sun, May 5

nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Allow to select an item with a single click, regardless of the configuration of the system.
Sun, May 5, 9:10 PM · Frameworks, Kate

Sat, May 4

nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Can you make this a QListView? I once heard the QListWidget will be deprecated in Qt6, rule of thumb is: always use Q*View instead of Q*Widget, since this then will also work in QML.

Sat, May 4, 5:16 PM · Frameworks, Kate
nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
    • Update:
  • Select the search text when showing the menu.
  • Also use Shift, Alt or Meta + Return to select an item without hiding the menu.
  • Fix style in signals/slots.
  • Use constant variable for icon size.
  • Use static_cast instead of dynamic_cast.
  • Always use brackets in if/else conditions.
  • Decrease unnecessary multiline comments.
  • Update base.
Sat, May 4, 5:07 PM · Frameworks, Kate

Fri, May 3

nibags committed R39:0a6ea0624228: Allow to change the Mode, after changing the Highlighting (authored by nibags).
Allow to change the Mode, after changing the Highlighting
Fri, May 3, 12:04 PM
nibags closed D20959: Allow to change the Mode, after changing the Highlighting.
Fri, May 3, 12:04 PM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Thanks for the comments, in a while I will update the diff with the suggestions/corrections.

Fri, May 3, 11:46 AM · Frameworks, Kate

Thu, May 2

nibags requested review of D20959: Allow to change the Mode, after changing the Highlighting.
Thu, May 2, 11:19 AM · Frameworks, Kate
nibags added reviewers for D20958: New menu of syntax highlighting in the status bar: KTextEditor, Kate.
Thu, May 2, 11:13 AM · Frameworks, Kate
nibags requested review of D20958: New menu of syntax highlighting in the status bar.
Thu, May 2, 11:07 AM · Frameworks, Kate

Apr 6 2019

nibags committed R216:e3a9359decea: Add syntax definition for Elm language to syntax-highlighting (authored by nibags).
Add syntax definition for Elm language to syntax-highlighting
Apr 6 2019, 6:06 PM
nibags closed D19438: Add syntax definition for Elm language to syntax-highlighting.
Apr 6 2019, 5:59 PM · Frameworks, Kate
nibags updated the diff for D19438: Add syntax definition for Elm language to syntax-highlighting.
  • Ok! Adding autotest references
Apr 6 2019, 5:58 PM · Frameworks, Kate

Apr 5 2019

nibags added reviewers for D20233: Add syntax highlighting for fish shell: Framework: Syntax Highlighting, dhaumann, cullmann.
Apr 5 2019, 8:24 PM · Frameworks, Framework: Syntax Highlighting, Kate
nibags added reviewers for D19438: Add syntax definition for Elm language to syntax-highlighting: Framework: Syntax Highlighting, dhaumann, cullmann.
Apr 5 2019, 8:21 PM · Frameworks, Kate
nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.
  • Running make test, after adding a new file to autotests/input, will throw an error in "testhighlighter_test", "htmlhighlighter_test" and "folding_test", since references haven't been updated. It's normal to show you that error.
  • You have to execute the autotest/update-reference-data.sh script to update the references (new files will be copied to folding, html & reference). When running again make test everything will work fine.
Apr 5 2019, 8:20 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Don't highlight as Error the "alias" keyword within rules

Better not to highlight anything in rules.

Apr 5 2019, 8:19 AM · Frameworks, Kate

Apr 3 2019

nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Update tests
Apr 3 2019, 9:55 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Apply changes in apparmor.xml, remove selinux-*.xml changes
Apr 3 2019, 9:29 PM · Frameworks, Kate
nibags committed R216:508be5417e67: AppArmor & SELinux: remove one indentation in XML files (authored by nibags).
AppArmor & SELinux: remove one indentation in XML files
Apr 3 2019, 8:57 PM
nibags closed D20220: AppArmor & SELinux: remove one indentation in XML files.
Apr 3 2019, 8:57 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Fix some indentations
  • Remove selinux-*.xml changes
Apr 3 2019, 8:52 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Remove "alias" in the "_end_rule" context and add some comments
Apr 3 2019, 8:42 PM · Frameworks, Kate
nibags updated the diff for D20220: AppArmor & SELinux: remove one indentation in XML files.
  • Fix some indentations
Apr 3 2019, 8:33 PM · Frameworks, Kate
nibags added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

Sorry, I committed this diff, but it hasn't been fully accepted. Although I made the changes that mwolff requested. If there is a problem, I can undo the commit or update it....

Apr 3 2019, 7:40 AM · Frameworks, Kate
nibags committed R39:c922bc8352ac: Fix: apply correctly the text colors of the chosen scheme (authored by nibags).
Fix: apply correctly the text colors of the chosen scheme
Apr 3 2019, 7:22 AM
nibags closed D19876: Fix: apply correctly the text colors of the chosen scheme.
Apr 3 2019, 7:22 AM · Frameworks, Kate
nibags added a dependent revision for D20220: AppArmor & SELinux: remove one indentation in XML files: D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Apr 3 2019, 6:21 AM · Frameworks, Kate
nibags added a dependency for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles: D20220: AppArmor & SELinux: remove one indentation in XML files.
Apr 3 2019, 6:21 AM · Frameworks, Kate
nibags requested review of D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Apr 3 2019, 6:15 AM · Frameworks, Kate
nibags requested review of D20220: AppArmor & SELinux: remove one indentation in XML files.
Apr 3 2019, 6:09 AM · Frameworks, Kate

Apr 2 2019

nibags added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

I have tested this a lot and it works well so far. I don't know if you have any disagreement with the last update (for example, using setTheme() with an empty theme, although I haven't seen this cause any problems)...

Apr 2 2019, 6:32 AM · Frameworks, Kate
nibags committed R216:3c5f212c90ef: Doxygen: don't use black color in tags (authored by nibags).
Doxygen: don't use black color in tags
Apr 2 2019, 6:13 AM
nibags closed D20195: Doxygen: don't use black color in tags.
Apr 2 2019, 6:13 AM · Frameworks, Kate
nibags committed R216:b518dcc6486a: Allow line end context switches in empty lines (authored by nibags).
Allow line end context switches in empty lines
Apr 2 2019, 6:13 AM
nibags requested review of D20195: Doxygen: don't use black color in tags.
Apr 2 2019, 6:07 AM · Frameworks, Kate
nibags closed D20148: Allow line end context switches in empty lines.
Apr 2 2019, 5:21 AM · Frameworks, Kate
nibags updated the diff for D20148: Allow line end context switches in empty lines.
  • Loop proposal
Apr 2 2019, 4:21 AM · Frameworks, Kate

Apr 1 2019

nibags updated the summary of D20148: Allow line end context switches in empty lines.
Apr 1 2019, 4:15 AM · Frameworks, Kate
nibags updated the diff for D20148: Allow line end context switches in empty lines.
  • Don't store bool in StateData
Apr 1 2019, 4:11 AM · Frameworks, Kate

Mar 31 2019

nibags added reviewers for D20148: Allow line end context switches in empty lines: Framework: Syntax Highlighting, cullmann, dhaumann, vkrause.
Mar 31 2019, 7:46 PM · Frameworks, Kate
nibags requested review of D20148: Allow line end context switches in empty lines.
Mar 31 2019, 7:42 PM · Frameworks, Kate

Mar 28 2019

nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Fix attributes in "KDE" and "Vim (dark)" themes
Mar 28 2019, 10:15 PM · Frameworks, Kate

Mar 25 2019

nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Use QStringLiteral
Mar 25 2019, 2:26 PM · Frameworks, Kate

Mar 24 2019

nibags updated the summary of D19876: Fix: apply correctly the text colors of the chosen scheme.
Mar 24 2019, 6:09 PM · Frameworks, Kate
nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Pass schema name as parameter
Mar 24 2019, 6:06 PM · Frameworks, Kate

Mar 23 2019

nibags updated the summary of D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0).
Mar 23 2019, 2:39 PM · Frameworks, Kate
nibags added reviewers for D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0): Framework: Syntax Highlighting, cullmann, dhaumann, vkrause.
Mar 23 2019, 2:24 PM · Frameworks, Kate
nibags requested review of D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0).
Mar 23 2019, 2:22 PM · Frameworks, Kate
nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Add some comments
Mar 23 2019, 1:54 PM · Frameworks, Kate

Mar 20 2019

nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Fix theme names

Convert theme names from KTextEditor => KSyntaxHighlighting and avoid using invalid KSyntaxHighlighting::Theme objects.

Mar 20 2019, 10:53 AM · Frameworks, Kate

Mar 19 2019

nibags added reviewers for D19876: Fix: apply correctly the text colors of the chosen scheme: KTextEditor, Kate.
Mar 19 2019, 7:11 AM · Frameworks, Kate
nibags requested review of D19876: Fix: apply correctly the text colors of the chosen scheme.
Mar 19 2019, 7:04 AM · Frameworks, Kate

Mar 12 2019

nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.

It isn't possible to compile, because the elm.xml file has multiple issues :(
The script "data/schema/validatehl.sh" serves to verify the XML files:

cd syntax-highlighting/data/schema/
./validatehl.sh ../syntax/elm.xml

Output:

../syntax/elm.xml:3: element language: Schemas validity error : Element 'language', attribute 'version': '1.0' is not a valid value of the atomic type 'xs:integer'.
../syntax/elm.xml:43: element WordDetect: Schemas validity error : Element 'WordDetect', attribute 'string': The attribute 'string' is not allowed.
../syntax/elm.xml:43: element WordDetect: Schemas validity error : Element 'WordDetect': The attribute 'String' is required but missing.
../syntax/elm.xml:84: element StringDetect: Schemas validity error : Element 'StringDetect', attribute 'char': The attribute 'char' is not allowed.
../syntax/elm.xml:84: element StringDetect: Schemas validity error : Element 'StringDetect': The attribute 'String' is required but missing.
../syntax/elm.xml:86: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:93: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:102: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:114: element itemDatas: Schemas validity error : Element 'itemDatas': This element is not expected. Expected is ( context ).
../syntax/elm.xml:4: element highlighting: Schemas validity error : Element 'highlighting': Missing child element(s). Expected is ( itemDatas ).
../syntax/elm.xml fails to validate

For example: </contexts> (line 133) must be placed before <itemDatas> and dsHexVal isn't a valid default style (use dsBaseN, look here). By solving it, maybe compile everything well.

Mar 12 2019, 9:58 AM · Frameworks, Kate

Mar 10 2019

nibags committed R216:1296052d48b3: Logcat: fix dsError color with underline="0" (authored by nibags).
Logcat: fix dsError color with underline="0"
Mar 10 2019, 9:13 AM
nibags closed D19461: Logcat: fix dsError color with underline="0".
Mar 10 2019, 9:13 AM · Frameworks, Kate
nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

Yes, this corresponds to the bug you mention.
In the "Vim (dark)" scheme, bold="0" doesn't work either, since all the text is bold.

Mar 10 2019, 9:13 AM · Frameworks, Kate

Mar 8 2019

nibags updated the diff for D19461: Logcat: fix dsError color with underline="0".
  • Update styles
Mar 8 2019, 11:01 AM · Frameworks, Kate
nibags added a comment to D18673: Add symlinks for flatpak.

In D19324 the icons for code and code-oss were added, which also need symbolic links for Flatpak (com.visualstudio.code & com.visualstudio.code.oss)

Mar 8 2019, 8:03 AM · Frameworks

Mar 6 2019

nibags added a comment to D18673: Add symlinks for flatpak.

+1
Also missing the symlink for JDownloader (org.jdownloader.JDownloader.svg): https://flathub.org/apps/details/org.jdownloader.JDownloader

Mar 6 2019, 10:01 PM · Frameworks

Mar 5 2019

nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

I want to check the colors of this highlighter before doing the commit

Mar 5 2019, 10:34 PM · Frameworks, Kate
nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.

Use: cmake ./ && make to compile

Mar 5 2019, 7:12 AM · Frameworks, Kate
nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

I still have problems with dsError + underline="0" :(
In "autotest/html" these aren't underlined, but when I open the file "test.logcat" with Kate, it's underlined.
I even tried creating a new Unix user, but the problem persists (I'm using KDE Frameworks 5.55.0).
Even removing the underlines in "Configure Kate -> Fonts & Colors", the problem persists.
Also clarify that the file "$HOME/.config/katesyntaxhighlightingrc" doesn't exist.

Mar 5 2019, 6:37 AM · Frameworks, Kate

Mar 4 2019

nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

Not seem, from what I see it is a recent bug. I just checked it in KDE Frameworks 5.48.0 (Fedora 28) and it works correctly

Mar 4 2019, 7:36 AM · Frameworks, Kate
nibags updated the diff for D19461: Logcat: fix dsError color with underline="0".
  • Add tests
Mar 4 2019, 7:25 AM · Frameworks, Kate

Mar 2 2019

nibags requested review of D19461: Logcat: fix dsError color with underline="0".
Mar 2 2019, 6:42 AM · Frameworks, Kate

Feb 27 2019

nibags added a comment to D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.

The MustacheJS highlight is modified in this diff: D19328

Feb 27 2019, 6:40 AM · Frameworks, Kate
nibags committed R216:de1ba2b6705c: MustacheJS: also highlight template files, fix syntax and improve support for… (authored by nibags).
MustacheJS: also highlight template files, fix syntax and improve support for…
Feb 27 2019, 6:38 AM
nibags closed D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars.
Feb 27 2019, 6:35 AM · Frameworks, Kate

Feb 26 2019

nibags requested review of D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars.
Feb 26 2019, 8:08 AM · Frameworks, Kate

Feb 23 2019

nibags requested review of D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP.
Feb 23 2019, 11:15 AM · Frameworks, Kate

Feb 13 2019

nibags added a comment to D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.

I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included

Feb 13 2019, 9:38 PM · Frameworks, Kate

Feb 12 2019

nibags committed R216:81a415fa3d6e: CubeScript: fixes line continuation escape in strings (authored by nibags).
CubeScript: fixes line continuation escape in strings
Feb 12 2019, 9:47 PM
nibags closed D18948: CubeScript: fixes line continuation escape in strings.
Feb 12 2019, 9:47 PM · Frameworks, Kate
nibags updated the diff for D18948: CubeScript: fixes line continuation escape in strings.
  • Add unit test
Feb 12 2019, 9:18 PM · Frameworks, Kate
nibags accepted D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".

It's good, I think it's a better solution ;D

Feb 12 2019, 9:05 PM · Frameworks, Kate
nibags updated the summary of D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.
Feb 12 2019, 11:48 AM · Frameworks, Kate
nibags requested review of D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.
Feb 12 2019, 11:38 AM · Frameworks, Kate
nibags requested review of D18949: R Markdown: improve folding of blocks.
Feb 12 2019, 11:27 AM · Frameworks, Kate