The function setDontChangeHlOnSave() uses the m_hlSetByUser variable to avoid resetting the syntax highlighting, which I removed in updateFileType().
I could use another binary for this.

Hi, @alvinhochun and @lsegovia!

@knambiar The config dialog for polygon annotations has seemingly regressed with recent changes:

Thanks @aacid. I've tested this and verified that it works. The code changes are a little bit over my head but @sander has reviewed them. I think it makes sense to land this.

In D21306#467715, @beischer wrote:

I'm on Arch Linux and '/usr/bin/python' is version 3.7.3. I don't know how the python version is determined in scripts run through 'perf script', unfortunately. Could be that they invoke /usr/bin/python (through #!/usr/bin/python?).

Fix review comments. Minor cleanups.

Please revert the QStringLiteral with utf8 inside, after that you can commit if you're convince there will be no regressions :)

I have not reviewed this, i am not thrilled about the licensing situation, but at least relicensing wouldn't be harder than for other people so if other people have reviewed this and made sure it breaks nothing and is a good improvement i won't get mad if this lands.

Maybe push to 4.0 branch?

https://cgit.kde.org/libkeduvocdocument.git/commit/?id=f21e006a12071d0e29cb06efa79d97ddb9bf9fcf

Your diff is a bit weird it removes code that doesn't exist.

Thanks. :)

I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?

Tested to compile, install and work as expected.

In D21301#467973, @ngraham wrote:

Fantastic. The dark inactive tab is maybe a bit too dark, but that's a fairly minor thing.

My bad, sorry. I should have done a closer code review. Fixed with 3a5cd96bfc92741e6fb6285b516934ffb76ae56f.

• rename variables

• switch declaration KFileWidgetPrivate::findMatchingFilter from bool to QString … again

fix

In D21279#468029, @davidedmundson wrote:

This is an ugly hack.

ActionItems ultimately end up in
SessionManagementScreen.qml:113

Row {
id: actionItemsLayout
}

A Row has a spacing property.

In D16648#468032, @feverfew wrote:

In D16648#468028, @fvogt wrote:

In D16648#467893, @feverfew wrote:

In D16648#467854, @fvogt wrote:

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.

QUrl::fromStringList and QUrl::toStringList were created for the express purpose of dealing with DBus calls: https://gitlab.com/pteam/pteam-qtbase/commit/6b9545a980f09d8fb034d930cfe67f6110357d0c.
In fact @dfaure was the one who created these functions himself :)
I think I'll stick with using those static methods unless there is a different reason to objection.

In D16648#468028, @fvogt wrote:

In D16648#467893, @feverfew wrote:

In D16648#467854, @fvogt wrote:

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.

There are still code styling issues, but too late...

This is an ugly hack.

In D16648#467893, @feverfew wrote:

In D16648#467854, @fvogt wrote:

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Thanks very much!

In D21312#467923, @abetts wrote:

Do you think this and other metrics could just be optional and enabled in settings, for example?

Sounds great! Basically just test the betas. And here's a link to the QA testcases ones for Disco: http://iso.qa.ubuntu.com/qatracker/milestones/403/builds/191460/testcases

Actually looks like we've got compilation errors now:

Reword Allow Expansion to Allow Expansion in Details View

Moving Continuous into the sub-menu amounts to a regression for menubar users since it becomes less noticeable in there. However I think there's an obvious solution: add the View Mode action to the default toobar, next to the Zoom combobox. Then all of this functionality becomes much much more noticeable for everyone, which is good because it's a part of the core functionality IMO.

+1 for this. I think it makes sense. Trying it out, I like it a lot.