tommo (Tom Moebert)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 12 2019, 5:07 PM (26 w, 1 d)
Availability
Available

Recent Activity

Fri, Nov 8

tommo added a comment to D25005: Fix image loading performance.

I've tested it and it works fine for me, thanks. One minor issue is noted below.

Fri, Nov 8, 1:30 PM · Gwenview

Mon, Nov 4

tommo added a comment to D25005: Fix image loading performance.

Ok. I would like to test this, will need a few days though.

Mon, Nov 4, 3:44 PM · Gwenview

Sat, Nov 2

tommo added a comment to D25005: Fix image loading performance.

The same determination is done in LoadingDocumentImpl::init().

Sat, Nov 2, 10:57 AM · Gwenview

Tue, Oct 29

tommo added a comment to D25005: Fix image loading performance.

That looks better, thanks. Not sure if it's the best place for the connect, but I'll leave that to Nate.

Tue, Oct 29, 3:18 PM · Gwenview

Mon, Oct 28

tommo added a comment to D25005: Fix image loading performance.

make sure that an url passed on the command line is loaded and shown before the possibly long running dirlister

Mon, Oct 28, 2:49 PM · Gwenview

Wed, Oct 23

tommo added a comment to D24874: Fix temporary path in importer test unit.

Don't worry, Nate will apply it.

Wed, Oct 23, 7:30 AM · Gwenview

Mon, Oct 14

tommo added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Mon, Oct 14, 4:31 PM · Gwenview

Oct 12 2019

tommo added a comment to D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Oh, I didn't know about that, thx for the hint. Will see how it can be integrated.

Oct 12 2019, 1:00 PM · Gwenview

Oct 9 2019

tommo requested review of D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".
Oct 9 2019, 2:47 PM · Gwenview

Sep 14 2019

tommo added a comment to D23905: Modernize the signal-slot syntax.

Pls. note that the usage of CMAKE_CXX_STANDARD requires bumping cmake_minimum_required to 3.1.0 .

Sep 14 2019, 2:05 PM

Jul 18 2019

tommo added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

I vote against bumping Qt to 5.10 just because of a single obsolete method. Qt 5.9 is a LTS release, which is supported until May 2020. E.g. I'm using openSUSE Leap 15.1, which uses 5.9.7 . Also, QImage::sizeInBytes() is recommend for images bigger 2GiB, but I never had success to open images that big with Gwenview.

Jul 18 2019, 4:48 PM · Gwenview

Jul 7 2019

tommo updated the summary of D22305: Fix MIME type not determined for small files.
Jul 7 2019, 10:25 AM · Gwenview
tommo requested review of D22305: Fix MIME type not determined for small files.
Jul 7 2019, 10:22 AM · Gwenview

Jun 28 2019

tommo updated the diff for D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Jun 28 2019, 5:05 PM · Gwenview

Jun 27 2019

tommo updated subscribers of D21407: Disable smoothing thumbnails in LowResourceUsageMode.

@ngraham ping

Jun 27 2019, 3:21 PM · Gwenview

Jun 23 2019

tommo updated the diff for D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.

Added kconfig update script. Tested with make install and works as expected.

Jun 23 2019, 2:37 PM · Gwenview

Jun 2 2019

tommo added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Jun 2 2019, 5:51 AM · Gwenview

Jun 1 2019

tommo added a comment to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.

Need to postpone this until end of June.

Jun 1 2019, 11:46 AM · Gwenview
tommo updated the diff for D21398: Correctly crop Sony's embedded thumbnails.

Constness.

Jun 1 2019, 11:44 AM · Gwenview

May 25 2019

tommo added a comment to D21407: Disable smoothing thumbnails in LowResourceUsageMode.

...also a blurred thumbnail suggests that the image is defocused.

May 25 2019, 3:39 PM · Gwenview
tommo updated the diff for D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
May 25 2019, 3:37 PM · Gwenview
tommo updated the summary of D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
May 25 2019, 3:36 PM · Gwenview
tommo requested review of D21407: Disable smoothing thumbnails in LowResourceUsageMode.
May 25 2019, 3:36 PM · Gwenview
tommo requested review of D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
May 25 2019, 3:34 PM · Gwenview
tommo added a comment to D21398: Correctly crop Sony's embedded thumbnails.

Works for usual and panorama images, e.g.:

May 25 2019, 12:49 PM · Gwenview
tommo requested review of D21398: Correctly crop Sony's embedded thumbnails.
May 25 2019, 12:38 PM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

I haven't checked which folder Gwenview actually tries to delete, but the thumbnails are stored in ~/.cache/thumbnails instead of ~/.thumbnails.

May 25 2019, 3:32 AM · Documentation, Gwenview

May 24 2019

tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

You guys really have to setup clang-format or astyle to automate those whitespace formatting issues, IMO.

May 24 2019, 3:28 PM · Documentation, Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Fix unit test.

May 24 2019, 8:45 AM · Documentation, Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Sry, I missed that.

May 24 2019, 5:55 AM · Documentation, Gwenview

May 23 2019

tommo updated the diff for D21329: Correctly crop embedded thumbs for Canon JPEGs.
May 23 2019, 2:45 PM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Sry, I should really enable Kate's spell checking.

May 23 2019, 6:58 AM · Documentation, Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 23 2019, 6:49 AM · Gwenview
tommo updated subscribers of D21285: Remove redundant QImage::loadFromData().

@ngraham Missed?

May 23 2019, 6:32 AM · Gwenview
tommo updated subscribers of D21284: Accelerate thumnailgenerator when loading RAW files.

@ngraham Missed?

May 23 2019, 6:32 AM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Docs updated. Need to apply https://phabricator.kde.org/D21329 first, to avoid conflict.

May 23 2019, 6:30 AM · Documentation, Gwenview
tommo updated the diff for D21337: Do not re-use previously generated thumbnails in case of error.
May 23 2019, 4:53 AM · Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
May 23 2019, 4:49 AM · Gwenview

May 22 2019

tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

I really can't get used to high quality thumbnails. The problem with your approach is that it puts (IMO unnecessary) load on memory bus and CPU: First we would crawl through all files in the directory to quickly display the embedded thumbnail and in a second run we open and decode picture by picture just for generating nice high quality thumbs. This reminds me of https://bugs.kde.org/show_bug.cgi?id=331435

May 22 2019, 4:48 PM · Documentation, Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
May 22 2019, 4:36 PM · Gwenview
tommo added a comment to D21337: Do not re-use previously generated thumbnails in case of error.

I just followed the steps to repeat described in the bug, i.e. create an empty file: touch test.jpg

May 22 2019, 4:29 PM · Gwenview
tommo added a watcher for Gwenview: tommo.
May 22 2019, 11:55 AM
tommo updated the summary of D21337: Do not re-use previously generated thumbnails in case of error.
May 22 2019, 11:52 AM · Gwenview
tommo requested review of D21337: Do not re-use previously generated thumbnails in case of error.
May 22 2019, 11:43 AM · Gwenview
tommo requested review of D21333: Update copyright year to 2019.
May 22 2019, 10:39 AM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

P.S.: The unit test fails expectedly. However, I'd first like to get some feedback before fixing it.

May 22 2019, 10:00 AM · Documentation, Gwenview
tommo set the repository for D21292: Remove orphaned member to R260 Gwenview.
May 22 2019, 6:45 AM · Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
May 22 2019, 5:49 AM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Attached is a screenshot demonstrating this suggestion. Even at 512px big thumbs, the embedded thumbnail (160x120) is big enough to get a rough idea of what's on the picture: A landscape, an animal, maybe which one? (not sure if you can tell the difference between a horse and a donkey, but IMO this isn't the purpose of a thumbnail preview anyway.)

May 22 2019, 5:36 AM · Documentation, Gwenview
tommo requested review of D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
May 22 2019, 5:20 AM · Documentation, Gwenview
tommo updated the summary of D21329: Correctly crop embedded thumbs for Canon JPEGs.
May 22 2019, 3:56 AM · Gwenview
tommo added a comment to D21329: Correctly crop embedded thumbs for Canon JPEGs.

Example Canon thumbnail attached:

May 22 2019, 3:50 AM · Gwenview
tommo requested review of D21329: Correctly crop embedded thumbs for Canon JPEGs.
May 22 2019, 3:49 AM · Gwenview

May 21 2019

tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Unit test fixed. Unfortunately I can't avoid QFile::readAll() entirely. When the same file is saved as the one already open through mem-mapping, we are in trouble when writing to that file: "It is unspecified whether modifications made to the file made after the mapping is created will be visible through the mapped memory." Apparently this might be the case and causes strange behavior when working with the input data later on. And I can't simply unmap the input data, as it may be needed for transformation. Thus postpone QFile::readAll() to JpegContent::save(). At least it speeds up the thumbnail generator.

May 21 2019, 4:34 PM · Gwenview

May 19 2019

tommo updated the diff for D21292: Remove orphaned member.
May 19 2019, 3:42 PM · Gwenview
tommo requested review of D21292: Remove orphaned member.
May 19 2019, 2:32 PM · Gwenview
tommo requested review of D21285: Remove redundant QImage::loadFromData().
May 19 2019, 9:40 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:36 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:33 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:33 AM · Gwenview
tommo requested review of D21284: Accelerate thumnailgenerator when loading RAW files.
May 19 2019, 8:32 AM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Typo.

May 19 2019, 3:58 AM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Use private mapping and handle nullptr.

May 19 2019, 3:49 AM · Gwenview

May 17 2019

tommo requested review of D21260: Accelerate thumnailgenerator when loading JpegContent.
May 17 2019, 5:42 PM · Gwenview

May 14 2019

tommo added a comment to D21163: Ensure the loading indicator is actually displayed.

Can you provide your full name and email address so we can land this patch with correct authorship information?

May 14 2019, 3:30 PM · Gwenview
tommo added a comment to D21161: Fix incomplete EXIF data for RAW files.

I actually don't have any RAW images I can use to test this.

May 14 2019, 3:30 PM · Gwenview

May 12 2019

tommo requested review of D21163: Ensure the loading indicator is actually displayed.
May 12 2019, 5:43 PM · Gwenview
tommo requested review of D21161: Fix incomplete EXIF data for RAW files.
May 12 2019, 5:15 PM · Gwenview