- User Since
- Dec 1 2015, 3:40 PM (168 w, 2 d)
Sat, Feb 16
I’m ok with it.
Fri, Feb 15
- More guards removed.
- Remove unused include
Thu, Feb 14
- Fix compilation
already merged and a followup was also merged fixing the issues related by @broulik
- Fix code style
- re-add assert
- Fix code style
Wed, Feb 13
There are two different patches for that, one from myself that adds a dim
effect (that Kurt asked to remove from this change set) and another one
that implements a header, also in a different review (but not from myself
and I don’t have the review number on my head).
Be my guest
- don't copy the map
- Call directly, lambda is uneeded here.
- Remove unused function - a findChildren is what it's needed
- Properly count the number of Terminals
- Fix creation of splits in the middle of the grid
- Remove Dim code: I'll add that to another review
- Remove deprecated code
- Refactor to reduce the number of boilerplate
- Fix updating the detach menus
- Dim unfocused terminals
- Rebase on master
While I'm reopening this I have zero time to tackle this right now because of real work.
Tue, Feb 12
They aren’t, just forgot to remove all of them
Mon, Feb 11
Sun, Feb 10
seems pretty straigthforward.
Sat, Feb 9
I tough about that but it’s not that easy unless we also refactor the
Profile class, because everything in the profile class is stored inside a
map. It would be quite expensive to always access it.
Fri, Feb 8
geh, then let's keep this one and remove the other one.
I'll close this one, let's use yours.
Wed, Feb 6
Tue, Feb 5
please rebase on top of master, there's a conflict.
Mon, Feb 4
@ngraham is this accepted? I can't tel because of the talk after the last ok.
Sat, Feb 2
I have also a patch for Yakuake to fix them too, they are using one kpart
per view instead of using the tabbar that konsole part provides. :/
This week it will be hard for me to touch this code but I’ll see what I can
Wed, Jan 30
No; both are unrelated
I agree with the change, specially that now there's a warning on implicit falltrougth
I still don't like the shared ptr but let's go with that for now.
Tue, Jan 29
Let me interfeer a bit.
- Accept commas for PID
Mon, Jan 28
@apol can you also check here?