tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (157 w, 5 d)
Availability
Available

Recent Activity

Yesterday

tcanabrava updated the diff for D17267: Don't duplicate the tabs when Spliting the View.
  • Allow to move a tab between splitters
  • Simplify Check
  • Fix tab management
  • currentTabChanged was never connected
  • Fix the redraw after focus
  • Create the default container on constructor
  • Return the current tabWidget from the view
  • Be explicit in where we are creating the new session
  • Always pass the tab that the session will be created
  • Export the ViewContainer
  • Expand the signals / slots to use the tabWidget
  • After cretaing the view, focus it
  • If a side of the split is close, focus another tab
  • Fix size of the new Tab
Sun, Dec 9, 12:58 PM · Konsole

Sat, Dec 8

tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

As usual thanks for the really good review.
I’ll address the Points tomorrow as today I’m traveling.

Sat, Dec 8, 5:27 PM · Konsole

Thu, Dec 6

tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

The last fix (opening a tab by double clicking on the empty space on the tabbar) was a bit more intrusive than what I wanted (as the signal must be forwarded to the MainWindow / KPart, to be forwarded back and the pointer to the TabWidget that was clicked needed to be in the callchain. To make it more safe I removed the signal-casts in the connect changing the names of the signals, keeping compile-time correctness, so I'm pretty sure I didn't broke code by doing that. The calls that could use the ~default~ tab now just ask for activeContainer() as a parameter. in the end the code is a bit safer and more explicit on what's happening.

Thu, Dec 6, 2:50 PM · Konsole
tcanabrava updated the diff for D17267: Don't duplicate the tabs when Spliting the View.
  • Allow to move a tab between splitters
  • Simplify Check
  • Fix tab management
  • currentTabChanged was never connected
  • Fix the redraw after focus
  • Create the default container on constructor
  • Return the current tabWidget from the view
  • Be explicit in where we are creating the new session
  • Always pass the tab that the session will be created
  • Export the ViewContainer
  • Expand the signals / slots to use the tabWidget
Thu, Dec 6, 2:46 PM · Konsole

Wed, Dec 5

tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Ok, I'll take a look.
Seems easy to fix.

Wed, Dec 5, 5:21 PM · Konsole
tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

considering that this is a behavioral change I'll wait for @hindenburg ok to merge this.

Wed, Dec 5, 11:04 AM · Konsole

Tue, Dec 4

tcanabrava updated the diff for D17267: Don't duplicate the tabs when Spliting the View.
  • currentTabChanged was never connected
  • Fix the redraw after focus
Tue, Dec 4, 9:30 PM · Konsole
tcanabrava added a comment to D17329: Simplify/Speedup reading Stylesheet file.

That makes sense if you are processing the line and doing something with it
and discarding, but not appending to a string doing nothing with it until
the result is the whole file content. If what you want is the same as the
readAll, this one is faster as there’s no allocations for the temporary.

Tue, Dec 4, 7:36 AM · Konsole

Mon, Dec 3

tcanabrava updated subscribers of D17267: Don't duplicate the tabs when Spliting the View.

untill you click on it. I'v realized that but I belive this is not a
blocker. The TerminalDisplay has *too many* issues not redrawing correctly
after a move untill someone clicks on it or it gains focus.

Mon, Dec 3, 12:37 PM · Konsole
tcanabrava added a reviewer for D17329: Simplify/Speedup reading Stylesheet file: hindenburg.
Mon, Dec 3, 12:16 PM · Konsole
tcanabrava requested review of D17329: Simplify/Speedup reading Stylesheet file.
Mon, Dec 3, 12:14 PM · Konsole
tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Ready for review, I belive I killed all the bugs related to this.

Mon, Dec 3, 11:56 AM · Konsole
tcanabrava updated the diff for D17267: Don't duplicate the tabs when Spliting the View.
  • Fix tab management
Mon, Dec 3, 11:56 AM · Konsole
tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

There's still one bug when I try to drag a tab from a window *back* into another window when I just habe one tab. I need to fix that before having an accept.

Mon, Dec 3, 9:25 AM · Konsole
tcanabrava updated the diff for D17267: Don't duplicate the tabs when Spliting the View.
  • Simplify Check
Mon, Dec 3, 9:21 AM · Konsole

Sun, Dec 2

tcanabrava updated the diff for D17267: Don't duplicate the tabs when Spliting the View.
  • Allow to move a tab between splitters
Sun, Dec 2, 10:08 PM · Konsole

Fri, Nov 30

tcanabrava updated subscribers of D17267: Don't duplicate the tabs when Spliting the View.

I plan to remove the hability to have tabs per split in the future, I
believe an implementation like terminator makes more sense. One Tabbar,
splits inside of the tabs. But konsole code is really tied and I’m doing
many cleanup commits just to be able to change that in the future.

Fri, Nov 30, 9:30 PM · Konsole
tcanabrava added reviewers for D17267: Don't duplicate the tabs when Spliting the View: thsurrel, hindenburg, gennad.
Fri, Nov 30, 5:02 PM · Konsole
tcanabrava abandoned D17261: Don't duplicate the tabs when Spliting the View.

arc diff created a new revision instead of updating this one, sorry for the noise. https://phabricator.kde.org/D17267

Fri, Nov 30, 5:01 PM · Konsole
tcanabrava requested review of D17267: Don't duplicate the tabs when Spliting the View.
Fri, Nov 30, 4:59 PM · Konsole
tcanabrava added a comment to D17261: Don't duplicate the tabs when Spliting the View.

I'm a bit lost on what cause it so I accept help if you have a bit of time.
The crash is inside the eventFilter of the mainwindow with the following
backtrace:

Fri, Nov 30, 4:45 PM · Konsole
tcanabrava updated subscribers of D17261: Don't duplicate the tabs when Spliting the View.

sorry for the crash, I'm researching what caused it.

Fri, Nov 30, 3:53 PM · Konsole
tcanabrava added a comment to D17261: Don't duplicate the tabs when Spliting the View.

before:

Fri, Nov 30, 3:15 PM · Konsole
tcanabrava requested review of D17261: Don't duplicate the tabs when Spliting the View.
Fri, Nov 30, 3:11 PM · Konsole

Wed, Nov 28

tcanabrava requested review of D17222: Remove virtual for non-virtual calls.
Wed, Nov 28, 6:34 PM · Konsole
tcanabrava requested review of D17221: Don't hide setFont, it's not virtual.
Wed, Nov 28, 6:32 PM · Konsole

Fri, Nov 23

tcanabrava accepted D17117: Prevent Canceled FileChooser from calling print.
Fri, Nov 23, 3:04 PM · Atelier
tcanabrava accepted D17120: Implement zooming with Ctrl+mouse wheel.

repaint will trigger a reppaint forcefully, if you use update() are we skipping frames?

Fri, Nov 23, 3:04 PM · Documentation, KDE Edu
tcanabrava accepted D17101: Make atcore Clazy tidy.
Fri, Nov 23, 2:58 PM · Atelier: AtCore
tcanabrava accepted D17116: Improve the UI for MainWindow::askToSave.
Fri, Nov 23, 2:57 PM · Atelier
tcanabrava accepted D17106: Atelier Clazy-tidy.

Just a nitpick, an empty QString should be QString(), not QString("")

Fri, Nov 23, 10:35 AM · Atelier
tcanabrava requested changes to D17116: Improve the UI for MainWindow::askToSave.
Fri, Nov 23, 10:33 AM · Atelier
tcanabrava requested changes to D17120: Implement zooming with Ctrl+mouse wheel.
Fri, Nov 23, 10:32 AM · Documentation, KDE Edu
tcanabrava added a reviewer for D17121: Fix regression: duplicates were shown again: gregormi.
Fri, Nov 23, 10:08 AM · Kate
tcanabrava requested review of D17121: Fix regression: duplicates were shown again.
Fri, Nov 23, 10:07 AM · Kate
tcanabrava added a comment to D16706: Hide tabbar in KParts.

Well, the code that got in qApp->applicationName() == "konsole" shouldn't be part of a class, it's a perfectly valid function. this would fix everything. I'll prepare a patch for this later.

Fri, Nov 23, 8:40 AM · Konsole

Wed, Nov 21

tcanabrava accepted D16928: Do not show "+" for positive numbers if user do not want this.
Wed, Nov 21, 2:27 PM · Documentation, KDE Edu
tcanabrava accepted D16855: Adjust formula for lateral area's icon size.
Wed, Nov 21, 2:26 PM · Atelier: General Development
tcanabrava added a comment to D16928: Do not show "+" for positive numbers if user do not want this.

I wouldn't add this. it's just more clutter to the code and to the settings.
mathematically speaking, if a number is not prepended with a sign, it's positive.
I would say to drop the '+' instead of adding a configuration for that.

Wed, Nov 21, 12:11 PM · Documentation, KDE Edu
tcanabrava accepted D16976: Temperature Object Improvements.

I don't understand why patrick wanted all regular expressions to be static const (I would create them as non-static, but that's a non issue)

Wed, Nov 21, 12:09 PM · Atelier: AtCore

Thu, Nov 15

tcanabrava committed R337:cccaa1253526: Removed old-style casting warnings (authored by msuarez).
Removed old-style casting warnings
Thu, Nov 15, 4:04 PM
tcanabrava closed D16863: Removed old-style casting warnings.
Thu, Nov 15, 4:04 PM · KDE Edu
tcanabrava accepted D16863: Removed old-style casting warnings.
Thu, Nov 15, 3:53 PM · KDE Edu
tcanabrava requested changes to D16863: Removed old-style casting warnings.

Waiting for the whitespace clenaup before merging.

Thu, Nov 15, 2:50 PM · KDE Edu
tcanabrava added a comment to D16863: Removed old-style casting warnings.
In D16863#358962, @apol wrote:

Note you have changed the indentation of the modified lines. Make sure indentation isn't changed (unless it's required specificly).

Thu, Nov 15, 2:50 PM · KDE Edu
tcanabrava accepted D10367: Fix color bar painting failures in statistics main window.
Thu, Nov 15, 1:37 PM · KDE Edu

Nov 7 2018

tcanabrava accepted D15739: [Places panel] Don't show Root by default.

too many +1 to not be accepted.

Nov 7 2018, 3:29 PM · Frameworks

Nov 6 2018

tcanabrava abandoned D16669: Dont show tabs if in KParts mode.

arc diff created a new revision, sorry for that. https://phabricator.kde.org/D16706

Nov 6 2018, 12:23 PM · Konsole
tcanabrava added a reviewer for D16706: Hide tabbar in KParts: hindenburg.
Nov 6 2018, 12:22 PM · Konsole
tcanabrava requested review of D16706: Hide tabbar in KParts.
Nov 6 2018, 12:21 PM · Konsole
tcanabrava accepted D16463: QtMath now provides M_PI constant, operations with degrees, and c++ provides round().
Nov 6 2018, 9:24 AM · KDE Edu
tcanabrava added a comment to D16669: Dont show tabs if in KParts mode.

I didn't, I looked for isPart, isKPart but my grep didn't try
isKonsokePart. I'll update the code.

Nov 6 2018, 8:10 AM · Konsole

Nov 5 2018

tcanabrava added a comment to D16138: Create the default profile if it doesn't exist.

well I'm a bit confused why I don't see your results under the current master branch - I've tried 2 different VMs and verified there are no konsole files anywhere and get the results I mentioned above.

Nov 5 2018, 8:41 AM · Konsole
tcanabrava accepted D16629: Allow hide/show unfocused items in the function list.

While this seems correct the code feels like it should be part of a model. I'm +1 this but can you add a TODO: to create a proper model later?

Nov 5 2018, 8:40 AM · KDE Edu
tcanabrava accepted D15518: Editor - Line highlighting color fix.
Nov 5 2018, 8:39 AM · KDE Edu

Nov 4 2018

tcanabrava added reviewers for D16669: Dont show tabs if in KParts mode: hindenburg, sandsmark, ngraham.
Nov 4 2018, 7:31 PM · Konsole
tcanabrava requested review of D16669: Dont show tabs if in KParts mode.
Nov 4 2018, 7:30 PM · Konsole

Nov 2 2018

tcanabrava requested changes to D15518: Editor - Line highlighting color fix.

Just this small thing and it can go in.

Nov 2 2018, 4:44 PM · KDE Edu
tcanabrava accepted D16597: Add items to news feeds as they are received..
Nov 2 2018, 4:29 PM · Atelier: General Development
tcanabrava requested changes to D16463: QtMath now provides M_PI constant, operations with degrees, and c++ provides round().
Nov 2 2018, 4:28 PM · KDE Edu
tcanabrava accepted D16146: Remove KNS support.

We can always revert when this is working again

Nov 2 2018, 4:26 PM · KDE Edu
tcanabrava accepted D10370: Fix parsing of sound and image urls with relative paths.
Nov 2 2018, 4:20 PM · KDE Edu
tcanabrava added a comment to D10367: Fix color bar painting failures in statistics main window.

Can you post a screenshoot of the before / after?

Nov 2 2018, 4:19 PM · KDE Edu
tcanabrava requested changes to D9395: Configuration capabilities for online dictionaries.
Nov 2 2018, 4:18 PM · KDE Edu
tcanabrava requested changes to D8204: Make parents and children Return References.
Nov 2 2018, 4:15 PM · KDE Edu
Restricted Application added a project to D8204: Make parents and children Return References: KDE Edu.
Nov 2 2018, 4:13 PM · KDE Edu

Oct 31 2018

tcanabrava created T9964: Create Workboard for KDE Edu and subprojects.
Oct 31 2018, 4:33 PM · Sysadmin
tcanabrava created T9963: Create Minuet project in phabricator.
Oct 31 2018, 4:32 PM · Sysadmin
tcanabrava created T9962: Create Kalzium Project in Phabricator.
Oct 31 2018, 4:31 PM · Sysadmin
tcanabrava created T9961: Create Rocs Project in Phabricator.
Oct 31 2018, 4:30 PM · Sysadmin
tcanabrava created T9960: Create KTurtle Project in Phabricator.
Oct 31 2018, 4:29 PM · Sysadmin
tcanabrava added a member for KDE Edu: tcanabrava.
Oct 31 2018, 8:26 AM

Oct 21 2018

tcanabrava accepted D16199: Make SerialLayer completely private.
Oct 21 2018, 4:02 PM · Atelier: AtCore
tcanabrava added a comment to D15518: Editor - Line highlighting color fix.

ping?

Oct 21 2018, 3:34 PM · KDE Edu

Oct 17 2018

tcanabrava updated subscribers of D16204: Quick Open: Remove "file:///" prefix from file paths.

You have to rebase, and probably fix the conflict because I moved the code
to a real model.

Oct 17 2018, 12:38 PM · Kate
tcanabrava committed R40:d6e38c0cbd3d: Fix Duplicates on Quick Open File (authored by tcanabrava).
Fix Duplicates on Quick Open File
Oct 17 2018, 10:01 AM
tcanabrava closed D15804: Fix Duplicates on Quick Open File.
Oct 17 2018, 10:01 AM · Kate

Oct 16 2018

tcanabrava added a comment to D15804: Fix Duplicates on Quick Open File.

now I need a re-acceptance.

Oct 16 2018, 2:14 PM · Kate
tcanabrava added a comment to D15804: Fix Duplicates on Quick Open File.

There, no more std::get nor cast from enum ;)

Oct 16 2018, 2:13 PM · Kate
tcanabrava updated the diff for D15804: Fix Duplicates on Quick Open File.
  • Implement the QuickOpen as a TableModel
  • Code Cleanup
  • Fix displayign in bold the open files
  • Add License
  • Use struct instead of std::tuple
Oct 16 2018, 2:09 PM · Kate
tcanabrava accepted D16144: Send bedSize to 3dviewer.
Oct 16 2018, 11:33 AM · Atelier: General Development
tcanabrava accepted D16200: Use SerialLayer()->pushCommand in only in processQueue.
Oct 16 2018, 11:32 AM · Atelier: AtCore
tcanabrava requested changes to D16181: Move final terminator in firmware plugin side.
Oct 16 2018, 11:32 AM

Oct 15 2018

tcanabrava committed R73:ba719a2b569f: Specifying http protocol when getting Open Sans font to fix Scripting API (authored by luansimoes).
Specifying http protocol when getting Open Sans font to fix Scripting API
Oct 15 2018, 8:37 AM
tcanabrava closed D16164: Specifying http protocol when getting Open Sans font to fix Scripting API.
Oct 15 2018, 8:36 AM · KDE Edu
tcanabrava accepted D16164: Specifying http protocol when getting Open Sans font to fix Scripting API.
Oct 15 2018, 8:32 AM · KDE Edu

Oct 14 2018

tcanabrava updated subscribers of D16134: Secure history file.

If the user has a encrypted disk but the disk is mounted, then this is
userfull to not allow other mallicious app in the same disk to peek into
the history file, no?

Oct 14 2018, 10:10 PM · Konsole
tcanabrava requested changes to D16164: Specifying http protocol when getting Open Sans font to fix Scripting API.

Strings with spaces should be inside quotes., just like the Helvetica Neue is.

Oct 14 2018, 7:33 AM · KDE Edu
tcanabrava committed R73:f55393740292: Fixed wrong position of added nodes. (authored by Fernando Costa <fernandocr@id.uff.br>).
Fixed wrong position of added nodes.
Oct 14 2018, 7:30 AM
tcanabrava closed D16185: Fixed wrong position of added nodes..
Oct 14 2018, 7:30 AM · KDE Edu
tcanabrava accepted D16185: Fixed wrong position of added nodes..
Oct 14 2018, 7:30 AM · KDE Edu

Oct 13 2018

tcanabrava committed R337:9d028a06f6a9: Change null pointer reference from zero to nullptr (authored by Shroudmaster).
Change null pointer reference from zero to nullptr
Oct 13 2018, 7:03 PM
tcanabrava closed D16143: Change null pointer reference from zero to nullptr.
Oct 13 2018, 7:03 PM · KDE Edu
tcanabrava accepted D16143: Change null pointer reference from zero to nullptr.
Oct 13 2018, 7:02 PM · KDE Edu
tcanabrava committed R73:844fca994663: Keeping the given code document filename consistent. (authored by Fernando Costa <fernandocr@id.uff.br>).
Keeping the given code document filename consistent.
Oct 13 2018, 9:14 AM
tcanabrava closed D16156: Keeping the given code document filename consistent..
Oct 13 2018, 9:14 AM · KDE Edu
tcanabrava accepted D16156: Keeping the given code document filename consistent..
Oct 13 2018, 9:13 AM · KDE Edu
tcanabrava added a comment to D16164: Specifying http protocol when getting Open Sans font to fix Scripting API.

I don't like that. What happens if the person is not int he internet? can you remove that url completely and see if it works?
*if* it works, I'd rather remove the need to be on the internet.

Oct 13 2018, 9:12 AM · KDE Edu
tcanabrava added a comment to D16134: Secure history file.

I asked @frederico to run in an old notebook that he has with a Celeron u2300 1.2GHz running Debian Buster.
He used find in its home folder to test. After some time I asked him to scroll back and forth and tell if he noticed any difference.
Apparently he did not found any noticeable difference.

Oct 13 2018, 9:11 AM · Konsole
tcanabrava accepted D16129: Allow to control the bed dimensions.

Yes, I went for my own properties due to more precise naming, but I admit I don't mind either way on the technical level. So what should I do? Change it or stay as is? You guys seem to disagree a bit. :-)

Oct 13 2018, 9:09 AM