- User Since
- Dec 1 2015, 3:40 PM (184 w, 4 d)
You can jusr click in the "commit" button on the gitlab review.
Thu, Jun 13
@cfeck any objections here? I'll wait a few days for an outcome.
Wed, Jun 5
Mon, Jun 3
Moving to gitlab
moving to gitlab
Moving to gitlab
Tue, May 28
lutris also depends on gnome-desktop (the library)
Thu, May 23
Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)
I use as focus mode. And the google icon will remember you that you are in
“fake full screen” mode.
If you look at the other terminals that offer multi split they also offer
We are but it’s a per project basis
Tue, May 21
I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?
- Add license headers
- Palette highligth fixes
- Icon / Tooltip
- Fix build
- Add toggle of the Maximize / Minimize split
@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?
phabricator is tracking the wrong branch , it's *not* merged. (can I have a review? :)
Mon, May 20
- Add HeaderBar to TerminalDisplay
Fri, May 17
May 16 2019
May 15 2019
May 14 2019
I'll wait kurt's comments as I'm sure this is a hack and not a proper fix.
May 11 2019
I’ll look the warnings, none of them appear on Gcc. Should be a clazy
May 10 2019
May 8 2019
@ngraham as this needs input from the VDG
I personally love the idea, I would change the half of the page dimm effect by a thin line on the side (like kdevelop shows for edited lines)
May 7 2019
Seriously much. As the splits in master are in no way near what they where
before. But you might consider trying master, you might like the current
(It actually splits).
For the old behavior there was just 2 complaints, your and someone that
talked to me on email, and I’ll ask you the same thing I asked him. Try to
help with patches to have the old behavior back as a mirror tabs feature.
I’m trying to solve as many bugs as I can, but I can’t do that alone :)
May 6 2019
can you put a screenshoot of the before / after ? I can't really read math.
Apr 30 2019
Apr 26 2019
The proces of creation / destructiion / management of the views is a bit more complex. I'll gladly accept a patch but one that actually helps to clean the current behavior. This one just hides complexity.
O don’t really get it. Why this code needs to go to MainWindow and not to
Seems to me that the class that should have knowledge on how to create the
tabs is not mainwindow.
Apr 23 2019
Apr 20 2019
Mind you guys that the internal implementation without a profile is kinda
broken, so this patch makes sense to me.
Apr 17 2019
None, I’m ok with it
Apr 12 2019
Ok, I'll update the code for that.
- Remove useless lambda
- Add missing label, Add tooltips
Apr 11 2019
Only because I’m forbidden to remove configuration options that exist, for
me this is one of those niche cases that shouldn’t exist.
I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?