tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (184 w, 4 d)
Availability
Available

Recent Activity

Yesterday

tcanabrava added a comment to D20816: Configure Konsole dialog GUI redesign.

You can jusr click in the "commit" button on the gitlab review.

Sat, Jun 15, 5:00 PM · VDG, Konsole
tcanabrava committed R319:22356315c161: Fixes logic for Maximize / Restore terminals (authored by tcanabrava).
Fixes logic for Maximize / Restore terminals
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:ed946b5708ea: Use breeze inactive-tab color for inactive splits (authored by tcanabrava).
Use breeze inactive-tab color for inactive splits
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:dc0663833e39: Block mouse events in the header bar (authored by tcanabrava).
Block mouse events in the header bar
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:3eb09319f907: Paint the line as the TabBar separator for consistency (authored by tcanabrava).
Paint the line as the TabBar separator for consistency
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:b4ab5fe920da: Paint a 1px border at the top between the menu and the splitters (authored by tcanabrava).
Paint a 1px border at the top between the menu and the splitters
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:e83707fe45ca: Add a TerminalHeader when using splits (authored by tcanabrava).
Add a TerminalHeader when using splits
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:c9967fb4c278: Use only one accelerator to Maximize / Unmaximize a split view (authored by tcanabrava).
Use only one accelerator to Maximize / Unmaximize a split view
Sat, Jun 15, 2:56 PM
tcanabrava committed R319:4c39ef39f42b: Fix the logic for Maximize / Minimize (authored by tcanabrava).
Fix the logic for Maximize / Minimize
Sat, Jun 15, 2:56 PM

Thu, Jun 13

tcanabrava added a comment to D21495: Use MPFR in knumber_float in order to improve floating-point precision.

@cfeck any objections here? I'll wait a few days for an outcome.

Thu, Jun 13, 1:32 PM

Wed, Jun 5

tcanabrava committed R954:f3d40d465ff3: Re-add tomaz blog (authored by tcanabrava).
Re-add tomaz blog
Wed, Jun 5, 9:42 AM

Mon, Jun 3

tcanabrava added inline comments to D21567: Use QString::replace(QChar, QString) in place of QString::replace(QRegEx, QString) in LogWidget::appendSLog.
Mon, Jun 3, 8:06 PM
tcanabrava abandoned D21301: Add a TerminalHeader when using splits.

Moving to gitlab

Mon, Jun 3, 2:23 PM · Konsole
tcanabrava abandoned D21309: Use only one accelerator to Maximize / Unmaximize a split view.

moving to gitlab

Mon, Jun 3, 2:14 PM · Konsole
tcanabrava abandoned D21308: Fix the logic for Maximize / Minimize.

Moving to gitlab

Mon, Jun 3, 2:13 PM · Konsole

Tue, May 28

tcanabrava added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

lutris also depends on gnome-desktop (the library)

Tue, May 28, 7:07 AM · KDE Promo

Thu, May 23

tcanabrava added a comment to D21308: Fix the logic for Maximize / Minimize.

Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)

Thu, May 23, 5:51 PM · Konsole
tcanabrava added a comment to D21309: Use only one accelerator to Maximize / Unmaximize a split view.

I use as focus mode. And the google icon will remember you that you are in
“fake full screen” mode.
If you look at the other terminals that offer multi split they also offer
this.

Thu, May 23, 4:39 PM · Konsole
tcanabrava updated subscribers of D21301: Add a TerminalHeader when using splits.

We are but it’s a per project basis

Thu, May 23, 4:38 PM · Konsole

Tue, May 21

tcanabrava accepted D21325: template: check order before access.
Tue, May 21, 9:21 PM · Konsole
tcanabrava updated subscribers of D21301: Add a TerminalHeader when using splits.

I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?

Tue, May 21, 7:32 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add license headers
Tue, May 21, 4:13 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Palette highligth fixes
Tue, May 21, 3:35 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Icon / Tooltip
Tue, May 21, 3:10 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Fix build
Tue, May 21, 2:51 PM · Konsole
tcanabrava committed R319:d375a694a440: Hide scroll buttons for tabs (authored by tcanabrava).
Hide scroll buttons for tabs
Tue, May 21, 2:42 PM
tcanabrava closed D21316: Hide scroll buttons for tabs.
Tue, May 21, 2:42 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add toggle of the Maximize / Minimize split
Tue, May 21, 2:36 PM · Konsole
tcanabrava added a comment to D21301: Add a TerminalHeader when using splits.

@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?

Tue, May 21, 2:06 PM · Konsole
tcanabrava reopened D21301: Add a TerminalHeader when using splits.

phabricator is tracking the wrong branch , it's *not* merged. (can I have a review? :)

Tue, May 21, 2:05 PM · Konsole
tcanabrava committed R319:b83382b42570: Trigger a detach (authored by tcanabrava).
Trigger a detach
Tue, May 21, 1:59 PM
tcanabrava committed R319:04268e75aeba: Start the work to Drag & drop The splits (authored by tcanabrava).
Start the work to Drag & drop The splits
Tue, May 21, 1:59 PM
tcanabrava committed R319:bbcc8b808623: Add HeaderBar to TerminalDisplay (authored by tcanabrava).
Add HeaderBar to TerminalDisplay
Tue, May 21, 1:59 PM
tcanabrava closed D21301: Add a TerminalHeader when using splits.
Tue, May 21, 1:59 PM · Konsole
tcanabrava committed R319:067aca12c9c9: Relax rules for split selection via keyboard (authored by tcanabrava).
Relax rules for split selection via keyboard
Tue, May 21, 1:59 PM
tcanabrava requested review of D21316: Hide scroll buttons for tabs.
Tue, May 21, 9:48 AM · Konsole

Mon, May 20

tcanabrava added a reviewer for D21301: Add a TerminalHeader when using splits: ngraham.
Mon, May 20, 3:19 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add HeaderBar to TerminalDisplay
Mon, May 20, 3:18 PM · Konsole
tcanabrava added a reviewer for D21309: Use only one accelerator to Maximize / Unmaximize a split view: Konsole.
Mon, May 20, 3:03 PM · Konsole
tcanabrava added a reviewer for D21309: Use only one accelerator to Maximize / Unmaximize a split view: hindenburg.
Mon, May 20, 3:03 PM · Konsole
tcanabrava added reviewers for D21308: Fix the logic for Maximize / Minimize: ngraham, hindenburg, Konsole.
Mon, May 20, 3:02 PM · Konsole
tcanabrava requested review of D21309: Use only one accelerator to Maximize / Unmaximize a split view.
Mon, May 20, 2:37 PM · Konsole
tcanabrava requested review of D21308: Fix the logic for Maximize / Minimize.
Mon, May 20, 2:37 PM · Konsole
tcanabrava added reviewers for D21301: Add a TerminalHeader when using splits: Konsole, hindenburg.
Mon, May 20, 9:34 AM · Konsole
tcanabrava requested review of D21301: Add a TerminalHeader when using splits.
Mon, May 20, 9:32 AM · Konsole

Fri, May 17

tcanabrava requested review of D21263: Don't call << in a temporary vector.
Fri, May 17, 7:42 PM · KWin
tcanabrava requested review of D21262: Fix memory leak.
Fri, May 17, 7:37 PM · KWin

May 16 2019

tcanabrava committed R319:d79c1b908fa6: Remove function, Make other function work. (authored by tcanabrava).
Remove function, Make other function work.
May 16 2019, 9:52 AM
tcanabrava committed R319:9ba9727a00fc: Merge me later (authored by tcanabrava).
Merge me later
May 16 2019, 9:52 AM

May 15 2019

tcanabrava committed R319:e51642e2eb97: Headerbar ~Working~ (authored by tcanabrava).
Headerbar ~Working~
May 15 2019, 12:51 PM
tcanabrava committed R319:89c218f32e01: New Class: TerminalWidget (authored by tcanabrava).
New Class: TerminalWidget
May 15 2019, 12:51 PM
tcanabrava committed R319:09469b62bd88: New Class: TerminalHeaderBar (authored by tcanabrava).
New Class: TerminalHeaderBar
May 15 2019, 12:51 PM

May 14 2019

tcanabrava added a comment to D21216: Fix sessions not correcly loading untill a tab is focused.

I'll wait kurt's comments as I'm sure this is a hack and not a proper fix.

May 14 2019, 2:49 PM · Konsole
tcanabrava added reviewers for D21216: Fix sessions not correcly loading untill a tab is focused: ngraham, Konsole, hindenburg.
May 14 2019, 2:12 PM · Konsole
tcanabrava requested review of D21216: Fix sessions not correcly loading untill a tab is focused.
May 14 2019, 2:11 PM · Konsole

May 11 2019

tcanabrava updated subscribers of D21123: Compile without Q_FOREACH.

I’ll look the warnings, none of them appear on Gcc. Should be a clazy
warning

May 11 2019, 2:53 PM · Konsole

May 10 2019

tcanabrava added reviewers for D21124: Allow configuration of the Splitter Size: Konsole, ngraham, hindenburg.
May 10 2019, 12:46 PM · Konsole
tcanabrava requested review of D21124: Allow configuration of the Splitter Size.
May 10 2019, 12:45 PM · Konsole
tcanabrava added reviewers for D21123: Compile without Q_FOREACH: Konsole, hindenburg, sandsmark.
May 10 2019, 12:26 PM · Konsole
tcanabrava requested review of D21123: Compile without Q_FOREACH.
May 10 2019, 12:25 PM · Konsole
tcanabrava added reviewers for D21118: Toggle all actions when a session restore happens: ngraham, hindenburg, Konsole.
May 10 2019, 10:23 AM · Konsole
tcanabrava requested review of D21118: Toggle all actions when a session restore happens.
May 10 2019, 10:22 AM · Konsole

May 8 2019

tcanabrava accepted D21046: Fix hsv effect when applied to image.
May 8 2019, 9:06 AM
tcanabrava updated subscribers of D21055: Highlight lines coming into view when scrolling.

@ngraham as this needs input from the VDG
I personally love the idea, I would change the half of the page dimm effect by a thin line on the side (like kdevelop shows for edited lines)

May 8 2019, 9:06 AM · Konsole

May 7 2019

tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Seriously much. As the splits in master are in no way near what they where
before. But you might consider trying master, you might like the current
split behavior.
(It actually splits).
For the old behavior there was just 2 complaints, your and someone that
talked to me on email, and I’ll ask you the same thing I asked him. Try to
help with patches to have the old behavior back as a mirror tabs feature.
I’m trying to solve as many bugs as I can, but I can’t do that alone :)

May 7 2019, 7:20 PM · Konsole

May 6 2019

tcanabrava accepted D20535: Create Machine Information Object.
May 6 2019, 2:51 PM · Atelier: AtCore
tcanabrava added a comment to D21046: Fix hsv effect when applied to image.

can you put a screenshoot of the before / after ? I can't really read math.

May 6 2019, 2:38 PM
tcanabrava added a comment to D18854: Allow changing the foreground/text color of buttons.

ping?

May 6 2019, 12:24 PM
tcanabrava resigned from D15076: Build failures with KSyntaxHighlighting 5.49.
May 6 2019, 12:24 PM · KDE Edu
tcanabrava accepted D19482: Fix-ish scrollbar background with Qt Fusion style.
May 6 2019, 12:23 PM · Konsole
tcanabrava resigned from D19956: ki18n: updating memory manager and removing compile warnings.
May 6 2019, 12:23 PM · Frameworks
tcanabrava added inline comments to D17201: Fix for memory leak in SessionManagerFixed.
May 6 2019, 12:23 PM · KDE Edu
tcanabrava accepted D20334: Speed up invert colors effect.

ping?

May 6 2019, 12:21 PM
tcanabrava resigned from D19808: elisa: code edent.
May 6 2019, 12:21 PM
tcanabrava accepted D20335: Remove warning static member accessed through instance.
May 6 2019, 12:21 PM
tcanabrava accepted D20398: Remove warning: do not use 'else' after 'return'.
May 6 2019, 12:21 PM
tcanabrava added a comment to D20795: Remove warning - modernize: pass an argument by values and use std::move().

@pino ping?

May 6 2019, 12:19 PM

Apr 30 2019

tcanabrava committed R319:71417ac55e85: Return early if no Splitter (authored by tcanabrava).
Return early if no Splitter
Apr 30 2019, 8:46 AM

Apr 26 2019

tcanabrava requested changes to D20518: Enable multi-tab-only shortcuts after restoring a multi-tab session from session management.

The proces of creation / destructiion / management of the views is a bit more complex. I'll gladly accept a patch but one that actually helps to clean the current behavior. This one just hides complexity.

Apr 26 2019, 11:40 AM · Konsole
tcanabrava accepted D20794: Simplify function return by removing the redundant empty object.
Apr 26 2019, 11:36 AM
tcanabrava accepted D20836: Fix New tab behavior.
Apr 26 2019, 11:35 AM · Konsole
tcanabrava added a comment to D20836: Fix New tab behavior.

O don’t really get it. Why this code needs to go to MainWindow and not to
TabbedContainer ?
Seems to me that the class that should have knowledge on how to create the
tabs is not mainwindow.

Apr 26 2019, 9:07 AM · Konsole

Apr 23 2019

tcanabrava committed R231:10db899f14ee: Add override to clean up warnings (authored by laysrodrigues).
Add override to clean up warnings
Apr 23 2019, 11:20 AM
tcanabrava committed R231:2227f9a1cb9f: Add override to clean up warnings (authored by laysrodrigues).
Add override to clean up warnings
Apr 23 2019, 11:20 AM
tcanabrava closed D19085: Add override to clean up warnings.
Apr 23 2019, 11:20 AM
tcanabrava committed R649:7c0b056607a2: Turning on the rotation on 3D plot (authored by karinapassos).
Turning on the rotation on 3D plot
Apr 23 2019, 11:17 AM
tcanabrava closed D19627: Turning on the rotation on 3D plot .
Apr 23 2019, 11:17 AM
tcanabrava committed R323:1af7c48a2df4: Deprecating rotation function (authored by karinapassos).
Deprecating rotation function
Apr 23 2019, 11:14 AM
tcanabrava closed D19645: Deprecating rotation function.
Apr 23 2019, 11:14 AM · KDE Edu

Apr 20 2019

tcanabrava added a comment to D16138: Create the default profile if it doesn't exist.

Mind you guys that the internal implementation without a profile is kinda
broken, so this patch makes sense to me.

Apr 20 2019, 7:07 AM · Konsole

Apr 17 2019

tcanabrava updated subscribers of D20395: Ctrl-Tab should work in "split-only" view as well.

None, I’m ok with it

Apr 17 2019, 2:20 PM · Konsole

Apr 12 2019

tcanabrava added a comment to D20466: Rework scrollback settings.
In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Did you mean -1? :P Hiding part of an UI depending on selected option is bad UX. Moving another elements around because something appears is probably even worse.
It is also against KDE HIG: https://hig.kde.org/patterns/content/settings.html#implementation (last point)

About changes:

  • Maybe putting custom path field below radio button (and indenting it) would be better? Path which appear here will probably be longer than current field width (at least I think so), and it will not be needed to align it with fixed size field
  • All radio buttons had equal vertical spacing, and the left label was aligned to the first radio button
  • Button group instead of frame
  • Maybe kmessagebox instead of label?
Apr 12 2019, 4:23 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

Ok, I'll update the code for that.

Apr 12 2019, 1:28 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Another way to display this would be to only show the "info box" when unlimited is selected.

Apr 12 2019, 1:24 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Apr 12 2019, 1:22 PM · Konsole
tcanabrava updated the diff for D20466: Rework scrollback settings.
  • Remove useless lambda
Apr 12 2019, 7:57 AM · Konsole
tcanabrava updated the diff for D20466: Rework scrollback settings.
  • Add missing label, Add tooltips
Apr 12 2019, 7:53 AM · Konsole

Apr 11 2019

tcanabrava added a comment to D20466: Rework scrollback settings.

Only because I’m forbidden to remove configuration options that exist, for
me this is one of those niche cases that shouldn’t exist.

Apr 11 2019, 8:31 PM · Konsole
tcanabrava updated subscribers of D20466: Rework scrollback settings.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?

Apr 11 2019, 5:05 PM · Konsole
tcanabrava added reviewers for D20466: Rework scrollback settings: Konsole, hindenburg.
Apr 11 2019, 12:56 PM · Konsole