You can jusr click in the "commit" button on the gitlab review.

@cfeck any objections here? I'll wait a few days for an outcome.

Moving to gitlab

moving to gitlab

Moving to gitlab

lutris also depends on gnome-desktop (the library)

Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)

I use as focus mode. And the google icon will remember you that you are in
“fake full screen” mode.
If you look at the other terminals that offer multi split they also offer
this.

We are but it’s a per project basis

I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?

• Add license headers

• Palette highligth fixes

• Icon / Tooltip

• Fix build

• Add toggle of the Maximize / Minimize split

@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?

phabricator is tracking the wrong branch , it's *not* merged. (can I have a review? :)

• Add HeaderBar to TerminalDisplay

I'll wait kurt's comments as I'm sure this is a hack and not a proper fix.

I’ll look the warnings, none of them appear on Gcc. Should be a clazy
warning

@ngraham as this needs input from the VDG
I personally love the idea, I would change the half of the page dimm effect by a thin line on the side (like kdevelop shows for edited lines)

Seriously much. As the splits in master are in no way near what they where
before. But you might consider trying master, you might like the current
split behavior.
(It actually splits).
For the old behavior there was just 2 complaints, your and someone that
talked to me on email, and I’ll ask you the same thing I asked him. Try to
help with patches to have the old behavior back as a mirror tabs feature.
I’m trying to solve as many bugs as I can, but I can’t do that alone :)

can you put a screenshoot of the before / after ? I can't really read math.

ping?

ping?

@pino ping?

The proces of creation / destructiion / management of the views is a bit more complex. I'll gladly accept a patch but one that actually helps to clean the current behavior. This one just hides complexity.

O don’t really get it. Why this code needs to go to MainWindow and not to
TabbedContainer ?
Seems to me that the class that should have knowledge on how to create the
tabs is not mainwindow.

Mind you guys that the internal implementation without a profile is kinda
broken, so this patch makes sense to me.

None, I’m ok with it

In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

In D20466#448705, @ngraham wrote:

In D20466#448704, @hindenburg wrote:

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Did you mean -1? :P Hiding part of an UI depending on selected option is bad UX. Moving another elements around because something appears is probably even worse.
It is also against KDE HIG: https://hig.kde.org/patterns/content/settings.html#implementation (last point)

About changes:

• Maybe putting custom path field below radio button (and indenting it) would be better? Path which appear here will probably be longer than current field width (at least I think so), and it will not be needed to align it with fixed size field
• All radio buttons had equal vertical spacing, and the left label was aligned to the first radio button
  
• Button group instead of frame
• Maybe kmessagebox instead of label?

Ok, I'll update the code for that.

In D20466#448704, @hindenburg wrote:

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Another way to display this would be to only show the "info box" when unlimited is selected.

In D20466#448705, @ngraham wrote:

In D20466#448704, @hindenburg wrote:

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

• Remove useless lambda

• Add missing label, Add tooltips

Only because I’m forbidden to remove configuration options that exist, for
me this is one of those niche cases that shouldn’t exist.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?