tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (177 w, 2 d)
Availability
Available

Recent Activity

Tue, Apr 23

tcanabrava committed R231:10db899f14ee: Add override to clean up warnings (authored by laysrodrigues).
Add override to clean up warnings
Tue, Apr 23, 11:20 AM
tcanabrava committed R231:2227f9a1cb9f: Add override to clean up warnings (authored by laysrodrigues).
Add override to clean up warnings
Tue, Apr 23, 11:20 AM
tcanabrava closed D19085: Add override to clean up warnings.
Tue, Apr 23, 11:20 AM
tcanabrava committed R649:7c0b056607a2: Turning on the rotation on 3D plot (authored by karinapassos).
Turning on the rotation on 3D plot
Tue, Apr 23, 11:17 AM
tcanabrava closed D19627: Turning on the rotation on 3D plot .
Tue, Apr 23, 11:17 AM
tcanabrava committed R323:1af7c48a2df4: Deprecating rotation function (authored by karinapassos).
Deprecating rotation function
Tue, Apr 23, 11:14 AM
tcanabrava closed D19645: Deprecating rotation function.
Tue, Apr 23, 11:14 AM · KDE Edu

Sat, Apr 20

tcanabrava added a comment to D16138: Create the default profile if it doesn't exist.

Mind you guys that the internal implementation without a profile is kinda
broken, so this patch makes sense to me.

Sat, Apr 20, 7:07 AM · Konsole

Wed, Apr 17

tcanabrava updated subscribers of D20395: Ctrl-Tab should work in "split-only" view as well.

None, I’m ok with it

Wed, Apr 17, 2:20 PM · Konsole

Fri, Apr 12

tcanabrava added a comment to D20466: Rework scrollback settings.
In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Did you mean -1? :P Hiding part of an UI depending on selected option is bad UX. Moving another elements around because something appears is probably even worse.
It is also against KDE HIG: https://hig.kde.org/patterns/content/settings.html#implementation (last point)

About changes:

  • Maybe putting custom path field below radio button (and indenting it) would be better? Path which appear here will probably be longer than current field width (at least I think so), and it will not be needed to align it with fixed size field
  • All radio buttons had equal vertical spacing, and the left label was aligned to the first radio button
  • Button group instead of frame
  • Maybe kmessagebox instead of label?
Fri, Apr 12, 4:23 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

Ok, I'll update the code for that.

Fri, Apr 12, 1:28 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Another way to display this would be to only show the "info box" when unlimited is selected.

Fri, Apr 12, 1:24 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Fri, Apr 12, 1:22 PM · Konsole
tcanabrava updated the diff for D20466: Rework scrollback settings.
  • Remove useless lambda
Fri, Apr 12, 7:57 AM · Konsole
tcanabrava updated the diff for D20466: Rework scrollback settings.
  • Add missing label, Add tooltips
Fri, Apr 12, 7:53 AM · Konsole

Thu, Apr 11

tcanabrava added a comment to D20466: Rework scrollback settings.

Only because I’m forbidden to remove configuration options that exist, for
me this is one of those niche cases that shouldn’t exist.

Thu, Apr 11, 8:31 PM · Konsole
tcanabrava updated subscribers of D20466: Rework scrollback settings.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?

Thu, Apr 11, 5:05 PM · Konsole
tcanabrava added reviewers for D20466: Rework scrollback settings: Konsole, hindenburg.
Thu, Apr 11, 12:56 PM · Konsole
tcanabrava updated the summary of D20466: Rework scrollback settings.
Thu, Apr 11, 12:55 PM · Konsole
tcanabrava requested review of D20466: Rework scrollback settings.
Thu, Apr 11, 12:50 PM · Konsole

Wed, Apr 10

tcanabrava committed R319:e1474c3bc949: remove clang warnings: else after return (authored by tcanabrava).
remove clang warnings: else after return
Wed, Apr 10, 6:27 PM
tcanabrava closed D20444: remove clang warnings: else after return.
Wed, Apr 10, 6:27 PM · Konsole
tcanabrava closed D20441: Fix clang warnings about else after return.
Wed, Apr 10, 6:26 PM · Konsole
tcanabrava committed R319:13781fa6c9b6: Fix clang warnings about else after return (authored by tcanabrava).
Fix clang warnings about else after return
Wed, Apr 10, 6:26 PM
tcanabrava committed R319:208218dec98a: Small code simplifications (authored by tcanabrava).
Small code simplifications
Wed, Apr 10, 6:26 PM
tcanabrava closed D20438: Small code simplifications.
Wed, Apr 10, 6:26 PM · Konsole
tcanabrava updated subscribers of D20438: Small code simplifications.

This is more future proof as if we change the type of the function we don’t
need to change that return.

Wed, Apr 10, 5:36 PM · Konsole
tcanabrava added reviewers for D20444: remove clang warnings: else after return: Konsole, hindenburg.
Wed, Apr 10, 3:21 PM · Konsole
tcanabrava requested review of D20444: remove clang warnings: else after return.
Wed, Apr 10, 3:21 PM · Konsole
tcanabrava added reviewers for D20441: Fix clang warnings about else after return: Konsole, hindenburg.
Wed, Apr 10, 3:14 PM · Konsole
tcanabrava requested review of D20441: Fix clang warnings about else after return.
Wed, Apr 10, 3:13 PM · Konsole
tcanabrava added reviewers for D20440: Fix warning "variable loses precision int to uint8": hindenburg, Konsole.
Wed, Apr 10, 3:11 PM · Konsole
tcanabrava requested review of D20440: Fix warning "variable loses precision int to uint8".
Wed, Apr 10, 3:10 PM · Konsole
tcanabrava requested review of D20439: Fix alignment boundary.
Wed, Apr 10, 3:07 PM · Konsole
tcanabrava added reviewers for D20438: Small code simplifications: Konsole, hindenburg.
Wed, Apr 10, 3:04 PM · Konsole
tcanabrava requested review of D20438: Small code simplifications.
Wed, Apr 10, 3:03 PM · Konsole
tcanabrava added a comment to D14200: Simplify newSession code.

We set this variable in two or three different files and in a few different
methods. I remember that one of the first things that I tried to do for
konsole was to simplify the creation of sessions (and this broke a lot of
code and you where not happy) but it seems that we do need to make some
compromise and align that.

Wed, Apr 10, 2:29 PM · Konsole
tcanabrava updated subscribers of D14200: Simplify newSession code.

I beg your pardon? (How do I test the new session? konsole is working
for me so maybe it's something I missed)

Wed, Apr 10, 2:13 PM · Konsole
tcanabrava added a comment to D15570: Use new connection style.

I forgot this for quite a while, I'll update today.

Wed, Apr 10, 8:30 AM · Konsole
tcanabrava added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

ON master w/o this patch, I still get the CD echoing on all the tabs when I try the shortcuts. So maybe it is something else. Is anyone else seeing this issue?

Wed, Apr 10, 8:29 AM · Konsole

Tue, Apr 9

tcanabrava added a comment to D13854: Refactor Profile and ColorScheme.

I'll add a backtrace as soon as I test this again. since I'm succeeding in my konsole code cleanup I'll get this back on track.

Tue, Apr 9, 8:28 PM · Konsole
tcanabrava committed R319:8029d74a970f: Implement saving sessions recursively (authored by tcanabrava).
Implement saving sessions recursively
Tue, Apr 9, 4:21 PM
tcanabrava closed D20224: Implement saving sessions recursively.
Tue, Apr 9, 4:21 PM · Konsole
tcanabrava closed D20410: Display the settings as List instead of Tab.
Tue, Apr 9, 4:21 PM · Konsole
tcanabrava committed R319:7bda99d7bc4e: Display the settings as List instead of Tab (authored by tcanabrava).
Display the settings as List instead of Tab
Tue, Apr 9, 4:21 PM
tcanabrava added a comment to D20410: Display the settings as List instead of Tab.

too many things to fix here and there. :)

Tue, Apr 9, 4:19 PM · Konsole
tcanabrava added reviewers for D20410: Display the settings as List instead of Tab: Konsole, hindenburg, ngraham.
Tue, Apr 9, 3:39 PM · Konsole
tcanabrava requested review of D20410: Display the settings as List instead of Tab.
Tue, Apr 9, 3:38 PM · Konsole
tcanabrava added a comment to D20398: Remove warning: do not use 'else' after 'return'.

we don't have a clangformat file specified for kde projects, maybe this is
something good to add. I voted for global .editoconfigfiles but I was
outvoted. :)

Tue, Apr 9, 2:48 PM
tcanabrava updated the diff for D14200: Simplify newSession code.
  • Further simplify code
Tue, Apr 9, 2:41 PM · Konsole
tcanabrava added a comment to D20395: Ctrl-Tab should work in "split-only" view as well.

When we have multiple tabs / splits this is not confusing?

Tue, Apr 9, 2:24 PM · Konsole
tcanabrava added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

this should fix most of the issues. I have another patch to go related to actions, but this one needs to land first.

Tue, Apr 9, 2:16 PM · Konsole
tcanabrava updated the diff for D20115: Re enable move tab left / right via keyboard shortcuts.
  • Fix action identifiers
Tue, Apr 9, 2:15 PM · Konsole
tcanabrava added a comment to D20224: Implement saving sessions recursively.

@ngraham can you accept even with the shortcut issue that you are having? I have other reviews that depend on this one. I promise you to fix the shortcut bug <3

Tue, Apr 9, 12:59 PM · Konsole
tcanabrava updated the diff for D20224: Implement saving sessions recursively.
  • Use reference with range for loops
Tue, Apr 9, 9:08 AM · Konsole
tcanabrava added inline comments to D20224: Implement saving sessions recursively.
Tue, Apr 9, 9:03 AM · Konsole
tcanabrava added a comment to D18992: Kbruch exercise mode improvement.

ping?

Tue, Apr 9, 8:41 AM · KDE Edu
tcanabrava accepted D19085: Add override to clean up warnings.
Tue, Apr 9, 8:40 AM
tcanabrava added a comment to D19960: bluez-qt: remove warnings.

ping?

Tue, Apr 9, 8:39 AM · Frameworks
tcanabrava accepted D19563: adding multiple decays and updated isotope information H-Na.
Tue, Apr 9, 8:39 AM · KDE Edu
tcanabrava requested changes to D20119: clean main.cpp.

the adition of the phabricator configuration file is unrelated to a clean, please split in two patches.

Tue, Apr 9, 8:37 AM
tcanabrava requested changes to D20258: clean.
Tue, Apr 9, 8:36 AM
tcanabrava added a comment to D20398: Remove warning: do not use 'else' after 'return'.

the specific warning is https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tue, Apr 9, 8:35 AM
tcanabrava added a comment to D20335: Remove warning static member accessed through instance.

I believe that he builds in clang and clang 8 added quite a bunch of new
warnings

Tue, Apr 9, 6:07 AM

Mon, Apr 8

tcanabrava accepted D20322: remove the OpenMPI dependency.
Mon, Apr 8, 7:34 PM
tcanabrava added a comment to D20335: Remove warning static member accessed through instance.

true, but then the instance is there anyway. what we gain from this?

Mon, Apr 8, 7:32 PM
tcanabrava added a comment to D20224: Implement saving sessions recursively.

Hm? This doesn’t touches that.

Mon, Apr 8, 5:33 PM · Konsole
tcanabrava added a comment to D20224: Implement saving sessions recursively.

waiting for @hindenburg ok before landing. :)

Mon, Apr 8, 3:21 PM · Konsole
tcanabrava updated the diff for D20224: Implement saving sessions recursively.
  • Better variable name
Mon, Apr 8, 2:22 PM · Konsole
tcanabrava updated the diff for D20224: Implement saving sessions recursively.
  • Whitespace / Todos removal
Mon, Apr 8, 2:07 PM · Konsole
tcanabrava added a comment to D20224: Implement saving sessions recursively.

This seems to fix the issue I started having recently where Konsole crashes at logout and then opens as a big white window on login after session restoration.

Mon, Apr 8, 1:57 PM · Konsole
tcanabrava accepted D20336: Simplifying class constructor with constructor delegate.

sorry, my mistake. this is correct.
https://en.cppreference.com/w/cpp/language/initializer_list#Delegating_constructor

Mon, Apr 8, 1:56 PM
tcanabrava added a comment to D20336: Simplifying class constructor with constructor delegate.

that looks factually wrong. what are you trying to accomplish here?

Mon, Apr 8, 1:55 PM
tcanabrava updated the test plan for D20224: Implement saving sessions recursively.
Mon, Apr 8, 12:10 PM · Konsole
tcanabrava added a reviewer for D20224: Implement saving sessions recursively: ngraham.
Mon, Apr 8, 12:03 PM · Konsole
tcanabrava updated the diff for D20224: Implement saving sessions recursively.

Session Save / Restore

Mon, Apr 8, 12:00 PM · Konsole

Fri, Apr 5

tcanabrava updated subscribers of D20036: Correct math to blend color in the blur effect.

OpenMP is missing, Andre is working on it.

Fri, Apr 5, 10:47 AM · KDE Applications

Thu, Apr 4

tcanabrava added a comment to D20224: Implement saving sessions recursively.

This code can load sessions, it has a better behavior than the old session load code, but still has bugs. I'll finish this luckly today / tomorrow.

Thu, Apr 4, 3:14 PM · Konsole
tcanabrava updated the diff for D20224: Implement saving sessions recursively.
  • Sessions partially working
  • Code cleanup
Thu, Apr 4, 2:57 PM · Konsole
tcanabrava added a comment to D20224: Implement saving sessions recursively.

I'll remove the debugs / message handlers as soon as everything is working. but it's one of the fastest ways for me to keep the debug messages between runs so I can understand what's wrong.
the session is correctly saved, and the SessionManager correctly loads all the sessions back, the ViewManager however is broken on load. that's what I'm debugging now. so even tougth we don't display any terminal, they are up and running.

Thu, Apr 4, 1:38 PM · Konsole
tcanabrava updated the diff for D20224: Implement saving sessions recursively.
  • messageHandler + tons of debug
  • Sabe json correctly in the configuration
Thu, Apr 4, 1:36 PM · Konsole
tcanabrava added a comment to D20224: Implement saving sessions recursively.

Well, I finally managed to discover something:
when MainWindow::saveProperties is triggered we already destroyed the sessions and tabs, and that's the reason it's not saving anything.
I'm trying to debug the destructor order now to see if I can change something.

Thu, Apr 4, 10:26 AM · Konsole

Wed, Apr 3

tcanabrava updated the diff for D20224: Implement saving sessions recursively.
  • Implement the Load of Sessions
  • Solve crash while quitting konsole via Session End
  • Still Broken, do not review unless you can help. :)
Wed, Apr 3, 5:22 PM · Konsole
tcanabrava added reviewers for D20224: Implement saving sessions recursively: Konsole, hindenburg.
Wed, Apr 3, 10:27 AM · Konsole
tcanabrava requested review of D20224: Implement saving sessions recursively.
Wed, Apr 3, 10:27 AM · Konsole

Sat, Mar 30

tcanabrava added a comment to D17643: Multiple Splits per Tab.

The code for sessions is commented out, in the original review you said
that you would help me see the saving the session code as now we have to
deal with splits.

Sat, Mar 30, 9:10 PM · Konsole

Fri, Mar 29

tcanabrava updated the diff for D20115: Re enable move tab left / right via keyboard shortcuts.
  • Remove empty line
Fri, Mar 29, 4:51 PM · Konsole
tcanabrava added reviewers for D20115: Re enable move tab left / right via keyboard shortcuts: Konsole, hindenburg.
Fri, Mar 29, 4:51 PM · Konsole
tcanabrava requested review of D20115: Re enable move tab left / right via keyboard shortcuts.
Fri, Mar 29, 4:50 PM · Konsole
tcanabrava added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

This is mostly working, but I will not merge this untill we fix the current state of the shortcuts (that I'm preparing in a separate patch).
after the shortcuts are correct, there will be a follow up patch here to use the switcher style *or* the next-prev-tab style (as we have today) selectable by the user, defaulting to the current behavior.

Fri, Mar 29, 3:09 PM · Konsole
tcanabrava updated the diff for D18154: Add a "Session Switcher" via Ctrl + Tab.
  • Simplify handling of code
  • Handle list with the shortcut selected
  • Mostly working
  • Remove mnemonics from text
Fri, Mar 29, 3:07 PM · Konsole
tcanabrava added a comment to D17643: Multiple Splits per Tab.

I’m in a konsole spree this week so expect patches.

Fri, Mar 29, 2:57 PM · Konsole

Thu, Mar 28

tcanabrava added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

how that the splits are merged, I'm preparing a round of patches that where rotting in my pc.

Thu, Mar 28, 5:14 PM · Konsole
tcanabrava abandoned D18575: Remove warning before hidding the MenuBar.
Thu, Mar 28, 11:44 AM · Plasma
tcanabrava abandoned D19015: This is a followup review for the removal of ifdefs before debug.
Thu, Mar 28, 11:43 AM
tcanabrava added a reviewer for D20088: Simplify TerminalDisplay code : Konsole.
Thu, Mar 28, 11:42 AM · Konsole
tcanabrava abandoned D20089: Remove sender() and QVariant() conversions.
Thu, Mar 28, 11:41 AM · Konsole
tcanabrava accepted D20036: Correct math to blend color in the blur effect.
Thu, Mar 28, 11:41 AM · KDE Applications
tcanabrava abandoned D20090: Declare + initialize, instead of setting the value later.
Thu, Mar 28, 11:41 AM · Konsole
tcanabrava updated the diff for D20088: Simplify TerminalDisplay code .
  • Use one liners where appropriate.
  • Remove sender() and QVariant() conversions
  • Declare + initialize, instead of setting the value later
  • Don't create unecessary temporaries
  • Extract code from huge function into a smaller one
Thu, Mar 28, 11:40 AM · Konsole