• Remove debug line
• return null instead of asserting

• Add copyright information and docs

@hein I'll try to follow your approach.

Caio, while understand the usecase I do agree with the rest of the reviews.

• Add pid information to the log files
• Store only the last 10 files in the cache directory

• Add pid information to the log files
• rebase

• Add pid information to the log files

And perhaps more ideally, albeit not blocking this diff, we should look at reshuffling the architecture so on next login drkonqi auto starts with a list of crashes and the ability to file reports for them.

Store in the cache folder

In D22323#492220, @sitter wrote:

I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was before the diff is weird, and the way it is after the diff is still weird IMHO. Also the two objects that are allocated in the two methods aren't properly deleted anywhere it seems.

• Store the number of stars instead of the Enum
• Check enums with switch

• Store the number of stars instead of the Enum

You can jusr click in the "commit" button on the gitlab review.

@cfeck any objections here? I'll wait a few days for an outcome.

Moving to gitlab

moving to gitlab

Moving to gitlab

lutris also depends on gnome-desktop (the library)

Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)

I use as focus mode. And the google icon will remember you that you are in
“fake full screen” mode.
If you look at the other terminals that offer multi split they also offer
this.

We are but it’s a per project basis

I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?

• Add license headers

• Palette highligth fixes

• Icon / Tooltip

• Fix build

• Add toggle of the Maximize / Minimize split

@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?

phabricator is tracking the wrong branch , it's *not* merged. (can I have a review? :)

• Add HeaderBar to TerminalDisplay