• Use Plasma KCM
• Adapt to FormLayout
• Fix label
• Space every tab equally
• Form layout port
• FormLayout
• Simplify Qml
• Port to Form Layout
• A much much better layout than tabs
• Beginning of KConfigXt Port
• Add KConfigXt stubs
• Fix install
• Fix wrong values accessed
• s/visibleBell/visualBell
• Fix Many issues with the KConfigXT port
• Fixes
• Fix all the KConfigXT noiseances

In D24224#545013, @broulik wrote:

Can you please follow KDE Frameworks coding style

• Fix Strings
• Fix margins

this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate.

• Use Plasma KCM
• Adapt to FormLayout
• Fix label
• Space every tab equally
• Form layout port
• FormLayout
• Simplify Qml
• Port to Form Layout

I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not used.

• fix Comment

• Simplify Checkboxes
• Fix previouslyEnabled logic
• Tell Qml that we have the values
• Move code around
• Fix QSet math
• Qml gives us a Url, we want the Local file
• use folderAdded and folderRemoved
• Remove debug information
• Add spacing

• Fix metadata installation
• Fix model loading on Qml
• Base work on the Qml
• Name fixes
• Move ui/main to contents
• Fix wrong types in Qml
• Plug the controllers
• Link to the save button
• Fix borders and background for the Baloo KCM
• Use kirigami BasicListItem
• Spacing
• Fix mapping of roles
• Fix delegate / Mouse integration

wq - Restore colors metatada, and correctly set the datetime metadata

• s/kcmclock/kcm_clock
• Fix author
• kcm_name break kauth, it needs kcmname =/
• Fix missing property, Add a Qml Clock (from the Qt Demos)
• Add a Time Zone list.
• Fix many layout mistakes

• Fix KAuth usage

closing this as arc diff opened two reviews with the same content =/

got it, updating.

In D24224#537680, @whiting wrote:

Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) The top groupbox of Activation Gestures items could be moved to their respective groupboxes also so there are less groupboxes on the Keyboard tab than before on these 3 tabs.

• Make buttons work

https://phabricator.kde.org/D24187 has a wip, it currently is a 1 to 1 translation of the Widgets one, we need a better layout for it.

• Remove the ui file
• Rename kcm_access to kcmaccess
• Fix typos
• Qml Loads. Now, fix beaury
• Fix imports and labels
• Fix most layouts
• Fix layout for the mouse navigation
• Initial Working Gestures
• Add boilerplate
• Fixes on bell
• Fix functionality

• Initial Working Gestures

• Rename kcm_access to kcmaccess
• Fix typos
• Qml Loads. Now, fix beaury
• Fix imports and labels
• Fix most layouts
• Fix layout for the mouse navigation

• Remove the ui file

• Fix metadata installation
• Fix model loading on Qml
• Base work on the Qml
• Name fixes
• Move ui/main to contents
• Fix wrong types in Qml
• Plug the controllers
• Link to the save button
• Fix borders and background for the Baloo KCM

• Fix metadata installation
• Fix model loading on Qml
• Base work on the Qml
• Name fixes
• Move ui/main to contents
• Fix wrong types in Qml
• Plug the controllers
• Link to the save button

I needed a new accelerator for focus split right left top bottom, I talked
to David this weekend and we agreed to restore the old accelerator for move
tab.

• Name fixes

• Fix metadata installation
• Fix model loading on Qml
• Base work on the Qml

When I tested I kept a old profile but probably forgot to use during
development. Sorry for the trouble :)

@ngraham I agree with you completely. it's basically removing a bit of code, smaller patch and the code behaves without surprises.

• Revert "Remove filtering of recent apps that are in the favorites"
• Add a new Q_PROPERTY to the Recents Model to filter out or not favorites

In D23461#520710, @davidedmundson wrote:

Is there a reason to change kicker? If not, it needs to be a property.

• Revert "Remove 'magic' filtering of recent apps"
• Remove filtering of recent apps that are in the favorites

• Remove debug line
• return null instead of asserting

• Add copyright information and docs

@hein I'll try to follow your approach.

Caio, while understand the usecase I do agree with the rest of the reviews.

• Add pid information to the log files
• Store only the last 10 files in the cache directory

• Add pid information to the log files
• rebase