tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (168 w, 2 d)
Availability
Available

Recent Activity

Sat, Feb 16

tcanabrava added a comment to D17643: Multiple Splits per Tab.

I’m ok with it.

Sat, Feb 16, 3:32 PM · Konsole

Fri, Feb 15

tcanabrava accepted D18859: cdb: First working version.
Fri, Feb 15, 1:45 PM · Plasma
tcanabrava updated the diff for D19015: This is a followup review for the removal of ifdefs before debug.
  • More guards removed.
  • Remove unused include
Fri, Feb 15, 12:41 PM

Thu, Feb 14

tcanabrava requested review of D19015: This is a followup review for the removal of ifdefs before debug.
Thu, Feb 14, 5:24 PM
tcanabrava committed R374:fff60307ff06: Remove conditional debug output (authored by tcanabrava).
Remove conditional debug output
Thu, Feb 14, 2:39 PM
tcanabrava closed D18930: Remove conditional debug output.
Thu, Feb 14, 2:39 PM
tcanabrava updated the diff for D18930: Remove conditional debug output.
  • Fix compilation
Thu, Feb 14, 2:21 PM
tcanabrava closed D18741: Convert old style to Qt5 style connection.

already merged and a followup was also merged fixing the issues related by @broulik

Thu, Feb 14, 9:42 AM
tcanabrava committed R374:28bb1592924b: Remove unused code (authored by andreagenor).
Remove unused code
Thu, Feb 14, 9:41 AM
tcanabrava closed D18742: Remove unused code.
Thu, Feb 14, 9:41 AM
tcanabrava committed R374:1d1136866821: Standardizing includes across header files (authored by andreagenor).
Standardizing includes across header files
Thu, Feb 14, 9:40 AM
tcanabrava closed D18872: Standardizing includes across header files.
Thu, Feb 14, 9:40 AM
tcanabrava committed R374:d69b9ee1426d: Replace some math macro definitions (authored by andreagenor).
Replace some math macro definitions
Thu, Feb 14, 9:40 AM
tcanabrava closed D18876: Replace some math macro definitions.
Thu, Feb 14, 9:40 AM
tcanabrava added a comment to D14200: Simplify newSession code.

@hindenburg ping?

Thu, Feb 14, 9:39 AM · Konsole
tcanabrava updated the diff for D18579: Rework Sensor Browser.
  • Fix code style
  • re-add assert
  • Fix code style
Thu, Feb 14, 9:37 AM · Plasma
tcanabrava committed R106:b4bde28dc7af: Simpe C updates to ksysguardd code (authored by tcanabrava).
Simpe C updates to ksysguardd code
Thu, Feb 14, 9:31 AM
tcanabrava closed D18576: Simpe C updates to ksysguardd code.
Thu, Feb 14, 9:31 AM · Plasma
tcanabrava closed D18578: Reduce string objects.
Thu, Feb 14, 9:30 AM · Plasma
tcanabrava committed R106:91b1f7115bf3: Reduce string objects (authored by tcanabrava).
Reduce string objects
Thu, Feb 14, 9:30 AM
tcanabrava added a comment to D18575: Remove warning before hidding the MenuBar.

No other KDE app does this

That's not true. Kate and Gwenview do this too, and for good reason: without this warning, there's no way to know how to get the menu bar back again if you remove it by accident and/or don't know about the ctrl+m shortcut.

Konsole doesn't show a warning because it's a power user app; presumably the user knows what he/she is doing. Dolphin doesn't have this warning because it automatically creates a menu-like toolbar button when the menubar is hidden, which is an acceptable alternative. But for apps that don't do this or something else (e.g. putting the menubar in the titlebar instead) we need to show an ugly warning like this.

Thu, Feb 14, 9:29 AM · Plasma

Wed, Feb 13

tcanabrava updated subscribers of D17643: Multiple Splits per Tab.

There are two different patches for that, one from myself that adds a dim
effect (that Kurt asked to remove from this change set) and another one
that implements a header, also in a different review (but not from myself
and I don’t have the review number on my head).

Wed, Feb 13, 9:16 PM · Konsole
tcanabrava added a comment to D15742: Add close tab and create new tab on middle click event.

Be my guest

Wed, Feb 13, 6:00 PM · Konsole
tcanabrava updated the diff for D17643: Multiple Splits per Tab.
  • don't copy the map
Wed, Feb 13, 4:39 PM · Konsole
tcanabrava updated the diff for D17643: Multiple Splits per Tab.
  • Call directly, lambda is uneeded here.
Wed, Feb 13, 4:36 PM · Konsole
tcanabrava updated the diff for D17643: Multiple Splits per Tab.
  • Remove unused function - a findChildren is what it's needed
Wed, Feb 13, 4:27 PM · Konsole
tcanabrava added inline comments to D17643: Multiple Splits per Tab.
Wed, Feb 13, 4:26 PM · Konsole
tcanabrava added inline comments to D18859: cdb: First working version.
Wed, Feb 13, 4:15 PM · Plasma
tcanabrava updated the diff for D17643: Multiple Splits per Tab.
  • Properly count the number of Terminals
Wed, Feb 13, 1:40 PM · Konsole
tcanabrava updated the diff for D17643: Multiple Splits per Tab.
  • Fix creation of splits in the middle of the grid
  • Remove Dim code: I'll add that to another review
Wed, Feb 13, 11:12 AM · Konsole
tcanabrava updated the diff for D17643: Multiple Splits per Tab.
  • Remove deprecated code
  • Refactor to reduce the number of boilerplate
  • Fix updating the detach menus
  • Dim unfocused terminals
  • Rebase on master
Wed, Feb 13, 8:04 AM · Konsole
tcanabrava reclaimed D15742: Add close tab and create new tab on middle click event.

While I'm reopening this I have zero time to tackle this right now because of real work.

Wed, Feb 13, 7:44 AM · Konsole

Tue, Feb 12

tcanabrava added a comment to D18930: Remove conditional debug output.

They aren’t, just forgot to remove all of them

Tue, Feb 12, 4:03 PM
tcanabrava requested changes to D18859: cdb: First working version.
Tue, Feb 12, 3:08 PM · Plasma
tcanabrava added a reviewer for D18930: Remove conditional debug output: broulik.
Tue, Feb 12, 1:12 PM
tcanabrava committed R374:f766486c1947: Changed to use correct object signal (authored by andreagenor).
Changed to use correct object signal
Tue, Feb 12, 10:18 AM
tcanabrava closed D18927: Changed to use correct object signal.
Tue, Feb 12, 10:18 AM
tcanabrava accepted D18927: Changed to use correct object signal.
Tue, Feb 12, 10:17 AM
tcanabrava committed R325:4901d314a0aa: Changes in CMakeLists file It was changed because some QML files weren't… (authored by karinapassos).
Changes in CMakeLists file It was changed because some QML files weren't…
Tue, Feb 12, 10:12 AM
tcanabrava closed D18937: Changes in CMakeLists file It was changed because some QML files weren't appearing on QtCreator..
Tue, Feb 12, 10:12 AM · KDE Edu
tcanabrava accepted D18937: Changes in CMakeLists file It was changed because some QML files weren't appearing on QtCreator..
Tue, Feb 12, 10:11 AM · KDE Edu

Mon, Feb 11

tcanabrava requested review of D18930: Remove conditional debug output.
Mon, Feb 11, 5:05 PM

Sun, Feb 10

tcanabrava accepted D18801: CMakeLists: Fix bfd.h include path on windows.
Sun, Feb 10, 9:09 PM · Plasma
tcanabrava accepted D18802: Fix pragma once problem with process class.
Sun, Feb 10, 9:08 PM · Plasma
tcanabrava accepted D18876: Replace some math macro definitions.

seems pretty straigthforward.

Sun, Feb 10, 9:05 PM

Sat, Feb 9

tcanabrava added a comment to D18520: Remove dead code in TerminalDisplay.

I tough about that but it’s not that easy unless we also refactor the
Profile class, because everything in the profile class is stored inside a
map. It would be quite expensive to always access it.

Sat, Feb 9, 3:07 PM · Konsole

Fri, Feb 8

tcanabrava committed R325:88cbe101d3e7: Change in plugins/CMakeLists.txt It was changed because QML files weren't… (authored by karinapassos).
Change in plugins/CMakeLists.txt It was changed because QML files weren't…
Fri, Feb 8, 3:46 PM
tcanabrava closed D18820: Change in plugins/CMakeLists.txt It was changed because QML files weren't appearing on QtCreator.
Fri, Feb 8, 3:46 PM · KDE Edu
tcanabrava accepted D18820: Change in plugins/CMakeLists.txt It was changed because QML files weren't appearing on QtCreator.
Fri, Feb 8, 3:45 PM · KDE Edu
tcanabrava added a comment to D15742: Add close tab and create new tab on middle click event.

geh, then let's keep this one and remove the other one.

Fri, Feb 8, 2:20 PM · Konsole
tcanabrava abandoned D15742: Add close tab and create new tab on middle click event.
Fri, Feb 8, 11:01 AM · Konsole
tcanabrava updated subscribers of D15742: Add close tab and create new tab on middle click event.

I'll close this one, let's use yours.

Fri, Feb 8, 11:01 AM · Konsole

Wed, Feb 6

tcanabrava accepted D18779: Better window title display.
Wed, Feb 6, 3:12 PM · Plasma

Tue, Feb 5

tcanabrava committed R374:f561f6d58b71: Convert old style to Qt5 style connection (authored by andreagenor).
Convert old style to Qt5 style connection
Tue, Feb 5, 10:35 AM
tcanabrava closed D18741: Convert old style to Qt5 style connection.
Tue, Feb 5, 10:35 AM
tcanabrava added a comment to D18742: Remove unused code.

please rebase on top of master, there's a conflict.

Tue, Feb 5, 10:33 AM
tcanabrava committed R374:d675556ae90e: Add zero before dot to float point values (authored by andreagenor).
Add zero before dot to float point values
Tue, Feb 5, 10:32 AM
tcanabrava closed D18743: Add zero before dot to float point values.
Tue, Feb 5, 10:32 AM
tcanabrava accepted D18741: Convert old style to Qt5 style connection.
Tue, Feb 5, 9:07 AM
tcanabrava accepted D18742: Remove unused code.
Tue, Feb 5, 9:06 AM
tcanabrava accepted D18743: Add zero before dot to float point values.
Tue, Feb 5, 9:05 AM

Mon, Feb 4

tcanabrava added a comment to D17814: Add option to have close button on each tab.

@ngraham is this accepted? I can't tel because of the talk after the last ok.

Mon, Feb 4, 3:40 PM · Konsole
tcanabrava committed R374:21c562bab325: Standardizing includes across all project files (authored by andreagenor).
Standardizing includes across all project files
Mon, Feb 4, 3:39 PM
tcanabrava closed D18595: Standardizing includes across all project files.
Mon, Feb 4, 3:39 PM
tcanabrava retitled D18595: Standardizing includes across all project files from Standardizing lib calls across all project files to Standardizing includes across all project files.
Mon, Feb 4, 3:39 PM
tcanabrava committed R374:158c9c605a8b: Remove break statement after return call (authored by andreagenor).
Remove break statement after return call
Mon, Feb 4, 3:38 PM
tcanabrava closed D18602: Remove break statement after return call.
Mon, Feb 4, 3:38 PM
adrianchavesfernandez awarded D18580: Accept commas to separate processes on the Search Edit a Love token.
Mon, Feb 4, 8:53 AM · Plasma

Sat, Feb 2

tcanabrava added a comment to D17643: Multiple Splits per Tab.

I have also a patch for Yakuake to fix them too, they are using one kpart
per view instead of using the tabbar that konsole part provides. :/
This week it will be hard for me to touch this code but I’ll see what I can
do.

Sat, Feb 2, 9:28 PM · Konsole

Wed, Jan 30

tcanabrava added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

No; both are unrelated

Wed, Jan 30, 1:42 PM · Konsole
tcanabrava added a comment to D18578: Reduce string objects.
In D18578#401842, @apol wrote:

Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P

Wed, Jan 30, 8:13 AM · Plasma
tcanabrava added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

ping?

Wed, Jan 30, 8:10 AM · Konsole
tcanabrava added inline comments to D18579: Rework Sensor Browser.
Wed, Jan 30, 8:10 AM · Plasma
tcanabrava accepted D18584: Use Smart pointer for temperature object.
Wed, Jan 30, 8:08 AM · Atelier: AtCore
tcanabrava accepted D18586: Fix Failed Sprinter Test by capturing temperature with or with out decimal.
Wed, Jan 30, 8:07 AM · Atelier: AtCore
tcanabrava accepted D18595: Standardizing includes across all project files.
Wed, Jan 30, 8:07 AM
tcanabrava accepted D18602: Remove break statement after return call.
Wed, Jan 30, 8:07 AM
tcanabrava added a comment to D18602: Remove break statement after return call.

I agree with the change, specially that now there's a warning on implicit falltrougth

Wed, Jan 30, 8:07 AM
tcanabrava accepted D18472: Create Bed Deform Object.

I still don't like the shared ptr but let's go with that for now.

Wed, Jan 30, 8:05 AM · Atelier: AtCore

Tue, Jan 29

tcanabrava updated subscribers of D18585: Changes in the menus.

Let me interfeer a bit.

Tue, Jan 29, 6:26 PM · KDE Edu
tcanabrava committed R374:43ad92ea64b5: Remove warning: zero as null pointer constant (authored by andreagenor).
Remove warning: zero as null pointer constant
Tue, Jan 29, 10:03 AM
tcanabrava closed D18337: Remove warning: zero as null pointer constant.
Tue, Jan 29, 10:03 AM
tcanabrava committed R374:72d5601cc7f8: Convert old-style cast to C++ style (authored by andreagenor).
Convert old-style cast to C++ style
Tue, Jan 29, 10:03 AM
tcanabrava closed D18311: Convert old-style cast to C++ style.

landed.

Tue, Jan 29, 10:02 AM
tcanabrava committed R323:c2c1d883a5f9: Use the default RGB Colors for the XYZ Axis (authored by karinapassos).
Use the default RGB Colors for the XYZ Axis
Tue, Jan 29, 9:55 AM
tcanabrava closed D18304: Use the default RGB Colors for the XYZ Axis.
Tue, Jan 29, 9:55 AM · KDE Edu
tcanabrava accepted D18304: Use the default RGB Colors for the XYZ Axis.
Tue, Jan 29, 9:52 AM · KDE Edu
tcanabrava closed D18580: Accept commas to separate processes on the Search Edit.
Tue, Jan 29, 9:49 AM · Plasma
tcanabrava committed R111:f5dcd02c52fd: Accept commas to separate processes on the Search Edit (authored by tcanabrava).
Accept commas to separate processes on the Search Edit
Tue, Jan 29, 9:49 AM
tcanabrava updated the diff for D18580: Accept commas to separate processes on the Search Edit.
  • Accept commas for PID
Tue, Jan 29, 9:48 AM · Plasma

Mon, Jan 28

tcanabrava accepted D18585: Changes in the menus.

@apol can you also check here?

Mon, Jan 28, 5:09 PM · KDE Edu
tcanabrava requested changes to D18585: Changes in the menus.
Mon, Jan 28, 4:24 PM · KDE Edu
tcanabrava updated the summary of D18585: Changes in the menus.
Mon, Jan 28, 4:21 PM · KDE Edu
tcanabrava updated the summary of D18580: Accept commas to separate processes on the Search Edit.
Mon, Jan 28, 12:32 PM · Plasma
tcanabrava requested review of D18580: Accept commas to separate processes on the Search Edit.
Mon, Jan 28, 12:31 PM · Plasma
tcanabrava requested review of D18579: Rework Sensor Browser.
Mon, Jan 28, 12:00 PM · Plasma
tcanabrava requested review of D18578: Reduce string objects.
Mon, Jan 28, 11:00 AM · Plasma
tcanabrava requested review of D18576: Simpe C updates to ksysguardd code.
Mon, Jan 28, 10:52 AM · Plasma
tcanabrava requested review of D18575: Remove warning before hidding the MenuBar.
Mon, Jan 28, 10:49 AM · Plasma

Sat, Jan 26

tcanabrava added a comment to D17643: Multiple Splits per Tab.

Ok. I’ll extract from here.

Sat, Jan 26, 10:44 AM · Konsole