tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (220 w, 1 d)
Availability
Available

Recent Activity

Today

tcanabrava requested review of D27500: Simplify If return chain by returning early.
Wed, Feb 19, 1:00 PM
tcanabrava committed R491:6cd9d79a9937: Add KDE ClangFormat on CMake and run the target (authored by tcanabrava).
Add KDE ClangFormat on CMake and run the target
Wed, Feb 19, 12:57 PM
tcanabrava closed D27499: Add KDE ClangFormat on CMake and run the target.
Wed, Feb 19, 12:57 PM
tcanabrava abandoned D27498: Add clang-format file.
Wed, Feb 19, 12:47 PM
tcanabrava requested review of D27499: Add KDE ClangFormat on CMake and run the target.
Wed, Feb 19, 12:46 PM
tcanabrava requested review of D27498: Add clang-format file.
Wed, Feb 19, 12:35 PM

Mon, Feb 17

tcanabrava committed R1034:4dbcc5eaef93: Fix many possible crashes with the Screenshoot (authored by tcanabrava).
Fix many possible crashes with the Screenshoot
Mon, Feb 17, 11:39 AM

Sun, Feb 2

tcanabrava updated subscribers of D26877: Simplify calls to whitespace() and use it in more places..

I like indentedStream.

Sun, Feb 2, 10:38 AM · Frameworks

Thu, Jan 30

tcanabrava added a reviewer for D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens: graesslin.
Thu, Jan 30, 1:30 PM · Plasma
tcanabrava added a comment to D26133: Enable Auto Save.

That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all.

Thu, Jan 30, 10:32 AM · Frameworks

Wed, Jan 29

tcanabrava updated the diff for D26868: Move newItem to private method in KConfigSourceGenerator.
  • Fix code style
Wed, Jan 29, 5:38 PM · Frameworks
tcanabrava added a comment to D26868: Move newItem to private method in KConfigSourceGenerator.

There is indeed a QString overload for concatenating QLatin1String, but it will have to be converted char-by-char (from 8 bits to 16 bits), so isn't it faster to concatenate QStringLiterals?

I have never seen numbers, but any time I asked someone who might have seen numbers, they told me: QStringLiteral only for final strings not further modified or given to operations. Sadly cannot find references now, but I asked often the recent years.
Looking at the code, the qt_from_latin1 helper method might be as efficient on most processors as the memcpy is perhaps, and making up for any other overhead the QStringLiteral-generated code has, perhaps atomic stuff around the generated QString instance is expensive compared to the copy logic?

But ready to hear from real Qt experts once more, perhaps with numbers this time :)

Wed, Jan 29, 5:33 PM · Frameworks
tcanabrava abandoned D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert..
Wed, Jan 29, 5:28 PM · Frameworks
tcanabrava abandoned D26127: Simplify cppType method: Return Early, Use a Map and Assert..
Wed, Jan 29, 5:28 PM · Frameworks
tcanabrava abandoned D26126: Simplify param method: Return Early, Use a Map and Assert..
Wed, Jan 29, 5:27 PM · Frameworks
tcanabrava abandoned D26130: Simplify return logic.
Wed, Jan 29, 5:27 PM · Frameworks
tcanabrava abandoned D26129: Remove Iterator based loops for range based loops.
Wed, Jan 29, 5:26 PM · Frameworks
tcanabrava added a comment to D26876: Remove the Enum hack: finish lists with a comma, it's valid c++.

update / rebased.

Wed, Jan 29, 5:24 PM · Frameworks
tcanabrava updated the diff for D26876: Remove the Enum hack: finish lists with a comma, it's valid c++.
  • Use qAsConst
Wed, Jan 29, 5:24 PM · Frameworks
tcanabrava added a comment to D26368: Add an is<PropertyName>Immutable to know if a property is immutable.

it's a +1 for me. @dfaure and @ervin ?

Wed, Jan 29, 4:34 PM · Frameworks
tcanabrava added a comment to D26368: Add an is<PropertyName>Immutable to know if a property is immutable.

I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind of code in Qml:

Wed, Jan 29, 2:34 PM · Frameworks
tcanabrava updated the diff for D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens.
  • Simplify Architecture
Wed, Jan 29, 1:30 PM · Plasma
tcanabrava added a comment to D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens.

This is definitely an area for improvement.

This code was initially written before QGuiApplication::screenRemoved existed, which is why it's like this.
I think this solution is overly complex, you have the pointer to what changed in screenRemoved, we then discard that information and then go through loops to effectively retrieve that information we originally had.
With a refactor that could be cleaner.

Wed, Jan 29, 12:39 PM · Plasma
tcanabrava requested review of D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens.
Wed, Jan 29, 12:00 PM · Plasma

Tue, Jan 28

tcanabrava closed D26573: Add missing Import Env Variable.
Tue, Jan 28, 4:26 PM · Build System, Frameworks
tcanabrava committed R240:ee0531749057: Add missing Import Env Variable (authored by tcanabrava).
Add missing Import Env Variable
Tue, Jan 28, 4:26 PM
tcanabrava updated the diff for D26573: Add missing Import Env Variable.
  • Fix Variable
Tue, Jan 28, 4:26 PM · Build System, Frameworks
tcanabrava accepted D26961: Be more helpfully verbose when we can't start an action.
Tue, Jan 28, 12:48 PM · Frameworks

Mon, Jan 27

Tomaz Canabrava <tcanabraba@kde.org> committed R1034:8a395481a48a: Add a pipelineWatcher to log possible warnings and error messages from GStreamer (authored by tcanabrava).
Add a pipelineWatcher to log possible warnings and error messages from GStreamer
Mon, Jan 27, 1:48 PM
Tomaz Canabrava <tcanabraba@kde.org> committed R1034:e887d2a9e090: Adapt gstreamer integration and plugins for VideoSurface (authored by tcanabrava).
Adapt gstreamer integration and plugins for VideoSurface
Mon, Jan 27, 1:48 PM
Tomaz Canabrava <tcanabraba@kde.org> committed R1034:9488d65e56e4: new method: GStreamerIntegration::takeSnapshot (authored by tcanabrava).
new method: GStreamerIntegration::takeSnapshot
Mon, Jan 27, 1:48 PM
Tomaz Canabrava <tcanabraba@kde.org> committed R1034:974867a708f3: New Class: VideoSurface (authored by tcanabrava).
New Class: VideoSurface
Mon, Jan 27, 1:48 PM

Sat, Jan 25

tcanabrava added a comment to D26133: Enable Auto Save.

I agree with the comments, but I'm a bit lost on how to implement that in KCoreConfigSkeleton:
the isSaveNeeded reads the value of the variable and return if it's different from the reference variable. (that I tougth it was a reference *value*, to find out that it's a *variable reference*.
so, if I change my setting via:

Sat, Jan 25, 5:13 PM · Frameworks

Fri, Jan 24

tcanabrava added reviewers for D26131: Braces around for, break early.: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26867: New class: KConfigTypeInformation: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26868: Move newItem to private method in KConfigSourceGenerator: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26876: Remove the Enum hack: finish lists with a comma, it's valid c++: ervin, dfaure.
Fri, Jan 24, 5:43 PM · Frameworks
tcanabrava added reviewers for D26877: Simplify calls to whitespace() and use it in more places.: dfaure, ervin.
Fri, Jan 24, 5:42 PM · Frameworks

Thu, Jan 23

tcanabrava updated the diff for D26131: Braces around for, break early..
  • use std::any_of
Thu, Jan 23, 4:33 PM · Frameworks
tcanabrava requested review of D26877: Simplify calls to whitespace() and use it in more places..
Thu, Jan 23, 4:22 PM · Frameworks
tcanabrava requested review of D26876: Remove the Enum hack: finish lists with a comma, it's valid c++.
Thu, Jan 23, 4:03 PM · Frameworks
tcanabrava requested review of D26868: Move newItem to private method in KConfigSourceGenerator.
Thu, Jan 23, 2:31 PM · Frameworks
tcanabrava updated the diff for D26867: New class: KConfigTypeInformation.
  • Fix position of reference on parameter
Thu, Jan 23, 1:51 PM · Frameworks
tcanabrava requested review of D26867: New class: KConfigTypeInformation.
Thu, Jan 23, 12:31 PM · Frameworks

Wed, Jan 22

tcanabrava committed R237:95aee1294e32: Refactor KConfigXT (authored by tcanabrava).
Refactor KConfigXT
Wed, Jan 22, 2:20 PM
tcanabrava closed D26202: Refactor KConfigXT.
Wed, Jan 22, 2:20 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Rebase
Wed, Jan 22, 2:11 PM · Frameworks
tcanabrava abandoned D26768: Revert "Revert "WIP: Refactor KConfigXT"".
Wed, Jan 22, 2:10 PM · Frameworks
tcanabrava added inline comments to D26202: Refactor KConfigXT.
Wed, Jan 22, 10:53 AM · Frameworks
tcanabrava added a comment to D26202: Refactor KConfigXT.

@ervin since they are just nitpicks I'll fix in code and land the patch.

Wed, Jan 22, 9:57 AM · Frameworks
tcanabrava accepted D22476: Port away from kdelibs4support.
Wed, Jan 22, 9:56 AM
tcanabrava added a comment to D26761: Unbreak opening in separate process and fix crashes.

(ah, also, konsole has been migrated to gitlab in invent.kde.org - you migth get better reviews there)

Wed, Jan 22, 9:55 AM · Konsole

Jan 19 2020

tcanabrava added a comment to D26202: Refactor KConfigXT.

I checked https://cgit.kde.org/kconfig.git/tree/src/kconfig_compiler/kcfg.xsd and it says

<xsd:element name="group" maxOccurs="unbounded" >
                   <xsd:complexType>
                       <xsd:sequence>
                           <xsd:element name="entry" maxOccurs="unbounded">

According to google default of minOccurs is 1 so empty files are indeed not allowed

Jan 19 2020, 7:20 PM · Frameworks
tcanabrava added a comment to D26761: Unbreak opening in separate process and fix crashes.

It works if not launched from another terminal I think, but Konsole explicitly launches a new instance in that case:

But before that it checks if --new-tab is passed, and then forces re-using the existing, so I'm not sure why that doesn't work. But the correct thing to do is to fix that at least:

Ideally we should pass along the environment to the existing konsole so it can set it in the new tab, but that involves reimplementing kdbusservice (like okular does), and is a bit less trivial.

edit; I tested, and --new-tab works as expected with my revert.

Jan 19 2020, 4:22 PM · Konsole
tcanabrava updated subscribers of D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

I think we are misunderstanding eachother here.
If I'm developing the software and running cmake all the time, having a
warning that I can't fix (because it depends in another platform) is noise,
but still being a developer I don't want to run with -Wno-dev.
I do work in applications that targets more than one system (and they are
mac / windows / ios / android) I tend to use buildhosts, and those
buildhosts will tell me the warning - if any. But only if I'm targeting
them.

Jan 19 2020, 4:20 PM · Build System, Frameworks
tcanabrava added a comment to D26202: Refactor KConfigXT.

@dfaure I tried to remove the WIP from the history but I'm worried that will force git push --force as I merged this with the wip before.
any hints?

Jan 19 2020, 3:24 PM · Frameworks
tcanabrava retitled D26202: Refactor KConfigXT from WIP: Refactor KConfigXT to Refactor KConfigXT .
Jan 19 2020, 3:23 PM · Frameworks
tcanabrava requested review of D26768: Revert "Revert "WIP: Refactor KConfigXT"".
Jan 19 2020, 3:22 PM · Frameworks
tcanabrava added a reverting change for R237:5f8c2ce63499: Revert "WIP: Refactor KConfigXT": D26768: Revert "Revert "WIP: Refactor KConfigXT"".
Jan 19 2020, 3:22 PM
tcanabrava abandoned D26766: Revert "Revert "WIP: Refactor KConfigXT"".
Jan 19 2020, 2:26 PM · Frameworks
tcanabrava requested review of D26766: Revert "Revert "WIP: Refactor KConfigXT"".
Jan 19 2020, 2:25 PM · Frameworks
tcanabrava added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

That’s not a developer issue, it’s a packaging issue.

Jan 19 2020, 12:03 PM · Build System, Frameworks
tcanabrava updated subscribers of D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

But why would I get the warning if I build on Linux? The warning should
target the platform, not the entire build system.

Jan 19 2020, 11:55 AM · Build System, Frameworks
tcanabrava updated subscribers of D26761: Unbreak opening in separate process and fix crashes.

My patch fixed one bug (and probably created the others as you found out),
this patch reverts mine, but does —new-tab works if konsole is set to
multiple instances?

Jan 19 2020, 11:53 AM · Konsole

Jan 18 2020

tcanabrava added a comment to D26202: Refactor KConfigXT.

Aparently the kmymoney issue was the same: empty kconfig file. I just successfully compiled kdevelop and kmymoney.
I'll let the computer to compile the whole kde applications from scratch tonigth to see if it will fail somewhere.

Jan 18 2020, 9:45 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Revert "Revert "WIP: Refactor KConfigXT""
  • Add Reference files for Broken KDevelop Configuration
  • Fix generating of empty configuration files
Jan 18 2020, 9:14 PM · Frameworks
tcanabrava added a comment to D26202: Refactor KConfigXT.

who knew? This actually was not a false positive: the kdevelop build failure was a bug in kdevelop.
I already opened a ticket: https://invent.kde.org/kde/kdevelop/merge_requests/90
but at the same time I added code to handle the case of broken / empty kconfigxt.

Jan 18 2020, 9:11 PM · Frameworks
tcanabrava accepted D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Jan 18 2020, 2:06 PM · Build System, Frameworks
tcanabrava accepted D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
Jan 18 2020, 1:49 PM · Build System, Frameworks

Jan 17 2020

tcanabrava requested review of D26202: Refactor KConfigXT.
Jan 17 2020, 10:06 AM · Frameworks
tcanabrava reopened D26202: Refactor KConfigXT.

Reopening for review :)

Jan 17 2020, 10:06 AM · Frameworks
tcanabrava added a comment to D26202: Refactor KConfigXT.

We can revert, and I’ll fix the full build. Doing that now.

Jan 17 2020, 10:05 AM · Frameworks
tcanabrava added a reverting change for R237:98c32e29f504: WIP: Refactor KConfigXT: R237:5f8c2ce63499: Revert "WIP: Refactor KConfigXT".
Jan 17 2020, 10:04 AM
tcanabrava committed R237:5f8c2ce63499: Revert "WIP: Refactor KConfigXT" (authored by tcanabrava).
Revert "WIP: Refactor KConfigXT"
Jan 17 2020, 10:04 AM
tcanabrava added a comment to D26202: Refactor KConfigXT.

We can revert, and I’ll fix the full build. Doing that now.

Jan 17 2020, 9:42 AM · Frameworks

Jan 16 2020

tcanabrava committed R237:98c32e29f504: WIP: Refactor KConfigXT (authored by tcanabrava).
WIP: Refactor KConfigXT
Jan 16 2020, 10:15 AM
tcanabrava closed D26202: Refactor KConfigXT.
Jan 16 2020, 10:15 AM · Frameworks

Jan 15 2020

tcanabrava added inline comments to D26202: Refactor KConfigXT.
Jan 15 2020, 10:18 AM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Rebase
Jan 15 2020, 10:16 AM · Frameworks

Jan 14 2020

tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Add missing copyright holders
Jan 14 2020, 6:53 PM · Frameworks
tcanabrava added a comment to D26202: Refactor KConfigXT.

Took the time to nuke the SignalArguments and use Param instead, easier than I initially tougth.

Jan 14 2020, 11:57 AM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Simplify List creation
  • Fail with the diff file name
  • Simplify Code
  • Fix Typo
  • Remove SignalArgument for Param
  • Nitpicks and Include fixes
Jan 14 2020, 11:52 AM · Frameworks

Jan 12 2020

tcanabrava added a comment to D26202: Refactor KConfigXT.

Right now the code passes all the tests and I tried to be extra careful not to break away with the general architecture. I think it's the first "safe" version to review.

Jan 12 2020, 5:31 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Fix bug ediging param variable that's supposed to be const
  • Const Correctness:
Jan 12 2020, 5:26 PM · Frameworks
tcanabrava added inline comments to D26202: Refactor KConfigXT.
Jan 12 2020, 2:25 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Rename KConfigCodeGenerator to KconfigCodeGeneratorBase
  • Simplify diff file saving
  • Add License Headers
  • Documentation, Privatization, Unused method / variable
  • Const, Documentation
  • Newlines at the end of files
  • Spacing
  • Remove Globals
  • Remove unused code and Debugs
  • Constify ParseResult
  • English Typos
  • qAsConst
  • Public / Private issues
  • Simplify Construction
  • Revert "Constify ParseResult"
Jan 12 2020, 2:17 PM · Frameworks
tcanabrava added inline comments to D26202: Refactor KConfigXT.
Jan 12 2020, 1:54 PM · Frameworks

Jan 11 2020

tcanabrava added a comment to D26202: Refactor KConfigXT.

Looking at the review you it's a bis strange to see that I'v touched some test reference generated code, I did this only on *whitespace only changes* where the new whitespace made more sense than the old one.
there is *one* bug I havent fixed on this code that I plan to fix tomorrow, as it's almost 9:45 and it's saturday. I believe that this code is getting near review quality.
I'v also rebased against master as some other people also started to change this code - I already got a few conflicts, so I really need to rush this before it gets unmergeable.

Jan 11 2020, 9:43 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Fix whitespace on the reference code / genreator
Jan 11 2020, 9:40 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • More whiteespaces fixed
  • Fix *space only* issues with the test reference headers
  • More whitespace fixes, only six files to go
  • Way more tests passing - space fixes
Jan 11 2020, 8:48 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Fix many small whitespace issues
Jan 11 2020, 7:19 PM · Frameworks
tcanabrava updated the diff for D26202: Refactor KConfigXT.
  • Rebase on master
Jan 11 2020, 6:10 PM · Frameworks
tcanabrava added a comment to D25449: Start of the new Formats KCM.

With OverlaySheet

Jan 11 2020, 4:03 PM · Plasma
tcanabrava updated the diff for D25449: Start of the new Formats KCM.
  • Merge branch 'master' into arcpatch-D25449
  • Use OverlaySheet
Jan 11 2020, 4:01 PM · Plasma
tcanabrava closed D26489: Use qmlRegisterAnonymousType.
Jan 11 2020, 3:25 PM · Plasma
tcanabrava committed R112:7a6b1a037e65: Use qmlRegisterAnonymousType (authored by tcanabrava).
Use qmlRegisterAnonymousType
Jan 11 2020, 3:25 PM
tcanabrava updated the diff for D26489: Use qmlRegisterAnonymousType.
  • Move typeRegistration to the Plugin instanciation
Jan 11 2020, 3:17 PM · Plasma
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • ListElement does not handle i18n calls, use raw array
  • Dont complain about null background - Failing on Qt 5.14
  • Add Key entries to the kconfigxt generator
  • ArtsBell* -> CustomBell*
  • kModifiers* -> KeyboardModifiers*
  • Rename mouse settings
  • Remove deprecated call
  • Fix nitpicks
  • Fix Qml Style
  • Use QFileDialog to look for audio files
  • Fix Binary checks
  • Mark as Q_INVOKABLE, not Q_SCRIPTABLE
  • Use QtQuick Dialogs for the audio file
  • Fix orca calls
  • Use Label instead of placeholder text
  • Fix icon & text for search audio files
  • Fix Triggers
  • Trigger orcaInstalled() only when entering ScreenReader
  • Add explanation for magic number
  • Add transient window for the KNofityConfigWidget dialog
  • Fix KConfig Misuse
  • Explain property
  • Audible Bell Layout
  • Add string context
Jan 11 2020, 2:00 PM · Plasma

Jan 10 2020

tcanabrava requested review of D26573: Add missing Import Env Variable.
Jan 10 2020, 9:35 PM · Build System, Frameworks
tcanabrava updated the diff for D25449: Start of the new Formats KCM.
  • Fix esc and click outside to close the overlay
Jan 10 2020, 9:03 PM · Plasma