tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (202 w, 4 d)
Availability
Available

Recent Activity

Wed, Oct 16

tcanabrava added a comment to D24224: Start of the accessibility KCM.


Now it uses a Vertical List, providing a better navigation mode, The Settings where also rewritten using KConfigXT so I don't need to deal with all the possible properties. This actually hit a hard limit in the KConfigXT framework and I had to split in multiple files. aparently KConfigXT can't handle more than 32 settings at the moment.

Wed, Oct 16, 7:16 AM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Use Plasma KCM
  • Adapt to FormLayout
  • Fix label
  • Space every tab equally
  • Form layout port
  • FormLayout
  • Simplify Qml
  • Port to Form Layout
  • A much much better layout than tabs
  • Beginning of KConfigXt Port
  • Add KConfigXt stubs
  • Fix install
  • Fix wrong values accessed
  • s/visibleBell/visualBell
  • Fix Many issues with the KConfigXT port
  • Fixes
  • Fix all the KConfigXT noiseances
Wed, Oct 16, 7:14 AM · Plasma

Fri, Oct 11

tcanabrava added inline comments to D24224: Start of the accessibility KCM.
Fri, Oct 11, 12:27 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

Can you please follow KDE Frameworks coding style

Fri, Oct 11, 12:17 PM · Plasma
tcanabrava committed R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite (authored by tcanabrava).
WIP: Beginning of the Baloo/Search KCM Rewrite
Fri, Oct 11, 12:11 PM
tcanabrava closed T7271: File Search as Resolved by committing R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite.
Fri, Oct 11, 12:11 PM · Plasma: KCM Redesign
tcanabrava closed D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
Fri, Oct 11, 12:11 PM · Plasma

Wed, Oct 9

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix Strings
  • Fix margins
Wed, Oct 9, 6:12 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate.

Wed, Oct 9, 5:15 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Use Plasma KCM
  • Adapt to FormLayout
  • Fix label
  • Space every tab equally
  • Form layout port
  • FormLayout
  • Simplify Qml
  • Port to Form Layout
Wed, Oct 9, 5:14 PM · Plasma
tcanabrava added a comment to D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.

I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not used.

Wed, Oct 9, 4:31 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • fix Comment
Wed, Oct 9, 4:30 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Simplify Checkboxes
  • Fix previouslyEnabled logic
  • Tell Qml that we have the values
  • Move code around
  • Fix QSet math
  • Qml gives us a Url, we want the Local file
  • use folderAdded and folderRemoved
  • Remove debug information
  • Add spacing
Wed, Oct 9, 4:29 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button
  • Fix borders and background for the Baloo KCM
  • Use kirigami BasicListItem
  • Spacing
  • Fix mapping of roles
  • Fix delegate / Mouse integration
Wed, Oct 9, 2:57 PM · Plasma

Thu, Oct 3

tcanabrava updated the diff for D24374: WIP: Initial port of the Date and Time KCM.

wq - Restore colors metatada, and correctly set the datetime metadata

  • s/kcmclock/kcm_clock
  • Fix author
  • kcm_name break kauth, it needs kcmname =/
  • Fix missing property, Add a Qml Clock (from the Qt Demos)
  • Add a Time Zone list.
  • Fix many layout mistakes
Thu, Oct 3, 7:00 PM · Plasma

Wed, Oct 2

tcanabrava updated the diff for D24374: WIP: Initial port of the Date and Time KCM.
  • Fix KAuth usage
Wed, Oct 2, 8:40 PM · Plasma
tcanabrava requested review of D24374: WIP: Initial port of the Date and Time KCM.
Wed, Oct 2, 8:19 PM · Plasma

Thu, Sep 26

tcanabrava abandoned D24187: Start of the accessibility KCM.

closing this as arc diff opened two reviews with the same content =/

Thu, Sep 26, 2:57 PM · Plasma
tcanabrava added a comment to D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.

got it, updating.

Thu, Sep 26, 2:53 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) The top groupbox of Activation Gestures items could be moved to their respective groupboxes also so there are less groupboxes on the Keyboard tab than before on these 3 tabs.

Thu, Sep 26, 2:52 PM · Plasma

Wed, Sep 25

tcanabrava updated the summary of D24187: Start of the accessibility KCM.
Wed, Sep 25, 3:33 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Make buttons work
Wed, Sep 25, 3:13 PM · Plasma
tcanabrava requested review of D24224: Start of the accessibility KCM.
Wed, Sep 25, 2:43 PM · Plasma
tcanabrava added a comment to T11774: Port Accessibility KCM to Qml.

https://phabricator.kde.org/D24187 has a wip, it currently is a 1 to 1 translation of the Widgets one, we need a better layout for it.

Wed, Sep 25, 1:50 PM · Plasma: KCM Redesign
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Remove the ui file
  • Rename kcm_access to kcmaccess
  • Fix typos
  • Qml Loads. Now, fix beaury
  • Fix imports and labels
  • Fix most layouts
  • Fix layout for the mouse navigation
  • Initial Working Gestures
  • Add boilerplate
  • Fixes on bell
  • Fix functionality
Wed, Sep 25, 1:50 PM · Plasma
tcanabrava created T11774: Port Accessibility KCM to Qml.
Wed, Sep 25, 1:49 PM · Plasma: KCM Redesign

Tue, Sep 24

ognarb awarded D24187: Start of the accessibility KCM a Love token.
Tue, Sep 24, 8:59 PM · Plasma
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Initial Working Gestures
Tue, Sep 24, 5:47 PM · Plasma
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Rename kcm_access to kcmaccess
  • Fix typos
  • Qml Loads. Now, fix beaury
  • Fix imports and labels
  • Fix most layouts
  • Fix layout for the mouse navigation
Tue, Sep 24, 5:36 PM · Plasma
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Remove the ui file
Tue, Sep 24, 2:14 PM · Plasma
tcanabrava requested review of D24187: Start of the accessibility KCM.
Tue, Sep 24, 1:08 PM · Plasma

Mon, Sep 23

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button
  • Fix borders and background for the Baloo KCM
Mon, Sep 23, 7:45 AM · Plasma

Sep 16 2019

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button
Sep 16 2019, 7:14 PM · Plasma
tcanabrava committed R120:b159222aa558: Take in consideration flat() for the All Applications menu (authored by tcanabrava).
Take in consideration flat() for the All Applications menu
Sep 16 2019, 12:17 PM
tcanabrava closed D22762: Take in consideration flat() for the All Applications menu.
Sep 16 2019, 12:17 PM · Plasma

Sep 11 2019

tcanabrava committed R319:050e06d220e9: Fix Drag Drop from splits in Wayland (authored by tcanabrava).
Fix Drag Drop from splits in Wayland
Sep 11 2019, 1:34 PM

Sep 10 2019

tcanabrava added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

I needed a new accelerator for focus split right left top bottom, I talked
to David this weekend and we agreed to restore the old accelerator for move
tab.

Sep 10 2019, 7:17 AM · Konsole

Sep 7 2019

tcanabrava committed R73:167649d36604: Don't query for the document twice (authored by tcanabrava).
Don't query for the document twice
Sep 7 2019, 2:10 PM
tcanabrava committed R73:f1fca7c854b0: documenttypeswidget: simplify code (authored by tcanabrava).
documenttypeswidget: simplify code
Sep 7 2019, 2:10 PM
tcanabrava committed R73:d67b0b6b03b8: edgetypesdelegate: fix mem leak (authored by tcanabrava).
edgetypesdelegate: fix mem leak
Sep 7 2019, 1:59 PM
tcanabrava committed R73:ca563d222656: edgetypesdelegate: simplify logic (authored by tcanabrava).
edgetypesdelegate: simplify logic
Sep 7 2019, 1:59 PM
tcanabrava committed R73:19dc1fd4d5ed: edgetypesdelegate: dont append on temporary (authored by tcanabrava).
edgetypesdelegate: dont append on temporary
Sep 7 2019, 1:59 PM
tcanabrava committed R73:3e18456fa62d: Use QScopedPointer to guard against memleaks (authored by tcanabrava).
Use QScopedPointer to guard against memleaks
Sep 7 2019, 1:54 PM
tcanabrava committed R73:89ecb4e72b49: fileformatdialog: Fix memory leak of the FileDialog (authored by tcanabrava).
fileformatdialog: Fix memory leak of the FileDialog
Sep 7 2019, 1:54 PM
tcanabrava committed R73:8a44b096001a: nodetypesdelegate: fix memory leak (authored by tcanabrava).
nodetypesdelegate: fix memory leak
Sep 7 2019, 1:36 PM
tcanabrava committed R73:d5093f7d857f: nodetypesdelegate: dont append on temporary (authored by tcanabrava).
nodetypesdelegate: dont append on temporary
Sep 7 2019, 1:36 PM
tcanabrava committed R73:86c55aab45ed: scriptoutputwidget: simplify updateFixupButton logic (authored by tcanabrava).
scriptoutputwidget: simplify updateFixupButton logic
Sep 7 2019, 1:36 PM
tcanabrava committed R73:773589d6692b: sidedockwidget: simplify sizehint (authored by tcanabrava).
sidedockwidget: simplify sizehint
Sep 7 2019, 1:28 PM
tcanabrava committed R73:97b2d5c65159: mainwindow: no else after return (authored by tcanabrava).
mainwindow: no else after return
Sep 7 2019, 1:23 PM
tcanabrava committed R73:c44c4ae2baf1: sidedockwidget: get rid of depreccated method (authored by tcanabrava).
sidedockwidget: get rid of depreccated method
Sep 7 2019, 1:23 PM
tcanabrava committed R73:fd845181c5f5: mainwindow: spacing (authored by tcanabrava).
mainwindow: spacing
Sep 7 2019, 1:23 PM
tcanabrava committed R73:ece487f0545a: mainwindow: de-escalate if (authored by tcanabrava).
mainwindow: de-escalate if
Sep 7 2019, 1:23 PM
tcanabrava committed R73:3e8ca8cee330: mainwindow: spacing (authored by tcanabrava).
mainwindow: spacing
Sep 7 2019, 1:23 PM
tcanabrava committed R73:056cd3444676: mainwidow, sidedockwidget: simplify layout and logic (authored by tcanabrava).
mainwidow, sidedockwidget: simplify layout and logic
Sep 7 2019, 1:23 PM
tcanabrava committed R73:cecb00e5c4ec: mainwindow: use auto when type is explicit (authored by tcanabrava).
mainwindow: use auto when type is explicit
Sep 7 2019, 1:23 PM
tcanabrava committed R73:a6fe09916db3: mainwindow.cpp Use list initialization instead of appending to temporary (authored by tcanabrava).
mainwindow.cpp Use list initialization instead of appending to temporary
Sep 7 2019, 1:23 PM
tcanabrava committed R73:a4c359356856: mainwindow: simplify queryClose (authored by tcanabrava).
mainwindow: simplify queryClose
Sep 7 2019, 1:23 PM
tcanabrava committed R73:4aad1105e318: mainwindow: simplify if logic (authored by tcanabrava).
mainwindow: simplify if logic
Sep 7 2019, 1:23 PM

Sep 4 2019

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Name fixes
Sep 4 2019, 4:35 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
Sep 4 2019, 4:18 PM · Plasma
tcanabrava requested review of D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
Sep 4 2019, 2:39 PM · Plasma

Sep 2 2019

tcanabrava added a comment to D23601: Fix the fallback code used when restoring session fails.

When I tested I kept a old profile but probably forgot to use during
development. Sorry for the trouble :)

Sep 2 2019, 7:11 AM · Konsole

Aug 28 2019

tcanabrava added a comment to D23461: Remove 'magic' filtering of recent apps.

@ngraham I agree with you completely. it's basically removing a bit of code, smaller patch and the code behaves without surprises.

Aug 28 2019, 1:44 PM · Plasma
tcanabrava updated the diff for D23461: Remove 'magic' filtering of recent apps.
  • Revert "Remove filtering of recent apps that are in the favorites"
  • Add a new Q_PROPERTY to the Recents Model to filter out or not favorites
Aug 28 2019, 11:09 AM · Plasma
tcanabrava updated subscribers of D23461: Remove 'magic' filtering of recent apps.

Is there a reason to change kicker? If not, it needs to be a property.

Aug 28 2019, 8:41 AM · Plasma
tcanabrava committed R293:7190e177f537: Fixes a crash in Peruse triggered by baloo (authored by tcanabrava).
Fixes a crash in Peruse triggered by baloo
Aug 28 2019, 8:31 AM
tcanabrava closed D23200: Fixes a crash in Peruse triggered by baloo.
Aug 28 2019, 8:31 AM · Baloo, Frameworks
tcanabrava updated the diff for D23461: Remove 'magic' filtering of recent apps.
  • Revert "Remove 'magic' filtering of recent apps"
  • Remove filtering of recent apps that are in the favorites
Aug 28 2019, 8:29 AM · Plasma

Aug 26 2019

tcanabrava requested review of D23461: Remove 'magic' filtering of recent apps.
Aug 26 2019, 12:14 PM · Plasma

Aug 19 2019

tcanabrava committed R323:e1550fa8f4b1: Missing identifier on Graph3D (authored by tcanabrava).
Missing identifier on Graph3D
Aug 19 2019, 5:49 PM

Aug 16 2019

tcanabrava updated the diff for D23200: Fixes a crash in Peruse triggered by baloo.
  • Remove debug line
  • return null instead of asserting
Aug 16 2019, 2:54 PM · Baloo, Frameworks
tcanabrava requested review of D23200: Fixes a crash in Peruse triggered by baloo.
Aug 16 2019, 12:38 PM · Baloo, Frameworks

Aug 2 2019

tcanabrava updated the diff for D22890: Add new class AllAppsModel that gives us a list of installed Apps.
  • Add copyright information and docs
Aug 2 2019, 11:00 AM · Plasma
tcanabrava requested review of D22890: Add new class AllAppsModel that gives us a list of installed Apps.
Aug 2 2019, 10:51 AM · Plasma

Jul 30 2019

tcanabrava added a comment to D22762: Take in consideration flat() for the All Applications menu.

@hein I'll try to follow your approach.

Jul 30 2019, 1:50 PM · Plasma

Jul 28 2019

tcanabrava added a comment to D22756: Save Image of the Current Tab.

Caio, while understand the usecase I do agree with the rest of the reviews.

Jul 28 2019, 3:42 PM · Konsole

Jul 26 2019

tcanabrava committed R73:3e311e730bb1: Merge branch 'improve-dev-docs' into 'master' (authored by tcanabrava).
Merge branch 'improve-dev-docs' into 'master'
Jul 26 2019, 3:07 PM
tcanabrava committed R119:0b9eb1e70c96: Take in consideration flat() for the All Applications menu (authored by tcanabrava).
Take in consideration flat() for the All Applications menu
Jul 26 2019, 1:52 PM
tcanabrava closed D22762: Take in consideration flat() for the All Applications menu.
Jul 26 2019, 1:52 PM · Plasma
tcanabrava requested review of D22762: Take in consideration flat() for the All Applications menu.
Jul 26 2019, 1:38 PM · Plasma

Jul 19 2019

tcanabrava committed R319:47d97aa0b3f5: Remove obsolete call 'rects', use begin / end iterators. (authored by tcanabrava).
Remove obsolete call 'rects', use begin / end iterators.
Jul 19 2019, 2:45 PM

Jul 18 2019

tcanabrava committed R32:8a3d8936fc4f: Add missing include (authored by tcanabrava).
Add missing include
Jul 18 2019, 5:22 PM
tcanabrava accepted D22383: For profileNames function uses Q_PROPERTY.
Jul 18 2019, 1:09 PM

Jul 13 2019

tcanabrava updated the summary of D22445: WIP: Open from cache / Open Normally.
Jul 13 2019, 5:48 PM · Plasma
tcanabrava requested review of D22445: WIP: Open from cache / Open Normally.
Jul 13 2019, 5:44 PM · Plasma
tcanabrava committed R871:653388df0ff9: Remove forced crash storage (authored by tcanabrava).
Remove forced crash storage
Jul 13 2019, 5:28 PM
tcanabrava committed R871:107a9f5c6c45: Create helper object to hold the connections (authored by tcanabrava).
Create helper object to hold the connections
Jul 13 2019, 5:09 PM
tcanabrava committed R871:483808137d3f: Store only the last 10 files in the cache directory (authored by tcanabrava).
Store only the last 10 files in the cache directory
Jul 13 2019, 5:09 PM
tcanabrava committed R871:c8dda347e418: Add pid information to the log files (authored by tcanabrava).
Add pid information to the log files
Jul 13 2019, 5:09 PM
tcanabrava committed R871:5c581620b5f7: Store crash report automatically if shutting down (authored by tcanabrava).
Store crash report automatically if shutting down
Jul 13 2019, 5:09 PM
tcanabrava closed D22322: Store crash report automatically if shutting down.
Jul 13 2019, 5:09 PM · Plasma

Jul 10 2019

tcanabrava accepted D22331: Add method to store settings using QVariantMap.
Jul 10 2019, 3:53 PM
tcanabrava updated the diff for D22322: Store crash report automatically if shutting down.
  • Add pid information to the log files
  • Store only the last 10 files in the cache directory
Jul 10 2019, 3:16 PM · Plasma

Jul 9 2019

tcanabrava requested changes to D22331: Add method to store settings using QVariantMap.
Jul 9 2019, 5:16 PM

Jul 8 2019

tcanabrava updated the diff for D22322: Store crash report automatically if shutting down.
  • Add pid information to the log files
  • rebase
Jul 8 2019, 7:05 PM · Plasma
tcanabrava added reviewers for D22322: Store crash report automatically if shutting down: sitter, davidedmundson.
Jul 8 2019, 7:05 PM · Plasma
tcanabrava committed R108:a3f2d56eafd0: Don't call << in a temporary vector (authored by tcanabrava).
Don't call << in a temporary vector
Jul 8 2019, 7:03 PM
tcanabrava closed D21263: Don't call << in a temporary vector.
Jul 8 2019, 7:03 PM · KWin
tcanabrava committed R871:2f828efa74b3: Fix some tests in release mode (authored by tcanabrava).
Fix some tests in release mode
Jul 8 2019, 7:01 PM
tcanabrava closed D22242: Fix some tests in release mode.
Jul 8 2019, 7:01 PM · Plasma