tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (194 w, 2 d)
Availability
Available

Recent Activity

Mon, Aug 19

tcanabrava committed R323:e1550fa8f4b1: Missing identifier on Graph3D (authored by tcanabrava).
Missing identifier on Graph3D
Mon, Aug 19, 5:49 PM

Fri, Aug 16

tcanabrava updated the diff for D23200: Fixes a crash in Peruse triggered by baloo.
  • Remove debug line
  • return null instead of asserting
Fri, Aug 16, 2:54 PM · Baloo, Frameworks
tcanabrava requested review of D23200: Fixes a crash in Peruse triggered by baloo.
Fri, Aug 16, 12:38 PM · Baloo, Frameworks

Fri, Aug 2

tcanabrava updated the diff for D22890: Add new class AllAppsModel that gives us a list of installed Apps.
  • Add copyright information and docs
Fri, Aug 2, 11:00 AM · Plasma
tcanabrava requested review of D22890: Add new class AllAppsModel that gives us a list of installed Apps.
Fri, Aug 2, 10:51 AM · Plasma

Tue, Jul 30

tcanabrava added a comment to D22762: Take in consideration flat() for the All Applications menu.

@hein I'll try to follow your approach.

Tue, Jul 30, 1:50 PM · Plasma

Sun, Jul 28

tcanabrava added a comment to D22756: Save Image of the Current Tab.

Caio, while understand the usecase I do agree with the rest of the reviews.

Sun, Jul 28, 3:42 PM · Konsole

Fri, Jul 26

tcanabrava committed R73:3e311e730bb1: Merge branch 'improve-dev-docs' into 'master' (authored by tcanabrava).
Merge branch 'improve-dev-docs' into 'master'
Fri, Jul 26, 3:07 PM
tcanabrava committed R119:0b9eb1e70c96: Take in consideration flat() for the All Applications menu (authored by tcanabrava).
Take in consideration flat() for the All Applications menu
Fri, Jul 26, 1:52 PM
tcanabrava closed D22762: Take in consideration flat() for the All Applications menu.
Fri, Jul 26, 1:52 PM · Plasma
tcanabrava requested review of D22762: Take in consideration flat() for the All Applications menu.
Fri, Jul 26, 1:38 PM · Plasma

Jul 19 2019

tcanabrava committed R319:47d97aa0b3f5: Remove obsolete call 'rects', use begin / end iterators. (authored by tcanabrava).
Remove obsolete call 'rects', use begin / end iterators.
Jul 19 2019, 2:45 PM

Jul 18 2019

tcanabrava committed R32:8a3d8936fc4f: Add missing include (authored by tcanabrava).
Add missing include
Jul 18 2019, 5:22 PM
tcanabrava accepted D22383: For profileNames function uses Q_PROPERTY.
Jul 18 2019, 1:09 PM

Jul 13 2019

tcanabrava updated the summary of D22445: WIP: Open from cache / Open Normally.
Jul 13 2019, 5:48 PM · Plasma
tcanabrava requested review of D22445: WIP: Open from cache / Open Normally.
Jul 13 2019, 5:44 PM · Plasma
tcanabrava committed R871:653388df0ff9: Remove forced crash storage (authored by tcanabrava).
Remove forced crash storage
Jul 13 2019, 5:28 PM
tcanabrava committed R871:107a9f5c6c45: Create helper object to hold the connections (authored by tcanabrava).
Create helper object to hold the connections
Jul 13 2019, 5:09 PM
tcanabrava committed R871:483808137d3f: Store only the last 10 files in the cache directory (authored by tcanabrava).
Store only the last 10 files in the cache directory
Jul 13 2019, 5:09 PM
tcanabrava committed R871:c8dda347e418: Add pid information to the log files (authored by tcanabrava).
Add pid information to the log files
Jul 13 2019, 5:09 PM
tcanabrava committed R871:5c581620b5f7: Store crash report automatically if shutting down (authored by tcanabrava).
Store crash report automatically if shutting down
Jul 13 2019, 5:09 PM
tcanabrava closed D22322: Store crash report automatically if shutting down.
Jul 13 2019, 5:09 PM · Plasma

Jul 10 2019

tcanabrava accepted D22331: Add method to store settings using QVariantMap.
Jul 10 2019, 3:53 PM
tcanabrava updated the diff for D22322: Store crash report automatically if shutting down.
  • Add pid information to the log files
  • Store only the last 10 files in the cache directory
Jul 10 2019, 3:16 PM · Plasma

Jul 9 2019

tcanabrava requested changes to D22331: Add method to store settings using QVariantMap.
Jul 9 2019, 5:16 PM

Jul 8 2019

tcanabrava updated the diff for D22322: Store crash report automatically if shutting down.
  • Add pid information to the log files
  • rebase
Jul 8 2019, 7:05 PM · Plasma
tcanabrava added reviewers for D22322: Store crash report automatically if shutting down: sitter, davidedmundson.
Jul 8 2019, 7:05 PM · Plasma
tcanabrava committed R108:a3f2d56eafd0: Don't call << in a temporary vector (authored by tcanabrava).
Don't call << in a temporary vector
Jul 8 2019, 7:03 PM
tcanabrava closed D21263: Don't call << in a temporary vector.
Jul 8 2019, 7:03 PM · KWin
tcanabrava committed R871:2f828efa74b3: Fix some tests in release mode (authored by tcanabrava).
Fix some tests in release mode
Jul 8 2019, 7:01 PM
tcanabrava closed D22242: Fix some tests in release mode.
Jul 8 2019, 7:01 PM · Plasma
tcanabrava updated the diff for D22322: Store crash report automatically if shutting down.
  • Add pid information to the log files
Jul 8 2019, 5:21 PM · Plasma
tcanabrava added a comment to D22322: Store crash report automatically if shutting down.

And perhaps more ideally, albeit not blocking this diff, we should look at reshuffling the architecture so on next login drkonqi auto starts with a list of crashes and the ability to file reports for them.

Jul 8 2019, 3:23 PM · Plasma
tcanabrava updated the diff for D22322: Store crash report automatically if shutting down.

Store in the cache folder

Jul 8 2019, 1:14 PM · Plasma
tcanabrava committed R871:9f12ae753f43: Code cleanups (authored by tcanabrava).
Code cleanups
Jul 8 2019, 11:19 AM
tcanabrava committed R871:efc625a79d6d: Rename variable: QApplication qa to app. (authored by tcanabrava).
Rename variable: QApplication qa to app.
Jul 8 2019, 11:19 AM
tcanabrava committed R871:39301e2c5d91: Return directly without creating temporaries (authored by tcanabrava).
Return directly without creating temporaries
Jul 8 2019, 11:19 AM
tcanabrava committed R871:1af8e1cc37e9: Const-correctness (authored by tcanabrava).
Const-correctness
Jul 8 2019, 11:19 AM
tcanabrava committed R871:10c9d94a87c9: Send options as an Array (authored by tcanabrava).
Send options as an Array
Jul 8 2019, 11:19 AM
tcanabrava closed D22323: Code cleanups.
Jul 8 2019, 11:19 AM · Plasma
tcanabrava added a comment to D22323: Code cleanups.

I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was before the diff is weird, and the way it is after the diff is still weird IMHO. Also the two objects that are allocated in the two methods aren't properly deleted anywhere it seems.

Jul 8 2019, 11:18 AM · Plasma
tcanabrava requested review of D22323: Code cleanups.
Jul 8 2019, 10:11 AM · Plasma
tcanabrava requested review of D22322: Store crash report automatically if shutting down.
Jul 8 2019, 10:09 AM · Plasma

Jul 7 2019

tcanabrava committed R319:ce7b20e75eb0: Merge branch 'martin/fixrandomlyscrollingdown' into 'master' (authored by tcanabrava).
Merge branch 'martin/fixrandomlyscrollingdown' into 'master'
Jul 7 2019, 5:21 PM
tcanabrava committed R319:977c0d9eabd2: Merge branch 'gitlab/fix_message_tab_quit' into 'master' (authored by tcanabrava).
Merge branch 'gitlab/fix_message_tab_quit' into 'master'
Jul 7 2019, 5:21 PM
tcanabrava committed R319:93391779b8a5: s/tabs/terminals - We have now tabs and splits (authored by tcanabrava).
s/tabs/terminals - We have now tabs and splits
Jul 7 2019, 5:21 PM
tcanabrava committed R319:372585621c02: Merge branch 'splits-fix-repaint-after-unmaximizing' into 'master' (authored by tcanabrava).
Merge branch 'splits-fix-repaint-after-unmaximizing' into 'master'
Jul 7 2019, 5:21 PM
tcanabrava committed R319:edeabc231267: Merge branch 'splits-small-ui-fixes' into 'master' (authored by tcanabrava).
Merge branch 'splits-small-ui-fixes' into 'master'
Jul 7 2019, 5:20 PM

Jul 3 2019

tcanabrava updated the test plan for D22242: Fix some tests in release mode.
Jul 3 2019, 4:06 PM · Plasma
tcanabrava requested review of D22242: Fix some tests in release mode.
Jul 3 2019, 4:04 PM · Plasma
tcanabrava committed R871:6fd8a05b4da5: Code Simplification / Readability Changes (authored by tcanabrava).
Code Simplification / Readability Changes
Jul 3 2019, 1:33 PM
tcanabrava closed D22233: Code Simplification / Readability Changes.
Jul 3 2019, 1:33 PM · Plasma
tcanabrava updated the diff for D22233: Code Simplification / Readability Changes.
  • Store the number of stars instead of the Enum
  • Check enums with switch
Jul 3 2019, 1:30 PM · Plasma
tcanabrava updated the diff for D22233: Code Simplification / Readability Changes.
  • Store the number of stars instead of the Enum
Jul 3 2019, 10:01 AM · Plasma
tcanabrava added inline comments to D22233: Code Simplification / Readability Changes.
Jul 3 2019, 9:33 AM · Plasma
tcanabrava updated the test plan for D22233: Code Simplification / Readability Changes.
Jul 3 2019, 9:24 AM · Plasma
tcanabrava accepted D22232: assert qt and kf5 versions against their actual underlying class.
Jul 3 2019, 9:23 AM · Plasma
tcanabrava requested review of D22233: Code Simplification / Readability Changes.
Jul 3 2019, 9:22 AM · Plasma

Jul 1 2019

tcanabrava added inline comments to D22147: Better use of Qt APIs in Plasma::Theme.
Jul 1 2019, 2:13 PM · Frameworks
tcanabrava added inline comments to D22147: Better use of Qt APIs in Plasma::Theme.
Jul 1 2019, 2:11 PM · Frameworks

Jun 28 2019

tcanabrava committed R73:99f9f01f35d7: Merge branch 'improved-graph-ide-classes' into 'master' (authored by tcanabrava).
Merge branch 'improved-graph-ide-classes' into 'master'
Jun 28 2019, 2:29 PM

Jun 26 2019

tcanabrava committed R319:fd26be431a5c: Let the move tab enabled even with one tab (authored by tcanabrava).
Let the move tab enabled even with one tab
Jun 26 2019, 1:23 AM

Jun 15 2019

tcanabrava added a comment to D20816: Configure Konsole dialog GUI redesign.

You can jusr click in the "commit" button on the gitlab review.

Jun 15 2019, 5:00 PM · VDG, Konsole
tcanabrava committed R319:22356315c161: Fixes logic for Maximize / Restore terminals (authored by tcanabrava).
Fixes logic for Maximize / Restore terminals
Jun 15 2019, 2:56 PM
tcanabrava committed R319:ed946b5708ea: Use breeze inactive-tab color for inactive splits (authored by tcanabrava).
Use breeze inactive-tab color for inactive splits
Jun 15 2019, 2:56 PM
tcanabrava committed R319:dc0663833e39: Block mouse events in the header bar (authored by tcanabrava).
Block mouse events in the header bar
Jun 15 2019, 2:56 PM
tcanabrava committed R319:3eb09319f907: Paint the line as the TabBar separator for consistency (authored by tcanabrava).
Paint the line as the TabBar separator for consistency
Jun 15 2019, 2:56 PM
tcanabrava committed R319:b4ab5fe920da: Paint a 1px border at the top between the menu and the splitters (authored by tcanabrava).
Paint a 1px border at the top between the menu and the splitters
Jun 15 2019, 2:56 PM
tcanabrava committed R319:e83707fe45ca: Add a TerminalHeader when using splits (authored by tcanabrava).
Add a TerminalHeader when using splits
Jun 15 2019, 2:56 PM
tcanabrava committed R319:c9967fb4c278: Use only one accelerator to Maximize / Unmaximize a split view (authored by tcanabrava).
Use only one accelerator to Maximize / Unmaximize a split view
Jun 15 2019, 2:56 PM
tcanabrava committed R319:4c39ef39f42b: Fix the logic for Maximize / Minimize (authored by tcanabrava).
Fix the logic for Maximize / Minimize
Jun 15 2019, 2:56 PM

Jun 13 2019

tcanabrava added a comment to D21495: Use MPFR in knumber_float in order to improve floating-point precision.

@cfeck any objections here? I'll wait a few days for an outcome.

Jun 13 2019, 1:32 PM

Jun 5 2019

tcanabrava committed R954:f3d40d465ff3: Re-add tomaz blog (authored by tcanabrava).
Re-add tomaz blog
Jun 5 2019, 9:42 AM

Jun 3 2019

tcanabrava added inline comments to D21567: Use QString::replace(QChar, QString) in place of QString::replace(QRegEx, QString) in LogWidget::appendSLog.
Jun 3 2019, 8:06 PM
tcanabrava abandoned D21301: Add a TerminalHeader when using splits.

Moving to gitlab

Jun 3 2019, 2:23 PM · Konsole
tcanabrava abandoned D21309: Use only one accelerator to Maximize / Unmaximize a split view.

moving to gitlab

Jun 3 2019, 2:14 PM · Konsole
tcanabrava abandoned D21308: Fix the logic for Maximize / Minimize.

Moving to gitlab

Jun 3 2019, 2:13 PM · Konsole

May 28 2019

tcanabrava added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

lutris also depends on gnome-desktop (the library)

May 28 2019, 7:07 AM · KDE Promo

May 23 2019

tcanabrava added a comment to D21308: Fix the logic for Maximize / Minimize.

Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)

May 23 2019, 5:51 PM · Konsole
tcanabrava added a comment to D21309: Use only one accelerator to Maximize / Unmaximize a split view.

I use as focus mode. And the google icon will remember you that you are in
“fake full screen” mode.
If you look at the other terminals that offer multi split they also offer
this.

May 23 2019, 4:39 PM · Konsole
tcanabrava updated subscribers of D21301: Add a TerminalHeader when using splits.

We are but it’s a per project basis

May 23 2019, 4:38 PM · Konsole

May 21 2019

tcanabrava accepted D21325: template: check order before access.
May 21 2019, 9:21 PM · Konsole
tcanabrava updated subscribers of D21301: Add a TerminalHeader when using splits.

I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?

May 21 2019, 7:32 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add license headers
May 21 2019, 4:13 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Palette highligth fixes
May 21 2019, 3:35 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Icon / Tooltip
May 21 2019, 3:10 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Fix build
May 21 2019, 2:51 PM · Konsole
tcanabrava committed R319:d375a694a440: Hide scroll buttons for tabs (authored by tcanabrava).
Hide scroll buttons for tabs
May 21 2019, 2:42 PM
tcanabrava closed D21316: Hide scroll buttons for tabs.
May 21 2019, 2:42 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add toggle of the Maximize / Minimize split
May 21 2019, 2:36 PM · Konsole
tcanabrava added a comment to D21301: Add a TerminalHeader when using splits.

@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?

May 21 2019, 2:06 PM · Konsole
tcanabrava reopened D21301: Add a TerminalHeader when using splits.

phabricator is tracking the wrong branch , it's *not* merged. (can I have a review? :)

May 21 2019, 2:05 PM · Konsole
tcanabrava committed R319:b83382b42570: Trigger a detach (authored by tcanabrava).
Trigger a detach
May 21 2019, 1:59 PM
tcanabrava committed R319:04268e75aeba: Start the work to Drag & drop The splits (authored by tcanabrava).
Start the work to Drag & drop The splits
May 21 2019, 1:59 PM
tcanabrava committed R319:bbcc8b808623: Add HeaderBar to TerminalDisplay (authored by tcanabrava).
Add HeaderBar to TerminalDisplay
May 21 2019, 1:59 PM
tcanabrava closed D21301: Add a TerminalHeader when using splits.
May 21 2019, 1:59 PM · Konsole
tcanabrava committed R319:067aca12c9c9: Relax rules for split selection via keyboard (authored by tcanabrava).
Relax rules for split selection via keyboard
May 21 2019, 1:59 PM
tcanabrava requested review of D21316: Hide scroll buttons for tabs.
May 21 2019, 9:48 AM · Konsole

May 20 2019

tcanabrava added a reviewer for D21301: Add a TerminalHeader when using splits: ngraham.
May 20 2019, 3:19 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add HeaderBar to TerminalDisplay
May 20 2019, 3:18 PM · Konsole