tcanabrava (Tomaz Canabrava)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2015, 3:40 PM (210 w, 2 d)
Availability
Available

Recent Activity

Fri, Dec 6

tcanabrava added a comment to D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings.

I would also say that 'Baloo' means nothing to users, and File search should be used instead. It's an internal name, not really a brand.

Fri, Dec 6, 1:14 PM · Plasma
tcanabrava added a comment to D24374: WIP: Initial port of the Date and Time KCM.

Quite ugly I'm afraid.
I'll port this to KConfigXT over next week.

Fri, Dec 6, 1:06 PM · Plasma
tcanabrava added a comment to D25449: Start of the new Formats KCM.

ping?

Fri, Dec 6, 12:51 PM · Plasma
tcanabrava accepted D25482: Port from KFileDialog to QFileDialog..

Tested and works.

Fri, Dec 6, 12:41 PM
tcanabrava added a comment to D25375: Start of the accessibility KCM.

Updated texts by ngraham sugestions.

Fri, Dec 6, 12:41 PM · Plasma
tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Fix indentation
Fri, Dec 6, 12:39 PM · Plasma, Frameworks
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • Fix localization calls
Fri, Dec 6, 12:37 PM · Plasma
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • Typos and onToggled instead of onCheckStateChanged
  • Better UX / Texts
  • Text updates
  • Remove ActivationGestures page, Fix orca information
Fri, Dec 6, 11:52 AM · Plasma
tcanabrava requested review of D25781: Fix build with kf5.
Fri, Dec 6, 10:44 AM · Umbrello

Wed, Dec 4

tcanabrava requested review of D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule.
Wed, Dec 4, 3:50 PM · Plasma

Mon, Dec 2

tcanabrava added a comment to D25375: Start of the accessibility KCM.

Missing apply button being enabled seems something related to ManagedConfigModule. I don't know what to do there yet.

Mon, Dec 2, 2:13 PM · Plasma
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • Add missing setButtons
  • Fix Typo
Mon, Dec 2, 2:08 PM · Plasma
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • Fix factory name
Mon, Dec 2, 1:51 PM · Plasma
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • Fixes
  • Fixes texts and UI
  • Simplify Algorithm
  • Fix Enable / Disable status
Mon, Dec 2, 1:47 PM · Plasma

Thu, Nov 21

tcanabrava requested review of D25449: Start of the new Formats KCM.
Thu, Nov 21, 8:24 PM · Plasma
tcanabrava updated the diff for D25375: Start of the accessibility KCM.
  • Fixes
Thu, Nov 21, 1:48 PM · Plasma
tcanabrava added a comment to D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM.

I was under the impression we were killing this KCM in the very near future.

The relevant workboard entry: https://phabricator.kde.org/T7292

Thu, Nov 21, 1:10 PM · Plasma
tcanabrava abandoned D15639: Add editorconfig.
Thu, Nov 21, 1:09 PM · KDE Edu
tcanabrava abandoned D21124: Allow configuration of the Splitter Size.
Thu, Nov 21, 1:08 PM · Konsole
tcanabrava added a comment to D25084: Allow a Multiple instances to become Unique.

I'm open to counter-arguments and counter-examples. Actually, do we know of any other app than konsole which supports both Multiple and Unique modes?

Thu, Nov 21, 1:07 PM · Frameworks
tcanabrava added a comment to D25280: [Baloo KCM] Purge index when disabling indexing.

I gree with david's questioning, sometimes I disable indexing when I'm about to do something heavy, to re-enable it later. I don't want to lose all my data.
perhaps there should be a box purge database data instead of purging on disable?

Thu, Nov 21, 1:02 PM · Plasma

Tue, Nov 19

tcanabrava updated the diff for D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM.
  • Fix speed of the models
  • Simplify Logic
  • Speed up emoticon loading
  • Re-Enable updateBtn
  • Re-enable remove theme
  • Move more data to the Models
  • Re-enable the rest of the functions
  • Remove ui file
Tue, Nov 19, 8:12 PM · Plasma

Mon, Nov 18

tcanabrava requested review of D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM.
Mon, Nov 18, 8:59 PM · Plasma
tcanabrava abandoned D24224: Start of the accessibility KCM.
Mon, Nov 18, 6:34 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

After squashing the commits to remove the broken history, arc diff opened a new revision.
https://phabricator.kde.org/D25375

Mon, Nov 18, 6:34 PM · Plasma
tcanabrava requested review of D25375: Start of the accessibility KCM.
Mon, Nov 18, 6:32 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Use Plasma KCM
  • Adapt to FormLayout
  • Fix label
  • Space every tab equally
  • Form layout port
  • FormLayout
  • Simplify Qml
  • Port to Form Layout
  • A much much better layout than tabs
  • Beginning of KConfigXt Port
  • Add KConfigXt stubs
  • Fix install
  • Fix wrong values accessed
  • s/visibleBell/visualBell
  • Fix Many issues with the KConfigXT port
  • Fixes
  • Fix all the KConfigXT noiseances
  • Add background to the List
  • Add single-connects
  • Fix Layout
  • Adapt to new ManagedConfig
  • Re-add X11Info
Mon, Nov 18, 6:15 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

It doesn't compile:

/home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory
    1 | #include "kns3/downloaddialog.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~

Also we should be using the new QML-based GHNS dialog where possible, now that it's a first-class citizen.

Mon, Nov 18, 5:35 PM · Plasma
tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Handle immutability
Mon, Nov 18, 5:29 PM · Plasma, Frameworks
tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Adapt to ManagedConfigModule
Mon, Nov 18, 5:19 PM · Plasma, Frameworks

Thu, Nov 14

tcanabrava added inline comments to D25149: Add a new template for KCMs.
Thu, Nov 14, 7:42 AM · Plasma, Frameworks

Nov 12 2019

tcanabrava added a comment to D24224: Start of the accessibility KCM.

Nov 12 2019, 7:12 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Fix Layout
Nov 12 2019, 7:12 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Use Plasma KCM
  • Adapt to FormLayout
  • Fix label
  • Space every tab equally
  • Form layout port
  • FormLayout
  • Simplify Qml
  • Port to Form Layout
  • A much much better layout than tabs
  • Beginning of KConfigXt Port
  • Add KConfigXt stubs
  • Fix install
  • Fix wrong values accessed
  • s/visibleBell/visualBell
  • Fix Many issues with the KConfigXT port
  • Fixes
  • Fix all the KConfigXT noiseances
  • Add background to the List
  • Add single-connects
Nov 12 2019, 7:08 PM · Plasma
tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Add KConfigXT
  • Remove wrong icon
Nov 12 2019, 6:45 PM · Plasma, Frameworks

Nov 7 2019

tcanabrava added a comment to D25149: Add a new template for KCMs.

A very sensible idea. ++

templates/kcm-qml/qml-plasmoid.png

What's this about?

Nov 7 2019, 3:45 PM · Plasma, Frameworks
tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Add KConfigXT
Nov 7 2019, 3:44 PM · Plasma, Frameworks

Nov 4 2019

tcanabrava updated the diff for D25149: Add a new template for KCMs.
  • Update readme
Nov 4 2019, 11:24 PM · Plasma, Frameworks
tcanabrava updated the summary of D25149: Add a new template for KCMs.
Nov 4 2019, 11:21 PM · Plasma, Frameworks
tcanabrava requested review of D25149: Add a new template for KCMs.
Nov 4 2019, 11:18 PM · Plasma, Frameworks

Nov 3 2019

tcanabrava added a comment to D25084: Allow a Multiple instances to become Unique.

Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid,
this will fix your second point.
About your first point, do you think it’s a problem?

Nov 3 2019, 11:13 PM · Frameworks
tcanabrava added a comment to D25084: Allow a Multiple instances to become Unique.

im Open to redo the patch but I don’t see the problems you guys see. The
only thing this patch does is to quit early if you trigger a unique
application *after* a multiple one has been spawned.

Nov 3 2019, 10:49 PM · Frameworks

Nov 2 2019

tcanabrava added a comment to D20466: Rework scrollback settings.

Forgotten, I’ll look at it today

Nov 2 2019, 5:39 PM · Konsole

Nov 1 2019

tcanabrava updated subscribers of D25084: Allow a Multiple instances to become Unique.

But it’s not related to this path, it’s just another bug

Nov 1 2019, 3:02 PM · Frameworks
tcanabrava added a comment to D25084: Allow a Multiple instances to become Unique.

Yes, that's exactly what would happen, I think I just need to verify if the name would be the same as the name minus the uuid. because if you open an app on ::Multiple and later the same app on ::Unique, merging them seems sane.

Nov 1 2019, 1:15 PM · Frameworks

Oct 30 2019

tcanabrava requested review of D25084: Allow a Multiple instances to become Unique.
Oct 30 2019, 11:56 PM · Frameworks

Oct 16 2019

tcanabrava added a comment to D24224: Start of the accessibility KCM.


Now it uses a Vertical List, providing a better navigation mode, The Settings where also rewritten using KConfigXT so I don't need to deal with all the possible properties. This actually hit a hard limit in the KConfigXT framework and I had to split in multiple files. aparently KConfigXT can't handle more than 32 settings at the moment.

Oct 16 2019, 7:16 AM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Use Plasma KCM
  • Adapt to FormLayout
  • Fix label
  • Space every tab equally
  • Form layout port
  • FormLayout
  • Simplify Qml
  • Port to Form Layout
  • A much much better layout than tabs
  • Beginning of KConfigXt Port
  • Add KConfigXt stubs
  • Fix install
  • Fix wrong values accessed
  • s/visibleBell/visualBell
  • Fix Many issues with the KConfigXT port
  • Fixes
  • Fix all the KConfigXT noiseances
Oct 16 2019, 7:14 AM · Plasma

Oct 11 2019

tcanabrava added inline comments to D24224: Start of the accessibility KCM.
Oct 11 2019, 12:27 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

Can you please follow KDE Frameworks coding style

Oct 11 2019, 12:17 PM · Plasma
tcanabrava committed R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite (authored by tcanabrava).
WIP: Beginning of the Baloo/Search KCM Rewrite
Oct 11 2019, 12:11 PM
tcanabrava closed T7271: File Search as Resolved by committing R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite.
Oct 11 2019, 12:11 PM · Plasma: KCM Redesign
tcanabrava closed D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
Oct 11 2019, 12:11 PM · Plasma

Oct 9 2019

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix Strings
  • Fix margins
Oct 9 2019, 6:12 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate.

Oct 9 2019, 5:15 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Use Plasma KCM
  • Adapt to FormLayout
  • Fix label
  • Space every tab equally
  • Form layout port
  • FormLayout
  • Simplify Qml
  • Port to Form Layout
Oct 9 2019, 5:14 PM · Plasma
tcanabrava added a comment to D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.

I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not used.

Oct 9 2019, 4:31 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • fix Comment
Oct 9 2019, 4:30 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Simplify Checkboxes
  • Fix previouslyEnabled logic
  • Tell Qml that we have the values
  • Move code around
  • Fix QSet math
  • Qml gives us a Url, we want the Local file
  • use folderAdded and folderRemoved
  • Remove debug information
  • Add spacing
Oct 9 2019, 4:29 PM · Plasma
tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button
  • Fix borders and background for the Baloo KCM
  • Use kirigami BasicListItem
  • Spacing
  • Fix mapping of roles
  • Fix delegate / Mouse integration
Oct 9 2019, 2:57 PM · Plasma

Oct 3 2019

tcanabrava updated the diff for D24374: WIP: Initial port of the Date and Time KCM.

wq - Restore colors metatada, and correctly set the datetime metadata

  • s/kcmclock/kcm_clock
  • Fix author
  • kcm_name break kauth, it needs kcmname =/
  • Fix missing property, Add a Qml Clock (from the Qt Demos)
  • Add a Time Zone list.
  • Fix many layout mistakes
Oct 3 2019, 7:00 PM · Plasma

Oct 2 2019

tcanabrava updated the diff for D24374: WIP: Initial port of the Date and Time KCM.
  • Fix KAuth usage
Oct 2 2019, 8:40 PM · Plasma
tcanabrava requested review of D24374: WIP: Initial port of the Date and Time KCM.
Oct 2 2019, 8:19 PM · Plasma

Sep 26 2019

tcanabrava abandoned D24187: Start of the accessibility KCM.

closing this as arc diff opened two reviews with the same content =/

Sep 26 2019, 2:57 PM · Plasma
tcanabrava added a comment to D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.

got it, updating.

Sep 26 2019, 2:53 PM · Plasma
tcanabrava added a comment to D24224: Start of the accessibility KCM.

Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) The top groupbox of Activation Gestures items could be moved to their respective groupboxes also so there are less groupboxes on the Keyboard tab than before on these 3 tabs.

Sep 26 2019, 2:52 PM · Plasma

Sep 25 2019

tcanabrava updated the summary of D24187: Start of the accessibility KCM.
Sep 25 2019, 3:33 PM · Plasma
tcanabrava updated the diff for D24224: Start of the accessibility KCM.
  • Make buttons work
Sep 25 2019, 3:13 PM · Plasma
tcanabrava requested review of D24224: Start of the accessibility KCM.
Sep 25 2019, 2:43 PM · Plasma
tcanabrava added a comment to T11774: Port Accessibility KCM to Qml.

https://phabricator.kde.org/D24187 has a wip, it currently is a 1 to 1 translation of the Widgets one, we need a better layout for it.

Sep 25 2019, 1:50 PM · Plasma: KCM Redesign
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Remove the ui file
  • Rename kcm_access to kcmaccess
  • Fix typos
  • Qml Loads. Now, fix beaury
  • Fix imports and labels
  • Fix most layouts
  • Fix layout for the mouse navigation
  • Initial Working Gestures
  • Add boilerplate
  • Fixes on bell
  • Fix functionality
Sep 25 2019, 1:50 PM · Plasma
tcanabrava created T11774: Port Accessibility KCM to Qml.
Sep 25 2019, 1:49 PM · Plasma: KCM Redesign

Sep 24 2019

ognarb awarded D24187: Start of the accessibility KCM a Love token.
Sep 24 2019, 8:59 PM · Plasma
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Initial Working Gestures
Sep 24 2019, 5:47 PM · Plasma
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Rename kcm_access to kcmaccess
  • Fix typos
  • Qml Loads. Now, fix beaury
  • Fix imports and labels
  • Fix most layouts
  • Fix layout for the mouse navigation
Sep 24 2019, 5:36 PM · Plasma
tcanabrava updated the diff for D24187: Start of the accessibility KCM.
  • Remove the ui file
Sep 24 2019, 2:14 PM · Plasma
tcanabrava requested review of D24187: Start of the accessibility KCM.
Sep 24 2019, 1:08 PM · Plasma

Sep 23 2019

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button
  • Fix borders and background for the Baloo KCM
Sep 23 2019, 7:45 AM · Plasma

Sep 16 2019

tcanabrava updated the diff for D23718: WIP: Beginning of the Baloo/Search KCM Rewrite.
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button
Sep 16 2019, 7:14 PM · Plasma
tcanabrava committed R120:b159222aa558: Take in consideration flat() for the All Applications menu (authored by tcanabrava).
Take in consideration flat() for the All Applications menu
Sep 16 2019, 12:17 PM
tcanabrava closed D22762: Take in consideration flat() for the All Applications menu.
Sep 16 2019, 12:17 PM · Plasma

Sep 11 2019

tcanabrava committed R319:050e06d220e9: Fix Drag Drop from splits in Wayland (authored by tcanabrava).
Fix Drag Drop from splits in Wayland
Sep 11 2019, 1:34 PM

Sep 10 2019

tcanabrava added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

I needed a new accelerator for focus split right left top bottom, I talked
to David this weekend and we agreed to restore the old accelerator for move
tab.

Sep 10 2019, 7:17 AM · Konsole

Sep 7 2019

tcanabrava committed R73:167649d36604: Don't query for the document twice (authored by tcanabrava).
Don't query for the document twice
Sep 7 2019, 2:10 PM
tcanabrava committed R73:f1fca7c854b0: documenttypeswidget: simplify code (authored by tcanabrava).
documenttypeswidget: simplify code
Sep 7 2019, 2:10 PM
tcanabrava committed R73:d67b0b6b03b8: edgetypesdelegate: fix mem leak (authored by tcanabrava).
edgetypesdelegate: fix mem leak
Sep 7 2019, 1:59 PM
tcanabrava committed R73:ca563d222656: edgetypesdelegate: simplify logic (authored by tcanabrava).
edgetypesdelegate: simplify logic
Sep 7 2019, 1:59 PM
tcanabrava committed R73:19dc1fd4d5ed: edgetypesdelegate: dont append on temporary (authored by tcanabrava).
edgetypesdelegate: dont append on temporary
Sep 7 2019, 1:59 PM
tcanabrava committed R73:3e18456fa62d: Use QScopedPointer to guard against memleaks (authored by tcanabrava).
Use QScopedPointer to guard against memleaks
Sep 7 2019, 1:54 PM
tcanabrava committed R73:89ecb4e72b49: fileformatdialog: Fix memory leak of the FileDialog (authored by tcanabrava).
fileformatdialog: Fix memory leak of the FileDialog
Sep 7 2019, 1:54 PM
tcanabrava committed R73:8a44b096001a: nodetypesdelegate: fix memory leak (authored by tcanabrava).
nodetypesdelegate: fix memory leak
Sep 7 2019, 1:36 PM
tcanabrava committed R73:d5093f7d857f: nodetypesdelegate: dont append on temporary (authored by tcanabrava).
nodetypesdelegate: dont append on temporary
Sep 7 2019, 1:36 PM
tcanabrava committed R73:86c55aab45ed: scriptoutputwidget: simplify updateFixupButton logic (authored by tcanabrava).
scriptoutputwidget: simplify updateFixupButton logic
Sep 7 2019, 1:36 PM
tcanabrava committed R73:773589d6692b: sidedockwidget: simplify sizehint (authored by tcanabrava).
sidedockwidget: simplify sizehint
Sep 7 2019, 1:28 PM
tcanabrava committed R73:97b2d5c65159: mainwindow: no else after return (authored by tcanabrava).
mainwindow: no else after return
Sep 7 2019, 1:23 PM
tcanabrava committed R73:c44c4ae2baf1: sidedockwidget: get rid of depreccated method (authored by tcanabrava).
sidedockwidget: get rid of depreccated method
Sep 7 2019, 1:23 PM
tcanabrava committed R73:fd845181c5f5: mainwindow: spacing (authored by tcanabrava).
mainwindow: spacing
Sep 7 2019, 1:23 PM
tcanabrava committed R73:ece487f0545a: mainwindow: de-escalate if (authored by tcanabrava).
mainwindow: de-escalate if
Sep 7 2019, 1:23 PM
tcanabrava committed R73:3e8ca8cee330: mainwindow: spacing (authored by tcanabrava).
mainwindow: spacing
Sep 7 2019, 1:23 PM
tcanabrava committed R73:056cd3444676: mainwidow, sidedockwidget: simplify layout and logic (authored by tcanabrava).
mainwidow, sidedockwidget: simplify layout and logic
Sep 7 2019, 1:23 PM