On Linux appstream URLs don't work for me on Firefox Kubuntu 19.04. Should we really be using them if they're broken?

I won't review, but would like to note I think that with KIOFuse, in conjuction with fio we can do some really complex testing on KIO, correct me if I'm wrong.

@davidedmundson would be happy to work on this. Do you have the URL to the proposal on the mailing list?

There is a BoF on this!

Assuming it's tested LGTM.

In D23672#524727, @elvisangelaccio wrote:

Go for it ;)

Simplifying getIndexByUrl function

@ngraham I believe if you rebase on D23672 then the FIXME is solved. I also believe that dolphinInstanceData() should have an empty QString() in your case. I've tested your patch with an empty QString() and it worked, it might not work with what you currently have...

• Revert "Fixing bugs in new folders in tabs feature"

@ngraham I believe the diff in src/main.cpp may help with the speed issues in D11382. Haven't checked though...

In D23207#520233, @sitter wrote:

Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,.

• Removing flush on write

• Fixing typos
• Adding test for reading of 0 bytes and asserting that the close signal is

actually emitted.

In D23445#518992, @ngraham wrote:

Will do.

I thought all GSoC students needed to have commit access though? Please apply. https://community.kde.org/Infrastructure/Get_a_Developer_Account

In D23445#518985, @ngraham wrote:

Thanks for the quick fix. Stable branch please!

In D21691#518929, @ngraham wrote:

Go ahead, I'm sure you can fix it in no time.

In D22708#516132, @ngraham wrote:

In D22708#516131, @feverfew wrote:

In D22708#516128, @ngraham wrote:

Also feel free to pop by #kde-fm for discussions or if you want to ask a question.

It kicks me out for not having a registered nickname even though I totally do and am using it. If it's not necessary anymore, it might be nice to remove that restriction.

In D22708#516128, @ngraham wrote:

Oh good. :) Is there anywhere I can follow the progress?

In D22708#507449, @ngraham wrote:

What?

Making comments clearer

In D11382#513245, @ngraham wrote:

This is ready for re-review, with one specific thing I could use help debugging: when you enable the new option, launching Dolphin and opening new windows becomes interminably slow, probably due to some extra DBus overhead that's still a bit beyond my comprehension. See the FIXME in the code.

Unnecessary min version upgraded

Addressing comments

Can't test, but looks sane to me. I have a small comment, but can be left for later if time is of the essence.

Also would like to see a push for advertising KDE Apps on Windows and Mac OS, where possible. This will bring us a wider audience, and can even help switch people to Linux.

I also believe T11093 can tie very well with this and T11080. If we brainstorm properly we can standardise certain widgets such that many goals are met at once, with a decreased maintenance burden for everyone involved.

Note that this goal is necessary for T11080 to succeed. It's quite common in a lot of companies/governments that they make suitable provisions for those with disabilities, where possible.

In D21736#484989, @ngraham wrote:

Thanks, the issue is fixed now. I could not find any other behavioral regressions, and I've verified that the new feature behaves correctly. The code looks good to me too!

Next, do you think you could work on https://bugs.kde.org/show_bug.cgi?id=408919?

Rebasing onto master

• Simplifying option
• Fixing regression

In D21736#484695, @ngraham wrote:

In D21736#484694, @feverfew wrote:

In D21736#484693, @ngraham wrote:

Nope, same behavior after a rebase on current master.

Be careful when you say nope/yes ;) was very confused if you meant rebasing it solved it or not.

Oh gosh, I'm sorry. I'm too tired for this right now and need to go to bed.

So for example if you open a jpg, and ask to open in containing folder it'll reopen in gwenview and also be selected in Dolphin?

Almost. Here's a video that shows the issue (with apologies to @broulik):

• Fixing regression

In D21736#484693, @ngraham wrote:

Nope, same behavior after a rebase on current master.

In D21736#484271, @ngraham wrote:

Ran into an interesting bug with this. With the feature turned off, using the "Open Containing Folder" feature in many KDE apps causes a new Dolphin window to open with the path of the file itself, not its containing folder. As a result, the file gets opened a second time.

With the feature turned on, everything works properly and the file's containing folder is opened in a new tab in the running Dolphin instance

@elvisangelaccio note I can't actually commit this as I don't have commit access.

• Simplifying option

• Making comment clearer

In D21736#478953, @ngraham wrote:

Thanks! Will review once the feature in and of itself works reliably enough for me to test it in various use cases; first I'd like to see https://bugs.kde.org/show_bug.cgi?id=408244 and https://bugs.kde.org/show_bug.cgi?id=408387 fixed.

Fix identation

• Removing trailing whitespace

• Removing trailing whitespace

In D16648#471347, @elvisangelaccio wrote:

Tested also on gnome, window activation works fine also there.

@feverfew Do you have commit access?

• Implementing code review suggestion

• Adding fallback to always opening new window if running in Wayland session

• Coding style change

• Simplifying conditional

• Styling fixes

• Addressing code review comments
• Adding back macro
• Allow window activation without forceActiveWindow()
• Avoiding duplication of tabs
• Distributing URLs among all instances
• Making ShowFolders/ShowItems also check if URLs are open in other tabs
• Ensuring current instance is considered when needed
• Removing unnecessary include
• Overloading openFiles/openDirectories
• Removing unnecessary new line
• Amend test
• Fixing header file

In D16648#468028, @fvogt wrote:

In D16648#467893, @feverfew wrote:

In D16648#467854, @fvogt wrote:

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.

Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.

In D16648#467854, @fvogt wrote:

It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.

• Removing unnecessary include

• Allow window activation without forceActiveWindow()
• Avoiding duplication of tabs
• Distributing URLs among all instances
• Making ShowFolders/ShowItems also check if URLs are open in other tabs
• Ensuring current instance is considered when needed

In D16648#450590, @davidedmundson wrote:

activateWindow works if and only if your X startup info is correct.

When you launch dolphin through a UI (on gnome or Plasma) you will see an extra environment variable on your dolphin process.

DESKTOP_STARTUP_ID=David-Desktop;1555336591;362121;16299_TIME219914845

Qt normally handles this internally.

If you then call into an existing dolphin you need to pass this and import it the other side before calling window->activate().
See KStartupInfo or QX11Extras::setAppTime

Plasma isn't really involved.

In D16648#449696, @elvisangelaccio wrote:

This made me think: what about non-plasma systems?
e.g. GNOME doesn't even have a taskbar, what's gonna happen there?

• Adding back macro

• Addressing code review comments

In T10263#180285, @fvogt wrote:

In T10263#180221, @feverfew wrote:

In T10263#178973, @fvogt wrote:

@feverfew Sure! I don't know much about GSoC though, I hope that's not an issue.

@fvogt Great, I can tell you more about it on a platform of your choice. What's your preferred method of contact (.e.g email) so we can get a project submitted (deadline is 9th April)?

E-Mail is fine - you can use the one here on phab.