feverfew (Alexander Saoutkin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 17 2018, 6:08 PM (97 w, 5 d)
Availability
Available

Recent Activity

Sat, Jun 6

feverfew added a comment to D7563: Add privilegeExecution field to file protocol description.

This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs when certain timers happen to trigger. A trivial way to reproduce this is to try and duplicate a file in file:/

Interesting... Yes if so that's a serious blocker.

Also making folders is actually not even implemented as the relevant mkdirjob seems to lack privilege enablement. That's not strictly speaking blocking but renders the actual UX broken.

I can confirm that I noticed this too. I also noticed that sometimes the dialog wouldn't show at all because the slave kept state that said that permission was denied (and hence it believed showing the dialog was redundant) when in fact my permission was never asked. Although this only happened for mkdir for me IIRC. So the slave might be mishandling state. At the same time, I'm not sure if the slave is in a position to handle such state (they're short-lived?).

Sat, Jun 6, 3:34 PM · Frameworks
feverfew added a comment to T12101: Replace KWallet with KSecretsService (provide org.freedesktop.secrets).

Alternative solution: we port apps to libqt5keychain, which itself supports KWallet, gnome-keyring and libsecret (which I assume uses "secrets service").
See task T12219

Sat, Jun 6, 3:25 PM · KF6

May 14 2020

feverfew accepted D29743: sftp: map sftp_open error to kio error.
May 14 2020, 2:11 PM · Frameworks, Dolphin

May 13 2020

feverfew added a comment to D29634: sftp: break large writes into multiple requests.

Nice work.

I imagine something similar should be done for FileJob::write?

Yeah.

I guess you meant FileProtocol::write.
There is no need there, it uses QIODevice::write directly.

May 13 2020, 7:15 PM · Frameworks, Dolphin
feverfew added a comment to D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache.

Hmmmm, this looks like a poor man's priority queue, would std::priority_queue not be appropriate here? (I'm not blocking here, idm tbh but it just seems more natural here to me). Also means that you don't have to explicitly enforce it all the time the queues are used, the priority is decided only in one place.

May 13 2020, 2:50 PM · Dolphin
feverfew accepted D29634: sftp: break large writes into multiple requests.

I imagine something similar should be done for FileJob::write?

May 13 2020, 2:46 PM · Frameworks, Dolphin

May 12 2020

feverfew added inline comments to D29634: sftp: break large writes into multiple requests.
May 12 2020, 10:44 AM · Frameworks, Dolphin

May 11 2020

feverfew updated the task description for T13142: Akademy 2020: Outreach to Academic Institutions.
May 11 2020, 7:05 PM · KDE Promo, Akademy
feverfew added a comment to D29634: sftp: break large writes into multiple requests.

Seems like something similar should also occur in FileJob::write?

May 11 2020, 4:18 PM · Frameworks, Dolphin

May 3 2020

feverfew added a comment to D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun.

Quick question, how does this affect D23384? Previously KRun used KIO::DesktopExecParser::resultingArguments() which handled the conversion of URLs to local KIOFuse URLs if needed, but now I believe this new API doesn't?

No worries, this should still happen.
KRun is actually split into three classes: OpenUrlJob, CommandLauncherJob and ApplicationLauncherJob. The last two delegate the work to an internal class, KProcessRunner (like KRun did).
So (to roll out the common case of a document-type file), once OpenUrlJob finds out which application to start, it calls ApplicationLauncherJob, which creates a KProcessRunner, which uses KIO::DesktopExecParser::resultingArguments().

May 3 2020, 8:08 PM · Frameworks
feverfew added a comment to D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun.

Quick question, how does this affect D23384? Previously KRun used KIO::DesktopExecParser::resultingArguments() which handled the conversion of URLs to local KIOFuse URLs if needed, but now I believe this new API doesn't?

May 3 2020, 7:51 PM · Frameworks

Apr 26 2020

feverfew added inline comments to D29178: [dolphin] : Mac integration.
Apr 26 2020, 8:37 AM · Dolphin

Apr 25 2020

feverfew requested changes to D29178: [dolphin] : Mac integration.
Apr 25 2020, 10:49 PM · Dolphin

Apr 21 2020

feverfew accepted D11382: Add an option to show tabs from last time when Dolphin starts.
Apr 21 2020, 10:08 AM · Dolphin

Apr 20 2020

feverfew added a comment to D7563: Add privilegeExecution field to file protocol description.

[insert I-have-no-idea-what-I'm-doing dog meme here]

When trying to create items in root-owned locations, I'm getting an errors saying "The process for the file protocol died unexpectedly." or else Dolphin simply crashes with a totally unhelpful backtrace.

If it's still happening, please have a look at https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves

Apr 20 2020, 10:50 PM · Frameworks

Apr 13 2020

feverfew committed R320:94e7b64325f9: [KIO-MTP] Fix null pointer dereference (authored by feverfew).
[KIO-MTP] Fix null pointer dereference
Apr 13 2020, 12:08 PM
feverfew closed D28535: [KIO-MTP] Fix null pointer dereference.
Apr 13 2020, 12:08 PM · Frameworks, Dolphin
feverfew added a reviewer for D28790: Add option to separate full path visibility for tab and window.: Dolphin.
Apr 13 2020, 11:29 AM · Dolphin

Apr 12 2020

feverfew added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

I assume there is a reason why MTPDevice::getDevice() has code for handling this very specific case, so I wouldn't just remove it without figuring out why: https://i.redd.it/hfnl7xo8yovy.gif

If not, that would indeed be the best option.

Unfortunately git blame doesn't seem to help us here.

I suggest to push this fix to master only and see what happens.

By pushing this to master would we still be able to throw it up to 20.04.* if we decide it's stable enough? (also need to know to know what to put down as the FIXED-IN in the commit message)?

Apr 12 2020, 6:04 PM · Frameworks, Dolphin

Apr 10 2020

feverfew added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Just an idea: can Baloo figure out this for us? This sounds like a feature that would fit at the baloo level, as it recurses through directories anyway and goes through their attributes.

Apr 10 2020, 11:35 AM · Dolphin

Apr 8 2020

feverfew requested changes to D11382: Add an option to show tabs from last time when Dolphin starts.

Apologies for the delay in reviewing this. I believe FIXED-IN will unfortunately have to change to 20.08. Also looking at the screenshot, the text and the buttons/input box are misaligned, is this resolvable in this patch, or is that a wider issue with settings? Also note in the commit message "thatfunctionality" -> "that functionality".

Apr 8 2020, 11:39 AM · Dolphin

Apr 7 2020

feverfew committed R320:f4e0183adfd8: Fix lifetime of slot in KIO-MTP (authored by feverfew).
Fix lifetime of slot in KIO-MTP
Apr 7 2020, 6:20 PM
feverfew closed D28520: Fix lifetime of slot in KIO-MTP.
Apr 7 2020, 6:20 PM · Frameworks, Dolphin
feverfew committed R318:5351db95c646: Sync terminal with KIOFuse mount when browing remote directories (authored by feverfew).
Sync terminal with KIOFuse mount when browing remote directories
Apr 7 2020, 5:27 PM
feverfew closed D28290: Sync terminal with KIOFuse mount when browing remote directories.
Apr 7 2020, 5:27 PM · Dolphin

Apr 5 2020

feverfew added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

I assume there is a reason why MTPDevice::getDevice() has code for handling this very specific case, so I wouldn't just remove it without figuring out why: https://i.redd.it/hfnl7xo8yovy.gif

If not, that would indeed be the best option.

Unfortunately git blame doesn't seem to help us here.

I suggest to push this fix to master only and see what happens.

Apr 5 2020, 4:48 PM · Frameworks, Dolphin

Apr 3 2020

feverfew added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

Ok so I've updated the code as can be seen. Mucked around with disconnecting/connecting, no issues on my side at least.

Apr 3 2020, 9:32 PM · Frameworks, Dolphin
feverfew updated the diff for D28535: [KIO-MTP] Fix null pointer dereference.
  • Don't try to release device in get method
Apr 3 2020, 9:29 PM · Frameworks, Dolphin
feverfew added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

So to be succinct, the only correct fix here is to change getDevice() to return m_mtpdevice?

Yes, then check if it's crash, in all other places LIBMTP_xxx should take care of and return false or nullptr depend of function returning value.

Apr 3 2020, 2:11 PM · Frameworks, Dolphin
feverfew added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

If you want to, feel free, I'm a bit tight on time. But I will say this. the whole getDevice() function confuses me. I'm not entirely sure why this if check is necessary at all. The lifetime of devices and its children (i.e storage) should be managed by the KMTPD daemon AFAICT. A device shouldn't be trying to re-open itself anywhere IMO. To me the getDevice() function should simply be a simple return to avoid this NULL issue happening. Even if a device doesn't exist anymore, no segfaults should happen when passing an "invalid" LIBMTP_mtpdevice_t to any other LIBMTP function?

Apr 3 2020, 1:16 PM · Frameworks, Dolphin
feverfew added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

What you're suggesting is to change MTPDevice::getDevice to return the old device if reopening fails - but reopening without releasing might not work.

Apr 3 2020, 12:36 PM · Frameworks, Dolphin
feverfew requested review of D28535: [KIO-MTP] Fix null pointer dereference.
Apr 3 2020, 11:09 AM · Frameworks, Dolphin
feverfew added a comment to D28520: Fix lifetime of slot in KIO-MTP.

@apol just found another one where this occurs, forgot about it but noticed it earlier as well. This doesn't affect KIOFuse as much though (as we don't listen to the processedSize() signal).

Apr 3 2020, 10:51 AM · Frameworks, Dolphin
feverfew updated the diff for D28520: Fix lifetime of slot in KIO-MTP.
  • Fix another slot lifetime
Apr 3 2020, 10:50 AM · Frameworks, Dolphin

Apr 2 2020

feverfew requested review of D28520: Fix lifetime of slot in KIO-MTP.
Apr 2 2020, 4:17 PM · Frameworks, Dolphin

Apr 1 2020

feverfew added a comment to T12214: Move IOSlaves into a thread of the calling application instead of separate process.

I'd like this, would make debugging a million times easier to. Probably faster as well...

Apr 1 2020, 5:06 PM · KF6

Mar 30 2020

feverfew added a comment to D28363: Don't incorrectly claim to support KIO::open.

@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?

Mar 30 2020, 5:20 PM · KIO GDrive
feverfew closed D28363: Don't incorrectly claim to support KIO::open.
Mar 30 2020, 5:17 PM · KIO GDrive
feverfew committed R219:aa6e987eed44: Don't incorrectly claim to support KIO::open (authored by feverfew).
Don't incorrectly claim to support KIO::open
Mar 30 2020, 5:17 PM
feverfew closed D28440: Mark KIOFuse mounts as Probably slow.
Mar 30 2020, 5:02 PM · Frameworks
feverfew committed R241:ec5adbccc23d: Mark KIOFuse mounts as Probably slow (authored by feverfew).
Mark KIOFuse mounts as Probably slow
Mar 30 2020, 5:02 PM
feverfew added reviewers for D28440: Mark KIOFuse mounts as Probably slow: Frameworks, dfaure, broulik, bruns.
Mar 30 2020, 2:54 PM · Frameworks
feverfew requested review of D28440: Mark KIOFuse mounts as Probably slow.
Mar 30 2020, 2:51 PM · Frameworks
feverfew updated the diff for D28290: Sync terminal with KIOFuse mount when browing remote directories.
  • Only do DBus call if mount is KIOFuse mount
  • make interface member of class
  • switch to camel case
Mar 30 2020, 12:42 PM · Dolphin

Mar 27 2020

feverfew added a project to D28363: Don't incorrectly claim to support KIO::open: KIO GDrive.
Mar 27 2020, 9:17 PM · KIO GDrive
feverfew requested review of D28363: Don't incorrectly claim to support KIO::open.
Mar 27 2020, 9:16 PM · KIO GDrive

Mar 25 2020

feverfew added a reviewer for D28290: Sync terminal with KIOFuse mount when browing remote directories: Dolphin.

Demo of feature:

Mar 25 2020, 8:32 PM · Dolphin
feverfew requested review of D28290: Sync terminal with KIOFuse mount when browing remote directories.
Mar 25 2020, 8:30 PM · Dolphin

Mar 19 2020

feverfew accepted D27999: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice.

Quick testing with fish protocol doesn't break anything KIOFuse side. Going to page in @ngraham, if it works for him with smb it's an all good from the "KIOFuse people" ;)

Mar 19 2020, 7:14 PM · Frameworks

Mar 13 2020

feverfew added a comment to D27999: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice.

don't merge yet, looking at the code I sense something might break here but I need some time to do my own testing first.

Mar 13 2020, 2:17 PM · Frameworks

Mar 12 2020

feverfew added a reviewer for D27999: [DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice: feverfew.

I'll review this when I have a chance (sometime this week).

Mar 12 2020, 12:12 PM · Frameworks

Mar 3 2020

feverfew added a comment to D27810: Correctly disable UDS_ACCESS being set.

I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1

Mar 3 2020, 8:26 PM · Frameworks, Dolphin
feverfew added a comment to T8449: Replacement of KDE Identity System.

I have extensive experience in Django, maybe in the summer I can help work in this direction.

Mar 3 2020, 2:52 PM · Websites, Sysadmin

Mar 1 2020

feverfew closed D21795: [KAuth] Add support for action details in Polkit1 backend..
Mar 1 2020, 5:58 PM · Frameworks
feverfew committed R283:f53d6a29a049: [KAuth] Add support for action details in Polkit1 backend. (authored by feverfew).
[KAuth] Add support for action details in Polkit1 backend.
Mar 1 2020, 5:58 PM
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Fix &
  • Use enum class
  • Use enum instead of string comparison
Mar 1 2020, 5:56 PM · Frameworks
feverfew committed R318:7a2885853a42: Merge branch 'release/19.12' (authored by feverfew).
Merge branch 'release/19.12'
Mar 1 2020, 5:23 PM
feverfew committed R318:af45eb0af521: Fix typo in comment (authored by feverfew).
Fix typo in comment
Mar 1 2020, 5:21 PM
feverfew committed R318:fef7eebc6e3c: Fix files not being highlighted if directory of file is already open (authored by feverfew).
Fix files not being highlighted if directory of file is already open
Mar 1 2020, 5:19 PM
feverfew closed D27389: Fix files not being highlighted if directory of file is already open.
Mar 1 2020, 5:19 PM · Dolphin

Feb 26 2020

feverfew added a comment to D21795: [KAuth] Add support for action details in Polkit1 backend..

I believe most of your (@sitter) comments (apart from the misaligned & probably were caused by me forgetting to rebase), lmk if otherwise.

Feb 26 2020, 9:59 PM · Frameworks
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Merge branch 'master' into arcpatch-D21795_1
  • Update version
Feb 26 2020, 9:42 PM · Frameworks
feverfew planned changes to D21795: [KAuth] Add support for action details in Polkit1 backend..

Ok, I see what's going on here. Earlier I mucked up the diff a bit and had to go back to different diff id and reapply my changes. In the process I forgot to rebase onto master. Once I do that David's copyright will be back in (and the event loop goes with it).

Feb 26 2020, 2:08 PM · Frameworks

Feb 25 2020

feverfew added a comment to D27643: FileChooser: download remote files to a cache location to open them through the portal.

With a brief look the ideal scenario is to be able to use DesktopExecParser::resultingArguments, or a class that calls it KRun. That should do the conversion. I'm just not sure if you have the information required to use it.

Feb 25 2020, 9:04 PM · Plasma
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Fix the diff
Feb 25 2020, 8:35 PM · Frameworks

Feb 24 2020

feverfew accepted D27153: port sftp to Result system to force serialization of error/finish condition.
Feb 24 2020, 11:22 PM · Frameworks, Dolphin

Feb 20 2020

feverfew added a comment to D21795: [KAuth] Add support for action details in Polkit1 backend..

Ok I've commandeered this on request, as we're so close to getting this done. I've simply addressed sitter's comments here seeming as they're simple enough to do so without understanding the code that well. I haven't actually tested this in any capacity, as again, I'm not too familiar with this code and what it's trying to accomplish. If someone could point me in the correct direction I'll test as well.

Feb 20 2020, 11:42 PM · Frameworks
ngraham awarded D21795: [KAuth] Add support for action details in Polkit1 backend. a Love token.
Feb 20 2020, 10:44 PM · Frameworks
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • add const &
Feb 20 2020, 10:43 PM · Frameworks
feverfew updated the diff for D21795: [KAuth] Add support for action details in Polkit1 backend..
  • Rebase
  • Respond to sitter's comments
Feb 20 2020, 10:33 PM · Frameworks
feverfew commandeered D21795: [KAuth] Add support for action details in Polkit1 backend..
Feb 20 2020, 10:32 PM · Frameworks

Feb 16 2020

feverfew updated the test plan for D27389: Fix files not being highlighted if directory of file is already open.
Feb 16 2020, 4:34 PM · Dolphin
feverfew updated the diff for D27389: Fix files not being highlighted if directory of file is already open.
  • Remote unnecessary newline
Feb 16 2020, 3:19 PM · Dolphin
feverfew updated the diff for D27389: Fix files not being highlighted if directory of file is already open.
  • Actually fix the bug
Feb 16 2020, 2:39 PM · Dolphin

Feb 14 2020

feverfew requested review of D27389: Fix files not being highlighted if directory of file is already open.
Feb 14 2020, 12:05 AM · Dolphin

Feb 13 2020

feverfew requested changes to D27153: port sftp to Result system to force serialization of error/finish condition.

Good stuff, I'll admit I kind of skimmed over the bits that were rewrites error(...); return; -> Result::fail(), I assume you've mapped correctly there. Only minor comments from me.

Feb 13 2020, 10:40 PM · Frameworks, Dolphin

Feb 10 2020

feverfew added a comment to D27291: install smb as both smb:// and cifs://.

feverfew: you're probably looking at master while this is a patch for the 19.12 branch.
See https://phabricator.kde.org/D26358 which happened in master.

I guess that makes this commit ok for 19.12, but it has to be redone differently in master.

Feb 10 2020, 10:32 PM · Frameworks, Dolphin
feverfew added a comment to D27291: install smb as both smb:// and cifs://.

I'm a bit confused here, isn't the protocol file now a JSON file? I'm looking at the repo and it appears to be the case, so I'm not seeing how this diff is seeing this as a rename?

Feb 10 2020, 10:19 PM · Frameworks, Dolphin

Jan 11 2020

feverfew committed R320:3bb841890e5a: Add support for FileJob->truncate() in smb/sftp slaves (authored by feverfew).
Add support for FileJob->truncate() in smb/sftp slaves
Jan 11 2020, 9:32 PM
feverfew closed D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Jan 11 2020, 9:32 PM · Frameworks, Dolphin
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.
  • Merge branch 'master' into arcpatch-D26191
  • adhere to protcol -> json switch
Jan 11 2020, 9:30 PM · Frameworks, Dolphin
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Cleanup code according to comments

Jan 11 2020, 9:24 PM · Frameworks, Dolphin

Jan 2 2020

feverfew committed R241:fcf4529f62e1: Adding support for mounting KIOFuse URLs for applications that don't use KIO (authored by feverfew).
Adding support for mounting KIOFuse URLs for applications that don't use KIO
Jan 2 2020, 6:29 PM
feverfew closed D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Jan 2 2020, 6:29 PM · Frameworks

Jan 1 2020

feverfew committed R241:578fbf45297b: Add truncation support to FileJob (authored by feverfew).
Add truncation support to FileJob
Jan 1 2020, 11:59 PM
feverfew closed D26148: Add truncation support to FileJob.
Jan 1 2020, 11:59 PM · Frameworks
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Fix introduction of BIC method

Jan 1 2020, 11:59 PM · Frameworks, Dolphin
feverfew added a comment to D26148: Add truncation support to FileJob.

Thanks @dfaure! Would you be able to also review D26191?

Yes, once it has been ported to virtual_hook as well.

Jan 1 2020, 11:07 PM · Frameworks
feverfew updated the diff for D26148: Add truncation support to FileJob.

Fix introduction of BIC method

Jan 1 2020, 2:59 PM · Frameworks

Dec 25 2019

feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Add fact that protocol supports truncation

Dec 25 2019, 10:49 PM · Frameworks, Dolphin
feverfew updated the summary of D26148: Add truncation support to FileJob.
Dec 25 2019, 10:47 PM · Frameworks
feverfew updated the diff for D26148: Add truncation support to FileJob.

Add feature to determine if protocol supports truncation

Dec 25 2019, 10:46 PM · Frameworks

Dec 24 2019

feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Avoid code duplication

Dec 24 2019, 6:52 PM · Frameworks, Dolphin
feverfew updated the diff for D26191: Add support for FileJob->truncate() in smb/sftp slaves.

Avoid free(NULL)

Dec 24 2019, 6:47 PM · Frameworks, Dolphin

Dec 23 2019

feverfew added inline comments to D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Dec 23 2019, 7:12 PM · Frameworks, Dolphin
feverfew added a comment to D26148: Add truncation support to FileJob.
In D26148#582365, @apol wrote:

It would be interesting to explain why it's important or how it's to be used in the commit message.

Dec 23 2019, 7:05 PM · Frameworks
feverfew updated the summary of D26148: Add truncation support to FileJob.
Dec 23 2019, 7:04 PM · Frameworks
feverfew updated the summary of D26148: Add truncation support to FileJob.
Dec 23 2019, 7:03 PM · Frameworks
feverfew added a dependency for D26191: Add support for FileJob->truncate() in smb/sftp slaves: D26148: Add truncation support to FileJob.
Dec 23 2019, 5:42 PM · Frameworks, Dolphin
feverfew added a dependent revision for D26148: Add truncation support to FileJob: D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Dec 23 2019, 5:42 PM · Frameworks