- User Since
- Aug 17 2018, 6:08 PM (97 w, 5 d)
Sat, Jun 6
Interesting... Yes if so that's a serious blocker.
Also making folders is actually not even implemented as the relevant mkdirjob seems to lack privilege enablement. That's not strictly speaking blocking but renders the actual UX broken.
I can confirm that I noticed this too. I also noticed that sometimes the dialog wouldn't show at all because the slave kept state that said that permission was denied (and hence it believed showing the dialog was redundant) when in fact my permission was never asked. Although this only happened for mkdir for me IIRC. So the slave might be mishandling state. At the same time, I'm not sure if the slave is in a position to handle such state (they're short-lived?).
May 14 2020
May 13 2020
Hmmmm, this looks like a poor man's priority queue, would std::priority_queue not be appropriate here? (I'm not blocking here, idm tbh but it just seems more natural here to me). Also means that you don't have to explicitly enforce it all the time the queues are used, the priority is decided only in one place.
I imagine something similar should be done for FileJob::write?
May 12 2020
May 11 2020
Seems like something similar should also occur in FileJob::write?
May 3 2020
Quick question, how does this affect D23384? Previously KRun used KIO::DesktopExecParser::resultingArguments() which handled the conversion of URLs to local KIOFuse URLs if needed, but now I believe this new API doesn't?
Apr 26 2020
Apr 25 2020
Apr 21 2020
Apr 20 2020
Apr 13 2020
Apr 12 2020
Apr 10 2020
Just an idea: can Baloo figure out this for us? This sounds like a feature that would fit at the baloo level, as it recurses through directories anyway and goes through their attributes.
Apr 8 2020
Apologies for the delay in reviewing this. I believe FIXED-IN will unfortunately have to change to 20.08. Also looking at the screenshot, the text and the buttons/input box are misaligned, is this resolvable in this patch, or is that a wider issue with settings? Also note in the commit message "thatfunctionality" -> "that functionality".
Apr 7 2020
Apr 5 2020
Apr 3 2020
Ok so I've updated the code as can be seen. Mucked around with disconnecting/connecting, no issues on my side at least.
- Don't try to release device in get method
If you want to, feel free, I'm a bit tight on time. But I will say this. the whole getDevice() function confuses me. I'm not entirely sure why this if check is necessary at all. The lifetime of devices and its children (i.e storage) should be managed by the KMTPD daemon AFAICT. A device shouldn't be trying to re-open itself anywhere IMO. To me the getDevice() function should simply be a simple return to avoid this NULL issue happening. Even if a device doesn't exist anymore, no segfaults should happen when passing an "invalid" LIBMTP_mtpdevice_t to any other LIBMTP function?
@apol just found another one where this occurs, forgot about it but noticed it earlier as well. This doesn't affect KIOFuse as much though (as we don't listen to the processedSize() signal).
- Fix another slot lifetime
Apr 2 2020
Apr 1 2020
I'd like this, would make debugging a million times easier to. Probably faster as well...
Mar 30 2020
@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?
- Only do DBus call if mount is KIOFuse mount
- make interface member of class
- switch to camel case
Mar 27 2020
Mar 25 2020
Demo of feature:
Mar 19 2020
Quick testing with fish protocol doesn't break anything KIOFuse side. Going to page in @ngraham, if it works for him with smb it's an all good from the "KIOFuse people" ;)
Mar 13 2020
don't merge yet, looking at the code I sense something might break here but I need some time to do my own testing first.
Mar 12 2020
I'll review this when I have a chance (sometime this week).
Mar 3 2020
I have extensive experience in Django, maybe in the summer I can help work in this direction.
Mar 1 2020
- Fix &
- Use enum class
- Use enum instead of string comparison
Feb 26 2020
I believe most of your (@sitter) comments (apart from the misaligned & probably were caused by me forgetting to rebase), lmk if otherwise.
- Merge branch 'master' into arcpatch-D21795_1
- Update version
Ok, I see what's going on here. Earlier I mucked up the diff a bit and had to go back to different diff id and reapply my changes. In the process I forgot to rebase onto master. Once I do that David's copyright will be back in (and the event loop goes with it).
Feb 25 2020
With a brief look the ideal scenario is to be able to use DesktopExecParser::resultingArguments, or a class that calls it KRun. That should do the conversion. I'm just not sure if you have the information required to use it.
- Fix the diff
Feb 24 2020
Feb 20 2020
Ok I've commandeered this on request, as we're so close to getting this done. I've simply addressed sitter's comments here seeming as they're simple enough to do so without understanding the code that well. I haven't actually tested this in any capacity, as again, I'm not too familiar with this code and what it's trying to accomplish. If someone could point me in the correct direction I'll test as well.
- add const &
- Respond to sitter's comments
Feb 16 2020
- Remote unnecessary newline
- Actually fix the bug
Feb 14 2020
Feb 13 2020
Good stuff, I'll admit I kind of skimmed over the bits that were rewrites error(...); return; -> Result::fail(), I assume you've mapped correctly there. Only minor comments from me.
Feb 10 2020
I'm a bit confused here, isn't the protocol file now a JSON file? I'm looking at the repo and it appears to be the case, so I'm not seeing how this diff is seeing this as a rename?
Jan 11 2020
- Merge branch 'master' into arcpatch-D26191
- adhere to protcol -> json switch
Cleanup code according to comments
Jan 2 2020
Jan 1 2020
Fix introduction of BIC method
Fix introduction of BIC method
Dec 25 2019
Add fact that protocol supports truncation
Add feature to determine if protocol supports truncation
Dec 24 2019
Avoid code duplication