Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here.
Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it.
Christophe is correct here, it is worth warning developers about these issues regardless of the platform, so they can get the code ready for those platforms and test everything in their local environment as much as possible.
I know for certain that there are developers who rely on our CI system and the Binary Factory to test and validate their applications (because they themselves do not have access to a development environment on those platforms).
I think we are misunderstanding eachother here.
If I'm developing the software and running cmake all the time, having a
warning that I can't fix (because it depends in another platform) is noise,
but still being a developer I don't want to run with -Wno-dev.
I do work in applications that targets more than one system (and they are
mac / windows / ios / android) I tend to use buildhosts, and those
buildhosts will tell me the warning - if any. But only if I'm targeting
That’s not a developer issue, it’s a packaging issue.
You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform
But why would I get the warning if I build on Linux? The warning should
target the platform, not the entire build system.
I object. This warning is for developers. It tells them the icons are missing for some platforms.
Sat, Jan 18
Fri, Jan 10
Sat, Jan 4
Ping? Any update if somebody tried the proposed changes?
Fri, Jan 3
Mon, Dec 30
Corrected logic, so it is is in line with GNUInstallDirs. Explained in comment. Added tests.
Sun, Dec 29
@heikobecker are you still interested in this patch? I can take over otherwise.
Sat, Dec 28
(Just remember that using KDE_INSTALL_KNSRCDIR though needs at least KNewStuffCore from KF 5.57 (hint was missing in API dox, proposing D26248 to fix that).)
Not saying that this patch is wrong, would have to look into it more closely.
Fri, Dec 27
Sat, Dec 21
Dec 19 2019
This has been missing the link from an rst file in docs/, so the documentation generation picks up the file. Fixed with c4890d5c03ed79f0c87da861b6608bbd46c2162c
Dec 18 2019
Dec 15 2019
Dec 14 2019
Dec 13 2019
Dec 9 2019
I tried to address the most recent comments: