Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Yesterday

dfaure accepted D8979: ecm_add_test: Use proper path sep on Windows.

Ah, oops, indeed.

Thu, Nov 23, 11:26 PM · Build System, Frameworks
kfunk added a reviewer for D8979: ecm_add_test: Use proper path sep on Windows: bcooksley.
Thu, Nov 23, 11:09 PM · Build System, Frameworks
kfunk updated subscribers of D8979: ecm_add_test: Use proper path sep on Windows.
Thu, Nov 23, 11:08 PM · Build System, Frameworks
kfunk added a reviewer for D8979: ecm_add_test: Use proper path sep on Windows: cgiboudeaux.
Thu, Nov 23, 11:07 PM · Build System, Frameworks
kfunk created D8979: ecm_add_test: Use proper path sep on Windows.
Thu, Nov 23, 11:07 PM · Build System, Frameworks

Mon, Nov 20

aacid added a comment to D8173: Use readelf to find project dependencies.

still not working in my setup
the setenv seems to not be working
and complains with

  • could not find 0x00000001 (NEEDED) Shared library: [libKF5ConfigCore.so] in /home/tsdgeos/devel/kde/ktuberling/export//lib or /home/tsdgeos/devel/kde/ktuberling/build_android

which is true, the library is not in any of those two paths

Mon, Nov 20, 10:40 PM · Build System, Frameworks

Fri, Nov 17

apol updated the diff for D8173: Use readelf to find project dependencies.

Added "" around a variable that may contain ;

Fri, Nov 17, 12:51 AM · Build System, Frameworks
apol updated the diff for D8173: Use readelf to find project dependencies.

Pass LANG=C to readelf so it doesn't appear in catalan (or anything other than C) and pass ECM_ADDITIONAL_FIND_ROOT_PATH to look for dependencies

Fri, Nov 17, 12:27 AM · Build System, Frameworks

Wed, Nov 15

apol added a comment to D8173: Use readelf to find project dependencies.
In D8173#167835, @aacid wrote:
In D8173#167776, @apol wrote:

I either need more information

I'm happy to provide any information you want, i just don't know what you need other than KConfigCore.so is in the apk without your patch and not with your patch.

Wed, Nov 15, 12:03 AM · Build System, Frameworks

Tue, Nov 14

aacid added a comment to D8173: Use readelf to find project dependencies.
In D8173#167776, @apol wrote:

I either need more information

Tue, Nov 14, 11:19 PM · Build System, Frameworks
apol added a comment to D8173: Use readelf to find project dependencies.

I've done a build of with and without and I don't see such differences:

Tue, Nov 14, 5:19 PM · Build System, Frameworks
turbov added a comment to D8780: Try `llvm-config` to find `libclang`.

Yep, this review is the first in series about to clean up the code of FindPythongModuleGeneration and make it generic (not only for Ubuntu) and flexible.
It is why I want to clean up it from "hard-coded" values like 3.8/3.9 and "brute force" of any versions...

Tue, Nov 14, 11:59 AM · Build System, Frameworks
shaheed added inline comments to D8780: Try `llvm-config` to find `libclang`.
Tue, Nov 14, 9:29 AM · Build System, Frameworks
shaheed added inline comments to D8780: Try `llvm-config` to find `libclang`.
Tue, Nov 14, 9:26 AM · Build System, Frameworks
cgiboudeaux added inline comments to D8780: Try `llvm-config` to find `libclang`.
Tue, Nov 14, 8:42 AM · Build System, Frameworks
cgiboudeaux added inline comments to D8780: Try `llvm-config` to find `libclang`.
Tue, Nov 14, 8:26 AM · Build System, Frameworks
cgiboudeaux closed D8777: restore old behaviour of FindPulseAudio.
Tue, Nov 14, 7:58 AM · Build System, Frameworks
turbov added inline comments to D8780: Try `llvm-config` to find `libclang`.
Tue, Nov 14, 12:22 AM · Build System, Frameworks

Mon, Nov 13

jhirte updated the diff for D8777: restore old behaviour of FindPulseAudio.

v3 should address all comments

Mon, Nov 13, 11:37 PM · Build System, Frameworks
cgiboudeaux closed D8790: Add FindSasl2.cmake to ECM.
Mon, Nov 13, 5:04 PM · KDE PIM, Build System, Frameworks
vkrause accepted D8790: Add FindSasl2.cmake to ECM.
Mon, Nov 13, 5:00 PM · KDE PIM, Build System, Frameworks
cgiboudeaux added a project to D8790: Add FindSasl2.cmake to ECM: KDE PIM.
Mon, Nov 13, 2:45 PM · KDE PIM, Build System, Frameworks
cgiboudeaux created D8790: Add FindSasl2.cmake to ECM.
Mon, Nov 13, 2:23 PM · KDE PIM, Build System, Frameworks
cgiboudeaux added inline comments to D8780: Try `llvm-config` to find `libclang`.
Mon, Nov 13, 9:41 AM · Build System, Frameworks
shaheed added a comment to D8780: Try `llvm-config` to find `libclang`.

I'm afraid your's truly might take a bit of the blame. The basis of the logic was likely my original Python code, which did just enough to make Ubuntu work.

Mon, Nov 13, 6:23 AM · Build System, Frameworks
turbov created D8780: Try `llvm-config` to find `libclang`.
Mon, Nov 13, 12:49 AM · Build System, Frameworks

Sun, Nov 12

cgiboudeaux accepted D8777: restore old behaviour of FindPulseAudio.

Please commit after fixing the last issue.

Sun, Nov 12, 9:48 PM · Build System, Frameworks
jhirte updated the diff for D8777: restore old behaviour of FindPulseAudio.

v2 of the patch with comments from Christophe Giboudeaux considered

Sun, Nov 12, 9:32 PM · Build System, Frameworks
cgiboudeaux added a comment to D8777: restore old behaviour of FindPulseAudio.

you also need set(PULSEAUDIO_FOUND "${PulseAudio_FOUND}"). You then have to move the compat variables below "find_package_handle_standard_args".

Sun, Nov 12, 9:08 PM · Build System, Frameworks
jhirte created D8777: restore old behaviour of FindPulseAudio.
Sun, Nov 12, 8:59 PM · Build System, Frameworks
aacid added a comment to D8173: Use readelf to find project dependencies.

I'm still not getting libkconfigcore.so into the apk with this

Sun, Nov 12, 6:43 PM · Build System, Frameworks

Tue, Nov 7

cgiboudeaux added inline comments to D8281: Allow to use IcoTool for Windows icons.
Tue, Nov 7, 12:42 PM · Build System, Frameworks
apol added a reviewer for D8281: Allow to use IcoTool for Windows icons: Windows.
Tue, Nov 7, 11:59 AM · Build System, Frameworks
mart added a comment to D8173: Use readelf to find project dependencies.

+1

Tue, Nov 7, 9:26 AM · Build System, Frameworks
apol added a comment to D8058: don't redefine output dirs on android.

https://phabricator.kde.org/D8173

Tue, Nov 7, 1:00 AM · Build System, Frameworks

Mon, Nov 6

cgiboudeaux added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.
In D7823#164879, @cfeck wrote:

Are the copies in the attic directory still needed for compatibility reasons, or can they get removed?

No needed by anything within Frameworks, Plasma or Applications as far as I'm aware. Shall I remove them?

Mon, Nov 6, 1:00 PM · Build System, Frameworks
marten added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.
In D7823#164879, @cfeck wrote:

Are the copies in the attic directory still needed for compatibility reasons, or can they get removed?

Mon, Nov 6, 12:59 PM · Build System, Frameworks
cfeck added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Are the copies in the attic directory still needed for compatibility reasons, or can they get removed?

Mon, Nov 6, 12:56 PM · Build System, Frameworks
marten closed D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.
Mon, Nov 6, 12:52 PM · Build System, Frameworks

Sun, Nov 5

dfaure closed D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found.
Sun, Nov 5, 8:32 PM · Build System, Frameworks
cgiboudeaux accepted D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found.

+1. Tested with a few repo without noticing any regression.

Sun, Nov 5, 11:05 AM · Build System, Frameworks
cgiboudeaux added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Don't forget to create .rst files in doc/find-module and change 'Since 5.39.0' to 'Since 5.40.0'

Sun, Nov 5, 10:18 AM · Build System, Frameworks
cgiboudeaux accepted D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

No news from the ECM maintainer, please push.
Don't forget to create .rst files in doc/find-module and change 'Since 5.39.0' to 'Since 5.40.0'

Sun, Nov 5, 10:15 AM · Build System, Frameworks
dfaure updated the diff for D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found.

now with the right patch...

Sun, Nov 5, 9:02 AM · Build System, Frameworks
dfaure created D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found.
Sun, Nov 5, 8:50 AM · Build System, Frameworks
dfaure closed D7612: KDECMakeSettings: more docu about the layout of the build dir.
Sun, Nov 5, 8:46 AM · Build System, Frameworks
dfaure added a comment to D7612: KDECMakeSettings: more docu about the layout of the build dir.

No feedback, but this is just docu, I'll push it.

Sun, Nov 5, 8:45 AM · Build System, Frameworks

Fri, Nov 3

xuetianweng abandoned D5805: include directory should contains all directory from pkg-config.

Just noticed that FindPkgConfig has import_module now.. Personally I just port my code to use that.

Fri, Nov 3, 5:25 PM · Build System, Frameworks

Thu, Nov 2

apol updated the diff for D8173: Use readelf to find project dependencies.

Make sure we get the dependencies from the prefix as well

Thu, Nov 2, 2:25 PM · Build System, Frameworks

Oct 22 2017

marten added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Ping anyone?

Oct 22 2017, 2:15 PM · Build System, Frameworks