Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Yesterday

cgiboudeaux abandoned D17015: Fix the Qt doc creation with Qt 5.12..

qhelpgenerator is back in Qt 5.12.1

Mon, Jan 21, 12:06 PM · Build System, Frameworks
kossebau added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add override won't break. Human errors happen, nobody will be able to review something like that. Addressing this warning by adding override all over our legacy code base has a serious risk.

I'm seriously pissed that this is forced on us and we have to change code.

I'm totally fine with this warning for new code and new projects. But let projects opt in for it instead of forcing it on legacy code bases.

Mon, Jan 21, 8:42 AM · Build System, Frameworks
graesslin added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add override won't break. Human errors happen, nobody will be able to review something like that. Addressing this warning by adding override all over our legacy code base has a serious risk.

Mon, Jan 21, 5:28 AM · Build System, Frameworks

Sun, Jan 20

aacid added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years.

Sun, Jan 20, 7:26 PM · Build System, Frameworks
graesslin added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years.

Sun, Jan 20, 5:09 PM · Build System, Frameworks

Sat, Jan 19

aacid closed D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.
Sat, Jan 19, 11:01 AM · Build System, Frameworks

Fri, Jan 18

aacid closed D18345: Fix python binding generation for classes with deleted copy constructors.
Fri, Jan 18, 6:17 PM · Build System, Frameworks
lbeltrame accepted D18345: Fix python binding generation for classes with deleted copy constructors.

As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code...

Fri, Jan 18, 10:58 AM · Build System, Frameworks
cgiboudeaux added a reviewer for D18345: Fix python binding generation for classes with deleted copy constructors: lbeltrame.
Fri, Jan 18, 9:30 AM · Build System, Frameworks

Thu, Jan 17

aacid updated subscribers of D18345: Fix python binding generation for classes with deleted copy constructors.
Thu, Jan 17, 11:50 PM · Build System, Frameworks
aacid requested review of D18345: Fix python binding generation for classes with deleted copy constructors.
Thu, Jan 17, 11:48 PM · Build System, Frameworks

Mon, Jan 14

vkrause closed D18243: Fix qmake module generation for Qt 5.12.1.
Mon, Jan 14, 3:09 PM · Build System, Frameworks
apol accepted D18243: Fix qmake module generation for Qt 5.12.1.
Mon, Jan 14, 2:54 PM · Build System, Frameworks
vkrause requested review of D18243: Fix qmake module generation for Qt 5.12.1.
Mon, Jan 14, 2:47 PM · Build System, Frameworks

Sat, Jan 12

aacid added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

Since i have two +1 i'll commit this next saturday unless someone shouts in disagreement

Sat, Jan 12, 5:40 PM · Build System, Frameworks

Thu, Jan 10

apol added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

+1 to me too.

Thu, Jan 10, 11:23 PM · Build System, Frameworks
vkrause added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

IMHO a good idea, +1.

Thu, Jan 10, 7:43 PM · Build System, Frameworks
aacid requested review of D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.
Thu, Jan 10, 7:38 PM · Build System, Frameworks

Tue, Jan 8

apol accepted D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.
Tue, Jan 8, 12:46 AM · Build System, Frameworks

Mon, Jan 7

kossebau added a comment to D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.

Not sure if there ever s a chance somebody would inject QObject code into such a generated file?

Mon, Jan 7, 11:56 PM · Build System, Frameworks
kossebau requested review of D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.
Mon, Jan 7, 11:55 PM · Build System, Frameworks

Mon, Dec 31

cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

include(ECMCheckLinkerFlags)
[...]
# Check for nodump support
SET(NODUMP_FLAGS "-Wl,-z,nodump")
ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
if (NODUMP_SUPPORTED)
    SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
endif ()

Of course kstars could also just stop adding nodump ever :)

Mon, Dec 31, 12:45 PM · Build System, Frameworks
tcberner added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Mon, Dec 31, 6:48 AM · Build System, Frameworks

Sun, Dec 30

cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Sun, Dec 30, 11:10 PM · Build System, Frameworks
lbeltrame added a reviewer for D17863: Add ecm_check_linker_flags function: cgiboudeaux.
Sun, Dec 30, 8:47 AM · Build System, Frameworks

Sat, Dec 29

tcberner added a comment to D17863: Add ecm_check_linker_flags function.

See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603

Sat, Dec 29, 10:58 PM · Build System, Frameworks
tcberner updated the summary of D17863: Add ecm_check_linker_flags function.
Sat, Dec 29, 10:57 PM · Build System, Frameworks
tcberner requested review of D17863: Add ecm_check_linker_flags function.
Sat, Dec 29, 10:56 PM · Build System, Frameworks
thiago added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

qhelpgenerator is coming back in 5.12.1. You may simply tell people to skip the .0 release and upgrade.

Sat, Dec 29, 6:30 PM · Build System, Frameworks

Dec 21 2018

cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Try to find qmake if qmake-qt5 is not found

Dec 21 2018, 2:57 PM · Build System, Frameworks

Dec 20 2018

dfaure added a comment to D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.

Damn, I went too fast. This doesn't fix the issue.

Dec 20 2018, 10:48 PM · Build System, Frameworks
dfaure closed D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.
Dec 20 2018, 10:09 PM · Build System, Frameworks
cgiboudeaux accepted D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.
Dec 20 2018, 8:43 PM · Build System, Frameworks
dfaure requested review of D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.
Dec 20 2018, 7:08 PM · Build System, Frameworks

Dec 6 2018

tcberner added inline comments to D17015: Fix the Qt doc creation with Qt 5.12..
Dec 6 2018, 7:40 PM · Build System, Frameworks

Dec 4 2018

vkrause closed D16954: Add find module for Google's libphonenumber.
Dec 4 2018, 4:47 PM · Build System, Frameworks

Dec 3 2018

cgiboudeaux accepted D16954: Add find module for Google's libphonenumber.
Dec 3 2018, 6:02 PM · Build System, Frameworks
vkrause updated the diff for D16954: Add find module for Google's libphonenumber.

Address review comments.

Dec 3 2018, 5:53 PM · Build System, Frameworks
cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)

Any idea how we could perhaps deduplicate the FindQHelpGenerator.cmake with the one from find-modules (which is a helper for runtime with the ECMAddQch macro)? No instant idea yet, perhaps also better to have dedicated variants for each purppse? Needs me another round of thinking.

Dec 3 2018, 11:46 AM · Build System, Frameworks
cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Add the reason for looking for the executable

Dec 3 2018, 11:40 AM · Build System, Frameworks

Dec 1 2018

cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Dec 1 2018, 9:16 PM · Build System, Frameworks
cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Dec 1 2018, 9:11 PM · Build System, Frameworks
vkrause added a comment to D16954: Add find module for Google's libphonenumber.

ping?

Dec 1 2018, 11:17 AM · Build System, Frameworks

Nov 26 2018

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

A more complete draft:

Nov 26 2018, 10:36 PM · Build System

Nov 25 2018

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

You will notice that I plan to maintain an option to disable the Apple-specific behaviour for anyone who depends on the current behaviour (that includes me, but your script would also continue to work). Cf. the APPLE_FORCE_X11 option

Nov 25 2018, 11:42 AM · Build System
yurikoles added a comment to T10112: KDEInstallDirs on Mac.
/Library/Application Support/kf5
Nov 25 2018, 11:32 AM · Build System

Nov 24 2018

vkrause added reviewers for D16954: Add find module for Google's libphonenumber: Build System, Frameworks.
Nov 24 2018, 11:31 AM · Build System, Frameworks

Nov 23 2018

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

Can we set DATAROOTDIR=/Library/Application Support/KDE so that everything remains nicely bundled?

Nov 23 2018, 1:38 PM · Build System
rjvbb updated subscribers of T10112: KDEInstallDirs on Mac.
Nov 23 2018, 1:33 PM · Build System
rjvbb created T10112: KDEInstallDirs on Mac.
Nov 23 2018, 10:00 AM · Build System