Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Tue, Mar 5

dfaure closed D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Tue, Mar 5, 2:40 PM · Build System, Frameworks
apol accepted D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Tue, Mar 5, 1:26 PM · Build System, Frameworks
dfaure added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Makes sense --> https://phabricator.kde.org/D19538

Tue, Mar 5, 10:58 AM · Build System, Frameworks
dfaure requested review of D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Tue, Mar 5, 10:49 AM · Build System, Frameworks

Mon, Mar 4

vkrause closed D19486: Add UDev find module.
Mon, Mar 4, 8:05 PM · Build System, Frameworks
kossebau added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

FWIW, this still results in inproper pc files, from what I heard recently. The prefix variable can be overriden from outside when calling pkg-config (cmp. pkg-config --help) to allow for relocatable installations. Same like CMake Config files also allow relocation by having the install prefix not hardcoded into directory var values.

Mon, Mar 4, 6:51 PM · Build System, Frameworks
dfaure closed D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mon, Mar 4, 12:35 PM · Build System, Frameworks
cgiboudeaux accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Thanks.

Mon, Mar 4, 12:23 PM · Build System, Frameworks
dfaure updated the diff for D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Update unittests, passes now

Mon, Mar 4, 11:52 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mon, Mar 4, 11:35 AM · Build System, Frameworks
cgiboudeaux requested changes to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mon, Mar 4, 11:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mon, Mar 4, 11:27 AM · Build System, Frameworks
fazevedo accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Works for me !

Mon, Mar 4, 11:20 AM · Build System, Frameworks
dfaure requested review of D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mon, Mar 4, 10:26 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

kdelibs4support provides one.

Mon, Mar 4, 8:49 AM · Build System, Frameworks
vkrause closed D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mon, Mar 4, 7:37 AM · Build System, Frameworks

Sun, Mar 3

cgiboudeaux accepted D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Sun, Mar 3, 9:31 PM · Build System, Frameworks
kossebau added a comment to D18943: Add Fontconfig find modudle.

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

Sun, Mar 3, 9:24 PM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

D19499 fixes that here

Sun, Mar 3, 9:17 PM · Build System, Frameworks
vkrause requested review of D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Sun, Mar 3, 9:17 PM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Sun, Mar 3, 9:10 PM · Build System, Frameworks
matthieugras added a comment to D18943: Add Fontconfig find modudle.

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Sun, Mar 3, 6:55 PM · Build System, Frameworks
cgiboudeaux accepted D19486: Add UDev find module.
Sun, Mar 3, 10:53 AM · Build System, Frameworks
vkrause updated the diff for D19486: Add UDev find module.

Add backward compatibility variables.

Sun, Mar 3, 10:38 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Sun, Mar 3, 10:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Sun, Mar 3, 10:18 AM · Build System, Frameworks
vkrause closed D18943: Add Fontconfig find modudle.
Sun, Mar 3, 9:47 AM · Build System, Frameworks
vkrause requested review of D19486: Add UDev find module.
Sun, Mar 3, 9:26 AM · Build System, Frameworks
dfaure requested changes to D15795: Fix warnings about deprecated install dirs.

The warning needs to be removed then. We can't really warn at the time of using a variable.

Sun, Mar 3, 12:20 AM · Build System, Frameworks

Sat, Mar 2

cgiboudeaux accepted D18943: Add Fontconfig find modudle.

LGTM

Sat, Mar 2, 11:57 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

ping?

Sat, Mar 2, 10:07 AM · Build System, Frameworks

Tue, Feb 26

jjazeix added a comment to D19016: Update Android toolchain files to reality.
In D19016#420246, @apol wrote:

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Tue, Feb 26, 3:57 PM · Build System, Frameworks
apol added a comment to D19016: Update Android toolchain files to reality.

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Tue, Feb 26, 2:54 PM · Build System, Frameworks

Mon, Feb 25

jjazeix added inline comments to D19016: Update Android toolchain files to reality.
Mon, Feb 25, 9:29 PM · Build System, Frameworks

Fri, Feb 22

dfaure added a comment to D19075: Fix FindEGL.

If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches.

Fri, Feb 22, 3:20 PM · Build System, Frameworks
vkrause closed D19223: Fix releaseme checkout when this is included in a sub-directory.
Fri, Feb 22, 1:47 PM · Build System, Frameworks
apol accepted D19223: Fix releaseme checkout when this is included in a sub-directory.
Fri, Feb 22, 1:31 PM · Build System, Frameworks
vkrause requested review of D19223: Fix releaseme checkout when this is included in a sub-directory.
Fri, Feb 22, 12:24 PM · Build System, Frameworks

Feb 20 2019

apol added a comment to D15795: Fix warnings about deprecated install dirs.

Has this been fixed? I haven't seen these warnings

Feb 20 2019, 5:21 PM · Build System, Frameworks
apol added a comment to D17863: Add ecm_check_linker_flags function.

Yep, I'd say let's get it in kstars and if other applications start needing it, we move it to ECM to share.

Feb 20 2019, 5:14 PM · Build System, Frameworks

Feb 19 2019

tcberner closed D19075: Fix FindEGL.
Feb 19 2019, 12:15 PM · Build System, Frameworks
sitter closed D18952: new find module for Canberra.
Feb 19 2019, 9:57 AM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

explicitly set FOUND_VAR so it is camelcase too

Feb 19 2019, 9:56 AM · Build System, Frameworks
cgiboudeaux accepted D18952: new find module for Canberra.

Thanks! just a little thing to fix before pushing

Feb 19 2019, 8:09 AM · Build System, Frameworks

Feb 18 2019

vkrause added a comment to D19005: android: don't default to gcc anymore.
In D19005#414313, @apol wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

Feb 18 2019, 5:02 PM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

fix bad copy paste in compat setup

Feb 18 2019, 4:24 PM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.
  • pkgconfig is now quiet
  • variables are now camelcase
    • old variables are still set for compat
  • new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do)
  • set package description url & description
Feb 18 2019, 12:36 PM · Build System, Frameworks
bcooksley added a comment to D19075: Fix FindEGL.

If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/

Feb 18 2019, 9:55 AM · Build System, Frameworks
apol added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Feb 18 2019, 1:01 AM · Build System, Frameworks
apol accepted D19075: Fix FindEGL.
Feb 18 2019, 12:16 AM · Build System, Frameworks