Build SystemOrganization
ActivePublic

Recent Activity

Today

patrickelectric added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here.

Mon, Jan 20, 10:46 AM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?

In Kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands for for scalable (SVG) files.

Mon, Jan 20, 9:03 AM · Build System, Frameworks
vkrause added inline comments to D26749: WIP: Support NDK r20 and Qt 5.14.
Mon, Jan 20, 8:45 AM · Build System, Frameworks

Yesterday

apol accepted D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.

Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it.

Sun, Jan 19, 11:25 PM · Build System, Frameworks
apol added inline comments to D26749: WIP: Support NDK r20 and Qt 5.14.
Sun, Jan 19, 11:21 PM · Build System, Frameworks
patrickelectric added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?

Sun, Jan 19, 10:57 PM · Build System, Frameworks
bcooksley requested changes to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Christophe is correct here, it is worth warning developers about these issues regardless of the platform, so they can get the code ready for those platforms and test everything in their local environment as much as possible.
I know for certain that there are developers who rely on our CI system and the Binary Factory to test and validate their applications (because they themselves do not have access to a development environment on those platforms).

Sun, Jan 19, 6:51 PM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sun, Jan 19, 5:23 PM · Build System, Frameworks
tcanabrava updated subscribers of D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

I think we are misunderstanding eachother here.
If I'm developing the software and running cmake all the time, having a
warning that I can't fix (because it depends in another platform) is noise,
but still being a developer I don't want to run with -Wno-dev.
I do work in applications that targets more than one system (and they are
mac / windows / ios / android) I tend to use buildhosts, and those
buildhosts will tell me the warning - if any. But only if I'm targeting
them.

Sun, Jan 19, 4:20 PM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

That’s not a developer issue, it’s a packaging issue.

Sun, Jan 19, 1:12 PM · Build System, Frameworks
tcanabrava added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

That’s not a developer issue, it’s a packaging issue.

Sun, Jan 19, 12:03 PM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform

Sun, Jan 19, 12:01 PM · Build System, Frameworks
tcanabrava updated subscribers of D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

But why would I get the warning if I build on Linux? The warning should
target the platform, not the entire build system.

Sun, Jan 19, 11:55 AM · Build System, Frameworks
cgiboudeaux requested changes to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

I object. This warning is for developers. It tells them the icons are missing for some platforms.

Sun, Jan 19, 10:00 AM · Build System, Frameworks

Sat, Jan 18

patrickelectric retitled D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build from ECMAddAppIcon: Do not warn about mac icons if isnt a mac build to ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sat, Jan 18, 2:08 PM · Build System, Frameworks
tcanabrava accepted D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sat, Jan 18, 2:06 PM · Build System, Frameworks
patrickelectric added reviewers for D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build: apol, tcanabrava.
Sat, Jan 18, 2:04 PM · Build System, Frameworks
patrickelectric requested review of D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sat, Jan 18, 2:03 PM · Build System, Frameworks
patrickelectric added a reviewer for D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names: apol.
Sat, Jan 18, 1:50 PM · Build System, Frameworks
tcanabrava accepted D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
Sat, Jan 18, 1:49 PM · Build System, Frameworks
patrickelectric added a comment to D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.

From ECMInstallIcons:

Sat, Jan 18, 1:46 PM · Build System, Frameworks
patrickelectric requested review of D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
Sat, Jan 18, 1:44 PM · Build System, Frameworks
vkrause added a task to D26749: WIP: Support NDK r20 and Qt 5.14: T12520: Qt 5.14.
Sat, Jan 18, 11:43 AM · Build System, Frameworks
vkrause updated the test plan for D26749: WIP: Support NDK r20 and Qt 5.14.
Sat, Jan 18, 11:43 AM · Build System, Frameworks
vkrause requested review of D26749: WIP: Support NDK r20 and Qt 5.14.
Sat, Jan 18, 11:41 AM · Build System, Frameworks

Fri, Jan 10

tcanabrava requested review of D26573: Add missing Import Env Variable.
Fri, Jan 10, 9:35 PM · Build System, Frameworks

Sat, Jan 4

cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

Ping? Any update if somebody tried the proposed changes?

Sat, Jan 4, 4:52 PM · Build System, Frameworks
nicolasfella closed D26402: [android] Fix apk install target.
Sat, Jan 4, 12:14 AM · Build System, Frameworks
apol accepted D26402: [android] Fix apk install target.
Sat, Jan 4, 12:11 AM · Build System, Frameworks

Fri, Jan 3

nicolasfella requested review of D26402: [android] Fix apk install target.
Fri, Jan 3, 5:51 PM · Build System, Frameworks
apol accepted D26394: ECMGeneratePriFile: Fix static configurations.
Fri, Jan 3, 3:09 PM · Build System, Frameworks
kfunk added reviewers for D26394: ECMGeneratePriFile: Fix static configurations: winterz, vkrause.
Fri, Jan 3, 2:15 PM · Build System, Frameworks
kfunk requested review of D26394: ECMGeneratePriFile: Fix static configurations.
Fri, Jan 3, 2:15 PM · Build System, Frameworks

Mon, Dec 30

pwojcik updated the diff for D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr.

Corrected logic, so it is is in line with GNUInstallDirs. Explained in comment. Added tests.

Mon, Dec 30, 5:36 PM · Build System, Frameworks

Sun, Dec 29

elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

@heikobecker are you still interested in this patch? I can take over otherwise.

Sun, Dec 29, 4:02 PM · Build System, Frameworks

Sat, Dec 28

kossebau added a comment to D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr.

(Just remember that using KDE_INSTALL_KNSRCDIR though needs at least KNewStuffCore from KF 5.57 (hint was missing in API dox, proposing D26248 to fix that).)

Sat, Dec 28, 2:04 PM · Build System, Frameworks
pwojcik added inline comments to D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr.
Sat, Dec 28, 10:29 AM · Build System, Frameworks
apol added a comment to D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr.

Not saying that this patch is wrong, would have to look into it more closely.

Sat, Dec 28, 1:12 AM · Build System, Frameworks

Fri, Dec 27

pwojcik added reviewers for D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr: kossebau, alexmerry.
Fri, Dec 27, 6:06 PM · Build System, Frameworks
pwojcik requested review of D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr.
Fri, Dec 27, 5:53 PM · Build System, Frameworks

Sat, Dec 21

cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

This has been missing the link from an rst file in docs/, so the documentation generation picks up the file. Fixed with c4890d5c03ed79f0c87da861b6608bbd46c2162c

Sat, Dec 21, 8:08 PM · Build System, Frameworks

Dec 19 2019

kossebau added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

This has been missing the link from an rst file in docs/, so the documentation generation picks up the file. Fixed with c4890d5c03ed79f0c87da861b6608bbd46c2162c

Dec 19 2019, 9:53 PM · Build System, Frameworks

Dec 18 2019

apol abandoned D12172: Android: Also install plugins, otherwise they are just not available.
Dec 18 2019, 2:07 AM · Build System, Frameworks

Dec 15 2019

arojas closed D25972: Support PyQt5 compiled with SIP 5.
Dec 15 2019, 10:03 AM · Build System, Frameworks
apol accepted D25972: Support PyQt5 compiled with SIP 5.
Dec 15 2019, 9:47 AM · Build System, Frameworks

Dec 14 2019

arojas updated the diff for D25972: Support PyQt5 compiled with SIP 5.

Use HINTS

Dec 14 2019, 11:01 PM · Build System, Frameworks
apol added a comment to D25972: Support PyQt5 compiled with SIP 5.

LGTM overall

Dec 14 2019, 10:37 PM · Build System, Frameworks

Dec 13 2019

arojas requested review of D25972: Support PyQt5 compiled with SIP 5.
Dec 13 2019, 10:27 PM · Build System, Frameworks

Dec 9 2019

thomasfischer updated the diff for D24641: Collect more information from version control systems.

I tried to address the most recent comments:

Dec 9 2019, 10:49 PM · Build System, Frameworks

Dec 8 2019

asturmlechner added a reviewer for D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations: Frameworks.
Dec 8 2019, 3:32 PM · Build System, Frameworks