Build SystemOrganization
ActivePublic

Recent Activity

Fri, May 22

broulik updated the diff for D29051: Add ecm_generate_dbus_service_file.
  • Clarify docs
Fri, May 22, 8:17 AM · Build System, Frameworks

Wed, May 13

kossebau closed D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED().
Wed, May 13, 4:07 PM · Build System, Frameworks

Mon, May 11

nicolasfella closed D29631: [android] Allow specifying APK install location.
Mon, May 11, 4:58 PM · Build System, Frameworks
apol accepted D29631: [android] Allow specifying APK install location.
Mon, May 11, 3:31 PM · Build System, Frameworks
nicolasfella updated the diff for D29631: [android] Allow specifying APK install location.
  • Rename variable
Mon, May 11, 1:48 PM · Build System, Frameworks
apol added a comment to D29631: [android] Allow specifying APK install location.

+1 overall, good idea.

Mon, May 11, 1:41 PM · Build System, Frameworks
apol added inline comments to D29631: [android] Allow specifying APK install location.
Mon, May 11, 1:41 PM · Build System, Frameworks
nicolasfella added a comment to D29631: [android] Allow specifying APK install location.

This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68

Mon, May 11, 1:31 PM · Build System, Frameworks
nicolasfella requested review of D29631: [android] Allow specifying APK install location.
Mon, May 11, 1:22 PM · Build System, Frameworks

Sat, May 9

kossebau added a dependent revision for D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED(): D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED.
Sat, May 9, 8:11 PM · Build System, Frameworks
dfaure accepted D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED().

So many things to take care of :-)

Sat, May 9, 8:04 PM · Build System, Frameworks
kossebau requested review of D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED().
Sat, May 9, 7:55 PM · Build System, Frameworks

Fri, May 8

dfaure closed D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.
Fri, May 8, 11:01 AM · Build System, Frameworks
cgiboudeaux accepted D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.

tested successfully with the openSUSE package which uses absolute paths

Fri, May 8, 10:54 AM · Build System, Frameworks
dfaure requested review of D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.
Fri, May 8, 9:59 AM · Build System, Frameworks
dfaure closed D29274: ECMGeneratePriFile: make the pri files relocatable.
Fri, May 8, 9:13 AM · Build System, Frameworks
vkrause accepted D29274: ECMGeneratePriFile: make the pri files relocatable.
Fri, May 8, 9:12 AM · Build System, Frameworks

Mon, May 4

xuetianweng closed D29396: Suppress find_package_handle_standard_args package name mismatch warning..
Mon, May 4, 3:35 PM · Build System, Frameworks
apol accepted D29396: Suppress find_package_handle_standard_args package name mismatch warning..

This will make our configure steps readable again. Thanks!

Mon, May 4, 2:20 AM · Build System, Frameworks
xuetianweng requested review of D29396: Suppress find_package_handle_standard_args package name mismatch warning..
Mon, May 4, 1:27 AM · Build System, Frameworks

Thu, Apr 30

ablu abandoned D29096: Prefix includes and libs dir with QT_SYSROOT.
Thu, Apr 30, 8:21 AM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Ah, right. If you are using a normal sysroot for system libs, but conan for some libs then it makes sense!

Thu, Apr 30, 7:51 AM · Build System, Frameworks
dfaure added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

I'm using conan, not doing cross compilation.

Thu, Apr 30, 7:47 AM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Though... How does it come that you do not have SYSROOT set in your case? Won't that break in other cases?

Thu, Apr 30, 5:14 AM · Build System, Frameworks
ablu added a comment to D29274: ECMGeneratePriFile: make the pri files relocatable.

The Build worked. So this solves the issue for me!

Thu, Apr 30, 5:13 AM · Build System, Frameworks

Wed, Apr 29

dfaure added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Thanks for the quick test!

Wed, Apr 29, 3:56 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

looks good! yours is probably a bit more "CMakeish"! So feel free to continue with that one and close this.

Wed, Apr 29, 3:14 PM · Build System, Frameworks
dfaure updated the diff for D29274: ECMGeneratePriFile: make the pri files relocatable.

Fix error: regex "[^/]*" matched an empty string.

Wed, Apr 29, 2:45 PM · Build System, Frameworks
ablu added a comment to D29274: ECMGeneratePriFile: make the pri files relocatable.

My reason is basically the same. Will try this version too.

Wed, Apr 29, 2:41 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Hi @dfaure. It looks pretty much the same and I think it should work for us. I will kick off a build to confirm.

Wed, Apr 29, 2:39 PM · Build System, Frameworks
dfaure added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Could you test if my patch in D29274 solves your problem? By making these lines relative to the location of the .pri file, it should work very well in a sysroot context as well.

Wed, Apr 29, 2:13 PM · Build System, Frameworks
kossebau added a comment to D29274: ECMGeneratePriFile: make the pri files relocatable.

D29096 also wants to touch those entries, for different reasons. You may want to align here.

Wed, Apr 29, 1:28 PM · Build System, Frameworks
dfaure requested review of D29274: ECMGeneratePriFile: make the pri files relocatable.
Wed, Apr 29, 1:19 PM · Build System, Frameworks

Tue, Apr 28

apol closed D29079: android: include the architecture on the apk name.
Tue, Apr 28, 11:16 PM · Build System, Frameworks
nicolasfella accepted D29079: android: include the architecture on the apk name.
Tue, Apr 28, 8:42 PM · Build System, Frameworks

Apr 23 2020

kossebau added a comment to D29051: Add ecm_generate_dbus_service_file.

Any chance for a simple unit test to check the generation does what is expected (or catches bad input)? :)

Apr 23 2020, 1:20 PM · Build System, Frameworks
kossebau added a comment to D28355: Introduce function ecm_install_configured_file.

A bit unsure if the arg name "TEMPLATES" is good, or if perhaps should be renamed to "INPUT". Just mentioning, not preferring one over the other. So far have not found existing samples to take as lead for consistent argument naming.

Apr 23 2020, 12:06 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePriFile and preparing it for cross-compilation, the installation prefix would be hardcoded into the generated artifacts.. Seems that instead files are relocated sometimes, changing their path & prefix, or tools snipping of some things?

Apr 23 2020, 11:35 AM · Build System, Frameworks
kossebau added a reviewer for D28355: Introduce function ecm_install_configured_file: Build System.
Apr 23 2020, 11:04 AM · Build System, Frameworks
kossebau added reviewers for D29096: Prefix includes and libs dir with QT_SYSROOT: Build System, apol, vkrause, kfunk.
Apr 23 2020, 10:54 AM · Build System, Frameworks
kossebau added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Thanks for the explanation, fear though I am missing some details and thus have not yet understood the problem and the solution. Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePriFile and preparing it for cross-compilation, the installation prefix would be hardcoded into the generated artifacts.. Seems that instead files are relocated sometimes, changing their path & prefix, or tools snipping of some things? So $$[QT_SYSROOT] would make up for that, when having a library build normally for a system, but then deployed to the cross-compilation system below some path? Just curious in case you have time to teach me, positioning myself here as curious person at the sideline :)

Apr 23 2020, 10:53 AM · Build System, Frameworks
davidedmundson added a dependent revision for D29051: Add ecm_generate_dbus_service_file: D28305: Systemd Startup.
Apr 23 2020, 9:41 AM · Build System, Frameworks
davidedmundson added a dependent revision for D28355: Introduce function ecm_install_configured_file: D28305: Systemd Startup.
Apr 23 2020, 9:41 AM · Build System, Frameworks

Apr 22 2020

kossebau closed D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args.
Apr 22 2020, 4:51 PM · Build System, Frameworks
apol added a comment to D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args.

+1 makes sense

Apr 22 2020, 3:05 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

The SYSROOT variable should not (directly) impact that. The install directory is configured by ECM_MKSPECS_INSTALL_DIR, which usually will point to /usr/lib/mkspecs/modules/ on Linux. For a cross-compile toolchain it will however be additionally prefixed with separate path. But Qt and qmake will also be configured with that prefix so those know to lookup the mkspecs dir under that prefix. Issuing QT += <module> can then trigger the including of the include and lib paths from the .pri generated by this code. So the case I am trying to fix with this patch is the case where the .pri is found (so ECM_MKSPECS_INSTALL_DIR was specified correctly) but now the libs and include paths are pointing to /usr/{include,lib} and not to <cross-compile-prefix>/usr/{include,lib}. Now since <cross-compile-prefix> can differ depending on the installation dir of the tool chain it may not be possible to know that path during compile / install time. However, we can assume that Qt / qmake will know about the sysroot (which is the prefix essentially). So as long qmake is configured for the cross compile our Qt module now should be too.

Apr 22 2020, 2:04 PM · Build System, Frameworks
cgiboudeaux accepted D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args.
Apr 22 2020, 1:55 PM · Build System, Frameworks
kossebau added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

No current clue about qmake, just wondering from my little knowledge:
how does having $$[QT_SYSROOT] here influence any QMAKEPATH env var set? Would pri files installed into a custom prefix still be found?

Apr 22 2020, 1:55 PM · Build System, Frameworks
kossebau added a comment to D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args.

Warning: I have not really investigated in full detail if the current code of FindKF5 is completely sane besides a quick check, more or less assume that it has worked all the time, so the new warning here can be silenced.

Apr 22 2020, 1:45 PM · Build System, Frameworks
kossebau requested review of D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args.
Apr 22 2020, 1:43 PM · Build System, Frameworks