Build SystemOrganization
ActivePublic

Recent Activity

Today

arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

The pkgconfig file disagrees:
it contains libsuffix=-2_4 and later Libs: -L${libdir} -lIlmImf${libsuffix}
For me, that library name is correct

Thu, Nov 14, 5:30 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

Thu, Nov 14, 5:26 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

Thu, Nov 14, 5:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Thu, Nov 14, 5:19 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unprefixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Thu, Nov 14, 4:53 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found

Thu, Nov 14, 1:53 PM · Build System, Frameworks
cgiboudeaux requested review of D25304: Fix the OpenEXR >= 2.4 detection.
Thu, Nov 14, 1:42 PM · Build System, Frameworks

Fri, Nov 8

winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2.

Fri, Nov 8, 10:33 PM · Build System, Frameworks

Sun, Nov 3

davidedmundson closed D25107: Add install dir for systemd units.
Sun, Nov 3, 10:04 PM · Build System, Frameworks
kossebau closed D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.
Sun, Nov 3, 8:48 PM · Build System, Frameworks
kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Merci, will land later tonight. Bonnes vacances :)

Sun, Nov 3, 8:18 PM · Build System, Frameworks
dfaure accepted D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Done (in the process of being pushed), you can push this.

Sun, Nov 3, 8:11 PM · Build System, Frameworks
kossebau updated subscribers of D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

@dfaure Hi. Any chance you you can sneak in before you are away (enjoy :) ) to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x060000" from all the KF modules in the next days? Otherwise would land this here with just the -DKF_DEPRECATED_WARNINGS_SINCE=0x060000 for now, otherwise people do not see warnings in KF modules when they should.

Sun, Nov 3, 7:58 PM · Build System, Frameworks
thomasfischer updated the diff for D24641: Collect more information from version control systems.

I updated the diff. I was quite surprised about the time it takes to compute the number of commits (26 seconds), thus I removed this functionality completely. As of now, only 'revision' and 'branch' are queried for.
There are three functions now:

Sun, Nov 3, 6:16 PM · Build System, Frameworks
thomasfischer updated the test plan for D24641: Collect more information from version control systems.
Sun, Nov 3, 6:08 PM · Build System, Frameworks
apol accepted D25107: Add install dir for systemd units.
Sun, Nov 3, 2:26 AM · Build System, Frameworks

Fri, Nov 1

davidedmundson requested review of D25107: Add install dir for systemd units.
Fri, Nov 1, 5:05 PM · Build System, Frameworks

Mon, Oct 28

apol accepted D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.
Mon, Oct 28, 11:54 AM · Build System, Frameworks

Sun, Oct 27

kossebau requested review of D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.
Sun, Oct 27, 7:41 PM · Build System, Frameworks

Thu, Oct 24

sitter added a comment to D24641: Collect more information from version control systems.

Hm, how about separate functions though? With a single stat any given build still needs N process forks even when they only want 1 value.

Thu, Oct 24, 10:22 AM · Build System, Frameworks

Wed, Oct 23

kossebau added a comment to D24841: Use modern way to set the C/CXX standard.

Where are those tests running? I'm only aware of https://build.kde.org/job/Frameworks/job/extra-cmake-modules/

Wed, Oct 23, 5:22 PM · Build System, Frameworks
vonreth added a comment to D24841: Use modern way to set the C/CXX standard.

Another issue caused by the new CMake 3.5 dependency, some tests fail:

59 - ecm_setup_version-old_simple (Failed)
60 - ecm_setup_version-old_soversion (Failed)
61 - ecm_setup_version-old_version_file (Failed)
62 - ecm_setup_version-old_version_file_abspath (Failed)
63 - ecm_setup_version-old_version_file_anynewer (Failed)
64 - ecm_setup_version-old_version_file_exact (Failed)
65 - ecm_setup_version-old_version_file_samemajor (Failed)
66 - ecm_setup_version-old_header (Failed)
67 - ecm_setup_version-old_header_abspath (Failed)

(+2 others not related to the recent changes)
I didn't look yet at the details. My guess is the CMake policy changes between 2.8.12 and 3.5

Wed, Oct 23, 5:18 PM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Another issue caused by the new CMake 3.5 dependency, some tests fail:

Wed, Oct 23, 11:01 AM · Build System, Frameworks
dfaure closed D24882: Don't set C/C++ standards if already set.
Wed, Oct 23, 10:15 AM · Build System, Frameworks
cgiboudeaux accepted D24882: Don't set C/C++ standards if already set.

Thanks! tested successfullly

Wed, Oct 23, 9:43 AM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Does https://phabricator.kde.org/D24882 help? (Not tested)

Wed, Oct 23, 9:34 AM · Build System, Frameworks
dfaure requested review of D24882: Don't set C/C++ standards if already set.
Wed, Oct 23, 9:34 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Maybe some projects were doing set(CMAKE_CXX_STANDARD 14) before including KDECompilerSettings? We could test the var here to avoid overwriting it...

Wed, Oct 23, 9:17 AM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Wed, Oct 23, 9:08 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync)

Wed, Oct 23, 9:01 AM · Build System, Frameworks

Tue, Oct 22

vonreth closed D24841: Use modern way to set the C/CXX standard.
Tue, Oct 22, 4:54 PM · Build System, Frameworks
cgiboudeaux updated the summary of D24841: Use modern way to set the C/CXX standard.
Tue, Oct 22, 2:53 PM · Build System, Frameworks
dfaure accepted D24841: Use modern way to set the C/CXX standard.
Tue, Oct 22, 7:00 AM · Build System, Frameworks

Mon, Oct 21

vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.
  • Raise CMake requirements to 3.5
Mon, Oct 21, 9:38 PM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Dunno, it's harder to justify in a standalone review :)
"Increase dependency, just because" ;)

Mon, Oct 21, 9:04 PM · Build System, Frameworks
vonreth added a comment to D24841: Use modern way to set the C/CXX standard.

I guess we should do that in a separate review?

Mon, Oct 21, 8:45 PM · Build System, Frameworks
vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.

Fix

Mon, Oct 21, 8:41 PM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Works for me.

Mon, Oct 21, 8:40 PM · Build System, Frameworks
aacid added a comment to D24841: Use modern way to set the C/CXX standard.

If you want to increase cmake dependency, we should at least increase it to 3.5

Mon, Oct 21, 8:26 PM · Build System, Frameworks
dfaure requested changes to D24841: Use modern way to set the C/CXX standard.
Mon, Oct 21, 8:19 PM · Build System, Frameworks
vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.

CMAKE_CXX_STANDARD_REQUIRED

Mon, Oct 21, 7:08 PM · Build System, Frameworks
vonreth updated the summary of D24841: Use modern way to set the C/CXX standard.
Mon, Oct 21, 7:07 PM · Build System, Frameworks
vonreth added a comment to D24841: Use modern way to set the C/CXX standard.

I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM...

Mon, Oct 21, 7:07 PM · Build System, Frameworks
chehrlic added a comment to D24841: Use modern way to set the C/CXX standard.

I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM...

Mon, Oct 21, 7:05 PM · Build System, Frameworks
vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.

Change message

Mon, Oct 21, 7:04 PM · Build System, Frameworks
vonreth added reviewers for D24841: Use modern way to set the C/CXX standard: dfaure, cullmann.
Mon, Oct 21, 7:03 PM · Build System, Frameworks
vonreth requested review of D24841: Use modern way to set the C/CXX standard.
Mon, Oct 21, 7:02 PM · Build System, Frameworks
cullmann added a comment to D24826: Enforce 100 chars line width.

See the other task: columnlimit 0 leads to endless long lines and is a unusable default.

Mon, Oct 21, 1:04 PM · Build System, Frameworks
winterz added a comment to D24826: Enforce 100 chars line width.

I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short.

Mon, Oct 21, 1:03 PM · Build System, Frameworks
zzag added a comment to D24826: Enforce 100 chars line width.

I suggest to set ColumnLimit to 0 by default and allow projects to override it.

Mon, Oct 21, 12:55 PM · Build System, Frameworks