Build SystemOrganization
ActivePublic

Recent Activity

Sat, May 25

mgallien added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.
In D21381#469617, @apol wrote:

How about we test against both?

Sat, May 25, 9:44 AM · Build System, Frameworks
mgallien updated the diff for D21381: use org.freedesktop.appstream-glib package to validate appstream data.
  • use appstream-util and appstreamcli to validate appdata file
Sat, May 25, 9:40 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for kdebugsettings categories file.

LOGGINGCATEGORIESDIR indeed it's more specific +1 for me
debug-categories5 => indeed it's just using by kdebugsettings at the moment. => kdebugsettings-categories5 ?
no idea if it's better.

Sat, May 25, 8:08 AM · Build System, Frameworks

Fri, May 24

bcooksley added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.

Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence)
Not to mention that Flatpak is Linux only as well, while Appstream data isn't applicable to multiple platforms.

Fri, May 24, 7:30 PM · Build System, Frameworks
apol requested changes to D21381: use org.freedesktop.appstream-glib package to validate appstream data.

How about we test against both?

Fri, May 24, 7:26 PM · Build System, Frameworks
ngraham added a reviewer for D21381: use org.freedesktop.appstream-glib package to validate appstream data: apol.
Fri, May 24, 2:52 PM · Build System, Frameworks
kossebau added inline comments to D21313: Create specific directory for kdebugsettings categories file.
Fri, May 24, 2:44 PM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for kdebugsettings categories file.

Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR

Fri, May 24, 2:35 PM · Build System, Frameworks
mgallien requested review of D21381: use org.freedesktop.appstream-glib package to validate appstream data.
Fri, May 24, 1:22 PM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for kdebugsettings categories file.

Ping ?

Fri, May 24, 7:45 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for kdebugsettings categories file.

Ping ?

Fri, May 24, 5:02 AM · Build System, Frameworks

Wed, May 22

kossebau updated the summary of D20984: Add ECMAddQmlModule.
Wed, May 22, 6:05 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts

Wed, May 22, 5:51 PM · Build System, Frameworks
dfaure closed D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Wed, May 22, 7:49 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for kdebugsettings categories file.

Use DEBUGCATEGORIESDIR and debug-categories5

Wed, May 22, 4:55 AM · Build System, Frameworks

Tue, May 21

dvratil accepted D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Tue, May 21, 2:09 PM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for kdebugsettings categories file.

DEBUGCATEGORIESDIR is fine for me too

Tue, May 21, 10:58 AM · Build System, Frameworks
apol added a comment to D21314: Don't enable QT_STRICT_ITERATORS on Windows..

+1

Tue, May 21, 10:53 AM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for kdebugsettings categories file.

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

Tue, May 21, 7:52 AM · Build System, Frameworks
dfaure updated the diff for D21314: Don't enable QT_STRICT_ITERATORS on Windows..

Remove unrelated change

Tue, May 21, 7:32 AM · Build System, Frameworks
dfaure requested review of D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Tue, May 21, 7:32 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for kdebugsettings categories file.
Tue, May 21, 7:16 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for kdebugsettings categories file.

Fix comment reported by Christophe Giboudeaux

Tue, May 21, 7:08 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for kdebugsettings categories file.
Tue, May 21, 6:51 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for kdebugsettings categories file.

Forgot to commit before creating diff

Tue, May 21, 6:14 AM · Build System, Frameworks
lbeltrame added a reviewer for D21313: Create specific directory for kdebugsettings categories file: cgiboudeaux.
Tue, May 21, 5:51 AM · Build System, Frameworks
lbeltrame updated subscribers of D21313: Create specific directory for kdebugsettings categories file.
Tue, May 21, 5:50 AM · Build System, Frameworks
mlaurent added a reviewer for D21313: Create specific directory for kdebugsettings categories file: dfaure.
Tue, May 21, 5:48 AM · Build System, Frameworks
mlaurent requested review of D21313: Create specific directory for kdebugsettings categories file.
Tue, May 21, 5:48 AM · Build System, Frameworks

Fri, May 3

kossebau updated the diff for D20984: Add ECMAddQmlModule.

Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes

Fri, May 3, 4:14 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

get rid of newer list(TRANSFORM)

Fri, May 3, 1:05 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Use file(WRITE/APPEND) over file(GENERATE), for less intermediate vars

Fri, May 3, 12:58 PM · Build System, Frameworks
kossebau added a comment to D20984: Add ECMAddQmlModule.
In D20984#460128, @apol wrote:

wouldn't it be almost as complex to file(WRITE ... qmldir)? Most of the code is to construct the file.

Fri, May 3, 11:51 AM · Build System, Frameworks
apol added a comment to D20984: Add ECMAddQmlModule.

wouldn't it be almost as complex to file(WRITE ... qmldir)? Most of the code is to construct the file.

Fri, May 3, 11:21 AM · Build System, Frameworks
kossebau updated the summary of D20984: Add ECMAddQmlModule.
Fri, May 3, 9:33 AM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Add DEPENDS & DESIGNERSUPPORTED, nothing complicated there (besides going
for asking string with pair of identifier & version, to avoid any arg clash
& make parsing easier)

Fri, May 3, 9:33 AM · Build System, Frameworks
kossebau added a comment to D20984: Add ECMAddQmlModule.

Possibly the ECMGenerateQmlTypes could be also merged somehow, but I have no experience with that, so leaving to someone else to improve here.

Fri, May 3, 8:45 AM · Build System, Frameworks
kossebau requested review of D20984: Add ECMAddQmlModule.
Fri, May 3, 8:43 AM · Build System, Frameworks

Apr 17 2019

sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

well.. I couldn't get it running as a toolchain and kept running into errors.

Apr 17 2019, 4:23 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

In my case if I do this: include (Android.cmake), then it won't be able to find the ECMAndroidDeployQt.cmake because I am using android-ndk's toolchain.

Apr 17 2019, 4:08 PM · Build System, Frameworks
sh-zam closed D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 3:57 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

What does it mean that "it expects to run as a toolchain"?

Apr 17 2019, 3:55 PM · Build System, Frameworks
apol accepted D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 3:16 PM · Build System, Frameworks
sh-zam added inline comments to D20558: Bug fix: find c++ stl using regex.
Apr 17 2019, 2:51 PM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

I am building Krita and to add create-apk target I am using include (ECMAndroidDeployQt.cmake), I can't use Android.cmake because of some variables as it expects to run as a toolchain.

Apr 17 2019, 2:36 PM · Build System, Frameworks

Apr 15 2019

sh-zam updated the diff for D20558: Bug fix: find c++ stl using regex.
  • disallow whitespaces in path
Apr 15 2019, 4:53 PM · Build System, Frameworks
sh-zam added a comment to D20558: Bug fix: find c++ stl using regex.

Why are you using it without Android.cmake?

Apr 15 2019, 12:28 AM · Build System, Frameworks
sh-zam updated the diff for D20558: Bug fix: find c++ stl using regex.
  • disallow whitespaces in path
Apr 15 2019, 12:28 AM · Build System, Frameworks
sh-zam closed D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix.
Apr 15 2019, 12:13 AM · Build System, Frameworks
apol added a comment to D20558: Bug fix: find c++ stl using regex.

Can we add a cmake_minimum_required to 3.7? Regex fails to compile on older versions, when run outside of Android.cmake.

Apr 15 2019, 12:08 AM · Build System, Frameworks