tusooaw (Tusooa Windy)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 23 2018, 1:32 AM (64 w, 5 d)
Availability
Available

mew

Recent Activity

Wed, Aug 21

tusooaw added a comment to T11351: Team Page for krita.org.

I have my photo and bio here:

Wed, Aug 21, 1:18 PM · Krita

Aug 9 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

https://invent.kde.org/tusooaw/krita/commit/24355db3272a02230a14217da6023a953ec8f119

The crash does not come from KisCanvas2 but KisNode actually, as I said that it happens only when the undo command is not created (so KisNode is deleted by KisNodeReplaceBasedStrokeStrategy::Private's destructor, which is executed in the image thread (by the destructor of KisStroke)).

Ref: https://invent.kde.org/tusooaw/krita/blob/24355db3272a02230a14217da6023a953ec8f119/libs/global/kis_thread_safe_signal_compressor.h

Aug 9 2019, 7:52 AM · Krita: Next Features

Aug 2 2019

tusooaw added a comment to T10903: Instructions for building on Windows using the dependencies built by binary factory.

A more detailed guide on how to use the build script.

Aug 2 2019, 1:38 PM · Krita: Manual

Jul 26 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

The crash does not come from KisCanvas2 but KisNode actually, as I said that it happens only when the undo command is not created (so KisNode is deleted by KisNodeReplaceBasedStrokeStrategy::Private's destructor, which is executed in the image thread (by the destructor of KisStroke)).

Jul 26 2019, 3:14 AM · Krita: Next Features

Jul 25 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

On the crash upon deletion of stroke strategy without creating an undo command:

It happens only when (1) we are not using debugger (so it is probably some timing issue); (2) the mouse is released immediately after pressing; and (3) no undo command is created.

https://invent.kde.org/snippets/335 indicates that the problem probably lies in KisCanvas2, whose m_d->canvasUpdateCompressor is of type KisSignalCompressor instead of the thread-safe one.

But I did also get another error message complaining from QObject::~QObject().

Jul 25 2019, 8:22 AM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

On the crash upon deletion of stroke strategy without creating an undo command:

Jul 25 2019, 8:06 AM · Krita: Next Features

Jul 16 2019

tusooaw added a comment to T11225: Krita 4.2.2 import krita module change code.

The "builtin" Krita is an instance, while krita.Krita is a class.
One should probably use krita.Krita.instance().version() instead?

Jul 16 2019, 6:09 AM · Krita

Jul 10 2019

tusooaw committed R37:4c2bfbd39798: Explicitly initialize QSharedData in flake private classes (authored by tusooaw).
Explicitly initialize QSharedData in flake private classes
Jul 10 2019, 1:38 PM

Jul 8 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

A note on KisNode::copyFromNode():

Jul 8 2019, 1:15 PM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

Currently the methods return a KUndo2Command that will do the changes. However, it should be possible to make them only do the changes, by taking a clone of the active layer before making undoable changes to it.

Jul 8 2019, 1:07 PM · Krita: Next Features

Jul 6 2019

tusooaw committed R37:e260107274f4: Fix flake tests under asan (authored by tusooaw).
Fix flake tests under asan
Jul 6 2019, 1:48 PM
tusooaw committed R37:5cd08da74fbe: Rid KoShapeBackground hierarchy of derived d-pointers and KisSharedDescendent (authored by tusooaw).
Rid KoShapeBackground hierarchy of derived d-pointers and KisSharedDescendent
Jul 6 2019, 2:41 AM
tusooaw committed R37:048978363046: Refactor out q-pointers and derived d-pointers in Flake (authored by tusooaw).
Refactor out q-pointers and derived d-pointers in Flake
Jul 6 2019, 2:41 AM
tusooaw committed R37:ef8ee1b41921: Revert the implicit sharing of KoImageData (authored by tusooaw).
Revert the implicit sharing of KoImageData
Jul 6 2019, 2:41 AM
tusooaw committed R37:ef0c79492a11: Make KoClipMask, KoClipPath, KoImageData implicitly sharable (authored by tusooaw).
Make KoClipMask, KoClipPath, KoImageData implicitly sharable
Jul 6 2019, 2:41 AM
tusooaw committed R37:cb8345e8e4cc: Make KoShapeBackground implicitly sharable (authored by tusooaw).
Make KoShapeBackground implicitly sharable
Jul 6 2019, 2:41 AM
tusooaw committed R37:38713473a721: Use KisDescendent instead of Descendent (authored by tusooaw).
Use KisDescendent instead of Descendent
Jul 6 2019, 2:41 AM
tusooaw committed R37:3080e9f62fb1: Make KisSharedDescendent::pointerOf() return a pointer (authored by tusooaw).
Make KisSharedDescendent::pointerOf() return a pointer
Jul 6 2019, 2:41 AM
tusooaw committed R37:8bd998d9072c: Add classes KisDescendent and KisSharedDescendent (authored by tusooaw).
Add classes KisDescendent and KisSharedDescendent
Jul 6 2019, 2:41 AM
tusooaw committed R37:b84cdf8d4651: Use implicitly-shared d-pointers for KoShapeBackground heirarchy (authored by tusooaw).
Use implicitly-shared d-pointers for KoShapeBackground heirarchy
Jul 6 2019, 2:40 AM

Jun 28 2019

tusooaw committed R37:edb2c8414b8d: Fix an assert when cloning perspective assistant (authored by tusooaw).
Fix an assert when cloning perspective assistant
Jun 28 2019, 11:52 PM
tusooaw added a comment to T10901: Better undo/redo for Krita.

Refactor out q-pointers and derived d-pointers in Flake

Jun 28 2019, 9:05 AM · Krita: Next Features

Jun 26 2019

tusooaw committed R37:608ba308a6ca: Add actions and tooltips for snapshot docker (authored by tusooaw).
Add actions and tooltips for snapshot docker
Jun 26 2019, 3:02 AM

Jun 21 2019

tusooaw closed T10991: Snapshot Docker as Resolved.
Jun 21 2019, 7:16 AM · Krita: Next Features
tusooaw closed T10991: Snapshot Docker, a subtask of T10901: Better undo/redo for Krita, as Resolved.
Jun 21 2019, 7:16 AM · Krita: Next Features

Jun 20 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

Discussion on derived d-pointers.

Jun 20 2019, 9:32 AM · Krita: Next Features
tusooaw added a comment to T10901: Better undo/redo for Krita.

Discussion on q-pointers.

Jun 20 2019, 4:15 AM · Krita: Next Features

Jun 19 2019

tusooaw committed R37:b30b3b89d84f: Fix a crash when creating snapshot with no open document (authored by tusooaw).
Fix a crash when creating snapshot with no open document
Jun 19 2019, 12:22 PM

Jun 18 2019

tusooaw committed R37:7c88e8e02d23: Reuse copyFromImage() in KisImage copy-ctor (authored by tusooaw).
Reuse copyFromImage() in KisImage copy-ctor
Jun 18 2019, 1:23 PM
tusooaw committed R37:3b75498f79b9: Add new signal/slot connection syntax to KisSignalAutoConnection (authored by tusooaw).
Add new signal/slot connection syntax to KisSignalAutoConnection
Jun 18 2019, 1:23 PM
tusooaw committed R37:f1ced4cbbd11: Reuse copyFromDocument() in KisDocument copy-ctor (authored by tusooaw).
Reuse copyFromDocument() in KisDocument copy-ctor
Jun 18 2019, 1:23 PM
tusooaw committed R37:ddf6465d2a9f: Fix auto-connections in assistants decoration and palette docker (authored by tusooaw).
Fix auto-connections in assistants decoration and palette docker
Jun 18 2019, 1:23 PM
tusooaw committed R37:ddb5fb193e34: Name snapshots after KisNameServer (authored by tusooaw).
Name snapshots after KisNameServer
Jun 18 2019, 1:23 PM
tusooaw committed R37:3928c0bb6d0b: Fix layer numbers after switching snapshots (authored by tusooaw).
Fix layer numbers after switching snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:47b26d967b65: Use KisSignalAutoConnectionsStore to (dis)connect signals (authored by tusooaw).
Use KisSignalAutoConnectionsStore to (dis)connect signals
Jun 18 2019, 1:23 PM
tusooaw committed R37:778ac4fcd435: Add unit test for replacing current KisDocument (authored by tusooaw).
Add unit test for replacing current KisDocument
Jun 18 2019, 1:23 PM
tusooaw committed R37:a099679752ce: Fix assistant decorations not updated after switching snapshots (authored by tusooaw).
Fix assistant decorations not updated after switching snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:3c7443df1e59: Make items in SnapshotView editable (authored by tusooaw).
Make items in SnapshotView editable
Jun 18 2019, 1:23 PM
tusooaw committed R37:9038e32cd160: Show reference images correctly after switching snapshots (authored by tusooaw).
Show reference images correctly after switching snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:53ff60a2f9df: Switch to last activated node when switching snapshots (authored by tusooaw).
Switch to last activated node when switching snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:7e4ad33a8f55: Clear undo stack and set doc to modified after switching snapshots (authored by tusooaw).
Clear undo stack and set doc to modified after switching snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:3b37aa3d32c4: Make deep clones of palette list when creating snapshots (authored by tusooaw).
Make deep clones of palette list when creating snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:cdf99ef21264: Emit sigSizeChanged() when copying from another KisImage (authored by tusooaw).
Emit sigSizeChanged() when copying from another KisImage
Jun 18 2019, 1:23 PM
tusooaw committed R37:ca7278312d34: Implement the cloning of reference images (authored by tusooaw).
Implement the cloning of reference images
Jun 18 2019, 1:23 PM
tusooaw committed R37:bc54383d8b02: Improve the replacing of grid config and assistants (authored by tusooaw).
Improve the replacing of grid config and assistants
Jun 18 2019, 1:23 PM
tusooaw committed R37:abf8f2782fbc: Improve the mechanism for Snapshot View (authored by tusooaw).
Improve the mechanism for Snapshot View
Jun 18 2019, 1:23 PM
tusooaw committed R37:5b5eb9730f4e: Implement replacing the current KisDocument with another snapshot (authored by tusooaw).
Implement replacing the current KisDocument with another snapshot
Jun 18 2019, 1:23 PM
tusooaw committed R37:2f964c32632e: Implement the creation of snapshots (authored by tusooaw).
Implement the creation of snapshots
Jun 18 2019, 1:23 PM
tusooaw committed R37:5a9b8e73ceb3: Add snapshot docker ui (authored by tusooaw).
Add snapshot docker ui
Jun 18 2019, 1:23 PM
tusooaw updated subscribers of T10991: Snapshot Docker.
Jun 18 2019, 8:43 AM · Krita: Next Features
tusooaw added a comment to T10991: Snapshot Docker.

There is said to be delay when switching between snapshots if one uses OpenGL canvas.

Jun 18 2019, 8:42 AM · Krita: Next Features

Jun 14 2019

tusooaw added a comment to D20103: Color Slider Docker.

That's because floating point RGB colorspaces are RGB, while integer are BGR. As for KisDisplayConverter, we don't expose that to Python yet.

Jun 14 2019, 3:05 AM · Krita

Jun 13 2019

tusooaw added a comment to D20103: Color Slider Docker.

The patch works as expected :)

I have found only two minor issues:

  1. The settings dialog should use QSpinBox instead of QLineEdit
  2. [DISPUTABLE] The arrow looks as if it is offset to the top. Was it expected?

Please fix at least the first point and push the patch into master without any further review :)

Jun 13 2019, 12:55 AM · Krita

Jun 1 2019

tusooaw committed R37:af9831955068: Fixed a bug where adding a guide may create two cmds (authored by tusooaw).
Fixed a bug where adding a guide may create two cmds
Jun 1 2019, 10:58 AM
tusooaw committed R37:52533ef600d1: Change edit guides cmd to post-exec & auto-upload to doc (authored by tusooaw).
Change edit guides cmd to post-exec & auto-upload to doc
Jun 1 2019, 10:58 AM
tusooaw committed R37:3b411b2fab60: Make KisChangeGuidesCommand only change guides' location (authored by tusooaw).
Make KisChangeGuidesCommand only change guides' location
Jun 1 2019, 10:58 AM
tusooaw committed R37:3723b4c07c01: Fixed a bug on undoing removal of last assistant (authored by tusooaw).
Fixed a bug on undoing removal of last assistant
Jun 1 2019, 10:58 AM
tusooaw committed R37:e8c333a50f5d: Implement sharing for non-undoable properties of assistants (authored by tusooaw).
Implement sharing for non-undoable properties of assistants
Jun 1 2019, 10:58 AM
tusooaw committed R37:56b98b76e6cf: Create undo command for editing assistants (authored by tusooaw).
Create undo command for editing assistants
Jun 1 2019, 10:58 AM
tusooaw committed R37:c2227e690728: Implement clone() methods for KisPaintingAssistant heirarchy (authored by tusooaw).
Implement clone() methods for KisPaintingAssistant heirarchy
Jun 1 2019, 10:57 AM
tusooaw committed R37:9055dbd6e856: Give different command names for KisChangeGuidesCommands (authored by tusooaw).
Give different command names for KisChangeGuidesCommands
Jun 1 2019, 10:57 AM
tusooaw committed R37:2a3fccde53e1: Control the merging and creation of KisChangeGuidesCommand (authored by tusooaw).
Control the merging and creation of KisChangeGuidesCommand
Jun 1 2019, 10:57 AM
tusooaw committed R37:9d09954917ce: Add undo commands for adding/removing assistants (authored by tusooaw).
Add undo commands for adding/removing assistants
Jun 1 2019, 10:57 AM

May 29 2019

tusooaw added a comment to T10991: Snapshot Docker.

The branch for this task is at https://invent.kde.org/tusooaw/krita/commits/tusooaw/T10991-snapshot-docker (deleted after merging)

May 29 2019, 9:29 AM · Krita: Next Features

May 27 2019

tusooaw added a comment to T10901: Better undo/redo for Krita.

Related branch:

May 27 2019, 12:39 AM · Krita: Next Features
tusooaw created T10991: Snapshot Docker.
May 27 2019, 12:38 AM · Krita: Next Features

May 21 2019

tusooaw added a comment to T10935: Need testing for WinInk tablet support.

I'm on Surface Pro 4/Windows 10 and everything goes well except for (2):

May 21 2019, 9:52 PM · Krita: Next Features (Needs Testing)

May 20 2019

tusooaw committed R37:e2a6cdf02bdd: Fix misleading comments in kis_shared_ptr.h (authored by tusooaw).
Fix misleading comments in kis_shared_ptr.h
May 20 2019, 10:47 AM

May 17 2019

tusooaw closed T10819: Better UI for dealing with Clone Layers as Resolved.
May 17 2019, 4:40 PM · Krita: Next Features

May 16 2019

tusooaw committed R37:e0dec40401a2: Add a dialog to change the source of clone layers (authored by tusooaw).
Add a dialog to change the source of clone layers
May 16 2019, 2:04 PM

May 15 2019

tusooaw committed R954:9527f7cfb143: add tusooa (authored by tusooaw).
add tusooa
May 15 2019, 8:26 AM

May 13 2019

tusooaw added a comment to T10903: Instructions for building on Windows using the dependencies built by binary factory.

The script does not need MSYS. It only needs Perl.

May 13 2019, 6:03 PM · Krita: Manual

May 10 2019

tusooaw added a comment to T10864: Enhancing UI for Global Selection Mask.

I don't like the "autohide", because if I have a workflow of selection using painting; I would probably be happy to deselect all sometime and directly paint on a new blank selection with white. and continue working.

May 10 2019, 7:45 PM · Krita: Abyss

May 9 2019

tusooaw triaged T10903: Instructions for building on Windows using the dependencies built by binary factory as Normal priority.
May 9 2019, 2:06 AM · Krita: Manual

May 8 2019

tusooaw updated the task description for T10901: Better undo/redo for Krita.
May 8 2019, 4:45 PM · Krita: Next Features
tusooaw created T10901: Better undo/redo for Krita.
May 8 2019, 4:42 PM · Krita: Next Features

May 4 2019

tusooaw renamed T10864: Enhancing UI for Global Selection Mask from Give Users the Option to Always Show Global Selection Mask to Enhancing UI for Global Selection Mask.
May 4 2019, 1:40 AM · Krita: Abyss

Apr 30 2019

tusooaw reopened T10864: Enhancing UI for Global Selection Mask as "Open".
Apr 30 2019, 4:03 PM · Krita: Abyss
tusooaw added a comment to T10864: Enhancing UI for Global Selection Mask.

Hi, @tusooaw!

The option is already present in Krita in Selection->Show Global Selection Mask menu:

Apr 30 2019, 1:06 PM · Krita: Abyss
tusooaw added a comment to T10864: Enhancing UI for Global Selection Mask.
Apr 30 2019, 1:02 PM · Krita: Abyss

Apr 29 2019

tusooaw created T10864: Enhancing UI for Global Selection Mask.
Apr 29 2019, 11:32 PM · Krita: Abyss
tusooaw edited projects for T10819: Better UI for dealing with Clone Layers, added: Krita: Next Features; removed Krita: Abyss.
Apr 29 2019, 11:23 PM · Krita: Next Features

Apr 21 2019

tusooaw added a comment to T10819: Better UI for dealing with Clone Layers.

I have made a separate dialog for this purpose. Merging it into Layer Properties is possible, but it could possibly mess up with the ui file, since most of the properties of general layers make sense to Clone Layers (this also holds for File Layers, so actually some settings of File Layers are made more difficult to change).

Apr 21 2019, 8:32 PM · Krita: Next Features

Apr 19 2019

tusooaw updated the task description for T10819: Better UI for dealing with Clone Layers.
Apr 19 2019, 5:34 PM · Krita: Next Features
tusooaw created T10819: Better UI for dealing with Clone Layers.
Apr 19 2019, 5:27 PM · Krita: Next Features

Apr 18 2019

tusooaw added a comment to D20314: Fix for bug 397836 - undo merging a layer that is cloned.

Just an idea:

  1. Implement GUI for changing the source of the clone layer (we wanted to do that for years)
  2. When the user wants to keep the clone, he does the following:
    • presses Ctrl+G to group the merged layers
    • retargets the clone to this new group
    • merges the source layers (the clone is intact, because it is not connected to them)

      More ideas:
  3. show a dialog that "some clone layers are going to be reincarnated into paint layers"
  4. or better just show a floating message

Oh that is a good idea. I will look into it after I finish my exams.

Apr 18 2019, 3:16 PM · Krita
tusooaw updated the diff for D20314: Fix for bug 397836 - undo merging a layer that is cloned.
Apr 18 2019, 3:14 PM · Krita

Apr 15 2019

tusooaw added a comment to D20314: Fix for bug 397836 - undo merging a layer that is cloned.

Just an idea:

  1. Implement GUI for changing the source of the clone layer (we wanted to do that for years)
  2. When the user wants to keep the clone, he does the following:
    • presses Ctrl+G to group the merged layers
    • retargets the clone to this new group
    • merges the source layers (the clone is intact, because it is not connected to them)

      More ideas:
  3. show a dialog that "some clone layers are going to be reincarnated into paint layers"
  4. or better just show a floating message
Apr 15 2019, 9:40 PM · Krita

Apr 10 2019

tusooaw added inline comments to D20430: Enable/disable sub-styles on Bevel and Emboss toggle in Layer Styles (WIP).
Apr 10 2019, 12:29 PM · Krita

Apr 9 2019

tusooaw added a comment to D20314: Fix for bug 397836 - undo merging a layer that is cloned.

As a side-note: it is technically enough to just swap restoreClones() and addNode() for the purpose of preventing data loss. However, when people are merging layers, chances are they think the merged layer should "inherit" all properties of the individual layers before, including clones. This is useful since we don't seem to have ways to paste things into the current layer (they go to new layers instead).

Apr 9 2019, 6:57 PM · Krita
tusooaw updated the diff for D20314: Fix for bug 397836 - undo merging a layer that is cloned.

When we undo() the removal of a cloned layer, restore its clones first, in case that one clone is just below the source layer.

Apr 9 2019, 6:44 PM · Krita

Apr 6 2019

tusooaw updated the diff for D20314: Fix for bug 397836 - undo merging a layer that is cloned.

clear the original list in next redo

Apr 6 2019, 9:39 PM · Krita
tusooaw updated the diff for D20314: Fix for bug 397836 - undo merging a layer that is cloned.

remove redundant operations

Apr 6 2019, 7:31 PM · Krita
tusooaw requested review of D20314: Fix for bug 397836 - undo merging a layer that is cloned.
Apr 6 2019, 6:43 PM · Krita

Mar 30 2019

tusooaw added a comment to D20103: Color Slider Docker.

Closing the two inline comments as the issues are fixed.

Mar 30 2019, 11:26 PM · Krita
tusooaw added a comment to D20103: Color Slider Docker.

I just tested this and it works. I can see the use of this. What do other people think of this feature? I like how little space the docker takes. Would be neat if the "S" button had a tooltip.

Code-wise it looks good to me, except for a couple of nitpicky remarks. Btw, I'm currently working on getting all existing Python modules PEP8 compliant. I'm not expecting new submits to follow this as long as it's still a work in progress (some python plugins are already done, some aren't), but if you are interested, here's how to set up code checks: https://phabricator.kde.org/D18404

Mar 30 2019, 11:14 PM · Krita
tusooaw updated the diff for D20103: Color Slider Docker.

Simplified logic in color_to_settings()
pep8 naming
Suppressed debug output
Reduced unnecessary imports
Added tooltip for settings button

Mar 30 2019, 11:02 PM · Krita

Mar 29 2019

tusooaw added a watcher for Krita: tusooaw.
Mar 29 2019, 10:19 PM
tusooaw set the repository for D20103: Color Slider Docker to R37 Krita.
Mar 29 2019, 4:13 PM · Krita
tusooaw updated the diff for D20103: Color Slider Docker.

Rename the docker as suggested by Wolthera.
Fixed a bug where the docker could not display the left and right colors correctly if there is no config available.

Mar 29 2019, 4:10 PM · Krita