joaonetto (Joao Oliveira)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2018, 11:35 PM (27 w, 3 d)
Availability
Available

Recent Activity

Sun, Apr 14

joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

Ping on this.

Sun, Apr 14, 9:17 PM · Okular

Thu, Apr 11

joaonetto updated the task description for T8553: Improve review side panel.
Thu, Apr 11, 8:04 PM · Okular

Thu, Apr 4

joaonetto added a comment to D19123: Added option to search for whole words only.

Yes, it should. I had some oversights that I hope are fixed now.

Thu, Apr 4, 5:53 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.
  • Bug fixing. Also, fixed some things I'd not seen before
Thu, Apr 4, 5:52 PM · Okular

Wed, Apr 3

joaonetto updated the test plan for D19123: Added option to search for whole words only.
Wed, Apr 3, 3:35 AM · Okular
joaonetto added a comment to D19123: Added option to search for whole words only.

I wasn't initializing m_wholeWords in searchLineEdit, that was causing it. Hope it works now.

Wed, Apr 3, 3:33 AM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixed variable not initalized. Also, now you won't find words split with -, like Oku-\nlar

Wed, Apr 3, 3:26 AM · Okular

Wed, Mar 27

joaonetto updated the diff for D19717: Search function fails to find phrases split over two lines.

Doesn't find anything no matter what direction.

Wed, Mar 27, 12:02 AM · Okular

Tue, Mar 26

joaonetto updated the diff for D19717: Search function fails to find phrases split over two lines.
  • Well, now it proves it doesn't find anything, is this sufficient?
Tue, Mar 26, 11:57 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

Are you okay with the method?

Tue, Mar 26, 11:33 PM · Okular

Mar 21 2019

joaonetto added a watcher for Okular: joaonetto.
Mar 21 2019, 5:43 PM

Mar 14 2019

joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.
Mar 14 2019, 5:28 PM · Okular

Mar 13 2019

joaonetto added a reviewer for D19717: Search function fails to find phrases split over two lines: Okular.
Mar 13 2019, 4:17 AM · Okular
joaonetto requested review of D19717: Search function fails to find phrases split over two lines.
Mar 13 2019, 4:15 AM · Okular

Mar 12 2019

joaonetto added a comment to D18358: Add buttons to collapse and expand all elements.

Just added some screenshots with the results.

Mar 12 2019, 11:30 PM · Okular
joaonetto updated the summary of D18358: Add buttons to collapse and expand all elements.
Mar 12 2019, 11:29 PM · Okular
joaonetto updated the summary of D18358: Add buttons to collapse and expand all elements.
Mar 12 2019, 10:54 PM · Okular
joaonetto updated the diff for D18358: Add buttons to collapse and expand all elements.

Updated with new icons, should use latest breeze-icons. Also fixed typo

Mar 12 2019, 10:53 PM · Okular

Mar 10 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

Ping

Mar 10 2019, 11:52 AM · Okular

Mar 6 2019

joaonetto added a comment to D18358: Add buttons to collapse and expand all elements.

We're waiting for icons, but I just heard not 5 minutes ago that they're in progress, in fact.

Mar 6 2019, 8:25 PM · Okular

Mar 3 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

I think it has most cases covered, I added a lot of tests which reflect on the new changes.
I'll wait on feedback.

Mar 3 2019, 5:45 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Mar 3 2019, 5:39 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixed word being in the same textEntity and added some new tests.

Mar 3 2019, 5:38 PM · Okular

Mar 2 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

This works properly for most cases, but still, it has some limitations.
If searching for r on a text, and the text contains R$, the R will be found.
Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
I guess that's a good trade-off, but we can work to improve it, if wanted.

This sounds optimal to me, not like a trade-off. Or how could it be improved?

By requiring whitespace on both sides, BAUD would not find USART0.BAUD, and argv would not find char *argv[].

Mar 2 2019, 12:43 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Mar 2 2019, 10:49 AM · Okular

Feb 27 2019

joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixed typo

Feb 27 2019, 1:33 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Feb 27 2019, 2:43 AM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Removed useless code, remodeled tests and fixed corner case

Feb 27 2019, 2:35 AM · Okular

Feb 23 2019

joaonetto updated the diff for D19123: Added option to search for whole words only.

Added some tests to validate the diff, and fixed a bug.

Feb 23 2019, 8:48 PM · Okular

Feb 22 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

If I understood well, this should fix the binary compability issues.

Feb 22 2019, 7:19 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixing binary compability issues

Feb 22 2019, 7:18 PM · Okular

Feb 18 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

I'll fix the binary compatibility issues, I didn't know it would break it.

Feb 18 2019, 10:43 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Feb 18 2019, 10:40 PM · Okular
joaonetto added a comment to D19123: Added option to search for whole words only.

This works properly for most cases, but still, it has some limitations.
If searching for r on a text, and the text contains R$, the R will be found.
Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
I guess that's a good trade-off, but we can work to improve it, if wanted.

Feb 18 2019, 6:33 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Updated comment on SearchText

Feb 18 2019, 6:30 PM · Okular
joaonetto added a reviewer for D19123: Added option to search for whole words only: Okular.
Feb 18 2019, 6:26 PM · Okular
joaonetto requested review of D19123: Added option to search for whole words only.
Feb 18 2019, 6:25 PM · Okular

Feb 14 2019

joaonetto added a reviewer for D18358: Add buttons to collapse and expand all elements: VDG.
Feb 14 2019, 1:40 PM · Okular

Feb 13 2019

joaonetto updated the summary of D18358: Add buttons to collapse and expand all elements.
Feb 13 2019, 11:44 PM · Okular

Feb 8 2019

joaonetto added a comment to D18144: Implemented find function from console.

It seems I can't get the text on the findBar widget, so I can't test if the text there is equivalent to the intended.
If it was found or not is not imperative to the test, since this is tested on the searchtext.cpp

Feb 8 2019, 11:07 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Added two tests.
First one tests if the findBar was opened and second tests the decryption

Feb 8 2019, 11:04 PM · Okular

Feb 7 2019

joaonetto added a comment to D18144: Implemented find function from console.

I don't know a lot about autotests, therefore I'm not so sure that it is implemented correctly. I can implement it, but I would need some assistance.

Feb 7 2019, 12:12 AM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Changed decrypt to shellUtils. Implemented a test

Feb 7 2019, 12:10 AM · Okular

Feb 3 2019

joaonetto updated the diff for D18144: Implemented find function from console.

Changed find String to a encrypted base64 string.

Feb 3 2019, 8:34 PM · Okular

Jan 29 2019

joaonetto added a comment to D18144: Implemented find function from console.

Ping

Jan 29 2019, 10:00 AM · Okular

Jan 18 2019

joaonetto abandoned D18238: Implements a new button on findbar that allows users to choose the color that highlights the text.

There's better solutions than adding a new button, closing it.

Jan 18 2019, 6:14 PM · Okular
joaonetto abandoned D18283: Auto-expand all tree elements in the side panel when the panel is first shown.

As discussed in T8553, a button that does this would be more suitable.

Jan 18 2019, 1:05 PM · Okular
joaonetto requested review of D18358: Add buttons to collapse and expand all elements.
Jan 18 2019, 1:04 PM · Okular

Jan 17 2019

joaonetto added a comment to T8553: Improve review side panel.

Tried some icons that come with KDE. We can't have the arrow down one since it's already used in page.

Jan 17 2019, 5:39 PM · Okular
joaonetto added a comment to T8553: Improve review side panel.

On the right side, like this would be good? If it is, I just have to get the right icons for it.
Left one expands, right one collapses all.

Jan 17 2019, 3:52 PM · Okular
joaonetto added a comment to T8553: Improve review side panel.

Point 2:
If we had the "Expand/Collapse all" elements button, is this still necessary?
You could expand it at your will.

Jan 17 2019, 12:40 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Fixed bug when searching for strings with : and some cleanup

Jan 17 2019, 3:56 AM · Okular

Jan 16 2019

joaonetto added a comment to D18238: Implements a new button on findbar that allows users to choose the color that highlights the text.

There's some people asking for it on bugzilla, to change the search highlight color, but as Nate said, no other reader does this.

Jan 16 2019, 12:11 AM · Okular

Jan 15 2019

joaonetto updated the diff for D18283: Auto-expand all tree elements in the side panel when the panel is first shown.

Updated files

Jan 15 2019, 11:12 PM · Okular
joaonetto added a comment to D18283: Auto-expand all tree elements in the side panel when the panel is first shown.

Fixing it, other files went in.

Jan 15 2019, 11:08 PM · Okular
joaonetto requested review of D18283: Auto-expand all tree elements in the side panel when the panel is first shown.
Jan 15 2019, 11:04 PM · Okular
joaonetto added a comment to T8553: Improve review side panel.

I have a lot of free time as of now, and for the next month. I'm having fun tinkering with the source code, so I try to help as much as I can.

Jan 15 2019, 10:58 PM · Okular
joaonetto added a comment to T8553: Improve review side panel.

I would like to work on tasks of this list if you don't mind.

Jan 15 2019, 3:34 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Code cleanup, only important parts should be changed

Jan 15 2019, 12:05 AM · Okular

Jan 14 2019

joaonetto updated the diff for D18144: Implemented find function from console.

Deleted signal, now I call the function after the file has been open

Jan 14 2019, 11:55 PM · Okular
joaonetto added a comment to D18238: Implements a new button on findbar that allows users to choose the color that highlights the text.

I'm okay in discarding it.

Jan 14 2019, 9:51 PM · Okular
joaonetto added a reviewer for D18238: Implements a new button on findbar that allows users to choose the color that highlights the text: Okular.
Jan 14 2019, 12:46 PM · Okular
joaonetto requested review of D18238: Implements a new button on findbar that allows users to choose the color that highlights the text.
Jan 14 2019, 7:42 AM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Not initializing the variable was causing crashes. Fixed it

Jan 14 2019, 2:05 AM · Okular

Jan 12 2019

joaonetto updated the diff for D18144: Implemented find function from console.

Changed variable names and deleted QString after use

Jan 12 2019, 7:34 PM · Okular
joaonetto added inline comments to D18144: Implemented find function from console.
Jan 12 2019, 6:40 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Deleted remains and formatting issues

Jan 12 2019, 1:20 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Made changes that allows file to be searched only when loaded

Jan 12 2019, 1:17 PM · Okular

Jan 11 2019

joaonetto added a comment to D18144: Implemented find function from console.

It seems that it tries to search before copying the file, so I'm searching an empty string. Let me see what I can do to improve that. Maybe wait until the document is completely copied?

Jan 11 2019, 10:43 PM · Okular

Jan 10 2019

joaonetto updated the diff for D18144: Implemented find function from console.

Changed the code so I no longer use query.

Jan 10 2019, 10:36 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

one last change to avoid repeating code. I guess it's ready to land, just need a reviewer.

Jan 10 2019, 7:48 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Using command find from terminal now opens FindBar

Jan 10 2019, 7:41 PM · Okular
joaonetto added a comment to D18144: Implemented find function from console.

Tried that, not possible, it gets me compilation error.

Jan 10 2019, 3:29 PM · Okular
joaonetto added a reviewer for D18144: Implemented find function from console: Okular.
Jan 10 2019, 2:03 PM · Okular
joaonetto added inline comments to D18144: Implemented find function from console.
Jan 10 2019, 12:04 AM · Okular

Jan 9 2019

joaonetto updated the diff for D18144: Implemented find function from console.

Deleted iostream used in main for debugging

Jan 9 2019, 11:59 PM · Okular
joaonetto requested review of D18144: Implemented find function from console.
Jan 9 2019, 11:56 PM · Okular

Dec 6 2018

joaonetto added a comment to D17368: Fixed bug that crashed program when clicking Forecast->Chart.

I can't land or commit to repository since I'm not a KDE dev.

Dec 6 2018, 10:39 AM

Dec 5 2018

joaonetto updated the diff for D17368: Fixed bug that crashed program when clicking Forecast->Chart.

QString should be const, fixed it.

Dec 5 2018, 10:32 PM
joaonetto added a reviewer for D17368: Fixed bug that crashed program when clicking Forecast->Chart: KMyMoney.
Dec 5 2018, 10:09 PM
joaonetto updated the diff for D17368: Fixed bug that crashed program when clicking Forecast->Chart.

Forgot to delete debug options. Updated it

Dec 5 2018, 1:46 PM
joaonetto requested review of D17368: Fixed bug that crashed program when clicking Forecast->Chart.
Dec 5 2018, 1:42 PM

Nov 6 2018

joaonetto added a comment to D16684: Updated with petroleum industry units.

Done, can land now

Nov 6 2018, 8:48 AM · Frameworks
joaonetto updated the summary of D16684: Updated with petroleum industry units.
Nov 6 2018, 8:47 AM · Frameworks

Nov 5 2018

joaonetto updated the diff for D16684: Updated with petroleum industry units.
Nov 5 2018, 4:16 PM · Frameworks
joaonetto updated the diff for D16684: Updated with petroleum industry units.

permeability.h renamed to permeability_p.h and change Darcy to start at 33000

Nov 5 2018, 4:15 PM · Frameworks
joaonetto updated the diff for D16684: Updated with petroleum industry units.

Reviewed with comments made on this diff.

Nov 5 2018, 3:52 PM · Frameworks
joaonetto abandoned D16681: Updated with petroleum industry units.
Nov 5 2018, 1:41 PM · Frameworks
joaonetto updated the diff for D16684: Updated with petroleum industry units.

Couldn't update D16681, creating new revision

Nov 5 2018, 1:41 PM · Frameworks
joaonetto abandoned D16684: Updated with petroleum industry units.
Nov 5 2018, 1:38 PM · Frameworks
joaonetto updated the diff for D16684: Updated with petroleum industry units.

Updated with permeability source code

Nov 5 2018, 1:38 PM · Frameworks
joaonetto abandoned D16684: Updated with petroleum industry units.
Nov 5 2018, 1:36 PM · Frameworks
joaonetto updated the diff for D16684: Updated with petroleum industry units.
  • Updated source code with permeability class
Nov 5 2018, 1:35 PM · Frameworks
joaonetto abandoned D16684: Updated with petroleum industry units.
Nov 5 2018, 1:22 PM · Frameworks
joaonetto requested review of D16684: Updated with petroleum industry units.
Nov 5 2018, 1:22 PM · Frameworks
joaonetto updated the summary of D16681: Updated with petroleum industry units.
Nov 5 2018, 1:18 PM · Frameworks
joaonetto updated the diff for D16681: Updated with petroleum industry units.

Updating D16681: Updated with petroleum industry units

Nov 5 2018, 1:16 PM · Frameworks
joaonetto requested review of D16681: Updated with petroleum industry units.
Nov 5 2018, 12:59 PM · Frameworks

Oct 11 2018

joaonetto removed a watcher for Elisa: joaonetto.
Oct 11 2018, 9:10 PM
joaonetto added a watcher for Elisa: joaonetto.
Oct 11 2018, 11:17 AM