joaonetto (Joao Oliveira)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2018, 11:35 PM (44 w, 6 d)
Availability
Available

Recent Activity

Thu, Aug 15

joaonetto committed R223:3eb6a91e2536: Changed util.printd to use the default locale on case 2. Also made… (authored by joaonetto).
Changed util.printd to use the default locale on case 2. Also made…
Thu, Aug 15, 10:10 PM
joaonetto committed R223:a7845890b32a: Changed tests to use QTest interface, with QTest::newRow and column (authored by joaonetto).
Changed tests to use QTest interface, with QTest::newRow and column
Thu, Aug 15, 2:56 PM

Wed, Aug 14

joaonetto committed R223:24fc9defe34b: Changed AFTime_Format to work with user locale PM strings (authored by joaonetto).
Changed AFTime_Format to work with user locale PM strings
Wed, Aug 14, 10:10 PM
joaonetto committed R223:f54d65ca86f9: Changed util.printd to work with the default locale set on QLocale::setDefault… (authored by joaonetto).
Changed util.printd to work with the default locale set on QLocale::setDefault…
Wed, Aug 14, 10:10 PM

Mon, Aug 12

joaonetto committed R223:c7432cdae68b: Implemented support for AFSpecial_Format and AFSpecial_Keystroke (authored by joaonetto).
Implemented support for AFSpecial_Format and AFSpecial_Keystroke
Mon, Aug 12, 11:11 PM
joaonetto committed R223:052662d78d67: Implemented support for AFTime_Format and AFTime_Keystroke (authored by joaonetto).
Implemented support for AFTime_Format and AFTime_Keystroke
Mon, Aug 12, 2:29 PM

Jun 26 2019

joaonetto committed R954:3bc83bebd162: Added my blog to KDE Planet (authored by joaonetto).
Added my blog to KDE Planet
Jun 26 2019, 1:09 PM

Jun 14 2019

joaonetto added a comment to R223:a262fa194d18: Install in new logging directory when we use kf5 5.59.0.

This commit breaks my compiling environment with kdesrc-build.

Jun 14 2019, 4:15 PM

Jun 6 2019

joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Implemented buttonGetIcon and buttonSetIcon

Jun 6 2019, 12:56 PM · Okular
joaonetto committed R223:c00fbccf1b72: Added support for buttonSetIcon and buttonGetIcon. (authored by joaonetto).
Added support for buttonSetIcon and buttonGetIcon.
Jun 6 2019, 12:47 PM

Jun 4 2019

joaonetto committed R223:e12151ada980: Make selection scrolling go at 60 fps (authored by Kezi Olio <keziolio123@gmail.com>).
Make selection scrolling go at 60 fps
Jun 4 2019, 6:05 PM
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Updated with the code against master

Jun 4 2019, 1:38 AM · Okular
joaonetto reopened D21202: [WIP] Support animated PDF.

Wasn't supposed to be closed. It closed with a wrong commit on my side branch.

Jun 4 2019, 1:35 AM · Okular
joaonetto committed R223:5f324e583e98: Updated copyright with the right one (authored by joaonetto).
Updated copyright with the right one
Jun 4 2019, 1:33 AM
joaonetto committed R223:a3628c1f97e9: Revert "mend" (authored by joaonetto).
Revert "mend"
Jun 4 2019, 1:31 AM
joaonetto closed D21202: [WIP] Support animated PDF.
Jun 4 2019, 1:31 AM · Okular
joaonetto committed R223:919f056953f1: mend (authored by joaonetto).
mend
Jun 4 2019, 12:56 AM
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Changed button code to be transparent when there's no text.

Jun 4 2019, 12:51 AM · Okular
joaonetto committed R223:52c227ccb83d: Changed button code to be transparent when there's no text. (authored by joaonetto).
Changed button code to be transparent when there's no text.
Jun 4 2019, 12:47 AM

Jun 3 2019

joaonetto updated the test plan for D21202: [WIP] Support animated PDF.
Jun 3 2019, 1:03 AM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Updated Diff to track changes based on master

Jun 3 2019, 1:01 AM · Okular

Jun 1 2019

joaonetto updated the test plan for D21202: [WIP] Support animated PDF.
Jun 1 2019, 3:02 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Updating revision to match the current branch

Jun 1 2019, 2:59 PM · Okular
joaonetto committed R223:b009a1bf2c7c: Implemented more unit tests to cover the OCGs (authored by joaonetto).
Implemented more unit tests to cover the OCGs
Jun 1 2019, 2:28 PM

May 31 2019

joaonetto committed R223:70e3898224de: Implemented the getOCGs and OCGs methods to support layer changing by… (authored by joaonetto).
Implemented the getOCGs and OCGs methods to support layer changing by…
May 31 2019, 8:15 PM

May 30 2019

joaonetto committed R223:ece492dab82a: Implemented unit tests to the JavaScript functions. (authored by joaonetto).
Implemented unit tests to the JavaScript functions.
May 30 2019, 1:40 PM

May 28 2019

joaonetto committed R223:61d32c815992: When refreshing, widgets must check if they should be visible (authored by joaonetto).
When refreshing, widgets must check if they should be visible
May 28 2019, 11:15 AM

May 27 2019

joaonetto committed R223:a8a5e7a49489: Revert "Reverted commentary." (authored by joaonetto).
Revert "Reverted commentary."
May 27 2019, 10:25 PM
joaonetto added a reverting change for R223:a156c19053f6: Reverted commentary.: R223:a8a5e7a49489: Revert "Reverted commentary.".
May 27 2019, 10:25 PM
joaonetto committed R223:a156c19053f6: Reverted commentary. (authored by joaonetto).
Reverted commentary.
May 27 2019, 4:14 PM
joaonetto added inline comments to R223:a234a902dcff: Implement digital signature support for PDF.
May 27 2019, 3:46 PM
joaonetto added inline comments to R223:a234a902dcff: Implement digital signature support for PDF.
May 27 2019, 3:07 PM

May 23 2019

joaonetto committed R223:0e02d4617a6f: Implemented initial support for animatedPDF (authored by joaonetto).
Implemented initial support for animatedPDF
May 23 2019, 1:38 PM

May 22 2019

joaonetto added a comment to D21320: Fix build with poppler < 0.51.

This broke the compilation process on my machine. I just tested with a clean version of KDE Neon, Poppler 0.62, and it doesn't compile, something about FormFieldsSignatures.

May 22 2019, 8:14 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Documentation and fixing spaces

May 22 2019, 5:16 PM · Okular
joaonetto updated the test plan for D21202: [WIP] Support animated PDF.
May 22 2019, 5:11 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Implemented setInterval/clearInterval. WidgetScripts are now supported on pageOpening/Closing.

May 22 2019, 5:09 PM · Okular

May 16 2019

joaonetto added a comment to D21202: [WIP] Support animated PDF.

Do you have some files that exercise this?

Who would we autotest this?

May 16 2019, 8:58 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Declared g_displayProto as std::unique_ptr

May 16 2019, 12:00 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Remove unintentionally left qDebug()

May 16 2019, 11:47 AM · Okular
joaonetto added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 11:42 AM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Loops now use const and more efficient way of acessing LinkedList

May 16 2019, 11:41 AM · Okular

May 15 2019

joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Removed useless iterator

May 15 2019, 10:19 PM · Okular

May 14 2019

joaonetto updated the summary of D21202: [WIP] Support animated PDF.
May 14 2019, 1:36 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Changed for to range based loops

May 14 2019, 1:32 PM · Okular
joaonetto updated the diff for D21202: [WIP] Support animated PDF.

Fixed copyright

May 14 2019, 12:05 AM · Okular

May 13 2019

joaonetto added reviewers for D21202: [WIP] Support animated PDF: aacid, Okular.
May 13 2019, 11:56 PM · Okular
joaonetto requested review of D21202: [WIP] Support animated PDF.
May 13 2019, 11:56 PM · Okular

May 2 2019

joaonetto added inline comments to D19123: Added option to search for whole words only.
May 2 2019, 5:36 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Added documentation

May 2 2019, 5:34 PM · Okular

Apr 22 2019

joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

Hmmmmm. I can think of checking if the '\n' is in the search bar.

Apr 22 2019, 10:56 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

It probably will work, I'll try it

Apr 22 2019, 6:53 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.
Apr 22 2019, 5:57 PM · Okular
joaonetto updated the diff for D19717: Search function fails to find phrases split over two lines.

Made the necessary changes to work with any type of space.

Apr 22 2019, 5:55 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D

Opinions?

The use case to insert a newline could be:
Someone is testing a LaTeX document, and searches for a passage from the source code (maybe some verbatim code).
One would just copy the passage in Kate and paste it into the search box in Okular.

Apr 22 2019, 1:16 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

In my opinion is better to have it this way, I guess most users don't know about the newline.

Apr 22 2019, 11:46 AM · Okular

Apr 14 2019

joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

Ping on this.

Apr 14 2019, 9:17 PM · Okular

Apr 11 2019

joaonetto updated the task description for T8553: Improve review side panel.
Apr 11 2019, 8:04 PM · Okular

Apr 4 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

Yes, it should. I had some oversights that I hope are fixed now.

Apr 4 2019, 5:53 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.
  • Bug fixing. Also, fixed some things I'd not seen before
Apr 4 2019, 5:52 PM · Okular

Apr 3 2019

joaonetto updated the test plan for D19123: Added option to search for whole words only.
Apr 3 2019, 3:35 AM · Okular
joaonetto added a comment to D19123: Added option to search for whole words only.

I wasn't initializing m_wholeWords in searchLineEdit, that was causing it. Hope it works now.

Apr 3 2019, 3:33 AM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixed variable not initalized. Also, now you won't find words split with -, like Oku-\nlar

Apr 3 2019, 3:26 AM · Okular

Mar 27 2019

joaonetto updated the diff for D19717: Search function fails to find phrases split over two lines.

Doesn't find anything no matter what direction.

Mar 27 2019, 12:02 AM · Okular

Mar 26 2019

joaonetto updated the diff for D19717: Search function fails to find phrases split over two lines.
  • Well, now it proves it doesn't find anything, is this sufficient?

It shouldn't find anything, and it doesn't.
If not, I'll take a deeper look when I get home, this was just a top of my head solution.

Mar 26 2019, 11:57 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

Are you okay with the method?

Mar 26 2019, 11:33 PM · Okular

Mar 21 2019

joaonetto added a watcher for Okular: joaonetto.
Mar 21 2019, 5:43 PM

Mar 14 2019

joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.
Mar 14 2019, 5:28 PM · Okular

Mar 13 2019

joaonetto added a reviewer for D19717: Search function fails to find phrases split over two lines: Okular.
Mar 13 2019, 4:17 AM · Okular
joaonetto requested review of D19717: Search function fails to find phrases split over two lines.
Mar 13 2019, 4:15 AM · Okular

Mar 12 2019

joaonetto added a comment to D18358: Add buttons to collapse and expand all elements.

Just added some screenshots with the results.

Mar 12 2019, 11:30 PM · Okular
joaonetto updated the summary of D18358: Add buttons to collapse and expand all elements.
Mar 12 2019, 11:29 PM · Okular
joaonetto updated the summary of D18358: Add buttons to collapse and expand all elements.
Mar 12 2019, 10:54 PM · Okular
joaonetto updated the diff for D18358: Add buttons to collapse and expand all elements.

Updated with new icons, should use latest breeze-icons. Also fixed typo

Mar 12 2019, 10:53 PM · Okular

Mar 10 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

Ping

Mar 10 2019, 11:52 AM · Okular

Mar 6 2019

joaonetto added a comment to D18358: Add buttons to collapse and expand all elements.

We're waiting for icons, but I just heard not 5 minutes ago that they're in progress, in fact.

Mar 6 2019, 8:25 PM · Okular

Mar 3 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

I think it has most cases covered, I added a lot of tests which reflect on the new changes.
I'll wait on feedback.

Mar 3 2019, 5:45 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Mar 3 2019, 5:39 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixed word being in the same textEntity and added some new tests.

Mar 3 2019, 5:38 PM · Okular

Mar 2 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

This works properly for most cases, but still, it has some limitations.
If searching for r on a text, and the text contains R$, the R will be found.
Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
I guess that's a good trade-off, but we can work to improve it, if wanted.

This sounds optimal to me, not like a trade-off. Or how could it be improved?

By requiring whitespace on both sides, BAUD would not find USART0.BAUD, and argv would not find char *argv[].

Mar 2 2019, 12:43 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Mar 2 2019, 10:49 AM · Okular

Feb 27 2019

joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixed typo

Feb 27 2019, 1:33 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Feb 27 2019, 2:43 AM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Removed useless code, remodeled tests and fixed corner case

Feb 27 2019, 2:35 AM · Okular

Feb 23 2019

joaonetto updated the diff for D19123: Added option to search for whole words only.

Added some tests to validate the diff, and fixed a bug.

Feb 23 2019, 8:48 PM · Okular

Feb 22 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

If I understood well, this should fix the binary compability issues.

Feb 22 2019, 7:19 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Fixing binary compability issues

Feb 22 2019, 7:18 PM · Okular

Feb 18 2019

joaonetto added a comment to D19123: Added option to search for whole words only.

I'll fix the binary compatibility issues, I didn't know it would break it.

Feb 18 2019, 10:43 PM · Okular
joaonetto updated the summary of D19123: Added option to search for whole words only.
Feb 18 2019, 10:40 PM · Okular
joaonetto added a comment to D19123: Added option to search for whole words only.

This works properly for most cases, but still, it has some limitations.
If searching for r on a text, and the text contains R$, the R will be found.
Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
I guess that's a good trade-off, but we can work to improve it, if wanted.

Feb 18 2019, 6:33 PM · Okular
joaonetto updated the diff for D19123: Added option to search for whole words only.

Updated comment on SearchText

Feb 18 2019, 6:30 PM · Okular
joaonetto added a reviewer for D19123: Added option to search for whole words only: Okular.
Feb 18 2019, 6:26 PM · Okular
joaonetto requested review of D19123: Added option to search for whole words only.
Feb 18 2019, 6:25 PM · Okular

Feb 14 2019

joaonetto added a reviewer for D18358: Add buttons to collapse and expand all elements: VDG.
Feb 14 2019, 1:40 PM · Okular

Feb 13 2019

joaonetto updated the summary of D18358: Add buttons to collapse and expand all elements.
Feb 13 2019, 11:44 PM · Okular

Feb 8 2019

joaonetto added a comment to D18144: Implemented find function from console.

It seems I can't get the text on the findBar widget, so I can't test if the text there is equivalent to the intended.
If it was found or not is not imperative to the test, since this is tested on the searchtext.cpp

Feb 8 2019, 11:07 PM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Added two tests.
First one tests if the findBar was opened and second tests the decryption

Feb 8 2019, 11:04 PM · Okular

Feb 7 2019

joaonetto added a comment to D18144: Implemented find function from console.

I don't know a lot about autotests, therefore I'm not so sure that it is implemented correctly. I can implement it, but I would need some assistance.

Feb 7 2019, 12:12 AM · Okular
joaonetto updated the diff for D18144: Implemented find function from console.

Changed decrypt to shellUtils. Implemented a test

Feb 7 2019, 12:10 AM · Okular

Feb 3 2019

joaonetto updated the diff for D18144: Implemented find function from console.

Changed find String to a encrypted base64 string.

Feb 3 2019, 8:34 PM · Okular