- User Since
- Oct 10 2018, 11:35 PM (35 w, 4 d)
Fri, Jun 14
This commit breaks my compiling environment with kdesrc-build.
Thu, Jun 6
Implemented buttonGetIcon and buttonSetIcon
Tue, Jun 4
Updated with the code against master
Wasn't supposed to be closed. It closed with a wrong commit on my side branch.
Changed button code to be transparent when there's no text.
Mon, Jun 3
Updated Diff to track changes based on master
Sat, Jun 1
Updating revision to match the current branch
Fri, May 31
Thu, May 30
Tue, May 28
Mon, May 27
Thu, May 23
Wed, May 22
This broke the compilation process on my machine. I just tested with a clean version of KDE Neon, Poppler 0.62, and it doesn't compile, something about FormFieldsSignatures.
Documentation and fixing spaces
Implemented setInterval/clearInterval. WidgetScripts are now supported on pageOpening/Closing.
May 16 2019
Declared g_displayProto as std::unique_ptr
Remove unintentionally left qDebug()
Loops now use const and more efficient way of acessing LinkedList
May 15 2019
Removed useless iterator
May 14 2019
Changed for to range based loops
May 13 2019
May 2 2019
Apr 22 2019
Hmmmmm. I can think of checking if the '\n' is in the search bar.
It probably will work, I'll try it
Made the necessary changes to work with any type of space.
In my opinion is better to have it this way, I guess most users don't know about the newline.
Apr 14 2019
Ping on this.
Apr 11 2019
Apr 4 2019
Yes, it should. I had some oversights that I hope are fixed now.
- Bug fixing. Also, fixed some things I'd not seen before
Apr 3 2019
I wasn't initializing m_wholeWords in searchLineEdit, that was causing it. Hope it works now.
Fixed variable not initalized. Also, now you won't find words split with -, like Oku-\nlar
Mar 27 2019
Doesn't find anything no matter what direction.
Mar 26 2019
- Well, now it proves it doesn't find anything, is this sufficient?
It shouldn't find anything, and it doesn't.
If not, I'll take a deeper look when I get home, this was just a top of my head solution.
Are you okay with the method?
Mar 21 2019
Mar 14 2019
Mar 13 2019
Mar 12 2019
Just added some screenshots with the results.
Updated with new icons, should use latest breeze-icons. Also fixed typo
Mar 10 2019
Mar 6 2019
Mar 3 2019
I think it has most cases covered, I added a lot of tests which reflect on the new changes.
I'll wait on feedback.
Fixed word being in the same textEntity and added some new tests.
Mar 2 2019
Feb 27 2019
Removed useless code, remodeled tests and fixed corner case
Feb 23 2019
Added some tests to validate the diff, and fixed a bug.
Feb 22 2019
If I understood well, this should fix the binary compability issues.
Fixing binary compability issues
Feb 18 2019
I'll fix the binary compatibility issues, I didn't know it would break it.
This works properly for most cases, but still, it has some limitations.
If searching for r on a text, and the text contains R$, the R will be found.
Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
I guess that's a good trade-off, but we can work to improve it, if wanted.
Updated comment on SearchText
Feb 14 2019
Feb 13 2019
Feb 8 2019
It seems I can't get the text on the findBar widget, so I can't test if the text there is equivalent to the intended.
If it was found or not is not imperative to the test, since this is tested on the searchtext.cpp
Added two tests.
First one tests if the findBar was opened and second tests the decryption
Feb 7 2019
I don't know a lot about autotests, therefore I'm not so sure that it is implemented correctly. I can implement it, but I would need some assistance.
Changed decrypt to shellUtils. Implemented a test
Feb 3 2019
Changed find String to a encrypted base64 string.
Jan 29 2019
Jan 18 2019
There's better solutions than adding a new button, closing it.
As discussed in T8553, a button that does this would be more suitable.
Jan 17 2019
Tried some icons that come with KDE. We can't have the arrow down one since it's already used in page.
On the right side, like this would be good? If it is, I just have to get the right icons for it.
Left one expands, right one collapses all.