Details

Reviewers

Group Reviewers

Commits

Summary

Implemented the unit tests and the functions needed for the JavaScript to work.

The buttons along with the animations are now working, but still have a grey field above them since I can only use them when I click "Show Forms". I'll tackle them next.

Test Plan

Open this file:
http://www.texample.net/media/tikz/examples/PDF/animated-set-intersection.pdf
Any animations on this:
http://www.texample.net/tikz/examples/tag/animations/
should work, including the one with buttons.

Diff Detail

Repository

R223 Okular

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12475
Build 12493: arc lint + arc unit

joaonetto created this revision.May 13 2019, 11:56 PM

Restricted Application added a project: Okular. · View Herald TranscriptMay 13 2019, 11:56 PM

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

joaonetto requested review of this revision.May 13 2019, 11:56 PM

Harbormaster completed remote builds in B11811: Diff 58042.May 13 2019, 11:56 PM

joaonetto added reviewers: aacid, Okular.May 13 2019, 11:56 PM

Fixed copyright

Harbormaster completed remote builds in B11812: Diff 58043.May 14 2019, 12:05 AM

sander added a subscriber: sander.May 14 2019, 3:56 AM

sander added inline comments.

core/script/kjs_document.cpp
276	Please use a range-based for loop.

Changed for to range based loops

Harbormaster completed remote builds in B11829: Diff 58077.May 14 2019, 1:32 PM

joaonetto edited the summary of this revision. (Show Details)May 14 2019, 1:36 PM

aacid added inline comments.May 15 2019, 10:06 PM

core/script/kjs_document.cpp
138	you don't need this anymore?

Removed useless iterator

Harbormaster completed remote builds in B11871: Diff 58154.May 15 2019, 10:19 PM

sander added inline comments.May 16 2019, 4:53 AM

core/script/kjs_document.cpp
140	As you were using const iterators before: Shouldn't this be `qAsConst(doc->m_pagesVector)` to avoid unnecessary detaching?
143	Why not simply `numFields += pIt->formFields()` ?

anthonyfieroni added a subscriber: anthonyfieroni.May 16 2019, 5:54 AM

anthonyfieroni added inline comments.

core/script/kjs_display.cpp
20	use unique_ptr
36–39	if (g_displayProto) return;
41	g_displayProto.reset(new KJSPrototype);

pino added a subscriber: pino.May 16 2019, 6:27 AM

pino added inline comments.

core/script/kjs_document.cpp
275–286	This convoluted for loop basically get the i-th element of a QLinkedList, which is not designed for index accessing (and that is why there is no at(int) method). IMHO a better way is: get the list of form fields compare the wanted index with the count of the form fields: if it is out of boundaries, return KJSUndefined directly otherwise, create an iterator fromthe begin, and increment it by the wanted index to get to the wanted element

Loops now use const and more efficient way of acessing LinkedList

Harbormaster completed remote builds in B11875: Diff 58162.May 16 2019, 11:41 AM

joaonetto added inline comments.May 16 2019, 11:42 AM

core/script/kjs_display.cpp
20	Are we talking about the std::unique_ptr? I followed the template in the other classes, why should we use unique_ptr?
36–39	Then we get rid of the initialized bool?
41	And this does not compile
core/script/kjs_document.cpp
275–286	I still have to check for all the pages. But my new implementation looks more like with what you described

anthonyfieroni added inline comments.May 16 2019, 11:45 AM

core/script/kjs_display.cpp
36–39	Yep, also unique_ptr will clear the allocated memory, if you run valgrind, it will point a leak which is not good.

Remove unintentionally left qDebug()

Harbormaster completed remote builds in B11876: Diff 58163.May 16 2019, 11:47 AM

Declared g_displayProto as std::unique_ptr

Harbormaster completed remote builds in B11878: Diff 58165.May 16 2019, 12:00 PM

sander added inline comments.May 16 2019, 12:50 PM

core/script/kjs_display.cpp
41	`g_displayProto` needs to be a `std::unique_ptr` for this to compile.

Do you have some files that exercise this?

Who would we autotest this?

In D21202#466066, @aacid wrote:

Do you have some files that exercise this?

Who would we autotest this?

I intend to test this when all the functions needed to work are implemented.

Or would you like a test for every function?

In D21202#466067, @joaonetto wrote:

In D21202#466066, @aacid wrote:

Do you have some files that exercise this?

Who would we autotest this?

I intend to test this when all the functions needed to work are implemented.

Or would you like a test for every function?

Having as much test coverage as possible is the best. If you think you need some more building blocks for this to be more easily autotestable, that's also a valid answer

Implemented setInterval/clearInterval. WidgetScripts are now supported on pageOpening/Closing.

Harbormaster completed remote builds in B12067: Diff 58487.May 22 2019, 5:09 PM

joaonetto retitled this revision from Added basic JavaScript functions to support animated PDF to [WIP] Support animated PDF.May 22 2019, 5:11 PM

joaonetto edited the summary of this revision. (Show Details)

joaonetto edited the test plan for this revision. (Show Details)

Documentation and fixing spaces

Harbormaster completed remote builds in B12068: Diff 58488.May 22 2019, 5:16 PM

Updating revision to match the current branch

Harbormaster completed remote builds in B12319: Diff 58984.Jun 1 2019, 2:59 PM

joaonetto edited the summary of this revision. (Show Details)Jun 1 2019, 3:02 PM

joaonetto edited the test plan for this revision. (Show Details)

The diff shown here is wrong. We want the diff from your branch against master, not the last change in your branch against itself

Updated Diff to track changes based on master

Harbormaster completed remote builds in B12353: Diff 59045.Jun 3 2019, 1:01 AM

joaonetto edited the summary of this revision. (Show Details)Jun 3 2019, 1:03 AM

joaonetto edited the test plan for this revision. (Show Details)

Changed button code to be transparent when there's no text.

Harbormaster completed remote builds in B12379: Diff 59100.Jun 4 2019, 12:51 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2019, 1:31 AM

Closed by commit R223:a3628c1f97e9: Revert "mend" (authored by joaonetto). · Explain Why

This revision was automatically updated to reflect the committed changes.

Wasn't supposed to be closed. It closed with a wrong commit on my side branch.

Updated with the code against master

Harbormaster completed remote builds in B12380: Diff 59102.Jun 4 2019, 1:38 AM

Implemented buttonGetIcon and buttonSetIcon

Harbormaster completed remote builds in B12475: Diff 59257.Jun 6 2019, 12:57 PM

This was merged on invent.kde.org.

			Path
M			CMakeLists.txt (2 lines)
M			autotests/CMakeLists.txt (5 lines)
A	M	(bin)	autotests/data/kjsfunctionstest.pdf
A	M		autotests/kjsfunctionstest.cpp (209 lines)
M			core/document.h (7 lines)
M			core/document.cpp (7 lines)
M			core/script/executor_kjs.cpp (18 lines)
M			core/script/executor_kjs_p.h (2 lines)
M			core/script/kjs_app.cpp (105 lines)
P			core/script/kjs_app_p.h (6 lines) Copied to multiple locations: core/script/kjs_display_p.h core/script/kjs_ocg_p.h
A	M		core/script/kjs_display.cpp (49 lines)
P			core/script/kjs_display_p.h (15 lines) Copied from core/script/kjs_app_p.h
M			core/script/kjs_document.cpp (71 lines)
M			core/script/kjs_field.cpp (80 lines)
A	M		core/script/kjs_ocg.cpp (86 lines)
P			core/script/kjs_ocg_p.h (18 lines) Copied from core/script/kjs_app_p.h
M			core/scripter.cpp (3 lines)
M			ui/formwidgets.cpp (8 lines)
M			ui/pageview.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58042	745e8df		May 13 2019, 11:56 PM	★	★
Diff 2	58043	745e8df	Fixed copyright	May 14 2019, 12:05 AM	★	★
Diff 3	58077	745e8df	Changed for to range based loops	May 14 2019, 1:32 PM	★	★
Diff 4	58154	5c5e5fc	Removed useless iterator	May 15 2019, 10:19 PM	★	★
Diff 5	58162	5c5e5fc	Loops now use const and more efficient way of acessing LinkedList	May 16 2019, 11:41 AM	★	★
Diff 6	58163	5c5e5fc	Remove unintentionally left qDebug()	May 16 2019, 11:47 AM	★	★
Diff 7	58165	5c5e5fc	Declared g_displayProto as std::unique_ptr	May 16 2019, 12:00 PM	★	★
Diff 8	58487	5c5e5fc	Implemented setInterval/clearInterval. WidgetScripts are now supported on…	May 22 2019, 5:09 PM	★	★
Diff 9	58488	5c5e5fc	Documentation and fixing spaces	May 22 2019, 5:16 PM	★	★
Diff 10	58984	70e3898	Updating revision to match the current branch	Jun 1 2019, 2:59 PM	★	★
Diff 11	59045	d084641	Updated Diff to track changes based on master	Jun 3 2019, 1:01 AM	★	★
Diff 12	59100	3a380e1	Changed button code to be transparent when there's no text.	Jun 4 2019, 12:51 AM	★	★
Diff 13	59101	919f056	R223:a3628c1f97e9d4649a2f2b4638d1caf43f07d902	Jun 3 2019, 11:50 PM	★	★
Diff 14	59102	3a380e1	Updated with the code against master	Jun 4 2019, 1:38 AM	★	★
Diff 15	59257	e49742e	Implemented buttonGetIcon and buttonSetIcon	Jun 6 2019, 12:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
abf888e76cbd	3cfb4647d392	e49742e0f86c c00fbccf1b72	João Netto	Merge branch 'gsoc2019_animatedpdf'	Jun 6 2019, 3:56 PM
c00fbccf1b72	4a406ff027aa	e12151ada980	João Netto	Added support for buttonSetIcon and buttonGetIcon.	Jun 6 2019, 3:46 PM
e12151ada980	5be3951bbedb	5f324e583e98	Kezi Olio	Make selection scrolling go at 60 fps (Show More…)	May 21 2019, 9:03 PM
5f324e583e98	4182009a7906	a3628c1f97e9	João Netto	Updated copyright with the right one	Jun 3 2019, 11:52 PM
a3628c1f97e9	933c7e4ce59c	919f056953f1	João Netto	Revert "mend" (Show More…)	Jun 3 2019, 11:50 PM
919f056953f1	4182009a7906	52c227ccb83d	João Netto	mend	Jun 4 2019, 12:56 AM
52c227ccb83d	933c7e4ce59c	b009a1bf2c7c	João Netto	Changed button code to be transparent when there's no text.	Jun 4 2019, 12:45 AM
b009a1bf2c7c	ac86e0013e67	70e3898224de	João Netto	Implemented more unit tests to cover the OCGs	Jun 1 2019, 2:28 PM
70e3898224de	0e5dba9c889d	ece492dab82a	João Netto	Implemented the getOCGs and OCGs methods to support layer changing by… (Show More…)	May 31 2019, 8:03 PM
ece492dab82a	75c922b7dadc	61d32c815992	João Netto	Implemented unit tests to the JavaScript functions.	May 30 2019, 4:33 PM
61d32c815992	68fdb1a6c7dc	a8a5e7a49489	João Netto	When refreshing, widgets must check if they should be visible	May 28 2019, 11:10 AM
a8a5e7a49489	9fa2219ad424	a156c19053f6	João Netto	Revert "Reverted commentary." (Show More…)	May 27 2019, 10:19 PM
a156c19053f6	56158a0defd2	0e02d4617a6f	João Netto	Reverted commentary.	May 27 2019, 4:12 PM
0e02d4617a6f	9fa2219ad424	2083e763d0bf	João Netto	Implemented initial support for animatedPDF	May 23 2019, 1:28 PM

[WIP] Support animated PDF
AbandonedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 59257

CMakeLists.txt

autotests/CMakeLists.txt

autotests/data/kjsfunctionstest.pdf

autotests/kjsfunctionstest.cpp

core/document.h

core/document.cpp

core/script/executor_kjs.cpp

core/script/executor_kjs_p.h

core/script/kjs_app.cpp

core/script/kjs_app_p.h

core/script/kjs_display.cpp

core/script/kjs_display_p.h

core/script/kjs_document.cpp

core/script/kjs_field.cpp

core/script/kjs_ocg.cpp

core/script/kjs_ocg_p.h

core/scripter.cpp

ui/formwidgets.cpp

ui/pageview.cpp

[WIP] Support animated PDFAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 59257

CMakeLists.txt

autotests/CMakeLists.txt

autotests/data/kjsfunctionstest.pdf

autotests/kjsfunctionstest.cpp

core/document.h

core/document.cpp

core/script/executor_kjs.cpp

core/script/executor_kjs_p.h

core/script/kjs_app.cpp

core/script/kjs_app_p.h

core/script/kjs_display.cpp

core/script/kjs_display_p.h

core/script/kjs_document.cpp

core/script/kjs_field.cpp

core/script/kjs_ocg.cpp

core/script/kjs_ocg_p.h

core/scripter.cpp

ui/formwidgets.cpp

ui/pageview.cpp

[WIP] Support animated PDF
AbandonedPublic
Actions

Revision Contents
Changeset List