Ever since increasing the list item size to accommodate 32px icons, System Settings' sidebar has felt somehow wrong to me

• fix music import notification not showing up during initial indexing
• use categorized logging in DatabaseInterface
• store some metadata only if they are really defined
• only really return data on tracks if they are not null in database
• do not store invalid data from tracks into database
• add categorized logging for vlc player code
• scan newly discovered files from baloo only with audio mime type
• add more logs in Baloo to understand what happens during indexing
• only use categorized logging to indicate error cases
• add bad performance detection for all Sql queries in debug builds
• add some known index to Tracks table
• really only fetch track ids and optimize modified albums handling
• convert some remaining debug logs to categorized ones
• revert modifications for modified tracks from modified albums

Visually I don't think there's anything to object to, and this is a useful message to have. The wording seems fine. Someone should also confirm that the code is sane.

• const'ify

Tested against Russian translation. It works. Thanks!

Good catch.
it's a bug in clazy.

I’d also like to add my voice here: secret service support (libsecret) would be amazing for productivity (no separate password stores) and polish (no GNOME popup when something asks for a password)

Remove duplicate call

Software that hasn't been ported by now IMO deserves no further fixes anyway. At this point it's more a matter of anyone finding the time and energy to actually rip Qt4 out and moving to ECM :/

Btw regarding the prettyPrint param, should we set it to false, maybe? It's true by default, so disabling it could further improve performance and lower the bandwidth.

Good idea :-)

Nice! I think this is a great thing to have in libkgapi, thanks for looking into this.

Ping this looks sane, anyone ?

On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine.

What happen to this? Put it to 19.04 for testing.

This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers.

make the "Folders" string translatable

In D18809#436246, @victorr wrote:

File /wallpapers/image/imagepackage/contents/ui/config.qml
Word "Folders" without translation

Kirigami.Heading {
    text: "Folders"
    level: 2
}

File /wallpapers/image/imagepackage/contents/ui/config.qml
Word "Folders" without translation

In D19784#434564, @hoffmannrobert wrote:

In D19784#431683, @ngraham wrote:

Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm?

No, unfortunately it doesn't fix this. If the network isn't available, the file dialog waits for KCoreDirLister ("Iterating over dirs").

In D19970#436221, @sitter wrote:

Q_FALLTHROUGH is too new. This thing is still qt 4 compatible

q!

Removing the Q_FALLTHROUGH

Q_FALLTHROUGH is too new. This thing is still qt 4 compatible