Fix collection detaching at the wrong time in attribute()

Authored by dfaure on Mar 13 2019, 10:48 PM.



Found in FatCRM where changes to collection attributes were not stored

Test Plan

New unittest to ensure that we get the attribute from the
detached collection, not from the original one.

Diff Detail

R165 Akonadi
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Mar 13 2019, 10:48 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 13 2019, 10:48 PM
dfaure requested review of this revision.Mar 13 2019, 10:48 PM

Nice catch. The patch needs rebasing against your latest changes, though.

I incorporated it into D19942 moving this into the implementation of the non-templated non-const version of attribute(const QByteArray &).

dvratil accepted this revision.Mar 22 2019, 12:47 PM
This revision is now accepted and ready to land.Mar 22 2019, 12:47 PM

Updated to do the same in tag.h as well.

This revision was automatically updated to reflect the committed changes.