[kpeople] make it compile without foreach
ClosedPublic

Authored by mlaurent on Fri, Mar 22, 8:02 AM.

Details

Summary

compile without foreach

Test Plan

autotest ok

Diff Detail

Repository
R307 KPeople
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Fri, Mar 22, 8:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Mar 22, 8:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Fri, Mar 22, 8:02 AM
pino added a subscriber: pino.Fri, Mar 22, 8:40 AM
pino added inline comments.
src/matchessolver.cpp
61–66

iterators, please

apol added a subscriber: apol.Fri, Mar 22, 1:26 PM
apol added inline comments.
src/matchessolver.cpp
63

You are calling destinationResolver.keys(urlB) twice here.

mlaurent updated this revision to Diff 54563.Fri, Mar 22, 2:28 PM

Remove duplicate call

dfaure requested changes to this revision.Sun, Mar 24, 3:24 PM
dfaure added inline comments.
src/matchessolver.cpp
62–66

lst used to be called keys, there's no particular reason to rename it.

src/metacontact.cpp
51

(the qAsConst isn't technically needed since this method is const; but it doesn't hurt either)

src/widgets/plugins/mergecontactswidget.cpp
185

const & would be even better.

(It'll get lengthy, so this might be a reason to switch for const auto & here, although some might object that the type isn't visible in the code here)

This revision now requires changes to proceed.Sun, Mar 24, 3:24 PM
mlaurent updated this revision to Diff 54749.Mon, Mar 25, 5:59 AM

Fix error reported by david

dfaure accepted this revision.Mon, Mar 25, 8:25 AM
This revision is now accepted and ready to land.Mon, Mar 25, 8:25 AM
This revision was automatically updated to reflect the committed changes.