[Splash KCM] Use InlineMessage for testing error
AcceptedPublic

Authored by broulik on Mar 14 2019, 9:40 AM.

Details

Reviewers
filipf
Group Reviewers
Plasma
VDG
Summary

When testing a splash screen fails, a message box appears. This changes it to an InlineLabel and also makes process handling asynchronous to not block the settings dialog process and instead disables the controls within.

Test Plan

Made a ksplash theme that just froze the splash process, killed it, got this error.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 14 2019, 9:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2019, 9:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 14 2019, 9:40 AM
filipf accepted this revision.Mar 22 2019, 5:49 PM
filipf added a subscriber: filipf.

Visually I don't think there's anything to object to, and this is a useful message to have. The wording seems fine. Someone should also confirm that the code is sane.

This revision is now accepted and ready to land.Mar 22 2019, 5:49 PM
abetts added a subscriber: abetts.Mar 22 2019, 5:52 PM

Could the message include some hints of what failed? Maybe the theme name? Something like:

"Failed to test Adwaita splash screen, please check theme"

Yeah I agree, this isn't a very actionable error message. What is the user supposed to make of it or do next?