Differential D19978

Allow to set custom hints for notifications
ClosedPublic
Actions

Authored by nicolasfella on Mar 22 2019, 5:32 PM.

Details

Reviewers
broulik
davidedmundson
Commits
R289:06a61528cd48: Allow to set custom hints for notifications
Summary

Allow to send custom hints to the notification implementation. This allows applications to use Plasma (or any other backend) specific features without polluting the public API of KNotifications

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mar 22 2019, 5:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2019, 5:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 22 2019, 5:32 PM
nicolasfella updated this revision to Diff 54570.Mar 22 2019, 5:37 PM
  • const'ify
nicolasfella updated this revision to Diff 54573.Mar 22 2019, 5:53 PM
  • fix stuff
vkrause added a subscriber: vkrause.Mar 24 2019, 12:56 PM

Technically this looks ok to me, might be useful to have a little bit more context in the documentation and/or commit message though

nicolasfella edited the summary of this revision. (Show Details)Mar 24 2019, 1:05 PM
davidedmundson accepted this revision.Mar 24 2019, 1:09 PM
This revision is now accepted and ready to land.Mar 24 2019, 1:09 PM
Closed by commit R289:06a61528cd48: Allow to set custom hints for notifications (authored by nicolasfella). · Explain WhyMar 24 2019, 1:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/knotification.h (14 lines)
Msrc/knotification.cpp (19 lines)
Msrc/notifybypopup.cpp (5 lines)

Diff 54671

View Options

src/knotification.h

Loading...
View Options

src/knotification.cpp

Loading...
View Options

src/notifybypopup.cpp

Loading...