dvratil (Daniel Vrátil)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (184 w, 2 h)
Availability
Available

Recent Activity

Fri, Oct 19

dvratil requested changes to D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.
Fri, Oct 19, 11:51 AM · KDE PIM
dvratil accepted D16245: korgac: Save size and position on dialog hide/close and improve restore.
Fri, Oct 19, 11:45 AM · KDE PIM

Thu, Oct 18

dvratil accepted D16110: Unify license to LGPL v2.1+.

Approved.

Thu, Oct 18, 8:23 AM · KDE PIM

Wed, Oct 17

dvratil accepted D16136: License maintenance: GPLv2 -> GPLv2+.
Wed, Oct 17, 10:01 AM · KDE PIM
dvratil requested changes to D16245: korgac: Save size and position on dialog hide/close and improve restore.

Minor nitpicks, otherwise looks good.

Wed, Oct 17, 8:20 AM · KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

Flat items and less rounded corners are already in git master (for 18.12). We can wait for the improvements in the color palette to be done first, then blog about the whole task if you want.

Wed, Oct 17, 8:13 AM · KDE PIM: Junior Jobs, KDE PIM

Tue, Oct 16

dvratil added inline comments to D16244: korgac: Make the korgac notification dialog even smaller.
Tue, Oct 16, 1:56 PM · KDE PIM
dvratil updated subscribers of T9420: [KOrganizer] Improve event display.

Month and agenda items in KOrganizer are now flat with less-rounded corners, thanks to @ognarb! The work has landed on master (for 18.12 release)

Tue, Oct 16, 1:55 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil updated the task description for T9420: [KOrganizer] Improve event display.
Tue, Oct 16, 1:46 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil committed R76:235b2fdac42c: Rewrite the painting of an month item (authored by ognarb).
Rewrite the painting of an month item
Tue, Oct 16, 1:45 PM
dvratil closed D16013: Rewrite the painting of an month item.
Tue, Oct 16, 1:45 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil accepted D16013: Rewrite the painting of an month item.

I think it's perfect now, so from my side, this is good to go. I don't think this kind of change belongs to a bugfix release, so I'll push this to master (for 18.12 release).

Tue, Oct 16, 1:43 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil accepted D16243: korgac: Add a menu option to always get to the reminder dialog..

This has to go to master because of the string change, so it will be available in 18.12. We'll push this for you if you don't have commit access.

Tue, Oct 16, 1:36 PM · KDE PIM
dvratil added inline comments to D16013: Rewrite the painting of an month item.
Tue, Oct 16, 11:25 AM · KDE PIM: Junior Jobs, KDE PIM
dvratil requested changes to D16246: korgac: For no grab avoid mouse cursor when placing window.

I don't know if this is a good thing or not - there's still the window decoration and mouse pointer size that you would need to take into account, so just moving the window arbitrary amount of pixels left/right/above/below the cursor may or may not be enough based on user's window decorations theme, cursor size and DPI settings.

Tue, Oct 16, 8:44 AM · KDE PIM
dvratil requested changes to D16245: korgac: Save size and position on dialog hide/close and improve restore.
Tue, Oct 16, 8:34 AM · KDE PIM
dvratil added inline comments to D16244: korgac: Make the korgac notification dialog even smaller.
Tue, Oct 16, 8:31 AM · KDE PIM
dvratil requested changes to D16243: korgac: Add a menu option to always get to the reminder dialog..

Thanks for the patch! Just a minor nitpick, otherwise it looks good.

Tue, Oct 16, 8:29 AM · KDE PIM

Mon, Oct 15

dvratil added a comment to T9753: [Akonadi] Run db fsck as part of akonadictl fsck.

Hi Nathan,

Mon, Oct 15, 11:44 AM · KDE PIM
dvratil added a comment to D16013: Rewrite the painting of an month item.

No worries, hope your exams went well :)

Mon, Oct 15, 8:35 AM · KDE PIM: Junior Jobs, KDE PIM

Sun, Oct 14

dvratil added a comment to T9687: Create and publish AppImage with releases and master.

Hi Scarlett. The official stable Flathub Flatpak is on Flathub github: http://github.com/flathub/org.kde.kontact

Sun, Oct 14, 6:33 PM · KDE PIM

Thu, Oct 11

dvratil accepted D16051: Fix KOrg category color customization crash.

Thanks!

Thu, Oct 11, 9:22 PM · KDE PIM
dvratil requested changes to D16051: Fix KOrg category color customization crash.
Thu, Oct 11, 12:49 PM · KDE PIM
dvratil accepted D16088: Fix color inconsistency for unset categories..

Looks good, thanks!

Thu, Oct 11, 12:47 PM · KDE PIM
dvratil accepted D16089: Factor out coloring from AgendaItem::paintEvent..

Sorry for the delay, I had a hard time matching your changes in the logic to the original code :) looks good though. Thanks.

Thu, Oct 11, 12:43 PM · KDE PIM

Tue, Oct 9

dvratil added inline comments to D16089: Factor out coloring from AgendaItem::paintEvent..
Tue, Oct 9, 10:33 PM · KDE PIM
dvratil added a comment to T9753: [Akonadi] Run db fsck as part of akonadictl fsck.

Hi Nathan,

Tue, Oct 9, 2:58 PM · KDE PIM

Mon, Oct 8

dvratil added a comment to D16013: Rewrite the painting of an month item.

I think Denis has explained it better than I did - the margin and borders on 21st and 22nd break the effect of the continuous event - that's what I was concerned about.

Mon, Oct 8, 9:08 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D16013: Rewrite the painting of an month item.

So maybe we could pass some additional flag when creating the MonthGraphicsItem in MonthItem::updateMonthGraphicsItems() - this code is aware of the full even length, so it could simply pass an additional flag saying whether the event continues on next week (or started in the previous week, or both) and the painting code could handle that completely separately, like avoiding the border and margin on the respective side. What do you think?

Mon, Oct 8, 6:23 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D16013: Rewrite the painting of an month item.

Thanks. With the small radius, it still feels like it's hard to distinguish between an event that ends on Sunday and an event that continues to next week - could you try removing them in this case, so that the event seemingly goes out of the screen to make it more obvious that it spans multiple days?

Mon, Oct 8, 5:38 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil accepted D15975: Remove just deleted POP3 messages from the internal maps.

Thanks for digging into the POP3 resource, Chris!

Mon, Oct 8, 5:34 PM · KDE PIM
dvratil committed R85:aa0ce229e2cd: Merge branch 'Applications/18.08' (authored by dvratil).
Merge branch 'Applications/18.08'
Mon, Oct 8, 5:29 PM
dvratil committed R85:62f97d9aca77: Disable Chromium's crash handler (authored by dvratil).
Disable Chromium's crash handler
Mon, Oct 8, 5:29 PM
dvratil closed D16004: Disable Chromium's crash handler.
Mon, Oct 8, 5:29 PM · KDE PIM
dvratil requested changes to D16013: Rewrite the painting of an month item.

There seems to be a regression compared to the previous version when drawing events that span multiple weeks - in the original version the event is not rounded on week end and week start, while on your screenshot it appears the event has round corners on Sunday and Monday. Can you look into it?

Mon, Oct 8, 5:25 PM · KDE PIM: Junior Jobs, KDE PIM

Sun, Oct 7

dvratil committed R199:efa47c2034a2: Browser: fix tag fetch scope (authored by dvratil).
Browser: fix tag fetch scope
Sun, Oct 7, 1:24 PM
dvratil committed R199:75418c3e5b96: Debugger: enable pixel scrolling (authored by dvratil).
Debugger: enable pixel scrolling
Sun, Oct 7, 1:19 PM
dvratil requested review of D16004: Disable Chromium's crash handler.
Sun, Oct 7, 10:59 AM · KDE PIM
dvratil requested changes to D15997: Make KPimGAPI optional.

KMailTransport is a PIM library in the first place. PIM already depends on WebEngine, so I'm not much in favor of this change, sorry.

Sun, Oct 7, 10:44 AM · KDE PIM
dvratil added a comment to D15997: Make KPimGAPI optional.

What other components outside of Kontact/KDE PIM depend on KMailTransport?

Sun, Oct 7, 10:16 AM · KDE PIM

Sat, Oct 6

dvratil committed R165:05fb35f2df92: Don't update Item atime in NotificationCollector (authored by dvratil).
Don't update Item atime in NotificationCollector
Sat, Oct 6, 9:36 PM
dvratil committed R165:23ca10cb9394: Extend postgres search paths (authored by dvratil).
Extend postgres search paths
Sat, Oct 6, 9:36 PM
dvratil committed R165:fd56357ac239: Split ChangeRecorder journal loading/writing to its own file (authored by dvratil).
Split ChangeRecorder journal loading/writing to its own file
Sat, Oct 6, 8:19 PM
dvratil committed R76:d780fa85d26b: Rewrite the painting part of agandaitem (authored by ognarb).
Rewrite the painting part of agandaitem
Sat, Oct 6, 12:05 PM
dvratil closed D15916: Rewrite the painting part of agandaitem.
Sat, Oct 6, 12:05 PM · KDE PIM: Junior Jobs, KDE PIM

Fri, Oct 5

dvratil accepted D15962: pop3: qualify all mails for deletion if supplied id == -1.

Looks sensible. Thanks.

Fri, Oct 5, 11:08 AM · KDE PIM
dvratil moved T9595: [KAddressbook] Use KPeople model for contact list from Backlog to In Progress on the KDE PIM board.
Fri, Oct 5, 8:54 AM · KDE PIM
dvratil moved T9420: [KOrganizer] Improve event display from Backlog to In Progress on the KDE PIM board.
Fri, Oct 5, 8:54 AM · KDE PIM: Junior Jobs, KDE PIM

Thu, Oct 4

dvratil created T9801: [Akonadi] Resources::cancelTask() during sync loses the message.
Thu, Oct 4, 3:27 PM · KDE PIM
dvratil added a member for KDE PIM: Junior Jobs: dvratil.
Thu, Oct 4, 2:18 PM
dvratil added a member for Flatpak: dvratil.
Thu, Oct 4, 2:18 PM

Wed, Oct 3

dvratil added a comment to D15916: Rewrite the painting part of agandaitem.

No problem, the codebase is similar enough that if you code against the 18.08 branch the patches should apply on master without any big issues. If you don't have commit access (or even if you do and can't test against master), we can check and apply the patch for you :)

Wed, Oct 3, 1:30 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil accepted D15916: Rewrite the painting part of agandaitem.

I'm fine with a separate diff for month view, I just didn't know from the top of my head which parts of the code are shared between those views.

Wed, Oct 3, 12:42 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D15916: Rewrite the painting part of agandaitem.

Also, does this affect only the Agenda view (day/week view), or the month view as well? We should probably fix both, otherwise it will look weirdly inconsistent...

Wed, Oct 3, 11:58 AM · KDE PIM: Junior Jobs, KDE PIM
dvratil added inline comments to D15916: Rewrite the painting part of agandaitem.
Wed, Oct 3, 11:57 AM · KDE PIM: Junior Jobs, KDE PIM

Tue, Oct 2

dvratil edited projects for T9505: Kontact Flatpak, added: KDE PIM (Applications 18.12 (master)); removed KDE PIM.
Tue, Oct 2, 9:59 PM · KDE PIM (Applications 18.12 (master)), KDE PIM: Junior Jobs
dvratil added a comment to T9420: [KOrganizer] Improve event display.

Looks nice, thanks for looking into this!

Tue, Oct 2, 8:59 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil committed R201:a55949983bc0: Restore PNG icons, they are needed by ecm_add_app_icon (authored by dvratil).
Restore PNG icons, they are needed by ecm_add_app_icon
Tue, Oct 2, 8:55 PM
dvratil added a reverting change for R201:9704b33e4ef4: Fix search icon: R201:c5ba739e9151: Revert "Fix search icon".
Tue, Oct 2, 8:55 PM
dvratil committed R201:c5ba739e9151: Revert "Fix search icon" (authored by dvratil).
Revert "Fix search icon"
Tue, Oct 2, 8:55 PM
dvratil committed R208:197cc632d99d: Restore PNG icons, they are needed by ecm_add_app_icon (authored by dvratil).
Restore PNG icons, they are needed by ecm_add_app_icon
Tue, Oct 2, 8:53 PM
dvratil committed R208:d0dc8a7a83dc: Revert "Fix search icons" (authored by dvratil).
Revert "Fix search icons"
Tue, Oct 2, 8:53 PM
dvratil added a reverting change for R208:05edac94a8f5: Fix search icons: R208:d0dc8a7a83dc: Revert "Fix search icons".
Tue, Oct 2, 8:53 PM
dvratil committed R210:a42e2abd67e9: Restore PNG icons, they are needed by ecm_add_app_icon (authored by dvratil).
Restore PNG icons, they are needed by ecm_add_app_icon
Tue, Oct 2, 8:52 PM
dvratil committed R210:8f331384f03b: Revert "Fix search icon" (authored by dvratil).
Revert "Fix search icon"
Tue, Oct 2, 8:52 PM
dvratil added a reverting change for R210:0201f2599063: Fix search icon: R210:8f331384f03b: Revert "Fix search icon".
Tue, Oct 2, 8:52 PM
dvratil committed R204:db685f29bed4: Restore PNG icons, they are needed by ecm_add_app_icon (authored by dvratil).
Restore PNG icons, they are needed by ecm_add_app_icon
Tue, Oct 2, 8:47 PM
dvratil committed R204:076806ab1c38: Revert "Fix search icons" (authored by dvratil).
Revert "Fix search icons"
Tue, Oct 2, 8:47 PM
dvratil added a reverting change for R204:99360c355ce2: Fix search icons: R204:076806ab1c38: Revert "Fix search icons".
Tue, Oct 2, 8:47 PM
dvratil added a reverting change for R206:b3b292658df0: Fix search icons: R206:f3f9a5ce4f1c: Revert "Fix search icons".
Tue, Oct 2, 8:46 PM
dvratil committed R206:f3f9a5ce4f1c: Revert "Fix search icons" (authored by dvratil).
Revert "Fix search icons"
Tue, Oct 2, 8:46 PM
dvratil committed R206:935d6a994736: Restore PNG icons, they are needed by ecm_add_app_icon (authored by dvratil).
Restore PNG icons, they are needed by ecm_add_app_icon
Tue, Oct 2, 8:43 PM
dvratil committed R209:895a5e8255e4: Restore PNG icons, they are needed by ecm_add_app_icon (authored by dvratil).
Restore PNG icons, they are needed by ecm_add_app_icon
Tue, Oct 2, 8:38 PM
dvratil committed R209:393198c63545: Fix ecm_add_app_icon (authored by dvratil).
Fix ecm_add_app_icon
Tue, Oct 2, 8:24 PM
dvratil committed R208:c0bd2d724fff: Update appstream data (authored by dvratil).
Update appstream data
Tue, Oct 2, 7:44 PM
dvratil committed R208:3c8368c76b4f: Replace Oxygen icons with Breeze (authored by dvratil).
Replace Oxygen icons with Breeze
Tue, Oct 2, 7:44 PM
dvratil committed R210:967035fd021f: Update appstream data (authored by dvratil).
Update appstream data
Tue, Oct 2, 7:40 PM
dvratil committed R210:f3506cc494fd: Replace Oxygen icons with Breeze (authored by dvratil).
Replace Oxygen icons with Breeze
Tue, Oct 2, 7:40 PM
dvratil committed R206:f11a95989845: Update appstream data (authored by dvratil).
Update appstream data
Tue, Oct 2, 7:20 PM
dvratil committed R206:d3d7307a3984: Replace Oxygen icons with Breeze (authored by dvratil).
Replace Oxygen icons with Breeze
Tue, Oct 2, 7:20 PM
dvratil committed R204:269a774f96d3: Update appstream data (authored by dvratil).
Update appstream data
Tue, Oct 2, 7:01 PM
dvratil committed R204:cbb3d9e94ffb: Replace the old Oxygen icons with Breeze (authored by dvratil).
Replace the old Oxygen icons with Breeze
Tue, Oct 2, 7:01 PM
dvratil committed R201:352599771ca9: Upate appstream data (authored by dvratil).
Upate appstream data
Tue, Oct 2, 6:46 PM
dvratil committed R201:d846e208daa2: Replace Oxygen icon with Breeze (authored by dvratil).
Replace Oxygen icon with Breeze
Tue, Oct 2, 6:46 PM
dvratil committed R209:dfa21f620897: Update appdata file (authored by dvratil).
Update appdata file
Tue, Oct 2, 6:37 PM
dvratil committed R209:b2a16206f38b: Replace the old Oxygen icons with Breeze (authored by dvratil).
Replace the old Oxygen icons with Breeze
Tue, Oct 2, 6:37 PM
dvratil committed R256:bded0cacb4c6: akonadi-search can now be built without KRunner plugin (authored by dvratil).
akonadi-search can now be built without KRunner plugin
Tue, Oct 2, 4:06 PM
dvratil committed R42:f74ca243b5ce: Add option to not build the KRunner plugin (authored by dvratil).
Add option to not build the KRunner plugin
Tue, Oct 2, 4:04 PM
dvratil added a comment to T9595: [KAddressbook] Use KPeople model for contact list.

Cool! Just tried playing around with the test app a little, looks pretty good :)

Tue, Oct 2, 11:47 AM · KDE PIM
dvratil created T9786: [Akonadi] Improve error messages.
Tue, Oct 2, 11:00 AM · KDE PIM
dvratil created T9785: [Akonadi] Error message should also contain structured data with details.
Tue, Oct 2, 8:58 AM · KDE PIM
dvratil created T9784: [Akonadi] Translated error messages.
Tue, Oct 2, 8:56 AM · KDE PIM
dvratil created T9783: [Akonadi] Better error reporting.
Tue, Oct 2, 8:54 AM · KDE PIM

Mon, Oct 1

dvratil accepted D15851: Fix signals not being emitted when merging two persons.
Mon, Oct 1, 7:46 AM · Frameworks

Sat, Sep 29

dvratil added a comment to T9595: [KAddressbook] Use KPeople model for contact list.

Isn't the URI just an Akonadi ID? That should be enough to retrieve the Item from the ETM manually (build ID-only Item with Item::formUrl() and pass it to EntityTreeModel::modelIndexForItem() which will give you QModelIndex for the actual fully-populated Item) - for the editor and viewer you want to manipulate the Akonadi Item anyway, not the KContacts::Contact itself.

Sat, Sep 29, 6:14 AM · KDE PIM

Fri, Sep 28

dvratil updated subscribers of T9758: kdepim-runtime does not provide imap kio slave.

We don't really participate in GSOC/SOC/etc.. I don't want to speak for @mlaurent, but from my side, we simply don't have the time and manpower to manage it. And the topic of GSOC and similar projects never even came up on any PIM meeting.

Fri, Sep 28, 12:45 AM · KDE PIM
dvratil added a comment to T9687: Create and publish AppImage with releases and master.

@obogdan We are definitely fine with this, but we need help with it. I'm willing to keep the appimage up-to-date, as long as the updates are trivial (like updating tarball names and checksums), but I'd welcome someone from the community to help us with this (testing, solving issues, etc.)

Fri, Sep 28, 12:36 AM · KDE PIM
dvratil added a comment to T9687: Create and publish AppImage with releases and master.

Oh, cool! I'd very much prefer if we had a Kontact appimage instead of kmail/korganizer/.... as it helps to sell the brand of Kontact as a whole.

Fri, Sep 28, 12:06 AM · KDE PIM

Thu, Sep 27

dvratil added a comment to T9758: kdepim-runtime does not provide imap kio slave.

Because it was no longer needed (fully replaced by Akonadi and IMAP resource), it was duplicating a lots of code from KIMAP library and no-one was interested in porting it and maintaining it.

Thu, Sep 27, 2:12 PM · KDE PIM
dvratil added a comment to T9758: kdepim-runtime does not provide imap kio slave.

However, unlike IMAP slave, the kiomail requires users to use Akonadi and have their email accounts configured there - at which point interfacing with Akonadi directly might more optimal :-)

Thu, Sep 27, 8:40 AM · KDE PIM