dvratil (Daniel Vrátil)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (192 w, 2 d)
Availability
Available

Recent Activity

Yesterday

dvratil committed R165:3d53be982160: AkRanges: add operator< to LazyIterator (authored by dvratil).
AkRanges: add operator< to LazyIterator
Mon, Dec 17, 1:42 AM
dvratil added a reviewer for D17636: Allow specifying custom MSVC toolset: vonreth.
Mon, Dec 17, 1:04 AM
dvratil requested review of D17636: Allow specifying custom MSVC toolset.
Mon, Dec 17, 1:03 AM

Sun, Dec 16

dvratil added a comment to D17606: [WIP] Use <optional> if available..

I've recently run into the same problem on Akonadi on Windows, ended up allowing C++17 on Windows only and shipping a C++14-compatible implementation of C++17 optional in 3rdparty. Maybe we could just get rid of the optional in this agent until we can switch to C++17 proper. I hate not having it, but it's just one or two occurrences here and probably not worth the magic to satisfy all compilers.

Sun, Dec 16, 10:44 AM · KDE PIM

Sat, Dec 15

dvratil committed R165:a4e7f9310cef: Log time, level, category and more when logging to file (authored by dvratil).
Log time, level, category and more when logging to file
Sat, Dec 15, 4:44 PM

Thu, Dec 13

dvratil committed R82:661851e65dff: Remove AkonadiCore from target include directories (authored by dvratil).
Remove AkonadiCore from target include directories
Thu, Dec 13, 9:37 AM
dvratil committed R42:0c8f74b9e580: Make sure xapian.h is always included first (authored by dvratil).
Make sure xapian.h is always included first
Thu, Dec 13, 9:30 AM

Tue, Dec 11

dvratil committed R165:fc98526f5b1c: Improve AkRanges, add transform operation (authored by dvratil).
Improve AkRanges, add transform operation
Tue, Dec 11, 5:11 PM

Mon, Dec 10

dvratil committed R1028:fd84f15810ed: Update link to git repo (authored by dvratil).
Update link to git repo
Mon, Dec 10, 2:38 PM
dvratil committed R1028:0cbefe00f00b: Update README (authored by dvratil).
Update README
Mon, Dec 10, 2:37 PM
dvratil committed R1028:fdc8ac4f81da: Fix the clipboard hint to not store the password in history (authored by dvratil).
Fix the clipboard hint to not store the password in history
Mon, Dec 10, 2:14 PM

Sun, Dec 9

dvratil committed R177:d55fdc617bf1: Install NamespaceJob and RFCCodecs camelcase headers (authored by dvratil).
Install NamespaceJob and RFCCodecs camelcase headers
Sun, Dec 9, 6:06 PM

Wed, Dec 5

dvratil committed R165:612925731625: Install VectorHelper header from shared (authored by dvratil).
Install VectorHelper header from shared
Wed, Dec 5, 10:13 AM
dvratil committed R165:a13d01060f2d: Don't rely on STL implementation detail of nullopt (authored by dvratil).
Don't rely on STL implementation detail of nullopt
Wed, Dec 5, 10:02 AM
dvratil committed R165:5699098e40f1: Use a ranges-like notation for container conversion (authored by dvratil).
Use a ranges-like notation for container conversion
Wed, Dec 5, 12:22 AM
dvratil committed R165:25d476959c1c: Remove the duplicated VectorHelper (authored by dvratil).
Remove the duplicated VectorHelper
Wed, Dec 5, 12:22 AM
dvratil committed R165:482315f4cbc7: Use 3rdparty Optional, name it akOptional (authored by dvratil).
Use 3rdparty Optional, name it akOptional
Wed, Dec 5, 12:22 AM

Tue, Dec 4

dvratil committed R165:41e9929f5bbb: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Tue, Dec 4, 4:30 PM
dvratil committed R165:5d620cd60a43: Fix ModelSpy (and thus some model tests) (authored by dvratil).
Fix ModelSpy (and thus some model tests)
Tue, Dec 4, 4:30 PM
dvratil committed R165:c52f5d0d95a4: Fix logic in akoptional.h (authored by dvratil).
Fix logic in akoptional.h
Tue, Dec 4, 2:49 PM
dvratil committed R165:c783af75bc8c: Pretend MSVC supports feature test macros (authored by dvratil).
Pretend MSVC supports feature test macros
Tue, Dec 4, 2:39 PM
dvratil committed R165:720456e8092a: Remove the deprecated std::unary_function (authored by dvratil).
Remove the deprecated std::unary_function
Tue, Dec 4, 2:39 PM
dvratil committed R165:16ee220abf1c: Set /Zc:__cplusplus CXX flag in MSVC builds (authored by dvratil).
Set /Zc:__cplusplus CXX flag in MSVC builds
Tue, Dec 4, 2:13 PM
dvratil committed R165:ceeb4f3a72b6: Disable std::auto_ptr checks in Item in C++17 (authored by dvratil).
Disable std::auto_ptr checks in Item in C++17
Tue, Dec 4, 1:27 PM
dvratil added a reverting change for R165:b25c808942ef: One more try for MSVC: R165:a490a189e41a: Revert "One more try for MSVC".
Tue, Dec 4, 1:02 PM
dvratil committed R165:a490a189e41a: Revert "One more try for MSVC" (authored by dvratil).
Revert "One more try for MSVC"
Tue, Dec 4, 1:02 PM
dvratil committed R165:770a57f07388: Enable C++17 with MSVC (authored by dvratil).
Enable C++17 with MSVC
Tue, Dec 4, 1:00 PM
dvratil committed R165:b25c808942ef: One more try for MSVC (authored by dvratil).
One more try for MSVC
Tue, Dec 4, 12:13 PM
dvratil committed R165:d7b50cc61292: Try to fix build on MSVC (authored by dvratil).
Try to fix build on MSVC
Tue, Dec 4, 11:47 AM
dvratil committed R165:68cec6c21357: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Tue, Dec 4, 10:29 AM
dvratil committed R165:d2225d6bf5cc: Fix ItemStoreTest (authored by dvratil).
Fix ItemStoreTest
Tue, Dec 4, 10:29 AM
dvratil added a reverting change for R165:94ed0cf7268d: Adapt TagHandlerTest to recent tag parent changes: R165:77091f0e7169: Revert "Adapt TagHandlerTest to recent tag parent changes".
Tue, Dec 4, 10:29 AM
dvratil committed R165:77091f0e7169: Revert "Adapt TagHandlerTest to recent tag parent changes" (authored by dvratil).
Revert "Adapt TagHandlerTest to recent tag parent changes"
Tue, Dec 4, 10:29 AM
dvratil committed R165:c37a236b8703: Rename Handlers to match the entity, operation and command names (authored by dvratil).
Rename Handlers to match the entity, operation and command names
Tue, Dec 4, 10:29 AM
dvratil committed R165:876ae1e4ae64: Remove or fix bare qCDebug()s (authored by dvratil).
Remove or fix bare qCDebug()s
Tue, Dec 4, 10:29 AM

Sat, Dec 1

dvratil committed R165:57ae2d34fd93: Fix build (authored by dvratil).
Fix build
Sat, Dec 1, 9:18 PM
dvratil committed R165:16a563bcdcb7: Server: Improve debug, warning and error log messages (authored by dvratil).
Server: Improve debug, warning and error log messages
Sat, Dec 1, 9:14 PM
dvratil committed R165:7de3e6d130a5: Implement error handling in PartStreamer with exceptions (authored by dvratil).
Implement error handling in PartStreamer with exceptions
Sat, Dec 1, 9:14 PM
dvratil committed R165:188e1158638d: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Sat, Dec 1, 5:26 PM
dvratil committed R165:2e72fef182db: Fix creating new tags with null parent (authored by dvratil).
Fix creating new tags with null parent
Sat, Dec 1, 5:26 PM
dvratil committed R165:20e6faf2835e: Treat warnings as qCWarnings in ExternalPartStorage (authored by dvratil).
Treat warnings as qCWarnings in ExternalPartStorage
Sat, Dec 1, 5:26 PM
dvratil committed R165:920148ceaadb: Disable noisy qCDebug when streaming payload part into file (authored by dvratil).
Disable noisy qCDebug when streaming payload part into file
Sat, Dec 1, 5:26 PM
dvratil committed R165:089ee6959fcd: Call QSqlQuery::finish() on all SELECT queries when done (authored by dvratil).
Call QSqlQuery::finish() on all SELECT queries when done
Sat, Dec 1, 5:26 PM
dvratil committed R165:80dd88b90c6a: Remove the outdated protocol documentation file (authored by dvratil).
Remove the outdated protocol documentation file
Sat, Dec 1, 5:26 PM
dvratil committed R165:50376cd8ef92: Reimplement the QueryCache as an LRU cache with size limit (authored by dvratil).
Reimplement the QueryCache as an LRU cache with size limit
Sat, Dec 1, 5:26 PM
dvratil committed R165:182a334b6b8a: Add a wrapper header for std::(experimental::)optional (authored by dvratil).
Add a wrapper header for std::(experimental::)optional
Sat, Dec 1, 5:26 PM
dvratil committed R165:a24d7a6e4e05: Server: small optimization when updating flags (authored by dvratil).
Server: small optimization when updating flags
Sat, Dec 1, 5:26 PM

Mon, Nov 26

dvratil added a comment to D14902: Port Archive mail agent to new config API.

Hi @mlaurent - check dev/agent-configuration branch in akonadi.git, dev/agent-config branch in kdepim-runtime.git and dev/agent-configuration in kmail.git. Drop me an email if you have any question, I'm not much on IRC these days :-(

Mon, Nov 26, 11:46 AM · KDE PIM

Thu, Nov 22

dvratil added a comment to D14902: Port Archive mail agent to new config API.

Hey. I won't be able to get to this within the next couple weeks, so you can finish this if you want. I already have a branch with most of the agents and resources in kdepim-runtime ported, I'll push it for review when I get to my other computer so you don't have to do everything over again. The main reason I was delaying pushing this was that I wanted to port as many agents as possible first to see if the API in akonadicore was well designed and usable, I think I had some unpushed changes to the API as well. I'll drop you an email with details when I get to it :-)

Thu, Nov 22, 9:46 AM · KDE PIM

Tue, Nov 20

dvratil committed R206:cf6c1002e761: Make sure the unified mailbox dialog is only really shown once (authored by dvratil).
Make sure the unified mailbox dialog is only really shown once
Tue, Nov 20, 11:50 AM
dvratil closed D17010: Make sure the unified mailbox dialog is only really shown once.
Tue, Nov 20, 11:50 AM · KDE PIM

Mon, Nov 19

dvratil committed R165:3abf7e150914: Fix potential memory leak in protocolgen (authored by dvratil).
Fix potential memory leak in protocolgen
Mon, Nov 19, 11:50 AM
dvratil requested review of D17010: Make sure the unified mailbox dialog is only really shown once.
Mon, Nov 19, 11:32 AM · KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

There's Prefs::createNewColor() in eventviews/src/prefs.cpp, looks like that might be it?

Mon, Nov 19, 11:17 AM · KDE PIM: Junior Jobs, KDE PIM
dvratil accepted D16917: Akonadi: ignore remote ID if it's empty.

Change qWarning() to qCWarning(AKONADISERVER_LOG) before committing, but otherwise, it can go in. Thanks!

Mon, Nov 19, 11:15 AM · KDE PIM
dvratil accepted D16970: License consistency: kmailtransport is LGPLv2+ licensed.
Mon, Nov 19, 11:10 AM · KDE PIM
dvratil updated subscribers of D16898: [kcm] Remove profiles code.

Profiles were supposed to allow various screen layouts per single setup, for instance, if you have your monitor and TV both connected to your PC, you may want to have "Monitor", "Monitor+TV" and "TV-only" profiles. The idea was to have a combobox in the KCM that would allow you to quickly switch between those profiles without having to fiddle with the rest of the GUI every time. IIRC we did not agree with @afiestas on this feature back then, so it remained disabled (should've been on a branch instead of #ifdefs on master, I admit that ) and while I was still working on kscreen, I never got around to actually finish it and push it.

Mon, Nov 19, 10:36 AM · Plasma

Nov 14 2018

dvratil added inline comments to D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.
Nov 14 2018, 9:31 AM · KDE PIM

Nov 9 2018

dvratil committed R165:94ed0cf7268d: Adapt TagHandlerTest to recent tag parent changes (authored by dvratil).
Adapt TagHandlerTest to recent tag parent changes
Nov 9 2018, 11:55 PM
dvratil committed R165:6102be5b6277: Don't use DataStore::self() in Handlers (authored by dvratil).
Don't use DataStore::self() in Handlers
Nov 9 2018, 11:55 PM
dvratil committed R165:f3811a5481d8: Make the XSLT-produced code slightly easier to read (authored by dvratil).
Make the XSLT-produced code slightly easier to read
Nov 9 2018, 11:55 PM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

@ognarb uh, sorry, I haven't seen the notification about your last comment. Yeah, going for some more pastel color to better fit Plasma/Breeze color theme would be nice. Maybe the entire default color generator could be improved - I honestly don't know much about where the colors come from in KOrganizer :-)

Nov 9 2018, 11:20 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added 1 commit(s) for D16493: Fix crash in failing GMail resource: R44:a4316a290e24: Fix crash in failing GMail resource.
Nov 9 2018, 12:24 PM · KDE PIM
dvratil added an edge to R44:a4316a290e24: Fix crash in failing GMail resource: D16493: Fix crash in failing GMail resource.
Nov 9 2018, 12:24 PM

Nov 4 2018

dvratil added a comment to D16532: Avoid deadlocking Akonadi on duplicates during merge.

This is kinda dangerous: if the RIDs are duplicated, we cannot know if all the matching Items are just multiple instance of the same Item: they can be two completely different Items, accidentally having the same RID stored in the DB. In such a situation, this patch will correctly update the content of the rightful RID owner, but destroy the content of the Item with the broken RID.

Nov 4 2018, 10:20 AM · KDE PIM
dvratil accepted D16624: Improve contrast in header from agendaitem.
Nov 4 2018, 10:08 AM · KDE PIM

Nov 2 2018

dvratil added a comment to D16509: Eventviews: associate calendar color to remoteID rather than ID..

If you stored the entire path to the collection (hierarchical remote ID), then you would have a unique identifiers for collections based on RID

Nov 2 2018, 6:57 AM

Nov 1 2018

dvratil added a comment to T9924: Move Akonadi database-interfacing code into "akstorage" library.

Definitely keep (and should not require any work):

  • CollectionStatistics
  • CollectionTreeCache
  • ItemRetrieval*
  • ItemRetriever
Nov 1 2018, 9:26 PM · KDE PIM
dvratil accepted D16584: Replace old connect with QT5 style in eventsview (Part 1).
Nov 1 2018, 5:19 PM · KDE PIM
dvratil accepted D16590: Express intent to compare model columns more directly.
Nov 1 2018, 3:46 PM · KDE PIM
dvratil accepted D16556: Modernize object declarations and initializations.

Looks good now, thank you!

Nov 1 2018, 2:59 PM · KDE PIM
dvratil accepted D16555: Move construction of ExpectedSignal where it belongs.

Looking good. Thanks for your work so far!

Nov 1 2018, 2:21 PM · KDE PIM
dvratil added inline comments to D16556: Modernize object declarations and initializations.
Nov 1 2018, 2:19 PM · KDE PIM
dvratil added a comment to D16559: Fix unused-object warnings.

In thin particular case it's OK to merge now - you fixed what Laurent asked for and there's hardly anything else in this patch to complain about :-)

Nov 1 2018, 1:24 PM · KDE PIM
dvratil requested changes to D16555: Move construction of ExpectedSignal where it belongs.
Nov 1 2018, 1:20 PM · KDE PIM
dvratil requested changes to D16556: Modernize object declarations and initializations.
Nov 1 2018, 1:10 PM · KDE PIM
dvratil accepted D16557: Move non-optional ModelSpy dependency to ctor.

I would say that the ModelSpy should even be created on the stack because the way it is now it leaks from one test run to another (this is only destroyed after all tests methods are executed).

Nov 1 2018, 12:36 PM · KDE PIM
dvratil accepted D16558: Fix some comment typos.
Nov 1 2018, 12:32 PM · KDE PIM
dvratil accepted D16559: Fix unused-object warnings.
Nov 1 2018, 12:29 PM · KDE PIM
dvratil added a comment to D16584: Replace old connect with QT5 style in eventsview (Part 1).

Hmm, technically those methods (slots) are accessed from another class, so they /should/ be public or, preferably, the connect statements should be in the Private class. Also, you can probably now remove the Q_PRIVATE_SLOT declarations form IncidenceTreeModel header file.

Nov 1 2018, 12:26 PM · KDE PIM

Oct 31 2018

dvratil accepted D16493: Fix crash in failing GMail resource.

Nice catch, thanks for the patch! Ship it to the stable branch, please (Applications/18.08)

Oct 31 2018, 9:10 AM · KDE PIM
dvratil accepted D16512: Fix regression in tag fetching for notifications.

Oh, sorry for that! And you are right, we should have more tests to cover this :( Many thanks for diving into Akonadi to find this.

Oct 31 2018, 9:07 AM · KDE PIM

Oct 28 2018

dvratil added a comment to T9595: [KAddressbook] Use KPeople model for contact list.

@poboiko hi Igor, how's the progress on this? Do you need any help?

Oct 28 2018, 9:45 AM · KDE PIM

Oct 25 2018

dvratil added a comment to D16377: Using the system palette for drawing the month- and agendaitem..

Oct 25 2018, 11:04 AM · KDE PIM

Oct 23 2018

dvratil added a comment to T9420: [KOrganizer] Improve event display.

I would say let's treat the HiDPI problem as a standalone issue, the painting code should probably take font metrics into account, instead of hardcoded arbitrary constants :)

Oct 23 2018, 9:16 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D16377: Using the system palette for drawing the month- and agendaitem..

I still have a problem, the new config don't appear in the gui. Does someone know how kcfg works? I already read https://techbase.kde.org/Development/Tutorials/Using_KConfig_XT but it didn't help.

Oct 23 2018, 9:06 PM · KDE PIM
dvratil added a comment to D16377: Using the system palette for drawing the month- and agendaitem..

Looking pretty good so far. Nice job!

Oct 23 2018, 9:13 AM · KDE PIM

Oct 22 2018

dvratil added a comment to D16246: korgac: For no grab avoid mouse cursor when placing window.

@mlaurent what do you think about this?

Oct 22 2018, 8:00 PM · KDE PIM
dvratil accepted D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.
Oct 22 2018, 7:59 PM · KDE PIM
dvratil added inline comments to D16323: Replace 10 year out of date ModelTest copy with QAIMTester.
Oct 22 2018, 7:59 PM · KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

@ognarb That sounds like a good idea: you can use it to get information about background and foreground colors and calculate some reasonable color palette from that.

Oct 22 2018, 3:02 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil committed R165:22a018de0425: Merge branch 'Applications/18.08' (authored by dvratil).
Merge branch 'Applications/18.08'
Oct 22 2018, 11:41 AM
dvratil committed R165:89727ad4da4d: Fix StorageJanitor SQL error in duplicate detection (authored by dvratil).
Fix StorageJanitor SQL error in duplicate detection
Oct 22 2018, 11:41 AM
dvratil moved T9753: [Akonadi] Run db fsck as part of akonadictl fsck from Backlog to In Progress on the KDE PIM board.
Oct 22 2018, 8:37 AM · KDE PIM
dvratil assigned T9753: [Akonadi] Run db fsck as part of akonadictl fsck to nathanchristenson.
Oct 22 2018, 8:37 AM · KDE PIM
dvratil added a comment to T9753: [Akonadi] Run db fsck as part of akonadictl fsck.

The storage library should remain inside of the akonadi.git repository (just another folder in the /src dir). The library will be internal to Akonadi (so we won't even install it or its headers), and we will only want to use it in tools that all live inside of the akonadi repo - we definitely don't want some other party running direct SQL queries against our database behind our backs :-)

Oct 22 2018, 8:36 AM · KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

@repinc, could you please attach a screenshot?

Oct 22 2018, 8:31 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 21 2018

dvratil requested changes to D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.

Let's just improve the wording a little, rest of the code looks OK now.

Oct 21 2018, 11:23 PM · KDE PIM
dvratil accepted D16321: Make KHolidays work as static library too.
Oct 21 2018, 11:10 PM · KDE PIM
dvratil added inline comments to D16323: Replace 10 year out of date ModelTest copy with QAIMTester.
Oct 21 2018, 11:08 PM · KDE PIM