dvratil (Daniel Vrátil)
User

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (201 w, 2 d)
Availability
Available

Recent Activity

Today

dvratil added a comment to D19011: Thunderbolt KCM and KDED module.

Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe?

Tue, Feb 19, 11:15 AM · Plasma

Fri, Feb 15

dvratil added inline comments to D19011: Thunderbolt KCM and KDED module.
Fri, Feb 15, 10:21 AM · Plasma
dvratil updated the diff for D19011: Thunderbolt KCM and KDED module.
  • Fixed typos
  • Unified license
  • Addresses comments from kbroulik
Fri, Feb 15, 10:20 AM · Plasma

Thu, Feb 14

dvratil updated the test plan for D19011: Thunderbolt KCM and KDED module.
Thu, Feb 14, 4:50 PM · Plasma
dvratil requested review of D19011: Thunderbolt KCM and KDED module.
Thu, Feb 14, 4:47 PM · Plasma
dvratil edited projects for T632: [Akonadi] Separated resource configuration dialogs, added: KDE PIM (Applications 19.04 (master)); removed KDE PIM.
Thu, Feb 14, 10:19 AM · KDE PIM (Applications 19.04 (master))

Tue, Feb 12

dvratil committed R174:ce7b230a3f2d: Remove Q_REQUIRED_RESULT from assignment operator (authored by dvratil).
Remove Q_REQUIRED_RESULT from assignment operator
Tue, Feb 12, 9:07 AM

Sun, Feb 10

dvratil accepted D18888: Akonadi: fix racy code in (MimeType|Resource)::retrieveByNameOrCreate.

I believe the attempt here was to make the most common case of successful retrieval lock-free, but I now realize how broken that approach was. Thanks for the patch!

Sun, Feb 10, 11:14 PM · KDE PIM

Fri, Feb 8

dvratil committed R165:c7faa84deb54: akRanges: add 'values' and 'keys' transformations (authored by dvratil).
akRanges: add 'values' and 'keys' transformations
Fri, Feb 8, 11:53 AM
dvratil committed R165:dd9d3f7509d9: AkRanges: use std::distance to calculate Range size (authored by dvratil).
AkRanges: use std::distance to calculate Range size
Fri, Feb 8, 11:53 AM

Thu, Feb 7

dvratil committed R138:ae3afc33c5b4: Allow specifying custom MSVC toolset (authored by dvratil).
Allow specifying custom MSVC toolset
Thu, Feb 7, 1:39 PM
dvratil closed D17636: Allow specifying custom MSVC toolset.
Thu, Feb 7, 1:39 PM

Wed, Feb 6

dvratil added a comment to D17636: Allow specifying custom MSVC toolset.

Sorry, I somehow forgot to hit the "Submit" button :facepalm:

Wed, Feb 6, 11:36 PM
dvratil committed R165:8d0ea3a5dfb1: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Wed, Feb 6, 5:15 PM
dvratil committed R165:42d6c38c4dc6: Fix SQLite backend foreign key PRAGMAs (authored by konradr).
Fix SQLite backend foreign key PRAGMAs
Wed, Feb 6, 5:14 PM
dvratil closed D18781: Fix SQLite backend foreign key PRAGMAs.
Wed, Feb 6, 5:14 PM · KDE PIM
dvratil accepted D18781: Fix SQLite backend foreign key PRAGMAs.

Ouch, many thanks for the fix. Do you have commit access? If so, please commit to Applications/18.12 branch, otherwise I can push it for you.

Wed, Feb 6, 10:19 AM · KDE PIM

Tue, Feb 5

dvratil accepted D18711: Simplify AggregatedFetchScope code, removing all setters..

Nice!

Tue, Feb 5, 12:08 PM · KDE PIM
dvratil accepted D18709: Fix tag change notification shipping a bogus name..
Tue, Feb 5, 12:03 PM · KDE PIM
dvratil accepted D18695: AggregatedFetchScope: fix fetchAllAttributes for tags..

Thanks!

Tue, Feb 5, 12:02 PM · KDE PIM
dvratil accepted D18672: Properly clean up scopes when deregistering a subscriber..

Thanks!

Tue, Feb 5, 12:01 PM · KDE PIM
dvratil accepted D18558: Fix "QIODevice::read" warnings..

Thanks!

Tue, Feb 5, 11:56 AM · KDE PIM

Sat, Feb 2

dvratil requested changes to D18672: Properly clean up scopes when deregistering a subscriber..

Looks good, just one small change regarding the thread/no-thread handling.

Sat, Feb 2, 5:02 PM · KDE PIM
dvratil accepted D18670: Fix aggregation logic for cacheOnly and ignoreErrors..
Sat, Feb 2, 5:00 PM · KDE PIM

Mon, Jan 28

dvratil committed R165:cf76b3c36f17: Use some akRanges in the Server (authored by dvratil).
Use some akRanges in the Server
Mon, Jan 28, 11:57 PM
dvratil committed R165:2e8819b62597: Make akRanges work with any callable (authored by dvratil).
Make akRanges work with any callable
Mon, Jan 28, 11:57 PM
dvratil committed R165:b70cc3e65239: AkRanges: add forEach range operator (authored by dvratil).
AkRanges: add forEach range operator
Mon, Jan 28, 11:57 PM
dvratil committed R165:0224507eddde: Fix akRanges on temporary containers (authored by dvratil).
Fix akRanges on temporary containers
Mon, Jan 28, 11:57 PM
dvratil added a comment to D18556: Fix tag name/type/gid missing in notifications about tags..

Dedicated test for the AggregatedFetchScope is the easiest approach I think - it's a fairly isolated class, so it should be easy to write a test for it.

Mon, Jan 28, 9:29 AM · KDE PIM

Sun, Jan 27

dvratil accepted D18556: Fix tag name/type/gid missing in notifications about tags..

Thanks for the patch, looks good.

Sun, Jan 27, 9:26 PM · KDE PIM
dvratil requested changes to D18557: autotests: remove QEXPECT_FAIL, the mysql bug got fixed..

If it's really fixed, let's just remove the code completely.

Sun, Jan 27, 9:12 PM · KDE PIM
dvratil requested changes to D18558: Fix "QIODevice::read" warnings..

The readAll()s after close() were needed IIRC, because reopening the socket and reading from it caused junk to be read from the buffer after reopening. This may have been caused by me doing something wrong. However, to make sure this does not keep happening, I'd suggest to always recreate the socket in doReconnect() instead of just reconnecting if it already exists.

Sun, Jan 27, 9:10 PM · KDE PIM

Fri, Jan 25

dvratil accepted D18093: Calculate screen scaling dynamically, so it always fits to the page.

Looks good

Fri, Jan 25, 2:46 PM · Plasma
dvratil accepted D18101: Don't reset the moved display position.

Looks OK to me.

Fri, Jan 25, 2:39 PM · Plasma

Wed, Jan 23

dvratil accepted D18456: actually look for mysql binaries in PATH.

Thanks for the fix, Harald. Merge this into Applications/18.12 branch please.

Wed, Jan 23, 9:38 AM · KDE PIM

Jan 17 2019

dvratil created T10366: [wiki] Document manual PostgreSQL db upgrade.
Jan 17 2019, 1:59 PM · KDE PIM

Jan 11 2019

dvratil committed R165:057555349928: AkRanges: simplify and cleanup the code (authored by dvratil).
AkRanges: simplify and cleanup the code
Jan 11 2019, 1:52 AM
dvratil committed R165:0a937882eac1: AkRanges: add a filter operation (authored by dvratil).
AkRanges: add a filter operation
Jan 11 2019, 1:52 AM
dvratil committed R165:c966872cbf08: Refine the AkRanges codebase (authored by dvratil).
Refine the AkRanges codebase
Jan 11 2019, 1:52 AM

Jan 8 2019

dvratil committed R165:0d4e999a417f: Fix a typo (authored by dvratil).
Fix a typo
Jan 8 2019, 3:50 PM
dvratil committed R165:434702229d58: Add more context some qCDebugs (authored by dvratil).
Add more context some qCDebugs
Jan 8 2019, 3:48 PM

Jan 4 2019

dvratil committed R1028:76ccdc5271da: Use strict equality operators in QML (authored by dvratil).
Use strict equality operators in QML
Jan 4 2019, 7:23 PM
dvratil committed R1028:33b356501447: Explicitly forbid copying of PasswordsModel::Node (authored by dvratil).
Explicitly forbid copying of PasswordsModel::Node
Jan 4 2019, 7:23 PM
dvratil committed R1028:92a91ecddb70: PasswordFilterModel: don't hide QSFPM's filterChanged() signal (authored by dvratil).
PasswordFilterModel: don't hide QSFPM's filterChanged() signal
Jan 4 2019, 7:23 PM
dvratil committed R1028:f74735a30546: Fix X-KDE-PluginInfo-Name (authored by dvratil).
Fix X-KDE-PluginInfo-Name
Jan 4 2019, 7:23 PM
dvratil committed R1028:066945537305: Use new-style connect (authored by dvratil).
Use new-style connect
Jan 4 2019, 7:23 PM
dvratil committed R165:f70b9e872686: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Jan 4 2019, 5:32 PM
dvratil closed D17879: Ensure StandardDirs::saveDir returns existing dir.
Jan 4 2019, 5:32 PM · KDE PIM
dvratil committed R165:28f2916db1a2: Ensure StandardDirs::saveDir returns existing dir (authored by modax).
Ensure StandardDirs::saveDir returns existing dir
Jan 4 2019, 5:32 PM
dvratil committed R165:2db662a26c05: Fix SQL syntax error in findOrphanedItems() (authored by modax).
Fix SQL syntax error in findOrphanedItems()
Jan 4 2019, 5:32 PM
dvratil closed D17876: Fix SQL syntax error in findOrphanedItems().
Jan 4 2019, 5:32 PM · KDE PIM
dvratil committed R165:3e47fbc309fa: Handle query prepare errors in QueryBuilder::exec (authored by modax).
Handle query prepare errors in QueryBuilder::exec
Jan 4 2019, 5:32 PM
dvratil closed D17877: Handle query prepare errors in QueryBuilder::exec.
Jan 4 2019, 5:32 PM · KDE PIM
dvratil added a comment to D17606: [WIP] Use <optional> if available..

@tcberner this can now be closed in favor of D17917.

Jan 4 2019, 4:47 PM · KDE PIM
dvratil accepted D17879: Ensure StandardDirs::saveDir returns existing dir.
Jan 4 2019, 4:41 PM · KDE PIM
dvratil accepted D17917: unifiedmailboxagent: Stop using std::optional..

Looks good. Commit it to Applications/18.12 branch, please. Thanks!

Jan 4 2019, 1:31 PM · KDE PIM

Dec 30 2018

dvratil added a comment to D17606: [WIP] Use <optional> if available..

@rakuco Yes, should be OK. I don't have access to my KDE ssh key right now so feel free to revert them and push it (to Applications/18.12 branch, then merge the branch to master), otherwise, I'll push it sometime next week.

Dec 30 2018, 7:20 PM · KDE PIM
dvratil accepted D17876: Fix SQL syntax error in findOrphanedItems().

Should go to Applications/18.12 (stable) branch.

Dec 30 2018, 7:15 PM · KDE PIM
dvratil accepted D17877: Handle query prepare errors in QueryBuilder::exec.

Looks good, thanks!

Dec 30 2018, 7:14 PM · KDE PIM

Dec 24 2018

dvratil accepted D17682: Show unconnected displays at the right side of the main screen.

Sorry for the delay, I did not notice the review.

Dec 24 2018, 4:13 PM · Plasma

Dec 19 2018

dvratil committed R165:89ee3d050f55: AkRanges: fix deduction of result type of transform() (authored by dvratil).
AkRanges: fix deduction of result type of transform()
Dec 19 2018, 10:56 PM
dvratil committed R165:2d3dfa147c70: AkRanges: make it possible to explictly construct range on existing container (authored by dvratil).
AkRanges: make it possible to explictly construct range on existing container
Dec 19 2018, 10:56 PM
dvratil accepted D17686: Redraw the slider if modes have changed.

Looks good to me. This whole thing could probably use some cleanup, but that's for another day :-)

Dec 19 2018, 5:00 PM · Plasma
dvratil added inline comments to D17657: Notify also if modes have changed.
Dec 19 2018, 4:54 PM · Plasma
dvratil accepted D17685: Notify also if modes have changed.

You can close the review for master and commit this to the stable branch, then merge stable to master.

Dec 19 2018, 4:50 PM · Plasma
dvratil accepted D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.

👍 Move the find_package calls as well.

Dec 19 2018, 4:46 PM · KDE PIM

Dec 17 2018

dvratil committed R165:3d53be982160: AkRanges: add operator< to LazyIterator (authored by dvratil).
AkRanges: add operator< to LazyIterator
Dec 17 2018, 1:42 AM
dvratil added a reviewer for D17636: Allow specifying custom MSVC toolset: vonreth.
Dec 17 2018, 1:04 AM
dvratil requested review of D17636: Allow specifying custom MSVC toolset.
Dec 17 2018, 1:03 AM

Dec 16 2018

dvratil added a comment to D17606: [WIP] Use <optional> if available..

I've recently run into the same problem on Akonadi on Windows, ended up allowing C++17 on Windows only and shipping a C++14-compatible implementation of C++17 optional in 3rdparty for everyone else.

Dec 16 2018, 10:44 AM · KDE PIM

Dec 15 2018

dvratil committed R165:a4e7f9310cef: Log time, level, category and more when logging to file (authored by dvratil).
Log time, level, category and more when logging to file
Dec 15 2018, 4:44 PM

Dec 13 2018

dvratil committed R82:661851e65dff: Remove AkonadiCore from target include directories (authored by dvratil).
Remove AkonadiCore from target include directories
Dec 13 2018, 9:37 AM
dvratil committed R42:0c8f74b9e580: Make sure xapian.h is always included first (authored by dvratil).
Make sure xapian.h is always included first
Dec 13 2018, 9:30 AM

Dec 11 2018

dvratil committed R165:fc98526f5b1c: Improve AkRanges, add transform operation (authored by dvratil).
Improve AkRanges, add transform operation
Dec 11 2018, 5:11 PM

Dec 10 2018

dvratil committed R1028:fd84f15810ed: Update link to git repo (authored by dvratil).
Update link to git repo
Dec 10 2018, 2:38 PM
dvratil committed R1028:0cbefe00f00b: Update README (authored by dvratil).
Update README
Dec 10 2018, 2:37 PM
dvratil committed R1028:fdc8ac4f81da: Fix the clipboard hint to not store the password in history (authored by dvratil).
Fix the clipboard hint to not store the password in history
Dec 10 2018, 2:14 PM

Dec 9 2018

dvratil committed R177:d55fdc617bf1: Install NamespaceJob and RFCCodecs camelcase headers (authored by dvratil).
Install NamespaceJob and RFCCodecs camelcase headers
Dec 9 2018, 6:06 PM

Dec 5 2018

dvratil committed R165:612925731625: Install VectorHelper header from shared (authored by dvratil).
Install VectorHelper header from shared
Dec 5 2018, 10:13 AM
dvratil committed R165:a13d01060f2d: Don't rely on STL implementation detail of nullopt (authored by dvratil).
Don't rely on STL implementation detail of nullopt
Dec 5 2018, 10:02 AM
dvratil committed R165:5699098e40f1: Use a ranges-like notation for container conversion (authored by dvratil).
Use a ranges-like notation for container conversion
Dec 5 2018, 12:22 AM
dvratil committed R165:25d476959c1c: Remove the duplicated VectorHelper (authored by dvratil).
Remove the duplicated VectorHelper
Dec 5 2018, 12:22 AM
dvratil committed R165:482315f4cbc7: Use 3rdparty Optional, name it akOptional (authored by dvratil).
Use 3rdparty Optional, name it akOptional
Dec 5 2018, 12:22 AM

Dec 4 2018

dvratil committed R165:41e9929f5bbb: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Dec 4 2018, 4:30 PM
dvratil committed R165:5d620cd60a43: Fix ModelSpy (and thus some model tests) (authored by dvratil).
Fix ModelSpy (and thus some model tests)
Dec 4 2018, 4:30 PM
dvratil committed R165:c52f5d0d95a4: Fix logic in akoptional.h (authored by dvratil).
Fix logic in akoptional.h
Dec 4 2018, 2:49 PM
dvratil committed R165:c783af75bc8c: Pretend MSVC supports feature test macros (authored by dvratil).
Pretend MSVC supports feature test macros
Dec 4 2018, 2:39 PM
dvratil committed R165:720456e8092a: Remove the deprecated std::unary_function (authored by dvratil).
Remove the deprecated std::unary_function
Dec 4 2018, 2:39 PM
dvratil committed R165:16ee220abf1c: Set /Zc:__cplusplus CXX flag in MSVC builds (authored by dvratil).
Set /Zc:__cplusplus CXX flag in MSVC builds
Dec 4 2018, 2:13 PM
dvratil committed R165:ceeb4f3a72b6: Disable std::auto_ptr checks in Item in C++17 (authored by dvratil).
Disable std::auto_ptr checks in Item in C++17
Dec 4 2018, 1:27 PM
dvratil added a reverting change for R165:b25c808942ef: One more try for MSVC: R165:a490a189e41a: Revert "One more try for MSVC".
Dec 4 2018, 1:02 PM
dvratil committed R165:a490a189e41a: Revert "One more try for MSVC" (authored by dvratil).
Revert "One more try for MSVC"
Dec 4 2018, 1:02 PM
dvratil committed R165:770a57f07388: Enable C++17 with MSVC (authored by dvratil).
Enable C++17 with MSVC
Dec 4 2018, 1:00 PM
dvratil committed R165:b25c808942ef: One more try for MSVC (authored by dvratil).
One more try for MSVC
Dec 4 2018, 12:13 PM
dvratil committed R165:d7b50cc61292: Try to fix build on MSVC (authored by dvratil).
Try to fix build on MSVC
Dec 4 2018, 11:47 AM
dvratil committed R165:68cec6c21357: Merge branch 'Applications/18.12' (authored by dvratil).
Merge branch 'Applications/18.12'
Dec 4 2018, 10:29 AM
dvratil committed R165:d2225d6bf5cc: Fix ItemStoreTest (authored by dvratil).
Fix ItemStoreTest
Dec 4 2018, 10:29 AM
dvratil added a reverting change for R165:94ed0cf7268d: Adapt TagHandlerTest to recent tag parent changes: R165:77091f0e7169: Revert "Adapt TagHandlerTest to recent tag parent changes".
Dec 4 2018, 10:29 AM
dvratil committed R165:77091f0e7169: Revert "Adapt TagHandlerTest to recent tag parent changes" (authored by dvratil).
Revert "Adapt TagHandlerTest to recent tag parent changes"
Dec 4 2018, 10:29 AM
dvratil committed R165:c37a236b8703: Rename Handlers to match the entity, operation and command names (authored by dvratil).
Rename Handlers to match the entity, operation and command names
Dec 4 2018, 10:29 AM