dvratil (Daniel Vrátil)
User

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (209 w, 5 d)
Availability
Available

Recent Activity

Tue, Apr 16

dvratil accepted D20554: Adapt to the Grantlee address model changes.
Tue, Apr 16, 12:33 PM · KDE PIM
dvratil accepted D20544: Adjust to Grantlee model changes.
Tue, Apr 16, 12:32 PM · KDE PIM
dvratil accepted D20543: Port displaying of emails to KContact::Email too.
Tue, Apr 16, 12:31 PM · KDE PIM
dvratil accepted D20545: Port phone numbers Grantlee model to use KContact gadgets directly.
Tue, Apr 16, 12:31 PM · KDE PIM
dvratil accepted D20507: Update Japanese holidays.

The format looks correct, I trust you checked the dates carefully. Thanks for the patch!

Tue, Apr 16, 12:26 PM · KDE PIM
dvratil accepted D20571: Add public holidays for Lower Saxony (Germany).

The format looks good, I trust you checked the dates carefully.

Tue, Apr 16, 12:23 PM · KDE PIM

Mon, Apr 15

dvratil accepted D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.
Mon, Apr 15, 9:46 PM · KDE PIM
dvratil committed R165:384ab29108d1: Remove Collection references from Akonadi (authored by dvratil).
Remove Collection references from Akonadi
Mon, Apr 15, 8:47 AM
dvratil closed D20346: Remove Collection references from Akonadi.
Mon, Apr 15, 8:47 AM · KDE PIM
dvratil accepted D20505: CollectionScheduler: list all collections initially, not just those with syncPref set..

Looks good. Will cause some more overhead during startup, but shouldn't be too bad to slow it down substantially.

Mon, Apr 15, 8:34 AM · KDE PIM
dvratil requested changes to D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.
Mon, Apr 15, 8:26 AM · KDE PIM
dvratil accepted D20539: Fix a crash..

Hmm, this is weird, GObject documentation does not say anything about g_object_set_property not allowing a NULL value or even crashing. Do you have a backtrace? I'm actually quite interested where it crashes (if it's a Gst bug or just an undocumented GObject quirk).

Mon, Apr 15, 8:21 AM
dvratil accepted D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.

Thanks! (you should go fix QtCreator now ;-))

Mon, Apr 15, 8:08 AM · KDE PIM
dvratil accepted D20483: CollectionScheduler: add tests for the actual QTimer interval.

Thanks!

Mon, Apr 15, 8:07 AM · KDE PIM
dvratil accepted D20497: Add email type and preference API.

Makes sense, it wouldn't make the code any better.

Mon, Apr 15, 8:06 AM · KDE PIM
dvratil added a comment to D19011: Thunderbolt KCM and KDED module.

I realized we still need an icon for Thunderbolt (and thus for this KCM) - @abetts, @andreask, @trickyricky26, @ndavis - could one of you help me out, please? I have no clue about icons...

Mon, Apr 15, 8:03 AM · Plasma
dvratil updated the diff for D20346: Remove Collection references from Akonadi.

Remove last references to referencing.

Mon, Apr 15, 7:59 AM · KDE PIM

Sun, Apr 14

dvratil accepted D20481: Cleanup DataMatrix leftovers after D20339 made those unnecessary.
Sun, Apr 14, 10:28 AM · KDE PIM
dvratil requested changes to D20497: Add email type and preference API.
Sun, Apr 14, 10:19 AM · KDE PIM

Fri, Apr 12

dvratil accepted D20362: Add test for CollectionScheduler, code cleanups, bugfixes..
Fri, Apr 12, 8:27 AM · KDE PIM
dvratil requested changes to D20483: CollectionScheduler: add tests for the actual QTimer interval.
Fri, Apr 12, 8:26 AM · KDE PIM
dvratil requested changes to D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.
Fri, Apr 12, 8:21 AM · KDE PIM
dvratil accepted D20379: Avoid using subtitles of a previously played media.

Looks good now, thanks!

Fri, Apr 12, 8:20 AM
dvratil requested changes to D20481: Cleanup DataMatrix leftovers after D20339 made those unnecessary.
Fri, Apr 12, 8:09 AM · KDE PIM
dvratil accepted D20482: Add method to retrieve normalized (dialable) phone number.

Looks good

Fri, Apr 12, 8:08 AM · KDE PIM

Thu, Apr 11

dvratil accepted D20415: Improve handling of clashing country name strings.
Thu, Apr 11, 12:32 PM · KDE PIM

Tue, Apr 9

dvratil requested changes to D20379: Avoid using subtitles of a previously played media.
Tue, Apr 9, 12:25 PM
dvratil requested changes to D20379: Avoid using subtitles of a previously played media.
Tue, Apr 9, 9:43 AM
dvratil requested changes to D20362: Add test for CollectionScheduler, code cleanups, bugfixes..
Tue, Apr 9, 9:19 AM · KDE PIM

Mon, Apr 8

dvratil created T10774: Revealuate enabling CONDSTORE for Gmail.
Mon, Apr 8, 12:03 PM · KDE PIM
dvratil created T10773: QRESYNC support in IMAP.
Mon, Apr 8, 12:01 PM · KDE PIM
dvratil added inline comments to D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.
Mon, Apr 8, 11:01 AM · KDE PIM

Sun, Apr 7

dvratil accepted D20353: Fix dialing via KDE Connect, and make it the default.

Haven't tried it, but looks sensible.

Sun, Apr 7, 3:44 PM · KDE PIM
dvratil accepted D20354: Default to OSM for showing addresses on a map.
Sun, Apr 7, 3:41 PM · KDE PIM
dvratil accepted D20355: autotests: remove code duplication by moving try+catch+qWarning+qFatal to FakeAkonadiServer.

Nice!

Sun, Apr 7, 3:40 PM · KDE PIM
dvratil added inline comments to D20346: Remove Collection references from Akonadi.
Sun, Apr 7, 1:45 PM · KDE PIM
dvratil committed R199:7fba3c49f0ec: Remove support for Collection references (authored by dvratil).
Remove support for Collection references
Sun, Apr 7, 1:40 PM
dvratil closed D20348: Remove support for Collection references.
Sun, Apr 7, 1:40 PM · KDE PIM
dvratil committed R89:5931dac2ea64: Remove KPIM::Person and related jobs (authored by dvratil).
Remove KPIM::Person and related jobs
Sun, Apr 7, 1:38 PM
dvratil closed D20347: Remove KPIM::Person and related jobs.
Sun, Apr 7, 1:38 PM · KDE PIM
dvratil committed R165:62baeb6aa29b: Make Akonadi compile without QT_STRICT_ITERATORS (authored by dvratil).
Make Akonadi compile without QT_STRICT_ITERATORS
Sun, Apr 7, 1:34 PM
dvratil closed D20306: Make Akonadi compile without QT_STRICT_ITERATORS.
Sun, Apr 7, 1:34 PM · KDE PIM
dvratil added reviewers for D20348: Remove support for Collection references: vkrause, dfaure.
Sun, Apr 7, 1:14 PM · KDE PIM
dvratil added reviewers for D20347: Remove KPIM::Person and related jobs: vkrause, dfaure.
Sun, Apr 7, 1:14 PM · KDE PIM
dvratil added reviewers for D20346: Remove Collection references from Akonadi: vkrause, dfaure.
Sun, Apr 7, 1:13 PM · KDE PIM
dvratil added reviewers for D20306: Make Akonadi compile without QT_STRICT_ITERATORS: vkrause, dfaure.
Sun, Apr 7, 1:12 PM · KDE PIM
dvratil requested review of D20348: Remove support for Collection references.
Sun, Apr 7, 1:00 PM · KDE PIM
dvratil committed R210:6b718a8559f7: Remove Kolab <-> LDAP person identity merging code (authored by dvratil).
Remove Kolab <-> LDAP person identity merging code
Sun, Apr 7, 12:45 PM
dvratil closed D20344: Remove Kolab <-> LDAP person identity merging code.
Sun, Apr 7, 12:45 PM · KDE PIM
dvratil requested review of D20347: Remove KPIM::Person and related jobs.
Sun, Apr 7, 12:42 PM · KDE PIM
dvratil accepted D20339: Remove the DataMatrix code, just the QR code is enough.
Sun, Apr 7, 12:42 PM · KDE PIM
dvratil requested review of D20346: Remove Collection references from Akonadi.
Sun, Apr 7, 12:41 PM · KDE PIM
dvratil abandoned D19830: Force build order to prevent build happening before ui .h file exists.
Sun, Apr 7, 12:31 PM · KDE PIM
dvratil commandeered D19830: Force build order to prevent build happening before ui .h file exists.
Sun, Apr 7, 12:31 PM · KDE PIM
dvratil accepted D20243: ItemSync: skip handling remote items if local changes failed.

Thanks!

Sun, Apr 7, 12:30 PM · KDE PIM
dvratil triaged T10771: Remove QWebEngine dependency as High priority.
Sun, Apr 7, 12:27 PM · LibKGAPI
dvratil abandoned D20337: Rollback changes to CollectionReferenceManager on DB rollback.

I found a better fix: remove collection referencing.

Sun, Apr 7, 12:25 PM · KDE PIM
dvratil accepted D20338: Silence fall-through warnings where fall-through is intended.
Sun, Apr 7, 12:24 PM · KDE PIM
dvratil requested review of D20344: Remove Kolab <-> LDAP person identity merging code.
Sun, Apr 7, 12:00 PM · KDE PIM
dvratil accepted D20341: KF5AkonadiMacros: fix documentation and typo in variable name.
Sun, Apr 7, 10:18 AM · KDE PIM
dvratil added a comment to D20339: Remove the DataMatrix code, just the QR code is enough.

Shouldn't the code that generates the datamatrix data also removed? Or does that lives elsewhere?

Sun, Apr 7, 10:18 AM · KDE PIM
dvratil accepted D20326: Akonadiserver: rework handling of database deadlocks..
Sun, Apr 7, 9:25 AM · KDE PIM
dvratil updated the diff for D20337: Rollback changes to CollectionReferenceManager on DB rollback.

Unfuckup

Sun, Apr 7, 8:42 AM · KDE PIM
dvratil updated the diff for D20337: Rollback changes to CollectionReferenceManager on DB rollback.

Address review comments

Sun, Apr 7, 8:37 AM · KDE PIM
dvratil requested review of D20337: Rollback changes to CollectionReferenceManager on DB rollback.
Sun, Apr 7, 7:42 AM · KDE PIM
dvratil accepted D20296: Port away from SortableList::insertSorted.
Sun, Apr 7, 7:40 AM · KDE PIM
dvratil accepted D20309: Remove SortableList.

Looks good 👍

Sun, Apr 7, 7:12 AM · KDE PIM

Sat, Apr 6

dvratil requested changes to D20326: Akonadiserver: rework handling of database deadlocks..
Sat, Apr 6, 10:56 PM · KDE PIM
dvratil accepted D20297: Scope loop variable correctly.
Sat, Apr 6, 10:55 PM · KDE PIM
dvratil accepted D20325: Remove deprecated and unused deletion notification methods.
Sat, Apr 6, 10:05 PM · KDE PIM
dvratil accepted D20323: Remove unused deprecated method.
Sat, Apr 6, 9:53 PM · KDE PIM
dvratil accepted D20321: Remove unused member fetchAllAttributes in CollectionFetchScope.
Sat, Apr 6, 9:53 PM · KDE PIM
dvratil requested changes to D20296: Port away from SortableList::insertSorted.

Looks OK, but could you factor it out into a function too, please?

Sat, Apr 6, 9:01 PM · KDE PIM
dvratil accepted D20308: Remove local copy of KCalCore::DateList typedef.
Sat, Apr 6, 8:55 PM · KDE PIM
dvratil accepted D20307: Use KCalCore's typedefs rather the about to go away SortableList.
Sat, Apr 6, 8:55 PM · KDE PIM
dvratil accepted D20305: Remove unnecessary list copy.
Sat, Apr 6, 8:54 PM · KDE PIM
dvratil accepted D20304: Remove the last usage of qSortUnique.
Sat, Apr 6, 5:32 PM · KDE PIM
dvratil accepted D20303: Port away from SortableList::findLT.
Sat, Apr 6, 5:32 PM · KDE PIM
dvratil accepted D20298: Port away from SortableList::findGE/GT.
Sat, Apr 6, 5:27 PM · KDE PIM
dvratil added a subtask for T10768: Kill TransactionSequence: T10770: Move CollectionSync into the Server.
Sat, Apr 6, 5:12 PM · KDE PIM
dvratil edited parent tasks for T10770: Move CollectionSync into the Server, added: T10768: Kill TransactionSequence; removed: T10769: Move ItemSync into the Server.
Sat, Apr 6, 5:12 PM · KDE PIM
dvratil removed a subtask for T10769: Move ItemSync into the Server: T10770: Move CollectionSync into the Server.
Sat, Apr 6, 5:12 PM · KDE PIM
dvratil created T10770: Move CollectionSync into the Server.
Sat, Apr 6, 5:12 PM · KDE PIM
dvratil created T10769: Move ItemSync into the Server.
Sat, Apr 6, 5:11 PM · KDE PIM
dvratil created T10768: Kill TransactionSequence.
Sat, Apr 6, 5:11 PM · KDE PIM
dvratil accepted D20295: Port away from SortableList::removeSorted.
Sat, Apr 6, 3:49 PM · KDE PIM
dvratil accepted D20294: Port away from SortableList::sortUnique.
Sat, Apr 6, 2:39 PM · KDE PIM
dvratil closed D20289: Remove MinimumComboBox.
Sat, Apr 6, 2:12 PM · KDE PIM
dvratil committed R95:6b870c0ef899: Remove MinimumComboBox (authored by dvratil).
Remove MinimumComboBox
Sat, Apr 6, 2:12 PM
dvratil committed R92:d19ed578755e: Fix FilterActionWithUrlTest (authored by dvratil).
Fix FilterActionWithUrlTest
Sat, Apr 6, 2:12 PM
dvratil closed D20290: Fix FilterActionWithUrlTest.
Sat, Apr 6, 2:12 PM · KDE PIM
dvratil committed R92:883cac02e2aa: Remove MinimumComboBox (authored by dvratil).
Remove MinimumComboBox
Sat, Apr 6, 2:11 PM
dvratil closed D20288: Remove MinimumComboBox.
Sat, Apr 6, 2:11 PM · KDE PIM
dvratil committed R91:b7ae99f21cbc: Replace MinimumComboBox with regular QComboBox (authored by dvratil).
Replace MinimumComboBox with regular QComboBox
Sat, Apr 6, 2:10 PM
dvratil closed D20278: Replace MinimumComboBox with regular QComboBox.
Sat, Apr 6, 2:10 PM · KDE PIM
dvratil requested review of D20306: Make Akonadi compile without QT_STRICT_ITERATORS.
Sat, Apr 6, 2:08 PM · KDE PIM
dvratil committed R165:cf9c714a558f: Revert "QT_STRICT_ITERATORS is defined in KDEFrameworkCompilerSettings in debug" (authored by dvratil).
Revert "QT_STRICT_ITERATORS is defined in KDEFrameworkCompilerSettings in debug"
Sat, Apr 6, 12:35 PM
dvratil added a reverting change for R165:0a577bcf3120: QT_STRICT_ITERATORS is defined in KDEFrameworkCompilerSettings in debug: R165:cf9c714a558f: Revert "QT_STRICT_ITERATORS is defined in KDEFrameworkCompilerSettings in debug".
Sat, Apr 6, 12:35 PM
dvratil accepted D20294: Port away from SortableList::sortUnique.

Thanks!

Sat, Apr 6, 12:26 PM · KDE PIM
dvratil accepted D20291: Add unittest for clearPayload. Unfortunately it passes :-).
Sat, Apr 6, 12:25 PM · KDE PIM