dvratil (Daniel Vrátil)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (254 w, 5 d)
Availability
Available

Recent Activity

Today

dvratil added a comment to D27722: [resources/maildir] Don't save "file:" schema to the config.

Nicely done!

Fri, Feb 28, 8:29 PM · KDE PIM
dvratil requested review of D27729: fix: make hwdata truly a runtime dependency.
Fri, Feb 28, 8:27 PM · KWin

Wed, Feb 26

dvratil requested review of D10042: feat: parse EDID on the backend side.
Wed, Feb 26, 12:19 PM · Plasma
dvratil added a dependency for D27677: feat: fix build after EDID changes in libkscreen: D10042: feat: parse EDID on the backend side.
Wed, Feb 26, 12:18 PM · Plasma
dvratil added a dependent revision for D10042: feat: parse EDID on the backend side: D27677: feat: fix build after EDID changes in libkscreen.
Wed, Feb 26, 12:18 PM · Plasma
dvratil requested review of D27677: feat: fix build after EDID changes in libkscreen.
Wed, Feb 26, 12:18 PM · Plasma
dvratil added a dependent revision for D10042: feat: parse EDID on the backend side: D27675: feat: avoid duplicated text when assembling user-facing output names.
Wed, Feb 26, 12:15 PM · Plasma
dvratil added a dependency for D27675: feat: avoid duplicated text when assembling user-facing output names: D10042: feat: parse EDID on the backend side.
Wed, Feb 26, 12:15 PM · Plasma
dvratil added reviewers for D10042: feat: parse EDID on the backend side: Plasma, romangg.
Wed, Feb 26, 12:15 PM · Plasma
dvratil updated the diff for D10042: feat: parse EDID on the backend side.
  • Rebased on master
Wed, Feb 26, 12:14 PM · Plasma
dvratil added a comment to D27675: feat: avoid duplicated text when assembling user-facing output names.

This is needed for D10042 (which I'm rebasing right now) when even on KWayland the KScreen::Output will have EDID attached (assembled from information provided by KWayland/KWin). Since on KWayland the output name already is Vendor Model adding the information from EDID ends up with the string Vendor Model (Vendor Model), that is in my case Eizo Nanao Corporation DP-5-EV2736W/96211045 (Eizo Nanao Corporation DP-5-EV2736W/96211045), which is really long and kinda pointless.

Wed, Feb 26, 12:08 PM · Plasma
dvratil requested review of D27675: feat: avoid duplicated text when assembling user-facing output names.
Wed, Feb 26, 12:00 PM · Plasma
dvratil committed R108:33a1777a5ab0: Decode full monitor vendor name from EDID using hwdata (authored by dvratil).
Decode full monitor vendor name from EDID using hwdata
Wed, Feb 26, 11:37 AM
dvratil closed D10041: Decode full monitor vendor name from EDID using hwdata.
Wed, Feb 26, 11:37 AM · KWin
dvratil updated the test plan for D10041: Decode full monitor vendor name from EDID using hwdata.
Wed, Feb 26, 11:36 AM · KWin
dvratil committed R242:b6213cdd59cc: Dialog: disconnect from QWindow signals in destructor (authored by dvratil).
Dialog: disconnect from QWindow signals in destructor
Wed, Feb 26, 9:00 AM
dvratil closed D27671: Dialog: disconnect from QWindow signals in destructor.
Wed, Feb 26, 9:00 AM · Frameworks
dvratil added a comment to D23339: Fix memory leak in ConfigView and Dialog.

Fix for the crash: https://phabricator.kde.org/D27671

Wed, Feb 26, 8:57 AM · Frameworks
dvratil added a dependent revision for D23339: Fix memory leak in ConfigView and Dialog: D27671: Dialog: disconnect from QWindow signals in destructor.
Wed, Feb 26, 8:54 AM · Frameworks
dvratil added a dependency for D27671: Dialog: disconnect from QWindow signals in destructor: D23339: Fix memory leak in ConfigView and Dialog.
Wed, Feb 26, 8:54 AM · Frameworks
dvratil requested review of D27671: Dialog: disconnect from QWindow signals in destructor.
Wed, Feb 26, 8:53 AM · Frameworks

Tue, Feb 25

dvratil abandoned D9462: KCM: show scaled outputs correctly.
Tue, Feb 25, 4:38 PM · Plasma
dvratil abandoned D9464: KCM: add support for non-integer output scaling.
Tue, Feb 25, 4:36 PM · Plasma
dvratil abandoned D9461: Report modes unscaled and geometry scaled.
Tue, Feb 25, 4:36 PM · Plasma
dvratil abandoned D7546: Replace the "Retrieving folder contents" and offline screens with widgets.
Tue, Feb 25, 4:30 PM · KDE PIM
dvratil abandoned D6397: Add xapian-core to win32libs.
Tue, Feb 25, 4:29 PM
dvratil abandoned D4791: RFC: Split mail folder view into one view per account using tabs.
Tue, Feb 25, 4:28 PM · KDE PIM
dvratil abandoned D9463: XRandR: implement scaling support.
Tue, Feb 25, 4:25 PM · Plasma
dvratil abandoned D9460: KCM: Dynamically resize QMLOutput root dimensions directly in QML.
Tue, Feb 25, 4:14 PM · Plasma
dvratil added a reviewer for D10041: Decode full monitor vendor name from EDID using hwdata: Plasma.
Tue, Feb 25, 3:38 PM · KWin
dvratil updated the diff for D10041: Decode full monitor vendor name from EDID using hwdata.
  • rebase on master
  • add cmake check for hwdata
Tue, Feb 25, 3:37 PM · KWin
dvratil committed R104:51fd586686a8: refactor: fix various compiler warnings (authored by dvratil).
refactor: fix various compiler warnings
Tue, Feb 25, 3:22 PM
dvratil closed D27626: refactor: fix various compiler warnings.
Tue, Feb 25, 3:22 PM · Plasma
dvratil added a comment to D27626: refactor: fix various compiler warnings.

Also note that noexcept is not a compile-time check, it's a hint to enable some optimizations. It makes a difference when using standard library containers, e.g. std::vector<T> will perform a copy if T's move constructor is not noexcept in order to guarantee strong exceptions safety.

Tue, Feb 25, 3:21 PM · Plasma
dvratil added a comment to D27626: refactor: fix various compiler warnings.

A good rule of a thumb is that your move constructor and assignment operator should always be noexcept unless you have a very good reason for them not to be. Qt has most move constructors marked as noexcept - I found a few that are not marked but that looks more like an oversight rather than intent, more so that Qt does not use exceptions - so if you have a type composed Qt types, making the constructor noexcept is perfectly safe. For custom types, even if their move constructors/assignment operators are not marked as noexcept it's fairly safe to assume they do not throw since we generally do not use exceptions in KDE.

Tue, Feb 25, 3:16 PM · Plasma
dvratil added a reviewer for D21902: Calendar: add method to show event details: Plasma.
Tue, Feb 25, 2:10 PM · Frameworks
dvratil updated the diff for D21902: Calendar: add method to show event details.
  • Rebase to master
Tue, Feb 25, 2:10 PM · Frameworks
dvratil committed R242:1e11099c1616: Fix initialization order (authored by dvratil).
Fix initialization order
Tue, Feb 25, 1:32 PM
dvratil closed D27627: Fix initialization order.
Tue, Feb 25, 1:32 PM · Frameworks
dvratil committed R242:4b93b71a4924: Fix memory leak in ConfigView and Dialog (authored by dvratil).
Fix memory leak in ConfigView and Dialog
Tue, Feb 25, 1:31 PM
dvratil closed D23339: Fix memory leak in ConfigView and Dialog.
Tue, Feb 25, 1:31 PM · Frameworks
dvratil committed R110:069bb65af0d0: fix: handle when backend fails to load/initialize (authored by dvratil).
fix: handle when backend fails to load/initialize
Tue, Feb 25, 1:30 PM
dvratil committed R110:e0af3780a95f: Merge branch 'Plasma/5.18' (authored by dvratil).
Merge branch 'Plasma/5.18'
Tue, Feb 25, 1:30 PM
dvratil closed D27625: fix: handle when backend fails to load/initialize.
Tue, Feb 25, 1:30 PM · Plasma
dvratil committed R110:ff98585ea554: fix: handle when backend fails to load/initialize (authored by dvratil).
fix: handle when backend fails to load/initialize
Tue, Feb 25, 1:30 PM
dvratil added inline comments to D27626: refactor: fix various compiler warnings.
Tue, Feb 25, 1:18 PM · Plasma

Mon, Feb 24

dvratil added inline comments to D27096: Refactoring, improve validation in kcm, optimize.
Mon, Feb 24, 4:17 PM · Plasma
dvratil requested review of D27627: Fix initialization order.
Mon, Feb 24, 3:19 PM · Frameworks
dvratil added reviewers for D23339: Fix memory leak in ConfigView and Dialog: Plasma, Frameworks.
Mon, Feb 24, 3:16 PM · Frameworks
dvratil updated the diff for D23339: Fix memory leak in ConfigView and Dialog.
  • Rebase on current master
Mon, Feb 24, 3:16 PM · Frameworks
dvratil accepted D27578: IncidenceEditor: don't save the last used calendar if the user rejects the dialog.
Mon, Feb 24, 3:06 PM · KDE PIM
dvratil accepted D26821: Fix missing link libraries to CMakeLists.txt.
Mon, Feb 24, 3:05 PM · KDE PIM
dvratil requested review of D27626: refactor: fix various compiler warnings.
Mon, Feb 24, 3:03 PM · Plasma
dvratil requested review of D27625: fix: handle when backend fails to load/initialize.
Mon, Feb 24, 2:14 PM · Plasma
dvratil committed R110:691c85879caf: fix(kwayland): wait longer for connection timeout and retry (authored by dvratil).
fix(kwayland): wait longer for connection timeout and retry
Mon, Feb 24, 1:58 PM
dvratil closed D27618: fix(kwayland): wait longer for connection timeout and retry.
Mon, Feb 24, 1:58 PM · Plasma
dvratil updated the summary of D27618: fix(kwayland): wait longer for connection timeout and retry.
Mon, Feb 24, 12:05 PM · Plasma
dvratil requested review of D27618: fix(kwayland): wait longer for connection timeout and retry.
Mon, Feb 24, 9:43 AM · Plasma

Sun, Feb 23

dvratil accepted D27560: KOrganizer New Event: consider current time when setting the default start time.
Sun, Feb 23, 2:13 PM · KDE PIM

Fri, Feb 21

dvratil committed R110:ecea544dd071: test: query correct output (authored by dvratil).
test: query correct output
Fri, Feb 21, 1:31 PM
dvratil accepted D27526: Port away from KDBusConnectionPool.
Fri, Feb 21, 1:02 PM · KDE PIM
dvratil committed R110:2fcd093919b8: fix(autotests): fix simpleWrite test in kwaylandbackendtest (authored by dvratil).
fix(autotests): fix simpleWrite test in kwaylandbackendtest
Fri, Feb 21, 12:59 PM
dvratil closed D27537: Fix simpleWrite test in kwaylandbackendtest.
Fri, Feb 21, 12:59 PM · Plasma
dvratil closed D27538: Registry: don't destroy the callback on globalsync.
Fri, Feb 21, 11:54 AM · Frameworks
dvratil committed R127:4ceb35672dfa: Registry: don't destroy the callback on globalsync (authored by dvratil).
Registry: don't destroy the callback on globalsync
Fri, Feb 21, 11:54 AM
dvratil committed R110:d5304fd4e4f8: Merge branch 'Plasma/5.18' (authored by dvratil).
Merge branch 'Plasma/5.18'
Fri, Feb 21, 11:53 AM
dvratil committed R110:63cab28e74ee: fix(kwayland): remove code with side-effects from Q_ASSERT (authored by dvratil).
fix(kwayland): remove code with side-effects from Q_ASSERT
Fri, Feb 21, 11:51 AM
dvratil closed D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.
Fri, Feb 21, 11:51 AM · Plasma
dvratil updated the summary of D27538: Registry: don't destroy the callback on globalsync.
Fri, Feb 21, 9:25 AM · Frameworks
dvratil requested review of D27538: Registry: don't destroy the callback on globalsync.
Fri, Feb 21, 9:25 AM · Frameworks
dvratil updated the summary of D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.
Fri, Feb 21, 9:21 AM · Plasma
dvratil requested review of D27537: Fix simpleWrite test in kwaylandbackendtest.
Fri, Feb 21, 9:21 AM · Plasma
dvratil updated the diff for D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.
  • Add bug reference
Fri, Feb 21, 9:18 AM · Plasma
dvratil updated the diff for D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.
  • Fix typo
Fri, Feb 21, 7:43 AM · Plasma
dvratil added a reviewer for D27536: fix(kwayland): remove code with side-effects from Q_ASSERT: Plasma.
Fri, Feb 21, 7:42 AM · Plasma
dvratil requested review of D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.
Fri, Feb 21, 7:41 AM · Plasma

Wed, Feb 19

dvratil accepted D27510: Remove usage of KDBusConnectionPool.
Wed, Feb 19, 8:12 PM · KDE PIM
dvratil committed R477:fb396456a446: Merge branch 'release/19.12' (authored by dvratil).
Merge branch 'release/19.12'
Wed, Feb 19, 11:32 AM
dvratil committed R477:48f487f06e62: Fix typo in event status (authored by gbs).
Fix typo in event status
Wed, Feb 19, 11:30 AM
dvratil closed D27374: Fix typo in event status.
Wed, Feb 19, 11:30 AM · KDE PIM
dvratil accepted D27374: Fix typo in event status.
Wed, Feb 19, 11:23 AM · KDE PIM

Sat, Feb 1

dvratil accepted D27062: Handle 410 Gone errors during Calendar sync.

Nice, thanks!

Sat, Feb 1, 9:02 AM · KDE PIM

Jan 22 2020

dvratil committed R1028:d5c7d0f832df: Clang-tidy fixes (authored by dvratil).
Clang-tidy fixes
Jan 22 2020, 1:05 PM
dvratil committed R1028:c616cd939fbc: Run the abbreviation matcher in background threads (authored by dvratil).
Run the abbreviation matcher in background threads
Jan 22 2020, 1:04 PM
dvratil committed R1028:2667be0cd434: Bump minimum required Qt and Frameworks (authored by dvratil).
Bump minimum required Qt and Frameworks
Jan 22 2020, 1:04 PM
dvratil committed R1028:8079dc6bd1a1: Update dependencies in README (authored by dvratil).
Update dependencies in README
Jan 22 2020, 1:04 PM

Jan 13 2020

dvratil committed R156:2cd0e36d2722: Merge branch 'release/19.12' (authored by dvratil).
Merge branch 'release/19.12'
Jan 13 2020, 12:50 PM
dvratil committed R156:0a71da4e3caa: Google provider: limit requested OAuth scopes (authored by dvratil).
Google provider: limit requested OAuth scopes
Jan 13 2020, 12:49 PM
dvratil closed D26454: Google provider: limit requested OAuth scopes.
Jan 13 2020, 12:49 PM

Jan 7 2020

dvratil committed R165:1a58ba67960f: Port away from deprecated Qt API (authored by dvratil).
Port away from deprecated Qt API
Jan 7 2020, 12:06 PM
dvratil committed R165:156eaa59d95a: Remove the now invalid Selected state from Connection (authored by dvratil).
Remove the now invalid Selected state from Connection
Jan 7 2020, 12:06 PM

Jan 6 2020

dvratil updated the summary of D26454: Google provider: limit requested OAuth scopes.
Jan 6 2020, 9:46 AM
dvratil updated the diff for D26454: Google provider: limit requested OAuth scopes.
  • Remove unrelated changes
Jan 6 2020, 9:46 AM
dvratil requested review of D26454: Google provider: limit requested OAuth scopes.
Jan 6 2020, 9:44 AM
dvratil accepted D26396: fix(legal): Add LiCENSE files.

Makes sense. Thanks!

Jan 6 2020, 7:55 AM
dvratil added a comment to D26433: Attempt to fix the Windows build after 34fdee065da2ddd.

Already fixed here: https://phabricator.kde.org/R165:253bb02813f18cf2f7d38a8648b2847b6d5f2c7e

Jan 6 2020, 7:54 AM · KDE PIM

Jan 5 2020

dvratil committed R165:384d6f1c4aee: Fix possible crash due to QStringBuilder auto type (authored by dvratil).
Fix possible crash due to QStringBuilder auto type
Jan 5 2020, 2:44 PM
dvratil committed R165:6ea76b4f1909: Partially revert porting away from serviceOwnerChanged signal (authored by dvratil).
Partially revert porting away from serviceOwnerChanged signal
Jan 5 2020, 2:44 PM
dvratil added a reverting change for R165:5242bf2718e4: Port AgentManager away from deprecated serviceOwnerChanged signal: R165:6ea76b4f1909: Partially revert porting away from serviceOwnerChanged signal.
Jan 5 2020, 2:44 PM
dvratil committed R165:253bb02813f1: Fix Windows build (authored by dvratil).
Fix Windows build
Jan 5 2020, 1:24 PM