dvratil (Daniel Vrátil)
User

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (218 w, 15 h)
Availability
Available

Recent Activity

Today

dvratil committed R165:39657be4a18d: Tune log levels of some messages in akonadi_control (authored by dvratil).
Tune log levels of some messages in akonadi_control
Sun, Jun 16, 5:19 PM
dvratil added a comment to D21838: Add Drive resource and example..

To deprecate an entire class, change its the export macro to KGAPIDRIVE_DEPRECATED_EXPORT. If you want to deprecate just a particular method but not the whole class, prefix its definition with KGAPIDRIVE_DEPRECATED.

Sun, Jun 16, 10:54 AM · LibKGAPI, KDE PIM

Wed, Jun 12

dvratil accepted D21650: Shorten sockets file path.

Thanks!

Wed, Jun 12, 8:36 AM · KDE PIM

Mon, Jun 10

dvratil committed R165:0810593c1e48: Fix initializing Postgres database (authored by dvratil).
Fix initializing Postgres database
Mon, Jun 10, 9:22 AM
dvratil closed D21716: Fix initializing Postgres database.
Mon, Jun 10, 9:22 AM · KDE PIM
dvratil committed R165:c059d0542512: Raise limit for PimItem.remoteId to 1024 characters (authored by dvratil).
Raise limit for PimItem.remoteId to 1024 characters
Mon, Jun 10, 9:22 AM
dvratil closed D21714: Raise limit for PimItem.remoteId to 1024 characters.
Mon, Jun 10, 9:22 AM · KDE PIM
dvratil updated the summary of D21714: Raise limit for PimItem.remoteId to 1024 characters.
Mon, Jun 10, 9:16 AM · KDE PIM
dvratil requested review of D21716: Fix initializing Postgres database.
Mon, Jun 10, 9:15 AM · KDE PIM
dvratil updated the diff for D21714: Raise limit for PimItem.remoteId to 1024 characters.
  • Add bug reference
Mon, Jun 10, 9:14 AM · KDE PIM
dvratil updated the diff for D21714: Raise limit for PimItem.remoteId to 1024 characters.
  • Remove arcanist mess up
Mon, Jun 10, 9:12 AM · KDE PIM
dvratil updated the diff for D21714: Raise limit for PimItem.remoteId to 1024 characters.
  • Fix initializing Postgres database
Mon, Jun 10, 9:12 AM · KDE PIM
dvratil updated the diff for D21714: Raise limit for PimItem.remoteId to 1024 characters.
  • Fix initializing Postgres database
Mon, Jun 10, 9:10 AM · KDE PIM
dvratil requested review of D21714: Raise limit for PimItem.remoteId to 1024 characters.
Mon, Jun 10, 9:09 AM · KDE PIM
dvratil accepted D21689: Remove unused scheduler class.
Mon, Jun 10, 7:15 AM · KDE PIM
dvratil accepted D21688: Remove the last remaining maps using Attendee pointers as keys.
Mon, Jun 10, 7:15 AM · KDE PIM
dvratil committed R256:1f4a6ed2173e: Fix Kontact manifest (authored by vkrause).
Fix Kontact manifest
Mon, Jun 10, 7:13 AM

Sun, Jun 9

dvratil accepted D21683: Remove copy of Akonadi's supertrait.h.
Sun, Jun 9, 9:13 AM · KDE PIM

Sat, Jun 8

dvratil accepted D21464: IMAP: Option to use system proxy settings (Configuration and GUI).
Sat, Jun 8, 11:49 AM · KDE PIM
dvratil accepted D21463: KIMAP: Option to use system proxy settings (Core part).
Sat, Jun 8, 11:49 AM · KDE PIM
dvratil requested changes to D21650: Shorten sockets file path.

Good idea, this generally opens a new range of possibilities to simplify the code a bit, since the socket will now exist in user-specific directory (unlike until now it existed in /tmp on Linux, which could possibly clash with other users if it were called only "akonadi", hence the username and random string) so the name can be deterministic without random strings.

Sat, Jun 8, 11:46 AM · KDE PIM
dvratil accepted D21662: Use a vector rather than a map for the attendee status.

You could use emplace() instead of insert() to create the status in-place, but probably doesn't make much of a difference here.

Sat, Jun 8, 11:27 AM · KDE PIM
dvratil accepted D21663: Fix use after free ASAN failure caused by fromRawData use on a temporary.
Sat, Jun 8, 11:24 AM · KDE PIM
dvratil accepted D21665: Don't rely on Attendee being a pointer.
Sat, Jun 8, 11:23 AM · KDE PIM

Fri, Jun 7

dvratil committed R165:179bd0e766b3: Fix MSVC build (authored by dvratil).
Fix MSVC build
Fri, Jun 7, 10:00 PM

Sun, Jun 2

dvratil added inline comments to D21544: [RFC] First draft of the new async client API to interact with Akonadi.
Sun, Jun 2, 2:18 PM · KDE PIM
dvratil requested review of D21544: [RFC] First draft of the new async client API to interact with Akonadi.
Sun, Jun 2, 2:15 PM · KDE PIM
dvratil accepted D21537: Replace IncidenceBase::deleteAttendee with setAttendee().
Sun, Jun 2, 12:59 PM · KDE PIM
dvratil accepted D21536: Simplify AttendeeTableModel construction.
Sun, Jun 2, 12:59 PM · KDE PIM
dvratil accepted D21535: Use a vector rather than a hash for storing attendee/combobox pairs.
Sun, Jun 2, 12:57 PM · KDE PIM
dvratil accepted D21534: Move attendee UID generation out of IncidenceBase::addAttendee.
Sun, Jun 2, 12:56 PM · KDE PIM
dvratil committed R871:dd95de337e30: Fix the 'Report bug' button being always disabled (authored by dvratil).
Fix the 'Report bug' button being always disabled
Sun, Jun 2, 12:56 PM
dvratil committed R871:18d003013594: Merge branch 'Plasma/5.16' (authored by dvratil).
Merge branch 'Plasma/5.16'
Sun, Jun 2, 12:56 PM
dvratil closed D21527: Fix the 'Report bug' button being always disabled.
Sun, Jun 2, 12:56 PM · Plasma
dvratil committed R165:eb8c5dc661e2: Set KAboutData in AgentBase to enable reporting from DrKonqi (authored by dvratil).
Set KAboutData in AgentBase to enable reporting from DrKonqi
Sun, Jun 2, 12:52 PM
dvratil closed D21512: Set KAboutData in AgentBase to enable reporting from DrKonqi.
Sun, Jun 2, 12:52 PM · KDE PIM
dvratil committed R165:b893c7c99718: Fix return-std-move warning in CollectionStatistics (authored by dvratil).
Fix return-std-move warning in CollectionStatistics
Sun, Jun 2, 12:51 PM

Sat, Jun 1

dvratil added a reviewer for D21512: Set KAboutData in AgentBase to enable reporting from DrKonqi: KDE PIM.
Sat, Jun 1, 10:33 PM · KDE PIM
dvratil updated the summary of D21527: Fix the 'Report bug' button being always disabled.
Sat, Jun 1, 10:28 PM · Plasma
dvratil added a reviewer for D21527: Fix the 'Report bug' button being always disabled: Plasma.
Sat, Jun 1, 10:25 PM · Plasma
dvratil requested review of D21527: Fix the 'Report bug' button being always disabled.
Sat, Jun 1, 10:25 PM · Plasma
dvratil added inline comments to D21463: KIMAP: Option to use system proxy settings (Core part).
Sat, Jun 1, 6:28 PM · KDE PIM

Fri, May 31

dvratil requested review of D21512: Set KAboutData in AgentBase to enable reporting from DrKonqi.
Fri, May 31, 2:58 PM · KDE PIM
dvratil requested changes to D21464: IMAP: Option to use system proxy settings (Configuration and GUI).
Fri, May 31, 11:59 AM · KDE PIM
dvratil requested changes to D21463: KIMAP: Option to use system proxy settings (Core part).
Fri, May 31, 11:56 AM · KDE PIM
dvratil committed R165:eced0f5c180d: Fix a small memory leak in akonadicontrol (authored by dvratil).
Fix a small memory leak in akonadicontrol
Fri, May 31, 11:44 AM
dvratil committed R165:7f104d75ef45: Fix a crash due to weird refcount messup during stack unwinding (authored by dvratil).
Fix a crash due to weird refcount messup during stack unwinding
Fri, May 31, 11:44 AM
dvratil closed D21457: Fix a small memory leak in akonadicontrol.
Fri, May 31, 11:44 AM · KDE PIM
dvratil closed D21456: Fix a crash due to weird refcount messup during stack unwinding.
Fri, May 31, 11:44 AM · KDE PIM
dvratil committed R165:6426d256b9a2: Introduce a simple scope guard helper AkScopeGuard (authored by dvratil).
Introduce a simple scope guard helper AkScopeGuard
Fri, May 31, 11:44 AM
dvratil committed R165:8f230d7d7f8a: Automatic recovery from Multiple Merge Candidates error (authored by dvratil).
Automatic recovery from Multiple Merge Candidates error
Fri, May 31, 11:44 AM
dvratil closed D21454: Introduce a simple scope guard helper AkScopeGuard.
Fri, May 31, 11:44 AM · KDE PIM
dvratil closed D21455: Automatic recovery from Multiple Merge Candidates error.
Fri, May 31, 11:44 AM · KDE PIM
dvratil committed R165:961690efe562: Coding style and naming in AkRanges library (authored by dvratil).
Coding style and naming in AkRanges library
Fri, May 31, 11:44 AM
dvratil committed R165:763c307ed6d1: Add 'all' and 'any' algorithms into our ranges library (authored by dvratil).
Add 'all' and 'any' algorithms into our ranges library
Fri, May 31, 11:44 AM
dvratil closed D21453: Coding style and naming in AkRanges library.
Fri, May 31, 11:44 AM · KDE PIM
dvratil closed D21452: Add 'all' and 'any' algorithms into our ranges library.
Fri, May 31, 11:44 AM · KDE PIM
dvratil added inline comments to D21455: Automatic recovery from Multiple Merge Candidates error.
Fri, May 31, 11:13 AM · KDE PIM

Thu, May 30

dvratil added a comment to D21454: Introduce a simple scope guard helper AkScopeGuard.

This is basically a QScopedGuard :) We just don't depend on Qt 5.12 yet. Probably a typdef is in order when QT_VERSION>=5.12

Thu, May 30, 11:14 AM · KDE PIM

Tue, May 28

dvratil accepted D21449: Split css classes, to style different parts..
Tue, May 28, 11:21 AM · KDE PIM
dvratil added a comment to D21448: Cleanup headerstyle_util interface..

I assume you checked that everything still builds? I see some reference to this method in kdepim-addons?

Tue, May 28, 11:19 AM · KDE PIM
dvratil added a comment to D21447: Display resentFrom after vcard and organisation..

What does resentFrom actually represent? The sender of the vcard, if the vcard is not of the sender?

Tue, May 28, 11:18 AM · KDE PIM
dvratil accepted D21446: Use FancyLong from KMime..
Tue, May 28, 11:15 AM · KDE PIM
dvratil added inline comments to D21445: Switch from KMime::Headers::Date -> QDateTime for message header..
Tue, May 28, 11:14 AM · KDE PIM
dvratil accepted D21443: Fix grantleeheaderstyletest..
Tue, May 28, 11:11 AM · KDE PIM
dvratil added inline comments to D21444: Run grantleeheaderstyletest without kdepim-addons and without pre installat messagelib..
Tue, May 28, 11:10 AM · KDE PIM
dvratil accepted D21442: Fix grantleeheaderformattertest date tests.
Tue, May 28, 11:07 AM · KDE PIM
dvratil added a comment to D20054: Use ellipsis in search placeholder.

@ognarb ping? :)

Tue, May 28, 11:05 AM · KDE PIM
dvratil added dependencies for D21455: Automatic recovery from Multiple Merge Candidates error: D21452: Add 'all' and 'any' algorithms into our ranges library, D21454: Introduce a simple scope guard helper AkScopeGuard.
Tue, May 28, 10:52 AM · KDE PIM
dvratil added a dependent revision for D21452: Add 'all' and 'any' algorithms into our ranges library: D21455: Automatic recovery from Multiple Merge Candidates error.
Tue, May 28, 10:52 AM · KDE PIM
dvratil added a dependent revision for D21454: Introduce a simple scope guard helper AkScopeGuard: D21455: Automatic recovery from Multiple Merge Candidates error.
Tue, May 28, 10:52 AM · KDE PIM
dvratil added a comment to D21456: Fix a crash due to weird refcount messup during stack unwinding.

The ASAN report, if anyone can make anything out of it:

Tue, May 28, 10:52 AM · KDE PIM
dvratil added a reviewer for D21457: Fix a small memory leak in akonadicontrol: KDE PIM.
Tue, May 28, 10:51 AM · KDE PIM
dvratil added a reviewer for D21456: Fix a crash due to weird refcount messup during stack unwinding: KDE PIM.
Tue, May 28, 10:50 AM · KDE PIM
dvratil added a reviewer for D21455: Automatic recovery from Multiple Merge Candidates error: KDE PIM.
Tue, May 28, 10:50 AM · KDE PIM
dvratil added a reviewer for D21454: Introduce a simple scope guard helper AkScopeGuard: KDE PIM.
Tue, May 28, 10:49 AM · KDE PIM
dvratil added a reviewer for D21453: Coding style and naming in AkRanges library: KDE PIM.
Tue, May 28, 10:49 AM · KDE PIM
dvratil added a reviewer for D21452: Add 'all' and 'any' algorithms into our ranges library: KDE PIM.
Tue, May 28, 10:48 AM · KDE PIM
dvratil requested review of D21457: Fix a small memory leak in akonadicontrol.
Tue, May 28, 10:48 AM · KDE PIM
dvratil requested review of D21456: Fix a crash due to weird refcount messup during stack unwinding.
Tue, May 28, 10:48 AM · KDE PIM
dvratil requested review of D21455: Automatic recovery from Multiple Merge Candidates error.
Tue, May 28, 10:47 AM · KDE PIM
dvratil requested review of D21454: Introduce a simple scope guard helper AkScopeGuard.
Tue, May 28, 10:46 AM · KDE PIM
dvratil requested review of D21453: Coding style and naming in AkRanges library.
Tue, May 28, 10:46 AM · KDE PIM
dvratil requested review of D21452: Add 'all' and 'any' algorithms into our ranges library.
Tue, May 28, 10:45 AM · KDE PIM

Sat, May 25

dvratil committed R1044:e204cf058cc9: Mark a quirk in enum.h as intentional (authored by dvratil).
Mark a quirk in enum.h as intentional
Sat, May 25, 10:01 AM

Thu, May 23

dvratil accepted D20843: Fix CMakeLists always building examples..

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

Thu, May 23, 8:30 AM · LibKGAPI, KDE PIM

Tue, May 21

dvratil committed R165:33b2ec61a52c: Fix build on the CI (authored by dvratil).
Fix build on the CI
Tue, May 21, 2:39 PM
dvratil accepted D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Tue, May 21, 2:09 PM · Build System, Frameworks
dvratil moved T836: [Akonadi/PSQL] Support DB update with pg_upgrade from Backlog to Applications 19.08 (master) on the KDE PIM board.
Tue, May 21, 2:08 PM · KDE PIM
dvratil committed R165:180dc3e18144: Automatically run pg_upgrade when major PostgreSQL upgrade is detected (authored by dvratil).
Automatically run pg_upgrade when major PostgreSQL upgrade is detected
Tue, May 21, 2:06 PM
dvratil closed D21154: Automatically run pg_upgrade when major PostgreSQL upgrade is detected.
Tue, May 21, 2:06 PM · KDE PIM
dvratil triaged T10964: [Akonadi] Fix PSQL path lookup as High priority.
Tue, May 21, 2:05 PM · KDE PIM
dvratil accepted D21236: Fix crashes with Qt 5.12.

Hmm, I wonder how this fixes the crash, but WebEngine is magic (plus this looks "harmless")

Tue, May 21, 2:03 PM · KDE PIM

Sun, May 19

dvratil committed R219:01ec4d87b2e2: Adapt to LibKGAPI setFields() changes. (authored by barchiesi).
Adapt to LibKGAPI setFields() changes.
Sun, May 19, 11:36 AM
dvratil closed D20888: Adapt to LibKGAPI setFields() changes..
Sun, May 19, 11:36 AM · LibKGAPI, KIO GDrive
dvratil committed R477:0c480a29452f: Add fields standard query parameter to Job and use it in FileFetchJob. (authored by barchiesi).
Add fields standard query parameter to Job and use it in FileFetchJob.
Sun, May 19, 11:25 AM
dvratil closed D20886: Add fields standard query parameter to Job and use it in FileFetchJob..
Sun, May 19, 11:25 AM · LibKGAPI, KDE PIM
dvratil added a comment to D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Just use --skip-dependencies - arc is confused becasue the commits from previous reviews landed with different commit hashes than arc expects.

Sun, May 19, 10:51 AM · LibKGAPI, KDE PIM
dvratil added a comment to D20888: Adapt to LibKGAPI setFields() changes..

You should be able to apply the last missing patch on top of libkgapi master (I've merged all the previous ones just now).

Sun, May 19, 10:33 AM · LibKGAPI, KIO GDrive
dvratil committed R477:896fb729ae2f: Add prettyPrint standard query parameter for all jobs except DELETE jobs. (authored by barchiesi).
Add prettyPrint standard query parameter for all jobs except DELETE jobs.
Sun, May 19, 10:03 AM