- User Since
- Apr 12 2015, 7:56 AM (201 w, 2 d)
Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe?
Fri, Feb 15
- Fixed typos
- Unified license
- Addresses comments from kbroulik
Thu, Feb 14
Tue, Feb 12
Sun, Feb 10
I believe the attempt here was to make the most common case of successful retrieval lock-free, but I now realize how broken that approach was. Thanks for the patch!
Fri, Feb 8
Thu, Feb 7
Wed, Feb 6
Sorry, I somehow forgot to hit the "Submit" button :facepalm:
Ouch, many thanks for the fix. Do you have commit access? If so, please commit to Applications/18.12 branch, otherwise I can push it for you.
Tue, Feb 5
Sat, Feb 2
Looks good, just one small change regarding the thread/no-thread handling.
Mon, Jan 28
Dedicated test for the AggregatedFetchScope is the easiest approach I think - it's a fairly isolated class, so it should be easy to write a test for it.
Sun, Jan 27
Thanks for the patch, looks good.
If it's really fixed, let's just remove the code completely.
The readAll()s after close() were needed IIRC, because reopening the socket and reading from it caused junk to be read from the buffer after reopening. This may have been caused by me doing something wrong. However, to make sure this does not keep happening, I'd suggest to always recreate the socket in doReconnect() instead of just reconnecting if it already exists.
Fri, Jan 25
Looks OK to me.
Wed, Jan 23
Thanks for the fix, Harald. Merge this into Applications/18.12 branch please.
Jan 17 2019
Jan 11 2019
Jan 8 2019
Jan 4 2019
Looks good. Commit it to Applications/18.12 branch, please. Thanks!
Dec 30 2018
@rakuco Yes, should be OK. I don't have access to my KDE ssh key right now so feel free to revert them and push it (to Applications/18.12 branch, then merge the branch to master), otherwise, I'll push it sometime next week.
Should go to Applications/18.12 (stable) branch.
Looks good, thanks!
Dec 24 2018
Sorry for the delay, I did not notice the review.
Dec 19 2018
Looks good to me. This whole thing could probably use some cleanup, but that's for another day :-)
You can close the review for master and commit this to the stable branch, then merge stable to master.
👍 Move the find_package calls as well.
Dec 17 2018
Dec 16 2018
I've recently run into the same problem on Akonadi on Windows, ended up allowing C++17 on Windows only and shipping a C++14-compatible implementation of C++17 optional in 3rdparty for everyone else.