dvratil (Daniel Vrátil)
User

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (227 w, 4 d)
Availability
Available

Recent Activity

Today

dvratil committed R237:b9cf875e2e7d: Fix memory leak in KConfigWatcher (authored by dvratil).
Fix memory leak in KConfigWatcher
Thu, Aug 22, 11:01 AM
dvratil closed D23340: Fix memory leak in KConfigWatcher.
Thu, Aug 22, 11:01 AM · Frameworks
dvratil committed R94:70000f1493fa: Fix memory leak in PluginEditorGrammar (authored by dvratil).
Fix memory leak in PluginEditorGrammar
Thu, Aug 22, 11:01 AM
dvratil requested review of D23340: Fix memory leak in KConfigWatcher.
Thu, Aug 22, 10:39 AM · Frameworks
dvratil requested review of D23339: Fix memory leak in ConfigView and Dialog.
Thu, Aug 22, 10:34 AM · Frameworks

Mon, Aug 19

dvratil accepted D23252: Fix kdepim-addons autotest EnterpriseHeaderStylePluginTest.

Thanks!

Mon, Aug 19, 8:30 PM · KDE PIM

Sun, Aug 18

dvratil committed R165:968f8bbdd70f: Fix build on Windows (authored by dvratil).
Fix build on Windows
Sun, Aug 18, 9:43 AM
dvratil committed R165:2f6472c62d80: Fix build on Windows (authored by dvratil).
Fix build on Windows
Sun, Aug 18, 9:26 AM

Fri, Aug 16

dvratil committed R165:0fb3f45b3808: Adjust AkDbusTest (authored by dvratil).
Adjust AkDbusTest
Fri, Aug 16, 8:48 PM
dvratil committed R165:59036f86768d: Small cleanup in ItemRetrievalManager (authored by dvratil).
Small cleanup in ItemRetrievalManager
Fri, Aug 16, 8:05 PM
dvratil committed R165:524f5fbfb507: Cleaner DBus::parseAgentServiceName() API (authored by dvratil).
Cleaner DBus::parseAgentServiceName() API
Fri, Aug 16, 8:05 PM

Wed, Aug 14

dvratil committed R94:38b48bb7ecd5: Fix another failure in autotest rendertest (authored by gjditchfield).
Fix another failure in autotest rendertest
Wed, Aug 14, 12:43 PM
dvratil closed D23017: Fix another failure in autotest rendertest.
Wed, Aug 14, 12:43 PM · KDE PIM
dvratil accepted D23017: Fix another failure in autotest rendertest.
Wed, Aug 14, 12:40 PM · KDE PIM

Tue, Aug 13

dvratil committed R1044:ad41cf7fed33: Fix links in readme (authored by dvratil).
Fix links in readme
Tue, Aug 13, 1:23 PM

Tue, Aug 6

dvratil committed R94:50a790b1d63a: Set locale and timezone for Grantlee tests (authored by dvratil).
Set locale and timezone for Grantlee tests
Tue, Aug 6, 12:46 PM
dvratil closed D22965: Set locale and timezone for Grantlee tests.
Tue, Aug 6, 12:46 PM · KDE PIM
dvratil committed R94:3ece20e59345: Fix some failures in autotest rendertest (authored by gjditchfield).
Fix some failures in autotest rendertest
Tue, Aug 6, 12:25 PM
dvratil closed D22959: Fix some failures in autotest rendertest.
Tue, Aug 6, 12:25 PM · KDE PIM
dvratil accepted D22959: Fix some failures in autotest rendertest.

Looks good 👍

Tue, Aug 6, 12:23 PM · KDE PIM
dvratil requested review of D22965: Set locale and timezone for Grantlee tests.
Tue, Aug 6, 11:57 AM · KDE PIM
dvratil created T11329: [Akonadi] Mechanism to re-try writing Item payload into backend.
Tue, Aug 6, 10:03 AM · KDE PIM

Mon, Aug 5

dvratil committed R94:213b3e11d85b: Fix failures in autotest templateparserjobtest (authored by gjditchfield).
Fix failures in autotest templateparserjobtest
Mon, Aug 5, 11:57 AM
dvratil closed D22828: Fix failures in autotest templateparserjobtest.
Mon, Aug 5, 11:57 AM · KDE PIM
dvratil accepted D22828: Fix failures in autotest templateparserjobtest.

I think your analysis is correct, the merge commit indeed looks suspicious and misplaced in this test. Well spotted!

Mon, Aug 5, 11:52 AM · KDE PIM
dvratil committed R94:50e3d03aa033: Fix failing autotest grantleeheaderformattertest (authored by gjditchfield).
Fix failing autotest grantleeheaderformattertest
Mon, Aug 5, 11:46 AM
dvratil closed D22900: Fix failing autotest grantleeheaderformattertest.
Mon, Aug 5, 11:46 AM · KDE PIM
dvratil committed R94:7251f3cfad6c: Fix failing autotest grantleeheaderstyletest (authored by gjditchfield).
Fix failing autotest grantleeheaderstyletest
Mon, Aug 5, 11:46 AM
dvratil closed D22892: Fix failing autotest grantleeheaderstyletest.
Mon, Aug 5, 11:46 AM · KDE PIM
dvratil accepted D22900: Fix failing autotest grantleeheaderformattertest.

Many thanks for fixing the tests!

Mon, Aug 5, 11:45 AM · KDE PIM
dvratil accepted D22892: Fix failing autotest grantleeheaderstyletest.
Mon, Aug 5, 11:41 AM · KDE PIM
dvratil added a reviewer for D22944: Re-enable non-Akonadi tests in messagelib and mailcommon: bcooksley.
Mon, Aug 5, 11:39 AM
dvratil requested review of D22944: Re-enable non-Akonadi tests in messagelib and mailcommon.
Mon, Aug 5, 11:37 AM
dvratil accepted D22826: port to phonon 4.11, qt5, ecm.

I did not try to build it, but the changes look sensible to me. 👍

Mon, Aug 5, 8:08 AM
dvratil added a comment to D22779: Fix a segmentation fault in autotest messagefactoryngtest.

Sorry for the delay Glen, I've missed your comment. All approved changes are landed, Me or someone else from the team will try to get around to the rest of them soon :)

Mon, Aug 5, 7:51 AM · KDE PIM
dvratil committed R94:4b9ec96ac351: Fix segmentation fault in autotest ViewerGrantleeThemeSupportTest (authored by gjditchfield).
Fix segmentation fault in autotest ViewerGrantleeThemeSupportTest
Mon, Aug 5, 7:50 AM
dvratil committed R94:834d579975d4: Fix failing autotest FollowupReminderSelectDateDialogTest (authored by gjditchfield).
Fix failing autotest FollowupReminderSelectDateDialogTest
Mon, Aug 5, 7:50 AM
dvratil closed D22938: Fix segmentation fault in autotest ViewerGrantleeThemeSupportTest.
Mon, Aug 5, 7:50 AM · KDE PIM
dvratil committed R94:27ce5138d7b6: Fix a segmentation fault in autotest messagefactoryngtest (authored by gjditchfield).
Fix a segmentation fault in autotest messagefactoryngtest
Mon, Aug 5, 7:50 AM
dvratil closed D22937: Fix failing autotest FollowupReminderSelectDateDialogTest.
Mon, Aug 5, 7:50 AM · KDE PIM
dvratil closed D22779: Fix a segmentation fault in autotest messagefactoryngtest.
Mon, Aug 5, 7:50 AM · KDE PIM

Fri, Aug 2

dvratil committed R1003:c43defd044fc: Fix extracting seat reservation from Czech Railways group ticket (authored by dvratil).
Fix extracting seat reservation from Czech Railways group ticket
Fri, Aug 2, 3:57 PM
dvratil closed D22898: Fix extracting seat reservation from Czech Railways group ticket.
Fri, Aug 2, 3:57 PM · KDE PIM
dvratil committed R1003:0c915da188a5: Fix Czech Railways extractor to handle multi-leg group tickets properly (authored by dvratil).
Fix Czech Railways extractor to handle multi-leg group tickets properly
Fri, Aug 2, 3:57 PM
dvratil closed D22895: Fix Czech Railways extractor to handle multi-leg group tickets properly.
Fri, Aug 2, 3:57 PM · KDE PIM
dvratil updated the summary of D22898: Fix extracting seat reservation from Czech Railways group ticket.
Fri, Aug 2, 3:04 PM · KDE PIM
dvratil requested review of D22898: Fix extracting seat reservation from Czech Railways group ticket.
Fri, Aug 2, 3:04 PM · KDE PIM
dvratil requested review of D22895: Fix Czech Railways extractor to handle multi-leg group tickets properly.
Fri, Aug 2, 2:27 PM · KDE PIM

Mon, Jul 29

dvratil accepted D22688: remove qt4.
Mon, Jul 29, 12:07 PM
dvratil accepted D22516: i18n: Add context "@title:window" to arguments to setWindowTitle().
Mon, Jul 29, 12:04 PM · KDE PIM
dvratil committed R477:db302e1bdc31: Merge branch 'Applications/19.08' (authored by dvratil).
Merge branch 'Applications/19.08'
Mon, Jul 29, 9:14 AM
dvratil accepted D22779: Fix a segmentation fault in autotest messagefactoryngtest.

LGTM

Mon, Jul 29, 8:14 AM · KDE PIM
dvratil accepted D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.

Nice! I was afraid we might have to introduce a new method for this, but this is great - I think it's OK to land this onto Applications/19.08, if you can do it before the Thursday freeze.

Mon, Jul 29, 8:10 AM · KDE PIM

Fri, Jul 26

dvratil added a comment to D21905: [Digital Clock] Open KOrganizer with event details on click.

Also, could someone take a look at https://phabricator.kde.org/D21902 please? :)

Fri, Jul 26, 12:06 PM · Plasma
dvratil added inline comments to D21905: [Digital Clock] Open KOrganizer with event details on click.
Fri, Jul 26, 12:05 PM · Plasma
dvratil updated the diff for D21905: [Digital Clock] Open KOrganizer with event details on click.
  • Implement Kai's suggestion
Fri, Jul 26, 12:05 PM · Plasma
dvratil requested changes to D22688: remove qt4.
Fri, Jul 26, 11:52 AM
dvratil added a comment to D22688: remove qt4.

I think we should also get rid of the QT_VERSION #ifdefs around the code...

Fri, Jul 26, 11:52 AM
dvratil accepted D22746: Clarify that utils.h is not public API.
Fri, Jul 26, 11:36 AM · KDE PIM
dvratil accepted D22743: Port tests to new namespace.
Fri, Jul 26, 11:35 AM · KDE PIM
dvratil requested changes to D22516: i18n: Add context "@title:window" to arguments to setWindowTitle().
Fri, Jul 26, 11:34 AM · KDE PIM
dvratil committed R165:56bfde881405: Merge branch 'Applications/19.04' into Applications/19.08 (authored by dvratil).
Merge branch 'Applications/19.04' into Applications/19.08
Fri, Jul 26, 11:34 AM
dvratil committed R165:07e26a55996a: Merge branch 'Applications/19.08' (authored by dvratil).
Merge branch 'Applications/19.08'
Fri, Jul 26, 11:34 AM
dvratil committed R165:8b8db29d10b2: Fix compatibility with QMYSQL driver after 74aed95 (authored by dvratil).
Fix compatibility with QMYSQL driver after 74aed95
Fri, Jul 26, 11:32 AM
dvratil closed D22677: Fix compatibility with QMYSQL driver after 74aed95.
Fri, Jul 26, 11:32 AM · KDE PIM
dvratil added a reviewer for D22677: Fix compatibility with QMYSQL driver after 74aed95: KDE PIM.
Fri, Jul 26, 11:01 AM · KDE PIM

Jul 23 2019

dvratil requested review of D22677: Fix compatibility with QMYSQL driver after 74aed95.
Jul 23 2019, 9:35 AM · KDE PIM
dvratil added inline comments to D22628: Fix mimeType loss during file creation or update..
Jul 23 2019, 9:23 AM · KIO GDrive
dvratil accepted D22601: i18n: Add context @title:window to window titles.

LGTM

Jul 23 2019, 9:17 AM · KDE PIM
dvratil accepted D22671: Add public holidays' substitute days in Russia, for 2019-2020.
Jul 23 2019, 9:14 AM · KDE PIM
dvratil accepted D22672: Update holidays in Russia.
Jul 23 2019, 9:14 AM · KDE PIM

Jul 21 2019

dvratil accepted D22565: Elide tokens in logs and clean up debug output..
Jul 21 2019, 7:50 PM · KIO GDrive

Jul 15 2019

dvratil committed R296:811e78ef0ee3: Calendar events: allow plugins to show event details (authored by dvratil).
Calendar events: allow plugins to show event details
Jul 15 2019, 3:19 PM
dvratil closed D21901: Calendar events: allow plugins to show event details.
Jul 15 2019, 3:19 PM · Frameworks
dvratil accepted D22436: Also serialize IMPP fields.

Looks good :)

Jul 15 2019, 3:14 PM · KDE PIM
dvratil requested changes to D22462: Avoid calling finished() after error()".

The change around runJob() looks good, but all the changes in logging should go in separately since they are unrelated to the main part of the change.

Jul 15 2019, 3:13 PM · KIO GDrive

Jul 14 2019

dvratil added a comment to D21906: Events plugin: implement the new showEvent() API.

I can't, sadly no-one bothered to review the Frameworks changes, so I missed the 5.60 window ;(

Jul 14 2019, 8:18 AM · KDE PIM
dvratil added a comment to D21902: Calendar: add method to show event details.

Ping?

Jul 14 2019, 8:18 AM · Frameworks
dvratil added a reviewer for D21902: Calendar: add method to show event details: Frameworks.
Jul 14 2019, 8:18 AM · Frameworks
dvratil updated the summary of D21905: [Digital Clock] Open KOrganizer with event details on click.
Jul 14 2019, 8:17 AM · Plasma
dvratil added a comment to D21901: Calendar events: allow plugins to show event details.

Ping?

Jul 14 2019, 8:17 AM · Frameworks

Jul 12 2019

dvratil committed R200:2b520d841732: Add missing QVector include (authored by dvratil).
Add missing QVector include
Jul 12 2019, 11:18 AM
dvratil committed R290:886f7f4004e5: Fix build due to missing QVector include (authored by dvratil).
Fix build due to missing QVector include
Jul 12 2019, 10:20 AM
dvratil closed D22414: Fix build due to missing QVector include.
Jul 12 2019, 10:20 AM · Frameworks
dvratil committed R244:95e9d5f22ea3: Fix build after 0b2fe3cf21 (authored by dvratil).
Fix build after 0b2fe3cf21
Jul 12 2019, 10:07 AM
dvratil closed D22413: Fix build after 0b2fe3cf21.
Jul 12 2019, 10:07 AM · Frameworks
dvratil accepted D22407: Replace virtual_hook usage with actual virtual methods.
Jul 12 2019, 10:05 AM · KDE PIM
dvratil requested review of D22414: Fix build due to missing QVector include.
Jul 12 2019, 9:30 AM · Frameworks
dvratil requested review of D22413: Fix build after 0b2fe3cf21.
Jul 12 2019, 9:23 AM · Frameworks

Jul 11 2019

dvratil accepted D22343: Add Q_PROPERTYs to Attendee and Attachment.
Jul 11 2019, 4:13 PM · KDE PIM
dvratil accepted D22378: don't use nullptr to stay compatible with !c++11 & qt4.
Jul 11 2019, 4:08 PM

Jul 9 2019

dvratil accepted D22318: Uniform to using Utils::bool2Str()..

Nice!

Jul 9 2019, 1:49 PM · KDE PIM

Jul 7 2019

dvratil accepted D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 7 2019, 4:52 PM · KDE PIM
dvratil accepted D22248: Adapt to KCalCore::Attachment changes.
Jul 7 2019, 4:50 PM · KDE PIM
dvratil accepted D22246: Adapt to KCalCore::Attachment changes.
Jul 7 2019, 4:50 PM · KDE PIM
dvratil committed R177:5fb977be6dea: Merge branch 'Applications/19.04' (authored by dvratil).
Merge branch 'Applications/19.04'
Jul 7 2019, 4:48 PM
dvratil closed D22271: Fix int overflow when parsing ImapSet.
Jul 7 2019, 4:47 PM · KDE PIM
dvratil committed R177:8bc38d948c53: Fix int overflow when parsing ImapSet (authored by dvratil).
Fix int overflow when parsing ImapSet
Jul 7 2019, 4:47 PM
dvratil committed R165:99ade76f0ca3: Implement proper sorting of Postgres versioned directories (authored by dvratil).
Implement proper sorting of Postgres versioned directories
Jul 7 2019, 4:46 PM
dvratil closed D22274: Implement proper sorting of Postgres versioned directories.
Jul 7 2019, 4:46 PM · KDE PIM