- User Since
- Apr 12 2015, 7:56 AM (227 w, 4 d)
Mon, Aug 19
Sun, Aug 18
Fri, Aug 16
Wed, Aug 14
Tue, Aug 13
Tue, Aug 6
Looks good 👍
Mon, Aug 5
I think your analysis is correct, the merge commit indeed looks suspicious and misplaced in this test. Well spotted!
Many thanks for fixing the tests!
I did not try to build it, but the changes look sensible to me. 👍
Sorry for the delay Glen, I've missed your comment. All approved changes are landed, Me or someone else from the team will try to get around to the rest of them soon :)
Fri, Aug 2
Mon, Jul 29
Nice! I was afraid we might have to introduce a new method for this, but this is great - I think it's OK to land this onto Applications/19.08, if you can do it before the Thursday freeze.
Fri, Jul 26
Also, could someone take a look at https://phabricator.kde.org/D21902 please? :)
- Implement Kai's suggestion
I think we should also get rid of the QT_VERSION #ifdefs around the code...
Jul 23 2019
Jul 21 2019
Jul 15 2019
The change around runJob() looks good, but all the changes in logging should go in separately since they are unrelated to the main part of the change.
Jul 14 2019
I can't, sadly no-one bothered to review the Frameworks changes, so I missed the 5.60 window ;(