dvratil (Daniel Vrátil)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 7:56 AM (242 w, 6 d)
Availability
Available

Recent Activity

Yesterday

dvratil added a comment to T12315: Crash with latest kasync master.

Looks like some memory issue...could you try compiling with -fsanitize=address? I won't get to look into it properly before some time next week, sorry.

Fri, Dec 6, 10:54 AM · KASync, Kube
dvratil committed R1028:c9c4da96d373: Bump version to 1.1.0 (authored by dvratil).
Bump version to 1.1.0
Fri, Dec 6, 6:59 AM
dvratil committed R1028:f2d4a467170d: Plasma Pass 0.2 (authored by dvratil).
Plasma Pass 0.2
Fri, Dec 6, 6:52 AM

Thu, Dec 5

dvratil committed R1028:092a5f9fbb09: Delay filtering after user paused typing (authored by dvratil).
Delay filtering after user paused typing
Thu, Dec 5, 2:24 PM

Mon, Nov 25

dvratil committed R165:ae66fa0882a7: akonadi_control: fix regression in agent instance numbering (authored by dvratil).
akonadi_control: fix regression in agent instance numbering
Mon, Nov 25, 12:06 PM
dvratil accepted D25499: IMAP resource: do not prompt for password with GSSAPI auth.

Thanks!

Mon, Nov 25, 9:45 AM · KDE PIM

Fri, Nov 22

dvratil accepted D25455: akonadi: improve debug message in state() method.
Fri, Nov 22, 2:35 PM · KDE PIM
dvratil committed R165:def29581185e: Merge branch 'release/19.12' (authored by dvratil).
Merge branch 'release/19.12'
Fri, Nov 22, 2:34 PM
dvratil committed R165:e7c79ec8c2e5: Testrunner: wait until all jobs are done before aborting setup (authored by dvratil).
Testrunner: wait until all jobs are done before aborting setup
Fri, Nov 22, 2:29 PM
dvratil committed R165:34cb766861e9: akonadi_control: announce new Resource once both services are registered (authored by dvratil).
akonadi_control: announce new Resource once both services are registered
Fri, Nov 22, 2:29 PM
dvratil closed D25458: Attempt to make tests on CI more robust.
Fri, Nov 22, 2:29 PM · KDE PIM
dvratil added a comment to D25458: Attempt to make tests on CI more robust.

Fix the patch, arc sucks.

Off topic, but @mlaurent told me to use arcanist because my commandline generated 'git diff' patches suck. what's the deal?

Fri, Nov 22, 1:52 PM · KDE PIM
dvratil updated the diff for D25458: Attempt to make tests on CI more robust.

Fix the patch, arc sucks.

Fri, Nov 22, 1:30 PM · KDE PIM
dvratil updated the diff for D25458: Attempt to make tests on CI more robust.
  • Address review comments
Fri, Nov 22, 1:27 PM · KDE PIM
dvratil added inline comments to D25458: Attempt to make tests on CI more robust.
Fri, Nov 22, 1:27 PM · KDE PIM
dvratil committed R165:4f79c5099b2f: akonadi_control: cleanup (authored by dvratil).
akonadi_control: cleanup
Fri, Nov 22, 1:21 PM
dvratil committed R165:18f704937232: Create a logging category for the akonaditest helper (authored by dvratil).
Create a logging category for the akonaditest helper
Fri, Nov 22, 12:35 PM
dvratil committed R165:bf0b61407824: Minor optimization in DBus service name parser (authored by dvratil).
Minor optimization in DBus service name parser
Fri, Nov 22, 11:01 AM
dvratil committed R165:1603cbe420f5: Fix confusing member name in AgentService returned by DBus helper (authored by dvratil).
Fix confusing member name in AgentService returned by DBus helper
Fri, Nov 22, 11:01 AM
dvratil requested review of D25458: Attempt to make tests on CI more robust.
Fri, Nov 22, 10:56 AM · KDE PIM

Wed, Nov 20

dvratil accepted D25419: Add some test to ensure local time handling in recurrences..

Much appreciated!

Wed, Nov 20, 12:41 PM · KDE PIM

Fri, Nov 15

dvratil committed R665:25f880240983: Properly publicize and document waitForCompletion() (authored by dvratil).
Properly publicize and document waitForCompletion()
Fri, Nov 15, 3:32 PM
dvratil committed R665:4643e13d6358: Remove unused traits, inline others (authored by dvratil).
Remove unused traits, inline others
Fri, Nov 15, 3:32 PM
dvratil committed R665:e2bff63a76ed: Clean up bits of job_impl (authored by dvratil).
Clean up bits of job_impl
Fri, Nov 15, 3:32 PM
dvratil committed R665:5e224f0178c1: Inline async.cpp into job_impl.h (authored by dvratil).
Inline async.cpp into job_impl.h
Fri, Nov 15, 3:32 PM

Thu, Nov 14

dvratil committed R665:c4fda33ee17d: Improve support for movable-only Future values (authored by dvratil).
Improve support for movable-only Future values
Thu, Nov 14, 4:10 PM

Tue, Nov 12

dvratil committed R172:ed254021dd45: Memory Calendar: avoid code duplication (authored by dvratil).
Memory Calendar: avoid code duplication
Tue, Nov 12, 5:12 PM
dvratil committed R172:5dbdb02c8bfa: Use QDate as key in mIncidencesForDate in MemoryCalendar (authored by dvratil).
Use QDate as key in mIncidencesForDate in MemoryCalendar
Tue, Nov 12, 5:12 PM
dvratil closed D25271: Memory Calendar: avoid code duplication.
Tue, Nov 12, 12:55 PM · KDE PIM
dvratil closed D25166: Use QDate as key in mIncidencesForDate in MemoryCalendar.
Tue, Nov 12, 12:39 PM · KDE PIM
dvratil requested review of D25271: Memory Calendar: avoid code duplication.
Tue, Nov 12, 12:25 PM · KDE PIM

Mon, Nov 11

dvratil requested changes to D25213: Cancel task if conversion to XML fail.
Mon, Nov 11, 6:49 AM · KDE PIM

Nov 6 2019

dvratil added a project to D25166: Use QDate as key in mIncidencesForDate in MemoryCalendar: KDE PIM.
Nov 6 2019, 1:26 PM · KDE PIM
dvratil updated subscribers of D25166: Use QDate as key in mIncidencesForDate in MemoryCalendar.
Nov 6 2019, 10:52 AM · KDE PIM
dvratil requested review of D25166: Use QDate as key in mIncidencesForDate in MemoryCalendar.
Nov 6 2019, 10:52 AM · KDE PIM
dvratil accepted D25066: Handle incidences in different time zones in MemoryCalendar..

Looks good to me. Thanks!

Nov 6 2019, 10:38 AM · KDE PIM

Oct 30 2019

dvratil added a comment to T11535: Organize 2019 KF6 sprint.

Sadly, I can't be there :(

Oct 30 2019, 11:47 AM · KF6

Oct 22 2019

dvratil committed R665:626739209088: Remove syncStartImpl() altogether (authored by dvratil).
Remove syncStartImpl() altogether
Oct 22 2019, 12:28 PM
dvratil committed R665:390429b05d7a: Move (sync)StartImpl() into the Private namespace (authored by dvratil).
Move (sync)StartImpl() into the Private namespace
Oct 22 2019, 12:28 PM
dvratil committed R665:6e2304afd318: Fold ThenExecutor into Executor (authored by dvratil).
Fold ThenExecutor into Executor
Oct 22 2019, 12:28 PM
dvratil committed R665:953fda840f32: Merge branch 'continuation-holder' (authored by dvratil).
Merge branch 'continuation-holder'
Oct 22 2019, 12:28 PM
dvratil closed D24536: Cleanup and improvements around ContinuationHelper.
Oct 22 2019, 12:28 PM

Oct 19 2019

dvratil requested review of D24776: Fix typo.
Oct 19 2019, 11:15 AM
dvratil added a comment to D24739: KOrganizer Month View: use QDate stringification.

I grepped the localizations and it appears that everyone uses the "month year" format, so this change looks safe.

Oct 19 2019, 11:07 AM · KDE PIM
dvratil accepted D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.

Looks good to me, thanks!

Oct 19 2019, 11:00 AM
dvratil accepted D24705: Add colorSetAlpha filter, so explicitly set the alpha value of a color.
Oct 19 2019, 10:47 AM · KDE PIM
dvratil accepted D24541: fix(akonadiserver): Use xdg_data_home and xdg_config_home as variable..
Oct 19 2019, 10:47 AM · KDE PIM

Oct 10 2019

dvratil retitled D24536: Cleanup and improvements around ContinuationHelper from Fix documentation generation to Cleanup and improvements around ContinuationHelper.
Oct 10 2019, 4:00 PM
dvratil updated the summary of D24536: Cleanup and improvements around ContinuationHelper.
Oct 10 2019, 3:52 PM
dvratil updated the diff for D24536: Cleanup and improvements around ContinuationHelper.
  • Improved test, minor cleanup
Oct 10 2019, 3:50 PM
dvratil committed R665:31117e0d6beb: Remove the now pointless syncThenImpl(), use thenImpl() instead (authored by dvratil).
Remove the now pointless syncThenImpl(), use thenImpl() instead
Oct 10 2019, 3:50 PM
dvratil committed R665:32e6bf205515: Optimize memory usage by turning ContinuationHolder into a union (authored by dvratil).
Optimize memory usage by turning ContinuationHolder into a union
Oct 10 2019, 3:50 PM
dvratil updated the diff for D24536: Cleanup and improvements around ContinuationHelper.
  • Rebase on current master
Oct 10 2019, 3:39 PM
dvratil requested review of D24536: Cleanup and improvements around ContinuationHelper.
Oct 10 2019, 3:38 PM
dvratil committed R665:4f4ffc1a12bb: Remove the now pointless syncThenImpl(), use thenImpl() instead (authored by dvratil).
Remove the now pointless syncThenImpl(), use thenImpl() instead
Oct 10 2019, 3:37 PM

Oct 9 2019

dvratil committed R665:f5772427ca4a: Optimize memory usage by turning ContinuationHolder into a union (authored by dvratil).
Optimize memory usage by turning ContinuationHolder into a union
Oct 9 2019, 9:52 PM
dvratil committed R665:d4e85564840e: Rename ContinuationHelper to ContinuationHolder (authored by dvratil).
Rename ContinuationHelper to ContinuationHolder
Oct 9 2019, 9:52 PM
dvratil committed R665:bcf37801d306: Fold Sync and Error executors into ThenExecutor (authored by dvratil).
Fold Sync and Error executors into ThenExecutor
Oct 9 2019, 9:52 PM
dvratil committed R665:a813013ceed0: Simply template definitions (authored by dvratil).
Simply template definitions
Oct 9 2019, 9:52 PM
dvratil committed R665:cc4c3f577806: Rename HandleContinuation to AsyncContinuation (authored by dvratil).
Rename HandleContinuation to AsyncContinuation
Oct 9 2019, 9:52 PM
dvratil committed R665:b1ef28dfe13a: Fix documentation generation (authored by dvratil).
Fix documentation generation
Oct 9 2019, 9:52 PM
dvratil closed D24491: Fix build against Qt without std::hash<QString> specialization.
Oct 9 2019, 8:40 AM
dvratil committed R45:496047cdfd1c: Fix build against Qt without std::hash<QString> specialization (authored by dvratil).
Fix build against Qt without std::hash<QString> specialization
Oct 9 2019, 8:40 AM

Oct 8 2019

dvratil updated the summary of D24491: Fix build against Qt without std::hash<QString> specialization.
Oct 8 2019, 11:36 AM
dvratil requested review of D24491: Fix build against Qt without std::hash<QString> specialization.
Oct 8 2019, 11:35 AM
dvratil accepted D24484: Remove warnings about ignoring return value of removeHeader().
Oct 8 2019, 9:32 AM · KDE PIM
dvratil added a comment to D24443: Add a plugin system.
  • I would add name property to the CalendarEntry
  • I would add color property to the CalendarEntry, so that calendar that is e.g. green in KOrganizer would show up green in the Plasma applet, too.
Oct 8 2019, 9:30 AM
dvratil accepted D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.

Ok, let's roll with it, then.

Oct 8 2019, 8:56 AM · KDE PIM

Oct 7 2019

dvratil requested changes to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.
Oct 7 2019, 10:58 AM · KDE PIM

Oct 6 2019

dvratil added a revision to T11534: Port KIMAP away from KTcpSocket: D24438: Port away from KTcpSocket to QSslSocket.
Oct 6 2019, 12:04 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil added a task to D24438: Port away from KTcpSocket to QSslSocket: T11534: Port KIMAP away from KTcpSocket.
Oct 6 2019, 12:04 PM · KDE PIM
dvratil added a commit to T11534: Port KIMAP away from KTcpSocket: R177:4cd90762254a: Port away from KTcpSocket to QSslSocket.
Oct 6 2019, 12:03 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil added a task to R177:4cd90762254a: Port away from KTcpSocket to QSslSocket: T11534: Port KIMAP away from KTcpSocket.
Oct 6 2019, 12:03 PM
dvratil added a commit to T11533: Port KSMTP away from KTcpSocket: R733:25e1ff907994: Port away from KTcpSocket to QSslSocket.
Oct 6 2019, 12:03 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil added a task to R733:25e1ff907994: Port away from KTcpSocket to QSslSocket: T11533: Port KSMTP away from KTcpSocket.
Oct 6 2019, 12:03 PM
dvratil closed T11533: Port KSMTP away from KTcpSocket, a subtask of T11544: Remove KTcpSocket, as Resolved.
Oct 6 2019, 12:01 PM · KF6
dvratil closed T11533: Port KSMTP away from KTcpSocket as Resolved.
Oct 6 2019, 12:01 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil closed T11534: Port KIMAP away from KTcpSocket as Resolved.
Oct 6 2019, 12:01 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil closed T11534: Port KIMAP away from KTcpSocket, a subtask of T11544: Remove KTcpSocket, as Resolved.
Oct 6 2019, 12:01 PM · KF6
dvratil committed R177:4cd90762254a: Port away from KTcpSocket to QSslSocket (authored by dvratil).
Port away from KTcpSocket to QSslSocket
Oct 6 2019, 12:00 PM
dvratil edited projects for T11534: Port KIMAP away from KTcpSocket, added: KDE PIM (Applications 19.12 (master)); removed KDE PIM.
Oct 6 2019, 12:00 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil closed D24438: Port away from KTcpSocket to QSslSocket.
Oct 6 2019, 12:00 PM · KDE PIM
dvratil moved T11534: Port KIMAP away from KTcpSocket from In Progress to Done on the KF6 board.
Oct 6 2019, 12:00 PM · KDE PIM (Applications 19.12 (master)), KF6
dvratil requested review of D24438: Port away from KTcpSocket to QSslSocket.
Oct 6 2019, 11:10 AM · KDE PIM
dvratil moved T11534: Port KIMAP away from KTcpSocket from Backlog to In Progress on the KF6 board.
Oct 6 2019, 10:22 AM · KDE PIM (Applications 19.12 (master)), KF6
dvratil claimed T11534: Port KIMAP away from KTcpSocket.
Oct 6 2019, 10:22 AM · KDE PIM (Applications 19.12 (master)), KF6
dvratil committed R165:8aca730125ad: Fix AkStandardDirs include header guard (authored by dvratil).
Fix AkStandardDirs include header guard
Oct 6 2019, 9:34 AM
dvratil committed R165:1af267e7ee43: AkRanges: various cleanups (authored by dvratil).
AkRanges: various cleanups
Oct 6 2019, 9:34 AM

Oct 1 2019

dvratil requested changes to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.
Oct 1 2019, 11:41 AM · KDE PIM
dvratil accepted D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options..

Thanks for the fix. Since this is a bugfix, please land this patch to the Applications/19.08 branch, then merge the branch to master.

Oct 1 2019, 11:37 AM · LibKGAPI, KDE PIM
dvratil accepted D24310: Fix comparison typo.

Well spotted! Thanks

Oct 1 2019, 11:32 AM · LibKGAPI, KDE PIM
dvratil accepted D24319: Remove unused recurrence assignment operator.
Oct 1 2019, 11:32 AM · KDE PIM
dvratil accepted D24320: Remove unused recurrence assignment operators.
Oct 1 2019, 11:31 AM · KDE PIM

Sep 26 2019

dvratil accepted D24237: Fix compilation with Qt 5.14.
Sep 26 2019, 10:16 AM · KDE PIM

Sep 23 2019

dvratil added a comment to M155: KMail revamped.

KMail can show the message size in the message list already now, you can completely customize the data displayed in View->Message List->Theme - in case of the revamping, this customizability should not be lost. Also, the way the code is written now, it should be possible to even implement the proposed change alongside the existing one (same goes for the message view as well) - maybe just without the "upcoming event" information. So not really revamp, but evolution, with a fallback for users who would prefer the "old" look :-)

Sep 23 2019, 2:14 PM
dvratil requested changes to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.
Sep 23 2019, 8:43 AM · KDE PIM
dvratil added a comment to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.

Did you test on both Neon and plain Debian?

Sep 23 2019, 8:43 AM · KDE PIM

Sep 22 2019

dvratil renamed T11752: Blogger library code cleanup from Blogger API cleanup to Blogger library code cleanup.
Sep 22 2019, 11:49 AM · LibKGAPI
dvratil created T11752: Blogger library code cleanup.
Sep 22 2019, 11:49 AM · LibKGAPI
dvratil added a comment to T11741: Fix link ordering - BUG411425.

Sounds like there might be a problem with exports or some symbol name duplication that leads to some weird behavior during LTO.

Sep 22 2019, 11:44 AM · LibKGAPI