- User Since
- Apr 14 2015, 9:17 PM (166 w, 4 h)
Tue, Jun 12
Sat, Jun 9
Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.
Fri, Jun 1
- Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
- Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
- What about the configuration UI?
Sat, May 26
Was more aimed at @nicolasfella :)
So... accepted? :)
Thanks for the suggestion!
Using loginctl for session locking as well
Looks ok to me.
Mon, May 21
May 19 2018
May 17 2018
The second one sounds ok
May 16 2018
The problem with the original wording is mainly in using singular. It is for linking files to activities. I'm open to suggestions.
May 15 2018
Maybe "Linking files to activities" would be better?
May 13 2018
May 9 2018
May 2 2018
May 1 2018
I pushed it by accident, and I didn't want to revert just to push it to the phab again. Though, I did count that you'll check it out in the end even if it is already merged :)
Apr 29 2018
Apr 28 2018
If KRunner has multiple threads accessing the same sqlite database, then yes.
Apr 26 2018
Apr 10 2018
Apr 9 2018
Apr 6 2018
Vault uses FUSE, no block-level for the time being. I was toying with Tomb and preallocated fixed-size containers in the filsystem which uses Luks in the back, but I'm not sure it can be made to work properly.
Vault does not support public-private key encryption - it is out of the project's scope. And it would be quite strange for the user to see items like "KMail Index for ABCDEFGH01234... key" in the list of existing vaults. :)
Mar 28 2018
Mar 24 2018
"can't" should not be used in formal writings. Not sure how formal documentation is considered to be.
Mar 22 2018
You can also switch to 'can't' as far as I'm concerned
Mar 19 2018
Mar 11 2018
Mar 7 2018
Feb 26 2018
The fix needs to be a bit more complex. We can not really rely on the user to fix the database.
Feb 21 2018
Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that calls ::instance in ResultSet :) - because of this, I'm changing to 'Request Changes').
Feb 20 2018
This is not really as simple as 'accept without a comment'.
Feb 16 2018
Feb 12 2018
Feb 10 2018
Feb 9 2018
I can not say with certainty - never tested html encoding, but I would expect it to work in general.
Feb 8 2018
Feb 6 2018
Maybe hardcoding is a good idea, I have nothing against that. Though, I'm not sure hardcoding to 6 is the best one - I'm torn between that one and the next :)
Noise is often used to break the gradient visual artifacts that appear due to screens' inability to show colors precisely. You often get the impression there are lines orthogonal to the gradient direction which ruins the gradient.
Jan 29 2018
Jan 28 2018
Jan 21 2018
Jan 10 2018
Dec 9 2017
I've pushed this patch with a few changes (don't want to wait the last moment before the string freeze).
Dec 7 2017
Hi @abetts , we need a nice dialogue that shows the password entry for unlocking a vault. You have the current proposal screenshot above.
Dec 5 2017
Since VDG has not responded. Can you remove the padding and make the name bold?
Dec 1 2017
Why don't you set up the preferred size for the dialogue, and allow the label to be multi-line?
Nov 30 2017
@ngraham I can not reproduce the text overflow bud you are getting. I'm not setting any size-related things, so the bug is probably in the upstream (libplasma or above)
- Reverted the 'create a new vault button' to be a proper button