ivan (Ivan Čukić)
User

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:17 PM (267 w, 1 d)
Availability
Available

Recent Activity

Wed, May 20

ivan committed R845:991d5ac68dbb: Update .vim-template:h (authored by ivan).
Update .vim-template:h
Wed, May 20, 10:26 PM
ivan committed R6:82a88837ba27: Added logo for GitLab (authored by ivan).
Added logo for GitLab
Wed, May 20, 10:56 AM
ivan committed R161:ec7004ed4213: Added logo for GitLab (authored by ivan).
Added logo for GitLab
Wed, May 20, 10:54 AM
ivan committed R6:2a8b63a83a82: Added logo for GitLab (authored by ivan).
Added logo for GitLab
Wed, May 20, 10:54 AM
ivan committed R159:9d31c7b3aaea: Added logo for GitLab (authored by ivan).
Added logo for GitLab
Wed, May 20, 10:54 AM

Tue, May 19

ivan committed R610:139a652dfa1e: Added icon for GitLab (authored by ivan).
Added icon for GitLab
Tue, May 19, 10:28 PM
ivan committed R119:17a5a00ddd59: Add Plasma icon for GitLab (authored by ivan).
Add Plasma icon for GitLab
Tue, May 19, 10:05 PM
ivan committed R119:d39d8f778c87: Fixed switcher hiding issue (authored by ivan).
Fixed switcher hiding issue
Tue, May 19, 10:05 PM

Mon, May 18

ivan accepted D22702: [fileitemaction] Clean up includes.
Mon, May 18, 5:40 PM · Plasma

Sun, May 17

ivan committed R55:41c8153f77bd: GIT_SILENT: we don't use phabricator now (authored by ivan).
GIT_SILENT: we don't use phabricator now
Sun, May 17, 8:58 PM
ivan added a reverting change for R55:c3b3f5165c31: GIT_SILENT: we don't use phabricator now: R55:ad17af90ef25: Revert "GIT_SILENT: we don't use phabricator now".
Sun, May 17, 8:58 PM
ivan committed R55:ad17af90ef25: Revert "GIT_SILENT: we don't use phabricator now" (authored by ivan).
Revert "GIT_SILENT: we don't use phabricator now"
Sun, May 17, 8:58 PM
ivan committed R845:b7472568ab00: Added logo for GitLab (authored by ivan).
Added logo for GitLab
Sun, May 17, 8:35 PM
ivan committed R247:0af0d56e921f: Support URLs starting with ssh:// (authored by ivan).
Support URLs starting with ssh://
Sun, May 17, 6:46 PM

Tue, May 12

ivan committed R119:ca2e2bb26ebb: Dedicated drop areas for assigning tasks to activities (authored by ivan).
Dedicated drop areas for assigning tasks to activities
Tue, May 12, 6:05 PM
ivan closed D29679: Dedicated drop areas for assigning tasks to activities.
Tue, May 12, 6:05 PM · Plasma
ivan added a comment to D29595: Add gocryptfs support.

Done. Thanks again for the patch!

Tue, May 12, 4:39 PM · Plasma
ivan closed D29595: Add gocryptfs support.
Tue, May 12, 4:38 PM · Plasma
ivan committed R845:853b0be5a4ac: Add gocryptfs support (authored by mpilia).
Add gocryptfs support
Tue, May 12, 4:38 PM
ivan updated the summary of D29679: Dedicated drop areas for assigning tasks to activities.
Tue, May 12, 1:52 PM · Plasma
ivan requested review of D29679: Dedicated drop areas for assigning tasks to activities.
Tue, May 12, 1:51 PM · Plasma
ivan accepted D29595: Add gocryptfs support.
Tue, May 12, 8:25 AM · Plasma

Mon, May 11

ivan added inline comments to D29595: Add gocryptfs support.
Mon, May 11, 6:49 PM · Plasma
ivan requested changes to D29595: Add gocryptfs support.

Great work!

Mon, May 11, 6:06 PM · Plasma
ivan requested changes to D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar.

Superseeded by https://phabricator.kde.org/D29548 since there was no activity for >2 months.

Mon, May 11, 4:08 PM · Plasma
ivan committed R119:9ef7eab988f3: Drag and drop assigning windows to activities in the default switcher (authored by ivan).
Drag and drop assigning windows to activities in the default switcher
Mon, May 11, 4:05 PM
ivan closed D29548: Drag and drop assigning windows to activities in the default switcher.
Mon, May 11, 4:05 PM · Plasma

Sat, May 9

ivan updated the summary of D29548: Drag and drop assigning windows to activities in the default switcher.
Sat, May 9, 7:55 AM · Plasma
ivan requested review of D29548: Drag and drop assigning windows to activities in the default switcher.
Sat, May 9, 7:48 AM · Plasma

Mon, May 4

ivan committed R845:2befe1ffd7d7: Unassign activity from vault on activity deletion (authored by ivan).
Unassign activity from vault on activity deletion
Mon, May 4, 2:39 PM
ivan closed D29379: Unassign activity from vault on activity deletion.
Mon, May 4, 2:39 PM · Plasma

Sun, May 3

ivan added a reviewer for D29379: Unassign activity from vault on activity deletion: davidedmundson.
Sun, May 3, 9:09 AM · Plasma
ivan updated the diff for D29379: Unassign activity from vault on activity deletion.
Sun, May 3, 8:53 AM · Plasma
ivan requested review of D29379: Unassign activity from vault on activity deletion.
Sun, May 3, 8:51 AM · Plasma

Apr 24 2020

ivan added a comment to T13037: Wallpapers Model in KActivities.

A model like this could be quite useful I think.

Apr 24 2020, 6:39 PM · Plasma, KActivities
ivan accepted D29110: [applet] Port to Kirigami.PlaceholderMessage.

Fair enough.

Apr 24 2020, 4:43 AM · Plasma

Apr 23 2020

ivan added a comment to D29130: [Applet] Show in system tray iff at least one vault is open.

And I'l just be using my keyboard shortcut ;)

Apr 23 2020, 9:26 PM · Plasma
ivan added a comment to D29130: [Applet] Show in system tray iff at least one vault is open.

I'm not fond of this change, but I agree with Nate's comment about the possibility of setting 'always visible' for users that wish to keep the current behaviour, so I'm not going to give this a -1.

Apr 23 2020, 9:03 PM · Plasma
ivan accepted D29139: Remove .clang-format.
Apr 23 2020, 8:50 PM · Plasma
ivan added a comment to D29110: [applet] Port to Kirigami.PlaceholderMessage.

Not sure I like pulling in Kirigami just for this. Are there other places where Kirigami could improve the Vaults applet?

Apr 23 2020, 8:50 PM · Plasma

Apr 21 2020

ivan added inline comments to D28333: Add a new daemon for stats monitoring.
Apr 21 2020, 9:25 AM · Plasma
ivan added inline comments to D28333: Add a new daemon for stats monitoring.
Apr 21 2020, 9:16 AM · Plasma

Apr 17 2020

ivan committed R845:5920e79ebc69: Make sure we have saved network state before accessing it (authored by ivan).
Make sure we have saved network state before accessing it
Apr 17 2020, 1:42 PM

Apr 13 2020

ivan accepted D28798: Make warning and error messages grammatically correct.
Apr 13 2020, 6:27 PM · Plasma
ivan added a comment to D28798: Make warning and error messages grammatically correct.

Maybe "Unable to close the vault; it is being used by %1" -> "Unable to close the vault as it is being used by %1" ?

Apr 13 2020, 4:48 PM · Plasma
ivan accepted D28746: Show previews on encrypted filesystems.
Apr 13 2020, 3:54 PM · Frameworks
ivan accepted D28745: Skip caching thumbnails on encrypted filesystems.
Apr 13 2020, 9:40 AM · Frameworks, Dolphin
ivan added inline comments to D28746: Show previews on encrypted filesystems.
Apr 13 2020, 9:39 AM · Frameworks
ivan added inline comments to D28746: Show previews on encrypted filesystems.
Apr 13 2020, 7:21 AM · Frameworks
ivan requested changes to D28745: Skip caching thumbnails on encrypted filesystems.
Apr 13 2020, 7:19 AM · Frameworks, Dolphin

Apr 3 2020

ivan added a comment to D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar.

Any news on this?

Apr 3 2020, 8:49 AM · Plasma

Mar 19 2020

ivan added a comment to D28136: Add the option to show the current activity name and icon.

used Layouts instead of Anchors

Mar 19 2020, 3:54 PM · Plasma
ivan committed R119:67036074919f: Merge branch 'ivan/activity-switcher-applet-name-and-icon' (authored by ivan).
Merge branch 'ivan/activity-switcher-applet-name-and-icon'
Mar 19 2020, 3:54 PM
ivan committed R119:36e322792002: Add the option to show the current activity name and icon (authored by ivan).
Add the option to show the current activity name and icon
Mar 19 2020, 3:54 PM
ivan closed D28136: Add the option to show the current activity name and icon.
Mar 19 2020, 3:53 PM · Plasma
ivan added a comment to D28136: Add the option to show the current activity name and icon.

Last change - use "activities" icon if no icon is set (though this should not happen if the user creates the activity through legal ways)

Mar 19 2020, 3:27 PM · Plasma
ivan updated the diff for D28136: Add the option to show the current activity name and icon.
Mar 19 2020, 3:25 PM · Plasma
ivan added a comment to D28136: Add the option to show the current activity name and icon.

Done

Mar 19 2020, 3:18 PM · Plasma
ivan updated the diff for D28136: Add the option to show the current activity name and icon.
Mar 19 2020, 3:17 PM · Plasma
ivan added a comment to D28136: Add the option to show the current activity name and icon.

Kirigami has quite interesting features I must say :)

Mar 19 2020, 2:34 PM · Plasma
ivan updated the diff for D28136: Add the option to show the current activity name and icon.
Mar 19 2020, 2:33 PM · Plasma
ivan added a comment to D28136: Add the option to show the current activity name and icon.

The reason for the icon setting is to have full backwards compatibility. Maybe someone likes the static icon better than random icons they set for each activity. I don't like to have everything configurable, but here it is not a significant maintainance overhead, and the configuration dialogue would be quite dull with a single checkbox :)

Mar 19 2020, 2:28 PM · Plasma
ivan added reviewers for D28136: Add the option to show the current activity name and icon: ngraham, davidedmundson, mart.
Mar 19 2020, 10:20 AM · Plasma
ivan added a comment to D28136: Add the option to show the current activity name and icon.

Screenshot:

Mar 19 2020, 10:20 AM · Plasma
ivan requested review of D28136: Add the option to show the current activity name and icon.
Mar 19 2020, 10:16 AM · Plasma

Mar 17 2020

ivan committed R845:1e2988d7d3ca: Show command output on unknown failure (authored by ivan).
Show command output on unknown failure
Mar 17 2020, 3:24 PM
ivan committed R845:28390f86f041: Merge branch 'ivan/more-error-info' (authored by ivan).
Merge branch 'ivan/more-error-info'
Mar 17 2020, 3:24 PM
ivan closed D28099: Show command output on unknown failure.
Mar 17 2020, 3:24 PM · Plasma
ivan committed R348:9b147c384254: activated signal of QComboBox is overloaded, wrap it in QOverloaded (authored by ivan).
activated signal of QComboBox is overloaded, wrap it in QOverloaded
Mar 17 2020, 3:00 PM
ivan updated the diff for D28099: Show command output on unknown failure.
Mar 17 2020, 2:36 PM · Plasma
ivan abandoned D28100: Do not block when showing the details message.
Mar 17 2020, 2:34 PM
ivan requested review of D28100: Do not block when showing the details message.
Mar 17 2020, 2:34 PM
ivan added a dependent revision for D28099: Show command output on unknown failure: D28100: Do not block when showing the details message.
Mar 17 2020, 2:34 PM · Plasma
ivan added a comment to D28099: Show command output on unknown failure.

Of course... I need to reboot my brain it seems.

Mar 17 2020, 2:32 PM · Plasma
ivan committed R845:f6a924b37880: Make sure we have saved network state before accessing it (authored by ivan).
Make sure we have saved network state before accessing it
Mar 17 2020, 1:38 PM
ivan requested review of D28099: Show command output on unknown failure.
Mar 17 2020, 1:14 PM · Plasma

Mar 16 2020

ivan committed R161:9a36c4da7d7a: Support execution of shell scripts on activity events (authored by ivan).
Support execution of shell scripts on activity events
Mar 16 2020, 1:11 PM
ivan closed D28069: Support execution of shell scripts on activity events.
Mar 16 2020, 1:11 PM · Plasma
ivan committed R161:93d81bd05661: Require C++17 (authored by ivan).
Require C++17
Mar 16 2020, 1:11 PM
ivan updated the summary of D28069: Support execution of shell scripts on activity events.
Mar 16 2020, 12:59 PM · Plasma
ivan updated the diff for D28069: Support execution of shell scripts on activity events.
Mar 16 2020, 12:57 PM · Plasma
ivan requested review of D28069: Support execution of shell scripts on activity events.
Mar 16 2020, 11:39 AM · Plasma
ivan committed R161:a28972ffe1e7: No need to use QSet for activity existence checking (authored by ivan).
No need to use QSet for activity existence checking
Mar 16 2020, 11:29 AM

Mar 15 2020

ivan accepted D28035: [Applet] Port to ExpandableListItem.

I assume people tell you that you're awesome all the time, so I'm not going to ;)

Mar 15 2020, 7:25 AM · Plasma
ivan added a comment to D28035: [Applet] Port to ExpandableListItem.

I like it. Is the device notifier going to look like this as Vaaults tried to mimic that one?

Mar 15 2020, 12:22 AM · Plasma

Feb 26 2020

ivan added a comment to D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar.

This looks cool. The thing I'm missing (correct me if I'm wrong - I'm yet to test the patch) is for it to open the switcher when dragging the window over the switcher applet icon.

Feb 26 2020, 4:55 PM · Plasma

Feb 16 2020

ivan added a comment to D27322: Allow move or add window to Activities during Dnd using Ctrl modifier.

Cool idea, I'll have to think of something similar for the regular activity switcher

Feb 16 2020, 8:11 AM · Plasma
ivan accepted D24401: Use exposed DBus methods to switch activities in CLI.
Feb 16 2020, 8:08 AM · Frameworks

Jan 20 2020

ivan accepted D26798: Fix broken SQL query in allResourcesQuery.
Jan 20 2020, 8:24 PM · Frameworks

Jan 7 2020

ivan accepted D26447: Dynamically show and hide based on whether or not any vaults are configured.

That is why I put the "or in addition to" part.

Jan 7 2020, 2:35 PM · Plasma

Jan 6 2020

ivan added a comment to D26111: Runner: make recentdocument use KActivityStats data.

Why not change the recentdocuments runner?

Jan 6 2020, 9:41 PM · Plasma
ivan accepted D26474: Fix build with gpsd 3.20.
Jan 6 2020, 7:29 PM · Plasma
ivan accepted D26438: Runners: Convert foreach to for.

I hate Qt... defining operator* without operator-> ... ugh

Jan 6 2020, 12:38 PM · Plasma
ivan requested changes to D26438: Runners: Convert foreach to for.

Yes, the wrapper just serves for keyval iterators to be usable with a range-based for loop. Quite useful if there are a lot of these. In this case, where it is only one loop I agree it might be an overkill.

Jan 6 2020, 11:05 AM · Plasma
ivan added a comment to D26438: Runners: Convert foreach to for.

Something like this:

Jan 6 2020, 10:47 AM · Plasma
ivan requested changes to D26438: Runners: Convert foreach to for.
Jan 6 2020, 10:39 AM · Plasma
ivan accepted D26415: Ensure to store resource uri without a trailing slash.

TBH, I'd like more to have dirs always end with a slash, but I guess this is fine as well.

Jan 6 2020, 10:06 AM · Frameworks
ivan added a comment to D26447: Dynamically show and hide based on whether or not any vaults are configured.

For some reason, hiding this icon when there are no vaults was deemed undesired before. I don't recall why as I think it is a good idea. :)

Jan 6 2020, 9:59 AM · Plasma

Nov 3 2019

ivan accepted D25042: Rename cmake project to KActivityManagerd, remove unused option.
Nov 3 2019, 9:42 PM · Plasma

Oct 17 2019

ivan accepted D24741: Add a utility accessor to get a QUrl from a ResultSet::Result.

Just add TODO and you are free to push

Oct 17 2019, 7:01 PM · Frameworks