ivan (Ivan Čukić)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:17 PM (138 w, 6 d)
Availability
Available

Recent Activity

Sat, Dec 9

ivan committed R845:48e50b9343f9: Disable the password dialogue while trying to open the vault (authored by ivan).
Disable the password dialogue while trying to open the vault
Sat, Dec 9, 6:37 AM
ivan added a comment to D8787: Fix PWD dialog.

I've pushed this patch with a few changes (don't want to wait the last moment before the string freeze).

Sat, Dec 9, 6:35 AM · Plasma
ivan committed R845:eeedbb05531c: Added password dialogue title (authored by ivan).
Added password dialogue title
Sat, Dec 9, 6:33 AM
ivan committed R845:b80ee599b39f: Fix PWD dialog (authored by cryptodude).
Fix PWD dialog
Sat, Dec 9, 6:29 AM
ivan closed D8787: Fix PWD dialog.
Sat, Dec 9, 6:29 AM · Plasma

Thu, Dec 7

ivan added a comment to D8787: Fix PWD dialog.

Hi @abetts , we need a nice dialogue that shows the password entry for unlocking a vault. You have the current proposal screenshot above.

Thu, Dec 7, 10:15 PM · Plasma

Tue, Dec 5

ivan added a comment to D8787: Fix PWD dialog.

Since VDG has not responded. Can you remove the padding and make the name bold?

Tue, Dec 5, 4:37 PM · Plasma

Fri, Dec 1

ivan updated subscribers of D8787: Fix PWD dialog.

Why don't you set up the preferred size for the dialogue, and allow the label to be multi-line?

Fri, Dec 1, 2:01 PM · Plasma
ivan committed R845:fef23f48913f: Better UI for the "Create a new vault" button (authored by ivan).
Better UI for the "Create a new vault" button
Fri, Dec 1, 1:58 PM
ivan closed D9045: Better UI for the "Create a new vault" button.
Fri, Dec 1, 1:58 PM · Plasma

Thu, Nov 30

ivan added a comment to D9045: Better UI for the "Create a new vault" button.

@ngraham I can not reproduce the text overflow bud you are getting. I'm not setting any size-related things, so the bug is probably in the upstream (libplasma or above)

Thu, Nov 30, 7:07 AM · Plasma
ivan updated the summary of D9045: Better UI for the "Create a new vault" button.
Thu, Nov 30, 7:05 AM · Plasma
ivan updated the diff for D9045: Better UI for the "Create a new vault" button.
  • Reverted the 'create a new vault button' to be a proper button
Thu, Nov 30, 7:04 AM · Plasma

Wed, Nov 29

ivan retitled D9045: Better UI for the "Create a new vault" button from "New vault" action is now a tool button to Better UI for the "Create a new vault" button.
Wed, Nov 29, 8:24 AM · Plasma
ivan created D9045: Better UI for the "Create a new vault" button.
Wed, Nov 29, 8:22 AM · Plasma
ivan added a comment to D8787: Fix PWD dialog.

Almost mergeable - I just have a few nit-picks:

Wed, Nov 29, 8:04 AM · Plasma
ivan committed R845:7f15ce922069: Have a default backend (if one available) (authored by cryptodude).
Have a default backend (if one available)
Wed, Nov 29, 7:53 AM
ivan closed D8449: Have a default backend (if one available).
Wed, Nov 29, 7:53 AM · Plasma
ivan accepted D8449: Have a default backend (if one available).
Wed, Nov 29, 7:49 AM · Plasma
ivan added a comment to D8449: Have a default backend (if one available).

I was on a vacation, sorry. I'll test everything today and merge it if I don't find a problem.

Wed, Nov 29, 7:44 AM · Plasma

Fri, Nov 17

ivan added a comment to D8524: Add a signal notifying a change in the names of running activities..

The activities cache is a private class meant to communicate directly to KAMD. The signals it contains are in the form (activity id, something) and are meant to be private. The KActivities::Info class was meant to wrap these signals into a nice OO API where an activity object (Info) sends signals that a particular property has changed.

Fri, Nov 17, 12:24 PM · Plasma

Nov 3 2017

ivan added a comment to D8561: [d_ptr] Do not harsh destroy QThread .

While I like the idea behind the patch, I'd rather have what David proposed. Namely, d_ptr is a smart pointer, but I don't think it should be this smart - creating specializations for different types' destructors should not really be a part of it.

Nov 3 2017, 9:35 AM · Plasma

Oct 29 2017

ivan added a comment to D8524: Add a signal notifying a change in the names of running activities..

Also, not sure adding a signal that has one user only to a shared library is the best approach, especially since .h says this:

Oct 29 2017, 12:35 PM · Plasma
ivan committed R845:07311c73b5dd: Use XDG_DATA_HOME and security fix (authored by cryptodude).
Use XDG_DATA_HOME and security fix
Oct 29 2017, 9:14 AM
ivan closed D8469: Use XDG_DATA_HOME and security fix.
Oct 29 2017, 9:14 AM · Plasma
ivan committed R845:bd8d38c0c355: Added Phabricator uri (authored by ivan).
Added Phabricator uri
Oct 29 2017, 8:25 AM
ivan accepted D8469: Use XDG_DATA_HOME and security fix.
Oct 29 2017, 8:20 AM · Plasma

Oct 25 2017

ivan added inline comments to D8469: Use XDG_DATA_HOME and security fix.
Oct 25 2017, 8:48 PM · Plasma
ivan added a comment to D8469: Use XDG_DATA_HOME and security fix.

This one is almost mergeable.

Oct 25 2017, 7:50 PM · Plasma
ivan added a comment to D8449: Have a default backend (if one available).

I was not clear enough probably - I meant that "Have a default backend" does not warrant a change to the UI. Especially when it makes the UI more complex.

Oct 25 2017, 7:37 PM · Plasma

Oct 24 2017

ivan added a comment to D8449: Have a default backend (if one available).

p.s.

Do I need to relogin to make a kded module show up?

Oct 24 2017, 4:32 PM · Plasma
ivan added a comment to D8449: Have a default backend (if one available).

Having a default backend (IMO) has nothing to do with the UI. What is the rationale behind changing a combo-box (a widget designed for multiple choice questions) to a button?

Oct 24 2017, 4:29 PM · Plasma

Oct 23 2017

ivan accepted D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments.

Looks ok.

Oct 23 2017, 9:21 PM · Plasma

Oct 11 2017

ivan added a comment to D8178: Fix editing items in SimpleFavoritesModel.

Somehow I didn't submit the comment when I wrote it. See above.

Oct 11 2017, 8:28 PM · Plasma
ivan added inline comments to D8178: Fix editing items in SimpleFavoritesModel.
Oct 11 2017, 8:28 PM · Plasma

Sep 28 2017

ivan accepted D8026: [Activity KCM] Disallow adding/removing activity when restricted.
Sep 28 2017, 5:12 PM · Plasma

Sep 23 2017

ivan updated the task description for T7050: Privacy Software.
Sep 23 2017, 7:50 AM · Goal settings 2017

Sep 8 2017

ivan committed R119:4ba9b01e2d6a: Per-activity favorites (Final, again?) (authored by ivan).
Per-activity favorites (Final, again?)
Sep 8 2017, 8:46 PM
ivan closed D3805: Per-activity favorites (Final, again?) by committing R119:4ba9b01e2d6a: Per-activity favorites (Final, again?).
Sep 8 2017, 8:46 PM · Plasma
ivan committed R159:18ac1c70490f: Changed the default query limit to zero (authored by ivan).
Changed the default query limit to zero
Sep 8 2017, 11:41 AM
ivan committed R159:ac98fecefdd3: Added the option to enable model tester (authored by ivan).
Added the option to enable model tester
Sep 8 2017, 11:41 AM
ivan updated the diff for D3805: Per-activity favorites (Final, again?).

Increasing the result limit

Sep 8 2017, 11:32 AM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).

More debugging...

Sep 8 2017, 10:46 AM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).

Removed model test

Sep 8 2017, 9:40 AM · Plasma
ivan committed R845:34deb086b5a3: Added option to switch off networking when a vault is mounted (authored by ivan).
Added option to switch off networking when a vault is mounted
Sep 8 2017, 6:21 AM

Sep 7 2017

ivan updated the diff for D3805: Per-activity favorites (Final, again?).
Sep 7 2017, 6:11 PM · Plasma
ivan committed R845:de34b6a9eec2: Disabling vault dismantling (authored by ivan).
Disabling vault dismantling
Sep 7 2017, 7:07 AM
ivan added a comment to D3805: Per-activity favorites (Final, again?).

p.s. This is how I restart everything:

Sep 7 2017, 6:51 AM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).

Another one to test:

  • fixed a small bug related to fav adding
  • added debugging output for easier testing (when you encounter a bug, send me an email with plasma output)
Sep 7 2017, 6:50 AM · Plasma

Sep 5 2017

ivan updated the diff for D3805: Per-activity favorites (Final, again?).

Fixing the ordering

Sep 5 2017, 10:59 AM · Plasma

Sep 4 2017

ivan updated the diff for D3805: Per-activity favorites (Final, again?).
Sep 4 2017, 12:26 PM · Plasma
ivan committed R845:b2f9109c440d: Configuration dialogue for vaults (authored by ivan).
Configuration dialogue for vaults
Sep 4 2017, 11:51 AM
ivan added a comment to D3805: Per-activity favorites (Final, again?).

Post-migration sorting still feels completely random - not sure how solid that feeling is though.

Sep 4 2017, 10:45 AM · Plasma

Sep 2 2017

ivan committed R161:2a978d3647f1: Separating queries for removing from a specific activity and from all activities (authored by ivan).
Separating queries for removing from a specific activity and from all activities
Sep 2 2017, 9:35 PM
ivan added a comment to D3805: Per-activity favorites (Final, again?).

The last patch supports Kickoff, Kicker and Dash. I've tested what I can, found an small issue in KAMD (update KAMD to latest master before testing) and it looks like we are on the finish line.

Sep 2 2017, 9:23 PM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).
Sep 2 2017, 9:21 PM · Plasma
ivan updated the summary of D3805: Per-activity favorites (Final, again?).
Sep 2 2017, 9:19 PM · Plasma

Sep 1 2017

ivan added a comment to D3805: Per-activity favorites (Final, again?).

Good news: There's actually nothing to do on the favorite ids, Kicker already uses
KService::storageId as favorite id, which will be the menuId when it's available.

Sep 1 2017, 5:40 AM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).
Sep 1 2017, 5:39 AM · Plasma

Aug 31 2017

ivan added a comment to D3805: Per-activity favorites (Final, again?).

This might be a hint:

Aug 31 2017, 5:37 PM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

Regarding Kickoff - it looks like there are some problems in its model handling:

Aug 31 2017, 5:35 PM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

The initial sorting of the migrated superset seems random. How is it done?

Aug 31 2017, 5:19 PM · Plasma

Aug 30 2017

ivan added a comment to D3805: Per-activity favorites (Final, again?).

With icons (designed after the Dolphin plugin for activity linking - to at least be consistent with something :) )

Aug 30 2017, 7:56 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

Like this?

Aug 30 2017, 7:36 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

No Kickoff support: Personally I think we should actually migrate all applets at once.

Aug 30 2017, 6:13 AM · Plasma

Aug 17 2017

ivan committed R159:1b04f4bd55f5: Refactor of the query which combines linked and used resources (authored by ivan).
Refactor of the query which combines linked and used resources
Aug 17 2017, 8:48 PM
ivan committed R159:f98bd1c09809: Switched debugging output off (authored by ivan).
Switched debugging output off
Aug 17 2017, 11:28 AM
ivan committed R159:61fbc05340bc: Reloading the model when the resource gets unlinked (authored by ivan).
Reloading the model when the resource gets unlinked
Aug 17 2017, 11:27 AM
ivan committed R159:5c0dc259a096: Fixed the query when merging linked and used resources (authored by ivan).
Fixed the query when merging linked and used resources
Aug 17 2017, 11:27 AM

Aug 16 2017

ivan added a comment to D3805: Per-activity favorites (Final, again?).

p.s. Transitioned items go to all activities and the documents are supported in the current patch.

Aug 16 2017, 9:39 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

Hmm I think the Kickoff thing might have been a misunderstanding, or maybe I was full of crap then?

Aug 16 2017, 9:38 AM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).
Aug 16 2017, 9:36 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

The result of the migration is now the superset of all faves, but sorting is a bit weird (maybe this is the best possible?)

Aug 16 2017, 8:50 AM · Plasma

Jul 15 2017

ivan updated the diff for D3805: Per-activity favorites (Final, again?).

This was a referse-murphy - the second I posted that I can not find the reason behind the crash, I managed. Can you try the current revision whether it crashes or not?

Jul 15 2017, 11:48 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

I've finally managed to reproduce the crash (clean install, clean build, clean everything). I still do not see what is the cause of it...

Jul 15 2017, 11:23 AM · Plasma

Jul 11 2017

ivan accepted D6634: Require C++14.

Ignore my comment above, I'm colour-blind today :D

Jul 11 2017, 8:29 PM · KWin
ivan requested changes to D6634: Require C++14.

It is undefined behaviour to extend std:: namespace in this way. You should go for this instead:

Jul 11 2017, 8:22 PM · KWin

Jul 3 2017

ivan updated the test plan for D3805: Per-activity favorites (Final, again?).
Jul 3 2017, 7:18 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

True, I haven't updated the branch - had more than a few sub-branches since the last update.

Jul 3 2017, 7:16 AM · Plasma

Jul 2 2017

ivan updated the test plan for D3805: Per-activity favorites (Final, again?).
Jul 2 2017, 11:46 AM · Plasma
ivan added a comment to D3805: Per-activity favorites (Final, again?).

I've just added another test - having a custom kicker plasmoidsetupscript and putting kicker to be the default launcher on a blank user loads the favourites from said plasmoidsetupscript.

Jul 2 2017, 11:44 AM · Plasma
ivan added inline comments to D5677: Fix clearing recent usage history.
Jul 2 2017, 11:05 AM

Jun 26 2017

ivan committed R845:d1a0a78d3977: Added actions to the vault items in the applet (authored by ivan).
Added actions to the vault items in the applet
Jun 26 2017, 7:11 PM
ivan updated the test plan for D3805: Per-activity favorites (Final, again?).
Jun 26 2017, 12:45 PM · Plasma
ivan updated the summary of D3805: Per-activity favorites (Final, again?).
Jun 26 2017, 12:32 PM · Plasma
ivan updated the diff for D3805: Per-activity favorites (Final, again?).

I realized I can be quite thick.

Jun 26 2017, 12:30 PM · Plasma

Jun 23 2017

ivan updated the diff for D3805: Per-activity favorites (Final, again?).
Jun 23 2017, 7:28 AM · Plasma

May 24 2017

ivan added a comment to D5950: Implement the new panel icon size ceiling also for Activities..

It would be nicer if we had a better way to do this instead of having a chunk of code copy-pasted all over the place.

May 24 2017, 5:20 AM · Plasma

May 22 2017

ivan committed R845:8ca53b87c5a1: Merge branch 'Plasma/5.10' (authored by ivan).
Merge branch 'Plasma/5.10'
May 22 2017, 5:21 PM
ivan committed R845:b9882bf05af9: Report that the process has finished if we got an error executing it (authored by ivan).
Report that the process has finished if we got an error executing it
May 22 2017, 5:19 PM
ivan committed R120:e8e2be90834b: We should not forget the launchers that are not currently shown (authored by ivan).
We should not forget the launchers that are not currently shown
May 22 2017, 10:24 AM
ivan closed D5933: We should not forget the launchers that are not currently shown by committing R120:e8e2be90834b: We should not forget the launchers that are not currently shown.
May 22 2017, 10:23 AM · Plasma
ivan added a comment to D5933: We should not forget the launchers that are not currently shown.

This is meant to fix the https://bugs.kde.org/show_bug.cgi?id=379414

May 22 2017, 8:15 AM · Plasma
ivan created D5933: We should not forget the launchers that are not currently shown.
May 22 2017, 8:11 AM · Plasma

May 17 2017

ivan committed R499:62fa877295c8: Updated dependencies for plasma-vault (authored by ivan).
Updated dependencies for plasma-vault
May 17 2017, 7:22 PM

May 6 2017

ivan committed R119:65a42d8a2be1: Adding an option to show popular documents/apps for Kickoff (authored by ivan).
Adding an option to show popular documents/apps for Kickoff
May 6 2017, 4:16 PM
ivan closed D5620: Adding an option to show popular documents/apps for Kickoff by committing R119:65a42d8a2be1: Adding an option to show popular documents/apps for Kickoff.
May 6 2017, 4:16 PM · Plasma
ivan added a comment to D5620: Adding an option to show popular documents/apps for Kickoff.

Not sure I'd rush it for 5.11. I'll probably have to tweak the formula coefficients for the score - how much deterioration over time it should have, ... (this is the main reason I'm making the graphs - to be able to easier debug the stats - having it in a user application is less important.

May 6 2017, 4:16 PM · Plasma
ivan accepted D4906: Fix kactivities-stats into tier3.

This is a good point. *

May 6 2017, 5:01 AM · Frameworks
ivan committed R6:3463cde61d71: We are using only Tier 1 frameworks, so move us to Tier 2 (authored by ivan).
We are using only Tier 1 frameworks, so move us to Tier 2
May 6 2017, 5:01 AM