- User Since
- Apr 14 2015, 9:17 PM (227 w, 2 d)
You can also use set*/add* member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say set*/add* is a fine option.
This is something I did have initally in kastats, it was killed because while this is tempting
Sorry I missed this one. If I don't react on a ping here, just send me a direct mail.
Mon, Aug 19
Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?
Sat, Aug 17
Fri, Aug 16
Another tiny change, and I think it is ready to land. Unless someone else sees other issues.
Thu, Aug 15
Tue, Aug 13
Thanks for geting involved this much!
Sat, Jul 27
Thu, Jul 25
If @kossebau is satisfied, go for it
Wed, Jul 24
Joining with ResourceEvent is a problem. At least make it not get joined if the date filter is not present.
Jul 24 2019
Jul 11 2019
Inserting/Removing/Updating a sorted list does not need to resort every time - removing is easy, adding a new item is std::lower_bound (a binary search), and updating is a combination of the two.
Jul 10 2019
You are right, they are randomized.
Jun 26 2019
I think it would be better to put it into kio-extras - activities kio is also there.
I'd add support for HighScoredFirst and RecentlyCreatedFirst. Maybe the protocol could be something like "used:/" or something.
May 1 2019
WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself.
I guess that is the main point of this patch. I don't think that anyone is against that. :)
I'm torn between two approaches:
Thanks for working on this.
Apr 4 2019
Apr 2 2019
Mar 24 2019
Mar 23 2019
Accepted, but incomplete ;)
Mar 22 2019
Incorporated David's advice
Feb 6 2019
Feb 3 2019
Jan 5 2019
Jan 4 2019
Jan 3 2019
Dec 31 2018
Dec 18 2018
Dec 4 2018
Dec 2 2018
Nov 21 2018
Ok, +2 from me then
Using a shared pointer seems like a pessimization. Could this be done with std::unique_ptr?
Oct 26 2018
I'll be serving as the goal keeper for the next period.
Oct 16 2018
It is (also) a noun, though MW spells it as "pop-up" 
Lambdas are generally faster to compile and execute. std::bind can make code less verbose, but that is not the case here (I'd say that lambdas win on succinctness here).
The parentheses are not necessary when a lambda has no arguments.
Oct 13 2018
Different search bars are on different levels of usefulness.
Oct 10 2018
Not sure what the implications are for this change, it does fix Dolphin showing folders in its
Oct 8 2018
Aug 15 2018
Ok, though a better approach IMO would be to fix linking the non-local URLs :)
Aug 7 2018
Jul 27 2018
Jul 26 2018
Jul 23 2018
Jul 8 2018
Jun 12 2018
Jun 9 2018
Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.
Jun 1 2018
- Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
- Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
- What about the configuration UI?