- User Since
- Apr 14 2015, 9:17 PM (191 w, 5 d)
Tue, Dec 4
Sun, Dec 2
Wed, Nov 21
Ok, +2 from me then
Using a shared pointer seems like a pessimization. Could this be done with std::unique_ptr?
Oct 26 2018
I'll be serving as the goal keeper for the next period.
Oct 16 2018
It is (also) a noun, though MW spells it as "pop-up" 
Lambdas are generally faster to compile and execute. std::bind can make code less verbose, but that is not the case here (I'd say that lambdas win on succinctness here).
The parentheses are not necessary when a lambda has no arguments.
Oct 13 2018
Different search bars are on different levels of usefulness.
Oct 10 2018
Not sure what the implications are for this change, it does fix Dolphin showing folders in its
Oct 8 2018
Aug 15 2018
Ok, though a better approach IMO would be to fix linking the non-local URLs :)
Aug 7 2018
Jul 27 2018
Jul 26 2018
Jul 23 2018
Jul 8 2018
Jun 12 2018
Jun 9 2018
Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.
Jun 1 2018
- Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
- Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
- What about the configuration UI?
May 26 2018
Was more aimed at @nicolasfella :)
So... accepted? :)
Thanks for the suggestion!
Using loginctl for session locking as well
Looks ok to me.
May 21 2018
May 19 2018
May 17 2018
The second one sounds ok
May 16 2018
The problem with the original wording is mainly in using singular. It is for linking files to activities. I'm open to suggestions.
May 15 2018
Maybe "Linking files to activities" would be better?
May 13 2018
May 9 2018
May 2 2018
May 1 2018
I pushed it by accident, and I didn't want to revert just to push it to the phab again. Though, I did count that you'll check it out in the end even if it is already merged :)
Apr 29 2018
Apr 28 2018
If KRunner has multiple threads accessing the same sqlite database, then yes.
Apr 26 2018
Apr 10 2018
Apr 9 2018
Apr 6 2018
Vault uses FUSE, no block-level for the time being. I was toying with Tomb and preallocated fixed-size containers in the filsystem which uses Luks in the back, but I'm not sure it can be made to work properly.
Vault does not support public-private key encryption - it is out of the project's scope. And it would be quite strange for the user to see items like "KMail Index for ABCDEFGH01234... key" in the list of existing vaults. :)
Mar 28 2018
Mar 24 2018
"can't" should not be used in formal writings. Not sure how formal documentation is considered to be.
Mar 22 2018
You can also switch to 'can't' as far as I'm concerned
Mar 19 2018
Mar 11 2018
Mar 7 2018
Feb 26 2018
The fix needs to be a bit more complex. We can not really rely on the user to fix the database.
Feb 21 2018
Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that calls ::instance in ResultSet :) - because of this, I'm changing to 'Request Changes').
Feb 20 2018
This is not really as simple as 'accept without a comment'.
Feb 16 2018
Feb 12 2018
Feb 10 2018
Feb 9 2018
I can not say with certainty - never tested html encoding, but I would expect it to work in general.