- User Since
- Apr 14 2015, 9:17 PM (157 w, 5 d)
Tue, Apr 10
Mon, Apr 9
Fri, Apr 6
Vault uses FUSE, no block-level for the time being. I was toying with Tomb and preallocated fixed-size containers in the filsystem which uses Luks in the back, but I'm not sure it can be made to work properly.
Vault does not support public-private key encryption - it is out of the project's scope. And it would be quite strange for the user to see items like "KMail Index for ABCDEFGH01234... key" in the list of existing vaults. :)
Wed, Mar 28
Sat, Mar 24
"can't" should not be used in formal writings. Not sure how formal documentation is considered to be.
Mar 22 2018
You can also switch to 'can't' as far as I'm concerned
Mar 19 2018
Mar 11 2018
Mar 7 2018
Feb 26 2018
The fix needs to be a bit more complex. We can not really rely on the user to fix the database.
Feb 21 2018
Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that calls ::instance in ResultSet :) - because of this, I'm changing to 'Request Changes').
Feb 20 2018
This is not really as simple as 'accept without a comment'.
Feb 16 2018
Feb 12 2018
Feb 10 2018
Feb 9 2018
I can not say with certainty - never tested html encoding, but I would expect it to work in general.
Feb 8 2018
Feb 6 2018
Maybe hardcoding is a good idea, I have nothing against that. Though, I'm not sure hardcoding to 6 is the best one - I'm torn between that one and the next :)
Noise is often used to break the gradient visual artifacts that appear due to screens' inability to show colors precisely. You often get the impression there are lines orthogonal to the gradient direction which ruins the gradient.
Jan 29 2018
Jan 28 2018
Jan 21 2018
Jan 10 2018
Dec 9 2017
I've pushed this patch with a few changes (don't want to wait the last moment before the string freeze).
Dec 7 2017
Hi @abetts , we need a nice dialogue that shows the password entry for unlocking a vault. You have the current proposal screenshot above.
Dec 5 2017
Since VDG has not responded. Can you remove the padding and make the name bold?
Dec 1 2017
Why don't you set up the preferred size for the dialogue, and allow the label to be multi-line?
Nov 30 2017
@ngraham I can not reproduce the text overflow bud you are getting. I'm not setting any size-related things, so the bug is probably in the upstream (libplasma or above)
- Reverted the 'create a new vault button' to be a proper button
Nov 29 2017
Almost mergeable - I just have a few nit-picks:
I was on a vacation, sorry. I'll test everything today and merge it if I don't find a problem.
Nov 17 2017
The activities cache is a private class meant to communicate directly to KAMD. The signals it contains are in the form (activity id, something) and are meant to be private. The KActivities::Info class was meant to wrap these signals into a nice OO API where an activity object (Info) sends signals that a particular property has changed.
Nov 3 2017
While I like the idea behind the patch, I'd rather have what David proposed. Namely, d_ptr is a smart pointer, but I don't think it should be this smart - creating specializations for different types' destructors should not really be a part of it.
Oct 29 2017
Also, not sure adding a signal that has one user only to a shared library is the best approach, especially since .h says this:
Oct 25 2017
This one is almost mergeable.
I was not clear enough probably - I meant that "Have a default backend" does not warrant a change to the UI. Especially when it makes the UI more complex.
Oct 24 2017
Do I need to relogin to make a kded module show up?
Having a default backend (IMO) has nothing to do with the UI. What is the rationale behind changing a combo-box (a widget designed for multiple choice questions) to a button?
Oct 23 2017
Oct 11 2017
Somehow I didn't submit the comment when I wrote it. See above.
Sep 28 2017
Sep 23 2017
Sep 8 2017
Increasing the result limit
Removed model test
Sep 7 2017
p.s. This is how I restart everything:
Another one to test:
- fixed a small bug related to fav adding
- added debugging output for easier testing (when you encounter a bug, send me an email with plasma output)
Sep 5 2017
Fixing the ordering
Sep 4 2017
Post-migration sorting still feels completely random - not sure how solid that feeling is though.
Sep 2 2017
The last patch supports Kickoff, Kicker and Dash. I've tested what I can, found an small issue in KAMD (update KAMD to latest master before testing) and it looks like we are on the finish line.
Sep 1 2017
Good news: There's actually nothing to do on the favorite ids, Kicker already uses
KService::storageId as favorite id, which will be the menuId when it's available.
Aug 31 2017
This might be a hint:
Regarding Kickoff - it looks like there are some problems in its model handling:
The initial sorting of the migrated superset seems random. How is it done?
Aug 30 2017
With icons (designed after the Dolphin plugin for activity linking - to at least be consistent with something :) )
No Kickoff support: Personally I think we should actually migrate all applets at once.