ivan (Ivan Čukić)
User

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:17 PM (227 w, 2 d)
Availability
Available

Recent Activity

Today

ivan added a comment to D23372: Add operator |= for Query Terms.

You can also use set*/add* member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say set*/add* is a fine option.

Fri, Aug 23, 9:36 AM · Frameworks
ivan requested changes to D23372: Add operator |= for Query Terms.

This is something I did have initally in kastats, it was killed because while this is tempting

Fri, Aug 23, 9:07 AM · Frameworks

Yesterday

ivan accepted D22775: Allow date range filtering of resource events using Date Term.

Sorry I missed this one. If I don't react on a ping here, just send me a direct mail.

Thu, Aug 22, 4:55 PM · Frameworks

Mon, Aug 19

ivan added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Mon, Aug 19, 6:26 PM · Frameworks, Dolphin

Sat, Aug 17

ivan accepted D23112: Add a event Spy for GtkFileChooser recent files.
Sat, Aug 17, 10:26 AM · Plasma

Fri, Aug 16

ivan requested changes to D23112: Add a event Spy for GtkFileChooser recent files.

Another tiny change, and I think it is ready to land. Unless someone else sees other issues.

Fri, Aug 16, 9:45 PM · Plasma

Thu, Aug 15

ivan committed R161:cc2a78813fca: Set a parent for the dir watcher (authored by ivan).
Set a parent for the dir watcher
Thu, Aug 15, 12:25 PM
ivan added inline comments to D23112: Add a event Spy for GtkFileChooser recent files.
Thu, Aug 15, 8:13 AM · Plasma

Tue, Aug 13

ivan requested changes to D23112: Add a event Spy for GtkFileChooser recent files.

Thanks for geting involved this much!

Tue, Aug 13, 4:59 PM · Plasma

Sat, Jul 27

ivan accepted D22717: Add Date term to KActivities Stats to filter on resource event date.
Sat, Jul 27, 5:10 AM · Frameworks

Thu, Jul 25

ivan added a reviewer for D22143: Add proper logging using ECMQtDeclareLoggingCategory: kossebau.
Thu, Jul 25, 5:21 PM · Frameworks
ivan added a comment to D22143: Add proper logging using ECMQtDeclareLoggingCategory.

If @kossebau is satisfied, go for it

Thu, Jul 25, 5:21 PM · Frameworks
ivan added inline comments to D22717: Add Date term to KActivities Stats to filter on resource event date.
Thu, Jul 25, 5:20 PM · Frameworks

Wed, Jul 24

ivan requested changes to D22717: Add Date term to KActivities Stats to filter on resource event date.

Joining with ResourceEvent is a problem. At least make it not get joined if the date filter is not present.

Wed, Jul 24, 8:02 PM · Frameworks

Jul 24 2019

ivan requested changes to D22144: Add kio recentlyused:/ to access KActivityStats data.
Jul 24 2019, 9:55 AM · Frameworks, Dolphin

Jul 11 2019

ivan requested changes to D22381: Add previous-/nextActivity methods.

Inserting/Removing/Updating a sorted list does not need to resort every time - removing is easy, adding a new item is std::lower_bound (a binary search), and updating is a combination of the two.

Jul 11 2019, 12:14 PM · Plasma

Jul 10 2019

ivan added a comment to D22381: Add previous-/nextActivity methods.

You are right, they are randomized.

Jul 10 2019, 9:33 PM · Plasma
ivan requested changes to D22381: Add previous-/nextActivity methods.
Jul 10 2019, 4:14 PM · Plasma

Jun 26 2019

ivan added a comment to D22082: WIP Add an ioslave to access KActivityStat data.

I think it would be better to put it into kio-extras - activities kio is also there.

Jun 26 2019, 3:15 PM · Frameworks
ivan added a comment to D22082: WIP Add an ioslave to access KActivityStat data.

I'd add support for HighScoredFirst and RecentlyCreatedFirst. Maybe the protocol could be something like "used:/" or something.

Jun 26 2019, 6:45 AM · Frameworks
ivan accepted D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII.
Jun 26 2019, 6:42 AM · Frameworks

May 1 2019

ivan added a comment to D20938: Add Mounts Backend.

WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself.

May 1 2019, 8:28 PM · Frameworks
ivan added a comment to D20938: Add Mounts Backend.

I guess that is the main point of this patch. I don't think that anyone is against that. :)

May 1 2019, 6:30 PM · Frameworks
ivan added a comment to D20938: Add Mounts Backend.

I'm torn between two approaches:

May 1 2019, 6:07 PM · Frameworks
ivan added a comment to D20938: Add Mounts Backend.

Thanks for working on this.

May 1 2019, 4:57 PM · Frameworks

Apr 4 2019

ivan committed R845:9551fc218b95: Mark the source directory as busy while Vault is mounted (authored by ivan).
Mark the source directory as busy while Vault is mounted
Apr 4 2019, 8:39 AM
ivan committed R845:a13da523f08c: Added support for vanishing vaults (authored by ivan).
Added support for vanishing vaults
Apr 4 2019, 7:10 AM

Apr 2 2019

ivan committed R845:1a3726060cb5: Restore network only if needed (authored by ivan).
Restore network only if needed
Apr 2 2019, 10:21 AM

Mar 24 2019

ivan committed R241:7fd8b32f49f0: Fixed a typo (authored by ivan).
Fixed a typo
Mar 24 2019, 3:52 PM
ivan committed R241:bc42a1b2f913: Don't create thumbnails for encrypted Vaults (authored by ivan).
Don't create thumbnails for encrypted Vaults
Mar 24 2019, 2:16 PM
ivan closed D19979: Don't create thumbnails for encrypted Vaults.
Mar 24 2019, 2:16 PM · Frameworks
ivan updated the diff for D19979: Don't create thumbnails for encrypted Vaults.
Mar 24 2019, 1:29 PM · Frameworks
ivan added inline comments to D19979: Don't create thumbnails for encrypted Vaults.
Mar 24 2019, 1:28 PM · Frameworks
ivan removed a project from T7050: Privacy Software: KDE Privacy Goal.
Mar 24 2019, 12:50 PM · Goal settings 2017

Mar 23 2019

ivan committed R845:dc21669bba03: Never use non-resolved paths for mounts and devices (authored by ivan).
Never use non-resolved paths for mounts and devices
Mar 23 2019, 5:46 PM
ivan accepted D19997: Change http URLs to https.

Accepted, but incomplete ;)

Mar 23 2019, 2:07 PM · Plasma
ivan committed R845:a8210056def2: FileItem plugin for opening and closing Vaults from Dolphin (authored by ivan).
FileItem plugin for opening and closing Vaults from Dolphin
Mar 23 2019, 1:14 PM
ivan closed D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 1:14 PM · Plasma
ivan updated the diff for D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 1:09 PM · Plasma
ivan updated the diff for D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 1:06 PM · Plasma
ivan requested review of D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 12:00 PM · Plasma
ivan committed R845:4574e80916ae: Add a notification when mount failed because of a non empty mount point (authored by ivan).
Add a notification when mount failed because of a non empty mount point
Mar 23 2019, 10:44 AM
ivan committed R845:54a7b6cba169: Go offline as soon as the password prompt is shown (authored by ivan).
Go offline as soon as the password prompt is shown
Mar 23 2019, 10:13 AM

Mar 22 2019

ivan accepted D19986: Install .desktop file for kded5.
Mar 22 2019, 11:03 PM · Frameworks
ivan committed R845:fd3d8064222d: Sort vaults in the applet by name (authored by ivan).
Sort vaults in the applet by name
Mar 22 2019, 10:43 PM
ivan updated the summary of D19979: Don't create thumbnails for encrypted Vaults.
Mar 22 2019, 10:19 PM · Frameworks
ivan retitled D19979: Don't create thumbnails for encrypted Vaults from Don't create thumbnails for encrypted drives (Vaults) to Don't create thumbnails for encrypted Vaults.
Mar 22 2019, 10:17 PM · Frameworks
ivan updated the diff for D19979: Don't create thumbnails for encrypted Vaults.

Incorporated David's advice

Mar 22 2019, 9:57 PM · Frameworks
ivan requested review of D19979: Don't create thumbnails for encrypted Vaults.
Mar 22 2019, 9:27 PM · Frameworks
ivan committed R845:b099ea3d2be4: Do not load the payload from the first page when opening the wizard (authored by ivan).
Do not load the payload from the first page when opening the wizard
Mar 22 2019, 5:45 PM
ivan committed R845:1ba5dccb0bcc: Disable the dialog while creating the vault (authored by ivan).
Disable the dialog while creating the vault
Mar 22 2019, 4:58 PM

Feb 6 2019

ivan committed R119:019467e53bb9: Revert "[Activities KCM] vertically center the buttons" (authored by ivan).
Revert "[Activities KCM] vertically center the buttons"
Feb 6 2019, 8:09 PM
ivan committed R119:a8da90e21945: [Activities KCM] Properly vertically center the buttons (authored by ivan).
[Activities KCM] Properly vertically center the buttons
Feb 6 2019, 8:09 PM
ivan added a reverting change for R119:9cdfe25910cb: [Activities KCM] vertically center the buttons: R119:019467e53bb9: Revert "[Activities KCM] vertically center the buttons".
Feb 6 2019, 8:09 PM
ivan committed R119:a1ab33acec1c: Revert "[Activities KCM] vertically center the buttons" (authored by ivan).
Revert "[Activities KCM] vertically center the buttons"
Feb 6 2019, 8:07 PM
ivan committed R119:72a63ba0783b: [Activities KCM] Properly vertically center the buttons (authored by ivan).
[Activities KCM] Properly vertically center the buttons
Feb 6 2019, 8:07 PM
ivan added a reverting change for R119:9cdfe25910cb: [Activities KCM] vertically center the buttons: R119:a1ab33acec1c: Revert "[Activities KCM] vertically center the buttons".
Feb 6 2019, 8:07 PM
ivan committed R119:ae3ddf82dd95: Revert "[Activities KCM] vertically center the buttons" (authored by ivan).
Revert "[Activities KCM] vertically center the buttons"
Feb 6 2019, 7:19 PM
ivan committed R119:ccc6e24f9aab: [Activities KCM] Properly vertically center the buttons (authored by ivan).
[Activities KCM] Properly vertically center the buttons
Feb 6 2019, 7:19 PM
ivan added a reverting change for R119:9cdfe25910cb: [Activities KCM] vertically center the buttons: R119:ae3ddf82dd95: Revert "[Activities KCM] vertically center the buttons".
Feb 6 2019, 7:19 PM

Feb 3 2019

ivan committed R610:432b2f096285: Started porting runners from old Blade implementation (authored by ivan).
Started porting runners from old Blade implementation
Feb 3 2019, 5:35 PM

Jan 5 2019

ivan committed R120:394315e24e85: Merge branch 'Plasma/5.8' (authored by ivan).
Merge branch 'Plasma/5.8'
Jan 5 2019, 4:09 PM

Jan 4 2019

ivan committed R610:95a508db14ee: Reverted deleting delayed transformation helper functions (authored by ivan).
Reverted deleting delayed transformation helper functions
Jan 4 2019, 12:37 PM
ivan committed R610:a0c26eecb8de: Files reorganization (authored by ivan).
Files reorganization
Jan 4 2019, 12:37 PM
ivan committed R610:26d836ce2b82: Utility functions for easier function object creation (authored by ivan).
Utility functions for easier function object creation
Jan 4 2019, 11:41 AM
ivan committed R610:e50aa1275979: Added debouncing transformation (authored by ivan).
Added debouncing transformation
Jan 4 2019, 11:41 AM

Jan 3 2019

ivan committed R610:04f8f48201ec: Small refactor (authored by ivan).
Small refactor
Jan 3 2019, 10:44 PM
ivan committed R610:aa18226f0d2c: Basic serialization and deserialization implementation (authored by ivan).
Basic serialization and deserialization implementation
Jan 3 2019, 9:22 PM
ivan committed R610:89dc1c96e933: Added qmlc to gitignore (authored by ivan).
Added qmlc to gitignore
Jan 3 2019, 9:22 PM
ivan committed R610:fadf41043f6f: Basic support for Qt signal-slot pipelines (authored by ivan).
Basic support for Qt signal-slot pipelines
Jan 3 2019, 4:41 PM

Dec 31 2018

ivan committed R610:c1c1ebdf342b: Use QByteArray when unicode is not needed (authored by ivan).
Use QByteArray when unicode is not needed
Dec 31 2018, 4:42 PM
ivan committed R610:3d0006fc9811: Basic structure for Blade message passing (authored by ivan).
Basic structure for Blade message passing
Dec 31 2018, 10:27 AM

Dec 18 2018

ivan accepted D17664: fix for macOS.
Dec 18 2018, 10:11 PM · Frameworks

Dec 4 2018

ivan accepted D17359: Fix use of QRegularExpressionMatch.
Dec 4 2018, 7:45 PM · Plasma

Dec 2 2018

ivan triaged T10145: Port Vault to Voy as Normal priority.
Dec 2 2018, 10:15 AM · Voy
ivan set the image for Voy to F6450876: profile.
Dec 2 2018, 10:01 AM

Nov 21 2018

ivan accepted D17039: ASAN: Fix leak in KAStatsFavoritesModel.

Ok, +2 from me then

Nov 21 2018, 6:18 PM · Plasma
ivan added a comment to D17039: ASAN: Fix leak in KAStatsFavoritesModel.

Using a shared pointer seems like a pessimization. Could this be done with std::unique_ptr?

Nov 21 2018, 5:15 PM · Plasma

Oct 26 2018

ivan added a comment to T7050: Privacy Software.

I'll be serving as the goal keeper for the next period.

Oct 26 2018, 4:36 PM · Goal settings 2017
ivan claimed T7050: Privacy Software.
Oct 26 2018, 4:31 PM · Goal settings 2017

Oct 16 2018

ivan requested changes to D16257: Use correct wording, since it is an action word(not a noun).

It is (also) a noun, though MW spells it as "pop-up" [1]

Oct 16 2018, 6:07 PM · Plasma
ivan added a comment to D16250: Use lambdas instead of std::bind().

Lambdas are generally faster to compile and execute. std::bind can make code less verbose, but that is not the case here (I'd say that lambdas win on succinctness here).

Oct 16 2018, 2:26 PM · Frameworks
ivan added a comment to D16250: Use lambdas instead of std::bind().

The parentheses are not necessary when a lambda has no arguments.

Oct 16 2018, 2:18 PM · Frameworks

Oct 13 2018

ivan added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Different search bars are on different levels of usefulness.

Oct 13 2018, 5:35 PM · Plasma

Oct 10 2018

ivan requested changes to D16087: RFC: Store full URL as URI.

Not sure what the implications are for this change, it does fix Dolphin showing folders in its

Oct 10 2018, 3:20 PM · Plasma

Oct 8 2018

ivan committed R302:e0006451d5b0: Fixing a copy-paste error (authored by ivan).
Fixing a copy-paste error
Oct 8 2018, 9:15 PM

Aug 15 2018

ivan accepted D14843: [Activities Linking] Don't offer for non-local URLs.

Ok, though a better approach IMO would be to fix linking the non-local URLs :)

Aug 15 2018, 2:22 PM

Aug 7 2018

ivan committed R161:23d2d2f5191c: Enabled the global shortcuts plugin by default (authored by ivan).
Enabled the global shortcuts plugin by default
Aug 7 2018, 7:53 AM

Jul 27 2018

ivan committed R845:18db0b79dff5: Refactored the wizard logic (authored by ivan).
Refactored the wizard logic
Jul 27 2018, 5:18 PM

Jul 26 2018

ivan committed R845:7ee10da0d628: Remove the trailing slashes from the mount point (authored by ivan).
Remove the trailing slashes from the mount point
Jul 26 2018, 9:47 AM
ivan committed R845:bdf111ba714c: Showing error messages for badly chosen paths (authored by ivan).
Showing error messages for badly chosen paths
Jul 26 2018, 9:25 AM
ivan committed R845:42ad78f25801: Importing existing encrypted directories added to the backend (authored by ivan).
Importing existing encrypted directories added to the backend
Jul 26 2018, 8:16 AM
ivan committed R845:b32b0e71146d: Postpone deleting vaults while there are async operations on them (authored by ivan).
Postpone deleting vaults while there are async operations on them
Jul 26 2018, 8:16 AM
ivan committed R845:b8411a5c9f82: Better design for the directory chooser (authored by ivan).
Better design for the directory chooser
Jul 26 2018, 8:16 AM

Jul 23 2018

ivan committed R845:108d408dac3c: Allowing custom options to be passed to encfs and cryfs (authored by ivan).
Allowing custom options to be passed to encfs and cryfs
Jul 23 2018, 8:27 AM

Jul 8 2018

ivan accepted D13980: Honor BUILD_TESTING.
Jul 8 2018, 10:05 PM · Frameworks

Jun 12 2018

ivan accepted D13255: Make dependency on KF5NetworkManagerQt optional.

Thanks!

Jun 12 2018, 5:10 AM · Plasma

Jun 9 2018

ivan added a comment to D13255: Make dependency on KF5NetworkManagerQt optional.

Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.

Jun 9 2018, 8:02 PM · Plasma

Jun 1 2018

ivan requested changes to D13255: Make dependency on KF5NetworkManagerQt optional.
  • Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
  • Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
  • What about the configuration UI?
Jun 1 2018, 6:28 PM · Plasma

May 26 2018

ivan committed R224:6dbfe9cd2433: Qt Network is used by the KIO module (authored by ivan).
Qt Network is used by the KIO module
May 26 2018, 9:13 PM