ivan (Ivan Čukić)
User

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:17 PM (191 w, 5 d)
Availability
Available

Recent Activity

Tue, Dec 4

ivan accepted D17359: Fix use of QRegularExpressionMatch.
Tue, Dec 4, 7:45 PM · Plasma

Sun, Dec 2

ivan triaged T10145: Port Vault to Voy as Normal priority.
Sun, Dec 2, 10:15 AM · Voy
ivan set the image for Voy to F6450876: profile.
Sun, Dec 2, 10:01 AM

Wed, Nov 21

ivan accepted D17039: ASAN: Fix leak in KAStatsFavoritesModel.

Ok, +2 from me then

Wed, Nov 21, 6:18 PM · Plasma
ivan added a comment to D17039: ASAN: Fix leak in KAStatsFavoritesModel.

Using a shared pointer seems like a pessimization. Could this be done with std::unique_ptr?

Wed, Nov 21, 5:15 PM · Plasma

Oct 26 2018

ivan added a comment to T7050: Privacy Software.

I'll be serving as the goal keeper for the next period.

Oct 26 2018, 4:36 PM · Goal settings 2017
ivan claimed T7050: Privacy Software.
Oct 26 2018, 4:31 PM · Goal settings 2017

Oct 16 2018

ivan requested changes to D16257: Use correct wording, since it is an action word(not a noun).

It is (also) a noun, though MW spells it as "pop-up" [1]

Oct 16 2018, 6:07 PM · Plasma
ivan added a comment to D16250: Use lambdas instead of std::bind().

Lambdas are generally faster to compile and execute. std::bind can make code less verbose, but that is not the case here (I'd say that lambdas win on succinctness here).

Oct 16 2018, 2:26 PM · Frameworks
ivan added a comment to D16250: Use lambdas instead of std::bind().

The parentheses are not necessary when a lambda has no arguments.

Oct 16 2018, 2:18 PM · Frameworks

Oct 13 2018

ivan added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Different search bars are on different levels of usefulness.

Oct 13 2018, 5:35 PM · Plasma

Oct 10 2018

ivan requested changes to D16087: RFC: Store full URL as URI.

Not sure what the implications are for this change, it does fix Dolphin showing folders in its

Oct 10 2018, 3:20 PM · Plasma

Oct 8 2018

ivan committed R302:e0006451d5b0: Fixing a copy-paste error (authored by ivan).
Fixing a copy-paste error
Oct 8 2018, 9:15 PM

Aug 15 2018

ivan accepted D14843: [Activities Linking] Don't offer for non-local URLs.

Ok, though a better approach IMO would be to fix linking the non-local URLs :)

Aug 15 2018, 2:22 PM

Aug 7 2018

ivan committed R161:23d2d2f5191c: Enabled the global shortcuts plugin by default (authored by ivan).
Enabled the global shortcuts plugin by default
Aug 7 2018, 7:53 AM

Jul 27 2018

ivan committed R845:18db0b79dff5: Refactored the wizard logic (authored by ivan).
Refactored the wizard logic
Jul 27 2018, 5:18 PM

Jul 26 2018

ivan committed R845:7ee10da0d628: Remove the trailing slashes from the mount point (authored by ivan).
Remove the trailing slashes from the mount point
Jul 26 2018, 9:47 AM
ivan committed R845:bdf111ba714c: Showing error messages for badly chosen paths (authored by ivan).
Showing error messages for badly chosen paths
Jul 26 2018, 9:25 AM
ivan committed R845:42ad78f25801: Importing existing encrypted directories added to the backend (authored by ivan).
Importing existing encrypted directories added to the backend
Jul 26 2018, 8:16 AM
ivan committed R845:b32b0e71146d: Postpone deleting vaults while there are async operations on them (authored by ivan).
Postpone deleting vaults while there are async operations on them
Jul 26 2018, 8:16 AM
ivan committed R845:b8411a5c9f82: Better design for the directory chooser (authored by ivan).
Better design for the directory chooser
Jul 26 2018, 8:16 AM

Jul 23 2018

ivan committed R845:108d408dac3c: Allowing custom options to be passed to encfs and cryfs (authored by ivan).
Allowing custom options to be passed to encfs and cryfs
Jul 23 2018, 8:27 AM

Jul 8 2018

ivan accepted D13980: Honor BUILD_TESTING.
Jul 8 2018, 10:05 PM · Frameworks

Jun 12 2018

ivan accepted D13255: Make dependency on KF5NetworkManagerQt optional.

Thanks!

Jun 12 2018, 5:10 AM · Plasma

Jun 9 2018

ivan added a comment to D13255: Make dependency on KF5NetworkManagerQt optional.

Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.

Jun 9 2018, 8:02 PM · Plasma

Jun 1 2018

ivan requested changes to D13255: Make dependency on KF5NetworkManagerQt optional.
  • Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
  • Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
  • What about the configuration UI?
Jun 1 2018, 6:28 PM · Plasma

May 26 2018

ivan committed R224:6dbfe9cd2433: Qt Network is used by the KIO module (authored by ivan).
Qt Network is used by the KIO module
May 26 2018, 9:13 PM
ivan closed D11251: Qt Network is used by the KIO module.
May 26 2018, 9:13 PM · KDE Connect
ivan committed R224:f7a5c3220ba9: Added a few useful 'Sample commands' for the Run Command plugin (authored by ivan).
Added a few useful 'Sample commands' for the Run Command plugin
May 26 2018, 9:06 PM
ivan closed D13136: Added a few useful 'Sample commands' for the Run Command plugin.
May 26 2018, 9:06 PM · KDE Connect
ivan added a comment to D13136: Added a few useful 'Sample commands' for the Run Command plugin.

Was more aimed at @nicolasfella :)

May 26 2018, 8:58 PM · KDE Connect
ivan added a comment to D13136: Added a few useful 'Sample commands' for the Run Command plugin.

So... accepted? :)

May 26 2018, 8:56 PM · KDE Connect
ivan added a comment to D13136: Added a few useful 'Sample commands' for the Run Command plugin.

Thanks for the suggestion!

May 26 2018, 6:31 PM · KDE Connect
ivan updated the diff for D13136: Added a few useful 'Sample commands' for the Run Command plugin.

Using loginctl for session locking as well

May 26 2018, 6:31 PM · KDE Connect
ivan added reviewers for D13136: Added a few useful 'Sample commands' for the Run Command plugin: nicolasfella, KDE Connect.
May 26 2018, 4:29 PM · KDE Connect
ivan added reviewers for D11251: Qt Network is used by the KIO module: KDE Connect, nicolasfella.
May 26 2018, 4:29 PM · KDE Connect
Restricted Application added a project to D11251: Qt Network is used by the KIO module: KDE Connect.
May 26 2018, 4:28 PM · KDE Connect
ivan requested review of D13136: Added a few useful 'Sample commands' for the Run Command plugin.
May 26 2018, 4:27 PM · KDE Connect
ivan accepted D13042: Do not show activity switcher during fast switches.

Looks ok to me.

May 26 2018, 8:39 AM · Plasma

May 21 2018

ivan committed R610:eae4638b75e6: Moved the tests to a separate directory (authored by ivan).
Moved the tests to a separate directory
May 21 2018, 9:10 PM
ivan committed R610:c3c75d10e7e6: Merge branch 'master' of git://anongit.kde.org/lancelot (authored by ivan).
Merge branch 'master' of git://anongit.kde.org/lancelot
May 21 2018, 9:10 PM
ivan committed R610:8e1e59b0ee55: Created bridges with multiple destination/source instances (authored by ivan).
Created bridges with multiple destination/source instances
May 21 2018, 9:10 PM
ivan committed R610:e964e0da315b: Converted the test to a three-process pipeline (authored by ivan).
Converted the test to a three-process pipeline
May 21 2018, 9:10 PM

May 19 2018

ivan accepted D12952: [activity plugin] Use the imperative mood to match all other Dolphin plugins.
May 19 2018, 7:18 AM

May 17 2018

ivan added a comment to D12894: Rename KActivities linking plugin.

The second one sounds ok

May 17 2018, 9:20 AM

May 16 2018

ivan committed R610:d074074b197e: Converted the test to a three-process pipeline (authored by ivan).
Converted the test to a three-process pipeline
May 16 2018, 9:17 PM
ivan committed R610:1b6fa06d2a26: Changed the multiprocess example (authored by ivan).
Changed the multiprocess example
May 16 2018, 9:17 PM
ivan added a comment to D12894: Rename KActivities linking plugin.

The problem with the original wording is mainly in using singular. It is for linking files to activities. I'm open to suggestions.

May 16 2018, 6:27 PM
ivan accepted D12894: Rename KActivities linking plugin.
May 16 2018, 11:33 AM

May 15 2018

ivan requested changes to D12894: Rename KActivities linking plugin.

Maybe "Linking files to activities" would be better?

May 15 2018, 11:19 PM
ivan committed R610:06e10717670a: Added readme to explain how to clone the 3rdparty libraries (authored by ivan).
Added readme to explain how to clone the 3rdparty libraries
May 15 2018, 11:04 PM
ivan committed R610:e6a27fe612b3: Multiprocess bridge that uses ZMQ for transport (authored by ivan).
Multiprocess bridge that uses ZMQ for transport
May 15 2018, 10:58 PM
ivan committed R610:9d9377c0538a: Generate multiple targets -- one for each test (authored by ivan).
Generate multiple targets -- one for each test
May 15 2018, 10:58 PM
ivan committed R610:d887f1731bc9: Initial implementation of ZMQ publisher and subscriber (authored by ivan).
Initial implementation of ZMQ publisher and subscriber
May 15 2018, 10:58 PM

May 13 2018

ivan committed R610:c23d8f01cd90: Added a TCP server for stream testing purposes (authored by ivan).
Added a TCP server for stream testing purposes
May 13 2018, 7:41 PM

May 9 2018

ivan committed R610:06e440650480: Merging the source streams operation implemented (authored by ivan).
Merging the source streams operation implemented
May 9 2018, 5:29 AM
ivan committed R610:5f1598760322: Implemented the slice operation (authored by ivan).
Implemented the slice operation
May 9 2018, 5:29 AM
ivan committed R610:2ee401546ca7: Transform and filter operations on streams (authored by ivan).
Transform and filter operations on streams
May 9 2018, 5:29 AM
ivan committed R610:97a18563690f: Created a source stream which emits values after a predefined delay (authored by ivan).
Created a source stream which emits values after a predefined delay
May 9 2018, 5:29 AM
ivan committed R610:9d7c2864d58a: Implemented the process source (authored by ivan).
Implemented the process source
May 9 2018, 5:29 AM
ivan committed R610:5234e4ddbb4d: Added boost.asio service to handle the event loop (authored by ivan).
Added boost.asio service to handle the event loop
May 9 2018, 5:29 AM
ivan committed R610:7ae04b2c86fb: Implemented the DSL graph evaluation (authored by ivan).
Implemented the DSL graph evaluation
May 9 2018, 5:29 AM
ivan committed R610:7ae4545dbf86: Function that connects a list of nodes into a pipeline (authored by ivan).
Function that connects a list of nodes into a pipeline
May 9 2018, 5:29 AM
ivan committed R610:e1b8daa871b7: Implemented the sink node (authored by ivan).
Implemented the sink node
May 9 2018, 5:29 AM
ivan committed R610:24864d62928b: Initial form for the DSL nodes (authored by ivan).
Initial form for the DSL nodes
May 9 2018, 5:28 AM
ivan committed R610:5b3d824d0656: Initial commit to start off the reactive streams development (authored by ivan).
Initial commit to start off the reactive streams development
May 9 2018, 5:28 AM

May 2 2018

ivan accepted D12656: Use category logging.
May 2 2018, 9:28 AM · Plasma

May 1 2018

ivan added a comment to D12577: Allowing KAMD to run without a database backend.

I pushed it by accident, and I didn't want to revert just to push it to the phab again. Though, I did count that you'll check it out in the end even if it is already merged :)

May 1 2018, 5:37 PM · Plasma

Apr 29 2018

ivan committed R161:66c8f9ae86e3: Allowing KAMD to run without a database backend (authored by ivan).
Allowing KAMD to run without a database backend
Apr 29 2018, 1:21 PM
ivan closed D12577: Allowing KAMD to run without a database backend.
Apr 29 2018, 1:21 PM · Plasma

Apr 28 2018

ivan requested review of D12577: Allowing KAMD to run without a database backend.
Apr 28 2018, 1:06 PM · Plasma
ivan committed R161:74512fe9a50b: Removed the separate thread for resource score cache processing (authored by ivan).
Removed the separate thread for resource score cache processing
Apr 28 2018, 12:49 PM
ivan closed D12576: Removed the separate thread for resource score cache processing.
Apr 28 2018, 12:49 PM · Plasma
ivan added a comment to D12576: Removed the separate thread for resource score cache processing.

If KRunner has multiple threads accessing the same sqlite database, then yes.

Apr 28 2018, 11:43 AM · Plasma
ivan requested review of D12576: Removed the separate thread for resource score cache processing.
Apr 28 2018, 11:08 AM · Plasma

Apr 26 2018

ivan committed R845:d2b6443fa6e3: Updated the CryFS backend to use 0.9.9 (authored by ivan).
Updated the CryFS backend to use 0.9.9
Apr 26 2018, 6:55 PM

Apr 10 2018

ivan committed R845:efafd9dd5205: Making the error message when opening the vault more prominent (authored by ivan).
Making the error message when opening the vault more prominent
Apr 10 2018, 9:41 PM
ivan committed R845:eadb8c0689fd: Added vault deletion through the configuration dialogue (authored by ivan).
Added vault deletion through the configuration dialogue
Apr 10 2018, 9:23 PM
ivan committed R845:db2986a2817c: Added d-bus functions to close all open vaults (authored by ivan).
Added d-bus functions to close all open vaults
Apr 10 2018, 5:24 PM

Apr 9 2018

ivan committed R845:51a6a567d7a1: Fixed issues when closing multiple offline Vaults (authored by ivan).
Fixed issues when closing multiple offline Vaults
Apr 9 2018, 5:44 PM

Apr 6 2018

ivan added a comment to T8447: Indexing encrypted mails.

Vault uses FUSE, no block-level for the time being. I was toying with Tomb and preallocated fixed-size containers in the filsystem which uses Luks in the back, but I'm not sure it can be made to work properly.

Apr 6 2018, 12:50 PM · KDE PIM, Goal settings 2017
ivan added a comment to T8447: Indexing encrypted mails.

Vault does not support public-private key encryption - it is out of the project's scope. And it would be quite strange for the user to see items like "KMail Index for ABCDEFGH01234... key" in the list of existing vaults. :)

Apr 6 2018, 9:01 AM · KDE PIM, Goal settings 2017

Mar 28 2018

ivan committed R6:6febc3c64ae2: Removed extraneous return (authored by ivan).
Removed extraneous return
Mar 28 2018, 1:49 PM

Mar 24 2018

ivan added a comment to D11561: fix typos in UI strings.

"can't" should not be used in formal writings. Not sure how formal documentation is considered to be.

Mar 24 2018, 6:45 PM · Plasma

Mar 22 2018

ivan accepted D11561: fix typos in UI strings.

You can also switch to 'can't' as far as I'm concerned

Mar 22 2018, 5:41 PM · Plasma

Mar 19 2018

ivan committed R124:4f1f9b9f7ad9: Make the item heights rounded to avoid font rendering issues (authored by ivan).
Make the item heights rounded to avoid font rendering issues
Mar 19 2018, 10:14 PM
ivan closed D11502: Make the item heights rounded to avoid font rendering issues.
Mar 19 2018, 10:14 PM · Plasma
ivan requested review of D11502: Make the item heights rounded to avoid font rendering issues.
Mar 19 2018, 9:36 PM · Plasma
ivan accepted D11482: Export Translations to right filename.
Mar 19 2018, 6:05 PM · Plasma

Mar 11 2018

ivan requested review of D11251: Qt Network is used by the KIO module.
Mar 11 2018, 9:42 PM · KDE Connect

Mar 7 2018

ivan committed R159:9b47babb6c41: Do not assume SQLite works and do not terminate on errors (authored by ivan).
Do not assume SQLite works and do not terminate on errors
Mar 7 2018, 10:19 PM

Feb 26 2018

ivan added a comment to D10691: [kactivities-stats] Fix plasmashell crash when database is broken.

The fix needs to be a bit more complex. We can not really rely on the user to fix the database.

Feb 26 2018, 9:10 AM · Plasma, Frameworks

Feb 21 2018

ivan requested changes to D10691: [kactivities-stats] Fix plasmashell crash when database is broken.

Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that calls ::instance in ResultSet :) - because of this, I'm changing to 'Request Changes').

Feb 21 2018, 12:02 AM · Plasma, Frameworks

Feb 20 2018

ivan added a comment to D10691: [kactivities-stats] Fix plasmashell crash when database is broken.

This is not really as simple as 'accept without a comment'.

Feb 20 2018, 11:44 PM · Plasma, Frameworks

Feb 16 2018

ivan accepted D10388: allow to have more than one default activity.
Feb 16 2018, 9:39 AM · Plasma

Feb 12 2018

ivan added inline comments to D10388: allow to have more than one default activity.
Feb 12 2018, 4:27 PM · Plasma

Feb 10 2018

ivan committed R845:bd8117d921bc: Merge branch 'Plasma/5.12' (authored by ivan).
Merge branch 'Plasma/5.12'
Feb 10 2018, 9:08 AM
ivan committed R845:45ad41edad0d: Set icons for the Vault creation, configuration and mounting dialogues (authored by ivan).
Set icons for the Vault creation, configuration and mounting dialogues
Feb 10 2018, 9:07 AM

Feb 9 2018

ivan added a comment to D10383: Fix pinning apps when their .desktop file has a space in the file name..

I can not say with certainty - never tested html encoding, but I would expect it to work in general.

Feb 9 2018, 4:31 PM · Plasma

Feb 8 2018

ivan added inline comments to D10388: allow to have more than one default activity.
Feb 8 2018, 7:11 PM · Plasma