ivan (Ivan Čukić)
User

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:17 PM (235 w, 6 d)
Availability
Available

Recent Activity

Thu, Oct 17

ivan accepted D24741: Add a utility accessor to get a QUrl from a ResultSet::Result.

Just add TODO and you are free to push

Thu, Oct 17, 7:01 PM · Frameworks
ivan requested changes to D24741: Add a utility accessor to get a QUrl from a ResultSet::Result.
Thu, Oct 17, 5:56 PM · Frameworks
ivan added inline comments to D22005: Ensure url from KActivity resources are properly built.
Thu, Oct 17, 5:51 PM · Plasma

Thu, Oct 3

ivan accepted D22381: Add previous-/nextActivity methods.
Thu, Oct 3, 7:23 PM · Plasma
ivan added a comment to D22382: Add global shortcuts for switching to the previous/next activity.

I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is.

Thu, Oct 3, 5:44 PM · Plasma
ivan added inline comments to D22381: Add previous-/nextActivity methods.
Thu, Oct 3, 5:40 PM · Plasma

Sep 16 2019

ivan committed R120:c311339e14b3: Per-activity favorites (Final, again?) (authored by ivan).
Per-activity favorites (Final, again?)
Sep 16 2019, 12:16 PM
ivan committed R120:4728456ff837: Adding an option to show popular documents/apps for Kickoff (authored by ivan).
Adding an option to show popular documents/apps for Kickoff
Sep 16 2019, 12:16 PM
ivan committed R120:41798999b413: Adding an option to show popular documents/apps for Kicker and Dash (authored by ivan).
Adding an option to show popular documents/apps for Kicker and Dash
Sep 16 2019, 12:16 PM
ivan committed R120:a4226604b7ff: Removing the copy of KAStats from the plasma-desktop (authored by ivan).
Removing the copy of KAStats from the plasma-desktop
Sep 16 2019, 12:16 PM
ivan committed R120:2bc3c808b0ba: Kickoff thought that its source model is KAStats::ResultModel. It was mistaken. (authored by ivan).
Kickoff thought that its source model is KAStats::ResultModel. It was mistaken.
Sep 16 2019, 12:15 PM
ivan committed R120:2aaacb692bc3: Kickoff thought that its source model is KAStats::ResultModel. It was mistaken. (authored by ivan).
Kickoff thought that its source model is KAStats::ResultModel. It was mistaken.
Sep 16 2019, 12:15 PM
ivan committed R120:85df5603ddd7: Fixing the withinBounds test for Recent*Model (authored by ivan).
Fixing the withinBounds test for Recent*Model
Sep 16 2019, 12:15 PM
ivan committed R120:db1c9676ea01: Merge branch 'Plasma/5.3' (authored by ivan).
Merge branch 'Plasma/5.3'
Sep 16 2019, 12:15 PM
ivan committed R120:89e5482c75dd: Keeping ResultSet open as little as possible and fixing the count limit (authored by ivan).
Keeping ResultSet open as little as possible and fixing the count limit
Sep 16 2019, 12:15 PM
ivan committed R120:e96b3bc80048: Keeping ResultSet open as little as possible and fixing the count limit (authored by ivan).
Keeping ResultSet open as little as possible and fixing the count limit
Sep 16 2019, 12:15 PM
ivan committed R120:c55e33de87fe: Properly exporting the functions from Cleaning (authored by ivan).
Properly exporting the functions from Cleaning
Sep 16 2019, 12:15 PM
ivan committed R120:081312b4b745: Methods to forget specific resources, or all items in the model (authored by ivan).
Methods to forget specific resources, or all items in the model
Sep 16 2019, 12:15 PM
ivan committed R120:24d6a78f751d: Kicker is notifying KAMD of the recently started applications (authored by ivan).
Kicker is notifying KAMD of the recently started applications
Sep 16 2019, 12:14 PM
ivan committed R120:b4648dd10046: Adapting to cmake changes (authored by ivan).
Adapting to cmake changes
Sep 16 2019, 12:14 PM
ivan committed R120:43155244881e: Adding the url filter for showing only files (authored by ivan).
Adding the url filter for showing only files
Sep 16 2019, 12:14 PM

Sep 7 2019

ivan accepted D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.
Sep 7 2019, 9:51 PM · Frameworks, Dolphin

Sep 6 2019

ivan accepted D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.
Sep 6 2019, 7:22 AM · Frameworks

Sep 5 2019

ivan added inline comments to D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.
Sep 5 2019, 8:48 PM · Frameworks
ivan accepted D23742: Add two special cases url recentlyused:/files and recentlyused:/folders.
Sep 5 2019, 6:46 PM · Frameworks, Dolphin
ivan accepted D23737: Extract mimetype from recentlyused.xbel.
Sep 5 2019, 5:58 PM · Plasma
ivan requested changes to D23737: Extract mimetype from recentlyused.xbel.
Sep 5 2019, 3:59 PM · Plasma
ivan requested changes to D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Add the same for directories for completeness

Sep 5 2019, 3:57 PM · Frameworks

Aug 29 2019

ivan accepted D23555: Add @since 5.62 for newly added setters.
Aug 29 2019, 7:22 AM · Frameworks
ivan accepted D23556: Add version requirement to dependency KActivitiesStats.
Aug 29 2019, 7:04 AM · Frameworks, Dolphin

Aug 28 2019

ivan accepted D22144: Add kio recentlyused:/ to access KActivityStats data.

Filtering can be done as far as the KAStats is concerned. The question is how to know inside the KIO slave which application requested its services.

Aug 28 2019, 7:42 AM · Frameworks, Dolphin
ivan accepted D22143: Add proper logging using ECMQtDeclareLoggingCategory.
Aug 28 2019, 7:35 AM · Frameworks
ivan added inline comments to D22143: Add proper logging using ECMQtDeclareLoggingCategory.
Aug 28 2019, 6:25 AM · Frameworks

Aug 27 2019

ivan requested changes to D22143: Add proper logging using ECMQtDeclareLoggingCategory.

Change everything to plural.

Aug 27 2019, 6:21 PM · Frameworks

Aug 26 2019

ivan accepted D23174: Improve the look of the Activities KCM UI.
Aug 26 2019, 5:07 PM · KActivities, Plasma

Aug 24 2019

ivan accepted D23399: Add setter to Type, Activity, Agent and UrlFilter query fields.
Aug 24 2019, 5:36 PM · Frameworks
ivan added inline comments to D23399: Add setter to Type, Activity, Agent and UrlFilter query fields.
Aug 24 2019, 3:09 PM · Frameworks
ivan accepted D23393: Use special values constants in terms.cpp.
Aug 24 2019, 10:52 AM · Frameworks
ivan added inline comments to D22144: Add kio recentlyused:/ to access KActivityStats data.
Aug 24 2019, 10:49 AM · Frameworks, Dolphin
ivan added inline comments to D22144: Add kio recentlyused:/ to access KActivityStats data.
Aug 24 2019, 8:07 AM · Frameworks, Dolphin

Aug 23 2019

ivan added a comment to D23372: Add operator |= for Query Terms.

You can also use set*/add* member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say set*/add* is a fine option.

Aug 23 2019, 9:36 AM · Frameworks
ivan requested changes to D23372: Add operator |= for Query Terms.

This is something I did have initally in kastats, it was killed because while this is tempting

Aug 23 2019, 9:07 AM · Frameworks

Aug 22 2019

ivan accepted D22775: Allow date range filtering of resource events using Date Term.

Sorry I missed this one. If I don't react on a ping here, just send me a direct mail.

Aug 22 2019, 4:55 PM · Frameworks

Aug 19 2019

ivan added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Aug 19 2019, 6:26 PM · Frameworks, Dolphin

Aug 17 2019

ivan accepted D23112: Add a event Spy for GtkFileChooser recent files.
Aug 17 2019, 10:26 AM · Plasma

Aug 16 2019

ivan requested changes to D23112: Add a event Spy for GtkFileChooser recent files.

Another tiny change, and I think it is ready to land. Unless someone else sees other issues.

Aug 16 2019, 9:45 PM · Plasma

Aug 15 2019

ivan committed R161:cc2a78813fca: Set a parent for the dir watcher (authored by ivan).
Set a parent for the dir watcher
Aug 15 2019, 12:25 PM
ivan added inline comments to D23112: Add a event Spy for GtkFileChooser recent files.
Aug 15 2019, 8:13 AM · Plasma

Aug 13 2019

ivan requested changes to D23112: Add a event Spy for GtkFileChooser recent files.

Thanks for geting involved this much!

Aug 13 2019, 4:59 PM · Plasma

Jul 27 2019

ivan accepted D22717: Add Date term to KActivities Stats to filter on resource event date.
Jul 27 2019, 5:10 AM · Frameworks

Jul 25 2019

ivan added a reviewer for D22143: Add proper logging using ECMQtDeclareLoggingCategory: kossebau.
Jul 25 2019, 5:21 PM · Frameworks
ivan added a comment to D22143: Add proper logging using ECMQtDeclareLoggingCategory.

If @kossebau is satisfied, go for it

Jul 25 2019, 5:21 PM · Frameworks
ivan added inline comments to D22717: Add Date term to KActivities Stats to filter on resource event date.
Jul 25 2019, 5:20 PM · Frameworks

Jul 24 2019

ivan requested changes to D22717: Add Date term to KActivities Stats to filter on resource event date.

Joining with ResourceEvent is a problem. At least make it not get joined if the date filter is not present.

Jul 24 2019, 8:02 PM · Frameworks
ivan requested changes to D22144: Add kio recentlyused:/ to access KActivityStats data.
Jul 24 2019, 9:55 AM · Frameworks, Dolphin

Jul 11 2019

ivan requested changes to D22381: Add previous-/nextActivity methods.

Inserting/Removing/Updating a sorted list does not need to resort every time - removing is easy, adding a new item is std::lower_bound (a binary search), and updating is a combination of the two.

Jul 11 2019, 12:14 PM · Plasma

Jul 10 2019

ivan added a comment to D22381: Add previous-/nextActivity methods.

You are right, they are randomized.

Jul 10 2019, 9:33 PM · Plasma
ivan requested changes to D22381: Add previous-/nextActivity methods.
Jul 10 2019, 4:14 PM · Plasma

Jun 26 2019

ivan added a comment to D22082: WIP Add an ioslave to access KActivityStat data.

I think it would be better to put it into kio-extras - activities kio is also there.

Jun 26 2019, 3:15 PM · Frameworks
ivan added a comment to D22082: WIP Add an ioslave to access KActivityStat data.

I'd add support for HighScoredFirst and RecentlyCreatedFirst. Maybe the protocol could be something like "used:/" or something.

Jun 26 2019, 6:45 AM · Frameworks
ivan accepted D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII.
Jun 26 2019, 6:42 AM · Frameworks

May 1 2019

ivan added a comment to D20938: Add Mounts Backend.

WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself.

May 1 2019, 8:28 PM · Frameworks
ivan added a comment to D20938: Add Mounts Backend.

I guess that is the main point of this patch. I don't think that anyone is against that. :)

May 1 2019, 6:30 PM · Frameworks
ivan added a comment to D20938: Add Mounts Backend.

I'm torn between two approaches:

May 1 2019, 6:07 PM · Frameworks
ivan added a comment to D20938: Add Mounts Backend.

Thanks for working on this.

May 1 2019, 4:57 PM · Frameworks

Apr 4 2019

ivan committed R845:9551fc218b95: Mark the source directory as busy while Vault is mounted (authored by ivan).
Mark the source directory as busy while Vault is mounted
Apr 4 2019, 8:39 AM
ivan committed R845:a13da523f08c: Added support for vanishing vaults (authored by ivan).
Added support for vanishing vaults
Apr 4 2019, 7:10 AM

Apr 2 2019

ivan committed R845:1a3726060cb5: Restore network only if needed (authored by ivan).
Restore network only if needed
Apr 2 2019, 10:21 AM

Mar 24 2019

ivan committed R241:7fd8b32f49f0: Fixed a typo (authored by ivan).
Fixed a typo
Mar 24 2019, 3:52 PM
ivan committed R241:bc42a1b2f913: Don't create thumbnails for encrypted Vaults (authored by ivan).
Don't create thumbnails for encrypted Vaults
Mar 24 2019, 2:16 PM
ivan closed D19979: Don't create thumbnails for encrypted Vaults.
Mar 24 2019, 2:16 PM · Frameworks
ivan updated the diff for D19979: Don't create thumbnails for encrypted Vaults.
Mar 24 2019, 1:29 PM · Frameworks
ivan added inline comments to D19979: Don't create thumbnails for encrypted Vaults.
Mar 24 2019, 1:28 PM · Frameworks
ivan removed a project from T7050: Privacy Software: KDE Privacy Goal.
Mar 24 2019, 12:50 PM · Goal settings 2017

Mar 23 2019

ivan committed R845:dc21669bba03: Never use non-resolved paths for mounts and devices (authored by ivan).
Never use non-resolved paths for mounts and devices
Mar 23 2019, 5:46 PM
ivan accepted D19997: Change http URLs to https.

Accepted, but incomplete ;)

Mar 23 2019, 2:07 PM · Plasma
ivan committed R845:a8210056def2: FileItem plugin for opening and closing Vaults from Dolphin (authored by ivan).
FileItem plugin for opening and closing Vaults from Dolphin
Mar 23 2019, 1:14 PM
ivan closed D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 1:14 PM · Plasma
ivan updated the diff for D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 1:09 PM · Plasma
ivan updated the diff for D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 1:06 PM · Plasma
ivan requested review of D19991: FileItem plugin for opening and closing Vaults from Dolphin.
Mar 23 2019, 12:00 PM · Plasma
ivan committed R845:4574e80916ae: Add a notification when mount failed because of a non empty mount point (authored by ivan).
Add a notification when mount failed because of a non empty mount point
Mar 23 2019, 10:44 AM
ivan committed R845:54a7b6cba169: Go offline as soon as the password prompt is shown (authored by ivan).
Go offline as soon as the password prompt is shown
Mar 23 2019, 10:13 AM

Mar 22 2019

ivan accepted D19986: Install .desktop file for kded5.
Mar 22 2019, 11:03 PM · Frameworks
ivan committed R845:fd3d8064222d: Sort vaults in the applet by name (authored by ivan).
Sort vaults in the applet by name
Mar 22 2019, 10:43 PM
ivan updated the summary of D19979: Don't create thumbnails for encrypted Vaults.
Mar 22 2019, 10:19 PM · Frameworks
ivan retitled D19979: Don't create thumbnails for encrypted Vaults from Don't create thumbnails for encrypted drives (Vaults) to Don't create thumbnails for encrypted Vaults.
Mar 22 2019, 10:17 PM · Frameworks
ivan updated the diff for D19979: Don't create thumbnails for encrypted Vaults.

Incorporated David's advice

Mar 22 2019, 9:57 PM · Frameworks
ivan requested review of D19979: Don't create thumbnails for encrypted Vaults.
Mar 22 2019, 9:27 PM · Frameworks
ivan committed R845:b099ea3d2be4: Do not load the payload from the first page when opening the wizard (authored by ivan).
Do not load the payload from the first page when opening the wizard
Mar 22 2019, 5:45 PM
ivan committed R845:1ba5dccb0bcc: Disable the dialog while creating the vault (authored by ivan).
Disable the dialog while creating the vault
Mar 22 2019, 4:58 PM

Feb 6 2019

ivan committed R119:019467e53bb9: Revert "[Activities KCM] vertically center the buttons" (authored by ivan).
Revert "[Activities KCM] vertically center the buttons"
Feb 6 2019, 8:09 PM
ivan committed R119:a8da90e21945: [Activities KCM] Properly vertically center the buttons (authored by ivan).
[Activities KCM] Properly vertically center the buttons
Feb 6 2019, 8:09 PM
ivan added a reverting change for R119:9cdfe25910cb: [Activities KCM] vertically center the buttons: R119:019467e53bb9: Revert "[Activities KCM] vertically center the buttons".
Feb 6 2019, 8:09 PM
ivan committed R119:a1ab33acec1c: Revert "[Activities KCM] vertically center the buttons" (authored by ivan).
Revert "[Activities KCM] vertically center the buttons"
Feb 6 2019, 8:07 PM
ivan committed R119:72a63ba0783b: [Activities KCM] Properly vertically center the buttons (authored by ivan).
[Activities KCM] Properly vertically center the buttons
Feb 6 2019, 8:07 PM
ivan added a reverting change for R119:9cdfe25910cb: [Activities KCM] vertically center the buttons: R119:a1ab33acec1c: Revert "[Activities KCM] vertically center the buttons".
Feb 6 2019, 8:07 PM
ivan committed R119:ae3ddf82dd95: Revert "[Activities KCM] vertically center the buttons" (authored by ivan).
Revert "[Activities KCM] vertically center the buttons"
Feb 6 2019, 7:19 PM
ivan committed R119:ccc6e24f9aab: [Activities KCM] Properly vertically center the buttons (authored by ivan).
[Activities KCM] Properly vertically center the buttons
Feb 6 2019, 7:19 PM
ivan added a reverting change for R119:9cdfe25910cb: [Activities KCM] vertically center the buttons: R119:ae3ddf82dd95: Revert "[Activities KCM] vertically center the buttons".
Feb 6 2019, 7:19 PM