pvuorela (Pekka Vuorela)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 14 2019, 2:32 PM (44 w, 3 d)
Availability
Available

Recent Activity

Tue, Jan 7

pvuorela added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?

Tue, Jan 7, 11:07 AM · Calligra: 3.0
pvuorela added a comment to D25423: Fill table cells with color for ODS and XLSX files.

loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.

Tue, Jan 7, 9:38 AM · Calligra: 3.0

Fri, Jan 3

pvuorela added a comment to D25422: Handle custom-shapes to display text in ODP files.

Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious.

Fri, Jan 3, 2:12 PM · Calligra: 3.0
pvuorela added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Not sure about all the details but two things look suspicious here:

Fri, Jan 3, 1:16 PM · Calligra: 3.0
pvuorela added a comment to D24852: Remove list style from headings.

Actually seems to now revert that one line as it was before commit fc7b878f206fb / https://bugs.kde.org/show_bug.cgi?id=306141

Fri, Jan 3, 1:10 PM · Calligra: 3.0

Tue, Dec 31

pvuorela committed R8:959027525581: Use RTF default color as default Qt format (authored by pvuorela).
Use RTF default color as default Qt format
Tue, Dec 31, 2:13 PM
pvuorela closed D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 2:13 PM · Calligra: 3.0
pvuorela added inline comments to D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 1:28 PM · Calligra: 3.0
pvuorela added inline comments to D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 1:22 PM · Calligra: 3.0
pvuorela committed R8:bcda431ed438: Add a readOnly property to the QtQuick2 Document type which disables the… (authored by denexter).
Add a readOnly property to the QtQuick2 Document type which disables the…
Tue, Dec 31, 1:14 PM
pvuorela closed D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Tue, Dec 31, 1:14 PM · Calligra: 3.0
pvuorela accepted D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..

Seems to work and big impact indeed. Approving already.

Tue, Dec 31, 10:25 AM · Calligra: 3.0

Mon, Dec 30

pvuorela added inline comments to D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Mon, Dec 30, 3:13 PM · Calligra: 3.0

Dec 10 2019

pvuorela added a reviewer for D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.: leinir.
Dec 10 2019, 8:01 AM · Calligra: 3.0

Dec 3 2019

pvuorela added inline comments to D25715: Use RTF default color as default Qt format.
Dec 3 2019, 4:26 PM · Calligra: 3.0
pvuorela added reviewers for D25715: Use RTF default color as default Qt format: davidllewellynjones, dcaliste.
Dec 3 2019, 3:10 PM · Calligra: 3.0
pvuorela requested review of D25715: Use RTF default color as default Qt format.
Dec 3 2019, 3:06 PM · Calligra: 3.0

Nov 29 2019

pvuorela committed R8:206fdf01eaac: Display figure brackets in plain text (authored by mphilippov).
Display figure brackets in plain text
Nov 29 2019, 3:11 PM
pvuorela closed D25541: Display figure brackets in plain text.
Nov 29 2019, 3:11 PM · Calligra: 3.0

Nov 26 2019

pvuorela accepted D25541: Display figure brackets in plain text.

Or in other words: support for escaped brackets \{ \}

Nov 26 2019, 9:19 AM · Calligra: 3.0

Nov 21 2019

pvuorela added a comment to D25008: Add XLSX spreadsheets import optimisations for small/readonly devices.

A bit mixed feelings for this. In a way nice to avoid unnecessary work, but then again it seems effectively a compilation option if xlsx support is for read-write or view-only. On main level CMake it's also a bit random detail compared to others.

Nov 21 2019, 9:57 AM · Calligra: 3.0

Nov 20 2019

pvuorela committed R8:26c957c77e64: Relax TextPFRun validation to allow LibreOffice PPT import (authored by davidllewellynjones).
Relax TextPFRun validation to allow LibreOffice PPT import
Nov 20 2019, 9:48 AM
pvuorela closed D25256: Relax TextPFRun validation to allow LibreOffice PPT import.
Nov 20 2019, 9:48 AM · Calligra: 3.0
pvuorela accepted D25256: Relax TextPFRun validation to allow LibreOffice PPT import.
Nov 20 2019, 9:45 AM · Calligra: 3.0

Nov 19 2019

pvuorela committed R664:aca4fd06f1ad: Allow files exported by LibreOffice to validate (authored by pvuorela).
Allow files exported by LibreOffice to validate
Nov 19 2019, 1:44 PM
pvuorela closed D25259: Allow files exported by LibreOffice to validate.
Nov 19 2019, 1:44 PM
pvuorela accepted D25259: Allow files exported by LibreOffice to validate.
Nov 19 2019, 12:34 PM

Nov 14 2019

pvuorela added a comment to D25259: Allow files exported by LibreOffice to validate.

Seems reasonable to me. I'll approve later if no-one objects.

Nov 14 2019, 11:54 AM
pvuorela added a comment to D25256: Relax TextPFRun validation to allow LibreOffice PPT import.

Seems reasonable to me.

Nov 14 2019, 11:52 AM · Calligra: 3.0
pvuorela committed R8:6f183e8ae93e: Fix build on newish gcc with qreal as float (authored by pvuorela).
Fix build on newish gcc with qreal as float
Nov 14 2019, 11:22 AM
pvuorela closed D25288: Fix build on newish gcc with qreal as float.
Nov 14 2019, 11:22 AM · Calligra: 3.0
pvuorela committed R8:845a1ffb3204: Mark \shp and \shpinst as supported control words on rtf reader (authored by pvuorela).
Mark \shp and \shpinst as supported control words on rtf reader
Nov 14 2019, 11:22 AM
pvuorela closed D25285: Mark \shp and \shpinst as supported control words on rtf reader.
Nov 14 2019, 11:22 AM · Calligra: 3.0

Nov 13 2019

pvuorela added reviewers for D25288: Fix build on newish gcc with qreal as float: leinir, denexter.
Nov 13 2019, 2:51 PM · Calligra: 3.0
pvuorela requested review of D25288: Fix build on newish gcc with qreal as float.
Nov 13 2019, 2:50 PM · Calligra: 3.0
pvuorela added reviewers for D25285: Mark \shp and \shpinst as supported control words on rtf reader: denexter, davidllewellynjones.
Nov 13 2019, 2:33 PM · Calligra: 3.0
pvuorela requested review of D25285: Mark \shp and \shpinst as supported control words on rtf reader.
Nov 13 2019, 2:31 PM · Calligra: 3.0

Nov 11 2019

pvuorela committed R8:66ea04a230d7: Read xlsx drawing dimensions from the xdr:ext element if available. (authored by denexter).
Read xlsx drawing dimensions from the xdr:ext element if available.
Nov 11 2019, 9:22 AM
pvuorela committed R8:cec1e93bb7d5: Don't allow an unrecognized child element to block loading of a shape plugin. (authored by denexter).
Don't allow an unrecognized child element to block loading of a shape plugin.
Nov 11 2019, 9:22 AM
pvuorela committed R8:d0b2c2f9afdf: Don't drop number styling information from xlsx cell formats which start with a… (authored by denexter).
Don't drop number styling information from xlsx cell formats which start with a…
Nov 11 2019, 9:22 AM
pvuorela closed D25032: Read xlsx drawing dimensions from the xdr:ext element if available..
Nov 11 2019, 9:22 AM · Calligra: 3.0
pvuorela closed D25031: Don't allow an unrecognized child element to block loading of a shape plugin..
Nov 11 2019, 9:22 AM · Calligra: 3.0
pvuorela committed R8:345f970a6deb: Fix incorrect conditional styling of spreadsheet cells. (authored by denexter).
Fix incorrect conditional styling of spreadsheet cells.
Nov 11 2019, 9:22 AM
pvuorela committed R8:44e297458950: Don't double format spreadsheet currency values with custom format strings. (authored by denexter).
Don't double format spreadsheet currency values with custom format strings.
Nov 11 2019, 9:22 AM
pvuorela closed D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol..
Nov 11 2019, 9:22 AM · Calligra: 3.0
pvuorela closed D25036: Don't double format spreadsheet currency values with custom format strings..
Nov 11 2019, 9:22 AM · Calligra: 3.0
pvuorela committed R8:b253bef8dc85: Extract images from excel files which omit the FtCF entry. (authored by denexter).
Extract images from excel files which omit the FtCF entry.
Nov 11 2019, 9:22 AM
pvuorela closed D25035: Fix incorrect conditional styling of spreadsheet cells..
Nov 11 2019, 9:22 AM · Calligra: 3.0
pvuorela closed D25033: Extract images from excel files which omit the FtCF entry..
Nov 11 2019, 9:21 AM · Calligra: 3.0
pvuorela accepted D25032: Read xlsx drawing dimensions from the xdr:ext element if available..
Nov 11 2019, 9:15 AM · Calligra: 3.0
pvuorela accepted D25031: Don't allow an unrecognized child element to block loading of a shape plugin..
Nov 11 2019, 8:49 AM · Calligra: 3.0

Nov 8 2019

pvuorela added a reviewer for D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.: mkruisselbrink.

But would those characters work without encoding adjustments if the used MS font was present? Not sure how it gets rendered now without the font, but if it's anything like the "J" exchange email smiley I'm not sure which is worse.

Nov 8 2019, 8:31 AM · Calligra: 3.0

Nov 7 2019

pvuorela added a comment to D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records..

Is there something in the spec encoding the microsoft fonts or just some kind of practice? Seems a little scary just stripping bits.

Nov 7 2019, 12:24 PM · Calligra: 3.0
pvuorela accepted D25033: Extract images from excel files which omit the FtCF entry..

Minor comment, but overall looks good to me.

Nov 7 2019, 9:48 AM · Calligra: 3.0
pvuorela added a comment to D25032: Read xlsx drawing dimensions from the xdr:ext element if available..

Seems sensical for what I can tell. I'll do some test round and (likely) approve later if no objections pop up.

Nov 7 2019, 9:17 AM · Calligra: 3.0

Nov 6 2019

pvuorela added a comment to D25031: Don't allow an unrecognized child element to block loading of a shape plugin..

Seems sensible to me. I'll approve and merge shortly if no-one objects.

Nov 6 2019, 2:48 PM · Calligra: 3.0
pvuorela accepted D25037: Don't drop number styling information from xlsx cell formats which start with a currency symbol..

Seems good.

Nov 6 2019, 1:15 PM · Calligra: 3.0
pvuorela accepted D25036: Don't double format spreadsheet currency values with custom format strings..

Seems good.

Nov 6 2019, 1:15 PM · Calligra: 3.0
pvuorela accepted D25035: Fix incorrect conditional styling of spreadsheet cells..

Looks good to me.

Nov 6 2019, 1:15 PM · Calligra: 3.0
pvuorela committed R478:8b873b18ccff: Fix build issues when qreal == float. (authored by denexter).
Fix build issues when qreal == float.
Nov 6 2019, 12:16 PM
pvuorela closed D25030: Fix build issues when qreal == float..
Nov 6 2019, 12:16 PM

Nov 1 2019

pvuorela committed R243:8222caed9367: Fix null pointer reference when extraction fails (authored by pvuorela).
Fix null pointer reference when extraction fails
Nov 1 2019, 7:03 AM
pvuorela closed D24726: Fix null pointer reference when extraction fails.
Nov 1 2019, 7:03 AM · Frameworks

Oct 31 2019

pvuorela added a comment to D24726: Fix null pointer reference when extraction fails.

Haven't looked and to be honest a little skeptical if anyone removing a null check is likely enough to protect against.

Oct 31 2019, 1:54 PM · Frameworks
pvuorela accepted D25030: Fix build issues when qreal == float..

Looks good to me.

Oct 31 2019, 10:03 AM
pvuorela added reviewers for D24726: Fix null pointer reference when extraction fails: davidllewellynjones, dfaure, aacid.
Oct 31 2019, 8:40 AM · Frameworks
pvuorela updated the diff for D24726: Fix null pointer reference when extraction fails.

Also remove the empty target file on error

Oct 31 2019, 8:37 AM · Frameworks

Oct 30 2019

pvuorela committed R8:e80856e8eb6a: Asign correct column width when importing XLS file (authored by davidllewellynjones).
Asign correct column width when importing XLS file
Oct 30 2019, 7:41 AM
pvuorela closed D24761: Asign correct column width when importing XLS file.
Oct 30 2019, 7:41 AM · Calligra: 3.0
pvuorela committed R8:1b17db1a98ec: Better charset, unicode and image support for RTF files (authored by pvuorela).
Better charset, unicode and image support for RTF files
Oct 30 2019, 7:41 AM
pvuorela closed D24943: Better charset, unicode and image support for RTF files.
Oct 30 2019, 7:41 AM · Calligra: 3.0

Oct 29 2019

pvuorela updated the diff for D24943: Better charset, unicode and image support for RTF files.

Update image size reading conditions

Oct 29 2019, 12:53 PM · Calligra: 3.0
pvuorela added inline comments to D24943: Better charset, unicode and image support for RTF files.
Oct 29 2019, 12:46 PM · Calligra: 3.0

Oct 28 2019

pvuorela updated the diff for D24943: Better charset, unicode and image support for RTF files.

Whitespace adjustments

Oct 28 2019, 3:10 PM · Calligra: 3.0
pvuorela added inline comments to D24943: Better charset, unicode and image support for RTF files.
Oct 28 2019, 3:04 PM · Calligra: 3.0
pvuorela committed R8:b17f993c3b20: Migrate csv plugins from kdebug to qdebug (authored by pvuorela).
Migrate csv plugins from kdebug to qdebug
Oct 28 2019, 2:05 PM
pvuorela closed D24831: Migrate csv plugins from kdebug to qdebug.
Oct 28 2019, 2:05 PM · Calligra: 3.0
pvuorela accepted D24761: Asign correct column width when importing XLS file.
Oct 28 2019, 8:56 AM · Calligra: 3.0
pvuorela committed R8:0e9d73d8ce1e: Remove unsupported attributes from QGraphicsWidgets (authored by pvuorela).
Remove unsupported attributes from QGraphicsWidgets
Oct 28 2019, 7:15 AM
pvuorela closed D19759: Remove unsupported attributes from QGraphicsWidgets.
Oct 28 2019, 7:15 AM · Calligra: 3.0

Oct 25 2019

pvuorela requested review of D24943: Better charset, unicode and image support for RTF files.
Oct 25 2019, 1:44 PM · Calligra: 3.0
pvuorela added a comment to D24761: Asign correct column width when importing XLS file.

Seems it was indeed the only physicalDpi, though not too many logical either. Not trivial to follow, but seems sane and the screenshots are thorough. I'll approve if no-one objects shortly.

Oct 25 2019, 11:27 AM · Calligra: 3.0

Oct 22 2019

pvuorela committed R8:11b3b7718796: Add support for strikeout text in RTF documents (authored by pvuorela).
Add support for strikeout text in RTF documents
Oct 22 2019, 9:58 AM
pvuorela closed D24830: Add support for strikeout text in RTF documents.
Oct 22 2019, 9:58 AM · Calligra: 3.0
pvuorela accepted D24830: Add support for strikeout text in RTF documents.

Looking good to me.

Oct 22 2019, 8:15 AM · Calligra: 3.0

Oct 21 2019

pvuorela added inline comments to D24830: Add support for strikeout text in RTF documents.
Oct 21 2019, 2:12 PM · Calligra: 3.0
pvuorela added reviewers for D24831: Migrate csv plugins from kdebug to qdebug: dcaliste, leinir.
Oct 21 2019, 2:07 PM · Calligra: 3.0
pvuorela requested review of D24831: Migrate csv plugins from kdebug to qdebug.
Oct 21 2019, 2:06 PM · Calligra: 3.0

Oct 17 2019

pvuorela requested review of D24726: Fix null pointer reference when extraction fails.
Oct 17 2019, 10:28 AM · Frameworks

Sep 2 2019

pvuorela added a comment to D23492: Correct anchor detection in QML components..

And even rendering now better, no idea what happened.

Sep 2 2019, 12:41 PM · Calligra: 3.0
pvuorela accepted D23492: Correct anchor detection in QML components..

Having a bit strange rendering for TextDocumentImpl.cpp changes here, but the raw diff looks good now. Trust all good :)

Sep 2 2019, 12:40 PM · Calligra: 3.0

Aug 30 2019

pvuorela added a comment to D23492: Correct anchor detection in QML components..

Indeed that doesn't look like a good loop, if triggered once, nothing affecting the break out condition inside of it. But isn't the same thing happening also at the beginning of this method, and actually same kind of construct being there in spreadsheet and presentation impls too?

Aug 30 2019, 11:27 AM · Calligra: 3.0

Apr 26 2019

pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Second ping for this.

Apr 26 2019, 3:01 PM · Calligra: 3.0

Apr 4 2019

pvuorela committed R8:35ec7cff51c2: Small cleanups for qml components (authored by pvuorela).
Small cleanups for qml components
Apr 4 2019, 9:48 AM
pvuorela closed D19943: Small cleanups for qml components.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela committed R8:cfdd5d860b2a: Migrate away from deprecated interfaces in gemini dropbox parts (authored by pvuorela).
Migrate away from deprecated interfaces in gemini dropbox parts
Apr 4 2019, 9:48 AM
pvuorela closed D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().

Apr 4 2019, 9:18 AM · Calligra: 3.0

Mar 27 2019

pvuorela added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 1:23 PM · Calligra: 3.0

Mar 22 2019

pvuorela requested review of D19973: MsooXmlCommonRead: protect member for double free.
Mar 22 2019, 1:09 PM · Calligra: 3.0