barchiesi (David Barchiesi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2019, 11:10 AM (13 w, 1 d)
Availability
Available

Recent Activity

Thu, May 23

barchiesi added a comment to D20843: Fix CMakeLists always building examples..

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

Thu, May 23, 8:41 AM · LibKGAPI, KDE PIM
barchiesi closed D20843: Fix CMakeLists always building examples..
Thu, May 23, 8:39 AM · LibKGAPI, KDE PIM
barchiesi committed R477:2fc71a173504: Fix CMakeLists always building examples. (authored by barchiesi).
Fix CMakeLists always building examples.
Thu, May 23, 8:39 AM

Wed, May 22

barchiesi updated the diff for D20843: Fix CMakeLists always building examples..

Changed (wrong) commit email address.

Wed, May 22, 10:50 PM · LibKGAPI, KDE PIM

Sun, May 19

barchiesi updated the diff for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.

Fixed

Sun, May 19, 9:44 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Yes I did

Sun, May 19, 9:43 PM · KIO GDrive
barchiesi abandoned D19948: DRAFT Add Standard Query Parameters support.

All changes have been covered by other differentials, this can be abandoned.

Sun, May 19, 5:00 PM · KDE PIM, LibKGAPI
barchiesi set the repository for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities to R219 KIO GDrive.
Sun, May 19, 4:58 PM · KIO GDrive
barchiesi updated the diff for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.

Updated after changes to D20064

Sun, May 19, 4:58 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

You are correct, fixed those issues

Sun, May 19, 4:54 PM · KIO GDrive

Tue, May 14

barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

I bumped PIM_VERSION, but I'm not sure how versioning works in this project so I only increased the PATCH number.

Tue, May 14, 8:00 AM · KDE PIM, LibKGAPI

Wed, May 1

barchiesi set the repository for D20883: Apply Authorization headers in Job instead of in each Job implementation. to R477 KGAPI Library.
Wed, May 1, 6:17 PM · LibKGAPI, KDE PIM
barchiesi set the repository for D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs. to R477 KGAPI Library.
Wed, May 1, 6:17 PM · LibKGAPI, KDE PIM
barchiesi set the repository for D20886: Add fields standard query parameter to Job and use it in FileFetchJob. to R477 KGAPI Library.
Wed, May 1, 6:16 PM · KDE PIM, LibKGAPI
barchiesi added a comment to D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

LibKGAPI 19.04 has full support for the Teamdrives REST API but unfortunately that isn't sufficient for completely manipulating them in KIO GDrive. The KIO GDrive patch for Team Drives that I'm working on requires this revision for querying if the user can create Team Drives and it requires D20789 for uploading files and finding parents. I'll probably find more stuff that needs to be added to LibKGAPI.
Therefore KIO GDrive won't be able to support Team Drives until LibKGAPI 19.08. As soon as I have most of the functionality ready, I will submit a revision so you can start looking at it.

Wed, May 1, 6:05 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.

Add commit to revision.

Wed, May 1, 5:29 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Add commit to revision.

Wed, May 1, 5:28 PM · KIO GDrive
barchiesi added a dependency for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities: D20064: Add usefull functions to GDriveUrl..
Wed, May 1, 5:25 PM · KIO GDrive
barchiesi added a dependent revision for D20064: Add usefull functions to GDriveUrl.: D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
Wed, May 1, 5:25 PM · KIO GDrive
barchiesi requested review of D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
Wed, May 1, 5:25 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Maybe this time

Wed, May 1, 5:19 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Got it.

Wed, May 1, 5:16 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..
  • Add usefull functions to GDriveUrl and move some gdriveurl related logic there.
  • Refactor kio_gdrive to make use of new GDriveUrl functionalities.
Wed, May 1, 5:07 PM · KIO GDrive
barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Updated after revision D20789 change.

Wed, May 1, 4:57 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs..

Updated after revision D20789 change.

Wed, May 1, 4:56 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D20883: Apply Authorization headers in Job instead of in each Job implementation..

Updated after revision D20789 change.

Wed, May 1, 4:53 PM · LibKGAPI, KDE PIM
barchiesi updated the summary of D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.
Wed, May 1, 4:51 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.

Added the supportsAllDrives query param to other Jobs that can use it.

Wed, May 1, 4:49 PM · KDE PIM, LibKGAPI

Tue, Apr 30

barchiesi updated the summary of D20064: Add usefull functions to GDriveUrl..
Tue, Apr 30, 1:00 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Added more functions and refactored KIOGDrive.

Tue, Apr 30, 12:25 PM · KIO GDrive

Mon, Apr 29

barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Since this changes the API, we must also bump the version in CMakeLists.txt. KIO GDrive will then have to have an #ifdef on LibKGAPI version to use either the old or the new approach, based on against what version of LibKGAPI it is compiled. This LibKGAPI API will not be publicly available until August (KDE Applications 19.08 release).

Another option is to have KIO GDrive master depend on the master of LibKGAPI and not doing any KIO GDrive release from master until LibKGAPI 19.08 is released (but I doubt @elvisangelaccio would be too happy about that :-) )

I guess we should let @elvisangelaccio decide, I believe the first approach is better because it allows building a newer KIO GDrive against older versions of LibKGAPI.

Mon, Apr 29, 3:01 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Added Teamdrive field mappings.

Mon, Apr 29, 11:52 AM · KDE PIM, LibKGAPI
barchiesi retitled D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it from FileFetchJob: unconditionally set `includeTeamDriveItems`, `includeItemsFromAllDrives`, `supportsTeamDrives`, `supportsAllDrives` query params to FileFetchJob: unconditionally set `includeItemsFromAllDrives`, `supportsAllDrives` query params.
Mon, Apr 29, 8:27 AM · KDE PIM, LibKGAPI
barchiesi added a comment to D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Yes this change affects all LibKGAPI users that used the FileFetchJob::setFields() function. A patch for KIO Gdrive fixes the incompatibility, although I'm not sure how to specify that it should be blocked until the new LibKGAPI release.

Mon, Apr 29, 8:26 AM · KDE PIM, LibKGAPI
barchiesi added a dependency for D20888: Adapt to LibKGAPI setFields() changes.: D20886: Add fields standard query parameter to Job and use it in FileFetchJob..
Mon, Apr 29, 8:24 AM · LibKGAPI, KIO GDrive
barchiesi added a dependent revision for D20886: Add fields standard query parameter to Job and use it in FileFetchJob.: D20888: Adapt to LibKGAPI setFields() changes..
Mon, Apr 29, 8:24 AM · KDE PIM, LibKGAPI
barchiesi requested review of D20888: Adapt to LibKGAPI setFields() changes..
Mon, Apr 29, 8:24 AM · LibKGAPI, KIO GDrive

Sun, Apr 28

barchiesi added a dependent revision for D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs.: D20886: Add fields standard query parameter to Job and use it in FileFetchJob..
Sun, Apr 28, 9:47 PM · LibKGAPI, KDE PIM
barchiesi added a dependency for D20886: Add fields standard query parameter to Job and use it in FileFetchJob.: D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs..
Sun, Apr 28, 9:47 PM · KDE PIM, LibKGAPI
barchiesi requested review of D20886: Add fields standard query parameter to Job and use it in FileFetchJob..
Sun, Apr 28, 9:47 PM · KDE PIM, LibKGAPI
barchiesi added a dependent revision for D20883: Apply Authorization headers in Job instead of in each Job implementation.: D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs..
Sun, Apr 28, 9:41 PM · LibKGAPI, KDE PIM
barchiesi added a dependency for D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs.: D20883: Apply Authorization headers in Job instead of in each Job implementation..
Sun, Apr 28, 9:41 PM · LibKGAPI, KDE PIM
Restricted Application added a project to D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs.: KDE PIM.
Sun, Apr 28, 9:41 PM · LibKGAPI, KDE PIM
barchiesi requested review of D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs..
Sun, Apr 28, 9:40 PM · LibKGAPI, KDE PIM
barchiesi added a dependency for D20883: Apply Authorization headers in Job instead of in each Job implementation.: D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.
Sun, Apr 28, 9:35 PM · LibKGAPI, KDE PIM
barchiesi added a dependent revision for D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it: D20883: Apply Authorization headers in Job instead of in each Job implementation..
Sun, Apr 28, 9:35 PM · KDE PIM, LibKGAPI
barchiesi requested review of D20883: Apply Authorization headers in Job instead of in each Job implementation..
Sun, Apr 28, 9:34 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.
Sun, Apr 28, 9:19 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.

It seems like Google updated the v2 and v3 Drive references. The Teamdrive part of the API that I recently added is now considered deprecated and Drives should be used instead. Sintactically they are very similar, if not same apart from the added features.

Sun, Apr 28, 6:40 PM · KDE PIM, LibKGAPI

Apr 26 2019

barchiesi requested review of D20843: Fix CMakeLists always building examples..
Apr 26 2019, 1:22 PM · LibKGAPI, KDE PIM

Apr 25 2019

barchiesi moved T10630: Show Team Drives from Backlog to In Progress on the KIO GDrive board.
Apr 25 2019, 12:42 AM · KIO GDrive
barchiesi updated the diff for D19948: DRAFT Add Standard Query Parameters support.

Changed DeleteJob and ContactModifyJob to demonstrate prettyPrint overriding.

Apr 25 2019, 12:35 AM · KDE PIM, LibKGAPI
barchiesi updated the diff for D19948: DRAFT Add Standard Query Parameters support.

So I ditched Job::authorizedRequest() and now apply auth headers and standard params directly in Job::Private::_k_dispatchTimeout(). Basically I realized that perhaps some kind of jobs don't need the prettyPrint param set to false (no output or the cost is greater than the gain? delete methods maybe?) and in these cases I want to be able to remove the query param in the dispatchRequest implementation (eg. DeleteJob::dispatchRequest).
Does the above seem reasonable?
I also fixed up a little FileLogger so it produces a cleaner output.

Apr 25 2019, 12:17 AM · KDE PIM, LibKGAPI

Apr 24 2019

barchiesi added a dependency for D19948: DRAFT Add Standard Query Parameters support: D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.
Apr 24 2019, 3:06 PM · KDE PIM, LibKGAPI
barchiesi added a dependent revision for D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it: D19948: DRAFT Add Standard Query Parameters support.
Apr 24 2019, 3:06 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D19948: DRAFT Add Standard Query Parameters support.

Ok so I updated most test urls to reflect the prettyPrint change. I'm not sure what is left out but I will soon find out.
I also refactored File and FileFetchJob so the setFields is centralized. This will require that dependent projects rewrite their FileFetchJob::setFields() invocations, not sure how much of a negative impact that is...

Apr 24 2019, 3:05 PM · KDE PIM, LibKGAPI
barchiesi requested review of D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.
Apr 24 2019, 2:50 PM · KDE PIM, LibKGAPI

Apr 23 2019

barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Added test case, is the test sufficient?

Apr 23 2019, 8:48 AM · KIO GDrive

Mar 26 2019

barchiesi requested review of D20064: Add usefull functions to GDriveUrl..
Mar 26 2019, 5:06 PM · KIO GDrive

Mar 22 2019

barchiesi updated the diff for D19948: DRAFT Add Standard Query Parameters support.

I noticed most jobs set the Authorization header on their own so perhaps a standard request builder is needed. I added Job::authorizedRequest with encapsulates this and also adds standard query parameters.

Mar 22 2019, 11:01 PM · KDE PIM, LibKGAPI
barchiesi added inline comments to D19948: DRAFT Add Standard Query Parameters support.
Mar 22 2019, 5:19 PM · KDE PIM, LibKGAPI

Mar 21 2019

barchiesi requested review of D19948: DRAFT Add Standard Query Parameters support.
Mar 21 2019, 6:25 PM · KDE PIM, LibKGAPI

Mar 17 2019

barchiesi added a comment to T10630: Show Team Drives.

No the API only exposes the list, clients choose how to present them to users.

Mar 17 2019, 8:36 PM · KIO GDrive
barchiesi closed T10521: [Drive] Implement Team Drives portion of the API as Resolved.
Mar 17 2019, 7:46 PM · LibKGAPI
barchiesi created T10630: Show Team Drives.
Mar 17 2019, 7:46 PM · KIO GDrive
barchiesi added a comment to T10521: [Drive] Implement Team Drives portion of the API.

@barchiesi how much is still missing in the KGAPI code for the Teamdrive support?

Mar 17 2019, 6:07 PM · LibKGAPI
barchiesi updated the diff for D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive..
Mar 17 2019, 5:53 PM · KDE PIM, LibKGAPI
barchiesi added a comment to D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive..

Had some typos in copyright notices.

Mar 17 2019, 5:31 PM · KDE PIM, LibKGAPI
barchiesi added a comment to T10521: [Drive] Implement Team Drives portion of the API.

When D19836 gets approved I believe this task is complete, @dvratil correct me if I'm wrong.

Mar 17 2019, 5:15 PM · LibKGAPI
barchiesi added a revision to T10521: [Drive] Implement Team Drives portion of the API: D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive..
Mar 17 2019, 5:11 PM · LibKGAPI
barchiesi added a task to D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive.: T10521: [Drive] Implement Team Drives portion of the API.
Mar 17 2019, 5:11 PM · KDE PIM, LibKGAPI
barchiesi requested review of D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive..
Mar 17 2019, 5:11 PM · KDE PIM, LibKGAPI

Mar 11 2019

barchiesi added a task to D19693: Add TeamdriveDeleteJob with updated example and test: T10521: [Drive] Implement Team Drives portion of the API.
Mar 11 2019, 7:35 PM · LibKGAPI, KDE PIM
barchiesi added a revision to T10521: [Drive] Implement Team Drives portion of the API: D19693: Add TeamdriveDeleteJob with updated example and test.
Mar 11 2019, 7:35 PM · LibKGAPI
barchiesi requested review of D19693: Add TeamdriveDeleteJob with updated example and test.
Mar 11 2019, 7:35 PM · LibKGAPI, KDE PIM

Mar 8 2019

barchiesi updated the diff for D19576: Add Team Drive create job feature..

Added getter and updated test (not sure how useful).

Mar 8 2019, 1:25 PM · LibKGAPI, KDE PIM

Mar 7 2019

barchiesi added a task to D19576: Add Team Drive create job feature.: T10521: [Drive] Implement Team Drives portion of the API.
Mar 7 2019, 12:04 AM · LibKGAPI, KDE PIM
barchiesi added a revision to T10521: [Drive] Implement Team Drives portion of the API: D19576: Add Team Drive create job feature..
Mar 7 2019, 12:04 AM · LibKGAPI
barchiesi requested review of D19576: Add Team Drive create job feature..
Mar 7 2019, 12:04 AM · LibKGAPI, KDE PIM

Mar 5 2019

barchiesi added a comment to T10521: [Drive] Implement Team Drives portion of the API.

As of D19546, fetch support should be complete. I already started working on create functionality, after that only delete and update are missing.

Mar 5 2019, 4:30 PM · LibKGAPI
barchiesi added a revision to T10521: [Drive] Implement Team Drives portion of the API: D19546: Add TeamdriveSearchQuery and support for it in TeamdriveFetchJob..
Mar 5 2019, 4:27 PM · LibKGAPI
barchiesi added a task to D19546: Add TeamdriveSearchQuery and support for it in TeamdriveFetchJob.: T10521: [Drive] Implement Team Drives portion of the API.
Mar 5 2019, 4:27 PM · LibKGAPI, KDE PIM
barchiesi requested review of D19546: Add TeamdriveSearchQuery and support for it in TeamdriveFetchJob..
Mar 5 2019, 4:27 PM · LibKGAPI, KDE PIM

Mar 4 2019

barchiesi updated the diff for D19403: Add Team Drive model and basic fetch..

Embarrassing

Mar 4 2019, 6:44 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D19490: Refactor FileSearchQuery and create base class SearchQuery.

Use C++11 default constructors and QScopedPointer. I should have fixed all the points, let me know if I missed something.

Mar 4 2019, 3:59 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D19403: Add Team Drive model and basic fetch..

Use C++11 default constructors and QScopedPointer. I should have fixed all the points, let me know if I missed something.

Mar 4 2019, 1:58 PM · KDE PIM, LibKGAPI

Mar 3 2019

barchiesi updated the test plan for D19490: Refactor FileSearchQuery and create base class SearchQuery.
Mar 3 2019, 11:41 AM · KDE PIM, LibKGAPI
barchiesi added a revision to T10521: [Drive] Implement Team Drives portion of the API: D19490: Refactor FileSearchQuery and create base class SearchQuery.
Mar 3 2019, 11:18 AM · LibKGAPI
barchiesi added a task to D19490: Refactor FileSearchQuery and create base class SearchQuery: T10521: [Drive] Implement Team Drives portion of the API.
Mar 3 2019, 11:18 AM · KDE PIM, LibKGAPI
barchiesi requested review of D19490: Refactor FileSearchQuery and create base class SearchQuery.
Mar 3 2019, 11:17 AM · KDE PIM, LibKGAPI

Feb 28 2019

barchiesi updated the diff for D19403: Add Team Drive model and basic fetch..

Added constants for attributes. What is the correct naming?
Fixed copyright names.

Feb 28 2019, 11:39 PM · KDE PIM, LibKGAPI

Feb 27 2019

barchiesi added a comment to T10521: [Drive] Implement Team Drives portion of the API.

Considering D19403, fetch is missing support for the q parameter, which works the same way as in FileSearchQuery. FileSearchQuery is basically just missing team drive specific field definitions as described here. How should we handle this?

Feb 27 2019, 11:25 PM · LibKGAPI
barchiesi added a watcher for KIO GDrive: barchiesi.
Feb 27 2019, 11:15 PM
barchiesi added a revision to T10521: [Drive] Implement Team Drives portion of the API: D19403: Add Team Drive model and basic fetch..
Feb 27 2019, 11:02 PM · LibKGAPI
barchiesi added a task to D19403: Add Team Drive model and basic fetch.: T10521: [Drive] Implement Team Drives portion of the API.
Feb 27 2019, 11:02 PM · KDE PIM, LibKGAPI
barchiesi added a reviewer for D19403: Add Team Drive model and basic fetch.: dvratil.
Feb 27 2019, 10:59 PM · KDE PIM, LibKGAPI
barchiesi requested review of D19403: Add Team Drive model and basic fetch..
Feb 27 2019, 10:58 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D19368: Fetch Team Drive files and add Drive auth scope.

Added getter.

Feb 27 2019, 3:53 PM · LibKGAPI, KDE PIM

Feb 26 2019

barchiesi requested review of D19368: Fetch Team Drive files and add Drive auth scope.
Feb 26 2019, 8:24 PM · LibKGAPI, KDE PIM

Feb 24 2019

barchiesi added a watcher for LibKGAPI: barchiesi.
Feb 24 2019, 11:20 AM