barchiesi (David Barchiesi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2019, 11:10 AM (34 w, 2 h)
Availability
Available

Recent Activity

Thu, Oct 3

barchiesi committed R219:8e2b3d3d759b: Allow stat()ing new-account link. (authored by barchiesi).
Allow stat()ing new-account link.
Thu, Oct 3, 7:46 AM
barchiesi closed D24366: Allow stat()ing new-account link..
Thu, Oct 3, 7:46 AM · KIO GDrive

Wed, Oct 2

barchiesi added a project to D24366: Allow stat()ing new-account link.: KIO GDrive.
Wed, Oct 2, 3:07 PM · KIO GDrive
barchiesi requested review of D24366: Allow stat()ing new-account link..
Wed, Oct 2, 3:06 PM · KIO GDrive

Tue, Oct 1

barchiesi committed R477:eb6eba42b38d: Merge remote-tracking branch 'origin/Applications/19.08' (authored by barchiesi).
Merge remote-tracking branch 'origin/Applications/19.08'
Tue, Oct 1, 12:10 PM
barchiesi committed R477:2cbbdda75227: Fix null pointer dereference, keep FileModifyJob metadata and serialize with… (authored by barchiesi).
Fix null pointer dereference, keep FileModifyJob metadata and serialize with…
Tue, Oct 1, 12:10 PM
barchiesi closed D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options..
Tue, Oct 1, 12:10 PM · LibKGAPI, KDE PIM
barchiesi committed R477:aa6679a3843b: Fix comparison typo (authored by barchiesi).
Fix comparison typo
Tue, Oct 1, 11:56 AM
barchiesi closed D24310: Fix comparison typo.
Tue, Oct 1, 11:56 AM · LibKGAPI, KDE PIM

Mon, Sep 30

barchiesi claimed T11751: Tasks library code cleanup.
Mon, Sep 30, 1:21 PM · LibKGAPI
barchiesi moved T11751: Tasks library code cleanup from Backlog to In Progress on the LibKGAPI board.
Mon, Sep 30, 1:21 PM · LibKGAPI
barchiesi added a project to D24310: Fix comparison typo: LibKGAPI.
Mon, Sep 30, 12:39 PM · LibKGAPI, KDE PIM
barchiesi requested review of D24310: Fix comparison typo.
Mon, Sep 30, 12:39 PM · LibKGAPI, KDE PIM

Sun, Sep 29

barchiesi added a comment to D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options..

Regarding point 1, mea culpa 😬

Sun, Sep 29, 6:28 PM · LibKGAPI, KDE PIM
barchiesi added a project to D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options.: LibKGAPI.
Sun, Sep 29, 6:24 PM · LibKGAPI, KDE PIM
barchiesi requested review of D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options..
Sun, Sep 29, 6:24 PM · LibKGAPI, KDE PIM

Wed, Sep 25

barchiesi added a comment to T4251: Investigate KIO::UDSEntry::UDS_EXTRA usage.

As of now, the first UDS_EXTRA is used to store the alternateLink of a Drive file. This is necessary for providing an url to the 'Copy Google URL to clipboard' action.

Wed, Sep 25, 8:39 AM · KIO GDrive
barchiesi moved T11771: Directory structure change from Backlog to In Progress on the KIO GDrive board.
Wed, Sep 25, 8:39 AM · KIO GDrive
barchiesi placed T10630: Show Team Drives up for grabs.
Wed, Sep 25, 8:39 AM · KIO GDrive
barchiesi moved T10630: Show Team Drives from In Progress to Done on the KIO GDrive board.
Wed, Sep 25, 8:38 AM · KIO GDrive
barchiesi created T11771: Directory structure change.
Wed, Sep 25, 8:38 AM · KIO GDrive

Tue, Sep 24

barchiesi committed R219:41bb6b0214cb: Add Shared Drives to GDriveUrl slave. (authored by barchiesi).
Add Shared Drives to GDriveUrl slave.
Tue, Sep 24, 9:37 AM
barchiesi closed D23804: Add Shared Drives to GDriveUrl slave..
Tue, Sep 24, 9:37 AM · KIO GDrive

Sat, Sep 21

barchiesi added inline comments to D23804: Add Shared Drives to GDriveUrl slave..
Sat, Sep 21, 5:25 PM · KIO GDrive
barchiesi updated the diff for D23804: Add Shared Drives to GDriveUrl slave..

moved translation of Shared Drive label to kio_gdrive.cpp
ordered kio_gdrive.cpp includes
const and ref fixes

Sat, Sep 21, 5:25 PM · KIO GDrive
barchiesi created T11741: Fix link ordering - BUG411425.
Sat, Sep 21, 4:19 PM · LibKGAPI
barchiesi accepted D24085: Cleanup and modernize the Calendar library codebase.

This patch is an excellent example that can be used in other parts of LibKGAPI. I couldn't find anything to point out, it is good for me.

Sat, Sep 21, 3:05 PM · KDE PIM

Sep 19 2019

barchiesi closed D23979: Add missing parameters to Permission related jobs and fix url typo..
Sep 19 2019, 9:09 AM · LibKGAPI, KDE PIM
barchiesi committed R477:4455efed2805: Add missing parameters to Permission related jobs and fix url typo. (authored by barchiesi).
Add missing parameters to Permission related jobs and fix url typo.
Sep 19 2019, 9:09 AM
barchiesi updated the diff for D23979: Add missing parameters to Permission related jobs and fix url typo..

Fixed minor nitpicks

Sep 19 2019, 9:07 AM · LibKGAPI, KDE PIM

Sep 18 2019

barchiesi updated the diff for D23979: Add missing parameters to Permission related jobs and fix url typo..

Remove debug info from permissions example.

Sep 18 2019, 4:51 PM · LibKGAPI, KDE PIM
barchiesi added a comment to D23979: Add missing parameters to Permission related jobs and fix url typo..

@dvratil I rechecked if Permission was complete and added missing attributes. Also added an example.

Sep 18 2019, 4:50 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D23979: Add missing parameters to Permission related jobs and fix url typo..

Added parameter default values to member initialization.

Sep 18 2019, 4:47 PM · LibKGAPI, KDE PIM

Sep 16 2019

barchiesi updated the diff for D23979: Add missing parameters to Permission related jobs and fix url typo..

That sounds like a better way of handling defaults, I'll keep it in mind when touching other Jobs.

Sep 16 2019, 1:26 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D23979: Add missing parameters to Permission related jobs and fix url typo..

Added missing derived class access-specifier to PermissionDeleteJob.

Sep 16 2019, 10:36 AM · LibKGAPI, KDE PIM

Sep 15 2019

barchiesi committed R219:3ffc3d41fe04: Add KFileItemActionPlugin for copying Google URL to clipboard. (authored by barchiesi).
Add KFileItemActionPlugin for copying Google URL to clipboard.
Sep 15 2019, 10:15 PM
barchiesi closed D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Sep 15 2019, 10:15 PM · KIO GDrive
barchiesi added a project to D23979: Add missing parameters to Permission related jobs and fix url typo.: LibKGAPI.
Sep 15 2019, 10:04 PM · LibKGAPI, KDE PIM
barchiesi requested review of D23979: Add missing parameters to Permission related jobs and fix url typo..
Sep 15 2019, 10:03 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Remove unnecessary includes, use QGuiApplication instead of QApplication, use QLatin1String for string comparison, fix name in service descriptor.

Sep 15 2019, 3:40 PM · KIO GDrive

Sep 14 2019

barchiesi added a project to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard.: KIO GDrive.
Sep 14 2019, 6:14 PM · KIO GDrive
barchiesi added inline comments to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Sep 14 2019, 5:49 PM · KIO GDrive
barchiesi updated the diff for D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Remove debug and gdriveurl dependency, renamed context menu entry.

Sep 14 2019, 5:48 PM · KIO GDrive
barchiesi updated the diff for D23804: Add Shared Drives to GDriveUrl slave..

Remove deprecated Q_FOREACH and use enum in fetchSharedDrivesRootEntry() arguments.

Sep 14 2019, 5:35 PM · KIO GDrive
barchiesi added inline comments to D23804: Add Shared Drives to GDriveUrl slave..
Sep 14 2019, 5:12 PM · KIO GDrive
barchiesi updated the diff for D23804: Add Shared Drives to GDriveUrl slave..

First round of fixes.

Sep 14 2019, 4:59 PM · KIO GDrive
barchiesi added inline comments to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Sep 14 2019, 9:12 AM · KIO GDrive
barchiesi updated the diff for D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

Removed unnecessary stat(), removed translations, replaced UDS_ALTERNATE_LINK_FIELD with UDS_EXTRA.

Sep 14 2019, 9:00 AM · KIO GDrive

Sep 11 2019

barchiesi added a comment to D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..

@elvisangelaccio care to answer the following?

Sep 11 2019, 10:20 AM · KIO GDrive
barchiesi requested review of D23874: Add KFileItemActionPlugin for copying Google URL to clipboard..
Sep 11 2019, 10:16 AM · KIO GDrive

Sep 9 2019

barchiesi added a comment to D23804: Add Shared Drives to GDriveUrl slave..

Here are some screenshots:

Sep 9 2019, 6:37 PM · KIO GDrive
barchiesi added a project to D23804: Add Shared Drives to GDriveUrl slave.: KIO GDrive.
Sep 9 2019, 6:36 PM · KIO GDrive
barchiesi requested review of D23804: Add Shared Drives to GDriveUrl slave..
Sep 9 2019, 6:02 PM · KIO GDrive
barchiesi committed R219:51a29231efa6: Merge branch 'master' into drives (authored by barchiesi).
Merge branch 'master' into drives
Sep 9 2019, 6:00 PM
barchiesi committed R219:f4d723270ce9: Fix mimeType loss during file creation or update. (authored by barchiesi).
Fix mimeType loss during file creation or update.
Sep 9 2019, 2:56 PM
barchiesi closed D22628: Fix mimeType loss during file creation or update..
Sep 9 2019, 2:56 PM · KIO GDrive

Jul 29 2019

barchiesi committed R477:f77a7391c1e8: Use mimeType from metadata instead of blindly re-determining it during uploads (authored by barchiesi).
Use mimeType from metadata instead of blindly re-determining it during uploads
Jul 29 2019, 8:46 AM
barchiesi closed D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.
Jul 29 2019, 8:46 AM · KDE PIM

Jul 28 2019

barchiesi updated the summary of D22628: Fix mimeType loss during file creation or update..
Jul 28 2019, 8:30 PM · KIO GDrive
barchiesi updated the diff for D22628: Fix mimeType loss during file creation or update..

Fixed above

Jul 28 2019, 8:29 PM · KIO GDrive
barchiesi added a comment to D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.

This change was inspired by D22628.

Jul 28 2019, 6:39 PM · KDE PIM
barchiesi added a dependency for D22628: Fix mimeType loss during file creation or update.: D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.
Jul 28 2019, 6:37 PM · KIO GDrive
barchiesi added a dependent revision for D22787: Use mimeType from metadata instead of blindly re-determining it during uploads: D22628: Fix mimeType loss during file creation or update..
Jul 28 2019, 6:37 PM · KDE PIM
barchiesi updated the summary of D22628: Fix mimeType loss during file creation or update..
Jul 28 2019, 6:37 PM · KIO GDrive
barchiesi updated the diff for D22628: Fix mimeType loss during file creation or update..

Adapted according to changes to LibKGAPI in D22787

Jul 28 2019, 6:31 PM · KIO GDrive
barchiesi requested review of D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.
Jul 28 2019, 6:27 PM · KDE PIM

Jul 26 2019

barchiesi added a comment to T10630: Show Team Drives.

I just created the branch named drives. Most if not all Shared Drives operations have been implemented if I'm not mistaken. I'm not convinced with the permission handling, I couldn't find a way to instruct Dolphin regarding special specific permissions (i.e. disable deleting a Shared Drive but allow adding files).

Jul 26 2019, 8:57 AM · KIO GDrive
barchiesi committed R219:23d663af96a2: Add Shared Drives support in KIOGDrive slave. (authored by barchiesi).
Add Shared Drives support in KIOGDrive slave.
Jul 26 2019, 8:52 AM
barchiesi committed R219:cb0b0d3c99b2: Add Shared Drives to GDriveUrl. (authored by barchiesi).
Add Shared Drives to GDriveUrl.
Jul 26 2019, 8:52 AM
barchiesi committed R219:dff65ecdcb74: Elide tokens in logs and clean up debug output. (authored by barchiesi).
Elide tokens in logs and clean up debug output.
Jul 26 2019, 8:50 AM
barchiesi closed D22565: Elide tokens in logs and clean up debug output..
Jul 26 2019, 8:50 AM · KIO GDrive

Jul 23 2019

barchiesi added inline comments to D22628: Fix mimeType loss during file creation or update..
Jul 23 2019, 10:26 PM · KIO GDrive

Jul 22 2019

barchiesi updated the diff for D22565: Elide tokens in logs and clean up debug output..

Reworded log messages for fileSystemFreeSpace() as noted in D22462.

Jul 22 2019, 9:36 AM · KIO GDrive

Jul 21 2019

barchiesi updated the diff for D22628: Fix mimeType loss during file creation or update..

Added dash in temporary file template.

Jul 21 2019, 8:58 PM · KIO GDrive
barchiesi updated the summary of D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 8:54 PM · KIO GDrive
barchiesi added inline comments to D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 8:35 PM · KIO GDrive
barchiesi committed R219:5fe660eeff78: Avoid calling finished() after error()" (authored by barchiesi).
Avoid calling finished() after error()"
Jul 21 2019, 8:25 PM
barchiesi closed D22462: Avoid calling finished() after error()".
Jul 21 2019, 8:25 PM · KIO GDrive
barchiesi updated the diff for D22462: Avoid calling finished() after error()".

Yeah :D

Jul 21 2019, 7:22 PM · KIO GDrive
barchiesi added a project to D22628: Fix mimeType loss during file creation or update.: KIO GDrive.
Jul 21 2019, 7:11 PM · KIO GDrive
barchiesi requested review of D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 7:08 PM · KIO GDrive

Jul 19 2019

barchiesi added a dependency for D22565: Elide tokens in logs and clean up debug output.: D22462: Avoid calling finished() after error()".
Jul 19 2019, 6:32 PM · KIO GDrive
barchiesi added a dependent revision for D22462: Avoid calling finished() after error()": D22565: Elide tokens in logs and clean up debug output..
Jul 19 2019, 6:32 PM · KIO GDrive
barchiesi added a project to D22565: Elide tokens in logs and clean up debug output.: KIO GDrive.
Jul 19 2019, 6:32 PM · KIO GDrive
barchiesi requested review of D22565: Elide tokens in logs and clean up debug output..
Jul 19 2019, 6:28 PM · KIO GDrive

Jul 18 2019

barchiesi updated the diff for D22462: Avoid calling finished() after error()".

Added doxygen for runJob() method.

Jul 18 2019, 7:29 AM · KIO GDrive

Jul 15 2019

barchiesi retitled D22462: Avoid calling finished() after error()" from Avoid calling finished() after error()" and add some debug output. to Avoid calling finished() after error()".
Jul 15 2019, 6:00 PM · KIO GDrive
barchiesi updated the diff for D22462: Avoid calling finished() after error()".

Removed debug output changes.

Jul 15 2019, 6:00 PM · KIO GDrive

Jul 14 2019

barchiesi added a project to D22462: Avoid calling finished() after error()": KIO GDrive.
Jul 14 2019, 10:23 PM · KIO GDrive
barchiesi requested review of D22462: Avoid calling finished() after error()".
Jul 14 2019, 10:23 PM · KIO GDrive

Jul 9 2019

barchiesi committed R477:ed9a2fb0ec3d: Uniform to using Utils::bool2Str(). (authored by barchiesi).
Uniform to using Utils::bool2Str().
Jul 9 2019, 2:52 PM
barchiesi closed D22318: Uniform to using Utils::bool2Str()..
Jul 9 2019, 2:52 PM · KDE PIM

Jul 8 2019

barchiesi committed R219:4ded388b2b26: Re get Google credentials from KAccounts when a refresh is needed. (authored by barchiesi).
Re get Google credentials from KAccounts when a refresh is needed.
Jul 8 2019, 7:54 AM
barchiesi closed D22009: Re get Google credentials from KAccounts when a refresh is needed..
Jul 8 2019, 7:54 AM
barchiesi updated the summary of D22318: Uniform to using Utils::bool2Str()..
Jul 8 2019, 7:52 AM · KDE PIM
barchiesi requested review of D22318: Uniform to using Utils::bool2Str()..
Jul 8 2019, 7:52 AM · KDE PIM
barchiesi committed R477:a8c97c1fd3f4: Add supportsAllDrives query parameter to FileAbstractModifyJob and… (authored by barchiesi).
Add supportsAllDrives query parameter to FileAbstractModifyJob and…
Jul 8 2019, 7:48 AM
barchiesi closed D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 8 2019, 7:48 AM · KDE PIM

Jul 7 2019

barchiesi updated the test plan for D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 7 2019, 12:55 PM · KDE PIM
barchiesi updated the diff for D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..

Moved supportsAllDrives from FileAbstractUploadJob to FileAbstractDataJob so both FileCopyJob and FileCreateJob benefit.

Jul 7 2019, 12:46 PM · KDE PIM