barchiesi (David Barchiesi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2019, 11:10 AM (25 w, 5 d)
Availability
Available

Recent Activity

Mon, Jul 29

barchiesi committed R477:f77a7391c1e8: Use mimeType from metadata instead of blindly re-determining it during uploads (authored by barchiesi).
Use mimeType from metadata instead of blindly re-determining it during uploads
Mon, Jul 29, 8:46 AM
barchiesi closed D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.
Mon, Jul 29, 8:46 AM · KDE PIM

Sun, Jul 28

barchiesi updated the summary of D22628: Fix mimeType loss during file creation or update..
Sun, Jul 28, 8:30 PM · KIO GDrive
barchiesi updated the diff for D22628: Fix mimeType loss during file creation or update..

Fixed above

Sun, Jul 28, 8:29 PM · KIO GDrive
barchiesi added a comment to D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.

This change was inspired by D22628.

Sun, Jul 28, 6:39 PM · KDE PIM
barchiesi added a dependency for D22628: Fix mimeType loss during file creation or update.: D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.
Sun, Jul 28, 6:37 PM · KIO GDrive
barchiesi added a dependent revision for D22787: Use mimeType from metadata instead of blindly re-determining it during uploads: D22628: Fix mimeType loss during file creation or update..
Sun, Jul 28, 6:37 PM · KDE PIM
barchiesi updated the summary of D22628: Fix mimeType loss during file creation or update..
Sun, Jul 28, 6:37 PM · KIO GDrive
barchiesi updated the diff for D22628: Fix mimeType loss during file creation or update..

Adapted according to changes to LibKGAPI in D22787

Sun, Jul 28, 6:31 PM · KIO GDrive
barchiesi requested review of D22787: Use mimeType from metadata instead of blindly re-determining it during uploads.
Sun, Jul 28, 6:27 PM · KDE PIM

Fri, Jul 26

barchiesi added a comment to T10630: Show Team Drives.

I just created the branch named drives. Most if not all Shared Drives operations have been implemented if I'm not mistaken. I'm not convinced with the permission handling, I couldn't find a way to instruct Dolphin regarding special specific permissions (i.e. disable deleting a Shared Drive but allow adding files).

Fri, Jul 26, 8:57 AM · KIO GDrive
barchiesi committed R219:23d663af96a2: Add Shared Drives support in KIOGDrive slave. (authored by barchiesi).
Add Shared Drives support in KIOGDrive slave.
Fri, Jul 26, 8:52 AM
barchiesi committed R219:cb0b0d3c99b2: Add Shared Drives to GDriveUrl. (authored by barchiesi).
Add Shared Drives to GDriveUrl.
Fri, Jul 26, 8:52 AM
barchiesi committed R219:dff65ecdcb74: Elide tokens in logs and clean up debug output. (authored by barchiesi).
Elide tokens in logs and clean up debug output.
Fri, Jul 26, 8:50 AM
barchiesi closed D22565: Elide tokens in logs and clean up debug output..
Fri, Jul 26, 8:50 AM · KIO GDrive

Jul 23 2019

barchiesi added inline comments to D22628: Fix mimeType loss during file creation or update..
Jul 23 2019, 10:26 PM · KIO GDrive

Jul 22 2019

barchiesi updated the diff for D22565: Elide tokens in logs and clean up debug output..

Reworded log messages for fileSystemFreeSpace() as noted in D22462.

Jul 22 2019, 9:36 AM · KIO GDrive

Jul 21 2019

barchiesi updated the diff for D22628: Fix mimeType loss during file creation or update..

Added dash in temporary file template.

Jul 21 2019, 8:58 PM · KIO GDrive
barchiesi updated the summary of D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 8:54 PM · KIO GDrive
barchiesi added inline comments to D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 8:35 PM · KIO GDrive
barchiesi committed R219:5fe660eeff78: Avoid calling finished() after error()" (authored by barchiesi).
Avoid calling finished() after error()"
Jul 21 2019, 8:25 PM
barchiesi closed D22462: Avoid calling finished() after error()".
Jul 21 2019, 8:25 PM · KIO GDrive
barchiesi updated the diff for D22462: Avoid calling finished() after error()".

Yeah :D

Jul 21 2019, 7:22 PM · KIO GDrive
barchiesi added a project to D22628: Fix mimeType loss during file creation or update.: KIO GDrive.
Jul 21 2019, 7:11 PM · KIO GDrive
barchiesi requested review of D22628: Fix mimeType loss during file creation or update..
Jul 21 2019, 7:08 PM · KIO GDrive

Jul 19 2019

barchiesi added a dependency for D22565: Elide tokens in logs and clean up debug output.: D22462: Avoid calling finished() after error()".
Jul 19 2019, 6:32 PM · KIO GDrive
barchiesi added a dependent revision for D22462: Avoid calling finished() after error()": D22565: Elide tokens in logs and clean up debug output..
Jul 19 2019, 6:32 PM · KIO GDrive
barchiesi added a project to D22565: Elide tokens in logs and clean up debug output.: KIO GDrive.
Jul 19 2019, 6:32 PM · KIO GDrive
barchiesi requested review of D22565: Elide tokens in logs and clean up debug output..
Jul 19 2019, 6:28 PM · KIO GDrive

Jul 18 2019

barchiesi updated the diff for D22462: Avoid calling finished() after error()".

Added doxygen for runJob() method.

Jul 18 2019, 7:29 AM · KIO GDrive

Jul 15 2019

barchiesi retitled D22462: Avoid calling finished() after error()" from Avoid calling finished() after error()" and add some debug output. to Avoid calling finished() after error()".
Jul 15 2019, 6:00 PM · KIO GDrive
barchiesi updated the diff for D22462: Avoid calling finished() after error()".

Removed debug output changes.

Jul 15 2019, 6:00 PM · KIO GDrive

Jul 14 2019

barchiesi added a project to D22462: Avoid calling finished() after error()": KIO GDrive.
Jul 14 2019, 10:23 PM · KIO GDrive
barchiesi requested review of D22462: Avoid calling finished() after error()".
Jul 14 2019, 10:23 PM · KIO GDrive

Jul 9 2019

barchiesi committed R477:ed9a2fb0ec3d: Uniform to using Utils::bool2Str(). (authored by barchiesi).
Uniform to using Utils::bool2Str().
Jul 9 2019, 2:52 PM
barchiesi closed D22318: Uniform to using Utils::bool2Str()..
Jul 9 2019, 2:52 PM · KDE PIM

Jul 8 2019

barchiesi committed R219:4ded388b2b26: Re get Google credentials from KAccounts when a refresh is needed. (authored by barchiesi).
Re get Google credentials from KAccounts when a refresh is needed.
Jul 8 2019, 7:54 AM
barchiesi closed D22009: Re get Google credentials from KAccounts when a refresh is needed..
Jul 8 2019, 7:54 AM
barchiesi updated the summary of D22318: Uniform to using Utils::bool2Str()..
Jul 8 2019, 7:52 AM · KDE PIM
barchiesi requested review of D22318: Uniform to using Utils::bool2Str()..
Jul 8 2019, 7:52 AM · KDE PIM
barchiesi committed R477:a8c97c1fd3f4: Add supportsAllDrives query parameter to FileAbstractModifyJob and… (authored by barchiesi).
Add supportsAllDrives query parameter to FileAbstractModifyJob and…
Jul 8 2019, 7:48 AM
barchiesi closed D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 8 2019, 7:48 AM · KDE PIM

Jul 7 2019

barchiesi updated the test plan for D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 7 2019, 12:55 PM · KDE PIM
barchiesi updated the diff for D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..

Moved supportsAllDrives from FileAbstractUploadJob to FileAbstractDataJob so both FileCopyJob and FileCreateJob benefit.

Jul 7 2019, 12:46 PM · KDE PIM

Jul 6 2019

barchiesi added a comment to T10630: Show Team Drives.

As per Google's new naming, Team Drives have been renamed to Shared Drives.

Jul 6 2019, 2:36 PM · KIO GDrive
barchiesi added a reviewer for D22009: Re get Google credentials from KAccounts when a refresh is needed.: elvisangelaccio.
Jul 6 2019, 2:23 PM
barchiesi added a comment to D22009: Re get Google credentials from KAccounts when a refresh is needed..

Looking at accounts-sso/signon-plugin-oauth2, it seems they switch to refreshing if a previous token request returned a refresh_token in the response (which should be our case).

Jul 6 2019, 2:22 PM
barchiesi updated subscribers of D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 6 2019, 12:50 PM · KDE PIM
barchiesi requested review of D22298: Add supportsAllDrives query parameter to FileAbstractModifyJob and FileAbstractDataJob jobs..
Jul 6 2019, 12:49 PM · KDE PIM
barchiesi updated the diff for D22009: Re get Google credentials from KAccounts when a refresh is needed..

Changed commit email address.

Jul 6 2019, 11:30 AM
barchiesi updated the diff for D22009: Re get Google credentials from KAccounts when a refresh is needed..

Fixed the const issues.

Jul 6 2019, 11:27 AM

Jul 3 2019

barchiesi committed R219:f81aed7bd13f: Remove useless FileFetchJob field specifications. Fixes D21838 related issues. (authored by barchiesi).
Remove useless FileFetchJob field specifications. Fixes D21838 related issues.
Jul 3 2019, 6:29 PM

Jul 2 2019

barchiesi committed R219:a13fb3e6fc80: Rename Team Drives to Shared Drives. Add hidden drives support. (authored by barchiesi).
Rename Team Drives to Shared Drives. Add hidden drives support.
Jul 2 2019, 10:39 AM
barchiesi committed R219:b46efa3d47f4: Add delete shared drive. (authored by barchiesi).
Add delete shared drive.
Jul 2 2019, 10:39 AM
barchiesi committed R219:9b65f0b3a6a0: wip (authored by barchiesi).
wip
Jul 2 2019, 10:39 AM

Jun 23 2019

barchiesi committed R477:1f2f38fa72c0: Add Drive resource and example. (authored by barchiesi).
Add Drive resource and example.
Jun 23 2019, 4:01 PM
barchiesi closed D21838: Add Drive resource and example..
Jun 23 2019, 4:01 PM · LibKGAPI, KDE PIM

Jun 22 2019

barchiesi updated subscribers of D22009: Re get Google credentials from KAccounts when a refresh is needed..

@elvisangelaccio We have a refresh token available that could be used but I couldn't find any information regarding refreshing an account through KAccounts. Do you know if such functionality is available? If not, would you perhaps know who I can reach out to?

Jun 22 2019, 6:36 PM
barchiesi requested review of D22009: Re get Google credentials from KAccounts when a refresh is needed..
Jun 22 2019, 6:32 PM

Jun 19 2019

barchiesi updated the diff for D21838: Add Drive resource and example..
  • Silence Team Drive deprecation warnings for examples and tests.

@dvratil this seems like a possible solution, what do you think?

Jun 19 2019, 10:56 PM · LibKGAPI, KDE PIM

Jun 17 2019

barchiesi added a comment to D21838: Add Drive resource and example..
  • Deprecate Teamdrive fetch/create/modify/delete jobs.

    I added KGAPIDRIVE_DEPRECATED_EXPORT to the create/delete/modify/fetch jobs and afterwards all tests and the teamdrive example show warnings. Is that correct? Or should I delete tests/examples?
Jun 17 2019, 3:05 PM · LibKGAPI, KDE PIM

Jun 16 2019

barchiesi updated the diff for D21838: Add Drive resource and example..

Fixing previous edit mistakes (not sure what happened, still trying to understand arc).

Jun 16 2019, 4:13 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D21838: Add Drive resource and example..
  • Added canCreateDrives attribute to About.
Jun 16 2019, 4:10 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D21838: Add Drive resource and example..

Renamed wrong attributes in Drives::Capabilities.

Jun 16 2019, 12:25 PM · LibKGAPI, KDE PIM
barchiesi added a project to D21838: Add Drive resource and example.: LibKGAPI.
Jun 16 2019, 11:31 AM · LibKGAPI, KDE PIM
barchiesi updated the diff for D21838: Add Drive resource and example..
  • Deprecate Teamdrive fetch/create/modify/delete jobs.
Jun 16 2019, 11:21 AM · LibKGAPI, KDE PIM
barchiesi added a comment to D21838: Add Drive resource and example..

In this revision I would like to also include deprecation notices/warnings on the Teamdrive resource, as it is officially deprecated by Google. What is the correct way to do this?

Jun 16 2019, 12:14 AM · LibKGAPI, KDE PIM
barchiesi requested review of D21838: Add Drive resource and example..
Jun 16 2019, 12:10 AM · LibKGAPI, KDE PIM

May 23 2019

barchiesi added a comment to D20843: Fix CMakeLists always building examples..

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

May 23 2019, 8:41 AM · LibKGAPI, KDE PIM
barchiesi closed D20843: Fix CMakeLists always building examples..
May 23 2019, 8:39 AM · LibKGAPI, KDE PIM
barchiesi committed R477:2fc71a173504: Fix CMakeLists always building examples. (authored by barchiesi).
Fix CMakeLists always building examples.
May 23 2019, 8:39 AM

May 22 2019

barchiesi updated the diff for D20843: Fix CMakeLists always building examples..

Changed (wrong) commit email address.

May 22 2019, 10:50 PM · LibKGAPI, KDE PIM

May 19 2019

barchiesi updated the diff for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.

Fixed

May 19 2019, 9:44 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Yes I did

May 19 2019, 9:43 PM · KIO GDrive
barchiesi abandoned D19948: DRAFT Add Standard Query Parameters support.

All changes have been covered by other differentials, this can be abandoned.

May 19 2019, 5:00 PM · LibKGAPI, KDE PIM
barchiesi set the repository for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities to R219 KIO GDrive.
May 19 2019, 4:58 PM · KIO GDrive
barchiesi updated the diff for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.

Updated after changes to D20064

May 19 2019, 4:58 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

You are correct, fixed those issues

May 19 2019, 4:54 PM · KIO GDrive

May 14 2019

barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

I bumped PIM_VERSION, but I'm not sure how versioning works in this project so I only increased the PATCH number.

May 14 2019, 8:00 AM · LibKGAPI, KDE PIM

May 1 2019

barchiesi set the repository for D20883: Apply Authorization headers in Job instead of in each Job implementation. to R477 KGAPI Library.
May 1 2019, 6:17 PM · KDE PIM, LibKGAPI
barchiesi set the repository for D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs. to R477 KGAPI Library.
May 1 2019, 6:17 PM · KDE PIM, LibKGAPI
barchiesi set the repository for D20886: Add fields standard query parameter to Job and use it in FileFetchJob. to R477 KGAPI Library.
May 1 2019, 6:16 PM · LibKGAPI, KDE PIM
barchiesi added a comment to D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

LibKGAPI 19.04 has full support for the Teamdrives REST API but unfortunately that isn't sufficient for completely manipulating them in KIO GDrive. The KIO GDrive patch for Team Drives that I'm working on requires this revision for querying if the user can create Team Drives and it requires D20789 for uploading files and finding parents. I'll probably find more stuff that needs to be added to LibKGAPI.
Therefore KIO GDrive won't be able to support Team Drives until LibKGAPI 19.08. As soon as I have most of the functionality ready, I will submit a revision so you can start looking at it.

May 1 2019, 6:05 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.

Add commit to revision.

May 1 2019, 5:29 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Add commit to revision.

May 1 2019, 5:28 PM · KIO GDrive
barchiesi added a dependency for D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities: D20064: Add usefull functions to GDriveUrl..
May 1 2019, 5:25 PM · KIO GDrive
barchiesi added a dependent revision for D20064: Add usefull functions to GDriveUrl.: D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
May 1 2019, 5:25 PM · KIO GDrive
barchiesi requested review of D20941: Refactor kio_gdrive to make use of new GDriveUrl functionalities.
May 1 2019, 5:25 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Maybe this time

May 1 2019, 5:19 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Got it.

May 1 2019, 5:16 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

I'm still new to phabricator, I hope this is what you meant.

May 1 2019, 5:07 PM · KIO GDrive
barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Updated after revision D20789 change.

May 1 2019, 4:57 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D20884: Add prettyPrint standard query parameter for all jobs except DELETE jobs..

Updated after revision D20789 change.

May 1 2019, 4:56 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20883: Apply Authorization headers in Job instead of in each Job implementation..

Updated after revision D20789 change.

May 1 2019, 4:53 PM · KDE PIM, LibKGAPI
barchiesi updated the summary of D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.
May 1 2019, 4:51 PM · KDE PIM, LibKGAPI
barchiesi updated the diff for D20789: Set supportsAllDrives and includeItemsFromAllDrives on requests that allow it.

Added the supportsAllDrives query param to other Jobs that can use it.

May 1 2019, 4:49 PM · KDE PIM, LibKGAPI

Apr 30 2019

barchiesi updated the summary of D20064: Add usefull functions to GDriveUrl..
Apr 30 2019, 1:00 PM · KIO GDrive
barchiesi updated the diff for D20064: Add usefull functions to GDriveUrl..

Added more functions and refactored KIOGDrive.

Apr 30 2019, 12:25 PM · KIO GDrive

Apr 29 2019

barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Since this changes the API, we must also bump the version in CMakeLists.txt. KIO GDrive will then have to have an #ifdef on LibKGAPI version to use either the old or the new approach, based on against what version of LibKGAPI it is compiled. This LibKGAPI API will not be publicly available until August (KDE Applications 19.08 release).

Another option is to have KIO GDrive master depend on the master of LibKGAPI and not doing any KIO GDrive release from master until LibKGAPI 19.08 is released (but I doubt @elvisangelaccio would be too happy about that :-) )

I guess we should let @elvisangelaccio decide, I believe the first approach is better because it allows building a newer KIO GDrive against older versions of LibKGAPI.

Apr 29 2019, 3:01 PM · LibKGAPI, KDE PIM
barchiesi updated the diff for D20886: Add fields standard query parameter to Job and use it in FileFetchJob..

Added Teamdrive field mappings.

Apr 29 2019, 11:52 AM · LibKGAPI, KDE PIM