src/backends/polkit-1/Polkit1Backend.cpp
203–204	(pre-existing) bad, very slow, creates a temp container just to iterate. for (auto it = m_cachedResults.begin(); it != m_cachedResults.end(); ++it) { const QString action = it.key(); if (it.value() != ....) { *it = ....; ... } }

This revision is now accepted and ready to land.Mar 2 2019, 11:16 PM

Closed by commit R283:cd7490e85008: Make it compile without foreach (authored by mlaurent). · Explain WhyMar 4 2019, 7:03 AM

This revision was automatically updated to reflect the committed changes.

FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake

On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine.

Undefined symbols for architecture x86_64:

"output(QList<Action> const&, QMap<QString, QString> const&)", referenced from:
    _main in policy-gen.cpp.o

ld: symbol(s) not found for architecture x86_64

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			src/BackendsManager.cpp (4 lines)
M			src/backends/polkit-1/Polkit1Backend.cpp (5 lines)
M			src/backends/polkit-1/kauth-policy-gen-polkit1.cpp (4 lines)
M			src/policy-gen/policy-gen.h (2 lines)
M			src/policy-gen/policy-gen.cpp (6 lines)