[KJots] Translate statusbar messages
ClosedPublic
Actions

Authored by poboiko on Apr 21 2020, 11:43 AM.

Details

Reviewers

pino
dvratil

Commits

R573:c2bae20a84ae: [KJots] Translate statusbar messages

Summary

Use i18nc to translate the statusbar messages showing link information

Test Plan

It compiles, the information is still shown

Repository

R573 KJots

Branch

translate-statusbar (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25594
Build 25612: arc lint + arc unit

poboiko requested review of this revision.Apr 21 2020, 11:43 AM

The actual i18n changes LGTM, thanks!

src/KJotsMain.cpp
30	no need for the prefix, <KLocalizedString> or <klocalizedstring.h> is fine

Remove include prefix

LGTM for me from an i18n POV, I'll let @dvratil give a final review/approval.

Thanks!

This revision is now accepted and ready to land.Apr 21 2020, 2:23 PM

			Path	Packages
M			src/KJotsMain.cpp (4 lines)
M			src/kjotspart.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80751	70e117f		Apr 21 2020, 11:43 AM	★	★
Diff 2	80757	70e117f	Remove include prefix	Apr 21 2020, 12:20 PM	★	★