Diffusion Minuet 32bf62a5f138

minuet: Update set's properties in fluid synth sound controller.
32bf62a5f138
Actions

Authored by carneirogustavo on Apr 27 2020, 3:51 AM.

Description

minuet: Update set's properties in fluid synth sound controller.

Signed-off-by: Gustavo Carneiro <gcarneiroa@hotmail.com>

Details

Committed
tcanabravaApr 27 2020, 8:12 AM
Parents
R163:25795551a6d1: Minuet: Add .vscode in .gitignore list to ignore the Visual Studio Code…
Branches
Unknown
Tags
Unknown
pino added subscribers: tcanabrava, pino.Apr 27 2020, 8:16 AM

@tcanabrava @carneirogustavo this change does not look correct to me: now both the setters are effectively no-op if the new values are different than the old ones.
Are you sure it was not meant to be if (m_foo == foo) return; instead?

tcanabrava added a subscriber: carneirogustavo.Apr 27 2020, 8:59 AM

You are right, that’s the problem of doing reviews barely asleep. Fixing.

tcanabrava added a comment.Apr 27 2020, 9:26 AM

@pino we are moving those to invent.

araujoluis added a subscriber: araujoluis.Apr 27 2020, 9:33 AM
In R163:32bf62a5f138ff4b6d6d15470220bd66c618a490#3894422, @pino wrote:

@tcanabrava @carneirogustavo this change does not look correct to me: now both the setters are effectively no-op if the new values are different than the old ones.
Are you sure it was not meant to be if (m_foo == foo) return; instead?

Thanks for the feedback, @tcanabrava has already guided me through the invent and I have already proceeded with the correction.

Changes (1)

PathPackages
Msrc/plugins/fluidsynthsoundcontroller/fluidsynthsoundcontroller.cpp

R163:32bf62a5f138

View Options

src/plugins/fluidsynthsoundcontroller/fluidsynthsoundcontroller.cpp

Loading...