| dfaure |
| Konqueror | |
| Plasma |
The plugin is ported to use Qt5 and KF5, including:
Note that a fix for D28647 needs to be incorporated into KIO, as otherwise the user agent can only be changed once.
Built Konqueror with this change and the initial fix from D28647. Tested with https://kluge.in-chemnitz.de/tools/browser.php to demonstrate that selecting a user agent from the menu changes the resulting HTTP header sent.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| plugins/uachanger/uachangerplugin.cpp | ||
|---|---|---|
| 39 | (not needed) | |
| 98 | Are you sure the KConfigGroup keeps the KSharedConfig alive? It would be good if it did, but I'm not sure it does. Any reason not to use QLocale().uiLanguages()? | |
| 256 | (wow that was broken) | |
| 394 | could be const too | |
| 396 | Please use return hostname; without parenthesis. return isn't a function. | |
| 401 | same | |
| plugins/uachanger/uachangerplugin.cpp | ||
|---|---|---|
| 96–104 | please use KLocalizedString::languages() instead | |
| plugins/uachanger/uachangerplugin.cpp | ||
|---|---|---|
| 385 | QUrl u; u.setScheme("http"); u.setHostName(hostname); would be better in case of special characters in the hostname. | |