| mart | |
| apol | |
| sitter | |
| bcooksley |
| Frameworks |
Setting XDG_DATA_DIRS in the ENVIRONMENT property using
"XDG_DATA_DIRS=/path:$XDG_DATA_DIRS" has two flaws
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Small disadvantage of the current code is that this binds things to the value of XDG_DATA_DIRS at "cmake" runtime, not "make test" runtime. That would need the move of the env var setting into kpackagetoolappstreamtest.cmake I guess. Tell if you think that is important.
(Commented in the wrong place)
Shouldn't the test completely ignore the system location, to avoid interferences from the system installation?
The failure which triggered this patch is that appstreamcli or one of the things it links to (since recently?) wants to use some gsettings stuff, which it tries to look up in the system via XDG_DATA_DIRS, as found by sitter.
See https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/96/testReport/projectroot/autotests/testpackage_appstream/
The old code tried to still make any existing XDG_DATA_DIRS content used, just in a broken way. Which this patch fixes. Or: I do not take further responsibilities :P
If that setup is broken/questionable by design, could be possible, did not investigate that, leaving to the actual kpackage maintainers/experts.