Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

Authored by kossebau on Apr 21 2020, 4:35 PM.

Description

Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

Summary:
Setting XDG_DATA_DIRS in the ENVIRONMENT property using
"XDG_DATA_DIRS=/path:$XDG_DATA_DIRS" has two flaws

  • the value string is not evaluated e.g. by a shell but set directly, so $XDG_DATA_DIRS will stay verbatim
  • if XDG_DATA_DIRS was not set before, setting it now will trigger the rules to use the default /usr/local/share & /usr/share only if XDG_DATA_DIRS is not set, thus effectively removing these dirs now

Reviewers: Frameworks, mart, apol, sitter, bcooksley

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D29063

Details

Committed
kossebauApr 22 2020, 7:04 AM
Reviewer
apol
Differential Revision
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
Parents
R290:e0066f850b2c: GIT_SILENT Upgrade KF5 version to 5.70.0.
Branches
Unknown
Tags
Unknown
pino added a subscriber: pino.Apr 22 2020, 7:09 AM

Shouldn't the test completely ignore the system location, to avoid interferences from the system installation?