Differential D29195

Add AppStream file
ClosedPublic
Actions

Authored by ognarb on Apr 26 2020, 11:49 AM.

Details

Reviewers
niccolove
Commits
R1050:a3d091632ac4: Add AppStream file

Diff Detail

Repository
R1050 BasKet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb requested review of this revision.Apr 26 2020, 11:49 AM
ognarb created this revision.
niccolove accepted this revision.Apr 26 2020, 12:24 PM
This revision is now accepted and ready to land.Apr 26 2020, 12:24 PM
Closed by commit R1050:a3d091632ac4: Add AppStream file (authored by ognarb). · Explain WhyApr 26 2020, 6:14 PM
This revision was automatically updated to reflect the committed changes.
pino added a subscriber: pino.Apr 26 2020, 6:15 PM

Is the change to GenericName intentional?

ognarb added a comment.Apr 26 2020, 6:18 PM
In D29195#657788, @pino wrote:

Is the change to GenericName intentional?

Yes, we discussed a bit in the promo group that could be a better name for the generic name and summary. But if you thing "Multi-Purpose Notepad" was better I guess I could revert this change.

pino added a comment.Apr 26 2020, 6:24 PM

My concern is that this change is about adding an AppStream file, with no mention of other changes to the desktop file. So it is not clear (especially when looking at this after some time) whether the change was somehow related (which doesn't look like), or maybe it was a local change for testing that slipped in while committing.

Revision Contents
Changeset List

Diff 81272

View Options

src/CMakeLists.txt

Loading...
View Options

src/org.kde.basket.appdata.xml

Loading...
View Options

src/org.kde.basket.desktop

Loading...