[kcm] Fix label
Needs ReviewPublic

Authored by shubham on May 1 2020, 4:21 PM.

Details

Summary

BUG: 420563

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
shubham created this revision.May 1 2020, 4:21 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 1 2020, 4:21 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
shubham requested review of this revision.May 1 2020, 4:21 PM
pino added a subscriber: pino.May 1 2020, 4:47 PM

The accelerator is correct to use, as it will activate the buddy associated to to label... which is wrong, as quickTileLabel does not exist.
Did you try changing the buddy of quickTileLabel to kcfg_ElectricBorderTiling?

zzag requested changes to this revision.May 3 2020, 4:44 PM
zzag added inline comments.
kcmkwin/kwinscreenedges/main.ui
87

It must be kcfg_ElectricBorderTiling rather than quickTileBox.

This revision now requires changes to proceed.May 3 2020, 4:44 PM
shubham updated this revision to Diff 82109.May 6 2020, 2:51 PM
shubham marked an inline comment as done.

Corrections

pino requested changes to this revision.May 6 2020, 3:11 PM

Please read what @zzag and me wrote: you must fix the buddy of the label widget, not its name.

This revision now requires changes to proceed.May 6 2020, 3:11 PM
crossi added a subscriber: crossi.May 6 2020, 4:55 PM
shubham updated this revision to Diff 83205.Jun 3 2020, 8:25 AM
zzag accepted this revision.Jun 3 2020, 8:53 AM
zzag added a comment.Jun 3 2020, 8:56 AM

Push it to Plasma/5.19, please.

@zzag How do I close this revision and also will the bug will get close itself?

zzag added a comment.Jun 3 2020, 9:25 AM

Re: Commit subject line

Please use more descriptive subject lines and put the BUG keyword in the commit message.

How do I close this revision and also will the bug will get close itself?

Since the commit message doesn't have a link to this revision, I guess the only option is to abandon it?

zzag added a comment.Jun 3 2020, 9:49 AM

This commit broke Plasma/5.19 branch.

We've filed a sysadmin request to reset Plasma/5.19 to the latest good commit (1a50c98f4a99bce3363561b953ff8d92b8f1a33a).

zzag added a comment.Jun 3 2020, 10:00 AM

Plasma/5.19 has been reset. Can you please create a merge request on invent.kde.org/plasma/kwin that fixes bug 420563?

This comment was removed by shubham.