| dvratil |
Previously, it copied an internal Akonadi url (i.e. akonadi://?item=...),
which isn't recognized with KJots. Use newly introduced KJotsModel::UrlRole instead.
The pasting code (KJotsEdit) did not cope well with unicode
(it was converted to QLatin1String before pasting), fixed that as well.
Also, used QStringLiteral instead of QLatin1String for methods that don't have QLatin1String overload.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/kjotstreeview.cpp | ||
|---|---|---|
| 179 | Does this actually need to be localized? There's nothing to localize, really :) | |
| src/kjotstreeview.cpp | ||
|---|---|---|
| 179 | I thought so too at first. But then, @pino asked me about localizing string like "%1 -> %2", so now I'm a bit afraid :) Is there some sort of a guide or a checklist of stuff which one has to store in head when translating messages? :) | |
| src/kjotstreeview.cpp | ||
|---|---|---|
| 179 | "%1 -> %2" needed to be translatable because it is more than a simple "show this metadata to the user", and there is some room for adaptation by translation teams according to their language (say use an unicode arrow, or even show a text in case the arrow doesn't make sense for a language) in this case i'd say there is nothing to translate, as you are showing directly the title of a book as title for a link. | |
| src/kjotstreeview.cpp | ||
|---|---|---|
| 179 | OK, haven't thought of it actually. It makes sense, thanks! | |