Feed Advanced Search

Tue, Jan 21

pino committed R262:641894df045c: fixuifiles (authored by pino).
fixuifiles
Tue, Jan 21, 4:36 AM

Mon, Jan 13

pino added a comment to D25482: Port from KFileDialog to QFileDialog..

Shouldn't KFileCustomDialog be used instead?

Mon, Jan 13, 10:51 PM

Sat, Jan 11

pino committed R883:1559935: updates.
updates
Sat, Jan 11, 2:03 PM
pino committed R883:1559904: typo fix.
typo fix
Sat, Jan 11, 8:31 AM

Fri, Jan 10

pino committed R883:1559880: copy from trunk.
copy from trunk
Fri, Jan 10, 11:23 PM
pino added inline comments to D8208: Add Duplicate feature.
Fri, Jan 10, 9:43 AM · Dolphin
pino committed R473:1ab68a46529e: Remove extra quotes from Name (authored by pino).
Remove extra quotes from Name
Fri, Jan 10, 7:47 AM

Tue, Jan 7

pino committed R166:c45853234b5d: Merge remote-tracking branch 'origin/release/19.12' (authored by pino).
Merge remote-tracking branch 'origin/release/19.12'
Tue, Jan 7, 10:18 PM
pino committed R166:655a5a536d98: tests: make sure testNumbering works (authored by pino).
tests: make sure testNumbering works
Tue, Jan 7, 10:16 PM

Mon, Jan 6

pino committed R978:e65c077f5baa: Merge remote-tracking branch 'origin/release/19.12' (authored by pino).
Merge remote-tracking branch 'origin/release/19.12'
Mon, Jan 6, 7:44 PM
pino committed R978:4552c2fb4ce7: Improve appdata file (authored by pino).
Improve appdata file
Mon, Jan 6, 7:40 PM

Sun, Jan 5

pino committed R52:dda2e6e7303c: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Sun, Jan 5, 12:51 PM
pino committed R52:5fb100627264: Update phpfunctions.php to phpdoc revision 348802 (authored by pino).
Update phpfunctions.php to phpdoc revision 348802
Sun, Jan 5, 12:51 PM

Sat, Jan 4

pino committed R883:1559487: copy subtitlecomposer.po from trunk/l10n-kf5.
copy subtitlecomposer.po from trunk/l10n-kf5
Sat, Jan 4, 3:55 PM
pino added inline comments to D26358: KIO/SMB convert kio protocol declaration to json format.
Sat, Jan 4, 12:52 PM · Frameworks, Dolphin
pino added a comment to D26410: Port KLanguageButton from KConfig to QSettings.

IIRC KConfigGroup::readEntry() reads the translated version of the key, and every kf5_entry.desktop` has such translations. QSettings does not do that.

Sat, Jan 4, 12:18 PM · Frameworks

Thu, Jan 2

pino committed R220:e70ef6f2fe30: Merge remote-tracking branch 'origin/2.1' (authored by pino).
Merge remote-tracking branch 'origin/2.1'
Thu, Jan 2, 10:33 PM
pino committed R220:f80abcaa5953: appstream: sort releases from newer to older (authored by pino).
appstream: sort releases from newer to older
Thu, Jan 2, 10:33 PM

Mon, Dec 30

pino committed R469:5cfa97253928: appdata: fix <translation> (authored by pino).
appdata: fix <translation>
Mon, Dec 30, 8:38 AM

Sun, Dec 29

pino committed R883:1559137: update.
update
Sun, Dec 29, 6:18 PM
pino added a comment to D26273: cmake: don't use taglib-config if we are cross compiling.

Or maybe switch this module to use pkg-config as primary way to detect taglib, falling back to taglib-config only when the pkg-config file is not available.

Sun, Dec 29, 1:07 PM · Baloo, Frameworks

Dec 29 2019

pino committed R40:eb0f19dfbb44: lsp: update info of OCaml server (authored by pino).
lsp: update info of OCaml server
Dec 29 2019, 8:57 AM

Dec 28 2019

pino added inline comments to D24932: Add button to open the folder in filelight to view more details.
Dec 28 2019, 6:37 PM · Frameworks

Dec 16 2019

pino committed R246:e6fd2c5cabf9: Fix typos in API docs (authored by pino).
Fix typos in API docs
Dec 16 2019, 8:25 PM

Dec 9 2019

pino committed R883:1557905: fix typos.
fix typos
Dec 9 2019, 6:23 AM

Dec 8 2019

pino requested changes to D25333: scripty: Look for helper scripts in the current script's parent directory.

There are various issues here:

  • we are touching even branches that are dead or in maintenance mode, which means an high risk of issues
  • the same 4 lines of patterns is repeated over and over
  • the way to get the directory of a script is overly verbose, using realpath is way easier/faster...
Dec 8 2019, 4:48 PM
pino added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.

Nice start.

Dec 8 2019, 4:42 PM · Localization
pino committed R262:438822673081: fixuifiles (authored by pino).
fixuifiles
Dec 8 2019, 7:49 AM

Dec 3 2019

pino committed R40:2e212576821d: Make the strings translatable, fix typo (authored by yurchor).
Make the strings translatable, fix typo
Dec 3 2019, 6:31 PM

Dec 1 2019

pino added a comment to D25643: Use PERL_EXECUTABLE on all platforms.

Duplicate of D25638: autotests: Find perl executable on all platforms.

Dec 1 2019, 7:22 AM · KDE PIM

Nov 30 2019

pino added inline comments to D25640: RDP: Warn if trying to share a non existing folder.
Nov 30 2019, 11:23 PM

Nov 29 2019

pino committed R883:1557245: updates.
updates
Nov 29 2019, 4:51 AM

Nov 27 2019

pino committed R883:1557101: fix typos.
fix typos
Nov 27 2019, 9:54 PM
pino committed R883:1557100: fix typos.
fix typos
Nov 27 2019, 9:49 PM
pino committed R883:1557088: update.
update
Nov 27 2019, 6:40 PM
pino committed R883:1557071: updates.
updates
Nov 27 2019, 7:31 AM

Nov 23 2019

pino added a comment to D25484: Enable closing a tab by middle click.
In D25484#566477, @pino wrote:

Do people frequently misclick with the middle mouse button?

It can happen, and more often with a touchpad.

I hadn't considered that. By default, you have to tap with 3 fingers to middle click. What are you doing with the touchpad when this happens? [...]

Nov 23 2019, 11:08 AM · Okular
pino added a comment to D25484: Enable closing a tab by middle click.

Do people frequently misclick with the middle mouse button?

Nov 23 2019, 10:33 AM · Okular
pino committed R883:1556785: updates.
updates
Nov 23 2019, 10:10 AM
pino added a comment to D25484: Enable closing a tab by middle click.

Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document).

Nov 23 2019, 9:55 AM · Okular
pino committed R883:1556779: updates.
updates
Nov 23 2019, 8:41 AM
pino committed R883:1556774: updates.
updates
Nov 23 2019, 8:29 AM

Nov 21 2019

pino committed R20:b7e93f563027: i18n fixes (authored by pino).
i18n fixes
Nov 21 2019, 8:27 AM

Nov 20 2019

pino added inline comments to D25405: Fix Step infobrowser and examples localization.
Nov 20 2019, 10:48 PM · KDE Edu
pino committed R476:e521f16545b2: remove reviewboard configuration (authored by pino).
remove reviewboard configuration
Nov 20 2019, 6:04 AM

Nov 19 2019

pino added a comment to R1045:426d362cf6b0: i18n: remove rc.cpp only after xgettext.

Behaviour did not change, however I think the former version was more bulletproof.

Nov 19 2019, 6:24 PM
pino committed R883:1556555: remove old obsolete messages.
remove old obsolete messages
Nov 19 2019, 12:19 PM
pino committed R1045:426d362cf6b0: i18n: remove rc.cpp only after xgettext (authored by pino).
i18n: remove rc.cpp only after xgettext
Nov 19 2019, 12:13 PM

Nov 17 2019

pino added a comment to R883:1556373: Import kup translations (all but 'tl').

Import kup translations (all but 'tl')

... and enable extraction.
tl (Tagalog) has not been imported for now
because we don't have any other translation for it.

Nov 17 2019, 4:09 PM
pino committed R169:f9700eea16eb: i18n: extract messages also from C++ sources (authored by pino).
i18n: extract messages also from C++ sources
Nov 17 2019, 11:18 AM
pino committed R7:3bf5270d130f: Merge remote-tracking branch 'origin/1.7' (authored by pino).
Merge remote-tracking branch 'origin/1.7'
Nov 17 2019, 7:24 AM
pino committed R7:44ffe6ca1491: Remove extra Python shebang (authored by pino).
Remove extra Python shebang
Nov 17 2019, 7:24 AM

Nov 16 2019

pino added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.
In T4803#208465, @pino wrote:
  1. Import the 5 branches (*/l10n-kf5*/scripts and */l10n-kde4/scripts) to Git as subling directories:
    • branches_stable_l10n-kde4

Ugh no, please import them as branches, as they actually are.

As a counter-argument to this statement, I'm going to explain why */l10n-kf5*/ and */l10n-kde4/ are not real branches. Even though the various scripts/ directories are stored under branches/stable/ and trunk/ in SVN, they are not used as branches anymore.

Nov 16 2019, 10:34 PM · Localization
pino added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.
  1. Import the 5 branches (*/l10n-kf5*/scripts and */l10n-kde4/scripts) to Git as subling directories:
    • branches_stable_l10n-kde4
    • branches_stable_l10n-kf5
    • branches_stable_l10n-kf5-plasma-lts
    • trunk_l10n-kde4
    • trunk_l10n-kf5
Nov 16 2019, 5:22 PM · Localization
pino committed R321:b566a2ad4b75: appdata: update homepage and help URLs (authored by pino).
appdata: update homepage and help URLs
Nov 16 2019, 11:33 AM

Nov 15 2019

pino committed R470:f90e7f21a85e: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Nov 15 2019, 9:55 PM
pino committed R470:dd03ad35f053: appdata: sort versions by most recent ones (authored by pino).
appdata: sort versions by most recent ones
Nov 15 2019, 9:49 PM
pino committed R1026:22db12512239: cmake: remove zlib requirement (authored by pino).
cmake: remove zlib requirement
Nov 15 2019, 9:28 PM

Nov 10 2019

pino requested changes to D24987: Add Kompare as compare application with KIO support.

Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.

Nov 10 2019, 5:26 PM · Krusader

Nov 9 2019

pino committed R52:35d7813028e9: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Nov 9 2019, 3:21 PM
pino committed R52:983e9994e5f5: Update phpfunctions.php to phpdoc revision 348276. (authored by pino).
Update phpfunctions.php to phpdoc revision 348276.
Nov 9 2019, 3:20 PM

Nov 6 2019

pino committed R488:35862f3ac002: cmake: remove use of old PHONON_BUILD_PHONON4QT5 (authored by pino).
cmake: remove use of old PHONON_BUILD_PHONON4QT5
Nov 6 2019, 7:06 PM

Nov 5 2019

pino committed R482:485697525619: i18n: "Ok" -> "OK" (authored by pino).
i18n: "Ok" -> "OK"
Nov 5 2019, 6:49 AM

Nov 2 2019

pino requested changes to D24987: Add Kompare as compare application with KIO support.
Nov 2 2019, 10:48 PM · Krusader

Oct 31 2019

pino added a comment to D25095: Include fixx11.h to fix the build with Qt 5.14.

Not sure if that makes it worth to depend on KWindowSystem, or if it's maybe better to copy the header over.

Oct 31 2019, 6:03 PM
pino added a comment to D25095: Include fixx11.h to fix the build with Qt 5.14.

IMHO:

  • moving includes like this is more an hack than a real solution, as future changes in other Qt includes may cause this issue again -- see also the comment right before the phonon include...
  • the real solution is to #include <fixx11h.h> right after the X11 includes -- see the KWindowSystem framework
Oct 31 2019, 4:55 PM
pino committed R71:59ca6b5858b7: add override where needed (authored by pino).
add override where needed
Oct 31 2019, 7:49 AM
pino committed R71:18cbb5c92bad: Q_DECL_OVERRIDE -> override (authored by pino).
Q_DECL_OVERRIDE -> override
Oct 31 2019, 7:49 AM
pino committed R71:1881c071635e: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Oct 31 2019, 7:30 AM
pino committed R71:66f7d02bfa02: Q_DECL_OVERRIDE -> override (authored by pino).
Q_DECL_OVERRIDE -> override
Oct 31 2019, 7:11 AM
pino committed R71:4f8f15669e39: add override where needed (authored by pino).
add override where needed
Oct 31 2019, 7:11 AM

Oct 29 2019

pino committed R1026:f906c1066582: appdata: switch http URLs to https (authored by pino).
appdata: switch http URLs to https
Oct 29 2019, 11:16 AM
pino committed R15:33646b3455dc: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Oct 29 2019, 7:07 AM
pino committed R15:40cdaea4d782: PgSQL driver: fix build with PostgreSQL 12+ (authored by pino).
PgSQL driver: fix build with PostgreSQL 12+
Oct 29 2019, 6:53 AM

Oct 25 2019

pino added a comment to D24476: [KPropertiesDialog] Only show volume-related info for volumes.

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Don't you already have the free space information in the status bar though?

Oct 25 2019, 10:08 PM · Frameworks

Oct 24 2019

pino committed R458:9bf4f87ea55d: cmake: build/run tests only when enabled (authored by pino).
cmake: build/run tests only when enabled
Oct 24 2019, 6:11 PM

Oct 22 2019

pino committed R216:e292f14be062: debchangelog: add Focal Fossa (authored by pino).
debchangelog: add Focal Fossa
Oct 22 2019, 7:26 PM

Oct 12 2019

pino committed R226:b5d81938d345: Merge remote-tracking branch 'origin/Applications/19.08' (authored by pino).
Merge remote-tracking branch 'origin/Applications/19.08'
Oct 12 2019, 3:10 PM
pino committed R226:9119e90c00eb: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 (authored by stefanocrocco).
Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12
Oct 12 2019, 3:10 PM
pino committed R238:4a7d60c5cc90: man: use <arg> instead of <group> (authored by pino).
man: use <arg> instead of <group>
Oct 12 2019, 10:41 AM
pino committed R7:c01d1b6e4501: Merge remote-tracking branch 'origin/1.7' (authored by pino).
Merge remote-tracking branch 'origin/1.7'
Oct 12 2019, 6:31 AM
pino committed R7:d4d694b895ef: appdata: use https for URLs (authored by pino).
appdata: use https for URLs
Oct 12 2019, 6:28 AM

Oct 10 2019

pino committed R13:36a0a63a9659: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Oct 10 2019, 5:41 AM
pino committed R13:e1bdc4e6e857: Restore KPropertyDoubleSpinBox::resizeEvent() override (authored by pino).
Restore KPropertyDoubleSpinBox::resizeEvent() override
Oct 10 2019, 5:40 AM

Oct 5 2019

pino committed R1026:a18049be089f: fixuifiles (authored by pino).
fixuifiles
Oct 5 2019, 4:31 AM

Oct 2 2019

pino added inline comments to D7446: [Places panel] Revamp the Recently Saved section.
Oct 2 2019, 8:23 PM · Frameworks, Dolphin

Oct 1 2019

pino committed R883:1552885: typo fix.
typo fix
Oct 1 2019, 4:13 PM
pino committed R39:34d82c0eabe0: i18n: use translated section names of highlight defs (authored by pino).
i18n: use translated section names of highlight defs
Oct 1 2019, 4:03 PM
pino committed R39:7c8e51feebbe: i18n: translate placeholder (authored by pino).
i18n: translate placeholder
Oct 1 2019, 4:03 PM
pino committed R216:1873102570c5: i18n: fix context for the "None" definition (authored by pino).
i18n: fix context for the "None" definition
Oct 1 2019, 4:08 AM

Sep 27 2019

pino committed R40:d6f9923063b4: fixuifiles (authored by pino).
fixuifiles
Sep 27 2019, 4:37 AM

Sep 24 2019

pino added a comment to T11721: Splitting of i18n strings.

! In T11721#201558, @romangg wrote:
If not via newlines could it be possible to make it work by combining strings with +? Like:

i18n("Lorem ipsum dolor sit amet, consectetur adipisici elit, " +
     "sed eiusmod tempor incidunt ut labore et dolore magna aliqua.")

Not sure why this doesn't work at the moment. Is it because of this xgettext tool?

Sep 24 2019, 4:15 AM · Localization, Kirigami, Plasma

Sep 23 2019

pino added a comment to D24154: Add comment to desktop file for KRuler.

Also, please write why a Comment was added, especially that the referenced bug does not explain that either.

Sep 23 2019, 4:38 AM

Sep 22 2019

pino requested changes to D24140: Internationalize the default project name in the title bar.
Sep 22 2019, 3:29 PM
pino added a comment to D24140: Internationalize the default project name in the title bar.

I do not think this solution is correct. The project ID is set by the user, so translating it with i18n() will simply not work.

Sep 22 2019, 3:29 PM

Sep 21 2019

pino added inline comments to D23579: port ftp slave to new error reporting system.
Sep 21 2019, 5:48 AM · Frameworks

Sep 20 2019

pino added a comment to T11721: Splitting of i18n strings.

BTW, since the "100 characters per line" was brought as single argument, let's actually check what the KDE Frameworks Coding Style actually say.
Quoting bits from https://techbase.kde.org/Policies/Frameworks_Coding_Style (emphases mine):

Sep 20 2019, 6:02 AM · Localization, Kirigami, Plasma

Sep 19 2019

pino committed R104:6ae066c02573: i18n fixes (authored by pino).
i18n fixes
Sep 19 2019, 4:39 AM
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

@aspotashev: please read the discussion in this review request...

Sep 19 2019, 3:32 AM · Plasma

Sep 17 2019

pino added a comment to D23815: [KConfig] port away from deprecated methods in Qt 5.14.

If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs.
This is easy to do: if (EXISTS "${CMAKE_SOURCE_DIR}/.git").

Sep 17 2019, 4:38 AM · Frameworks