So I've got a +1 from VDG. Any opinions from someone in Plasma?

Ping.

In D11880#328630, @ndavis wrote:

Panic mode in FirewallD is not worse than Error. Panic mode is enabled by the user. It is something that the user enables when they need to stop all network traffic to the system.

In D13315#328252, @miklosm wrote:

There may be an other solution to the problem I was trying to solve with this patch series: remove the jpeg thumbnailer, and let the generic image thumbnailer handle jpeg as well.

@broulik, any chance you could help out with the code review for this? My sense is that a lot of people would really love touch support in Dolphin.

Oops, it looks like this patch totally got missed, sorry!

Looks like the dependencies have been committed and we've branched for 5.14. Plasma folks/@davidedmundson, does this look good to land now?

Data structures are not really my forte, but I had a look. It seems possible but rather complicated due to the way the models populate and update themselves and return data. I'd like to see what @apol has to say.

Any update on this, @nicolasfella?

We generally try to operate on the principle of consensus here in the KDE community, so if there's a disagreement, we talk about it until someone changes their mind or we arrive at a compromise.

In D15579#328254, @cfeck wrote:

Does the hit-box match the highlight region? Please also test with wide icon texts.

Tried this out and there's a little problem: the underline looks bad for us low-DPI folks. It takes a chunk out of the bottom edge of the highlight:

OK then! :)

Hmm, looks like Calligra already has code that does some of this: https://cgit.kde.org/calligra.git/tree/extras/thumbnail/calligracreator.cpp.

Hmm, yeah, we need to make sure to not even try to generate thumbnails for password-protected files. Good catch, @jtamate

Wow, that's pretty simple.

Sorry for the extended review time. It's just not the same since @rkflx left :(

+1 to always reducing the interval to one minute.

Oh well. :) The code looks sane and I can't find any regressions for when not using your proprietary Xorg extension, so if this fixes the issue for you, feel free to push it.

@broulik, given your recent crusade against blocking calls, can you think of a better way to do this?

@miklosm, can this go in now, or it is dependent on either of your other two patches?

In D15059#327703, @utecht wrote:

How about I remove all the settings UI changes, the configuration manager changes, move the sequential numbering to the export manager, and let the sequential numbering reset to 1 with every relaunch to keep it simple? If users accidentally close the application, they can clean up the numbering manually in a file manager.

Technically that is correct--Breeze widget theme vs Breeze Plasma theme. But from a user perspective, it's a needless inconsistency. The fact that Folder view is a Plasma widget rather than an extension of Dolphin is an implementation detail lost on people who aren't power users or developers. And even for someone who understands the distinction, they might (not unreasonably) think, Why should the Breeze widget theme look different from the Breeze Plasma theme? Aren't they both Breeze?

In D15579#327686, @broulik wrote:

It might be nice to round the corners a bit, if that's not too hard--and then make the same change for the open/save dialogs too.

That's governed by the widget style. Breeze uses square corners, Oxygen, for instance uses round ones, so doing that should be easy, and will affect all places, so any change there must be done carefully.

+1 because this makes Dolphin's Icon View visually consistent with the file open/save dialogs, and at least conceptually consistent with Folder View, which also uses a full-sized highlight (even though it looks different there).

Action item 1 (add background): https://bugs.kde.org/show_bug.cgi?id=398742

Yes, but they still hadn't approved the current version. :)

@shubham, in the future, when there are still reviewers who have marked their status as "Request Changes", please wait for them to approve before pushing.

@mmustac, I believe I've addressed your concern now.

Adjust top margin on Favorites view to make sure that the top item doesn't touch the new line

The SDDM Breeze theme is color aware and has the ability to request dark or light icons. But the point of this endeavor is that we won't need to care about the SDDM background image as long as the icon brings its own background. In the worst case scenario where the image background is the same color as the icon background, the symbol contained therein will still be visible. But to make it really bulletproof, we could outline the circular background with the opposite color to always provide the needed contrast.

I agree that supporting 3rd-party themes shouldn't drive our design decisions. At the same time, it also shouldn't be ignored.

@davidedmundson ping.

We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a directory. Adjusting the code here to know those pieces of information not easily possible and would involve patches to multiple other repos--and it's also out of scope for this patch. :)

That's better:

In T9444#160228, @filipf wrote:

It does mean in this case however that you have these same icons in Kicker, Kickoff etc.

Perfect, thanks! I did some investigation and this oddly-formed string is actually built by KIO itself, in core/job_error.cpp:

Yay, it works now! If I try to copy a folder that is too big, it stops immediately before anything happens, and the following is displayed in Dolphin:

You forgot the error line. :) It needs q->setError(ERR_DISK_FULL); before setErrorText().

Fix some compile errors, oops :/

In T9658#160220, @abetts wrote:

But let's avoid bouncing between one or the other with every release. I know that there could be people in both sides of this idea, but part of being a good designer is sticking to your vision. There will always be people thinking that it is not the best approach, we can change, but when we change too much, it becomes unsustainable.

Sweet.

I like this one best: https://www.flaticon.com/free-icon/switch-user_72336#term=switch&page=2&position=3

The loading time isn't actually that long though. And then once it does load (which might be in as fast as half a second), you lose the pretty background image. I'm not sure that will work.

Yeah, I think you're right, @abetts. I made some efforts over the last few days but couldn't find a way to make those big square buttons not look ugly. Looking back through the thread here, I have to say that I like @filipf's screenshot:

Looking better, thanks! I will test shortly. I have one string change suggestion; can we change it to:

Did you verify that you were on the right branch? Afterwards, just do an arc diff to update the patch; I don't think you actually have push rights for this repo yet.

• Only allow one upload job at a time; if one is already going, restart it

We don't actually need to create a messagebox because it's up to the caller to display the error in an appropriate manner. For example, Dolphin shows errors inline rather than with dialog boxes. So we shouldn't create a messagebox at all.

This is better, thanks. Now the optional number padding works too. Maybe I was holding it wrong?

Thanks! And since I don't believe this patch on its own is sufficient to resolve 397572, please change FEATURE: 397572 to CCBUG: 397572. The former will close the bug once this lands; the latter just adds the commit info as a comment, but keeps the bug open--which is what we want here.

That huge summary needs reformatting, please. :) See https://chris.beams.io/posts/git-commit/#seven-rules

One issue is that dynamic coloring doesn't work, so in e.g. Dolphin's tooltip the icon remains black

This doesn't merge cleanly. Looks like someone has changed source/introduction/research.rst since you submitted this patch, or else your local checkout wasn't up-to-date when you created your branch. You need to re-base on current master. Do git pull --rebase origin master and follow the instructions. I can help you over chat if needed.

I think we can be even more radical here. Right now we have "Design Vision" that introduces "Simple by default" and "Powerful when needed", and then the very next section expands on them.

Yeah, I also can't tell the difference. If this new way is computationally cheaper, then +1 from me.

FYI, this included an ABI change to SearchRequest that broke Discover: https://bugs.kde.org/show_bug.cgi?id=398412

In T9444#160051, @abetts wrote:

The second option is a great option IMHO. Thanks Nate. Is it possible for the backgrounds to have rounded corners and be darkened? My main idea is that they become very faint. Just between the point of being faded and distinguishable.

Just a few more:

Behavior seems perfect to me! Code review is not my strong suit but I'll give it a shot.

I gave option 3 a crude attempt tonight:

@davidedmundson Ping! This just missed the 5.14 window.

@nicolasfella ping! It would be a shame to lose this since it's already quite a good improvement.