Show photo orientation as icon
AbandonedPublic

Authored by broulik on Sep 14 2018, 11:23 AM.

Details

Reviewers
michaelh
kossebau
Group Reviewers
VDG
Summary

We currently don't map the numbers 1 through 8 to any meaningful value.
However, showing the text by specification ("top, left") like Gwenview does is also not very helpful.
Instead, show an icon and transform it accordingly.

Test Plan

All possible orientations according to http://sylvana.net/jpegcrop/exif_orientation.html

In Dolphin sidebar:
(took a vertical photo:)


(I resized the panel in the meantime, hence the different wrapping, normal photo)

same for "Details" tab (larger font size leads to larger icon, hence non-filled look)


One issue is that dynamic coloring doesn't work, so in e.g. Dolphin's tooltip the icon remains black

Diff Detail

Repository
R824 Baloo Widgets
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 14 2018, 11:23 AM
Restricted Application added a project: Baloo. · View Herald TranscriptSep 14 2018, 11:23 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
broulik requested review of this revision.Sep 14 2018, 11:23 AM
broulik edited the test plan for this revision. (Show Details)Sep 14 2018, 1:13 PM

One issue is that dynamic coloring doesn't work, so in e.g. Dolphin's tooltip the icon remains black

Is that fixable?

abetts added a subscriber: abetts.Sep 15 2018, 2:54 PM
kossebau resigned from this revision.Jul 4 2019, 2:04 PM

No maintainer here, also no opinion :) Thus resigning to not keep wrong hopes for feedback from me.

broulik abandoned this revision.Sep 16 2019, 10:29 AM