utecht (Kyle Utecht)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 13 2018, 6:55 PM (14 w, 1 d)
Availability
Available

Recent Activity

Oct 19 2018

utecht added a comment to D16304: Add default file name token for (padded) sequential file numbering.

I don't think so. I have a KDE identity and login for the KDE bugzilla. Is one of these what you're asking about?

Oct 19 2018, 6:24 PM · Spectacle
utecht updated the diff for D16304: Add default file name token for (padded) sequential file numbering.

Made QStringList const too.

Oct 19 2018, 3:49 PM · Spectacle
utecht added a comment to D16304: Add default file name token for (padded) sequential file numbering.

Thank you for your patience and feedback on this. I appreciate it since I'm still a bit new to C++ and this workflow. Would you like me to check the done boxes above with the in line diff comments? Or is that something the reviewer(s) do? Thanks.

Oct 19 2018, 2:21 PM · Spectacle
utecht updated the diff for D16304: Add default file name token for (padded) sequential file numbering.

Fixed memory leak. Added const to several QStrings. Update for loop to C++11 style.

Oct 19 2018, 2:18 PM · Spectacle

Oct 18 2018

utecht updated the diff for D16304: Add default file name token for (padded) sequential file numbering.

Add failsafe for blank filename in save options form. Placeholder and default file name is now %d. Also
improve regex that checks for similar file names for edge case with only sequential number file name.

Oct 18 2018, 8:24 PM · Spectacle
utecht added a comment to D16304: Add default file name token for (padded) sequential file numbering.

I think the empty file name template setting defaulting to sequential file number is an interesting idea. It is a good fail safe. If that seems like a reasonable add on to this diff, I can add %d as the default string coming from SpectacleConfig if save-filename-format is empty.

Oct 18 2018, 7:32 PM · Spectacle
utecht abandoned D15059: Added file name option %Nd to include auto incremented number to file name.
Oct 18 2018, 7:04 PM
utecht updated the summary of D16304: Add default file name token for (padded) sequential file numbering.
Oct 18 2018, 7:03 PM · Spectacle
utecht updated the diff for D16304: Add default file name token for (padded) sequential file numbering.

Removed more merge conflict markers. Sorry. Updated local method call to use upstream name.

Oct 18 2018, 6:46 PM · Spectacle
utecht updated the diff for D16304: Add default file name token for (padded) sequential file numbering.

removed some merge conflict markers

Oct 18 2018, 6:33 PM · Spectacle
utecht added a comment to D16304: Add default file name token for (padded) sequential file numbering.

BUG: 358641
BUG: 373759

Oct 18 2018, 6:29 PM · Spectacle
utecht added a comment to D15059: Added file name option %Nd to include auto incremented number to file name.

Sorry. I didn't mean for this to seem to be stalled. I submitted a new patch with the result of our conversation above. It uses arc and is rebased on the upstream git repository as of today so hopefully we can avoid some of the merging issues of last. The new patch is D16304.

Oct 18 2018, 6:24 PM
utecht requested review of D16304: Add default file name token for (padded) sequential file numbering.
Oct 18 2018, 6:22 PM · Spectacle

Oct 15 2018

utecht updated the diff for D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.

merged with origin master to hopefully fix the patch

Oct 15 2018, 6:27 PM · Spectacle

Oct 10 2018

utecht updated the diff for D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.

rebased on origin master I think

Oct 10 2018, 6:29 PM · Spectacle

Oct 6 2018

utecht updated the summary of D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.
Oct 6 2018, 3:05 AM · Spectacle

Oct 2 2018

utecht requested review of D15908: clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names.
Oct 2 2018, 8:08 PM · Spectacle

Sep 17 2018

utecht added a comment to D15059: Added file name option %Nd to include auto incremented number to file name.

I like how you've rephrased the instructions. Breaking it into two lines ends up being clearer and more concise.

Sep 17 2018, 3:57 PM

Sep 12 2018

utecht added a comment to T8711: Gathering feedback from newcomers on the current onboarding experience.

What made you step and and decide to contribute to KDE?
I've always wanted to contribute to something. I was very happy with what is going on in KDE lately (Plasma in particular but also the more common apps) and Nate's blog made it seem very approachable, even for someone new to KDE/Qt/C++.

Sep 12 2018, 8:22 PM · Goal settings 2017
utecht updated the diff for D15059: Added file name option %Nd to include auto incremented number to file name.

I agree about the help text on the use of this placeholder. I simplified it based on your suggestion. I think it is better but perhaps not perfect and am open to further suggestions on it.

Sep 12 2018, 12:45 PM

Sep 11 2018

utecht added a comment to D15416: Cleans up markDirty() function definition to not require parameter.

Am I to land this myself? I tried with arc but I got the following error:

Sep 11 2018, 12:27 PM · Spectacle
utecht requested review of D15416: Cleans up markDirty() function definition to not require parameter.
Sep 11 2018, 4:47 AM · Spectacle
utecht updated the diff for D15059: Added file name option %Nd to include auto incremented number to file name.

Let's try this diff. I also tidied up what will happen for large sequential file numbers - they roll over at 1,000,000.

Sep 11 2018, 4:44 AM

Sep 7 2018

utecht updated the diff for D15106: Calculate date and time values for file name at time of screen shot rather than time of save.

Let's try this one.

Sep 7 2018, 5:04 AM · Spectacle

Sep 5 2018

utecht updated the diff for D15106: Calculate date and time values for file name at time of screen shot rather than time of save.

I have reverted the commit that was causing the issue on my local feature branch which I hope allows the diff to work. If it doesn't, I'll go one step further and start a new branch from the upstream repository and reapply the changes manually.

Sep 5 2018, 3:38 PM · Spectacle

Aug 28 2018

utecht updated the diff for D14812: Move 'copy file location after saving' to Save Options page.

I believe I made the updates from the review. Is uploading a new diff that includes the original and review changes the preferred next step here? Thank you. This is my first go around with this.

Aug 28 2018, 9:26 PM · Spectacle

Aug 27 2018

utecht requested review of D15106: Calculate date and time values for file name at time of screen shot rather than time of save.
Aug 27 2018, 5:52 PM · Spectacle

Aug 24 2018

utecht updated the summary of D15059: Added file name option %Nd to include auto incremented number to file name.
Aug 24 2018, 2:38 PM
utecht requested review of D15059: Added file name option %Nd to include auto incremented number to file name.
Aug 24 2018, 2:35 PM

Aug 13 2018

utecht updated the summary of D14812: Move 'copy file location after saving' to Save Options page.
Aug 13 2018, 9:46 PM · Spectacle
utecht requested review of D14812: Move 'copy file location after saving' to Save Options page.
Aug 13 2018, 9:45 PM · Spectacle