Don't show rectangular region editor if failed to take a screenshot
ClosedPublic

Authored by volkov on Sep 11 2018, 1:15 PM.

Details

Summary

For example, some Xorg security extension may forbid to take
screenshots. There is nothing to edit in this case, moreover
the region editor resizes to a null size thus leaving spectacle
in an abnormal state.

Diff Detail

Repository
R166 Spectacle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2721
Build 2739: arc lint + arc unit
volkov created this revision.Sep 11 2018, 1:15 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptSep 11 2018, 1:15 PM
volkov requested review of this revision.Sep 11 2018, 1:15 PM

Thanks for the patch! Is there an easy way I can test the failure case?

I'm afraid that there is no such way :( I found the bug with proprietary security extension.
It should be possible to reproduce the situation with XSelinux, but I don't know how.

ngraham accepted this revision.Sep 18 2018, 3:17 AM

Oh well. :) The code looks sane and I can't find any regressions for when not using your proprietary Xorg extension, so if this fixes the issue for you, feel free to push it.

This revision is now accepted and ready to land.Sep 18 2018, 3:17 AM
volkov closed this revision.Sep 18 2018, 9:32 AM