jtamate (Jaime Torres Amate)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 2 2016, 9:23 AM (102 w, 1 d)
Availability
Available

Recent Activity

Thu, Jun 14

jtamate added a comment to D13475: fix sftp links with new uds implementation.

I'm backporting it. Before I push: will this work also with previous KIO versions?

Thu, Jun 14, 9:52 AM
jtamate added a comment to D13475: fix sftp links with new uds implementation.

Should we backport this on the stable branch? Otherwise affected people will have to either downgrade kio or compile kio-extras from master...

Thu, Jun 14, 8:37 AM

Wed, Jun 13

jtamate committed R241:fb3c94ed96c3: Enable comparing KFileItems by url (authored by jtamate).
Enable comparing KFileItems by url
Wed, Jun 13, 5:32 PM
jtamate closed D13211: Enable comparing KFileItems by url.
Wed, Jun 13, 5:32 PM · Frameworks
jtamate committed R320:d8e976394fdb: Remove an space and a new line (authored by jtamate).
Remove an space and a new line
Wed, Jun 13, 5:25 PM
jtamate committed R320:471f96763748: fix sftp links with new uds implementation (authored by jtamate).
fix sftp links with new uds implementation
Wed, Jun 13, 5:23 PM
jtamate closed D13475: fix sftp links with new uds implementation.
Wed, Jun 13, 5:23 PM

Tue, Jun 12

jtamate updated the diff for D13211: Enable comparing KFileItems by url.

Change @since to 5.48

Tue, Jun 12, 9:22 AM · Frameworks
jtamate abandoned D12897: Reserve space for the cachedLineForRanges Qhash (optimization).

More numbers:
The patch reserves 67 buckets in the QHash table vs. 37 by default.
In my test, pasing the content of https://www.boe.es/legislacion/documentos/ConstitucionCASTELLANO.pdf from Okular,
the number of items in the cache is a maximum of 24 members when inserting.
But the first undo uses up to 2300 members (4099 buckets), and later undoes only use a maximum of 43 members.

Tue, Jun 12, 7:28 AM · Frameworks, Kate
jtamate added inline comments to D13475: fix sftp links with new uds implementation.
Tue, Jun 12, 6:27 AM

Mon, Jun 11

jtamate updated the diff for D13475: fix sftp links with new uds implementation.

I misread what was after the goto. :-(
Modified also the similar method createUDSEntry.

Mon, Jun 11, 2:00 PM
jtamate added a comment to D12696: Use the new uds implementation.

I'm sorry, I was missing a -dev package and therefore I was not compiling kio sftp.

Mon, Jun 11, 8:05 AM · Frameworks
jtamate requested review of D13475: fix sftp links with new uds implementation.
Mon, Jun 11, 8:03 AM

Sun, Jun 10

jtamate added a comment to D12897: Reserve space for the cachedLineForRanges Qhash (optimization).

@mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain?

If there is a more constrained limit, this should be changed, of course.

Sun, Jun 10, 6:19 AM · Frameworks, Kate

Thu, Jun 7

jtamate added a comment to D12696: Use the new uds implementation.

Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only?

I'm sorry, I can't reproduce it with dolphin. (symbolic links and hard links and sftp://127.0.0.1).
Could you get a backtrace with more information, at least who is calling udsentry.cpp, line 107? Probably you can get it running the program inside gdb or under valgrind. Or you should compile the program and dependencies with -DCMAKE_BUILD_TYPE=RelWithDebInfo

Thu, Jun 7, 7:30 AM · Frameworks

Tue, Jun 5

jtamate updated the diff for D12945: kcoredirlister lstItems benchmark.

Changed the structure QListBinaryHash to QMap
Changed from KFileItems pointers to Values (it caused memory problems).

Tue, Jun 5, 7:12 AM · Frameworks

Fri, Jun 1

jtamate updated the diff for D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

The change in kdirmodel is not needed anymore.
The methods that were const are const again.
Better documented the new reinsert method.

Fri, Jun 1, 8:57 AM · Frameworks
jtamate updated the diff for D13211: Enable comparing KFileItems by url.

Now passes the tests and its performance for non invalid items is not degraded too much (same +3ms inserting).

Fri, Jun 1, 7:22 AM · Frameworks

Wed, May 30

jtamate committed R241:ae08cc2c983c: [kcoredirlister] Remove as many url.toString() as possible (authored by jtamate).
[kcoredirlister] Remove as many url.toString() as possible
Wed, May 30, 5:38 PM
jtamate closed D13189: [kcoredirlister] Remove as many url.toString() as possible.
Wed, May 30, 5:38 PM · Frameworks
jtamate updated the diff for D13211: Enable comparing KFileItems by url.

Taken into account invalid Items created from invalid QUrls.

Wed, May 30, 3:15 PM · Frameworks
jtamate updated the diff for D13211: Enable comparing KFileItems by url.

Invalid items are not less than invalid items or invalid urls, they are not like -infinite.
Added the tests comparing items with urls.
Changed the descriptions.

Wed, May 30, 3:00 PM · Frameworks
jtamate updated the diff for D13211: Enable comparing KFileItems by url.

A KFileItem without url will be the lowest, even lower than itself.
Created a new test.

Wed, May 30, 2:02 PM · Frameworks
jtamate added dependent revisions for D13211: Enable comparing KFileItems by url: D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache, D12945: kcoredirlister lstItems benchmark.
Wed, May 30, 10:39 AM · Frameworks
jtamate added a dependency for D12945: kcoredirlister lstItems benchmark: D13211: Enable comparing KFileItems by url.
Wed, May 30, 10:39 AM · Frameworks
jtamate added a dependency for D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache: D13211: Enable comparing KFileItems by url.
Wed, May 30, 10:39 AM · Frameworks
jtamate requested review of D13211: Enable comparing KFileItems by url.
Wed, May 30, 10:38 AM · Frameworks

Tue, May 29

jtamate updated the diff for D13189: [kcoredirlister] Remove as many url.toString() as possible.

const added.

Tue, May 29, 1:34 PM · Frameworks
jtamate requested review of D13189: [kcoredirlister] Remove as many url.toString() as possible.
Tue, May 29, 9:13 AM · Frameworks

Thu, May 24

jtamate added a comment to D11282: less expensive findByUrl in KCoreDirListerCache.

About the KCoreDirLister::Private::addNewItems method, benchmarking the current and sorted list implementation with 5000 fileItems:

Thu, May 24, 8:42 AM · Frameworks
jtamate updated the diff for D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

Removed m_hash, after implementing the right checks it was slower than comparing QUrls.

Thu, May 24, 7:26 AM · Frameworks

Wed, May 23

jtamate updated the diff for D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

Based on the tests done in D12945 and D11282, the best solution is to have the result of qHash(url) in KFileItem to compare items in the binary search.
In two cases, the KFileItem in the list has to be moved to the right position, this is still faster than before.
Introduce two methods to insert an item into the list and to move the item to the right position.

Wed, May 23, 1:47 PM · Frameworks

May 17 2018

jtamate added a dependency for D11282: less expensive findByUrl in KCoreDirListerCache: D12945: kcoredirlister lstItems benchmark.
May 17 2018, 2:40 PM · Frameworks
jtamate added a dependent revision for D12945: kcoredirlister lstItems benchmark: D11282: less expensive findByUrl in KCoreDirListerCache.
May 17 2018, 2:40 PM · Frameworks
jtamate requested review of D12945: kcoredirlister lstItems benchmark.
May 17 2018, 2:38 PM · Frameworks

May 15 2018

jtamate requested review of D12897: Reserve space for the cachedLineForRanges Qhash (optimization).
May 15 2018, 3:47 PM · Frameworks, Kate

May 14 2018

jtamate requested review of D12865: transferjob new connect syntax.
May 14 2018, 7:17 AM · Frameworks

May 10 2018

jtamate committed R241:e80c31163170: Use the new uds implementation (authored by jtamate).
Use the new uds implementation
May 10 2018, 5:26 PM
jtamate closed D12696: Use the new uds implementation.
May 10 2018, 5:26 PM · Frameworks
jtamate committed R241:2a57054a718a: Don't redirect smb:/ to smb:// and then to smb:/// (authored by jtamate).
Don't redirect smb:/ to smb:// and then to smb:///
May 10 2018, 5:22 PM
jtamate closed D12371: Don't redirect smb:/ to smb:// and then to smb:///.
May 10 2018, 5:22 PM · Frameworks
jtamate updated the summary of D12371: Don't redirect smb:/ to smb:// and then to smb:///.
May 10 2018, 5:22 PM · Frameworks
jtamate updated the diff for D12696: Use the new uds implementation.

Added the documentation for insert.
Removed the () from the QDataStream& operators, but must be kept for QDebug or clang++ will not compile.
Adjusted the reserved amounts.

May 10 2018, 8:29 AM · Frameworks

May 9 2018

jtamate updated the diff for D12696: Use the new uds implementation.

Direct friendship with the operators.

May 9 2018, 2:39 PM · Frameworks
jtamate updated the diff for D12371: Don't redirect smb:/ to smb:// and then to smb:///.

The crash after the redirection in fish://127.0.0.1 was due to a remaining of an unfinished patch in other files.
After removing it and testing the patch in different machines and different compilers, this solves this crash and I haven't noticed regressions.

May 9 2018, 9:21 AM · Frameworks
jtamate requested review of D12776: 4 more cases of empty protocol.
May 9 2018, 8:30 AM · Frameworks

May 8 2018

jtamate added inline comments to D12696: Use the new uds implementation.
May 8 2018, 2:16 PM · Frameworks
jtamate updated the diff for D12696: Use the new uds implementation.

Make some friends functions.
A bad type in copy&paste didn't allowed me the use of the module functions save/load/debugUDSEntry,

May 8 2018, 11:31 AM · Frameworks
jtamate updated the diff for D12696: Use the new uds implementation.

Don't use java style.
As UDSEntryPrivate is private, declare public methods save, load and debugUDSEntry, otherwise I couldn't access the private d pointer from the << and >> operators.

May 8 2018, 8:19 AM · Frameworks

May 7 2018

jtamate updated the diff for D12696: Use the new uds implementation.

Hopefully, all the issues fixed.

May 7 2018, 3:16 PM · Frameworks

May 4 2018

jtamate committed R39:90157a222b5e: optimization of KTextEditor::DocumentPrivate::views() (authored by jtamate).
optimization of KTextEditor::DocumentPrivate::views()
May 4 2018, 5:40 PM
jtamate closed D12511: optimization of KTextEditor::DocumentPrivate::views().
May 4 2018, 5:40 PM · Frameworks, Kate
jtamate added a comment to D12511: optimization of KTextEditor::DocumentPrivate::views().

https://phabricator.kde.org/file/data/w4qogv4brtxlc5p5bnwr/PHID-FILE-q62giymcptudpl5m6bt3/kwrite_perf_after_25_dwarf_caller.png shows ~1.5% in notifyAboutRangeChange (inclusively). Is that before or after your patch here?

May 4 2018, 4:45 PM · Frameworks, Kate
jtamate added a comment to D12511: optimization of KTextEditor::DocumentPrivate::views().

Actually, no. Ignore what I said. The pictures you are showing are pretty meaningless. Did you run perf with --call-graph dwarf? Better look at the flamegraph and search for the function you are interested in (Kate::TextBuffer::notifyAboutRangeChange) or use the Caller/Callee view to get an aggregated view of your change.

May 4 2018, 3:26 PM · Frameworks, Kate
jtamate updated the diff for D11604: kdirlistertest doesn't fail at random.

Add the new tests instead of replace.
Use QTRY_COMPARE instead of custom loops.
Reduce the number of files to 100.

May 4 2018, 12:09 PM · Frameworks
jtamate requested review of D12696: Use the new uds implementation.
May 4 2018, 11:44 AM · Frameworks
jtamate committed R39:81996f55b1ab: [ktexteditor] much faster positionFromCursor (authored by jtamate).
[ktexteditor] much faster positionFromCursor
May 4 2018, 10:26 AM
jtamate closed D12016: [ktexteditor] much faster positionFromCursor.
May 4 2018, 10:26 AM · Frameworks, Kate
jtamate updated the diff for D12511: optimization of KTextEditor::DocumentPrivate::views().

Add and remove from the list.

May 4 2018, 10:16 AM · Frameworks, Kate
jtamate added a comment to D12016: [ktexteditor] much faster positionFromCursor.

Actually, given the functionality is only used there, if that code is in the view or in that helper class makes no real difference, or?

May 4 2018, 9:10 AM · Frameworks, Kate
jtamate committed R241:01b2e536aeb3: two new UDS structures (authored by jtamate).
two new UDS structures
May 4 2018, 9:03 AM
jtamate closed D12659: two new UDS structures.
May 4 2018, 9:03 AM · Frameworks
jtamate updated the diff for D12659: two new UDS structures.

Removed some methods that are not used in the benchmarks.
Added the asserts to check the type of the data at the beginning of every insert and replaceOrInsert.

May 4 2018, 8:10 AM · Frameworks

May 3 2018

jtamate updated the diff for D12511: optimization of KTextEditor::DocumentPrivate::views().

You are right, there is no change to m_views there.

May 3 2018, 8:02 PM · Frameworks, Kate
jtamate updated the diff for D12659: two new UDS structures.

I've included some methods that will be needed if AnotherUDSEntry replaces the current one.
I hope to have addressed all your comments.

May 3 2018, 9:17 AM · Frameworks

May 2 2018

jtamate updated the diff for D12659: two new UDS structures.

Another way to improve insertion speed in release could be:
Transform "insert" to really insert only, with ASSERTS if it used as "replaceOrInsert" and add new methods "replaceOrInsert".

May 2 2018, 6:08 PM · Frameworks
jtamate added a comment to D12016: [ktexteditor] much faster positionFromCursor.

Maybe i miss something, but i think if something should be extended it's view not accessible.

May 2 2018, 5:30 PM · Frameworks, Kate
jtamate updated the diff for D12659: two new UDS structures.

Fixed the ordered insertion.
Using std::vector and std::find_if.
Initialize everything to try to detect a change of type in a "insert" over a different type.

May 2 2018, 4:47 PM · Frameworks
jtamate added a comment to D12659: two new UDS structures.

If anyone attempts this, please name the struct and its members, don't use QPair ;-)
But no, that cannot possibly be faster. QVariant has lots of overhead itself.

May 2 2018, 4:13 PM · Frameworks
jtamate requested review of D12659: two new UDS structures.
May 2 2018, 11:05 AM · Frameworks

Apr 28 2018

jtamate updated the diff for D12371: Don't redirect smb:/ to smb:// and then to smb:///.

If I use if (!u.path().isEmpty()) or if (!u.path().isEmpty() && !u.path().endsWith('/')),
as soon as I enter the url fish://127.0.0.1 (without trailing /), I'm redirected to fish://127.0.0.1/home/jtorres (that didn't happen before), and after finishing reading the directory, assertion.

Apr 28 2018, 11:17 AM · Frameworks

Apr 27 2018

jtamate updated the diff for D12371: Don't redirect smb:/ to smb:// and then to smb:///.

The responsible for changing smb:// into smb:/// was: void KFileWidgetPrivate::_k_enterUrl(const QUrl &url)
With this patch, the crashes are gone, as there is no redirection to smb:///
But now there is no smb error message.

(in spanish). unless smb:/// is introduced manually as the url.

Apr 27 2018, 4:45 PM · Frameworks

Apr 26 2018

jtamate added a comment to D12538: Allow accepting by double-click in save dialog.

I'm one of those that choose a file and add a "_2" to the filenames. ;-)

Apr 26 2018, 11:02 AM · Frameworks

Apr 25 2018

jtamate requested review of D12511: optimization of KTextEditor::DocumentPrivate::views().
Apr 25 2018, 8:45 AM · Frameworks, Kate
jtamate updated the diff for D12371: Don't redirect smb:/ to smb:// and then to smb:///.

Just to know if I'm in the correct path, because I'm getting out of ideas.
Use in the hash table, and probably in other parts, always the url with at most one trailing /.

Apr 25 2018, 8:06 AM · Frameworks

Apr 23 2018

jtamate added a comment to D12371: Don't redirect smb:/ to smb:// and then to smb:///.

One solution is to call printDebug(), which will output lots of information including the contents of directoryData().

Apr 23 2018, 7:21 AM · Frameworks

Apr 21 2018

jtamate committed R241:ee0a0f1ef323: kdirlister new connect syntax (authored by jtamate).
kdirlister new connect syntax
Apr 21 2018, 7:13 AM
jtamate closed D12228: kdirlister new connect syntax.
Apr 21 2018, 7:13 AM · Frameworks

Apr 20 2018

jtamate added a comment to D12371: Don't redirect smb:/ to smb:// and then to smb:///.

More investigation, in bold what causes the problem.

Apr 20 2018, 6:54 PM · Frameworks
jtamate updated the diff for D12228: kdirlister new connect syntax.

Removed comment.

Apr 20 2018, 6:07 PM · Frameworks
jtamate updated the diff for D12228: kdirlister new connect syntax.

Removed Q_PRIVATE_SLOT. Didn't saw them again. :-(

Apr 20 2018, 5:37 PM · Frameworks
jtamate updated the diff for D12228: kdirlister new connect syntax.

Added space.
Removed SLOT.

Apr 20 2018, 5:22 PM · Frameworks
jtamate updated the diff for D12228: kdirlister new connect syntax.

Change the first connect.
No need to change the name of the slot.
Pass the plain error message.

Apr 20 2018, 5:09 PM · Frameworks
jtamate added a comment to D12371: Don't redirect smb:/ to smb:// and then to smb:///.
In D12371#250366, @apol wrote:

^^' this won't work though. If the object gets deleted you will get a null pointer in the list.

Apr 20 2018, 12:44 PM · Frameworks
jtamate updated the diff for D12371: Don't redirect smb:/ to smb:// and then to smb:///.

Implemented as Aleix suggested, using QPointer.

Apr 20 2018, 11:47 AM · Frameworks
jtamate requested review of D12371: Don't redirect smb:/ to smb:// and then to smb:///.
Apr 20 2018, 8:26 AM · Frameworks

Apr 19 2018

jtamate added inline comments to D12233: Avoid manipulation of lists with quadratic complexity.
Apr 19 2018, 8:20 PM · Baloo, Frameworks
jtamate added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Lately, the zoom widget is placed at the bottom in most programs, perhaps it can be moved at the left of the Save/Open Cancel buttons.
If the mouse distance is a problem, the navigation buttons can be placed at the top right, just where the zoom widget is now.
This is just another idea.

Apr 19 2018, 6:22 PM · Frameworks

Apr 17 2018

jtamate updated the summary of D12228: kdirlister new connect syntax.
Apr 17 2018, 6:55 AM · Frameworks
jtamate updated the diff for D12228: kdirlister new connect syntax.

I have renamed one private slot because I didn't find a better solution.
QOverload seems to work only for signals, not for slots.

Apr 17 2018, 6:36 AM · Frameworks

Apr 16 2018

jtamate committed R244:c0b312a41f7f: KJob public signals (authored by jtamate).
KJob public signals
Apr 16 2018, 5:07 PM
jtamate closed D12242: KJob public signals.
Apr 16 2018, 5:07 PM · Frameworks
jtamate added a comment to D10702: Always use a job to delete files to avoid freezing process waiting on IO.

The current state is that it freezes as long as the file deletion (unlink) lasts.

Apr 16 2018, 3:13 PM · Frameworks
jtamate updated the diff for D12242: KJob public signals.

Changed from "can't" to "shouldn't".

Apr 16 2018, 9:44 AM · Frameworks
jtamate requested review of D12242: KJob public signals.
Apr 16 2018, 8:47 AM · Frameworks

Apr 15 2018

jtamate requested review of D12228: kdirlister new connect syntax.
Apr 15 2018, 4:49 PM · Frameworks
jtamate committed R241:287093136efc: Detect incorrect paramenter in findProtocol (authored by jtamate).
Detect incorrect paramenter in findProtocol
Apr 15 2018, 7:39 AM
jtamate closed D11013: Detect incorrect paramenter in findProtocol.
Apr 15 2018, 7:39 AM · Frameworks

Apr 11 2018

jtamate committed R241:940d2763e41b: convert setDirLister to the new connect syntax (authored by jtamate).
convert setDirLister to the new connect syntax
Apr 11 2018, 5:14 PM
jtamate closed D12095: convert setDirLister to the new connect syntax .
Apr 11 2018, 5:14 PM · Frameworks