jtamate (Jaime Torres Amate)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 2 2016, 9:23 AM (128 w, 3 d)
Availability
Available

Recent Activity

Yesterday

jtamate added a comment to D17619: Change the path for every item of the subdirectories in a directory rename.

I'll work on the unit test this weekend. I don't currently have enough free time on weekdays.

Mon, Dec 17, 9:09 PM · Frameworks
jtamate retitled D17619: Change the path for every item of the subdirectories in a directory rename from fix for bug 401552 to Change the path for every item of the subdirectories in a directory rename.
Mon, Dec 17, 9:07 PM · Frameworks
jtamate updated the summary of D17619: Change the path for every item of the subdirectories in a directory rename.
Mon, Dec 17, 8:16 PM · Frameworks
jtamate updated the diff for D17619: Change the path for every item of the subdirectories in a directory rename.

There is no need for a unit test, it is already in kdirmodeltest (but perhaps could be expanded in another patch).

Mon, Dec 17, 6:52 PM · Frameworks

Sun, Dec 16

jtamate updated the diff for D17619: Change the path for every item of the subdirectories in a directory rename.

I think this time I got the problem right.
One of the classics: I was modifying the list while it was being used.

Sun, Dec 16, 12:36 PM · Frameworks
jtamate updated the summary of D17619: Change the path for every item of the subdirectories in a directory rename.
Sun, Dec 16, 8:52 AM · Frameworks
jtamate added a comment to D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

Let's continue on D17619

Sun, Dec 16, 8:49 AM · Frameworks
jtamate requested review of D17619: Change the path for every item of the subdirectories in a directory rename.
Sun, Dec 16, 8:48 AM · Frameworks

Sat, Dec 15

jtamate added a comment to D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

I'm able to reproduce the bug with the following steps:

  • Create a folder structure X/X1/X2/X3/X4 and add a new empty text file into each folder.
  • Within Dolphin, open a tab for each folder.
  • In the tab showing X contents, rename X1 to X1_ and the crash is there.
Sat, Dec 15, 11:21 AM · Frameworks
jtamate added a comment to D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

I've been able to reproduce the bug:

Sat, Dec 15, 10:30 AM · Frameworks

Oct 26 2018

jtamate added a comment to D16344: Do not try to fallback to "less secure" protocols.

What protocol does KTcpSocket::SecureProtocols implement (I can't guess it)? If it is the same as QSsl:SecureProtocols
it does:
On the client side, this will send a TLS 1.0 Client Hello, enabling TLSv1_0 and SSLv3 connections. On the server side, this will enable both SSLv3 and TLSv1_0 connections.

Oct 26 2018, 3:20 PM · Frameworks

Oct 22 2018

jtamate closed D16349: [kdirlistertest] Wait a little longer for the lister to finish.
Oct 22 2018, 5:20 PM · Frameworks
jtamate committed R241:87a2f084be83: [kdirlistertest] Wait a little longer for the lister to finish (authored by jtamate).
[kdirlistertest] Wait a little longer for the lister to finish
Oct 22 2018, 5:20 PM

Oct 21 2018

jtamate requested review of D16349: [kdirlistertest] Wait a little longer for the lister to finish.
Oct 21 2018, 9:55 AM · Frameworks

Oct 14 2018

jtamate committed R241:63093179579c: Avoid waiting for user actions when kwin Focus stealing prevention is high or… (authored by jtamate).
Avoid waiting for user actions when kwin Focus stealing prevention is high or…
Oct 14 2018, 9:57 AM
jtamate closed D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme.
Oct 14 2018, 9:57 AM · Frameworks
jtamate added a comment to D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme.

Created https://bugreports.qt.io/browse/QTBUG-71137

Oct 14 2018, 9:53 AM · Frameworks

Oct 10 2018

jtamate abandoned D11282: less expensive findByUrl in KCoreDirListerCache.
Oct 10 2018, 6:42 AM · Frameworks

Oct 9 2018

jtamate committed R241:20b89972b643: get rid of the raw KFileItem pointers in KCoreDirListerCache (authored by jtamate).
get rid of the raw KFileItem pointers in KCoreDirListerCache
Oct 9 2018, 4:47 PM
jtamate closed D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.
Oct 9 2018, 4:46 PM · Frameworks
jtamate requested review of D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme.
Oct 9 2018, 1:21 PM · Frameworks

Oct 8 2018

jtamate added a comment to D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices.

Just in case, I'm subscribed now to the RSS https://build.kde.org/job/Frameworks/job/kio/rssFailed

Oct 8 2018, 2:40 PM · Frameworks
jtamate planned changes to D15328: kfilewidget: convert connect syntax.

QTest::qWaitForWindowActive fails because I use kwin Focus stealing prevention High, therefore the windows doesn't become active until I click on them in the task bar or switch to them.
And qWaitForWindowExposed doesn't help because the window/widget needs to have the focus.

Oct 8 2018, 8:34 AM · Frameworks
jtamate updated the diff for D15328: kfilewidget: convert connect syntax.

Fix a crash ,caused by a still connected signal, after running again the unittests.
kfilewidgettest still doesn't pass because QTest::qWaitForWindowActive fails for me.

Oct 8 2018, 7:46 AM · Frameworks
jtamate accepted D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices.

I am really, really sorry. I have no excuses to not have run the autotests (that I usually run after my first fiasco). Hopefully, after my second fiasco, I'll run them before creating any review request.

Oct 8 2018, 7:17 AM · Frameworks

Oct 7 2018

jtamate committed R37:409e7ac4256d: Trivial micro optimizations (initialization lists) (authored by jtamate).
Trivial micro optimizations (initialization lists)
Oct 7 2018, 9:07 AM
jtamate closed D15922: Trivial micro optimizations (initialization lists).
Oct 7 2018, 9:07 AM · Krita

Oct 6 2018

jtamate closed D15371: Don't assign twice the same key to the action New Tab.

closed again by commits:
https://commits.kde.org/dolphin/5d180c5bb280f68cb98996044055e6891e29bab7
https://commits.kde.org/dolphin/b610ce5913ef3172f3cf15c0a1d93c255ea0da4f

Oct 6 2018, 8:35 AM · Dolphin
jtamate committed R318:b610ce5913ef: Merge remote-tracking branch 'origin/Applications/18.08' (authored by jtamate).
Merge remote-tracking branch 'origin/Applications/18.08'
Oct 6 2018, 8:33 AM
jtamate committed R318:5d180c5bb280: Don't assign twice the same key to the action New Tab (authored by jtamate).
Don't assign twice the same key to the action New Tab
Oct 6 2018, 8:27 AM

Oct 5 2018

jtamate updated the diff for D15371: Don't assign twice the same key to the action New Tab.

Keep both key sequences in case someone used ctrl+shift+n.

Oct 5 2018, 3:17 PM · Dolphin
jtamate updated the diff for D15371: Don't assign twice the same key to the action New Tab.

As it turns out, QKeySequence::AddTab is Ctrl+Shift+N under plasma.
Filled Qt bug: https://bugreports.qt.io/browse/QTBUG-70963
Change to Qt::CTRL + Qt::Key_T.

Oct 5 2018, 2:40 PM · Dolphin

Oct 4 2018

jtamate committed R37:0f87010adf82: Descend the array in the right way (authored by jtamate).
Descend the array in the right way
Oct 4 2018, 4:55 PM
jtamate closed D15905: Descend the array in the right way.
Oct 4 2018, 4:55 PM · Krita

Oct 3 2018

jtamate updated the diff for D15922: Trivial micro optimizations (initialization lists).

A comment disappeared in the conversion.

Oct 3 2018, 2:47 PM · Krita
jtamate requested review of D15922: Trivial micro optimizations (initialization lists).
Oct 3 2018, 2:43 PM · Krita
jtamate updated the diff for D15905: Descend the array in the right way.

Changed 2 more 5 by 4.

Oct 3 2018, 1:30 PM · Krita

Oct 2 2018

jtamate requested review of D15905: Descend the array in the right way.
Oct 2 2018, 6:57 PM · Krita
jtamate committed R37:97b9e0abfebc: Trivial micro optimizations (initialization lists) (authored by jtamate).
Trivial micro optimizations (initialization lists)
Oct 2 2018, 5:07 PM
jtamate closed D15894: Trivial micro optimizations (initialization lists).
Oct 2 2018, 5:07 PM · Krita
jtamate updated the diff for D15894: Trivial micro optimizations (initialization lists).

Changed comma style in initialization lists.
Using member initialization in the class declaration.
Added a constructor not detected before.

Oct 2 2018, 11:29 AM · Krita
jtamate requested review of D15894: Trivial micro optimizations (initialization lists).
Oct 2 2018, 10:23 AM · Krita
jtamate added inline comments to D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit..
Oct 2 2018, 6:49 AM · Frameworks

Sep 30 2018

jtamate committed R37:1b50235ce3c2: Add a + button and the clear button to Add New Tag (authored by jtamate).
Add a + button and the clear button to Add New Tag
Sep 30 2018, 7:37 AM
jtamate closed D15811: Add a + button and the clear button to Add New Tag.
Sep 30 2018, 7:37 AM · Krita

Sep 29 2018

jtamate added a comment to D15811: Add a + button and the clear button to Add New Tag.

No email was sent with yesterday update (or I didn't receive any), this comment is just to notify yesterday change.

Sep 29 2018, 7:37 AM · Krita

Sep 28 2018

jtamate updated the diff for D15811: Add a + button and the clear button to Add New Tag.

Removed the tooltip, I think it is counterproductive now.
Changed the button text into + icon.

Sep 28 2018, 9:58 AM · Krita
jtamate requested review of D15811: Add a + button and the clear button to Add New Tag.
Sep 28 2018, 8:29 AM · Krita

Sep 26 2018

jtamate updated the diff for D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

I've tried to do an automatic benchmark of the rename case, without success.
Changed code as requested.

Sep 26 2018, 6:46 AM · Frameworks

Sep 25 2018

jtamate committed R293:a931be1d7e3a: Use non deprecated fastInsert in baloo (authored by jtamate).
Use non deprecated fastInsert in baloo
Sep 25 2018, 5:22 PM
jtamate closed D15740: Use non deprecated fastInsert in baloo.
Sep 25 2018, 5:22 PM · Baloo, Frameworks
jtamate committed R293:95af521127c1: Use String to store UDS_USER and UDS_GROUP of String type. (authored by jtamate).
Use String to store UDS_USER and UDS_GROUP of String type.
Sep 25 2018, 5:21 PM
jtamate closed D15635: Use String to store UDS_USER and UDS_GROUP of String type..
Sep 25 2018, 5:21 PM · Baloo, Frameworks
jtamate requested review of D15740: Use non deprecated fastInsert in baloo.
Sep 25 2018, 8:06 AM · Baloo, Frameworks

Sep 21 2018

jtamate updated the diff for D15635: Use String to store UDS_USER and UDS_GROUP of String type..

Copy the methods getUserName and getGroupName from kfile, those are cached, should be faster.
Keep the fastInsert for another revision.

Sep 21 2018, 10:18 AM · Baloo, Frameworks
jtamate accepted D15638: force-finish canberra notifications on close().

Forget what I just wrote. I've seen that I was missing 15 lines in between then in the phabricator diff view. :-(
Looks good to me.

Sep 21 2018, 9:47 AM · Frameworks
jtamate added a comment to D15638: force-finish canberra notifications on close().

What would happen if finishNotification is called twice, In line 161 and then in line 192?
My guess is that finished signal will be called twice with the same notification, and therefore KNotificationManager::notifyPluginFinished will be called twice. I don't know what will happen the second time.
Perhaps a return after line 161 is needed?

Sep 21 2018, 9:43 AM · Frameworks
jtamate updated the diff for D15635: Use String to store UDS_USER and UDS_GROUP of String type..

White at it, use fastInsert.
And this also fixes the search in the home directory :-).
The title in English :-).

Sep 21 2018, 8:12 AM · Baloo, Frameworks
jtamate abandoned D15623: Finish the notification before removing it from the hash.

I didn't realize the notifications are not owned by m_notifications :-(.
Just looking at the backtrace of the crash, it was the only suspicious thing.

Sep 21 2018, 7:51 AM · Frameworks
jtamate requested review of D15635: Use String to store UDS_USER and UDS_GROUP of String type..
Sep 21 2018, 7:43 AM · Baloo, Frameworks

Sep 20 2018

jtamate requested review of D15623: Finish the notification before removing it from the hash.
Sep 20 2018, 2:41 PM · Frameworks

Sep 19 2018

jtamate accepted D15591: Add Open Document thumbnailer.

Ok by side. It installs now, and don't ask for passwords.

Sep 19 2018, 10:05 AM · Frameworks, Dolphin

Sep 18 2018

jtamate requested changes to D15591: Add Open Document thumbnailer.

I'm trying to check if it works with password-protected files, but I can't install it.
The patch is missing opendocumentthumbnail.desktop.

Sep 18 2018, 6:35 PM · Frameworks, Dolphin
jtamate committed R241:2b52b47211a6: Don't try to restore invalid user places (authored by jtamate).
Don't try to restore invalid user places
Sep 18 2018, 5:26 PM
jtamate closed D14072: Don't try to restore invalid user places.
Sep 18 2018, 5:26 PM · Frameworks
jtamate committed R241:6ab78df8c86e: Make it possible to change directory up even with trailing slashes in the url (authored by jtamate).
Make it possible to change directory up even with trailing slashes in the url
Sep 18 2018, 5:24 PM
jtamate closed D13676: Make it possible to change directory up even with trailing slashes in the url .
Sep 18 2018, 5:24 PM · Frameworks
jtamate added a comment to D15591: Add Open Document thumbnailer.

I haven't tested it, therefore I ask: Does this thumbnailer ask for password for password protected files, like in https://bugs.kde.org/show_bug.cgi?id=394284 ?

Sep 18 2018, 5:16 PM · Frameworks, Dolphin
jtamate updated the diff for D14072: Don't try to restore invalid user places.

Continue processing the XML with invalid urls.
And a trivial code deduplication, I couldn't resist.

Sep 18 2018, 7:19 AM · Frameworks

Sep 14 2018

jtamate added a comment to D15068: Bindings: Correct handling of sources containing utf-8.

Another solution (not tested here but used in other projects) could be to use
with open(source, "r", encoding="utf-8") as f:
(or if the file could contain the aberration BOM, you could use "utf-8-sig")

Sep 14 2018, 6:28 AM · Build System, Frameworks

Sep 12 2018

jtamate added a member for Bugsquad: jtamate.
Sep 12 2018, 3:01 PM

Sep 11 2018

jtamate committed R39:3348145dbfbf: Intialize m_lastPosition (authored by jtamate).
Intialize m_lastPosition
Sep 11 2018, 2:47 PM
jtamate closed D15420: Intialize m_lastPosition.
Sep 11 2018, 2:47 PM · Frameworks, Kate
jtamate added a comment to D12016: [ktexteditor] much faster positionFromCursor.

I get the following warning from valgrind because of this change:

Fix in D15420

Sep 11 2018, 11:23 AM · Frameworks, Kate
jtamate requested review of D15420: Intialize m_lastPosition.
Sep 11 2018, 11:22 AM · Frameworks, Kate

Sep 10 2018

jtamate added a comment to D14724: autotests: don't fail if an unrelated window shows up..

It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 . or ctest -j4 .

Sep 10 2018, 8:03 PM · Frameworks
jtamate requested review of D15408: Don't assert deleting the temporary file.
Sep 10 2018, 3:28 PM · Frameworks
jtamate committed R318:9991eb0f5eaf: Don't assign twice the same key to the action New Tab (authored by jtamate).
Don't assign twice the same key to the action New Tab
Sep 10 2018, 2:47 PM
jtamate closed D15371: Don't assign twice the same key to the action New Tab.
Sep 10 2018, 2:47 PM · Dolphin

Sep 9 2018

jtamate requested review of D15371: Don't assign twice the same key to the action New Tab.
Sep 9 2018, 11:25 AM · Dolphin
jtamate updated the diff for D15328: kfilewidget: convert connect syntax.

Use nullptr instead of 0.
Remove the copied/pasted part of the cause of two dissconnects.

Sep 9 2018, 9:08 AM · Frameworks

Sep 7 2018

jtamate updated the diff for D15328: kfilewidget: convert connect syntax.

Changed to 'Anonymous' connects and disconnects.

Sep 7 2018, 12:26 PM · Frameworks
jtamate added inline comments to D15328: kfilewidget: convert connect syntax.
Sep 7 2018, 12:00 PM · Frameworks
jtamate added inline comments to D15328: kfilewidget: convert connect syntax.
Sep 7 2018, 11:27 AM · Frameworks
jtamate updated the diff for D15328: kfilewidget: convert connect syntax.

Changed [&] by [this]in the lambdas.
Added a lambda for KActionCollection::addAction. I didn't knew it was already possible.

Sep 7 2018, 11:06 AM · Frameworks
jtamate requested review of D15328: kfilewidget: convert connect syntax.
Sep 7 2018, 10:12 AM · Frameworks

Sep 6 2018

jtamate added a comment to D15318: Automatically re-upload saved files located on remote locations instead of asking first.

but wouldn't it be nicer to not get the dialog to overwrite the modified file

You're still seeing that with git master? If so, I agree that we should fix that too.

Yes, without your patch, every time I agree to upload the modified file then I have to agree to overwrite the remote file.

Sep 6 2018, 5:09 PM · Frameworks
jtamate added a comment to D15318: Automatically re-upload saved files located on remote locations instead of asking first.

It does automatically upload the modified file, but wouldn't it be nicer to not get the dialog to overwrite the modified file, that of course is not there in the case of local files.
It is just a third parameter to copy and tell it to Overwrite.

Sep 6 2018, 4:43 PM · Frameworks
jtamate committed R241:820f622e86bb: kioexecd: watch for creations or modifications of the temporary files (authored by jtamate).
kioexecd: watch for creations or modifications of the temporary files
Sep 6 2018, 2:40 PM
jtamate closed D15180: kioexecd: watch for creations or modifications of the temporary files.
Sep 6 2018, 2:40 PM · Frameworks
jtamate added inline comments to D15180: kioexecd: watch for creations or modifications of the temporary files.
Sep 6 2018, 6:15 AM · Frameworks

Sep 5 2018

jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

Use QDateTime::currentDateTimeUtc() instead of QDateTime::currentDateTime().

Sep 5 2018, 5:02 PM · Frameworks
jtamate added a comment to D15180: kioexecd: watch for creations or modifications of the temporary files.

May I commit or should I wait for @elvisangelaccio to accept the changes? This time I have read the arc message, that is usually something about non tracked files:
Revision 'D15180: kioexecd: watch for creations or modifications of the temporary files' has not been accepted. Continue anyway? [y/N]

Sep 5 2018, 3:47 PM · Frameworks
jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

Tested, dirty is not signaled when created (at least I didn't saw the dialog for uploading the modified file).
Removed the header.

Sep 5 2018, 10:02 AM · Frameworks
jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

Why the mutex? I interpreted that QTimer work as an interrumpt (wrong) instead of generating events in the event queue (right).
So I've gone through all the possible mistakes one can do here:

  • Design mistakes
  • Security mistakes
  • Misunderstanding the API.

Definitely, I need more vacation.

Sep 5 2018, 8:41 AM · Frameworks
jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

Do not delete recursively.
Do not delete the file after 30s (we know it is already deleted).

Sep 5 2018, 7:56 AM · Frameworks
jtamate added inline comments to D15180: kioexecd: watch for creations or modifications of the temporary files.
Sep 5 2018, 7:09 AM · Frameworks

Sep 4 2018

jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

I missed that part, sorry.
It is safer that way, the start(time) method was added in Qt 5.8.

Sep 4 2018, 8:01 AM · Frameworks
jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

Done.

Sep 4 2018, 7:35 AM · Frameworks
jtamate updated the diff for D15180: kioexecd: watch for creations or modifications of the temporary files.

Implemented Anthony comments/suggestions.

Sep 4 2018, 6:32 AM · Frameworks