- User Since
- Jul 2 2016, 9:23 AM (128 w, 3 d)
I'll work on the unit test this weekend. I don't currently have enough free time on weekdays.
There is no need for a unit test, it is already in kdirmodeltest (but perhaps could be expanded in another patch).
Sun, Dec 16
I think this time I got the problem right.
One of the classics: I was modifying the list while it was being used.
Let's continue on D17619
Sat, Dec 15
I'm able to reproduce the bug with the following steps:
- Create a folder structure X/X1/X2/X3/X4 and add a new empty text file into each folder.
- Within Dolphin, open a tab for each folder.
- In the tab showing X contents, rename X1 to X1_ and the crash is there.
I've been able to reproduce the bug:
Oct 26 2018
What protocol does KTcpSocket::SecureProtocols implement (I can't guess it)? If it is the same as QSsl:SecureProtocols
On the client side, this will send a TLS 1.0 Client Hello, enabling TLSv1_0 and SSLv3 connections. On the server side, this will enable both SSLv3 and TLSv1_0 connections.
Oct 22 2018
Oct 21 2018
Oct 14 2018
Oct 10 2018
Oct 9 2018
Oct 8 2018
Just in case, I'm subscribed now to the RSS https://build.kde.org/job/Frameworks/job/kio/rssFailed
QTest::qWaitForWindowActive fails because I use kwin Focus stealing prevention High, therefore the windows doesn't become active until I click on them in the task bar or switch to them.
And qWaitForWindowExposed doesn't help because the window/widget needs to have the focus.
Fix a crash ,caused by a still connected signal, after running again the unittests.
kfilewidgettest still doesn't pass because QTest::qWaitForWindowActive fails for me.
I am really, really sorry. I have no excuses to not have run the autotests (that I usually run after my first fiasco). Hopefully, after my second fiasco, I'll run them before creating any review request.
Oct 7 2018
Oct 6 2018
Oct 5 2018
Keep both key sequences in case someone used ctrl+shift+n.
As it turns out, QKeySequence::AddTab is Ctrl+Shift+N under plasma.
Filled Qt bug: https://bugreports.qt.io/browse/QTBUG-70963
Change to Qt::CTRL + Qt::Key_T.
Oct 4 2018
Oct 3 2018
A comment disappeared in the conversion.
Changed 2 more 5 by 4.
Oct 2 2018
Changed comma style in initialization lists.
Using member initialization in the class declaration.
Added a constructor not detected before.
Sep 30 2018
Sep 29 2018
No email was sent with yesterday update (or I didn't receive any), this comment is just to notify yesterday change.
Sep 28 2018
Removed the tooltip, I think it is counterproductive now.
Changed the button text into + icon.
Sep 26 2018
I've tried to do an automatic benchmark of the rename case, without success.
Changed code as requested.
Sep 25 2018
Sep 21 2018
Copy the methods getUserName and getGroupName from kfile, those are cached, should be faster.
Keep the fastInsert for another revision.
Forget what I just wrote. I've seen that I was missing 15 lines in between then in the phabricator diff view. :-(
Looks good to me.
What would happen if finishNotification is called twice, In line 161 and then in line 192?
My guess is that finished signal will be called twice with the same notification, and therefore KNotificationManager::notifyPluginFinished will be called twice. I don't know what will happen the second time.
Perhaps a return after line 161 is needed?
White at it, use fastInsert.
And this also fixes the search in the home directory :-).
The title in English :-).
I didn't realize the notifications are not owned by m_notifications :-(.
Just looking at the backtrace of the crash, it was the only suspicious thing.
Sep 20 2018
Sep 19 2018
Ok by side. It installs now, and don't ask for passwords.
Sep 18 2018
I'm trying to check if it works with password-protected files, but I can't install it.
The patch is missing opendocumentthumbnail.desktop.
I haven't tested it, therefore I ask: Does this thumbnailer ask for password for password protected files, like in https://bugs.kde.org/show_bug.cgi?id=394284 ?
Continue processing the XML with invalid urls.
And a trivial code deduplication, I couldn't resist.
Sep 14 2018
Another solution (not tested here but used in other projects) could be to use
with open(source, "r", encoding="utf-8") as f:
(or if the file could contain the aberration BOM, you could use "utf-8-sig")
Sep 12 2018
Sep 11 2018
Fix in D15420
Sep 10 2018
It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 . or ctest -j4 .
Sep 9 2018
Use nullptr instead of 0.
Remove the copied/pasted part of the cause of two dissconnects.
Sep 7 2018
Changed to 'Anonymous' connects and disconnects.
Changed [&] by [this]in the lambdas.
Added a lambda for KActionCollection::addAction. I didn't knew it was already possible.
Sep 6 2018
Yes, without your patch, every time I agree to upload the modified file then I have to agree to overwrite the remote file.
It does automatically upload the modified file, but wouldn't it be nicer to not get the dialog to overwrite the modified file, that of course is not there in the case of local files.
It is just a third parameter to copy and tell it to Overwrite.
Sep 5 2018
Use QDateTime::currentDateTimeUtc() instead of QDateTime::currentDateTime().
May I commit or should I wait for @elvisangelaccio to accept the changes? This time I have read the arc message, that is usually something about non tracked files:
Revision 'D15180: kioexecd: watch for creations or modifications of the temporary files' has not been accepted. Continue anyway? [y/N]
Tested, dirty is not signaled when created (at least I didn't saw the dialog for uploading the modified file).
Removed the header.
Why the mutex? I interpreted that QTimer work as an interrumpt (wrong) instead of generating events in the event queue (right).
So I've gone through all the possible mistakes one can do here:
- Design mistakes
- Security mistakes
- Misunderstanding the API.
Definitely, I need more vacation.
Do not delete recursively.
Do not delete the file after 30s (we know it is already deleted).
Sep 4 2018
I missed that part, sorry.
It is safer that way, the start(time) method was added in Qt 5.8.
Implemented Anthony comments/suggestions.