miklosm (Miklós Máté)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 13 2018, 1:13 PM (87 w, 5 d)
Availability
Available

Recent Activity

Tue, Jan 7

miklosm requested review of D26499: remove an unused header.
Tue, Jan 7, 4:05 PM · Plasma

Aug 2 2019

miklosm added a comment to D22864: use zero-based coordinate system on the plot.

Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section.

Aug 2 2019, 2:12 PM · Frameworks
miklosm added a comment to D22865: remove drawing a black line segment at the end of the plot.

and it looks unrelated to the rest of that changeset.

It does.

Do you have a commit account?
If so, I would suggest you merge after Saturday's tagging.

Aug 2 2019, 2:11 PM · Frameworks

Jul 31 2019

miklosm requested review of D22865: remove drawing a black line segment at the end of the plot.
Jul 31 2019, 9:19 PM · Frameworks
miklosm requested review of D22864: use zero-based coordinate system on the plot.
Jul 31 2019, 9:17 PM · Frameworks

Nov 23 2018

miklosm added a comment to D13314: Use file contents when selecting extractor plugin.

@miklosm shall I land this for you?

Nov 23 2018, 8:28 PM · Baloo

Sep 18 2018

miklosm added a comment to D13316: manually set format in jpeg thumbnail creator.

@miklosm, can this go in now, or it is dependent on either of your other two patches?

Sep 18 2018, 11:02 PM · Frameworks, Dolphin
miklosm added a comment to D13315: Detect mime type of local files based on their contents.

No, no. Too unreliable and against the MIME spec.

You're testing it for the ideal case, images, which have proper headers.
But there's no reliable "magic" (determination from content) to distinguish for example MSWord .doc vs Excel .xls, because it's all the same OLE storage format. Or many other cases like this.
This is why the MIME spec (which is implemented by mimeTypeForUrl) says: if the extension is known and matches a single mimetype, then that's the one.
This allows users to have control, rather than fuzzy algorithms.

Determination from content is only used when there is no extension, when multiple mimetypes are associated with the same extension (example: *.ogg can be audio or video), or when the extension is completely unknown.

Sep 18 2018, 11:02 PM · Frameworks

Jul 14 2018

miklosm added a comment to D13316: manually set format in jpeg thumbnail creator.

I guess this change makes sense (given that we are in the jpeg plugin), but what about QImageReader::decideFormatFromContent() ?

Jul 14 2018, 12:52 PM · Frameworks, Dolphin

Jun 8 2018

miklosm added a comment to D12857: Systemmonitor: use different label format when the applet is on a vertical panel.

BTW the updateInterval, which caused the conflict, is not as useful as it sounds, because the data source sends new data at a fixed 1Hz frequency.

Jun 8 2018, 9:04 PM · Plasma
miklosm updated the diff for D12857: Systemmonitor: use different label format when the applet is on a vertical panel.

Rebased on current master

Jun 8 2018, 8:33 PM · Plasma

Jun 7 2018

miklosm requested review of D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format.
Jun 7 2018, 6:22 PM · Frameworks, Dolphin

Jun 6 2018

miklosm added a comment to D12857: Systemmonitor: use different label format when the applet is on a vertical panel.

Do you need someone to land this for you, Miklós?

Jun 6 2018, 5:57 PM · Plasma

Jun 4 2018

miklosm added inline comments to D13315: Detect mime type of local files based on their contents.
Jun 4 2018, 9:26 PM · Frameworks
miklosm added a comment to D12857: Systemmonitor: use different label format when the applet is on a vertical panel.
Jun 4 2018, 8:24 PM · Plasma
miklosm added inline comments to D12857: Systemmonitor: use different label format when the applet is on a vertical panel.
Jun 4 2018, 12:50 PM · Plasma

Jun 3 2018

miklosm requested review of D13316: manually set format in jpeg thumbnail creator.
Jun 3 2018, 7:53 PM · Frameworks, Dolphin
miklosm requested review of D13315: Detect mime type of local files based on their contents.
Jun 3 2018, 7:51 PM · Frameworks
miklosm requested review of D13314: Use file contents when selecting extractor plugin.
Jun 3 2018, 7:44 PM · Baloo

May 13 2018

miklosm requested review of D12857: Systemmonitor: use different label format when the applet is on a vertical panel.
May 13 2018, 11:12 PM · Plasma
miklosm requested review of D12853: Calendar widget: fix resize.
May 13 2018, 1:29 PM · Plasma