I wonder whether the getStatus handler could be cleaned up by removing the UNKNOWN value of portStatus and removing the default: case.

Cannot use i18ncp because the number isn't integer.

KSysGuard is part of Plasma, so these changes will not be released until the next plasma release, which is 5.18 and should be released I think January next year.

We were actually saving already the value of current BT state, it was just not used. Your code assumes there is just one BT adapter, while in theory there might be more of them. What I would just is just simply not add property like m_tmpBluetoothEnabled and use m_bluetoothAdapters to check if the specific BT adapter was enabled before, that's why we save the object path together with the value. This should be done in the else if (enable && m_bluetoothAdapters.value(objPath)) branch. Just check whether it was enabled before and enable it in that case.

One thing more i forgot is https://download.kde.org/stable/applications/ needs to be somewhere else probably?

• Align arguments

Some feedback?
Else I would just try that.
For me it worked fine (obviously).

It's blurry in your screenshot because you're scaling a 22px icon up to 32px. The solution is to make a 32px version named 32-32-preferences-desktop-display-randr. BTW, the icon is not actually aligned with the grid. It's a little off here and there. You should be able to fix it easily with the node tool by snapping nodes to the grid.

rebase

In D24706#562666, @ngraham wrote:

In D24706#553074, @ngraham wrote:

I do like how obvious it makes the selected button, but by doing this, it visually overwhelms and destroys the concept of the default button (which is supposed to be the most visually distinctive button). IMO it also interferes with the the checked and hover states IMO. For example, hovering over a focused button right now inverts its text color, which I don't like at all.

Any comment on the above?

I think we can change the background color on hover, but for focus, IMO we should try playing with outlines and see if we can make it work. When the background changes based on hover, focus, and also default button status, it's just too much, and it becomes hard to tell what's what IMO.

I'm wondering if this is technically a proxy model, or rather a QAbstractListModel? Its content is not representing cells in the source model after all, which mapTo/FromSource assumes I think. It works in the example as you implement the entire QAIM interface needed for it, so the mapping functions are probably not even called, until the source model changes, or you add a selection model on top.

In D24743#562745, @gikari wrote:

I'm not very proficient in CMake, so how can I do that?

@davidedmundson - ping ;)

@bruns - ping ;)

• Invoke first run logic when indexing is turned on again after previously being turned off
• Show warning message when the user goes to turn it off, but before hitting "Apply"