murveit (Hy Murveit)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 18 2019, 6:32 AM (45 w, 4 d)
Availability
Available

Recent Activity

Thu, Jun 4

murveit committed R321:160fd208a438: Changed name to isGuidingOn and made it a private method. (authored by murveit).
Changed name to isGuidingOn and made it a private method.
Thu, Jun 4, 1:40 AM

May 22 2020

murveit committed R321:1c40d394ae25: Move where Git Tips was, and added code section at the bottom of the tips. (authored by murveit).
Move where Git Tips was, and added code section at the bottom of the tips.
May 22 2020, 10:04 AM

May 19 2020

murveit added a comment to D29817: New user log for internal guider in Phd2 log format.

I think I submitted a PR on the new repo.

May 19 2020, 8:33 AM · KDE Edu
murveit requested review of D29817: New user log for internal guider in Phd2 log format.
May 19 2020, 7:34 AM · KDE Edu

May 12 2020

murveit updated the diff for D29695: Add an internal guider calibration plot.

Changed the colors for the "out" segments to match the colors in the drift graphics

May 12 2020, 10:10 PM · KDE Edu
murveit requested review of D29695: Add an internal guider calibration plot.
May 12 2020, 9:40 PM · KDE Edu

May 6 2020

murveit requested review of D29471: Save HA Limit Enable checkbox.
May 6 2020, 7:05 AM · KDE Edu

May 5 2020

murveit added a comment to D29440: Move 2 logging statements from debug to info. printed only once per focus session..

I'd say yes, it would be useful for folks trying to tweak their focus parameters. I think is common among non-developers.

May 5 2020, 6:07 PM · KDE Edu
murveit abandoned D29440: Move 2 logging statements from debug to info. printed only once per focus session..
May 5 2020, 8:36 AM · KDE Edu
murveit added a comment to D29440: Move 2 logging statements from debug to info. printed only once per focus session..

You can see the request here
https://indilib.org/forum/general/6167-for-those-with-focus-issues.html?start=96
from dmsummers on 5/4/2020.

May 5 2020, 8:14 AM · KDE Edu
murveit requested review of D29440: Move 2 logging statements from debug to info. printed only once per focus session..
May 5 2020, 5:47 AM · KDE Edu

May 4 2020

murveit requested review of D29426: Internal guider didn't take binning into account when computing arc-seconds.
May 4 2020, 6:39 PM · KDE Edu
murveit abandoned D24256: Enable the auto-stretch Fits setting to be undone..
May 4 2020, 3:46 AM · KDE Edu

May 3 2020

murveit accepted D29389: Let UI tests customize the UI settings file..
May 3 2020, 7:56 PM · KDE Edu

May 2 2020

murveit updated the diff for D29355: Fix issue with Meridian Flip Retry.

Comments and cosmetic changes

May 2 2020, 7:24 PM · KDE Edu
murveit added a comment to D29355: Fix issue with Meridian Flip Retry.

I agree whole-heartedly with the need for doc for the state machines, but I am not on top of them, nor have I made any real changes to them. If you like, we can collaborate on some doc for mount and capture, but I think that's outside the scope of this PR.

May 2 2020, 7:22 PM · KDE Edu
murveit requested review of D29355: Fix issue with Meridian Flip Retry.
May 2 2020, 7:34 AM · KDE Edu

May 1 2020

murveit requested review of D29317: Comment out a couple wordy debug log messages.
May 1 2020, 2:22 AM · KDE Edu

Apr 27 2020

murveit accepted D29099: Make the Focus capture action include star detection.

Looks good. Thanks!

Apr 27 2020, 6:58 AM · KDE Edu

Apr 26 2020

murveit requested review of D29218: Fix bug where tab fitsviews weren't receiving images when fitsviewer was not enabled.
Apr 26 2020, 10:08 PM · KDE Edu

Apr 25 2020

murveit requested review of D29192: Improve Overlay Rendering.
Apr 25 2020, 10:09 PM · KDE Edu

Apr 22 2020

murveit updated the diff for D29085: Fix stretch control bug created in D28935.

Also don't draw overlays for the stretch preview image

Apr 22 2020, 8:14 AM · KDE Edu
murveit requested review of D29085: Fix stretch control bug created in D28935.
Apr 22 2020, 7:48 AM · KDE Edu

Apr 21 2020

murveit added a comment to D28935: Reduce memory use when zooming in fitsviewer.

Honestly, I don't know and can't test. However, it shouldn't fail. See line 161 in fitsview.cpp.
If the system call on Windows doesn't support the _SC_PHYS_PAGES request,
it should return -1 according to http://man7.org/linux/man-pages/man3/sysconf.3.html
and then we should get the 300% default.

Apr 21 2020, 7:06 AM · KDE Edu
murveit added a comment to D28935: Reduce memory use when zooming in fitsviewer.

Jasem, as requested, I added several lines in the constructor to see if the amount of physical memory is known, and if so, I created max zoom values based on that. See lines 154-177 in fitsview.cpp. Could have gone further and made it a function of the image W*H*C and physical memory, but honestly I'm not sure that's a good idea. Let me know if you disagree and if so, how much zoom for how much physcial memory and image size. Now, you can zoom up to 600% if you have 16Gb of memory. On my 32Gb MacbookPro, this is now limited by CPU more than memory. Tested on 32Gb Mac/Catalina (where the limit is 600%) and on Raspbian RPi4 4Gb (where the limit is 300%). According to online doc, some systems may not reveal the amount of physical memory. In that case the limit should be 300%.

Apr 21 2020, 6:08 AM · KDE Edu
murveit updated the diff for D28935: Reduce memory use when zooming in fitsviewer.

Adjust the maximum permissible zoom based on the amount of physical memory.

Apr 21 2020, 6:01 AM · KDE Edu

Apr 19 2020

murveit abandoned D27668: Save solver accuracy.
Apr 19 2020, 11:48 PM · KDE Edu

Apr 18 2020

murveit requested review of D28935: Reduce memory use when zooming in fitsviewer.
Apr 18 2020, 6:01 AM · KDE Edu

Apr 16 2020

murveit added a comment to D28767: SEP Focus improvements.

Forgot to add the URL to the example image in my last comment.
It's https://photos.app.goo.gl/tG5yheZyfxHWoJ788
and it's also at the bottom of the album with all the images:
https://photos.app.goo.gl/CHgXVZBREA19LVgN8

Apr 16 2020, 8:06 AM · KDE Edu
murveit added a comment to D28767: SEP Focus improvements.

Eric, I apologize but I don't fully understand your suggestion. I haven't changed it from an ellipse to a circle. It was a circle before, and I've kept it a circle. What I was trying to do is remove the noise from using the poor width estimate as a radius and replace it with double the HFR, which is much more consistent, as my images show. I didn't intentionally change where the center was, so if the center is off now, it was likely off before, e.g. note in the images I sent, the images on the right, offsets are noticable on some stars, is the "before" picture, that doesn't have my changes. Note, one thing I did change, though, is now I give Qt a float for the coordinates, whereas previous it was truncated to an int. Do you think that had an adverse affect? If you see an error in my code for centering these circles, please let me know and I'd be happy to fix it.

Apr 16 2020, 8:04 AM · KDE Edu
murveit updated the diff for D28767: SEP Focus improvements.

Adjust the center position of circles drawn around stars by half a pixel.

Apr 16 2020, 8:04 AM · KDE Edu
murveit added a comment to D28767: SEP Focus improvements.

Rob, I actually disagree that you get the accurate saturation value. E.g. your technique wouldn't work for signed shorts or signed bytes or floating point where the range is 0 to 1.0, or for that matter, cameras where Indi would put out 0-4K values, etc. In the end, I think we'll need a user-supplied input for this, but all that, I think, should get worked out when you complete your Sextractor parameter integration, and this could be one of the parameters that we offer the user the ability to modify. Until then, I believe this will be good enough. It shouldn't do any harm, and it might improve the situation over the current system. I did, though, modify my code to check to see if it was a byte type, and if so, change the saturation threshold to 250.

Apr 16 2020, 6:24 AM · KDE Edu
murveit updated the diff for D28767: SEP Focus improvements.

Modified saturation value if the data type is byte.

Apr 16 2020, 6:17 AM · KDE Edu

Apr 15 2020

murveit updated the diff for D28767: SEP Focus improvements.

Reduced the disk footprint of the test fixtures.

Apr 15 2020, 9:06 PM · KDE Edu

Apr 13 2020

murveit updated the diff for D28767: SEP Focus improvements.

Added tests at 3 different HFRs

Apr 13 2020, 7:12 AM · KDE Edu

Apr 12 2020

murveit added a comment to D28767: SEP Focus improvements.

Addressing your comment for line 789 of fitsview.cpp.
> I disagree : it was like this before, but small stars ellipses become offset because of rounding issues on the pixel center.

Apr 12 2020, 10:40 PM · KDE Edu
murveit added a comment to D28767: SEP Focus improvements.

Thanks. I'll discuss your other comments in a bit, but first here is detail on the speedup. The basic idea is that previously the code was calling sep_flux_radius, an expensive call, on all detections unnecessarily. Instead, I first sort of the detected stars' oval size, since we are only keeping the largest stars, and only call sep_flux_radius on the stars we intend to keep. I checked and sorting by HFR after calling sep_flux_radius on all stars vs first sorting by oval radii and only calling sep_flux_radius on those give almost the same set of stars. 

Apr 12 2020, 8:26 PM · KDE Edu
murveit abandoned D28477: Fixes a bug where the HFR was not displayed..

I am abandoning these changes.
Eric has refactored the code, and I have sent in the updated https://phabricator.kde.org/D28767 to replace this PR.

Apr 12 2020, 6:57 AM · KDE Edu
murveit requested review of D28767: SEP Focus improvements.
Apr 12 2020, 6:54 AM · KDE Edu

Apr 10 2020

murveit requested review of D28716: Fix the build which is broken on Macs by adding include for cmath.
Apr 10 2020, 3:26 AM · KDE Edu

Apr 5 2020

murveit added a comment to D28477: Fixes a bug where the HFR was not displayed..

@TallFurryMan Thanks Eric. I assume that at this point, I'm waiting for you to contact me and give me instructions on how to proceed.
Happy to add the test, but may need some hand-holding this first time.

Apr 5 2020, 6:31 PM · KDE Edu

Apr 4 2020

murveit updated the diff for D28477: Fixes a bug where the HFR was not displayed..

Added a significant bug fix and speedup.

Apr 4 2020, 9:55 PM · KDE Edu

Apr 3 2020

murveit updated the diff for D28477: Fixes a bug where the HFR was not displayed..

Reverted back to CENTROID as findStars default, still use SEP for mark stars, added hfr to status

Apr 3 2020, 9:40 PM · KDE Edu

Apr 1 2020

murveit requested review of D28477: Fixes a bug where the HFR was not displayed..
Apr 1 2020, 8:59 AM · KDE Edu

Mar 7 2020

murveit requested review of D27907: Fix a bug in the debayer offset code..
Mar 7 2020, 1:53 AM · KDE Edu

Mar 6 2020

murveit requested review of D27880: Update median calculation.
Mar 6 2020, 8:27 AM · KDE Edu

Feb 26 2020

murveit added a comment to D27668: Save solver accuracy.

I'm happy to drop this, or to fix it as you suggest. Let me know your preference and if you do recommend the change, which other parameters should be affected as well.

Feb 26 2020, 8:31 AM · KDE Edu
murveit requested review of D27670: Correct bug in median computation.
Feb 26 2020, 8:24 AM · KDE Edu
murveit requested review of D27668: Save solver accuracy.
Feb 26 2020, 1:59 AM · KDE Edu

Feb 16 2020

murveit added a comment to D27437: Add logging to help debug some capture stalls.

Jasem, I understand you sentiments, but in this case I respectfully disagree.
Here, the first 3 debug log statements will add at most one line per initiation of autofocus, and most likely nothing at all.
That's 0-10 or 20 lines in logs that can be > 100K lines. The final log statement would add one one line per capture.
While that could be a hundred lines per log, again, a tiny percentage, and could help us debug a hard-to-find bug.

Feb 16 2020, 8:04 PM · KDE Edu
murveit requested review of D27437: Add logging to help debug some capture stalls.
Feb 16 2020, 5:20 PM · KDE Edu

Feb 11 2020

murveit updated the diff for D27314: Fixes issue where align wasn't called after meridian flip.

Restored the conditions for the emit to what existed before https://phabricator.kde.org/D27274

Feb 11 2020, 9:32 AM · KDE Edu
murveit requested review of D27314: Fixes issue where align wasn't called after meridian flip.
Feb 11 2020, 9:23 AM · KDE Edu
murveit requested review of D27311: Add logging to look into alignState in capture.
Feb 11 2020, 7:28 AM · KDE Edu

Feb 10 2020

murveit requested review of D27275: Remove the word experimental from the Linear Focus algorithm.
Feb 10 2020, 8:58 AM · KDE Edu
murveit requested review of D27274: Correct issue with filter-autofocus and meridian flip.
Feb 10 2020, 8:43 AM · KDE Edu

Feb 3 2020

murveit updated the diff for D27115: Fix bug which may be causing the fits crashes..

Made the filename arg passed to writeImageFile a const.

Feb 3 2020, 5:21 AM · KDE Edu
murveit updated the diff for D27115: Fix bug which may be causing the fits crashes..

Made sure the filename was not overwritten when waiting for the thread to complete

Feb 3 2020, 5:04 AM · KDE Edu
murveit requested review of D27115: Fix bug which may be causing the fits crashes..
Feb 3 2020, 4:42 AM · KDE Edu

Jan 31 2020

murveit requested review of D27051: Linear Focus 3.2, optimize solution.
Jan 31 2020, 4:25 AM · KDE Edu

Jan 27 2020

murveit requested review of D26933: Fix a crash, reinitialize rawImage for every image..
Jan 27 2020, 9:56 AM · KDE Edu

Jan 25 2020

murveit requested review of D26910: Bugfix for fitsview, checking wrong width & height in initDisplayImage.
Jan 25 2020, 1:15 AM · KDE Edu

Jan 22 2020

murveit requested review of D26854: Linear Focus Algorithm 3.1, ignore timer-based focuser's return value..
Jan 22 2020, 8:47 PM · KDE Edu

Jan 20 2020

murveit requested review of D26778: Re-allocate the rawImage buffer if the number of channels has changed..
Jan 20 2020, 7:38 AM · KDE Edu

Jan 15 2020

murveit requested review of D26687: Improvements to the linear focus algorithm--v3.
Jan 15 2020, 9:55 AM · KDE Edu

Jan 13 2020

murveit requested review of D26615: Update of the Linear Focus Algorithm--v2.
Jan 13 2020, 6:28 AM · KDE Edu

Jan 3 2020

murveit requested review of D26384: Refactor polynomial code in focus and other small changes.
Jan 3 2020, 9:12 AM · KDE Edu

Dec 28 2019

murveit requested review of D26251: Modify focus graph to include sample number..
Dec 28 2019, 7:52 AM · KDE Edu
murveit updated the diff for D26240: Modify focus plot to include sample number.

Previous submission had bad user.email, trying again.

Dec 28 2019, 7:40 AM · KDE Edu

Dec 27 2019

murveit updated the diff for D26240: Modify focus plot to include sample number.

Made the background white.

Dec 27 2019, 5:13 PM · KDE Edu
murveit requested review of D26240: Modify focus plot to include sample number.
Dec 27 2019, 7:58 AM · KDE Edu

Dec 25 2019

murveit requested review of D26218: Improve Linear Focus Algorithm by adding extra outward motion then moving back in..
Dec 25 2019, 8:47 AM · KDE Edu

Dec 18 2019

murveit updated the diff for D26075: Introduce the linear focuser.

Updates for i18n/i18np and for author header.

Dec 18 2019, 8:26 AM · KDE Edu
murveit requested review of D26075: Introduce the linear focuser.
Dec 18 2019, 1:33 AM · KDE Edu

Dec 7 2019

murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

Thanks for the review and testing Jasem.
I addressed your tooltip-concern in my latest update.
I don't quite understand how to respond to your other concern (re hiding the contols).

Dec 7 2019, 8:05 PM · KDE Edu
murveit updated the diff for D25645: New UI to allow the user to modify the stretch being used..

Adjusted stretch button tooltips depending on their state.

Dec 7 2019, 7:52 PM · KDE Edu

Dec 4 2019

murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

The difference is subtle and IMHO it would not be obvious to many users.
I think this is much clearer.
You can try it by disabling the clear--comment out line 184 in fitstab.cpp

Dec 4 2019, 6:55 PM · KDE Edu
murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

Rob, That's working as intended. I clear the button and disabled it when selecting it didn't make sense. It only appears when there's something to do.
I tried it the way you suggest and it was confusing--the user could hit the button and nothing really would happen (e.g. I made an info pop-up, but in the end, I though the better thing to do was this).

Dec 4 2019, 6:49 PM · KDE Edu

Dec 3 2019

murveit updated the diff for D25645: New UI to allow the user to modify the stretch being used..

Moved from QCheckBox to QPushButton for the stretch and auto buttons.
Auto button is only enabled when it makes sense.
Sorry, the blank auto-button is a little wider when disabled,
couldn't figure out how to avoid that.

Dec 3 2019, 9:31 AM · KDE Edu

Dec 2 2019

murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

Rob: Thanks for describing the bug related to the slider value display. I was able to reproduce and fix. You should not see that behavior anymore.

Dec 2 2019, 7:11 AM · KDE Edu
murveit updated the diff for D25645: New UI to allow the user to modify the stretch being used..

Fix bug related to updated slider text value when auto is checked.

Dec 2 2019, 6:59 AM · KDE Edu
murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

I implemented Rob's suggestion to disable the sliders and their labels and the auto checkbox when stretching is disabled.
I think this was a good idea.

Dec 2 2019, 4:47 AM · KDE Edu
murveit updated the diff for D25645: New UI to allow the user to modify the stretch being used..

Disable most of the stretch UI when stretching is disabled.

Dec 2 2019, 4:45 AM · KDE Edu
murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

Rob, thanks for all the suggestions and questions. Let me respond before I make any code changes.

Dec 2 2019, 3:40 AM · KDE Edu
murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

Thanks again for testing and checking out the interface.

Dec 2 2019, 12:18 AM · KDE Edu
murveit updated the diff for D25645: New UI to allow the user to modify the stretch being used..

Fixed issue when stretching float or double fits file.

Dec 2 2019, 12:13 AM · KDE Edu

Dec 1 2019

murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

BTW, I see the problem with the floating point file.
The issue is that I need to normalize the number--the values needed to stretch are 1/64K as big as the 64K-scale-shorts, and so they underflow the 10000 scale I was using.
I will address this in the next couple days.

Dec 1 2019, 6:32 PM · KDE Edu
murveit added a comment to D25645: New UI to allow the user to modify the stretch being used..

Jasem & Rob, thanks for the initial comments.

Dec 1 2019, 6:25 PM · KDE Edu
murveit updated the diff for D25645: New UI to allow the user to modify the stretch being used..

Fix bug that hid the labels.

Dec 1 2019, 6:11 PM · KDE Edu
murveit requested review of D25645: New UI to allow the user to modify the stretch being used..
Dec 1 2019, 8:12 AM · KDE Edu

Nov 26 2019

murveit added a comment to D24256: Enable the auto-stretch Fits setting to be undone..

This is out-of-date, I guess abandoned, and the new scheme is an improvement, IMHO.
Is there something I need to do to delete/abandon it?

Nov 26 2019, 9:05 PM · KDE Edu

Nov 24 2019

murveit added a comment to D25497: Fix bug re filter-change-autofocus.

Perhaps I'm missing the obvious, but I don't see it. I don't want to overwrite secondsLabel. How would I use a fall through?

Nov 24 2019, 10:43 PM · KDE Edu
murveit updated the diff for D25497: Fix bug re filter-change-autofocus.

Added secondsLabel update to current change.
Capture should show that it's focusing while waiting for the filterManager.

Nov 24 2019, 10:06 PM · KDE Edu
murveit added a comment to D25497: Fix bug re filter-change-autofocus.

Wolfgang: Makes sense.
I assume what you mean is that I should do something like this:

secondsLabel->setText( i18n("Focusing..."));

just before the call to QTimer::singleShot(), where the text is dependent on filterManagerState.
E.g. if filterManagerState == FILTER_FOCUS then "Focusing...", if FILTER_CHANGE then "Changing Filters...", if FILTER_OFFSET then "Changing Focus Offset...".
I'll modify my change and do that.

Nov 24 2019, 9:07 PM · KDE Edu
murveit added a comment to D25497: Fix bug re filter-change-autofocus.

That's true, though, as far as I know, that shouldn't happen.

Nov 24 2019, 8:34 PM · KDE Edu
murveit added a comment to D25497: Fix bug re filter-change-autofocus.

Sorry for not filling that out. Here's what to check.

Nov 24 2019, 7:11 AM · KDE Edu

Nov 23 2019

murveit requested review of D25497: Fix bug re filter-change-autofocus.
Nov 23 2019, 10:40 PM · KDE Edu
murveit requested review of D25483: Fix off-by-one bug in stretch..
Nov 23 2019, 2:19 AM · KDE Edu

Nov 19 2019

murveit updated the diff for D25318: Update the auto-stretch scheme and UI.

Fixed file permissions, which were accidentally set wrong.

Nov 19 2019, 9:40 AM · KDE Edu
murveit updated the diff for D25318: Update the auto-stretch scheme and UI.

Removed some of the templating and refactored to simplify code.
Added highlighting to the stretch buttons when the image is stretched.
Needed to run initDisplayImage always in rescale, and not sure why.
Will continue to investigate.

Nov 19 2019, 9:32 AM · KDE Edu