- User Since
- Jul 16 2018, 3:21 PM (61 w, 2 d)
Tue, Sep 17
Sat, Sep 14
Thu, Sep 12
Use QSKIP to skip tests
Wed, Sep 11
Use QStandardPaths::findExecutable to locate lsof
Mon, Sep 9
Sat, Sep 7
Fri, Sep 6
Review comments, renamed the files to match the class name
Thu, Sep 5
Tue, Sep 3
Removed KListOpenFiles namespace and renamed ListOpenFilesJob to KListOpenFilesJob
Mon, Sep 2
I have added a minimal Windows implementation which always emits an error, along with a unit test. Please review it thoroughly and then I think it is ready to land :)
Review comments. Added minimal Windows implementation which basically always reports failure with the error code Unsupported.
Fri, Aug 30
One thing, when this is ready to land I will address the Windows support so that we do not get broken builds :)
@dfaure - Overall, what do you think about the approach of subclassing KJob? Did it turn out like you had thought? And is this the solution we should go with, or was one of the other solutions better?
Thu, Aug 29
Add bug reference
Fixed review comments, rebased.
@meven , so I finally managed to rewrite this patch to use KJob instead. Please take a look at it again and see if this is better approach :)
Rewrote the code to use KJob
Aug 17 2019
Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.
Aug 16 2019
Aug 13 2019
Aug 8 2019
@ngraham - Hey Nate, if you have time I would like to pick this patch up again, what are your thoughts on how we progress this? Currently this patch depends on D20867 being merged and released and also a change to KWidgetAddons (F6773036), so one approach could be to focus the review effort on those changes first? We have previously discussed various ways to simplify this change, but no other suitable solutions has been found, but I am still open to simpler solutions :)
Jun 27 2019
Jun 26 2019
Hi @ngraham - I have looked into this patch set and it is a little tedious to test, you have to do the following:
Jun 21 2019
Jun 20 2019
Jun 16 2019
Jun 12 2019
First of, this is WIP, I just wanted to share this early to get some feedback. The reasoning for this is to generalize functionality for running lsof, this is currently in use by the Device Notifier applet and I would like to use it in Dolphin to fix bug #189302. Also see the discussion in D19989 for details.
Jun 1 2019
May 28 2019
May 27 2019
May 20 2019
@davidedmundson - Hi David! I am (finally) starting to look at implementing the lsof functionality in Solid, but I am unsure of where exactly to place it in Solid? Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?
May 15 2019
May 13 2019
This has been fixed in D21050
Hi @ngraham - any update on this one? Should we move forward with this approach or should we do something else?
May 6 2019
Thanks for the review! Landing it now.
@elvisangelaccio - is it ok to merge this change now or do we need to wait for anything else?
@davidedmundson - ping ?
May 3 2019
I have tried to modify the fstab backend to also show fuse mounts and a very simple prototype is this:
May 2 2019
May 1 2019
This commit is still work-in-progress, but I would really like to get some feedback to the approach. Does it make sense to add a new backend? Or should this functionality be merged with one of the other backends (I was considering the fstab backend)?
Apr 29 2019
Share bookmarks.xml with kfile