hallas (David Hallas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2018, 3:21 PM (44 w, 11 h)
Availability
Available

Recent Activity

Yesterday

hallas added a comment to D19989: Unmounting busy device doesn't tell who is blocking.

@davidedmundson - Hi David! I am (finally) starting to look at implementing the lsof functionality in Solid, but I am unsure of where exactly to place it in Solid? Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?

Mon, May 20, 5:24 PM · Dolphin

Wed, May 15

hallas added inline comments to D21235: Add handling of fuseiso filesystem type.
Wed, May 15, 7:30 PM · Frameworks
hallas requested review of D21235: Add handling of fuseiso filesystem type.
Wed, May 15, 7:29 PM · Frameworks

Mon, May 13

hallas abandoned D20024: Fixes crash when hiding devices.

This has been fixed in D21050

Mon, May 13, 3:00 PM · Dolphin
hallas committed R318:78540e49213e: Summary: Fixes crash when hiding devices (authored by hallas).
Summary: Fixes crash when hiding devices
Mon, May 13, 2:58 PM
hallas closed D21050: Summary: Fixes crash when hiding devices.
Mon, May 13, 2:58 PM · Dolphin
hallas added a comment to D20867: Add Property to disable drawing of menu arrow indicators.

Hi @ngraham - any update on this one? Should we move forward with this approach or should we do something else?

Mon, May 13, 2:55 PM · Plasma
hallas committed R318:2fac50f5f59b: Add Bookmark Handling (authored by hallas).
Add Bookmark Handling
Mon, May 13, 2:37 PM
hallas closed D19926: Add Bookmark Handling.
Mon, May 13, 2:37 PM · Dolphin

Mon, May 6

hallas committed R244:fdf02e26749d: Add GetProcessList for retrieving the list of currently active processes (authored by hallas).
Add GetProcessList for retrieving the list of currently active processes
Mon, May 6, 5:48 PM
hallas closed D20007: Add GetProcessList for retrieving the list of currently active processes.
Mon, May 6, 5:48 PM · Frameworks
hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Thanks for the review! Landing it now.

Mon, May 6, 5:48 PM · Frameworks
hallas added a comment to D20024: Fixes crash when hiding devices.

Please also update the commit message (the fix is now different).

Mon, May 6, 5:35 PM · Dolphin
hallas requested review of D21050: Summary: Fixes crash when hiding devices.
Mon, May 6, 5:34 PM · Dolphin
hallas added a comment to D19926: Add Bookmark Handling.

@elvisangelaccio - is it ok to merge this change now or do we need to wait for anything else?

Mon, May 6, 5:28 PM · Dolphin
hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

@davidedmundson - ping ?

Mon, May 6, 5:28 PM · Frameworks
hallas added a comment to D20867: Add Property to disable drawing of menu arrow indicators.
In D20867#461499, @mart wrote:

QToolButton::setArrowType?

I just tried that, but it doesn't seem like Breeze honors this property - at least not for the QToolButton produced by KToolBarPopupAction. So adding

That's probably a breeze bug and that's where it should be addressed.
an application can't link to breeze, especially if is private api. (and would explode dependencies in distros package managers)

Mon, May 6, 5:27 PM · Plasma
hallas abandoned D20938: Add Mounts Backend.
Mon, May 6, 5:18 PM · Frameworks
hallas added a comment to D20938: Add Mounts Backend.

This patch has been superseeded by the wotk @bruns has done in D20995 - so closing this one :D

Mon, May 6, 5:18 PM · Frameworks
hallas added inline comments to D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts.
Mon, May 6, 5:14 PM · Frameworks
hallas added inline comments to D20995: [Fstab] Add support for non-network filesystems.
Mon, May 6, 3:29 PM · Frameworks
hallas added inline comments to D20995: [Fstab] Add support for non-network filesystems.
Mon, May 6, 3:10 PM · Frameworks

Fri, May 3

hallas added a comment to D20938: Add Mounts Backend.

I have tried to modify the fstab backend to also show fuse mounts and a very simple prototype is this:

Fri, May 3, 5:54 AM · Frameworks

Thu, May 2

hallas added a comment to D20938: Add Mounts Backend.

Solid already has a working implementation for reading from /proc/mounts, the fstab backend.

Contrary to this code, the fstab backend does not poll every second using a timer, but correctly uses /proc/mounts changes notification via blocking read.

The only thing needed is a small extension to also hand out information for other filesystems than nfs and cifs.

This was exactly the kind of review comments I was looking for :D Let me take a new stab at this where I extend the current fstab with this functionality so we can see how that solution compares to this one.

I already have/had some code for this laying on my hard disk, I will post this as a WIP later today ...

Thu, May 2, 5:41 PM · Frameworks
hallas added a comment to D20938: Add Mounts Backend.

Solid already has a working implementation for reading from /proc/mounts, the fstab backend.

Contrary to this code, the fstab backend does not poll every second using a timer, but correctly uses /proc/mounts changes notification via blocking read.

The only thing needed is a small extension to also hand out information for other filesystems than nfs and cifs.

Thu, May 2, 5:39 PM · Frameworks
hallas added a comment to D20938: Add Mounts Backend.
In D20938#459149, @ivan wrote:

I'm torn between two approaches:

  • doing what you have done, maybe with a customization point - fusermount -u by default, something else for specific mount types;
  • disabling the teardown operation

    The rationale for the second one:
  • The users which create fuse mounts from the shell know how to unmount them;
  • Users which used a tool to mount something (like Plasma Vault) should use the same tool to unmount (these tools potentially do more than simple unmounting - like calling a destructor in C++ instead of just free :) );
  • Some applications will have their own mounts (for example, akonadi will use encrypted storage for storing indexes of encrypted mails) - you don't want to have those controlled by the user.*

    (*) we will also need to hide these from Places, but that is not important at this point.
Thu, May 2, 5:38 PM · Frameworks

Wed, May 1

hallas added a comment to D20938: Add Mounts Backend.
In D20938#459076, @ivan wrote:

Thanks for working on this.

I'd probably call this fusemounts backend as it handles only FUSE mounts and nothing else.

As for the teardown operation, some FUSE backends (cryfs >0.10) have their own unmount commands instead of fusermount -u.

Wed, May 1, 5:23 PM · Frameworks
hallas added a comment to D20938: Add Mounts Backend.

This commit is still work-in-progress, but I would really like to get some feedback to the approach. Does it make sense to add a new backend? Or should this functionality be merged with one of the other backends (I was considering the fstab backend)?

Wed, May 1, 2:26 PM · Frameworks
hallas requested review of D20938: Add Mounts Backend.
Wed, May 1, 2:24 PM · Frameworks

Mon, Apr 29

hallas updated the diff for D19926: Add Bookmark Handling.

Share bookmarks.xml with kfile

Mon, Apr 29, 3:06 PM · Dolphin
hallas added a comment to D19926: Add Bookmark Handling.

We would probably like to allow the bookmarks to be accessible from KIOFileWidgets open/save dialog, somehow.
There is already a bookmark feature there, it would be great if the two matches.

KFileBookmarkHandler loads from "kfile/bookmarks.xml" the bookmarks.
Could this xml file be shared with dolphin ?

Mon, Apr 29, 2:50 PM · Dolphin

Sun, Apr 28

hallas added a comment to D20867: Add Property to disable drawing of menu arrow indicators.

QToolButton::setArrowType?

Sun, Apr 28, 5:20 PM · Plasma
hallas added a comment to D20867: Add Property to disable drawing of menu arrow indicators.

QToolButton::setArrowType?

Sun, Apr 28, 5:15 PM · Plasma
hallas added a comment to D20867: Add Property to disable drawing of menu arrow indicators.

There shouldn't be any Breeze specific code in client apps. It's a sign of something being wrong.

What's a navigation style toolbutton and where do you want to use this?

Sun, Apr 28, 5:05 PM · Plasma
hallas added a comment to D19311: Add navigation history to forward/back buttons.

What happens if the user is using an old version of breeze that doesn't have this new property? Will they get the arrows?

Sun, Apr 28, 10:51 AM · Dolphin

Sat, Apr 27

hallas committed R294:d8b9ceba1fd9: Fix KBoomarkMenuTest when Bookmarks Editor is not installed (authored by hallas).
Fix KBoomarkMenuTest when Bookmarks Editor is not installed
Sat, Apr 27, 2:11 PM
hallas closed D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed.
Sat, Apr 27, 2:11 PM · Frameworks
hallas added a comment to D19311: Add navigation history to forward/back buttons.

Sure thing. Please listen to @elvisangelaccio rather than my deluded ravings! :)

Sat, Apr 27, 1:57 PM · Dolphin
hallas requested review of D20867: Add Property to disable drawing of menu arrow indicators.
Sat, Apr 27, 1:57 PM · Plasma
hallas updated the diff for D19926: Add Bookmark Handling.

Review comments

Sat, Apr 27, 1:54 PM · Dolphin
hallas updated the diff for D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed.

Make the global functions static.

Sat, Apr 27, 1:42 PM · Frameworks
hallas added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

@hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/

Hi @aacid - I can't reproduce the test failure locally! I am running Gentoo Linux with Qt 5.11.3 - do you have any idea what could be wrong? Can you reproduce the issue?

It may have to do with how much "extra" stuff is there on your system. You can try running the docker infrastructure (needs some space+internet downloads), this should make it easier to reproduce
https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine

It works here too but i don't have all the frameworks as of master, maybe that's the issue and a framework this depends on creates the issues?

Sat, Apr 27, 7:11 AM · Frameworks
hallas requested review of D20860: Fix KBoomarkMenuTest when Bookmarks Editor is not installed.
Sat, Apr 27, 7:10 AM · Frameworks

Thu, Apr 25

hallas added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

@hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/

Thu, Apr 25, 5:14 PM · Frameworks
hallas added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

@hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/

Thu, Apr 25, 5:03 AM · Frameworks

Wed, Apr 24

hallas committed R294:abed768add92: Add support for KBookmarkOwner to communicate if it has tabs open (authored by hallas).
Add support for KBookmarkOwner to communicate if it has tabs open
Wed, Apr 24, 3:40 PM
hallas closed D20209: Add support for KBookmarkOwner to communicate if it has tabs open.
Wed, Apr 24, 2:41 PM · Frameworks

Tue, Apr 23

hallas added inline comments to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.
Tue, Apr 23, 5:34 PM · Frameworks
hallas updated the diff for D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Review comments

Tue, Apr 23, 5:34 PM · Frameworks

Mon, Apr 22

hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

@davidedmundson - Ping ;)

Mon, Apr 22, 5:48 PM · Frameworks
hallas added inline comments to D20024: Fixes crash when hiding devices.
Mon, Apr 22, 5:47 PM · Dolphin
hallas updated the diff for D20024: Fixes crash when hiding devices.

Change KStandardItem to derive from QObject, and use deleteLater when removing an item.

Mon, Apr 22, 5:45 PM · Dolphin
hallas added inline comments to D19926: Add Bookmark Handling.
Mon, Apr 22, 5:15 PM · Dolphin
hallas updated the diff for D19926: Add Bookmark Handling.

Print qWarning if GenericDataLocation is empty

Mon, Apr 22, 5:15 PM · Dolphin
hallas added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Urgh. Indeed. And looking around I find many inline virtuals in apparently public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff (though maybe some of these don't have d pointers at all...)

About KBookmarkOwner, the lack of an explicit constructor is a problem too (apps wouldn't instanciate the d pointer). I just added TODO KF6 comments, for the next person in your position: https://commits.kde.org/kbookmarks/746ecc8db9a04e4d47adc62b0aa03733ca8ecdf8

Meanwhile we have to find another way. Would my idea of adding methods to KBookmarkMenu work out?

Mon, Apr 22, 1:43 PM · Frameworks
hallas updated the diff for D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Reworked the patch to avoid any ABI breakage. Now the new functionality is in KBookmarkMenu instead.

Mon, Apr 22, 1:41 PM · Frameworks
hallas added a comment to D19311: Add navigation history to forward/back buttons.

The Breeze patch looks sane. I'm torn on whether or not adding the new style to KWidgetsAddons makes sense though. Couldn't Dolphin just set the new _kde_toolButton_noMenuArrow on just these buttons?

Mon, Apr 22, 12:58 PM · Dolphin
hallas added inline comments to D19926: Add Bookmark Handling.
Mon, Apr 22, 12:54 PM · Dolphin
hallas updated the diff for D19926: Add Bookmark Handling.

Review comments

Mon, Apr 22, 12:54 PM · Dolphin

Apr 14 2019

hallas added inline comments to D20007: Add GetProcessList for retrieving the list of currently active processes.
Apr 14 2019, 6:14 PM · Frameworks
hallas updated the diff for D20007: Add GetProcessList for retrieving the list of currently active processes.

Review comments

Apr 14 2019, 6:14 PM · Frameworks
hallas added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Hi @dfaure - I looked into this a bit more and have run into a problem, I hope you can help solve. The problem is that when I add a getter and a setter for the number of open tabs, I need to store the value somewhere in KBookmarkOwner but I guess I cannot add a member variable, since that breaks binary compatibility. But luckily this class has a d-Pointer KBookmarkOwnerPrivate in the member variable d, but there is no definition of KBookmarkOwnerPrivate and therefore it is not constructed anywhere, this is not a problem since I could just make one, the problem is that the virtual destructor for KBookmarkOwner is implemented directly in the header file, and I don't think I can move (and change) the implementation to the .cpp file without breaking binary compatibility? Also I should probably also implement a copy constructor and assignment operator in KBookmarkOwner if we actually use the d-Pointer, right? And this would also break binary compatibility.

Apr 14 2019, 6:08 PM · Frameworks
hallas added a comment to D19311: Add navigation history to forward/back buttons.
  • Modify/extend the Breeze theme to draw this button (via some special flag or something) without arrows, even though it has a delayed menu (maybe this should be a general change). Personally this would be my choice.

I agree, this is best. For inspiration, you might check out the following abandoned Breeze patch that did something similar and allowed opting out on a widget-by-widget basis: D13064 Maybe all we need to do is implement that opting-out mechanism for existing press-and-hold menu toolbuttons, and then set the hint in these buttons here.

Apr 14 2019, 5:52 PM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

@richardl - thanks for the feedback! I tend to agree with @david.fontanals in that it makes most sense to only show the back history in the back button and the forward history in the forward button. This also seems to be the behavior of Chrome (though I don't know how much it matters :) ).

Apr 14 2019, 5:40 PM · Dolphin
hallas added inline comments to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.
Apr 14 2019, 3:36 PM · Frameworks
hallas added inline comments to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.
Apr 14 2019, 8:30 AM · Frameworks

Apr 11 2019

hallas added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Ping - anyone ;)

Apr 11 2019, 5:47 PM · Frameworks
hallas updated the diff for D19926: Add Bookmark Handling.

Moved the Bookmarks menu to the Go menu

Apr 11 2019, 5:45 PM · Dolphin
hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

@davidedmundson - could you please take a look at this again? I have implemented all the stuff you suggested ;)

Apr 11 2019, 5:39 PM · Frameworks
hallas added a comment to D19926: Add Bookmark Handling.

a good compromise could be to put the "Bookmark" menu under the "Tools" menu.

Currently I placed the 'Bookmarks' menu under the 'Go' menu, is that a good idea?

Hm, looks to me more fitting than "Tools"

Apr 11 2019, 5:39 PM · Dolphin
hallas added a comment to D19714: Fixes crash when closing with Detailed Memory Information open.

Ping - anyone?

Apr 11 2019, 5:36 PM · Plasma
hallas added a comment to D19311: Add navigation history to forward/back buttons.

About the UI: I'd also be in favor of not showing the arrows. It's not just Falkon that doesn't show them, but also Firefox and Chrome.

After a lot of thought, I agree. I've reverted the Breeze change for the tiny arrows. Sorry for jerking you around here, @hallas! :( Would you mind updating the patch to the version that won't show any arrows at all?

Apr 11 2019, 5:36 PM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

About the UI: I'd also be in favor of not showing the arrows. It's not just Falkon that doesn't show them, but also Firefox and Chrome.

After a lot of thought, I agree. I've reverted the Breeze change for the tiny arrows. Sorry for jerking you around here, @hallas! :( Would you mind updating the patch to the version that won't show any arrows at all?

Apr 11 2019, 5:13 PM · Dolphin

Apr 3 2019

hallas added a comment to D19926: Add Bookmark Handling.
In D19926#442734, @hein wrote:

I'm not sure the "Konqueror had it and people are asking
for it back" argument is strong. Because Konqueror was also unpopular enough to get replaced by Dolphin and to end up largely unmaintained (although it is still released and available). To me that indicates that becoming more like Konqueror may actually be the wrong direction.

The "does adding this clutter the app" thing is also sometimes evaluated wrong IMHO. It's usually looked at in this way: Is the UI now worse than before. But the cost to adding things is also paid forward! Next time someone wants to add a feature to the UI, it has to slot into a UI that already has the last thing that got added. Which is then already fuller, more cluttered situation to start with. In other words, adding stuff is more like a budgetary concern - "should I spend this complexity? I might need it later for something stronger". Because removing things later is almost impossible without a new app. Which is what happened last time.

That said, I don't know the user audience for Dolphin as well as the people working on Dolphin more regularly. If you all think this feature is strong or non-niche enough to be in there despite the above concerns, cool.

Apr 3 2019, 5:25 PM · Dolphin
hallas added a comment to D19926: Add Bookmark Handling.

But I still think it is a pretty strong argument that it is one of the most voted for features for Dolphin, and it is something that was supported previously (because people used konqueror for file management). Also, the feature is _ot very intrusive. You get a new menu entry and a keyboard shortcut, that's it :)

Apr 3 2019, 4:02 AM · Dolphin

Apr 2 2019

hallas added a comment to D19926: Add Bookmark Handling.

Ah, that was the secret sauce, thanks!

This generally works quite well and is a very nice feature. One request: can you disable the Bookmark Tabs As Folder... menu item when there's only one tab open? Also yeah, we should probably consider putting this somewhere in the Control menu too.

I haven't found a way where I can conditionally remove the Bookmark Tabs As Folder... :( I would need to change the API of KBookmarks to do this. Any ideas for this are more than welcome :D

Ehh, this is probably fine for now then. :) Though it would be nice to look into that.

Apr 2 2019, 6:50 PM · Dolphin
hallas requested review of D20209: Add support for KBookmarkOwner to communicate if it has tabs open.
Apr 2 2019, 6:48 PM · Frameworks

Apr 1 2019

hallas added inline comments to D20024: Fixes crash when hiding devices.
Apr 1 2019, 1:27 PM · Dolphin

Mar 31 2019

hallas added a comment to D20024: Fixes crash when hiding devices.

Could you try and move the testHideItem to be the first test? Also make sure to run placesitemmodeltest using valgrind, i.e. valgrind placesitemmodeltest

Mar 31 2019, 9:28 AM · Dolphin

Mar 30 2019

hallas added inline comments to D20052: Make tabs rename-able.
Mar 30 2019, 6:42 AM · Dolphin
hallas added a comment to D20024: Fixes crash when hiding devices.

Hi @elvisangelaccio , I have been looking into writing a unit test for the crash, but it turns out we already have one: PlacesModelItemTest::testHideItem. But, the test only triggers the crash if it is run before the testPlaceItem test case. I have been digging in the code to figure out why the test cases are coupled in this way, but I haven't figured it out, so could you take a look? Here is a diff that triggers the crash:

Mar 30 2019, 6:32 AM · Dolphin

Mar 27 2019

hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

BTW - I tried locally chaning the D19989 patch to use the new KProcessList::processInfoList function and that enables us to achieve the same thing but without the KSysGuard dependency, so that's great :)

Mar 27 2019, 6:50 PM · Frameworks
hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

On FreeBSD, /proc is not necessarily mounted (it might be a Linuxism). So while I do have /proc, it's empty because procfs isn't mounted there. If I do mount it, then there's the expected list of processes and a curproc symlink. But /proc/<pid> doesn't contain a stat file .. there's a status, though. Let me mess around a bit with that... yes, changing to status makes all 6 tests pass. So I'd suggest something like

#ifdef Q_OS_FREEBSD
  QString statusFileName(QStringLiteral("/status"));
#else
  QString statusFileName(QStringLiteral("/stat"));
#endif

and then later on

filename += statusFileName;
Mar 27 2019, 6:48 PM · Frameworks
hallas added inline comments to D20007: Add GetProcessList for retrieving the list of currently active processes.
Mar 27 2019, 6:46 PM · Frameworks
hallas updated the diff for D20007: Add GetProcessList for retrieving the list of currently active processes.

Implemented review comments

Mar 27 2019, 6:46 PM · Frameworks
hallas updated the diff for D19634: Fixes minor memory leaks.

Rebased the commit and fixed a few other minor leaks introduced by the new split view code.

Mar 27 2019, 6:15 PM · Konsole
hallas added a comment to D20024: Fixes crash when hiding devices.

That said, the fix looks correct. An unit test for this crash would be awesome, if you have spare time.

Mar 27 2019, 6:14 PM · Dolphin
hallas updated the diff for D19926: Add Bookmark Handling.

Add the Bookmarks menu to the Control menu

Mar 27 2019, 5:42 AM · Dolphin
hallas added a comment to D19926: Add Bookmark Handling.

Ah, that was the secret sauce, thanks!

This generally works quite well and is a very nice feature. One request: can you disable the Bookmark Tabs As Folder... menu item when there's only one tab open? Also yeah, we should probably consider putting this somewhere in the Control menu too.

Mar 27 2019, 5:40 AM · Dolphin
hallas committed R31:27bcd1be9c2c: Reduce the indicator arrow size for press-and-hold menus in QToolButtons (authored by hallas).
Reduce the indicator arrow size for press-and-hold menus in QToolButtons
Mar 27 2019, 5:23 AM
hallas closed D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons.
Mar 27 2019, 5:19 AM · Plasma

Mar 26 2019

hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Ok, I have implemented all the review feedback you gave, I have also done some unit tests. Some of the unit tests or Unix specific though, I still don't know what to do about Windows since I don't have a development environment. Please give it a good look :D

Mar 26 2019, 5:27 AM · Frameworks
hallas updated the diff for D20007: Add GetProcessList for retrieving the list of currently active processes.

Updated with review comments

Mar 26 2019, 5:25 AM · Frameworks

Mar 24 2019

hallas requested review of D20024: Fixes crash when hiding devices.
Mar 24 2019, 7:00 PM · Dolphin
hallas added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Thanks a lot for the feedback guys, I will spend some time and implement it and push an updated patch.

Mar 24 2019, 2:09 PM · Frameworks

Mar 23 2019

hallas added a comment to D19989: Unmounting busy device doesn't tell who is blocking.

I have pushed the first commit with adding a GetProcessList function in KCoreAddons: D20007

Mar 23 2019, 9:13 PM · Dolphin
hallas added inline comments to D20007: Add GetProcessList for retrieving the list of currently active processes.
Mar 23 2019, 9:12 PM · Frameworks
hallas requested review of D20007: Add GetProcessList for retrieving the list of currently active processes.
Mar 23 2019, 9:07 PM · Frameworks
hallas updated the diff for D19926: Add Bookmark Handling.

Implemented review comments

Mar 23 2019, 12:26 PM · Dolphin
hallas added inline comments to D19926: Add Bookmark Handling.
Mar 23 2019, 12:26 PM · Dolphin