hallas (David Hallas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2018, 3:21 PM (69 w, 4 d)
Availability
Available

Recent Activity

Today

hallas added a comment to D23205: [KProcessList] Optimize KProcessList::processInfo.

@davidedmundson - ping ;)

Fri, Nov 15, 6:03 AM · Frameworks
hallas added a comment to D21235: Add handling of fuseiso filesystem type.

@bruns - ping ;)

Fri, Nov 15, 5:57 AM · Frameworks

Sun, Nov 3

hallas added a comment to D25125: Use KListOpenFilesJob for retrieving apps blocking unmount.

Set QT_PLUGIN_PATH to you local path with plugin after that set the system path for others
QT_PLUGIN_PATH=/local/path:/system/path executable

Sun, Nov 3, 10:46 AM · Plasma
hallas added a comment to D25125: Use KListOpenFilesJob for retrieving apps blocking unmount.

Note that I haven't tested this patch locally because I don't know how to "run" the locally compiled devicenotifier. I can see that I get a plasma_engine_devicenotifications.so library from building the project, but I don't know how to "run" it, do we have a cli tool to load the shared library for testing? Or how do you guys test?

Sun, Nov 3, 8:25 AM · Plasma
hallas requested review of D25125: Use KListOpenFilesJob for retrieving apps blocking unmount.
Sun, Nov 3, 8:22 AM · Plasma
hallas added a comment to D21235: Add handling of fuseiso filesystem type.

@bruns - ping :) I have updated this patch with the changes you requested, I hope you are ok with it now.

Sun, Nov 3, 8:21 AM · Frameworks

Sun, Oct 27

hallas committed R318:c3b914a7faed: Unmounting busy device doesn't tell who is blocking (authored by hallas).
Unmounting busy device doesn't tell who is blocking
Sun, Oct 27, 5:52 AM
hallas closed D19989: Unmounting busy device doesn't tell who is blocking.
Sun, Oct 27, 5:52 AM · Dolphin

Tue, Oct 22

hallas added inline comments to D19989: Unmounting busy device doesn't tell who is blocking.
Tue, Oct 22, 5:37 PM · Dolphin
hallas updated the diff for D19989: Unmounting busy device doesn't tell who is blocking.

Review comments

Tue, Oct 22, 5:37 PM · Dolphin
hallas added inline comments to D19989: Unmounting busy device doesn't tell who is blocking.
Tue, Oct 22, 4:59 AM · Dolphin

Mon, Oct 21

hallas updated the summary of D19989: Unmounting busy device doesn't tell who is blocking.
Mon, Oct 21, 7:03 PM · Dolphin
hallas updated the diff for D19989: Unmounting busy device doesn't tell who is blocking.

Review comments

Mon, Oct 21, 7:02 PM · Dolphin
hallas added inline comments to D21235: Add handling of fuseiso filesystem type.
Mon, Oct 21, 6:47 PM · Frameworks
hallas updated the diff for D21235: Add handling of fuseiso filesystem type.

Reorder functions to make diff smaller

Mon, Oct 21, 6:47 PM · Frameworks

Sun, Oct 20

hallas added a comment to D21235: Add handling of fuseiso filesystem type.

@bruns - I have now refactored the patch so that it uses the getmntent functions for parsing the mtab file, so I think this patch is pretty much ready for a serious review ;)

Sun, Oct 20, 8:12 AM · Frameworks
hallas updated the diff for D21235: Add handling of fuseiso filesystem type.

Rewrite to use the getmntent function for parsing the mtab file

Sun, Oct 20, 8:11 AM · Frameworks

Sat, Oct 19

hallas added inline comments to D21235: Add handling of fuseiso filesystem type.
Sat, Oct 19, 4:50 AM · Frameworks

Fri, Oct 18

hallas added a comment to D21235: Add handling of fuseiso filesystem type.

Currently you have the 'unmount' action if you right click on the device in dolphin, but it cannot unmount, so should we hide it? Or should we fix it so that it can actually unmount?

Fri, Oct 18, 11:44 AM · Frameworks
hallas updated the diff for D21235: Add handling of fuseiso filesystem type.

Implemented parsing of the fuseiso mtab file

Fri, Oct 18, 11:42 AM · Frameworks
hallas added a comment to D23205: [KProcessList] Optimize KProcessList::processInfo.

@davidedmundson ping :)

Fri, Oct 18, 6:40 AM · Frameworks
hallas added inline comments to D19989: Unmounting busy device doesn't tell who is blocking.
Fri, Oct 18, 6:38 AM · Dolphin
hallas updated the diff for D19989: Unmounting busy device doesn't tell who is blocking.

Updated to use KListOpenFilesJob

Fri, Oct 18, 6:36 AM · Dolphin

Oct 6 2019

hallas added a comment to D24434: Fix include path to kjob.h.

Argh, I retagged, but this wasn't pushed yet.
Landing and retagging again...

Oct 6 2019, 10:15 AM · Frameworks
hallas added a comment to D24434: Fix include path to kjob.h.

@dfaure - I just found that if you include KListOpenFilesJob from e.g. Dolphin then it fails because it cannot include jobs/kjob.h :(

Oct 6 2019, 5:26 AM · Frameworks
hallas requested review of D24434: Fix include path to kjob.h.
Oct 6 2019, 5:24 AM · Frameworks

Oct 5 2019

hallas added a comment to D24389: Fix klistopenfilesjob header file not being installed.

git tag doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so this commit will be included.

(I do that on the first Saturday of the month)

Oct 5 2019, 10:25 AM · Frameworks

Oct 3 2019

hallas added a comment to D24389: Fix klistopenfilesjob header file not being installed.

Please land this ASAP so it gets into Frameworks 5.63.

Oct 3 2019, 5:16 PM · Frameworks
hallas committed R244:53c424a63fbf: Fix klistopenfilesjob header file not being installed (authored by hallas).
Fix klistopenfilesjob header file not being installed
Oct 3 2019, 5:15 PM
hallas closed D24389: Fix klistopenfilesjob header file not being installed.
Oct 3 2019, 5:15 PM · Frameworks
hallas added a comment to D19989: Unmounting busy device doesn't tell who is blocking.

We can now restart this work leveraging KCoreAddon KListOpenFilesJo D21760 .

Oct 3 2019, 3:04 PM · Dolphin
hallas requested review of D24389: Fix klistopenfilesjob header file not being installed.
Oct 3 2019, 3:03 PM · Frameworks
hallas added a comment to D19989: Unmounting busy device doesn't tell who is blocking.

We can now restart this work leveraging KCoreAddon KListOpenFilesJo D21760 .

Oct 3 2019, 3:42 AM · Dolphin
hallas committed R318:c71c1c94be2e: Fix missing setDefaultShortcuts call (authored by hallas).
Fix missing setDefaultShortcuts call
Oct 3 2019, 3:41 AM
hallas closed D24342: Fix missing setDefaultShortcuts call.
Oct 3 2019, 3:40 AM · Dolphin

Oct 1 2019

hallas added a comment to D21235: Add handling of fuseiso filesystem type.

I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?

What do you gain by using KMountPoints? Solid already has code for parsing fstab style files.

Hi @bruns , no you are right that I should be able to do with the code that is in Solid already. It just needs to be updated to be able parse an arbitrary mtab file. But anyhow, the fstab/mtab code in Solid seems kind of duplicated with the code in KIO, so we might consolidate at some point.

But let me look into the mtab code in Solid and see if I can make it work there :)

Oct 1 2019, 6:02 PM · Frameworks
hallas requested review of D24342: Fix missing setDefaultShortcuts call.
Oct 1 2019, 3:27 PM · Dolphin

Sep 30 2019

hallas added a comment to D19311: Add navigation history to forward/back buttons.

@hallas I noticed the following warning on dolphin start:

KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action  "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.

Could you have a look? Maybe it's because we call actionCollection()->setDefaultShortcuts(m_backAction, backShortcuts); and we don't do the same for m_forwardAction ?

Sep 30 2019, 5:39 PM · Dolphin

Sep 29 2019

hallas committed R318:eec49bc38f4e: Add navigation history to forward/back buttons (authored by hallas).
Add navigation history to forward/back buttons
Sep 29 2019, 12:42 PM
hallas closed D19311: Add navigation history to forward/back buttons.
Sep 29 2019, 12:16 PM · Dolphin

Sep 27 2019

hallas updated the diff for D19311: Add navigation history to forward/back buttons.

Review comments

Sep 27 2019, 7:02 PM · Dolphin

Sep 23 2019

hallas added a comment to D21235: Add handling of fuseiso filesystem type.

I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?

What do you gain by using KMountPoints? Solid already has code for parsing fstab style files.

Sep 23 2019, 6:09 PM · Frameworks

Sep 22 2019

hallas added a comment to D21235: Add handling of fuseiso filesystem type.

I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?

Sep 22 2019, 6:08 AM · Frameworks
hallas added a comment to D19311: Add navigation history to forward/back buttons.

Just noticed that Alt+left/right shortcuts for back and forward are now broken.

Sep 22 2019, 5:59 AM · Dolphin
hallas updated the diff for D19311: Add navigation history to forward/back buttons.

Fix Back/Forward shortcuts

Sep 22 2019, 5:58 AM · Dolphin

Sep 19 2019

hallas added a comment to D23205: [KProcessList] Optimize KProcessList::processInfo.

@davidedmundson - ping :)

Sep 19 2019, 11:26 AM · Frameworks
hallas updated the diff for D19311: Add navigation history to forward/back buttons.

Restrict the number of navigation entries to 12

Sep 19 2019, 11:24 AM · Dolphin

Sep 17 2019

hallas added inline comments to D19311: Add navigation history to forward/back buttons.
Sep 17 2019, 11:13 AM · Dolphin
hallas committed R244:3d6847425df1: Fix KListOpenFilesJob unit test on Unix if lsof is not installed (authored by hallas).
Fix KListOpenFilesJob unit test on Unix if lsof is not installed
Sep 17 2019, 4:21 AM
hallas closed D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed.
Sep 17 2019, 4:19 AM · Frameworks

Sep 14 2019

hallas added inline comments to D19311: Add navigation history to forward/back buttons.
Sep 14 2019, 3:49 PM · Dolphin

Sep 12 2019

hallas added inline comments to D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed.
Sep 12 2019, 5:32 PM · Frameworks
hallas updated the diff for D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed.

Use QSKIP to skip tests

Sep 12 2019, 5:32 PM · Frameworks

Sep 11 2019

hallas added inline comments to D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed.
Sep 11 2019, 5:57 PM · Frameworks
hallas updated the diff for D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed.

Use QStandardPaths::findExecutable to locate lsof

Sep 11 2019, 5:57 PM · Frameworks
hallas requested review of D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed.
Sep 11 2019, 5:35 PM · Frameworks
hallas committed R244:e119ce7b5afe: Add KListOpenFilesJob (authored by hallas).
Add KListOpenFilesJob
Sep 11 2019, 4:10 PM
hallas closed D21760: Add KListOpenFilesJob.
Sep 11 2019, 4:10 PM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Updated @since

Sep 11 2019, 4:03 PM · Frameworks

Sep 9 2019

hallas added a comment to D19311: Add navigation history to forward/back buttons.

Thanks @hallas. I'm good with this now. For the future, I would like one of the following UI improvements:

  • Show no visible arrow at all (i.e. what web browsers do)
  • Make the downward-pointing arrow be really tiny and sit in the bottom-right corner of a square toolbutton, rather than making the toolbutton wider to accommodate it
Sep 9 2019, 5:19 PM · Dolphin

Sep 7 2019

hallas added a comment to D19311: Add navigation history to forward/back buttons.

Thanks for the analysis :) I still think we should get the change in with the current KToolBarPopupAction functionality (like Nate suggest), and then work on refining the user experience. But feel free to pinch in on the user experience part.

This is such a big discussion already. Which suggestion of Nate do you refer to specifically? I thought the current approach that shows indicators was denied.

Sep 7 2019, 11:00 AM · Dolphin
hallas updated the summary of D19311: Add navigation history to forward/back buttons.
Sep 7 2019, 8:12 AM · Dolphin
hallas updated the diff for D19311: Add navigation history to forward/back buttons.

Rebased

Sep 7 2019, 8:12 AM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

We have previously discussed various ways to simplify this change, but no other suitable solutions has been found, but I am still open to simpler solutions :)

This is what I think can produce the wanted behaviour:
KToolBarPopupAction uses QToolButton internally so Indicators are drawn (because of style rules if I understand correctly). If there is no way to use QToolButton and hide indicators without forcing style changes (which was blocked) then it seems to me like the only way forward is not using a QToolButton.
AFAICT there are two ways forward:

  • Further modify KToolBarPopupAction to not use QToolButton internally in the case of menuIndicator being turned off and instead internally implement the same behaviour using some other button class. The QAbstractButton with it's pressed and clicked signals might be enough to handle it but there are possibly more fitting specialised button classes. This way no changes to the Breeze style or any other style for that matter should be necessary.
  • It might be a bit difficult to imitate the behaviour of KToolBarPopupAction without using a QToolButton so alternatively it might be easier to not modify KToolBarPopupAction at all and create or use a different class. In this case you don't have to mimic all options of KToolBarPopupAction perfectly since it is expected that the new class behaves differently. You could then copy from/use Falkon's NavigationBarToolButton (like @david.fontanals suggested in D19311#432597) . I'm pretty sure the license of that class is incompatible with frameworks though so that would have to be handled if it's supposed to land in KWidgetAddons.

    Take my analysis with a grain of salt though since it is mainly based on me reading documentation without having ever actually tried similar stuff.
Sep 7 2019, 8:08 AM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

Hmm, can you rebase it on master?

Sep 7 2019, 8:07 AM · Dolphin
hallas added a comment to D21760: Add KListOpenFilesJob.

This is good to go in :-)

If you push it today it'll indeed be in 5.62, to be tagged tomorrow, otherwise we'll need to adjust the @since tag ;-)

Sep 7 2019, 8:05 AM · Frameworks

Sep 6 2019

hallas updated the summary of D21760: Add KListOpenFilesJob.
Sep 6 2019, 10:24 AM · Frameworks
hallas added inline comments to D21760: Add KListOpenFilesJob.
Sep 6 2019, 10:24 AM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Review comments

Sep 6 2019, 10:23 AM · Frameworks
hallas added a comment to D19311: Add navigation history to forward/back buttons.

At this point I'm inclined to say that we should go forward with the patch regardless of widget changes, because otherwise it's gonna be stuck in patch review limbo forever.

Can you make the menu show up on press-and-hold without showing any arrow on the buttons without widget changes? That's probably the simplest path forward until we sort out the appearance issue. Better to temporarily make it semi-hidden than never getting it landed. :)

Sep 6 2019, 8:50 AM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

Dolphin appears to not compile without F6773036 in KWidgetAddons though. All I can find for F6773036 is the diff. Is there a Dxxxxx thing in phab for that?

Sep 6 2019, 4:48 AM · Dolphin
hallas added a comment to D19311: Add navigation history to forward/back buttons.

At this point I'm inclined to say that we should go forward with the patch regardless of widget changes, because otherwise it's gonna be stuck in patch review limbo forever.

Can you make the menu show up on press-and-hold without showing any arrow on the buttons without widget changes? That's probably the simplest path forward until we sort out the appearance issue. Better to temporarily make it semi-hidden than never getting it landed. :)

Sep 6 2019, 4:48 AM · Dolphin
hallas updated the diff for D21760: Add KListOpenFilesJob.

Review comments, renamed the files to match the class name

Sep 6 2019, 4:46 AM · Frameworks
hallas added a comment to D21760: Add KListOpenFilesJob.

Yes, the filenames should match the classname, obviously :)

I did a deeper review of the KJob usage and I have two more comments, sorry for not taking the time to do this earlier...

Sep 6 2019, 4:46 AM · Frameworks

Sep 5 2019

hallas added a comment to D19311: Add navigation history to forward/back buttons.

Looks good. I do have a weird occurrence with three slashes appearing in the path for

seems when I leave and reenter, then leave the home dir.

Sep 5 2019, 5:20 AM · Dolphin

Sep 3 2019

hallas added inline comments to D21760: Add KListOpenFilesJob.
Sep 3 2019, 3:14 PM · Frameworks
hallas added a comment to D21760: Add KListOpenFilesJob.

Given that the namespace doesn't contain anything else anymore, I would just get rid of it, and provide a single class, KListOpenFilesJob.

Sep 3 2019, 3:12 PM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Removed KListOpenFiles namespace and renamed ListOpenFilesJob to KListOpenFilesJob

Sep 3 2019, 3:12 PM · Frameworks
hallas updated the summary of D21760: Add KListOpenFilesJob.
Sep 3 2019, 3:11 PM · Frameworks
hallas updated the summary of D21760: Add KListOpenFilesJob.
Sep 3 2019, 5:29 AM · Frameworks
hallas added inline comments to D21760: Add KListOpenFilesJob.
Sep 3 2019, 5:27 AM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Review comments

Sep 3 2019, 5:27 AM · Frameworks

Sep 2 2019

hallas added a comment to D19311: Add navigation history to forward/back buttons.

I'd like to test this... ...will Oxygen need similar changes?

Sep 2 2019, 1:26 PM · Dolphin
hallas added a comment to D21760: Add KListOpenFilesJob.

I have added a minimal Windows implementation which always emits an error, along with a unit test. Please review it thoroughly and then I think it is ready to land :)

Sep 2 2019, 1:22 PM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Review comments. Added minimal Windows implementation which basically always reports failure with the error code Unsupported.

Sep 2 2019, 1:21 PM · Frameworks

Aug 30 2019

hallas added a comment to D21760: Add KListOpenFilesJob.

One thing, when this is ready to land I will address the Windows support so that we do not get broken builds :)

Aug 30 2019, 5:20 AM · Frameworks
hallas added a comment to D21760: Add KListOpenFilesJob.

@dfaure - Overall, what do you think about the approach of subclassing KJob? Did it turn out like you had thought? And is this the solution we should go with, or was one of the other solutions better?

Aug 30 2019, 5:19 AM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Review comments

Aug 30 2019, 5:19 AM · Frameworks

Aug 29 2019

hallas updated the test plan for D23205: [KProcessList] Optimize KProcessList::processInfo.
Aug 29 2019, 5:55 AM · Frameworks
hallas updated the diff for D23205: [KProcessList] Optimize KProcessList::processInfo.

Add bug reference

Aug 29 2019, 5:53 AM · Frameworks
hallas updated the diff for D23205: [KProcessList] Optimize KProcessList::processInfo.

Fixed review comments, rebased.

Aug 29 2019, 5:52 AM · Frameworks
hallas added inline comments to D21760: Add KListOpenFilesJob.
Aug 29 2019, 5:27 AM · Frameworks
hallas added a comment to D21760: Add KListOpenFilesJob.

@meven , so I finally managed to rewrite this patch to use KJob instead. Please take a look at it again and see if this is better approach :)

Aug 29 2019, 5:25 AM · Frameworks
hallas updated the diff for D21760: Add KListOpenFilesJob.

Rewrote the code to use KJob

Aug 29 2019, 5:24 AM · Frameworks

Aug 17 2019

hallas added inline comments to D21760: Add KListOpenFilesJob.
Aug 17 2019, 12:39 PM · Frameworks
hallas added a comment to D23214: Add a BlockinApp util class to find process blockng access.

Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.

Great suggestion I missed this prior diff.

Abandoned in favor of D21760 and adding a KJob for this use case

Aug 17 2019, 12:13 PM · Frameworks
hallas added a comment to D23214: Add a BlockinApp util class to find process blockng access.

Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.

Aug 17 2019, 12:02 PM · Frameworks

Aug 16 2019

hallas requested review of D23205: [KProcessList] Optimize KProcessList::processInfo.
Aug 16 2019, 4:28 PM · Frameworks

Aug 13 2019

hallas added inline comments to D21760: Add KListOpenFilesJob.
Aug 13 2019, 3:21 PM · Frameworks
hallas updated subscribers of D21760: Add KListOpenFilesJob.

You wrote "ported from Device Notifier". I haven't check in detail yet, but do other copyright holders need to be mentioned?

Aug 13 2019, 3:13 PM · Frameworks