- User Since
- Jul 16 2018, 3:21 PM (52 w, 3 d)
Thu, Jun 27
Wed, Jun 26
Hi @ngraham - I have looked into this patch set and it is a little tedious to test, you have to do the following:
Fri, Jun 21
Thu, Jun 20
Jun 16 2019
Jun 12 2019
First of, this is WIP, I just wanted to share this early to get some feedback. The reasoning for this is to generalize functionality for running lsof, this is currently in use by the Device Notifier applet and I would like to use it in Dolphin to fix bug #189302. Also see the discussion in D19989 for details.
Jun 1 2019
May 28 2019
May 27 2019
May 20 2019
@davidedmundson - Hi David! I am (finally) starting to look at implementing the lsof functionality in Solid, but I am unsure of where exactly to place it in Solid? Also, currently Solid does not depend on any KF5 libraries, this would be the first, is that ok?
May 15 2019
May 13 2019
This has been fixed in D21050
Hi @ngraham - any update on this one? Should we move forward with this approach or should we do something else?
May 6 2019
Thanks for the review! Landing it now.
@elvisangelaccio - is it ok to merge this change now or do we need to wait for anything else?
@davidedmundson - ping ?
May 3 2019
I have tried to modify the fstab backend to also show fuse mounts and a very simple prototype is this:
May 2 2019
May 1 2019
This commit is still work-in-progress, but I would really like to get some feedback to the approach. Does it make sense to add a new backend? Or should this functionality be merged with one of the other backends (I was considering the fstab backend)?
Apr 29 2019
Share bookmarks.xml with kfile
Apr 28 2019
Apr 27 2019
Make the global functions static.
Apr 25 2019
Apr 24 2019
Apr 23 2019
Apr 22 2019
@davidedmundson - Ping ;)
Change KStandardItem to derive from QObject, and use deleteLater when removing an item.
Print qWarning if GenericDataLocation is empty
Reworked the patch to avoid any ABI breakage. Now the new functionality is in KBookmarkMenu instead.
Apr 14 2019
Hi @dfaure - I looked into this a bit more and have run into a problem, I hope you can help solve. The problem is that when I add a getter and a setter for the number of open tabs, I need to store the value somewhere in KBookmarkOwner but I guess I cannot add a member variable, since that breaks binary compatibility. But luckily this class has a d-Pointer KBookmarkOwnerPrivate in the member variable d, but there is no definition of KBookmarkOwnerPrivate and therefore it is not constructed anywhere, this is not a problem since I could just make one, the problem is that the virtual destructor for KBookmarkOwner is implemented directly in the header file, and I don't think I can move (and change) the implementation to the .cpp file without breaking binary compatibility? Also I should probably also implement a copy constructor and assignment operator in KBookmarkOwner if we actually use the d-Pointer, right? And this would also break binary compatibility.
@richardl - thanks for the feedback! I tend to agree with @david.fontanals in that it makes most sense to only show the back history in the back button and the forward history in the forward button. This also seems to be the behavior of Chrome (though I don't know how much it matters :) ).
Apr 11 2019
Ping - anyone ;)
Moved the Bookmarks menu to the Go menu
@davidedmundson - could you please take a look at this again? I have implemented all the stuff you suggested ;)
Ping - anyone?
Apr 3 2019
But I still think it is a pretty strong argument that it is one of the most voted for features for Dolphin, and it is something that was supported previously (because people used konqueror for file management). Also, the feature is _ot very intrusive. You get a new menu entry and a keyboard shortcut, that's it :)
Apr 2 2019
Apr 1 2019
Mar 31 2019
Could you try and move the testHideItem to be the first test? Also make sure to run placesitemmodeltest using valgrind, i.e. valgrind placesitemmodeltest
Mar 30 2019
Hi @elvisangelaccio , I have been looking into writing a unit test for the crash, but it turns out we already have one: PlacesModelItemTest::testHideItem. But, the test only triggers the crash if it is run before the testPlaceItem test case. I have been digging in the code to figure out why the test cases are coupled in this way, but I haven't figured it out, so could you take a look? Here is a diff that triggers the crash:
Mar 27 2019
BTW - I tried locally chaning the D19989 patch to use the new KProcessList::processInfoList function and that enables us to achieve the same thing but without the KSysGuard dependency, so that's great :)
Implemented review comments
Rebased the commit and fixed a few other minor leaks introduced by the new split view code.
Add the Bookmarks menu to the Control menu