- User Since
- Jul 16 2018, 3:21 PM (69 w, 4 d)
@davidedmundson - ping ;)
@bruns - ping ;)
Sun, Nov 3
Note that I haven't tested this patch locally because I don't know how to "run" the locally compiled devicenotifier. I can see that I get a plasma_engine_devicenotifications.so library from building the project, but I don't know how to "run" it, do we have a cli tool to load the shared library for testing? Or how do you guys test?
@bruns - ping :) I have updated this patch with the changes you requested, I hope you are ok with it now.
Sun, Oct 27
Tue, Oct 22
Mon, Oct 21
Reorder functions to make diff smaller
Sun, Oct 20
@bruns - I have now refactored the patch so that it uses the getmntent functions for parsing the mtab file, so I think this patch is pretty much ready for a serious review ;)
Rewrite to use the getmntent function for parsing the mtab file
Sat, Oct 19
Fri, Oct 18
Currently you have the 'unmount' action if you right click on the device in dolphin, but it cannot unmount, so should we hide it? Or should we fix it so that it can actually unmount?
Implemented parsing of the fuseiso mtab file
@davidedmundson ping :)
Updated to use KListOpenFilesJob
Oct 6 2019
@dfaure - I just found that if you include KListOpenFilesJob from e.g. Dolphin then it fails because it cannot include jobs/kjob.h :(
Oct 5 2019
Oct 3 2019
Oct 1 2019
Sep 30 2019
Sep 29 2019
Sep 27 2019
Sep 23 2019
Sep 22 2019
I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the ~/.mtab.fuseiso file I would like to use the KMountPoint class, but this class currently resides in KIO which Solid doesn't depend on. But, KIO actually depends on Solid so would it be an option to move this class from KIO to Solid?
Fix Back/Forward shortcuts
Sep 19 2019
@davidedmundson - ping :)
Restrict the number of navigation entries to 12
Sep 17 2019
Sep 14 2019
Sep 12 2019
Use QSKIP to skip tests
Sep 11 2019
Use QStandardPaths::findExecutable to locate lsof
Sep 9 2019
Sep 7 2019
Sep 6 2019
Review comments, renamed the files to match the class name
Sep 5 2019
Sep 3 2019
Removed KListOpenFiles namespace and renamed ListOpenFilesJob to KListOpenFilesJob
Sep 2 2019
I have added a minimal Windows implementation which always emits an error, along with a unit test. Please review it thoroughly and then I think it is ready to land :)
Review comments. Added minimal Windows implementation which basically always reports failure with the error code Unsupported.
Aug 30 2019
One thing, when this is ready to land I will address the Windows support so that we do not get broken builds :)
@dfaure - Overall, what do you think about the approach of subclassing KJob? Did it turn out like you had thought? And is this the solution we should go with, or was one of the other solutions better?
Aug 29 2019
Add bug reference
Fixed review comments, rebased.
@meven , so I finally managed to rewrite this patch to use KJob instead. Please take a look at it again and see if this is better approach :)
Rewrote the code to use KJob
Aug 17 2019
Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.