eszlari (Peter Eszlari)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 14 2018, 7:17 PM (116 w, 8 h)
Availability
Available

Recent Activity

Sat, Mar 28

eszlari added a comment to D28360: cmake: make xsettingsd check an option.

Again, why not just make XSettingsd required? It's simpler.

Sat, Mar 28, 7:31 AM · Plasma

Fri, Mar 27

eszlari added a comment to D28360: cmake: make xsettingsd check an option.

But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, which already is.

Fri, Mar 27, 8:05 PM · Plasma
eszlari added a comment to D28360: cmake: make xsettingsd check an option.

I would like to have this in 5.18

We cannot add mandatory dependencies to the stable branches/releases. Currently it's an optional dependency. If you want to make it mandatory, only 5.19 and later are possible options.

Fri, Mar 27, 7:03 PM · Plasma
eszlari added a comment to D28360: cmake: make xsettingsd check an option.

Why just not make xsettingsd required?

Fri, Mar 27, 6:56 PM · Plasma
eszlari added a reviewer for D28360: cmake: make xsettingsd check an option: gikari.
Fri, Mar 27, 6:43 PM · Plasma
eszlari requested review of D28360: cmake: make xsettingsd check an option.
Fri, Mar 27, 6:41 PM · Plasma

Sat, Mar 14

eszlari committed R37:da8617f87862: Linux: fix appdata (authored by eszlari).
Linux: fix appdata
Sat, Mar 14, 9:18 AM

Fri, Mar 13

eszlari committed R37:04efd614dfaa: Linux: fix appdata (authored by eszlari).
Linux: fix appdata
Fri, Mar 13, 8:22 AM

Mon, Mar 9

eszlari committed R158:7c8cff018e79: flatpak: frei0r-plugins 1.7.0 (authored by eszlari).
flatpak: frei0r-plugins 1.7.0
Mon, Mar 9, 6:38 AM

Sun, Mar 8

eszlari added a comment to D25324: [GTK Config] Add XSettingsd as a runtime dependency.

This bug is not fixed by this patch. xsettingsd needs to be started in plasma-workspace/startkde/startplasma.cpp (or by systemd in the future).

xsettingsd is started by the daemon itself, if it's not instantiated already. The daemon itself launches at startup, because it is a kded module.

Sun, Mar 8, 10:28 PM · Plasma
eszlari added a comment to D25324: [GTK Config] Add XSettingsd as a runtime dependency.

This bug is not fixed by this patch. xsettingsd needs to be started in plasma-workspace/startkde/startplasma.cpp (or by systemd in the future).

Sun, Mar 8, 4:37 PM · Plasma

Mar 5 2020

eszlari committed R256:4769d90c5f2a: kdenlive: use manifest from repo (authored by eszlari).
kdenlive: use manifest from repo
Mar 5 2020, 12:45 AM

Feb 27 2020

eszlari renamed T12753: Add xsettingsd as a dependency to kde-gtk-config from Add xsettingsd as a dependcy to kde-gtk-config to Add xsettingsd as a dependency to kde-gtk-config.
Feb 27 2020, 7:08 PM · Kubuntu
eszlari added a comment to T12753: Add xsettingsd as a dependency to kde-gtk-config.

See also: https://phabricator.kde.org/D25324

Feb 27 2020, 7:07 PM · Kubuntu
eszlari created T12753: Add xsettingsd as a dependency to kde-gtk-config.
Feb 27 2020, 7:06 PM · Kubuntu
eszlari added a comment to D25324: [GTK Config] Add XSettingsd as a runtime dependency.

But seems, this only applies to dependencies checked by find_package().

I'm confused.

Does it mean, I should create custom FindXsettingsd.cmake module for xsettingsd, then write something like this:

find_package(Xsettingsd)
set_package_properties(Xsettingsd PROPERTIES
    TYPE RUNTIME
    DESCRIPTION "Provides settings to X11 applications via the XSETTINGS specification"
    URL "https://github.com/derat/xsettingsd"
)

?

Feb 27 2020, 6:49 PM · Plasma

Feb 19 2020

eszlari committed R158:1b364e8b014b: fix org.kde.kdenlive.appdata.xml (authored by eszlari).
fix org.kde.kdenlive.appdata.xml
Feb 19 2020, 2:28 PM

Feb 14 2020

eszlari committed R158:a27bf515f308: fix org.kde.kdenlive.appdata.xml (authored by eszlari).
fix org.kde.kdenlive.appdata.xml
Feb 14 2020, 10:22 AM

Nov 29 2019

eszlari committed R158:930fb8d6e5d7: add flatpak nightly manifest (authored by eszlari).
add flatpak nightly manifest
Nov 29 2019, 11:32 AM

Nov 16 2019

eszlari added a comment to D25324: [GTK Config] Add XSettingsd as a runtime dependency.

I guess he refers to:

Nov 16 2019, 5:13 PM · Plasma

Nov 15 2019

eszlari added a comment to D24743: Update GTK settings according to Plasma settings.

I'm not very proficient in CMake, so how can I do that?

Nov 15 2019, 6:24 AM · VDG, Plasma

Nov 14 2019

eszlari added a comment to D24743: Update GTK settings according to Plasma settings.

Maybe a warning about the runtime dependency on xsettingsd should be added to cmake, so distro packagers know about it.

Nov 14 2019, 9:48 PM · VDG, Plasma

Aug 20 2019

eszlari committed R223:9fcd33599d47: appdata: add content_rating (authored by eszlari).
appdata: add content_rating
Aug 20 2019, 7:39 PM

Aug 11 2019

eszlari committed R158:7b2af9f0d99d: org.kde.kdenlive.appdata.xml: add content_rating (authored by eszlari).
org.kde.kdenlive.appdata.xml: add content_rating
Aug 11 2019, 12:11 PM

Jun 14 2019

eszlari committed R37:9f96e41ec05a: Linux/appdata: add content_rating (authored by eszlari).
Linux/appdata: add content_rating
Jun 14 2019, 8:21 AM

Apr 20 2019

eszlari added a comment to D20242: Add flatpak mime types.

I think, for my small contributions, this would be overkill, but thanks for your trust! :-)

Apr 20 2019, 7:26 PM · Plasma

Apr 19 2019

eszlari added a comment to D20242: Add flatpak mime types.

@apol Have forgotten to commit?

Apr 19 2019, 6:22 AM · Plasma

Apr 4 2019

eszlari requested review of D20242: Add flatpak mime types.
Apr 4 2019, 6:11 AM · Plasma

Mar 22 2019

eszlari added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

I guess you guys would consider this to be too risky for 5.15? (Although a lot of Nvidia owners - me included - are dying to get this fix).

Mar 22 2019, 8:17 AM · KWin

Oct 18 2018

eszlari added a comment to D14697: X11: set GDK_SCALE (try 2).

peter.eszlari@gmail.com

Oct 18 2018, 7:48 PM · Plasma

Oct 9 2018

eszlari added inline comments to D14697: X11: set GDK_SCALE (try 2).
Oct 9 2018, 6:39 PM · Plasma

Aug 8 2018

eszlari added reviewers for D14697: X11: set GDK_SCALE (try 2): davidedmundson, ngraham.
Aug 8 2018, 6:45 PM · Plasma
eszlari requested review of D14697: X11: set GDK_SCALE (try 2).
Aug 8 2018, 6:42 PM · Plasma

May 30 2018

eszlari added a comment to D13102: Don't include a 64 when building 64bit architectures on flatpak.
In D13102#268116, @apol wrote:

I don't really see how to put it without reading convoluted. Also as is, the documentation isn't wrong, we are just changing the logic to use one or another.

May 30 2018, 12:02 PM · Build System, Frameworks

May 29 2018

eszlari updated the diff for D13142: Update appdata.xml.
May 29 2018, 10:18 AM · Krita

May 28 2018

eszlari added a comment to D13143: rename mime xml file.

Do you have a commit access ?

May 28 2018, 6:59 AM · Kdenlive

May 27 2018

eszlari requested review of D13143: rename mime xml file.
May 27 2018, 5:56 AM · Kdenlive
eszlari requested review of D13142: Update appdata.xml.
May 27 2018, 5:41 AM · Krita

May 11 2018

eszlari retitled D12826: fix 4.0 appdata from fix appdata to fix 4.0 appdata.
May 11 2018, 1:53 PM · Krita
eszlari added a reviewer for D12826: fix 4.0 appdata: rempt.
May 11 2018, 1:52 PM · Krita
eszlari requested review of D12826: fix 4.0 appdata.
May 11 2018, 1:51 PM · Krita

Jan 16 2018

eszlari updated the diff for D9882: Add flatpak build manifest.

change CMAKE_BUILD_TYPE to RelWithDebInfo and remove CMAKE_INSTALL_LIBDIR=lib

Jan 16 2018, 7:29 PM · Krita, Flatpak
eszlari added a comment to D9882: Add flatpak build manifest.

When the KDE nightly build is switched to this manifest, it would be good, if a hint was added to krita's download page, with a link to the repo file:

Jan 16 2018, 5:20 PM · Krita, Flatpak
eszlari updated the diff for D9882: Add flatpak build manifest.

I changed the manifest to be usable for nightly builds and removed openjpeg.

Jan 16 2018, 5:11 PM · Krita, Flatpak

Jan 15 2018

eszlari added inline comments to D9882: Add flatpak build manifest.
Jan 15 2018, 3:21 PM · Krita, Flatpak
eszlari added a comment to D9882: Add flatpak build manifest.
In D9882#191275, @rempt wrote:

I have no opinion in the appstream file question, but I'm fine with having these definitions in our repo, on the same basis as the snap definitions: I cannot maintain them.

Jan 15 2018, 3:19 PM · Krita, Flatpak
eszlari added a comment to D9882: Add flatpak build manifest.

Would you consider adding <release> information to your AppStream metadata file here, so you don't need to patch it in on Flathub?

It's already there on master and will be dropped when 4.0 is released.

Jan 15 2018, 5:11 AM · Krita, Flatpak
eszlari added inline comments to D9882: Add flatpak build manifest.
Jan 15 2018, 3:20 AM · Krita, Flatpak
eszlari added a project to D9882: Add flatpak build manifest: Krita.
Jan 15 2018, 1:52 AM · Krita, Flatpak

Jan 14 2018

eszlari added a comment to D9882: Add flatpak build manifest.

And in case you are not familiar with the current state of flatpak: when the user has a recent version of Plasma Discover or GNOME Software installed, it's of course enough to click the the bundle to install it.

Jan 14 2018, 10:56 PM · Krita, Flatpak
eszlari updated the diff for D9882: Add flatpak build manifest.

fixed name of manifest in instructions

Jan 14 2018, 10:50 PM · Krita, Flatpak
eszlari added a comment to D9882: Add flatpak build manifest.

By the way: The resulting bundle includes python scripting support and should contain support for audio in animations (I had no idea how to test that).

Jan 14 2018, 10:45 PM · Krita, Flatpak