steffenh (Steffen Hartleib)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 1 2018, 10:28 AM (59 w, 1 d)
Availability
Available

Recent Activity

Tue, Jul 23

steffenh added a comment to D21829: Improved Touch support for Kickoff.

Before we discuss alternatives: Are you willing to have me try and teach you? I'm actually going to be very busy with a move in the next few weeks, so this could end up taking quite significant time between the two of us, but if you have the time and patience I don't mind helping you through creating the patch I had in mind.

Tue, Jul 23, 4:18 PM · Plasma

Jul 21 2019

steffenh added a comment to D21829: Improved Touch support for Kickoff.

Oh, sorry, I have the feeling I have misunderstood the post from @hein, I have the impression he wants to make a patch to DragHelper, but if I read this again, so sorry.

Jul 21 2019, 6:28 AM · Plasma

Jun 30 2019

steffenh updated the diff for D21759: Hold zoom center below center/mouse position.
  • lock mouse cursor for middle mouse button zooming
  • adjust for disappear and appear of scrollbars
  • try to recenter if zoom center moving below the mouse cursor
Jun 30 2019, 4:00 PM · Okular

Jun 23 2019

steffenh updated the diff for D21759: Hold zoom center below center/mouse position.

fix typos and make centerBegin and centerEnd const

Jun 23 2019, 6:57 AM · Okular

Jun 22 2019

steffenh added a comment to D21759: Hold zoom center below center/mouse position.

Hi @aacid,
thanks for testing,

Jun 22 2019, 4:41 PM · Okular

Jun 21 2019

steffenh updated the diff for D21829: Improved Touch support for Kickoff.

change variable name from tapandhold to tapAndHold

Jun 21 2019, 11:30 AM · Plasma

Jun 19 2019

steffenh added a comment to T10783: Right-click on touch.

The Question is how you do a two finger tap?
A two finger taps in the same time, this will get problems with small target.
Or you make the two finger tap over a time period (tap first finger, tap a second finger) the first finger is the target and the second finger the signal for right click.

Jun 19 2019, 11:45 AM · Plasma, VDG
steffenh added inline comments to D21829: Improved Touch support for Kickoff.
Jun 19 2019, 10:55 AM · Plasma

Jun 18 2019

steffenh updated the diff for D21829: Improved Touch support for Kickoff.
  • Drag icon now follows the touch point
  • to make the drag icon better visible, set the drag icon size for touch drag from medium to huge and move the drag icon a bit to the top and left
Jun 18 2019, 11:52 AM · Plasma

Jun 15 2019

steffenh requested review of D21829: Improved Touch support for Kickoff.
Jun 15 2019, 10:23 AM · Plasma

Jun 13 2019

steffenh updated the diff for D21759: Hold zoom center below center/mouse position.

Use initial cursor position for middle-button-drag zooming

Jun 13 2019, 2:22 PM · Okular

Jun 12 2019

steffenh requested review of D21759: Hold zoom center below center/mouse position.
Jun 12 2019, 9:00 AM · Okular

May 18 2019

steffenh updated the diff for D21028: add multiple gestures and a handler class to KWidgetsAddons.

change name to KTouchGesture
add a private class for every exported class
remove unused code

May 18 2019, 10:04 AM · Frameworks

May 8 2019

steffenh added a comment to D21028: add multiple gestures and a handler class to KWidgetsAddons.

thanks for the link, I see KGesture is already used. I hope KGestureHandler is not too similar

May 8 2019, 4:22 PM · Frameworks
steffenh added a comment to D21028: add multiple gestures and a handler class to KWidgetsAddons.

Ok, I need a new name, perhaps KGesture ?

May 8 2019, 9:50 AM · Frameworks
steffenh added a comment to D21028: add multiple gestures and a handler class to KWidgetsAddons.

Thanks for your time to look at my code. I know, I'am not good at this, so if you can point me at my errors I will try to correct this.

May 8 2019, 9:49 AM · Frameworks

May 5 2019

steffenh requested review of D21028: add multiple gestures and a handler class to KWidgetsAddons.
May 5 2019, 6:50 AM · Frameworks

Mar 16 2019

steffenh added a comment to D13901: Touch support for Gwenview.

I started to transfer the gestures to the framework, but I cannot promise anything.

Mar 16 2019, 5:41 PM · Gwenview

Mar 10 2019

steffenh updated the diff for D13901: Touch support for Gwenview.

Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.

Mar 10 2019, 8:46 AM · Gwenview

Mar 9 2019

steffenh added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?

https://cgit.kde.org/kwidgetsaddons.git

Mar 9 2019, 7:46 AM · Gwenview

Mar 3 2019

steffenh updated the diff for D13901: Touch support for Gwenview.
  • move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
  • fix some typos
  • fix copyright
Mar 3 2019, 5:22 PM · Gwenview

Feb 27 2019

steffenh added inline comments to D13901: Touch support for Gwenview.
Feb 27 2019, 1:17 PM · Gwenview

Feb 24 2019

steffenh added a comment to D13901: Touch support for Gwenview.

From a high level perspective, I share @rkflx's concern with the amount of duplicate code. ThumbnailView::viewportEvent() is almost entirely duplicate code from DocumentView::event(), for example. Can we refactor this into re-usable functions in touch or touch_helper or something?

I will have a look at this, perhaps I can move same code around.

Feb 24 2019, 7:12 AM · Gwenview

Feb 21 2019

steffenh updated the diff for D13901: Touch support for Gwenview.

rebase

Feb 21 2019, 9:01 AM · Gwenview

Sep 29 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issues

Sep 29 2018, 5:53 AM · Gwenview

Sep 24 2018

steffenh added a comment to D13901: Touch support for Gwenview.

Hi @ngraham

Rotation should only happen when one of the fingers remains still

I am not sure, that I agree with you in this matter, because I move both fingers if I want to rotate the image.

Sep 24 2018, 5:39 PM · Gwenview

Sep 22 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

The patch has completely rewritten, to implement changes based on review comments.

Sep 22 2018, 1:57 PM · Gwenview

Aug 30 2018

steffenh added a comment to D13901: Touch support for Gwenview.

Thank you for your effort, to look over my code.

Aug 30 2018, 4:44 PM · Gwenview

Aug 3 2018

steffenh added a comment to D13901: Touch support for Gwenview.

I have test after each command

Aug 3 2018, 11:32 AM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix the issues with the new master

Aug 3 2018, 11:11 AM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

after
git checkout 2324a8681a44
and
arc patch D13901
I have found the same issue.
But if I patch manually (copy and paste from diff to documentview.h and documentview.ccp) it is working fine.

Aug 3 2018, 10:24 AM · Gwenview

Jul 29 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix double tab in View mode

Jul 29 2018, 7:39 AM · Gwenview

Jul 28 2018

steffenh added a comment to D13901: Touch support for Gwenview.

We are so close! Other than the choppy zooming, I still have a problem with double-tap in View mode not entering full screen mode. But that's it! Everything else is working really really well.

Jul 28 2018, 3:50 PM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issue

Jul 28 2018, 12:31 PM · Gwenview

Jul 25 2018

steffenh added a comment to D13901: Touch support for Gwenview.

@steffenh Could you report how touchpad gestures are working for you in Qt's example app (see https://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html)?

touchpad is not working in this example.

Jul 25 2018, 12:02 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

after some test, I found my touchpad is working for zoom and rotate action in the view mode. The zoom action (pinch on the touchpad) worked out of the box, for the rotate action I need to set an alternative shortcut to rotate left and right to "Ctrl+," and "Ctrl+.". I don't know is it my touchpad and driver Combi or work this for all touchpad's.

Jul 25 2018, 8:29 AM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

thank for testing.

Jul 25 2018, 6:27 AM · Gwenview

Jul 23 2018

steffenh added a comment to D14284: Display full path of image on main window.

Hi @rkflx

You could try replicating my test from above and check your branches. If that does not help, I would suggest to try again with a fresh checkout and without KDevelop, and list the exact commands you ran along with any changes to environment variables (let us know if we should help you with doing all that in a shell). You really should be able to get Compare mode working with the normal master branch.

Jul 23 2018, 5:18 PM
steffenh added a comment to D14284: Display full path of image on main window.

Neon has Gwenview 18.04.3, while Leap has 17.12.3, the latter of which lacks the fix (a7819f6eb53c, found by reading through this). Are you sure you are running your self-compiled Gwenview on Leap, in particular in such a way that it picks up your self-compiled libgwenviewlib.so?

Jul 23 2018, 1:30 PM
steffenh added a comment to D14284: Display full path of image on main window.

display the active image name, if you have more than one image in the view mode

Do you mean that in Compare mode the window title should change when clicking on another image? For me this is already the case without your patch.

Jul 23 2018, 9:11 AM
steffenh updated the summary of D14284: Display full path of image on main window.
Jul 23 2018, 9:01 AM
steffenh updated the summary of D14284: Display full path of image on main window.
Jul 23 2018, 9:00 AM
steffenh updated the summary of D14284: Display full path of image on main window.
Jul 23 2018, 6:49 AM
steffenh added a reviewer for D14284: Display full path of image on main window: Gwenview.
Jul 23 2018, 6:48 AM
steffenh requested review of D14284: Display full path of image on main window.
Jul 23 2018, 6:47 AM

Jul 21 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issue

Jul 21 2018, 11:51 AM · Gwenview

Jul 16 2018

steffenh added a comment to D13901: Touch support for Gwenview.

thank you again for your time, to test this patch.

Jul 16 2018, 8:45 AM · Gwenview

Jul 14 2018

steffenh updated the test plan for D13901: Touch support for Gwenview.
Jul 14 2018, 9:19 AM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issure, implented some things

Jul 14 2018, 9:18 AM · Gwenview

Jul 12 2018

steffenh added a comment to D13901: Touch support for Gwenview.

Hi @ngraham,
thank you for testing

Jul 12 2018, 11:13 AM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

For now I'd say we should defer that particular feature to a future patch. This probably needs design work/ideas/research on how that interaction should work, not only in Gwenview, but in all of KDE's apps.

Ok, I will ignore this at the moment.

Jul 12 2018, 11:07 AM · Gwenview

Jul 9 2018

steffenh updated the test plan for D13901: Touch support for Gwenview.
Jul 9 2018, 4:33 PM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issure found in the last testing from @ngraham

Jul 9 2018, 4:32 PM · Gwenview

Jul 7 2018

steffenh added a comment to D13901: Touch support for Gwenview.

many thanks for your time to test this.

Jul 7 2018, 12:14 PM · Gwenview

Jul 6 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some crashes on DragandDrop in dokumentview

Jul 6 2018, 3:12 PM · Gwenview
steffenh updated the summary of D13901: Touch support for Gwenview.
Jul 6 2018, 12:18 PM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.

implement changes based on review comments

Jul 6 2018, 12:16 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

Hi @ngraham,
thanks for your time to look after my code.
I will change my style of the code and post a new diff (after I have worked out how it works).

Jul 6 2018, 11:12 AM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

Hi @rkflx,
thanks for your testing.
I think you need a touchscreen to test this, on my Laptop the touchpad don't work with this, but I think the touchpad is broken.

Jul 6 2018, 11:07 AM · Gwenview

Jul 5 2018

steffenh added a reviewer for D13901: Touch support for Gwenview: Gwenview.
Jul 5 2018, 11:09 AM · Gwenview
steffenh requested review of D13901: Touch support for Gwenview.
Jul 5 2018, 11:06 AM · Gwenview

Jul 1 2018

steffenh added a comment to D12162: Add support for touch scrolling in Dolphin.

Hi,
I have one problem with touch on the scrollbar, it does not work proberly.
I have change follow a line in the kitemlistcontainer.cpp :

QScroller::grabGesture(this), QScroller::TouchGesture);

to:

Jul 1 2018, 10:42 AM · Dolphin