- User Since
- Jul 1 2018, 10:28 AM (100 w, 7 h)
Sun, May 24
Wed, May 20
In terms of interaction, this feels great to me! I wonder, do you think you could move the patch to https://invent.kde.org/system/dolphin/-/merge_requests/? We've recently migrated to GitLab and are trying to stop using Phabricator.
- fix the stuck TapAndHold indicator
- add a small animation to TapAndHold indicator
- set minimal speed, lower for swipe gesture
Sun, May 17
Thanks, it applies now. Everything works great, except that the two-finger swipe gestures aren't recognized for me either.
I wonder if it would be better to use a single-finger swipe for navigation, and require a very fast motion, like a flick rather than a tap-and-drag, to differentiate it from a horizontal scroll in horizontally scrollable views. What do you think?
I don't think it will work, because Qscroller uses a flick to do an autoscroll very quickly, so the problem is to be distinguished: the user wants to scroll quickly or wants to swipe.
Fri, May 15
- add a TapAndHold indicator, to give the user a visual feedback for a successful TapAndHold gesture
- tweak swipe gesture recogniser
Thu, May 14
thanks for testing this patch.
Fri, May 8
added the following functions to the patch
- TabAndHold and moving gesture over an empty spot can now start a rubber band selection
- two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up
- two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click
Tue, May 5
First, thanks for testing the patch.
The Idea with the TabAndHold over an empty area is good, I will try to make it work.
Mon, May 4
new patch is here https://phabricator.kde.org/D29419
Sat, May 2
if nobody is working on it, i will try to make it work
Dec 15 2019
remove debug messages
Dec 12 2019
I was trying to use the TapHandler, but I came across a problem with DragAndDrop that I need help with.
Dec 10 2019
Ok a quick look at TapHandler, first I am missing a positionChanged signal in the TapHandler and second we need to change QtQuick from 2.8 to 2.12.
Dec 9 2019
That's a good news. I will make a new patch in the next days, without the debug messages.
Dec 7 2019
get ride of all simulated mouse clicks
change behavior for touch (similar to touch in kickoff):
- access to the context menu after tapandhold and release touch
- drag and drop after tabandhold and moving
don't show the action buttons (selection and popup buttons) if you make a tap.
Dec 3 2019
Hi @ngraham, thanks for testing,
Dec 2 2019
Yes, I have found this, if okular is build / using new poppler versions, but I don't know why. (poppler version poppler-0.77.0 and poppler-0.62.0 is working)
Nov 30 2019
don't use simulated double mouse click to open/launch an item.
Nov 26 2019
@ngraham thanks again for testing,
Nov 25 2019
Nov 24 2019
simulate left mouse click, if touchtap ended
Nov 20 2019
oops was wrong diff, now is it the correct version
Nov 15 2019
Jul 23 2019
Before we discuss alternatives: Are you willing to have me try and teach you? I'm actually going to be very busy with a move in the next few weeks, so this could end up taking quite significant time between the two of us, but if you have the time and patience I don't mind helping you through creating the patch I had in mind.
Jul 21 2019
Oh, sorry, I have the feeling I have misunderstood the post from @hein, I have the impression he wants to make a patch to DragHelper, but if I read this again, so sorry.
Jun 30 2019
- lock mouse cursor for middle mouse button zooming
- adjust for disappear and appear of scrollbars
- try to recenter if zoom center moving below the mouse cursor
Jun 23 2019
fix typos and make centerBegin and centerEnd const
Jun 22 2019
thanks for testing,
Jun 21 2019
change variable name from tapandhold to tapAndHold
Jun 19 2019
The Question is how you do a two finger tap?
A two finger taps in the same time, this will get problems with small target.
Or you make the two finger tap over a time period (tap first finger, tap a second finger) the first finger is the target and the second finger the signal for right click.
Jun 18 2019
- Drag icon now follows the touch point
- to make the drag icon better visible, set the drag icon size for touch drag from medium to huge and move the drag icon a bit to the top and left
Jun 15 2019
Jun 13 2019
Use initial cursor position for middle-button-drag zooming
Jun 12 2019
May 18 2019
change name to KTouchGesture
add a private class for every exported class
remove unused code
May 8 2019
thanks for the link, I see KGesture is already used. I hope KGestureHandler is not too similar
Ok, I need a new name, perhaps KGesture ?
Thanks for your time to look at my code. I know, I'am not good at this, so if you can point me at my errors I will try to correct this.
May 5 2019
Mar 16 2019
I started to transfer the gestures to the framework, but I cannot promise anything.
Mar 10 2019
Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.
Mar 9 2019
I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?
Mar 3 2019
- move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
- fix some typos
- fix copyright
Feb 27 2019
Feb 24 2019
From a high level perspective, I share @rkflx's concern with the amount of duplicate code. ThumbnailView::viewportEvent() is almost entirely duplicate code from DocumentView::event(), for example. Can we refactor this into re-usable functions in touch or touch_helper or something?
I will have a look at this, perhaps I can move same code around.
Feb 21 2019
Sep 29 2018
Fix some issues
Sep 24 2018
Rotation should only happen when one of the fingers remains still
I am not sure, that I agree with you in this matter, because I move both fingers if I want to rotate the image.
Sep 22 2018
The patch has completely rewritten, to implement changes based on review comments.
Aug 30 2018
Thank you for your effort, to look over my code.
Aug 3 2018
I have test after each command
Fix the issues with the new master
git checkout 2324a8681a44
arc patch D13901
I have found the same issue.
But if I patch manually (copy and paste from diff to documentview.h and documentview.ccp) it is working fine.
Jul 29 2018
Fix double tab in View mode
Jul 28 2018
We are so close! Other than the choppy zooming, I still have a problem with double-tap in View mode not entering full screen mode. But that's it! Everything else is working really really well.
Fix some issue
Jul 25 2018
@steffenh Could you report how touchpad gestures are working for you in Qt's example app (see https://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html)?
touchpad is not working in this example.
after some test, I found my touchpad is working for zoom and rotate action in the view mode. The zoom action (pinch on the touchpad) worked out of the box, for the rotate action I need to set an alternative shortcut to rotate left and right to "Ctrl+," and "Ctrl+.". I don't know is it my touchpad and driver Combi or work this for all touchpad's.
thank for testing.
Jul 23 2018
You could try replicating my test from above and check your branches. If that does not help, I would suggest to try again with a fresh checkout and without KDevelop, and list the exact commands you ran along with any changes to environment variables (let us know if we should help you with doing all that in a shell). You really should be able to get Compare mode working with the normal master branch.
Neon has Gwenview 18.04.3, while Leap has 17.12.3, the latter of which lacks the fix (a7819f6eb53c, found by reading through this). Are you sure you are running your self-compiled Gwenview on Leap, in particular in such a way that it picks up your self-compiled libgwenviewlib.so?
display the active image name, if you have more than one image in the view mode
Do you mean that in Compare mode the window title should change when clicking on another image? For me this is already the case without your patch.
Jul 21 2018
Fix some issue
Jul 16 2018
thank you again for your time, to test this patch.
Jul 14 2018
Fix some issure, implented some things
Jul 12 2018
thank you for testing
For now I'd say we should defer that particular feature to a future patch. This probably needs design work/ideas/research on how that interaction should work, not only in Gwenview, but in all of KDE's apps.
Ok, I will ignore this at the moment.
Jul 9 2018
Fix some issure found in the last testing from @ngraham
Jul 7 2018
many thanks for your time to test this.
Jul 6 2018
Fix some crashes on DragandDrop in dokumentview
implement changes based on review comments
thanks for your time to look after my code.
I will change my style of the code and post a new diff (after I have worked out how it works).
thanks for your testing.
I think you need a touchscreen to test this, on my Laptop the touchpad don't work with this, but I think the touchpad is broken.
Jul 5 2018
Jul 1 2018
I have one problem with touch on the scrollbar, it does not work proberly.
I have change follow a line in the kitemlistcontainer.cpp :