- User Since
- Jul 1 2018, 10:28 AM (42 w, 4 d)
Mar 16 2019
I started to transfer the gestures to the framework, but I cannot promise anything.
Mar 10 2019
Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.
Mar 9 2019
I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?
Mar 3 2019
- move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
- fix some typos
- fix copyright
Feb 27 2019
Feb 24 2019
From a high level perspective, I share @rkflx's concern with the amount of duplicate code. ThumbnailView::viewportEvent() is almost entirely duplicate code from DocumentView::event(), for example. Can we refactor this into re-usable functions in touch or touch_helper or something?
I will have a look at this, perhaps I can move same code around.
Feb 21 2019
Sep 29 2018
Fix some issues
Sep 24 2018
Rotation should only happen when one of the fingers remains still
I am not sure, that I agree with you in this matter, because I move both fingers if I want to rotate the image.
Sep 22 2018
The patch has completely rewritten, to implement changes based on review comments.
Aug 30 2018
Thank you for your effort, to look over my code.
Aug 3 2018
I have test after each command
Fix the issues with the new master
git checkout 2324a8681a44
arc patch D13901
I have found the same issue.
But if I patch manually (copy and paste from diff to documentview.h and documentview.ccp) it is working fine.
Jul 29 2018
Fix double tab in View mode
Jul 28 2018
We are so close! Other than the choppy zooming, I still have a problem with double-tap in View mode not entering full screen mode. But that's it! Everything else is working really really well.
Fix some issue
Jul 25 2018
@steffenh Could you report how touchpad gestures are working for you in Qt's example app (see https://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html)?
touchpad is not working in this example.
after some test, I found my touchpad is working for zoom and rotate action in the view mode. The zoom action (pinch on the touchpad) worked out of the box, for the rotate action I need to set an alternative shortcut to rotate left and right to "Ctrl+," and "Ctrl+.". I don't know is it my touchpad and driver Combi or work this for all touchpad's.
thank for testing.
Jul 23 2018
You could try replicating my test from above and check your branches. If that does not help, I would suggest to try again with a fresh checkout and without KDevelop, and list the exact commands you ran along with any changes to environment variables (let us know if we should help you with doing all that in a shell). You really should be able to get Compare mode working with the normal master branch.
Neon has Gwenview 18.04.3, while Leap has 17.12.3, the latter of which lacks the fix (a7819f6eb53c, found by reading through this). Are you sure you are running your self-compiled Gwenview on Leap, in particular in such a way that it picks up your self-compiled libgwenviewlib.so?
display the active image name, if you have more than one image in the view mode
Do you mean that in Compare mode the window title should change when clicking on another image? For me this is already the case without your patch.
Jul 21 2018
Fix some issue
Jul 16 2018
thank you again for your time, to test this patch.
Jul 14 2018
Fix some issure, implented some things
Jul 12 2018
thank you for testing
For now I'd say we should defer that particular feature to a future patch. This probably needs design work/ideas/research on how that interaction should work, not only in Gwenview, but in all of KDE's apps.
Ok, I will ignore this at the moment.
Jul 9 2018
Fix some issure found in the last testing from @ngraham
Jul 7 2018
many thanks for your time to test this.
Jul 6 2018
Fix some crashes on DragandDrop in dokumentview
implement changes based on review comments
thanks for your time to look after my code.
I will change my style of the code and post a new diff (after I have worked out how it works).
thanks for your testing.
I think you need a touchscreen to test this, on my Laptop the touchpad don't work with this, but I think the touchpad is broken.
Jul 5 2018
Jul 1 2018
I have one problem with touch on the scrollbar, it does not work proberly.
I have change follow a line in the kitemlistcontainer.cpp :