steffenh (Steffen Hartleib)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 1 2018, 10:28 AM (6 w, 3 d)
Availability
Available

Recent Activity

Fri, Aug 3

steffenh added a comment to D13901: Touch support for Gwenview.

I have test after each command

Fri, Aug 3, 11:32 AM
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix the issues with the new master

Fri, Aug 3, 11:11 AM
steffenh added a comment to D13901: Touch support for Gwenview.

after
git checkout 2324a8681a44
and
arc patch D13901
I have found the same issue.
But if I patch manually (copy and paste from diff to documentview.h and documentview.ccp) it is working fine.

Fri, Aug 3, 10:24 AM

Sun, Jul 29

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix double tab in View mode

Sun, Jul 29, 7:39 AM

Sat, Jul 28

steffenh added a comment to D13901: Touch support for Gwenview.

We are so close! Other than the choppy zooming, I still have a problem with double-tap in View mode not entering full screen mode. But that's it! Everything else is working really really well.

Sat, Jul 28, 3:50 PM
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issue

Sat, Jul 28, 12:31 PM

Wed, Jul 25

steffenh added a comment to D13901: Touch support for Gwenview.

@steffenh Could you report how touchpad gestures are working for you in Qt's example app (see https://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html)?

touchpad is not working in this example.

Wed, Jul 25, 12:02 PM
steffenh added a comment to D13901: Touch support for Gwenview.

after some test, I found my touchpad is working for zoom and rotate action in the view mode. The zoom action (pinch on the touchpad) worked out of the box, for the rotate action I need to set an alternative shortcut to rotate left and right to "Ctrl+," and "Ctrl+.". I don't know is it my touchpad and driver Combi or work this for all touchpad's.

Wed, Jul 25, 8:29 AM
steffenh added a comment to D13901: Touch support for Gwenview.

thank for testing.

Wed, Jul 25, 6:27 AM

Mon, Jul 23

steffenh added a comment to D14284: Display full path of image on main window.

Hi @rkflx

You could try replicating my test from above and check your branches. If that does not help, I would suggest to try again with a fresh checkout and without KDevelop, and list the exact commands you ran along with any changes to environment variables (let us know if we should help you with doing all that in a shell). You really should be able to get Compare mode working with the normal master branch.

Mon, Jul 23, 5:18 PM
steffenh added a comment to D14284: Display full path of image on main window.

Neon has Gwenview 18.04.3, while Leap has 17.12.3, the latter of which lacks the fix (a7819f6eb53c, found by reading through this). Are you sure you are running your self-compiled Gwenview on Leap, in particular in such a way that it picks up your self-compiled libgwenviewlib.so?

Mon, Jul 23, 1:30 PM
steffenh added a comment to D14284: Display full path of image on main window.

display the active image name, if you have more than one image in the view mode

Do you mean that in Compare mode the window title should change when clicking on another image? For me this is already the case without your patch.

Mon, Jul 23, 9:11 AM
steffenh updated the summary of D14284: Display full path of image on main window.
Mon, Jul 23, 9:01 AM
steffenh updated the summary of D14284: Display full path of image on main window.
Mon, Jul 23, 9:00 AM
steffenh updated the summary of D14284: Display full path of image on main window.
Mon, Jul 23, 6:49 AM
steffenh added a reviewer for D14284: Display full path of image on main window: Gwenview.
Mon, Jul 23, 6:48 AM
steffenh requested review of D14284: Display full path of image on main window.
Mon, Jul 23, 6:47 AM

Sat, Jul 21

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issue

Sat, Jul 21, 11:51 AM

Jul 16 2018

steffenh added a comment to D13901: Touch support for Gwenview.

thank you again for your time, to test this patch.

Jul 16 2018, 8:45 AM

Jul 14 2018

steffenh updated the test plan for D13901: Touch support for Gwenview.
Jul 14 2018, 9:19 AM
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issure, implented some things

Jul 14 2018, 9:18 AM

Jul 12 2018

steffenh added a comment to D13901: Touch support for Gwenview.

Hi @ngraham,
thank you for testing

Jul 12 2018, 11:13 AM
steffenh added a comment to D13901: Touch support for Gwenview.

For now I'd say we should defer that particular feature to a future patch. This probably needs design work/ideas/research on how that interaction should work, not only in Gwenview, but in all of KDE's apps.

Ok, I will ignore this at the moment.

Jul 12 2018, 11:07 AM

Jul 9 2018

steffenh updated the test plan for D13901: Touch support for Gwenview.
Jul 9 2018, 4:33 PM
steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issure found in the last testing from @ngraham

Jul 9 2018, 4:32 PM

Jul 7 2018

steffenh added a comment to D13901: Touch support for Gwenview.

many thanks for your time to test this.

Jul 7 2018, 12:14 PM

Jul 6 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some crashes on DragandDrop in dokumentview

Jul 6 2018, 3:12 PM
steffenh updated the summary of D13901: Touch support for Gwenview.
Jul 6 2018, 12:18 PM
steffenh updated the diff for D13901: Touch support for Gwenview.

implement changes based on review comments

Jul 6 2018, 12:16 PM
steffenh added a comment to D13901: Touch support for Gwenview.

Hi @ngraham,
thanks for your time to look after my code.
I will change my style of the code and post a new diff (after I have worked out how it works).

Jul 6 2018, 11:12 AM
steffenh added a comment to D13901: Touch support for Gwenview.

Hi @rkflx,
thanks for your testing.
I think you need a touchscreen to test this, on my Laptop the touchpad don't work with this, but I think the touchpad is broken.

Jul 6 2018, 11:07 AM

Jul 5 2018

steffenh added a reviewer for D13901: Touch support for Gwenview: Gwenview.
Jul 5 2018, 11:09 AM
steffenh requested review of D13901: Touch support for Gwenview.
Jul 5 2018, 11:06 AM

Jul 1 2018

steffenh added a comment to D12162: Add support for touch scrolling in Dolphin.

Hi,
I have one problem with touch on the scrollbar, it does not work proberly.
I have change follow a line in the kitemlistcontainer.cpp :

QScroller::grabGesture(this), QScroller::TouchGesture);

to:

Jul 1 2018, 10:42 AM · Dolphin