New version of the patch is here:

I'm working on another version of this patch at the moment. The new version doesn't need a MouseArea in the FolderItemDelegate.
If the new patch is ready, I will make a merge request on GitLab.

In terms of interaction, this feels great to me! I wonder, do you think you could move the patch to https://invent.kde.org/system/dolphin/-/merge_requests/? We've recently migrated to GitLab and are trying to stop using Phabricator.

• fix the stuck TapAndHold indicator
• add a small animation to TapAndHold indicator
• set minimal speed, lower for swipe gesture

Thanks, it applies now. Everything works great, except that the two-finger swipe gestures aren't recognized for me either.

I wonder if it would be better to use a single-finger swipe for navigation, and require a very fast motion, like a flick rather than a tap-and-drag, to differentiate it from a horizontal scroll in horizontally scrollable views. What do you think?

I don't think it will work, because Qscroller uses a flick to do an autoscroll very quickly, so the problem is to be distinguished: the user wants to scroll quickly or wants to swipe.

• rebase
• add a TapAndHold indicator, to give the user a visual feedback for a successful TapAndHold gesture
• tweak swipe gesture recogniser

thanks for testing this patch.

added the following functions to the patch

• TabAndHold and moving gesture over an empty spot can now start a rubber band selection
• two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up
• two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click

First, thanks for testing the patch.
The Idea with the TabAndHold over an empty area is good, I will try to make it work.

new patch is here https://phabricator.kde.org/D29419

if nobody is working on it, i will try to make it work

remove debug messages

I was trying to use the TapHandler, but I came across a problem with DragAndDrop that I need help with.

Ok a quick look at TapHandler, first I am missing a positionChanged signal in the TapHandler and second we need to change QtQuick from 2.8 to 2.12.

That's a good news. I will make a new patch in the next days, without the debug messages.

get ride of all simulated mouse clicks
change behavior for touch (similar to touch in kickoff):

• access to the context menu after tapandhold and release touch
• drag and drop after tabandhold and moving

don't show the action buttons (selection and popup buttons) if you make a tap.

Hi @ngraham, thanks for testing,

Yes, I have found this, if okular is build / using new poppler versions, but I don't know why. (poppler version poppler-0.77.0 and poppler-0.62.0 is working)

rebase

don't use simulated double mouse click to open/launch an item.

@ngraham thanks again for testing,

First, thank for testing @nicolasfella and @ngraham

simulate left mouse click, if touchtap ended

oops was wrong diff, now is it the correct version

rebase

Before we discuss alternatives: Are you willing to have me try and teach you? I'm actually going to be very busy with a move in the next few weeks, so this could end up taking quite significant time between the two of us, but if you have the time and patience I don't mind helping you through creating the patch I had in mind.

Oh, sorry, I have the feeling I have misunderstood the post from @hein, I have the impression he wants to make a patch to DragHelper, but if I read this again, so sorry.

• lock mouse cursor for middle mouse button zooming
• adjust for disappear and appear of scrollbars
• try to recenter if zoom center moving below the mouse cursor

fix typos and make centerBegin and centerEnd const

Hi @aacid,
thanks for testing,

change variable name from tapandhold to tapAndHold

The Question is how you do a two finger tap?
A two finger taps in the same time, this will get problems with small target.
Or you make the two finger tap over a time period (tap first finger, tap a second finger) the first finger is the target and the second finger the signal for right click.

• Drag icon now follows the touch point
• to make the drag icon better visible, set the drag icon size for touch drag from medium to huge and move the drag icon a bit to the top and left

Use initial cursor position for middle-button-drag zooming

change name to KTouchGesture
add a private class for every exported class
remove unused code

thanks for the link, I see KGesture is already used. I hope KGestureHandler is not too similar

Ok, I need a new name, perhaps KGesture ?

Thanks for your time to look at my code. I know, I'am not good at this, so if you can point me at my errors I will try to correct this.

I started to transfer the gestures to the framework, but I cannot promise anything.

Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.

In D13901#424009, @volkov wrote:

+1 to adding gesture recognizers to KWidgetsAddons

I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?

https://cgit.kde.org/kwidgetsaddons.git

• move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
• fix some typos
• fix copyright

From a high level perspective, I share @rkflx's concern with the amount of duplicate code. ThumbnailView::viewportEvent() is almost entirely duplicate code from DocumentView::event(), for example. Can we refactor this into re-usable functions in touch or touch_helper or something?

I will have a look at this, perhaps I can move same code around.

rebase

Fix some issues

Hi @ngraham

Rotation should only happen when one of the fingers remains still

I am not sure, that I agree with you in this matter, because I move both fingers if I want to rotate the image.

The patch has completely rewritten, to implement changes based on review comments.

Thank you for your effort, to look over my code.

I have test after each command

Fix the issues with the new master

after
git checkout 2324a8681a44
and
arc patch D13901
I have found the same issue.
But if I patch manually (copy and paste from diff to documentview.h and documentview.ccp) it is working fine.

Fix double tab in View mode

We are so close! Other than the choppy zooming, I still have a problem with double-tap in View mode not entering full screen mode. But that's it! Everything else is working really really well.

Fix some issue

@steffenh Could you report how touchpad gestures are working for you in Qt's example app (see https://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html)?

touchpad is not working in this example.

after some test, I found my touchpad is working for zoom and rotate action in the view mode. The zoom action (pinch on the touchpad) worked out of the box, for the rotate action I need to set an alternative shortcut to rotate left and right to "Ctrl+," and "Ctrl+.". I don't know is it my touchpad and driver Combi or work this for all touchpad's.

thank for testing.

Hi @rkflx

You could try replicating my test from above and check your branches. If that does not help, I would suggest to try again with a fresh checkout and without KDevelop, and list the exact commands you ran along with any changes to environment variables (let us know if we should help you with doing all that in a shell). You really should be able to get Compare mode working with the normal master branch.

Neon has Gwenview 18.04.3, while Leap has 17.12.3, the latter of which lacks the fix (a7819f6eb53c, found by reading through this). Are you sure you are running your self-compiled Gwenview on Leap, in particular in such a way that it picks up your self-compiled libgwenviewlib.so?

display the active image name, if you have more than one image in the view mode

Do you mean that in Compare mode the window title should change when clicking on another image? For me this is already the case without your patch.

Fix some issue

thank you again for your time, to test this patch.

Fix some issure, implented some things

Hi @ngraham,
thank you for testing

For now I'd say we should defer that particular feature to a future patch. This probably needs design work/ideas/research on how that interaction should work, not only in Gwenview, but in all of KDE's apps.

Ok, I will ignore this at the moment.

Fix some issure found in the last testing from @ngraham

many thanks for your time to test this.

Fix some crashes on DragandDrop in dokumentview

implement changes based on review comments

Hi @ngraham,
thanks for your time to look after my code.
I will change my style of the code and post a new diff (after I have worked out how it works).

Hi @rkflx,
thanks for your testing.
I think you need a touchscreen to test this, on my Laptop the touchpad don't work with this, but I think the touchpad is broken.

Hi,
I have one problem with touch on the scrollbar, it does not work proberly.
I have change follow a line in the kitemlistcontainer.cpp :

QScroller::grabGesture(this), QScroller::TouchGesture);

to: