[RFC] Fix Display Configuration icon margins
Needs ReviewPublic

Authored by ngraham on Thu, Nov 14, 4:00 AM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Summary

The icon's old margins were too large, causing it to stick out.

However in the process of fixing this, I managed to break the stylesheet so it no longer
changes its colors and make the icon blurry, despite the fact that it appears perfectly
pixel-aligned to the Inkscape grid.

VDG assistance would be appreciated to help me figure out what's wrong here.

BUG: 400087
FIXED-IN; 5.65

Test Plan

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
fix-xrandr-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18831
Build 18849: arc lint + arc unit
ngraham created this revision.Thu, Nov 14, 4:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Nov 14, 4:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Nov 14, 4:00 AM

It's blurry in your screenshot because you're scaling a 22px icon up to 32px. The solution is to make a 32px version named 32-32-preferences-desktop-display-randr. BTW, the icon is not actually aligned with the grid. It's a little off here and there. You should be able to fix it easily with the node tool by snapping nodes to the grid.

ndavis added inline comments.Fri, Nov 15, 9:00 AM
src/desktoptheme/breeze/icons/preferences.svg
0–1

Wrong default colors. Just replace the whole stylesheet with this one: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze

1

You have 2 embedded stylesheets, although I doubt the 2nd one actually works since the ID isn't correct. You can delete the 2nd one.

6

Hardcoded color

7

Hardcoded color. Inkscape does this to any element of the SVG you modify.

ngraham updated this revision to Diff 69815.EditedFri, Nov 15, 3:57 PM
ngraham marked 4 inline comments as done.
  • Fix stylesheet and color-changing ability
  • Align to grid; vertical lines still blurry, not sure why

I figured it out. The 22px version needs the 22-22- prefix in its ID.

Hmm, if I change that, the icon disappears entirely when displayed at the 22px size:

Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one:

@ndavis or @trickyricky26, could I ping you on this?

ndavis added a comment.Fri, Dec 6, 4:27 PM

Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one:

The color vs monochrome issue strikes again :(

Maybe remove the size prefix from the 32px version? If that doesn't work, I've got nothing.