scottpetrovic (Scott Petrovic)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 1:01 PM (209 w, 3 d)
Availability
Available

Recent Activity

Today

scottpetrovic abandoned D20500: BUG: 404975 Really hard to choose color in tool options.

I just moved this ticket to gitlab
https://invent.kde.org/kde/krita/merge_requests/10

Sat, Apr 20, 1:32 PM · Krita

Thu, Apr 18

scottpetrovic committed R158:4af1dc3f9d24: Merge branch 'master' into 'master' (authored by scottpetrovic).
Merge branch 'master' into 'master'
Thu, Apr 18, 8:04 PM
scottpetrovic committed R158:d9368bcf690b: Revert "Trying to submit changes through HTTPS" (authored by scottpetrovic).
Revert "Trying to submit changes through HTTPS"
Thu, Apr 18, 8:04 PM
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@gernene -- sure. you could start coming up with some code for it. This site uses bootstrap for the responsive stuff, so just keep that in mind.

Thu, Apr 18, 6:12 PM · Krita
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@leksireppo - hey! I am not sure how you would like to help with Krita. Do you want to help with something specifically with this task, or is there something else you think needs updating?

Thu, Apr 18, 12:29 PM · Krita
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@gernene - I think this project started out with adding a section to the homepage to attract new contributors which you are doing.

Thu, Apr 18, 12:28 PM · Krita

Wed, Apr 17

scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@gernene I am not sure what you proposing we do. I know this is the current flow people use to learn more...

Wed, Apr 17, 6:02 PM · Krita
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

Yes, we have anlalytics for krita.org and docs.krita.org.

Wed, Apr 17, 5:52 PM · Krita
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@woltherav - thanks. That is kind of similar to what I was thinking. I just came up with this in terms of a condensed page.

Wed, Apr 17, 3:33 PM · Krita
scottpetrovic added a comment to T10802: 4.2: Tablet settings dialog needs updating..

This is what it looks like on the last nightly build on Windows...

Wed, Apr 17, 3:21 PM · Krita: Manual

Tue, Apr 16

scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@woltherav - wow. that looks pretty cool. I like the mention on the bottom that donating is also a way to contribute.

Tue, Apr 16, 3:48 PM · Krita
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

We probably need to come up with some new content to help direct people for these sections. I will spend a bit of time and come up with new content. For example....

Tue, Apr 16, 2:05 PM · Krita
scottpetrovic updated subscribers of M149: Increasing Recruitment Via krita.org.

@gernene - that looks better with the call to action stuff.

Tue, Apr 16, 12:45 PM · Krita

Mon, Apr 15

scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.
  1. Good ideas. See if you can come up with how something might look.
  2. Good idea with the internal anchors going to the correct section on one of the pages.
Mon, Apr 15, 4:21 PM · Krita
scottpetrovic added a comment to M149: Increasing Recruitment Via krita.org.

@gernene good ideas

Mon, Apr 15, 3:48 PM · Krita
scottpetrovic added a comment to D15577: add move to top/bottom of parent layer functionality to layer docker.

I am here for an opinion too. I would say yes to maybe having it in the shortcuts/right-click option when selecting multiple layers. I do not like it in the GUI though on the bottom of the layers docker.

Mon, Apr 15, 3:47 PM · Krita

Sat, Apr 13

scottpetrovic committed R37:70ac5d1466cc: BUG:406233 Increase control point size a bit for easier grabbing (authored by scottpetrovic).
BUG:406233 Increase control point size a bit for easier grabbing
Sat, Apr 13, 10:30 PM
scottpetrovic added a comment to D20504: Updating build instructions for the manual.

Seems good to me

Sat, Apr 13, 12:00 PM · Krita: Manual

Fri, Apr 12

scottpetrovic updated the summary of D20500: BUG: 404975 Really hard to choose color in tool options.
Fri, Apr 12, 9:29 PM · Krita
scottpetrovic requested review of D20500: BUG: 404975 Really hard to choose color in tool options.
Fri, Apr 12, 9:24 PM · Krita

Tue, Apr 9

scottpetrovic closed D20401: Updates to G'Mic plugin section.

pushed out to the draft branch. Thanks for the quick review @woltherav

Tue, Apr 9, 9:44 PM · Krita: Manual
scottpetrovic committed R1012:d45e15db83d8: D20401 add instructions on updating GMIC (authored by scottpetrovic).
D20401 add instructions on updating GMIC
Tue, Apr 9, 9:44 PM
scottpetrovic requested review of D20401: Updates to G'Mic plugin section.
Tue, Apr 9, 6:47 AM · Krita: Manual
scottpetrovic committed R37:62b4e3f3b9ce: BUG:402990 Tablet fix for popup palette and right click (authored by scottpetrovic).
BUG:402990 Tablet fix for popup palette and right click
Tue, Apr 9, 12:29 AM

Thu, Apr 4

scottpetrovic awarded T10762: Krita 4.2 release a Love token.
Thu, Apr 4, 3:43 PM · Krita: Releases
scottpetrovic committed R37:4689792431b1: Make it easier to select smaller values in layer styles sliders (authored by scottpetrovic).
Make it easier to select smaller values in layer styles sliders
Thu, Apr 4, 2:59 AM
scottpetrovic committed R37:bcbcf3661cef: Make checkbox borders the same as text color. They were still hidden on some… (authored by scottpetrovic).
Make checkbox borders the same as text color. They were still hidden on some…
Thu, Apr 4, 2:59 AM
scottpetrovic committed R37:55b89ddeb42d: improve visibility for checkboxes on layer styles list (authored by scottpetrovic).
improve visibility for checkboxes on layer styles list
Thu, Apr 4, 2:59 AM
scottpetrovic committed R37:c05b3acde68f: BUG:406036 Allow group layers to be transformed and improve logic for layers… (authored by scottpetrovic).
BUG:406036 Allow group layers to be transformed and improve logic for layers…
Thu, Apr 4, 2:24 AM

Tue, Apr 2

scottpetrovic added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

This patch currently does layer changing to get to the newly created mask, which is what would be overlapping with gdquest's situation. If we want the new mask to automatically activate, I will have to figure out a different way to automatically activate it. Currently in Krita switching to a different layer de-activates the transform tool boundaries

Tue, Apr 2, 4:55 PM · Krita
scottpetrovic added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

@dkazakov -- I think I understand your points. I think the video was meant to be for artists for them to help decide how they want this tool and functionality to work. The current functionality in stable is not how some artists want it. Maybe I can make a video to help communicate the different directions that the tool could go.

Tue, Apr 2, 4:03 PM · Krita
scottpetrovic updated subscribers of D18792: Automatically create transform masks on layer types that cannot be transformed.

We might need a bit of discussion about both of these points to figure out what needs to happen.

Tue, Apr 2, 12:19 PM · Krita
scottpetrovic added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

With the group layers and the handles immedietly showing up...I noticed a group layer initially doesn't show the handles. If you select a child layer, then select the group layer again, it shows up.

Tue, Apr 2, 2:18 AM · Krita
scottpetrovic updated the diff for D18792: Automatically create transform masks on layer types that cannot be transformed.

I mostly just added a bit of logic to get the handles to show up faster. The issue with the handles not appearing instantly was because layer changes on the transform tool messes up the paint() from fully rendering.

Tue, Apr 2, 2:15 AM · Krita

Mon, Apr 1

scottpetrovic closed D20131: Fix for bug "lost frames if you add too many hold frames".

did a bit more commenting and fixed the white space.

Mon, Apr 1, 11:32 PM · Krita
scottpetrovic committed R37:e2002aa04ff3: fix extra white space on last commit (authored by scottpetrovic).
fix extra white space on last commit
Mon, Apr 1, 11:32 PM
scottpetrovic committed R37:e1be1dad8f0c: BUG:404246 Fix data loss when adding multiple hold frames for animation (authored by scottpetrovic).
BUG:404246 Fix data loss when adding multiple hold frames for animation
Mon, Apr 1, 11:31 PM

Sat, Mar 30

scottpetrovic requested review of D20131: Fix for bug "lost frames if you add too many hold frames".
Sat, Mar 30, 9:31 PM · Krita

Fri, Mar 29

scottpetrovic committed R37:534415655dea: BUG404190 Improve visibility in checkboxes (authored by scottpetrovic).
BUG404190 Improve visibility in checkboxes
Fri, Mar 29, 9:44 PM
scottpetrovic committed R37:dc6f233b71b9: Improve readability for checkboxes on pen sensors area in brush editor (authored by scottpetrovic).
Improve readability for checkboxes on pen sensors area in brush editor
Fri, Mar 29, 9:44 PM
scottpetrovic closed D20094: Move onion skin color filtering out of combo box.

This is pushed out... It will be in master and in Krita 4.2

Fri, Mar 29, 9:33 PM · Krita
scottpetrovic committed R37:130d6137845e: D20094 move color filters on onion skin docker outside of combo box (authored by scottpetrovic).
D20094 move color filters on onion skin docker outside of combo box
Fri, Mar 29, 9:32 PM
scottpetrovic added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

Just a note about that work recursive toggle on the tool options for the transform tool.

Fri, Mar 29, 3:52 PM · Krita
scottpetrovic updated the diff for D18792: Automatically create transform masks on layer types that cannot be transformed.

Updated logic with recursive mode and group layers. The added mask is skipped now in that situation

Fri, Mar 29, 2:53 PM · Krita
scottpetrovic updated the diff for D18792: Automatically create transform masks on layer types that cannot be transformed.

I took care of most of the points, so the the undo works now with it. I moved the function to the startStroke area as well. I also fixed a recent regression where transforming doesn't work on things like clone layers and vector layers.

Fri, Mar 29, 2:19 PM · Krita

Thu, Mar 28

scottpetrovic updated the summary of D20094: Move onion skin color filtering out of combo box.
Thu, Mar 28, 7:39 PM · Krita
scottpetrovic updated the diff for D20094: Move onion skin color filtering out of combo box.

Updated the diff a bit. Added another color filter on the end so it matches what we had before.

Thu, Mar 28, 7:39 PM · Krita
scottpetrovic updated the summary of D20094: Move onion skin color filtering out of combo box.
Thu, Mar 28, 3:44 PM · Krita
scottpetrovic requested review of D20094: Move onion skin color filtering out of combo box.
Thu, Mar 28, 3:43 PM · Krita

Mar 21 2019

scottpetrovic added a comment to M148: Idea for Reference animation frames.

The wireframe alone is hard to tell how the workflow would be with this... I tried putting together a video with how it would work. I am not too good with video editing, so forgive the "popping" that happens with the onion skin docker.

Mar 21 2019, 12:09 AM · Krita

Mar 20 2019

scottpetrovic added a comment to M148: Idea for Reference animation frames.

Based off the video in the previous conversation, the animator is putting the previous frame and the next frame to the new in-between position so the two drawings overlap. I added to the wireframe the ability to add 2 reference frames. I think they should default to before and after frames.

Mar 20 2019, 1:43 PM · Krita
scottpetrovic updated images of M148: Idea for Reference animation frames.
Mar 20 2019, 1:34 PM · Krita

Mar 19 2019

scottpetrovic added a comment to M148: Idea for Reference animation frames.

some additional conversation (IRC) and video from FlameReaper on how he uses it....
https://drive.google.com/file/d/1CVooALeUVgMDG9WgQd-zNVe1a7EptIjA/view

Mar 19 2019, 6:02 PM · Krita
scottpetrovic added a comment to M148: Idea for Reference animation frames.

Additional Reference:
Clip studio puts these in a separate area called light table layers: https://www.clip-studio.com/site/gd_en/csp/userguide/csp_userguide/577_animationcell_plt/577_animationcell_plt_ope.htm

Mar 19 2019, 12:53 PM · Krita

Mar 18 2019

scottpetrovic created M148: Idea for Reference animation frames.
Mar 18 2019, 8:02 PM · Krita

Mar 16 2019

scottpetrovic added a comment to M147: Post-download page design update.

just made these changes...closing this ticket.

Mar 16 2019, 10:30 PM · Krita
scottpetrovic closed mock M147: Post-download page design update.
Mar 16 2019, 10:30 PM · Krita
scottpetrovic closed D16438: Add textures for experiment brush .

Pushed out...closing

Mar 16 2019, 3:31 PM · Krita
scottpetrovic committed R37:3e31645058a1: D16438: Add ability to use patterns will shape brush (authored by albertoefg).
D16438: Add ability to use patterns will shape brush
Mar 16 2019, 3:29 PM

Mar 13 2019

scottpetrovic updated the diff for D16438: Add textures for experiment brush .

updated code to use enum instead of separate boolean values for fill type

Mar 13 2019, 3:10 AM · Krita

Mar 12 2019

scottpetrovic commandeered D16438: Add textures for experiment brush .

I talked with @albertoefg about this ticket. He is ok with me finishing this guy off.

Mar 12 2019, 5:29 PM · Krita
scottpetrovic added a comment to D16438: Add textures for experiment brush .

@albertoefg - Are you still working on this. If not, would you be ok if I took this patch over and finished it off. I think the patch is still pretty much yours, so you can still get the credit for it.

Mar 12 2019, 3:20 PM · Krita

Mar 9 2019

scottpetrovic added a comment to D19630: Update the getting started section.

Everything looks fine to me

Mar 9 2019, 6:12 AM · Krita: Manual

Mar 8 2019

scottpetrovic added a comment to D19597: Make a staggered second row of preset icons in the popup palette for large values..

yes. Looks nice!

Mar 8 2019, 4:10 PM · Krita

Mar 7 2019

scottpetrovic added a comment to D19597: Make a staggered second row of preset icons in the popup palette for large values..

Good idea. I wonder if we can extract this logic and put it in a function to isolate what is going on. There is a lot math stuff going on with this file already, so I am always a little concerned that adding more math stuff is going to make this file even harder to understand if we don't try to organize/comment it more.

Mar 7 2019, 4:38 PM · Krita

Mar 5 2019

scottpetrovic committed R1012:20f092d58f9c: update correct link for Ramon Miranda brushes (authored by scottpetrovic).
update correct link for Ramon Miranda brushes
Mar 5 2019, 6:29 PM
scottpetrovic committed R1012:a1eb885cfa0f: update image and link to Ramon Miranda resource pack (authored by scottpetrovic).
update image and link to Ramon Miranda resource pack
Mar 5 2019, 12:34 AM

Mar 4 2019

scottpetrovic accepted D19462: Lint Css.
Mar 4 2019, 2:06 PM · Krita: Manual
scottpetrovic added a comment to D19462: Lint Css.

it seems fine to me.

Mar 4 2019, 2:06 PM · Krita: Manual

Feb 28 2019

scottpetrovic created M147: Post-download page design update.
Feb 28 2019, 6:41 PM · Krita

Feb 26 2019

scottpetrovic added a comment to T10534: Simplify and refine multibrush tool options.

I attached one idea for the tool options for the multi-brush.

Feb 26 2019, 9:09 PM · Krita
scottpetrovic added a comment to T10534: Simplify and refine multibrush tool options.

@kamathraghavendra - I closed that ticket. That was a wishlist item to add the copy translate feature to begin with. The person that reported it was the same person that actually coded the feature. I think the UI idea on that ticket was to make a new popup to define the sub-brushes. I think we agreed that it was too disruptive...so we opted for adding the brushes right on the canvas and keep the options on the tool options.

Feb 26 2019, 7:25 PM · Krita

Feb 22 2019

scottpetrovic added a comment to D19227: Add information about how to translate the docs to the contributor's manual..

Looks good to me

Feb 22 2019, 4:00 PM · Krita: Manual

Feb 6 2019

woltherav awarded D18792: Automatically create transform masks on layer types that cannot be transformed a Love token.
Feb 6 2019, 7:17 PM · Krita
scottpetrovic requested review of D18792: Automatically create transform masks on layer types that cannot be transformed.
Feb 6 2019, 7:15 PM · Krita

Feb 5 2019

scottpetrovic updated the diff for D18412: Add options to wrap-around mode to only do vertical and horizontal.

I think I updated all your points. I ended up refactoring the code so it is shared. Adding more if statements for the pixel grid was a bit sloppy for me, so I moved it all to a new calculation function that does that for the other areas to use later.

Feb 5 2019, 8:36 PM · Krita

Jan 25 2019

scottpetrovic updated the diff for D18412: Add options to wrap-around mode to only do vertical and horizontal.

@dkazakov I think most of the issues are resolved except the disputable one.

Jan 25 2019, 3:25 PM · Krita
scottpetrovic added a comment to T8576: Improve Brush Opacity handling..

👍 +1

Jan 25 2019, 2:59 PM · Krita: Abyss

Jan 21 2019

scottpetrovic updated the diff for D18412: Add options to wrap-around mode to only do vertical and horizontal.

I updated the logic so it tries to more intelligently calculate the width and height when you toggle the vertical and horizontal. I think this should fix the issue @dkazakov found.

Jan 21 2019, 3:31 PM · Krita

Jan 20 2019

woltherav awarded D18412: Add options to wrap-around mode to only do vertical and horizontal a Love token.
Jan 20 2019, 8:10 PM · Krita
scottpetrovic requested review of D18412: Add options to wrap-around mode to only do vertical and horizontal.
Jan 20 2019, 6:45 PM · Krita

Jan 19 2019

scottpetrovic closed D18336: Improve decoration display for multibrush tool.

Pushed and closing...

Jan 19 2019, 5:28 PM · Krita
scottpetrovic committed R37:03c868c3d194: D18336: Improve decorations for multi brush tool (authored by scottpetrovic).
D18336: Improve decorations for multi brush tool
Jan 19 2019, 5:27 PM

Jan 18 2019

scottpetrovic added a comment to D18323: Add all arrange docker actions to the shape selection tool context menu..

@woltherav @amedonosova I could be mistaken, but this is just adding another way to get to the arrange functions. The Arrange docker is not being removed, so people can still go to that to use that if they want icons and a GUI interface for doing the arrange operations. I don't see really any reason to have a conflict of interest with this. There are a lot of things in the application that have multiple ways to access them. People like options.

Jan 18 2019, 4:21 PM · Krita

Jan 17 2019

woltherav awarded D18336: Improve decoration display for multibrush tool a Love token.
Jan 17 2019, 7:08 PM · Krita
scottpetrovic updated the summary of D18336: Improve decoration display for multibrush tool.
Jan 17 2019, 7:08 PM · Krita
scottpetrovic requested review of D18336: Improve decoration display for multibrush tool.
Jan 17 2019, 7:07 PM · Krita

Jan 10 2019

scottpetrovic committed R37:95773b5057b1: D18098 Add hasKeyframeAtTime function to Node Python API (authored by scottpetrovic).
D18098 Add hasKeyframeAtTime function to Node Python API
Jan 10 2019, 2:24 PM

Jan 9 2019

scottpetrovic updated the diff for D18098: Add "hasKeyframeAtTime" function for Node Python API.

Updated the diff removing the extra logic and replacing it with a safe assert. Using the python, it seems ok and I don't get any errors or issues

Jan 9 2019, 11:43 PM · Krita
scottpetrovic updated the test plan for D18098: Add "hasKeyframeAtTime" function for Node Python API.
Jan 9 2019, 11:42 PM · Krita

Jan 8 2019

scottpetrovic updated the test plan for D18098: Add "hasKeyframeAtTime" function for Node Python API.
Jan 8 2019, 3:08 PM · Krita
scottpetrovic requested review of D18098: Add "hasKeyframeAtTime" function for Node Python API.
Jan 8 2019, 3:06 PM · Krita

Jan 7 2019

scottpetrovic abandoned D14698: Text Editor UX improvements.

forgot to close this.

Jan 7 2019, 9:16 PM · Krita
scottpetrovic abandoned D14496: Animation: Turn play/stop into play/pause button. Add separate button for stop.

closing this. I am not really working on it and it probably needs more discussion

Jan 7 2019, 9:15 PM · Krita

Dec 19 2018

scottpetrovic added a comment to T10178: docs.krita.org organization and structure for future changes.

@emmetoneill I am not sure what you are proposing exactly. Are you proposing that we remove the reference guide, general concepts, and tutorials area. Or are you proposing to move all that stuff into the user manual under a beginner, intermediate, and advanced areas. The way I am reading your comment, the "big picture" appears to only talk about the user manual. I don't see any references to our other areas like tutorials, reference manual, or general concepts areas and how those fit in.

Dec 19 2018, 5:30 PM · Krita

Dec 11 2018

scottpetrovic added a comment to T10178: docs.krita.org organization and structure for future changes.

@woltherav - alright, so you are thinking the user manual needs to do a couple things. Looking at a few pages, I see a pattern we might want to try to follow for all the areas in the user manual.

Dec 11 2018, 5:09 PM · Krita
scottpetrovic created T10178: docs.krita.org organization and structure for future changes.
Dec 11 2018, 2:38 PM · Krita
scottpetrovic closed T9631: Create a bug counter widget for krita.org, a subtask of T9629: Goal Definition and Campaign Story, as Wontfix.
Dec 11 2018, 2:14 PM · Krita
scottpetrovic closed T9631: Create a bug counter widget for krita.org as Wontfix.

Closing this ticket. I am not working on this and I am not sure if there is a good way to get this data for krita.org to consume and show to people. We can look at it again if this comes up.

Dec 11 2018, 2:14 PM · Krita

Nov 17 2018

scottpetrovic committed R37:1519ff6843e4: Lower the opacity of the popup palette when someone is actively rotating or… (authored by scottpetrovic).
Lower the opacity of the popup palette when someone is actively rotating or…
Nov 17 2018, 4:36 AM