- User Since
- Feb 5 2015, 10:18 AM (175 w, 5 d)
Mon, Jun 11
May 4 2018
Apr 30 2018
Confused that you didn't update this patch but introduced a new one, but fair enough the whole series looks good together.
Just a couple of minor issues
Apr 29 2018
OK, I see. I'd rather have smaller commits, so let's go for the two variables. It's supposed to be transitional anyway.
Shouldn't we reuse the ZANSHIN_OVERRIDE_DATETIME environment variable here? Just to avoid situations where currentDate() and currentDateTime() are out of sync because the two variables aren't properly set?
Apr 26 2018
Apr 24 2018
The still failing cases I found seem to all revolve around "spaces not in the directory name but in the cover file name", currently my approach can't deal with that correctly. Also in cases of more than one match we don't necessarily pick the best one (yes... in some cases I have more than one match now because it's more aggressive). That's why in the end we probably want to list all jpg and png, score them and sort them based on the score to pick the best one. I'll see if I get to it at some point but for now I went for the simple fixes which remove my biggest pain points. :-)
Apr 23 2018
Apr 21 2018
Good point, I was thinking @gladhorn in fact. Sorry. :-)
Well, that wiki page seems out of date: https://community.kde.org/Incubator/Projects/Falkon
I'd like to point out again the talk we delivered at Akademy 2017 with @dfaure (it is referred to in the parent task of that one). For most cases we should strive at not forcing people to use a VM or a container. Especially if we want to make it easier for people on non-Linux platforms to contribute. The highest potential solution is the one using conan but since @fredrik prototype no activity has happened in that direction.
Looks good as well
Looks good to me
Mar 9 2018
Mar 6 2018
Mar 4 2018
Jan 15 2018
Jan 3 2018
Dec 26 2017
Oh right, would better use Utils::DateTime::currentDateTime() or similar. This one is overridable through the env var ZANSHIN_OVERRIDE_DATETIME.
It likely doesn't hit your bug since we don't use real akonadi for those tests anymore but a stub.
Surely asks for a unit test, isn't it? Otherwise totally agree with the fix.
Dec 20 2017
Looks good to me. Waiting for the Dolphin people to look at it.
I wonder if the test wouldn't be better inside addItemFromSourceModel? Other than that, looks good to me.
Dec 19 2017
Couple of smaller issues. Otherwise I didn't spot anything which looked very wrong to me, admittedly I don't know much about okular though.
Looks fine to me as well.
Looks fine to me, but I'm not a Dolphin expert so I'll let someone else more knowledgeable accept it.
Nov 28 2017
Nov 27 2017
Nov 24 2017
A small nitpick otherwise lgtm.
Nov 2 2017
Looks good to me too but want to give the plasma team the last say.
Couple more changes needed.
Oct 31 2017
Looks good to me, but I'm giving time for the Plasma team to see it.
At least the unit test would be welcome, I let you decide on the other comment.
Found a small one after all.
All the fiddling with URLs makes me wonder if that wouldn't be better done on the KIO implementations side... but that's out of scope for that patch I think.
Great work BTW, this looks really nice now.
Ah my apologies, I thought the goal here was to capture the whole spectrum of contributors. Of course if the goal was to focus on non-coding contributors then this is fine.
Oct 30 2017
Looks fine code wise now, just a couple more tweaks to make those sections look closer to what Dolphin got.
I'll sound like a broken record but: if we don't solve the "how difficult it is to build something and patch it" *first* all the nice things mentioned here with mentoring etc. (which require people we don't have BTW) won't get us far. People will try, fail immediately because it's too hard and leave again.
Seen that enough with my students the past few years.
Oct 20 2017
Yes, it'd be nice to see them finally merging, we're late in the discussion phase now. Also as a bonus, it would be awesome if the consolidated proposal could contain aspects coming from the talk we held with David Faure this year about the developer story. That'd make for a very strong one then, and would probably add at least David's name in the list of people willing to put work into it. ;-)