ervin (Kevin Ottens)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2015, 10:18 AM (268 w, 2 d)
Availability
Available

Recent Activity

Yesterday

ervin accepted D28310: Wayland: Allow to set a scroll Factor for input devices.

LGTM

Fri, Mar 27, 9:13 PM · KWin
ervin accepted D27784: KCM KWinTabBox manage KCModule states.
Fri, Mar 27, 9:12 PM · KWin
ervin added a reviewer for D27540: KCModule: Indicate when a setting has been changed from the default or previous value: broulik.
Fri, Mar 27, 8:57 PM · Frameworks
ervin updated the diff for D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

As advised by Kai and David on D27840, switch to using tool buttons and fix RTL handling.

Fri, Mar 27, 8:57 PM · Frameworks
ervin updated the diff for D27840: Introduce SettingState* elements to ease KCM writing.

Addresses Kai and David comments.

Fri, Mar 27, 7:50 PM · Frameworks
ervin added inline comments to D27840: Introduce SettingState* elements to ease KCM writing.
Fri, Mar 27, 7:50 PM · Frameworks
ervin accepted D27988: KCM/Compositing: Use KConfig XT in UI.
Fri, Mar 27, 5:54 PM · KWin
ervin added inline comments to D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland.
Fri, Mar 27, 5:52 PM · Plasma
ervin requested changes to D26934: KCM/Autostart Add a model to separate logic from UI.

Damn turns out I still missed a few, so what @broulik says (when it still applies).

Fri, Mar 27, 5:44 PM · Plasma
ervin requested changes to D28310: Wayland: Allow to set a scroll Factor for input devices.
Fri, Mar 27, 5:39 PM · KWin
ervin accepted D26934: KCM/Autostart Add a model to separate logic from UI.

Thanks for your patience :-)

Fri, Mar 27, 5:29 PM · Plasma
ervin requested changes to D26934: KCM/Autostart Add a model to separate logic from UI.

One last nitpick

Fri, Mar 27, 5:28 PM · Plasma
ervin requested changes to D27988: KCM/Compositing: Use KConfig XT in UI.
Fri, Mar 27, 5:27 PM · KWin
ervin requested changes to D28221: Don't write default value to configuration file when default value came from /etc/* file.
Fri, Mar 27, 5:15 PM · Frameworks
ervin accepted D27934: KCM/Kwinoptions: Port focus tab to KConfigXT.
Fri, Mar 27, 5:11 PM · KWin
ervin requested changes to D26934: KCM/Autostart Add a model to separate logic from UI.
Fri, Mar 27, 5:08 PM · Plasma
ervin accepted D27862: [WIP] KCM KWinTouchScreen port to KConfigXT.
Fri, Mar 27, 4:53 PM · KWin
ervin accepted D27955: KCM/Compositing: Use KConfig XT to store values.
Fri, Mar 27, 4:44 PM · KWin
ervin added inline comments to D27784: KCM KWinTabBox manage KCModule states.
Fri, Mar 27, 4:32 PM · KWin
ervin accepted D27971: Solid-device-automounter/kcm: correctly update automountOn.
Fri, Mar 27, 4:25 PM · Plasma
ervin added inline comments to D28128: Add force save behavior to KEntryMap.
Fri, Mar 27, 4:23 PM · Frameworks

Wed, Mar 25

ervin added a comment to D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

Is it possible to align all of the reset buttons like a column?

Why I'm not surprised. ;-)

Honestly with enough code it might be possible, but that'd be expensive in term of effort... I'll need to keep track of all widgets in the page. I'll give it a shot but don't hold your breath.

Wed, Mar 25, 3:55 PM · Frameworks
ervin updated the test plan for D27540: KCModule: Indicate when a setting has been changed from the default or previous value.
Wed, Mar 25, 3:52 PM · Frameworks
ervin updated the diff for D27840: Introduce SettingState* elements to ease KCM writing.

Have the indicators line up vertically automatically when applicable

Wed, Mar 25, 3:52 PM · Frameworks
ervin updated the diff for D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

Have the indicators vertically line up automatically

Wed, Mar 25, 3:51 PM · Frameworks

Wed, Mar 18

ervin added a comment to D27063: Fix disabeling of autolock timeout.

Ah didn't know! I assumed you could push... But yeah, you authored a few patches now, time to apply for a developer account. You can put my name indeed.

Wed, Mar 18, 5:16 PM · Plasma
ervin added a comment to D27063: Fix disabeling of autolock timeout.

Well, I already accepted it, I thought you pushed long ago (and I suspect it got overlooked by the other potential reviewers). :-)

Wed, Mar 18, 4:59 PM · Plasma

Tue, Mar 17

ervin added a comment to D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

Is it possible to align all of the reset buttons like a column?

Tue, Mar 17, 5:39 PM · Frameworks
ervin updated the diff for D27840: Introduce SettingState* elements to ease KCM writing.

Take feedback about the GUI into account

Tue, Mar 17, 5:04 PM · Frameworks
ervin updated the test plan for D27540: KCModule: Indicate when a setting has been changed from the default or previous value.
Tue, Mar 17, 5:02 PM · Frameworks
ervin updated the test plan for D27540: KCModule: Indicate when a setting has been changed from the default or previous value.
Tue, Mar 17, 5:01 PM · Frameworks
ervin updated the diff for D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

Take feedback about the GUI into account

Tue, Mar 17, 5:00 PM · Frameworks
ervin added a comment to D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

Some extra rules I thought of:

  • With the checkable label example in the mockup above, it should reset both the label and the checkbox.
Tue, Mar 17, 3:44 PM · Frameworks

Mon, Mar 16

ervin requested changes to D27988: KCM/Compositing: Use KConfig XT in UI.
Mon, Mar 16, 6:53 PM · KWin
ervin accepted D27133: kconfig_compiler : generate kconfig settings with subgroup.
Mon, Mar 16, 6:45 PM · Frameworks
ervin requested changes to D27971: Solid-device-automounter/kcm: correctly update automountOn.
Mon, Mar 16, 5:24 PM · Plasma
ervin accepted D27971: Solid-device-automounter/kcm: correctly update automountOn.
Mon, Mar 16, 5:23 PM · Plasma
ervin added a comment to D27956: [Various KCMs] Notify about changes in GTK related settings.

I'm finding myself wondering why we don't just make everything notify by default.

Mon, Mar 16, 5:20 PM · Plasma
ervin requested changes to D27955: KCM/Compositing: Use KConfig XT to store values.

It's a first step toward using addConfig later on,right?

Mon, Mar 16, 4:50 PM · KWin
ervin requested changes to D27862: [WIP] KCM KWinTouchScreen port to KConfigXT.
Mon, Mar 16, 4:37 PM · KWin
ervin requested changes to D27784: KCM KWinTabBox manage KCModule states.
Mon, Mar 16, 3:59 PM · KWin
ervin requested changes to D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions.

What @meven said about the typo, otherwise LGTM indeed.

Mon, Mar 16, 3:39 PM · Frameworks
ervin added a comment to D27944: KCM Colors fix apply button always disabled.

I marked it accepted, but of course this is assuming David's patch wouldn't make it quickly and we'd need the fix here ASAP.

Mon, Mar 16, 3:30 PM · Plasma
ervin accepted D27944: KCM Colors fix apply button always disabled.
Mon, Mar 16, 3:29 PM · Plasma
ervin accepted D27502: Create ConfigView an unmanaged ConfigWidget.
Mon, Mar 16, 3:28 PM · Frameworks
ervin accepted D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Mon, Mar 16, 3:27 PM · Plasma
ervin requested changes to D26934: KCM/Autostart Add a model to separate logic from UI.
Mon, Mar 16, 2:36 PM · Plasma
ervin accepted D27682: Port kwinrules kcm to kconfigxt.
Mon, Mar 16, 12:05 PM · KWin
ervin accepted D27380: [GTK Config] Construct font style by hand instead of relying on Qt function.
Mon, Mar 16, 9:08 AM · Plasma
ervin requested changes to D27934: KCM/Kwinoptions: Port focus tab to KConfigXT.

Not 100% about some of the comments, so let me know how this goes.

Mon, Mar 16, 9:06 AM · KWin
ervin accepted D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT.
Mon, Mar 16, 8:44 AM · KWin
ervin requested changes to D27682: Port kwinrules kcm to kconfigxt.

Minor things now (the one about the enum can be ignored of course).

Mon, Mar 16, 8:39 AM · KWin

Fri, Mar 13

ervin added a comment to D27540: KCModule: Indicate when a setting has been changed from the default or previous value.

And now you got a screenshot as well. Waiting for further feedback now.

Fri, Mar 13, 8:51 AM · Frameworks

Fri, Mar 6

ervin accepted D27463: KconfigXT: Add a value attribute to Enum field choices.
Fri, Mar 6, 10:25 AM · Frameworks
ervin accepted D27463: KconfigXT: Add a value attribute to Enum field choices.

LGTM, please fix the typo in the docs before pushing though

Fri, Mar 6, 10:22 AM · Frameworks
ervin accepted D27155: libnotificationmanager : add app-specific kconfig settings.
Fri, Mar 6, 10:18 AM · Plasma
ervin accepted D27133: kconfig_compiler : generate kconfig settings with subgroup.
Fri, Mar 6, 10:18 AM · Frameworks

Thu, Mar 5

ervin added a comment to D27840: Introduce SettingState* elements to ease KCM writing.

This patch doesn't apply on top of KDeclarative for me:

    This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (a1282da765c1b909d03d6c94eb77fd99e4374d74)
    [Y/n] y

Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.h...
Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp...
Checking patch src/qmlcontrols/kcmcontrols/qml/qmldir...
Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml...
Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml...
Checking patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp...
Checking patch src/qmlcontrols/kcmcontrols/CMakeLists.txt...
error: while searching for:

set(kcmcontrols_SRCS
    kcmcontrolsplugin.cpp
)

add_library(kcmcontrolsplugin SHARED ${kcmcontrols_SRCS})

error: patch failed: src/qmlcontrols/kcmcontrols/CMakeLists.txt:2
Hunk #2 succeeded at 12 (offset -1 lines).
Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.h cleanly.
Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/qmldir cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml cleanly.
Applied patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp cleanly.
Applying patch src/qmlcontrols/kcmcontrols/CMakeLists.txt with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.

 Patch Failed!
Thu, Mar 5, 5:22 PM · Frameworks
ervin requested changes to D27682: Port kwinrules kcm to kconfigxt.
Thu, Mar 5, 5:16 PM · KWin
ervin requested changes to D27862: [WIP] KCM KWinTouchScreen port to KConfigXT.

It's only a first step right? We'll move toward addConfig in a further step? Wondering what the plan is there.

Thu, Mar 5, 4:04 PM · KWin
ervin added a comment to D27811: [KConfigGui] Check font weight when clearing styleName property.

This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss.

Well this one is the tip of the ice berg, the berg itself was a2774ff5b41987c3919a9e :)

Thu, Mar 5, 3:52 PM · Frameworks
ervin requested changes to D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT.
Thu, Mar 5, 3:51 PM · KWin
ervin requested changes to D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem.
In D27833#622353, @apol wrote:

What's the use-case?

Thu, Mar 5, 3:45 PM · Frameworks
ervin added a reviewer for D27830: [Fonts KCM] Make the font selection dialog highlight the correct style: bport.
Thu, Mar 5, 3:31 PM · Plasma
ervin added a comment to D27811: [KConfigGui] Check font weight when clearing styleName property.

This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss.

Thu, Mar 5, 3:24 PM · Frameworks
ervin added a reviewer for D27811: [KConfigGui] Check font weight when clearing styleName property: bport.
Thu, Mar 5, 3:19 PM · Frameworks
ervin requested changes to D27463: KconfigXT: Add a value attribute to Enum field choices.
Thu, Mar 5, 3:13 PM · Frameworks
ervin accepted D27155: libnotificationmanager : add app-specific kconfig settings.

Although might become "parentGroupName" depending on what you do about my comments on the review introducing sub-group handling.

Thu, Mar 5, 3:01 PM · Plasma
ervin requested changes to D27133: kconfig_compiler : generate kconfig settings with subgroup.
Thu, Mar 5, 2:59 PM · Frameworks
ervin added a comment to D27784: KCM KWinTabBox manage KCModule states.

Most of it is really nitpicking at that point, I was about to hit accept and let you decide if you wanted to deal with them or not. That being said, it turns out there are two comments around unmanagedStateChange() which give me a bit the creeps (that's why I don't hit accept, not sure it's worth rejecting though, your call in the end).

Thu, Mar 5, 2:47 PM · KWin
ervin added inline comments to D27463: KconfigXT: Add a value attribute to Enum field choices.
Thu, Mar 5, 10:22 AM · Frameworks
ervin requested changes to D27463: KconfigXT: Add a value attribute to Enum field choices.
Thu, Mar 5, 8:54 AM · Frameworks

Wed, Mar 4

ervin added a dependency for D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding: D27840: Introduce SettingState* elements to ease KCM writing.
Wed, Mar 4, 4:45 PM · Plasma
ervin added a dependent revision for D27840: Introduce SettingState* elements to ease KCM writing: D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding.
Wed, Mar 4, 4:45 PM · Frameworks
ervin added reviewers for D27840: Introduce SettingState* elements to ease KCM writing: Frameworks, Plasma.
Wed, Mar 4, 4:45 PM · Frameworks
ervin added reviewers for D27839: Properly name the content of the kcmcontrols project: Frameworks, Plasma.
Wed, Mar 4, 4:44 PM · Frameworks
ervin requested review of D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding.
Wed, Mar 4, 4:43 PM · Plasma
ervin requested review of D27840: Introduce SettingState* elements to ease KCM writing.
Wed, Mar 4, 4:42 PM · Frameworks
ervin requested review of D27839: Properly name the content of the kcmcontrols project.
Wed, Mar 4, 4:42 PM · Frameworks

Sat, Feb 29

ervin moved T11570: Define SPDX License identifier exception for KDE e.V. Exception from Done to Announced on the KF6 board.
Sat, Feb 29, 3:39 PM · KF6
ervin moved T11543: Port Konqueror away from KHTML from Done to Announced on the KF6 board.
Sat, Feb 29, 3:39 PM · Konqueror, KF6
ervin moved T12287: KService: deprecate KServiceTypeProfile, unused from Done to Announced on the KF6 board.
Sat, Feb 29, 3:39 PM · KF6
ervin moved T12182: KService: deprecate KServiceTypeProfile from Done to Announced on the KF6 board.
Sat, Feb 29, 3:39 PM · KF6
ervin moved T12204: Drop KXmlGui::KGesture* from Done to Announced on the KF6 board.
Sat, Feb 29, 3:39 PM · KF6
ervin moved T11919: Port KDED modules from .desktop files to JSON metadata from Done to Announced on the KF6 board.
Sat, Feb 29, 3:38 PM · KF6
ervin moved T12237: Port KConfigGui from QtXml SAX parser to QXmlStreamReader from Done to Announced on the KF6 board.
Sat, Feb 29, 3:38 PM · KF6
ervin moved T12175: KService: write ApplicationTrader from Done to Announced on the KF6 board.
Sat, Feb 29, 3:38 PM · KF6

Fri, Feb 28

ervin accepted D27717: fix min/max entries with dpointer.
Fri, Feb 28, 9:00 AM · Frameworks

Feb 27 2020

ervin added inline comments to D27682: Port kwinrules kcm to kconfigxt.
Feb 27 2020, 1:04 PM · KWin
ervin added inline comments to D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Feb 27 2020, 1:01 PM · Plasma
ervin added inline comments to D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Feb 27 2020, 11:13 AM · Plasma
ervin requested changes to D27682: Port kwinrules kcm to kconfigxt.

This needs some design changes I think. Also please update copyright headers in the files you touch and add them in the files you add.

Feb 27 2020, 10:59 AM · KWin
ervin requested changes to D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Feb 27 2020, 9:00 AM · Plasma
ervin requested changes to D27502: Create ConfigView an unmanaged ConfigWidget.
Feb 27 2020, 8:44 AM · Frameworks

Feb 26 2020

ervin accepted D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT.
Feb 26 2020, 10:16 AM · KWin
ervin requested changes to D27463: KconfigXT: Add a value attribute to Enum field choices.
Feb 26 2020, 10:05 AM · Frameworks
ervin added inline comments to D27463: KconfigXT: Add a value attribute to Enum field choices.
Feb 26 2020, 9:47 AM · Frameworks

Feb 25 2020

ervin added inline comments to D26934: KCM/Autostart Add a model to separate logic from UI.
Feb 25 2020, 5:57 PM · Plasma
ervin requested changes to D27503: [KCM Spellchecking] port to KPropertySkeletonItem.
Feb 25 2020, 5:08 PM · Plasma
ervin requested changes to D27502: Create ConfigView an unmanaged ConfigWidget.
Feb 25 2020, 4:54 PM · Frameworks