ervin (Kevin Ottens)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2015, 10:18 AM (175 w, 5 d)
Availability
Available

Recent Activity

Mon, Jun 11

ervin created T8995: Package Maliit and friends.
Mon, Jun 11, 3:32 PM · Neon
ervin created T8994: Package Nextcloud sync client.
Mon, Jun 11, 3:31 PM · Neon

May 4 2018

ervin committed R4:b4e38ecf0491: Add missing actions from the Kontact part (authored by ervin).
Add missing actions from the Kontact part
May 4 2018, 10:01 PM
ervin closed D12697: Add missing actions from the Kontact part.
May 4 2018, 10:01 PM
ervin requested review of D12697: Add missing actions from the Kontact part.
May 4 2018, 12:10 PM

Apr 30 2018

ervin requested review of D12615: Also port EditorView to QDate only.
Apr 30 2018, 3:42 PM
ervin accepted D9095: Fix regression where today's tasks don't appear between 00:00 and 01:00..

Confused that you didn't update this patch but introduced a new one, but fair enough the whole series looks good together.

Apr 30 2018, 9:06 AM
ervin accepted D12607: Finish removing the compat code for old kcalcore versions..
Apr 30 2018, 9:04 AM
ervin requested changes to D9095: Fix regression where today's tasks don't appear between 00:00 and 01:00..

Just a couple of minor issues

Apr 30 2018, 6:25 AM
ervin accepted D12597: Remove now unused DateTime::currentDateTime().
Apr 30 2018, 6:14 AM

Apr 29 2018

ervin accepted D12581: Add Utils::DateTime::currentDate().

OK, I see. I'd rather have smaller commits, so let's go for the two variables. It's supposed to be transitional anyway.

Apr 29 2018, 12:21 PM
ervin added a comment to D12581: Add Utils::DateTime::currentDate().

Shouldn't we reuse the ZANSHIN_OVERRIDE_DATETIME environment variable here? Just to avoid situations where currentDate() and currentDateTime() are out of sync because the two variables aren't properly set?

Apr 29 2018, 10:56 AM
ervin accepted D12580: Add override everywhere where applicable..
Apr 29 2018, 10:53 AM
ervin accepted D12579: Fix compiler warning about unused bool.
Apr 29 2018, 10:53 AM

Apr 26 2018

ervin accepted D11264: don't set a zanshin screenshot for renku.
Apr 26 2018, 9:11 AM

Apr 24 2018

ervin committed R255:602a686e1335: Aggressively look for cover files (authored by ervin).
Aggressively look for cover files
Apr 24 2018, 6:24 AM
ervin closed D12472: Aggressively look for cover files.
Apr 24 2018, 6:24 AM
ervin committed R255:18768b8bd2a0: Also sort artists by name (authored by ervin).
Also sort artists by name
Apr 24 2018, 6:24 AM
ervin closed D12471: Also sort artists by name.
Apr 24 2018, 6:24 AM
ervin committed R255:b02848a08569: Don't take case into account when sorting albums (authored by ervin).
Don't take case into account when sorting albums
Apr 24 2018, 6:24 AM
ervin closed D12470: Don't take case into account when sorting albums.
Apr 24 2018, 6:24 AM
ervin added a comment to D12472: Aggressively look for cover files.

The still failing cases I found seem to all revolve around "spaces not in the directory name but in the cover file name", currently my approach can't deal with that correctly. Also in cases of more than one match we don't necessarily pick the best one (yes... in some cases I have more than one match now because it's more aggressive). That's why in the end we probably want to list all jpg and png, score them and sort them based on the score to pick the best one. I'll see if I get to it at some point but for now I went for the simple fixes which remove my biggest pain points. :-)

Apr 24 2018, 6:23 AM

Apr 23 2018

ervin requested review of D12472: Aggressively look for cover files.
Apr 23 2018, 3:48 PM
ervin requested review of D12471: Also sort artists by name.
Apr 23 2018, 3:48 PM
ervin requested review of D12470: Don't take case into account when sorting albums.
Apr 23 2018, 3:48 PM

Apr 21 2018

ervin updated subscribers of T8484: Making settting up a development environment quick and easy.

Good point, I was thinking @gladhorn in fact. Sorry. :-)

Apr 21 2018, 8:06 PM
ervin added a comment to T6857: Falkon Incubation.

Well, that wiki page seems out of date: https://community.kde.org/Incubator/Projects/Falkon

Apr 21 2018, 3:12 PM · Falkon
ervin updated subscribers of T8484: Making settting up a development environment quick and easy.

I'd like to point out again the talk we delivered at Akademy 2017 with @dfaure (it is referred to in the parent task of that one). For most cases we should strive at not forcing people to use a VM or a container. Especially if we want to make it easier for people on non-Linux platforms to contribute. The highest potential solution is the one using conan but since @fredrik prototype no activity has happened in that direction.

Apr 21 2018, 3:05 PM
ervin accepted D12403: Fix IMAP resource stuck if connection lost during Login..
Apr 21 2018, 2:56 PM · KDE PIM
ervin accepted D12402: IMAP fake server: provide more output in case the scenario is incomplete..

Looks good as well

Apr 21 2018, 2:55 PM · KDE PIM
ervin accepted D12400: KIMAP fake server: add support for disconnect before response.

Looks good to me

Apr 21 2018, 2:54 PM · KDE PIM

Mar 9 2018

ervin accepted D11178: fix appdata to use new (working) screenshot location.
Mar 9 2018, 4:11 PM

Mar 6 2018

ervin committed R4:768ab13cf4cb: Fix linking of the cuke-steps (authored by ervin).
Fix linking of the cuke-steps
Mar 6 2018, 1:14 PM

Mar 4 2018

ervin removed a member for Falkon: ervin.
Mar 4 2018, 12:42 PM

Jan 15 2018

ervin accepted D9328: Add support for cancellable image rendering and text extraction.
Jan 15 2018, 8:50 AM · Okular

Jan 3 2018

ervin committed R977:bb968fb06e07: Announce the 0.5.0 release (authored by ervin).
Announce the 0.5.0 release
Jan 3 2018, 10:41 PM
ervin committed R977:20eb4ae18d79: Point to download.kde.org now (authored by ervin).
Point to download.kde.org now
Jan 3 2018, 8:19 PM
ervin committed R977:c8d9a7d68a2f: Update the distro specific information (authored by ervin).
Update the distro specific information
Jan 3 2018, 8:19 PM
ervin committed R977:20f54d078616: We do use bugzilla now (authored by ervin).
We do use bugzilla now
Jan 3 2018, 8:19 PM
ervin committed R4:2be97824943e: Releasing Zanshin 0.5.0 (authored by ervin).
Releasing Zanshin 0.5.0
Jan 3 2018, 11:56 AM
ervin committed R4:343e08027fb4: We don't have docs, don't pretend otherwise (authored by ervin).
We don't have docs, don't pretend otherwise
Jan 3 2018, 9:27 AM
ervin closed D9630: We don't have docs, don't pretend otherwise.
Jan 3 2018, 9:27 AM
ervin committed R4:09a7e2dad9b5: Don't hardcode the settings dialog to todos (authored by ervin).
Don't hardcode the settings dialog to todos
Jan 3 2018, 9:27 AM
ervin closed D9629: Don't hardcode the settings dialog to todos.
Jan 3 2018, 9:27 AM
ervin committed R4:8484a0773362: Store the "Show future items" state in settings (authored by ervin).
Store the "Show future items" state in settings
Jan 3 2018, 7:07 AM
ervin closed D9607: Store the "Show future items" state in settings.
Jan 3 2018, 7:07 AM
ervin committed R4:b761a3579946: Add "Show future items" action to the PageView (authored by ervin).
Add "Show future items" action to the PageView
Jan 3 2018, 7:07 AM
ervin closed D9606: Add "Show future items" action to the PageView.
Jan 3 2018, 7:07 AM
ervin committed R4:2078d9208b34: Remove "Show future items" from the filter widget (authored by ervin).
Remove "Show future items" from the filter widget
Jan 3 2018, 7:06 AM
ervin committed R4:21decc5b6da4: Turn the future tasks slot into a public setter (authored by ervin).
Turn the future tasks slot into a public setter
Jan 3 2018, 7:06 AM
ervin closed D9604: Remove "Show future items" from the filter widget.
Jan 3 2018, 7:06 AM
ervin closed D9605: Turn the future tasks slot into a public setter.
Jan 3 2018, 7:06 AM
ervin committed R4:1640176630e9: Don't ignore the return value of qWaitForWindowShown (authored by ervin).
Don't ignore the return value of qWaitForWindowShown
Jan 3 2018, 7:06 AM
ervin closed D9603: Don't ignore the return value of qWaitForWindowShown.
Jan 3 2018, 7:06 AM

Dec 26 2017

ervin added a comment to D9095: Fix regression where today's tasks don't appear between 00:00 and 01:00..

Oh right, would better use Utils::DateTime::currentDateTime() or similar. This one is overridable through the env var ZANSHIN_OVERRIDE_DATETIME.

Dec 26 2017, 11:07 AM
ervin accepted D9355: Workday: fix LLCONFLICT when deparenting a task..
Dec 26 2017, 10:05 AM
ervin accepted D9343: Update README with instructions for running feature tests.
Dec 26 2017, 10:04 AM
ervin accepted D9322: Add feature tests for dnd within the workday..

It likely doesn't hit your bug since we don't use real akonadi for those tests anymore but a stub.

Dec 26 2017, 10:04 AM
ervin added a comment to D9095: Fix regression where today's tasks don't appear between 00:00 and 01:00..

Surely asks for a unit test, isn't it? Otherwise totally agree with the fix.

Dec 26 2017, 10:02 AM

Dec 20 2017

ervin added a comment to D9441: Fix PlacesItemModel loading with hidden devices.

Looks good to me. Waiting for the Dolphin people to look at it.

Dec 20 2017, 7:47 PM
ervin added a comment to D9441: Fix PlacesItemModel loading with hidden devices.

I wonder if the test wouldn't be better inside addItemFromSourceModel? Other than that, looks good to me.

Dec 20 2017, 6:42 PM

Dec 19 2017

ervin requested changes to D9328: Add support for cancellable image rendering and text extraction.

Couple of smaller issues. Otherwise I didn't spot anything which looked very wrong to me, admittedly I don't know much about okular though.

Dec 19 2017, 1:35 PM · Okular
ervin added a comment to D9347: Ignore baloo urls created from new KIO model.

Looks fine to me as well.

Dec 19 2017, 1:22 PM
ervin added a comment to D9333: Make sure that old URLs do not appear duplicated in places model.

Looks fine to me, but I'm not a Dolphin expert so I'll let someone else more knowledgeable accept it.

Dec 19 2017, 1:21 PM
ervin added a comment to D9325: Use QUrl in the ScreenMapper API.

@mwolff and @broulik Could one of you answer @amantia concerns regarding the motivations of that patch? If you agree with him maybe we don't want that patch at all...

Dec 19 2017, 12:48 PM · Plasma

Nov 28 2017

ervin accepted D9015: Refactoring the hidding/showing animation use within KFilePlacesView.
Nov 28 2017, 11:37 AM · Frameworks
ervin requested changes to D9015: Refactoring the hidding/showing animation use within KFilePlacesView.
Nov 28 2017, 9:40 AM · Frameworks
ervin accepted D8450: User can now hide an entire places group from KFilePlacesView.
Nov 28 2017, 9:35 AM · Frameworks
ervin accepted D8367: Hidding place groups implementation in KFilePlacesModel.
Nov 28 2017, 9:34 AM · Frameworks

Nov 27 2017

ervin committed R4:5d6814b81617: Get cucumber-cpp to build with boost 1.65 (authored by ervin).
Get cucumber-cpp to build with boost 1.65
Nov 27 2017, 9:59 AM
ervin added inline comments to D8450: User can now hide an entire places group from KFilePlacesView.
Nov 27 2017, 7:48 AM · Frameworks
ervin added inline comments to D8367: Hidding place groups implementation in KFilePlacesModel.
Nov 27 2017, 7:46 AM · Frameworks
ervin accepted D8630: Created unit test for PlacesItemModel.

lgtm too

Nov 27 2017, 7:44 AM
ervin accepted D8817: Port zanshin to QDateTime, as used by the Applications/17.12 kcalcore API..
Nov 27 2017, 7:16 AM

Nov 24 2017

ervin requested changes to D8450: User can now hide an entire places group from KFilePlacesView.
Nov 24 2017, 11:30 AM · Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.

A small nitpick otherwise lgtm.

Nov 24 2017, 11:16 AM · Frameworks
ervin accepted D8332: Added baloo urls into places model.
Nov 24 2017, 11:10 AM · Frameworks

Nov 2 2017

ervin added a comment to D8567: Emit signals when a screen is added or removed.

Looks good to me too but want to give the plasma team the last say.

Nov 2 2017, 12:08 PM · Plasma
ervin accepted D8566: Add API to retrieve the screen id for a screen name.
Nov 2 2017, 12:06 PM · Plasma, Frameworks
ervin accepted D8450: User can now hide an entire places group from KFilePlacesView.
Nov 2 2017, 10:46 AM · Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.

Couple more changes needed.

Nov 2 2017, 10:42 AM · Frameworks
ervin accepted D8366: Factoring out lists of url data within KFilePlacesModelTest.
Nov 2 2017, 10:35 AM · Frameworks

Oct 31 2017

ervin added a comment to D8567: Emit signals when a screen is added or removed.

Looks good to me, but I'm giving time for the Plasma team to see it.

Oct 31 2017, 2:10 PM · Plasma
ervin requested changes to D8566: Add API to retrieve the screen id for a screen name.
Oct 31 2017, 2:09 PM · Plasma, Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.
Oct 31 2017, 2:08 PM · Frameworks
ervin requested changes to D8450: User can now hide an entire places group from KFilePlacesView.

At least the unit test would be welcome, I let you decide on the other comment.

Oct 31 2017, 12:21 PM · Frameworks
ervin accepted D8348: Add a section for removable devices.
Oct 31 2017, 11:47 AM · Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.
Oct 31 2017, 11:46 AM · Frameworks
ervin requested changes to D8348: Add a section for removable devices.

Found a small one after all.

Oct 31 2017, 11:32 AM · Frameworks
ervin requested changes to D8366: Factoring out lists of url data within KFilePlacesModelTest.
Oct 31 2017, 11:27 AM · Frameworks
ervin accepted D8348: Add a section for removable devices.
Oct 31 2017, 11:25 AM · Frameworks
ervin requested changes to D8332: Added baloo urls into places model.

All the fiddling with URLs makes me wonder if that wouldn't be better done on the KIO implementations side... but that's out of scope for that patch I think.

Oct 31 2017, 10:40 AM · Frameworks
ervin added a comment to D8243: Implement support for categories on KfilesPlacesView.

Great work BTW, this looks really nice now.

Oct 31 2017, 9:00 AM · Frameworks
ervin accepted D8243: Implement support for categories on KfilesPlacesView.
Oct 31 2017, 9:00 AM · Frameworks
ervin added a comment to T7116: Streamlined onboarding of new contributors.

Ah my apologies, I thought the goal here was to capture the whole spectrum of contributors. Of course if the goal was to focus on non-coding contributors then this is fine.

Oct 31 2017, 6:58 AM · Goal settings 2017

Oct 30 2017

ervin added a comment to D8243: Implement support for categories on KfilesPlacesView.

Looks fine code wise now, just a couple more tweaks to make those sections look closer to what Dolphin got.

Oct 30 2017, 2:51 PM · Frameworks
ervin added a comment to T7116: Streamlined onboarding of new contributors.

I'll sound like a broken record but: if we don't solve the "how difficult it is to build something and patch it" *first* all the nice things mentioned here with mentoring etc. (which require people we don't have BTW) won't get us far. People will try, fail immediately because it's too hard and leave again.
Seen that enough with my students the past few years.

Oct 30 2017, 6:53 AM · Goal settings 2017

Oct 20 2017

ervin added a comment to T7116: Streamlined onboarding of new contributors.

Yes, it'd be nice to see them finally merging, we're late in the discussion phase now. Also as a bonus, it would be awesome if the consolidated proposal could contain aspects coming from the talk we held with David Faure this year about the developer story. That'd make for a very strong one then, and would probably add at least David's name in the list of people willing to put work into it. ;-)

Oct 20 2017, 6:18 AM · Goal settings 2017

Oct 18 2017

ervin committed R223:43199ae48116: Mention the share menu in the documentation (authored by ervin).
Mention the share menu in the documentation
Oct 18 2017, 2:55 PM
ervin closed D8263: Mention the share menu in the documentation.
Oct 18 2017, 2:55 PM · Okular