ervin (Kevin Ottens)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2015, 10:18 AM (220 w, 1 d)
Availability
Available

Recent Activity

Sun, Apr 7

ervin closed D20356: Trivial fixes.
Sun, Apr 7, 6:40 PM · KDE PIM
ervin committed R172:b1565118d342: Trivial fixes (authored by ervin).
Trivial fixes
Sun, Apr 7, 6:40 PM
ervin requested review of D20356: Trivial fixes.
Sun, Apr 7, 2:31 PM · KDE PIM

Mar 25 2019

ervin accepted D19957: New page: all tasks.
Mar 25 2019, 9:55 AM
ervin added a comment to D20028: IMAPResource: Defer task if we get disconnected during login.

Looks fine to me.

Mar 25 2019, 8:13 AM · KDE PIM
ervin added a comment to D19957: New page: all tasks.

I agree moving the promote implementation in the base class could make sense now. Rather in a separate commit though.

Mar 25 2019, 8:12 AM

Mar 22 2019

ervin added a comment to D19957: New page: all tasks.

I'm not sure the promotion a problem in practice in this view. Yes, the promoted task would disappear, but you'd have a project appearing instead and its children would still be there I guess. It's what I'd expect.

Mar 22 2019, 10:06 AM

Mar 19 2019

ervin accepted D19871: Fix failing unittests for yearly recurrence.
Mar 19 2019, 9:00 AM
ervin accepted D19868: Workday: don't show project name for child tasks.
Mar 19 2019, 8:59 AM
ervin accepted D19819: Fix findTopLevel() being the same as findInboxTopLevel().
Mar 19 2019, 8:58 AM

Mar 18 2019

ervin requested changes to D19819: Fix findTopLevel() being the same as findInboxTopLevel().

Makes me wonder if we shouldn't also fix findInboxTopLevel() indeed your improved findTopLevel() makes a better job at verifying the related-to field doesn't contain a broken reference to a parent... which the inbox doesn't (and should). Would be a separate patch I guess.

Mar 18 2019, 10:32 AM
ervin accepted D19810: Add support for yearly recurrence..

Hehe, clearly I don't have the use, hence the oversight. Thanks!

Mar 18 2019, 10:23 AM
ervin accepted D19809: ItemDelegate: don't replace the user's text upon dataChanged().

It almost asks for unit testing the behavior... but that looks really gruesome to test, so except if you got an idea let's get it merged.

Mar 18 2019, 10:20 AM

Mar 3 2019

ervin accepted D19481: Rename NewProjectDialog to NameAndDataSourceDialog.
Mar 3 2019, 9:55 AM

Mar 2 2019

ervin accepted D19470: Remove now unused Widgets::MessageBox::askTextInput.
Mar 2 2019, 3:30 PM
ervin accepted D19239: migrator: make --forceMigratingTags do the whole migration again.
Mar 2 2019, 3:30 PM
ervin accepted D19238: Fix interoperability issue with kolab server which uppercases all properties.
Mar 2 2019, 3:29 PM
ervin accepted D19217: Fix uids for contexts created by the migrator.
Mar 2 2019, 3:29 PM
ervin accepted D19211: Re-enable calling the migrator from zanshin..
Mar 2 2019, 3:28 PM
ervin accepted D19195: Add a migrator for converting tags to context items.
Mar 2 2019, 3:28 PM
ervin accepted D19147: Fix context not disappearing from the treeview upon removal..
Mar 2 2019, 3:28 PM
ervin accepted D19145: Remove all remaining traces of Akonadi::Tag.
Mar 2 2019, 3:28 PM
ervin accepted D19144: Remove AkonadiCache's handling of tags, not needed anymore.
Mar 2 2019, 3:27 PM
ervin accepted D19143: Remove fetchTags() and fetchTagItems() from the storage implementations.
Mar 2 2019, 3:27 PM
ervin accepted D19141: Store contexts as todos, not tags, step 5: much porting.
Mar 2 2019, 3:27 PM
ervin accepted D19140: Store contexts as todos, not tags, step 4: more Serializer methods.
Mar 2 2019, 3:26 PM
ervin accepted D19146: Store contexts as todos, not tags, step 7: fixing feature tests.

Thanks, I like having dirty and broken data at places.

Mar 2 2019, 3:26 PM
ervin accepted D19142: Store contexts as todos, not tags, step 6: AkonadiFakeData.
Mar 2 2019, 3:25 PM
ervin accepted D19139: Store contexts as todos, not tags, step 3: add GenTodo().asContext().
Mar 2 2019, 3:24 PM
ervin added a comment to D19138: Store contexts as todos, not tags, step 2: port ContextRepository.

NameAndDataSourceDialog it is then.

Mar 2 2019, 3:23 PM
ervin accepted D19137: Store contexts as todos, not tags, step 1: extend AkonadiSerializer.
Mar 2 2019, 10:36 AM
ervin accepted D19250: Clazy fixes.
Mar 2 2019, 10:35 AM
ervin accepted D19239: migrator: make --forceMigratingTags do the whole migration again.
Mar 2 2019, 10:33 AM
ervin accepted D19238: Fix interoperability issue with kolab server which uppercases all properties.
Mar 2 2019, 10:33 AM
ervin accepted D19217: Fix uids for contexts created by the migrator.
Mar 2 2019, 10:31 AM
ervin accepted D19211: Re-enable calling the migrator from zanshin..
Mar 2 2019, 10:30 AM
ervin accepted D19195: Add a migrator for converting tags to context items.
Mar 2 2019, 10:30 AM
ervin accepted D19147: Fix context not disappearing from the treeview upon removal..
Mar 2 2019, 10:28 AM
ervin requested changes to D19146: Store contexts as todos, not tags, step 7: fixing feature tests.

Admittedly I'm confused by some of the changes in the XML

Mar 2 2019, 10:27 AM
ervin accepted D19145: Remove all remaining traces of Akonadi::Tag.
Mar 2 2019, 10:15 AM
ervin accepted D19144: Remove AkonadiCache's handling of tags, not needed anymore.
Mar 2 2019, 10:13 AM
ervin accepted D19143: Remove fetchTags() and fetchTagItems() from the storage implementations.
Mar 2 2019, 10:13 AM
ervin requested changes to D19142: Store contexts as todos, not tags, step 6: AkonadiFakeData.
Mar 2 2019, 10:11 AM
ervin accepted D19141: Store contexts as todos, not tags, step 5: much porting.
Mar 2 2019, 10:05 AM
ervin accepted D19140: Store contexts as todos, not tags, step 4: more Serializer methods.
Mar 2 2019, 10:02 AM
ervin added a comment to D19139: Store contexts as todos, not tags, step 3: add GenTodo().asContext().

I'd also expect a way to express that a todo has a bunch of contexts? Like we have "withParentUid". You didn't feel that need yet? It's kind of surprising me.

Mar 2 2019, 10:00 AM
ervin accepted D19138: Store contexts as todos, not tags, step 2: port ContextRepository.

Couples of comments, but they are for different commits, they don't need to be done in this commit.

Mar 2 2019, 9:53 AM
ervin requested changes to D19137: Store contexts as todos, not tags, step 1: extend AkonadiSerializer.
Mar 2 2019, 9:46 AM

Feb 3 2019

ervin accepted D18691: Fix AkonadiStorageTestBase::shouldNotifyItemTagRemoved.
Feb 3 2019, 6:37 AM

Feb 1 2019

ervin accepted D18634: Fix AkonadiStorageTest::shouldNotifyTagAdded() flakiness..
Feb 1 2019, 7:07 AM

Jan 29 2019

ervin accepted D18543: Remove test about emails collection, not fetched anymore.
Jan 29 2019, 8:22 PM
ervin accepted D18541: Use task instead of note for AkonadiStorageTestBase::shouldNotifyItemRemoved.

Slightly torn about that one since we stop checking that we won't die on other data types... But I guess that's a necessary evil for now.

Jan 29 2019, 8:22 PM
ervin accepted D18539: Remove now unused cucumber.
Jan 29 2019, 8:20 PM
ervin accepted D18538: Remove unused akonaditest files..
Jan 29 2019, 8:20 PM
ervin accepted D18537: Fix contextdraganddropfeature and contexttaskremovefeature.
Jan 29 2019, 8:17 PM
ervin accepted D18535: Change syntax for features tests, to make F2 work in QtCreator.
Jan 29 2019, 8:16 PM
ervin accepted D18534: Fix contexttaskaddfeature: typo in page name.
Jan 29 2019, 8:15 PM
ervin accepted D18423: Fix workdaystartdateeditfeature and workdayduedateeditfeature..
Jan 29 2019, 8:15 PM
ervin accepted D18422: Mark deparenting-in-workday feature test as broken, with the reason why..
Jan 29 2019, 8:15 PM
ervin accepted D18234: Port the two data-driven tests from cucumber to qtestlib.
Jan 29 2019, 8:14 PM
ervin accepted D18220: Port 30 out of the remaining 32 feature tests.
Jan 29 2019, 8:13 PM

Jan 14 2019

ervin committed R4:f8ba1a34f337: First steps to move away from cucumber (authored by ervin).
First steps to move away from cucumber
Jan 14 2019, 1:01 PM
ervin closed D18209: First steps to move away from cucumber.
Jan 14 2019, 1:01 PM

Jan 12 2019

ervin requested review of D18209: First steps to move away from cucumber.
Jan 12 2019, 1:47 PM

Jan 9 2019

ervin committed R4:761c860fde89: Mark the add/remove methods as slots (authored by ervin).
Mark the add/remove methods as slots
Jan 9 2019, 12:37 PM
ervin closed D18120: Mark the add/remove methods as slots.
Jan 9 2019, 12:37 PM
ervin requested review of D18120: Mark the add/remove methods as slots.
Jan 9 2019, 12:36 PM
ervin committed R4:fe6b516dd7ee: Don't look for packages we don't really need (authored by ervin).
Don't look for packages we don't really need
Jan 9 2019, 8:18 AM
ervin closed D18113: Don't look for packages we don't really need.
Jan 9 2019, 8:18 AM
ervin committed R4:bc018d917b9b: Get rid of all the scripting code (authored by ervin).
Get rid of all the scripting code
Jan 9 2019, 8:18 AM
ervin closed D18112: Get rid of all the scripting code.
Jan 9 2019, 8:18 AM
ervin committed R4:e577049c482b: Port away from obsolete qWaitForWindowShown (authored by ervin).
Port away from obsolete qWaitForWindowShown
Jan 9 2019, 8:18 AM
ervin committed R4:add404b720bc: Remove unneeded include (authored by ervin).
Remove unneeded include
Jan 9 2019, 8:18 AM
ervin closed D18111: Port away from obsolete qWaitForWindowShown.
Jan 9 2019, 8:18 AM
ervin committed R4:11873828b62a: Add missing include (authored by ervin).
Add missing include
Jan 9 2019, 8:18 AM
ervin closed D18109: Add missing include.
Jan 9 2019, 8:18 AM
ervin committed R4:2f47c6474bef: Port away from obsolete qVariantCanConvert (authored by ervin).
Port away from obsolete qVariantCanConvert
Jan 9 2019, 8:18 AM
ervin closed D18110: Remove unneeded include.
Jan 9 2019, 8:18 AM
ervin committed R4:d587f6fd2017: Port away from obsolete setRoleNames (authored by ervin).
Port away from obsolete setRoleNames
Jan 9 2019, 8:18 AM
ervin closed D18108: Port away from obsolete qVariantCanConvert.
Jan 9 2019, 8:18 AM
ervin committed R4:8fea6d39a957: Remove dependency to AkonadiNotes and KMime (authored by ervin).
Remove dependency to AkonadiNotes and KMime
Jan 9 2019, 8:18 AM
ervin closed D18107: Port away from obsolete setRoleNames.
Jan 9 2019, 8:18 AM
ervin closed D18106: Remove dependency to AkonadiNotes and KMime.
Jan 9 2019, 8:18 AM
ervin committed R4:a8b4591e1fe1: Get rid of the Notes content type (authored by ervin).
Get rid of the Notes content type
Jan 9 2019, 8:18 AM
ervin closed D18105: Get rid of the Notes content type.
Jan 9 2019, 8:18 AM
ervin committed R4:f926deff41c7: Forgot to port that test, let's fix it (authored by ervin).
Forgot to port that test, let's fix it
Jan 9 2019, 8:18 AM
ervin closed D18103: Forgot to port that test, let's fix it.
Jan 9 2019, 8:18 AM
ervin closed D18102: Properly handle null running task models.
Jan 9 2019, 8:18 AM
ervin committed R4:710493bf3d9f: Properly handle null running task models (authored by ervin).
Properly handle null running task models
Jan 9 2019, 8:18 AM
ervin updated the diff for D18106: Remove dependency to AkonadiNotes and KMime.

Addresses David's comment.

Jan 9 2019, 6:34 AM
ervin added a comment to D18112: Get rid of all the scripting code.

Yes. A student project which never got completed. The same team did the workday view though. ;-)

Jan 9 2019, 6:26 AM

Jan 8 2019

ervin requested review of D18113: Don't look for packages we don't really need.
Jan 8 2019, 5:22 PM
ervin requested review of D18112: Get rid of all the scripting code.
Jan 8 2019, 5:22 PM
ervin requested review of D18111: Port away from obsolete qWaitForWindowShown.
Jan 8 2019, 5:22 PM
ervin requested review of D18110: Remove unneeded include.
Jan 8 2019, 5:21 PM
ervin requested review of D18109: Add missing include.
Jan 8 2019, 5:21 PM
ervin requested review of D18108: Port away from obsolete qVariantCanConvert.
Jan 8 2019, 5:21 PM
ervin requested review of D18107: Port away from obsolete setRoleNames.
Jan 8 2019, 5:21 PM
ervin requested review of D18106: Remove dependency to AkonadiNotes and KMime.
Jan 8 2019, 4:27 PM
ervin requested review of D18105: Get rid of the Notes content type.
Jan 8 2019, 4:27 PM