ervin (Kevin Ottens)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2015, 10:18 AM (250 w, 1 d)
Availability
Available

Recent Activity

Yesterday

ervin added a comment to D23316: Port towards KConfig XT.

LGTM, I'd still aim for the .ui port as a second step though.

Thu, Nov 21, 11:30 AM · Spectacle

Tue, Nov 19

ervin added inline comments to D25149: Add a new template for KCMs.
Tue, Nov 19, 8:35 AM · Plasma, Frameworks

Mon, Nov 18

ervin added a comment to D23316: Port towards KConfig XT.

Looks good to me regarding the kconfig_compiler use (epsilon one key which would be better suited to an enum).
The next natural step would be to switch the dialog pages to ui files, that would remove some more code.

If we have to port it to anything, I'd prefer a QML-based UI rather than making new .ui files.

Mon, Nov 18, 5:05 PM · Spectacle
ervin requested changes to D24224: Start of the accessibility KCM.

A few changes still needed.

Mon, Nov 18, 7:50 AM · Plasma
ervin accepted D25290: KCM launchfeedback : port to KConfig XT.
Mon, Nov 18, 7:34 AM · Plasma
ervin added a comment to D23316: Port towards KConfig XT.

Looks good to me regarding the kconfig_compiler use (epsilon one key which would be better suited to an enum).
The next natural step would be to switch the dialog pages to ui files, that would remove some more code.

Mon, Nov 18, 7:31 AM · Spectacle

Fri, Nov 15

ervin requested review of D25322: Have the wallpaper combo managed by KConfigDialogManager.
Fri, Nov 15, 10:34 AM · Plasma
ervin requested review of D25321: Remove dead code.
Fri, Nov 15, 10:34 AM · Plasma
ervin added inline comments to D25290: KCM launchfeedback : port to KConfig XT.
Fri, Nov 15, 7:15 AM · Plasma
ervin accepted D25274: KCM LookAndFeel : port to KConfig XT.
Fri, Nov 15, 7:07 AM · Plasma
ervin accepted D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Fri, Nov 15, 7:06 AM · Plasma

Thu, Nov 14

ervin added inline comments to D25149: Add a new template for KCMs.
Thu, Nov 14, 9:13 AM · Plasma, Frameworks

Wed, Nov 13

ervin requested changes to D25149: Add a new template for KCMs.
Wed, Nov 13, 9:59 PM · Plasma, Frameworks
ervin requested review of D25287: Integrate the lnf and wallpaper settings with the KCM logic.
Wed, Nov 13, 2:48 PM · Plasma
ervin closed D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:42 PM · Frameworks
ervin committed R296:40b94af6f0f4: Allow to disable autosave behavior in ConfigPropertyMap (authored by ervin).
Allow to disable autosave behavior in ConfigPropertyMap
Wed, Nov 13, 2:42 PM
ervin requested review of D25286: Allow to disable autosave behavior in ConfigPropertyMap.
Wed, Nov 13, 2:39 PM · Frameworks
ervin committed R133:68bdeb8cd7d9: Move the shortcut management in the settings object (authored by ervin).
Move the shortcut management in the settings object
Wed, Nov 13, 2:37 PM
ervin closed D25212: Move the shortcut management in the settings object.
Wed, Nov 13, 2:37 PM · Plasma
ervin closed D25211: Add KPropertySkeletonItem.
Wed, Nov 13, 2:35 PM · Frameworks
ervin committed R237:d63955cfe547: Add KPropertySkeletonItem (authored by ervin).
Add KPropertySkeletonItem
Wed, Nov 13, 2:35 PM
ervin committed R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow inheriting its private class (authored by ervin).
Prepare KConfigSkeletonItem to allow inheriting its private class
Wed, Nov 13, 2:35 PM
ervin closed D25210: Prepare KConfigSkeletonItem to allow inheriting its private class.
Wed, Nov 13, 2:35 PM · Frameworks

Tue, Nov 12

ervin requested changes to D25274: KCM LookAndFeel : port to KConfig XT.

Just a recurring typo, otherwise LGTM

Tue, Nov 12, 3:53 PM · Plasma
ervin added a reviewer for D25274: KCM LookAndFeel : port to KConfig XT: davidedmundson.
Tue, Nov 12, 3:48 PM · Plasma
ervin added inline comments to D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Tue, Nov 12, 1:45 PM · Plasma
ervin added inline comments to D25212: Move the shortcut management in the settings object.
Tue, Nov 12, 12:32 PM · Plasma
ervin added inline comments to D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Tue, Nov 12, 10:54 AM · Plasma
ervin accepted D25198: KCM Colors : port color scheme state management to KConfigXT.
Tue, Nov 12, 10:45 AM · Plasma
ervin updated the diff for D25211: Add KPropertySkeletonItem.

Avoid potential ownership problem on the propertyName

Tue, Nov 12, 10:41 AM · Frameworks

Mon, Nov 11

ervin accepted D25249: KDirModel: port to qCDebug, with its own category.
Mon, Nov 11, 9:25 AM · Frameworks

Fri, Nov 8

ervin updated the diff for D25211: Add KPropertySkeletonItem.

Fix member variable naming convention

Fri, Nov 8, 1:37 PM · Frameworks
ervin added a comment to D25210: Prepare KConfigSkeletonItem to allow inheriting its private class.

Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class?

Fri, Nov 8, 1:25 PM · Frameworks
ervin updated the diff for D25210: Prepare KConfigSkeletonItem to allow inheriting its private class.

Add missing virtual dtor

Fri, Nov 8, 1:25 PM · Frameworks
ervin committed R265:c0a8cd4a2a95: Register KKeySequenceWidget to KConfigDialogManager (authored by ervin).
Register KKeySequenceWidget to KConfigDialogManager
Fri, Nov 8, 1:21 PM
ervin closed D25209: Register KKeySequenceWidget to KConfigDialogManager.
Fri, Nov 8, 1:21 PM · Frameworks
ervin committed R263:fab6d95a9fad: Add missing property to KKeySequenceWidget (authored by ervin).
Add missing property to KKeySequenceWidget
Fri, Nov 8, 12:34 PM
ervin closed D25208: Add missing property to KKeySequenceWidget.
Fri, Nov 8, 12:34 PM · Frameworks
ervin updated the diff for D25212: Move the shortcut management in the settings object.

Remove stale updateState() function

Fri, Nov 8, 12:27 PM · Plasma
ervin requested review of D25212: Move the shortcut management in the settings object.
Fri, Nov 8, 12:00 PM · Plasma
ervin requested review of D25211: Add KPropertySkeletonItem.
Fri, Nov 8, 11:53 AM · Frameworks
ervin requested review of D25210: Prepare KConfigSkeletonItem to allow inheriting its private class.
Fri, Nov 8, 11:53 AM · Frameworks
ervin requested review of D25209: Register KKeySequenceWidget to KConfigDialogManager.
Fri, Nov 8, 11:52 AM · Frameworks
ervin requested review of D25208: Add missing property to KKeySequenceWidget.
Fri, Nov 8, 11:46 AM · Frameworks
ervin added a comment to D25198: KCM Colors : port color scheme state management to KConfigXT.

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

Fri, Nov 8, 9:34 AM · Plasma

Tue, Nov 5

ervin added a comment to D25147: Remove gtkrc-2.0 legacy settings.

FWIW, LGTM as well, agree with Nate that it likely requires some more extensive testing though.

Tue, Nov 5, 7:24 AM · Plasma
ervin added a comment to D25149: Add a new template for KCMs.

What about having the template use kcfg and ManagedConfigModule as well? It'd give better behaving modules by default and is a better practice than starting without them. I'd rather have people make the conscious decision to remove them because it turns out it's a KCM with no KConfig at all than people overlooking proper KConfig use by default.

Tue, Nov 5, 7:22 AM · Plasma, Frameworks

Mon, Nov 4

ervin committed R124:fe180972acbb: Disable the restore defaults button if the KCModule says so (authored by ervin).
Disable the restore defaults button if the KCModule says so
Mon, Nov 4, 2:34 PM
ervin closed D25074: Disable the restore defaults button if the KCModule says so.
Mon, Nov 4, 2:34 PM · Plasma
ervin added inline comments to D25074: Disable the restore defaults button if the KCModule says so.
Mon, Nov 4, 2:29 PM · Plasma
ervin updated the summary of D25074: Disable the restore defaults button if the KCModule says so.
Mon, Nov 4, 2:25 PM · Plasma
ervin updated the diff for D25074: Disable the restore defaults button if the KCModule says so.

Deal with David's comment and realign ModuleView with KCMultiDialog regarding button state management.

Mon, Nov 4, 2:25 PM · Plasma
ervin committed R295:f2f04d67e221: Disable the restore defaults button if the KCModule says so (authored by ervin).
Disable the restore defaults button if the KCModule says so
Mon, Nov 4, 2:08 PM
ervin closed D25072: Disable the restore defaults button if the KCModule says so.
Mon, Nov 4, 2:08 PM · Frameworks
ervin committed R295:dc836403bb5d: Have KCModuleProxy take care of the defaulted state (authored by ervin).
Have KCModuleProxy take care of the defaulted state
Mon, Nov 4, 2:08 PM
ervin committed R295:4dc999b9eba1: Make KCModuleQml conform to the defaulted() signal (authored by ervin).
Make KCModuleQml conform to the defaulted() signal
Mon, Nov 4, 2:08 PM
ervin closed D25071: Have KCModuleProxy take care of the defaulted state.
Mon, Nov 4, 2:08 PM · Frameworks
ervin closed D25070: Make KCModuleQml conform to the defaulted() signal.
Mon, Nov 4, 2:08 PM · Frameworks
ervin committed R265:0762203eb9df: Adjust KCModule to also channel information about defaults (authored by ervin).
Adjust KCModule to also channel information about defaults
Mon, Nov 4, 2:08 PM
ervin closed D25069: Adjust KCModule to also channel information about defaults.
Mon, Nov 4, 2:08 PM · Frameworks
ervin updated the diff for D25071: Have KCModuleProxy take care of the defaulted state.

Add missing @since markers

Mon, Nov 4, 1:57 PM · Frameworks
ervin updated the diff for D25069: Adjust KCModule to also channel information about defaults.

Add missing @since markers

Mon, Nov 4, 1:55 PM · Frameworks
ervin committed R197:34967b9553c7: Allow the timer to run in the background (authored by ervin).
Allow the timer to run in the background
Mon, Nov 4, 1:49 PM
ervin closed D6034: Allow the timer to run in the background.
Mon, Nov 4, 1:49 PM
ervin committed R197:7fd4a9588cbf: There are still a few QQC1 deps lurking around it seems (authored by ervin).
There are still a few QQC1 deps lurking around it seems
Mon, Nov 4, 1:49 PM
ervin committed R197:25682e023214: Add the android specific manifest and gradle files (authored by ervin).
Add the android specific manifest and gradle files
Mon, Nov 4, 1:49 PM
ervin closed D6033: There are still a few QQC1 deps lurking around it seems.
Mon, Nov 4, 1:49 PM
ervin closed D6032: Add the android specific manifest and gradle files.
Mon, Nov 4, 1:49 PM
ervin committed R197:ba6c7c48eeb9: Make sure pages are always full width (authored by ervin).
Make sure pages are always full width
Mon, Nov 4, 1:49 PM
ervin closed D6031: Make sure pages are always full width.
Mon, Nov 4, 1:49 PM
ervin committed R197:f2edce1cbb28: Drop the hours part in the formatted value (authored by ervin).
Drop the hours part in the formatted value
Mon, Nov 4, 1:49 PM
ervin closed D6030: Drop the hours part in the formatted value.
Mon, Nov 4, 1:49 PM
ervin added a comment to D24743: Update GTK settings according to Plasma settings.

Just a minor thing, otherwise LGTM, I'll let Kai give the last stamp of approval.

Mon, Nov 4, 11:06 AM · VDG, Plasma
ervin added a comment to T11535: Organize 2019 KF6 sprint.

I confirm I'll be there, booked the flights (I land in Tegel at 9:40 if everything goes well, and I'll take off at 18:00 on sunday). Waiting for information regarding accomodations (in particular do I need to book at all, or will we go for a group booking?)

Mon, Nov 4, 8:47 AM · KF6

Thu, Oct 31

ervin added a comment to T11535: Organize 2019 KF6 sprint.

I think I can make it. Depends a bit on said times and how it works out travel wise. Do we already know what's the setup for accomodations as well?

Thu, Oct 31, 4:24 PM · KF6
ervin committed R119:7b0149c79ea4: Fix reset to defaults in the fonts KCM (authored by ervin).
Fix reset to defaults in the fonts KCM
Thu, Oct 31, 3:38 PM
ervin closed D25094: Fix reset to defaults in the fonts KCM.
Thu, Oct 31, 3:38 PM · Plasma
ervin requested review of D25094: Fix reset to defaults in the fonts KCM.
Thu, Oct 31, 3:37 PM · Plasma
ervin committed R119:08a8914d7169: fix kcm fonts "typo" on connect (authored by bport).
fix kcm fonts "typo" on connect
Thu, Oct 31, 10:44 AM
ervin closed D24848: fix kcm fonts "typo" on connect.
Thu, Oct 31, 10:44 AM · Plasma

Wed, Oct 30

ervin added inline comments to D24743: Update GTK settings according to Plasma settings.
Wed, Oct 30, 6:41 PM · VDG, Plasma
ervin accepted D25000: Do not assign combobox currentIndex as it breaks binding..

Looks good to me. Please just wait a bit before pushing to give David a chance to object to my comments. ;-)

Wed, Oct 30, 5:59 PM · Plasma
ervin added inline comments to D25000: Do not assign combobox currentIndex as it breaks binding..
Wed, Oct 30, 5:57 PM · Plasma
ervin added a comment to D25000: Do not assign combobox currentIndex as it breaks binding..

There's a Plasma rule that if we're working round a Qt bug, there should be a Qt bug created and linked before accepting a workaround.

From the sounds of it we want a QQuickControls::ComboBox::setIndex(int) invokable that doesn't update the binding?
Or is it a more generic problem of somehow exposing QQmlPropertyData::WriteFlags ?

Wed, Oct 30, 5:39 PM · Plasma
ervin added a comment to D24916: KCM style : fix combobox that weren't updated after user made change.

Once we got D25000 completed, please remember to abandon that one.

Wed, Oct 30, 2:03 PM · Plasma
ervin requested changes to D25000: Do not assign combobox currentIndex as it breaks binding..

Almost there! Glad we're getting near a proper fix. Can you confirm this works with *and* without D24916 applied?
Can you also confirm this doesn't break the KScreen KCM? (as mentioned in Kai's comment on D24916).

Wed, Oct 30, 2:01 PM · Plasma
ervin added inline comments to D25070: Make KCModuleQml conform to the defaulted() signal.
Wed, Oct 30, 1:52 PM · Frameworks
ervin added a comment to D25071: Have KCModuleProxy take care of the defaulted state.

Edit: ah, I see why.

KCMMultiDialog and system settings re-evaluate the buttons on receipt of the changed signal
Still seems maybe a bit odd, but it makes sense in context.

Wed, Oct 30, 12:52 PM · Frameworks
ervin committed R296:92f6e85438f8: Use compile time checked connect (authored by ervin).
Use compile time checked connect
Wed, Oct 30, 12:48 PM
ervin closed D25077: Use compile time checked connect.
Wed, Oct 30, 12:48 PM · Frameworks
ervin requested review of D25077: Use compile time checked connect.
Wed, Oct 30, 12:46 PM · Frameworks
ervin added inline comments to D25071: Have KCModuleProxy take care of the defaulted state.
Wed, Oct 30, 12:29 PM · Frameworks
ervin committed R119:35c84cb5f9d2: Force reevaluating state on pending deletion changes (authored by ervin).
Force reevaluating state on pending deletion changes
Wed, Oct 30, 12:17 PM
ervin closed D25076: Force reevaluating state on pending deletion changes.
Wed, Oct 30, 12:17 PM · Plasma
ervin committed R119:61cd3d4b19a9: Adjust QtQuickSettings KCM to use KConfigXT in full (authored by ervin).
Adjust QtQuickSettings KCM to use KConfigXT in full
Wed, Oct 30, 12:17 PM
ervin closed D25068: Adjust QtQuickSettings KCM to use KConfigXT in full.
Wed, Oct 30, 12:17 PM · Plasma
ervin accepted D24917: KCM Style port to KConfigXT.
Wed, Oct 30, 12:14 PM · Plasma
ervin added a comment to D24847: KCM Icons fix theme selected when we hit delete theme.

nitpick, but otherwise LGTM, giving time to others (in particular Nate) to chip in.

Wed, Oct 30, 12:09 PM · Plasma
ervin requested changes to D24846: Port kcm icons to kconfigxt.
Wed, Oct 30, 12:07 PM · Plasma
ervin committed R296:372dbb493df6: Make the settingChanged() slot protected. (authored by ervin).
Make the settingChanged() slot protected.
Wed, Oct 30, 11:57 AM