ervin (Kevin Ottens)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2015, 10:18 AM (240 w, 3 d)
Availability
Available

Recent Activity

Thu, Sep 12

ervin committed R4:a1cab6853ed5: Port a page model test away from mock (authored by ervin).
Port a page model test away from mock
Thu, Sep 12, 1:28 PM
ervin committed R4:0468e7bc57e4: Create DependencyManager objects from AkonadiFakeData (authored by ervin).
Create DependencyManager objects from AkonadiFakeData
Thu, Sep 12, 1:28 PM
ervin closed D23889: Create DependencyManager objects from AkonadiFakeData.
Thu, Sep 12, 1:28 PM
ervin committed R4:afcb1fc17b6e: Split initializeGlobalAppDependencies in four functions (authored by ervin).
Split initializeGlobalAppDependencies in four functions
Thu, Sep 12, 1:28 PM
ervin closed D23890: Port a page model test away from mock.
Thu, Sep 12, 1:28 PM
ervin closed D23888: Split initializeGlobalAppDependencies in four functions.
Thu, Sep 12, 1:28 PM
ervin committed R4:aeea98ec040a: Move initializeDependencies in its own integration module (authored by ervin).
Move initializeDependencies in its own integration module
Thu, Sep 12, 1:28 PM
ervin committed R4:cb4ded706fab: Fix AkonadiSerializerTest when run on the 10th (authored by ervin).
Fix AkonadiSerializerTest when run on the 10th
Thu, Sep 12, 1:28 PM
ervin closed D23887: Move initializeDependencies in its own integration module.
Thu, Sep 12, 1:28 PM
ervin closed D23886: Fix AkonadiSerializerTest when run on the 10th.
Thu, Sep 12, 1:28 PM
ervin added a comment to D23890: Port a page model test away from mock.

Alright, now we "just" need to port the rest.

Thu, Sep 12, 1:28 PM

Wed, Sep 11

ervin requested review of D23890: Port a page model test away from mock.
Wed, Sep 11, 9:01 PM
ervin requested review of D23889: Create DependencyManager objects from AkonadiFakeData.
Wed, Sep 11, 9:01 PM
ervin requested review of D23888: Split initializeGlobalAppDependencies in four functions.
Wed, Sep 11, 9:01 PM
ervin requested review of D23887: Move initializeDependencies in its own integration module.
Wed, Sep 11, 9:01 PM
ervin requested review of D23886: Fix AkonadiSerializerTest when run on the 10th.
Wed, Sep 11, 9:01 PM

Tue, Sep 10

ervin accepted D23820: [KSieve] Fix messagebox about connection to server lost.

Looks good to me. Glad the network here is not great, that helped finally nailing that one down. :-)

Tue, Sep 10, 9:05 AM · KDE PIM

Sun, Aug 25

ervin committed R4:0d3760b646d1: Make it build both with pre and post 19.08.0 KCalCore (authored by ervin).
Make it build both with pre and post 19.08.0 KCalCore
Sun, Aug 25, 4:02 PM
ervin closed D23443: Make it build both with pre and post 19.08.0 KCalCore.
Sun, Aug 25, 4:02 PM
ervin requested review of D23443: Make it build both with pre and post 19.08.0 KCalCore.
Sun, Aug 25, 1:40 PM

Tue, Aug 20

ervin accepted D23263: Update fr.kde.org to use the Aether theme.

Looks good to me.

Tue, Aug 20, 1:16 PM

Sat, Aug 17

ervin committed R4:074d2c34883a: Rename childTask to isChildTask in TaskExtraData (authored by ervin).
Rename childTask to isChildTask in TaskExtraData
Sat, Aug 17, 10:32 AM
ervin committed R4:9035e504fd7a: Get rid of the now unused AdditionalInfoRole (authored by ervin).
Get rid of the now unused AdditionalInfoRole
Sat, Aug 17, 10:32 AM
ervin closed D23199: Rename childTask to isChildTask in TaskExtraData.
Sat, Aug 17, 10:32 AM
ervin closed D23183: Get rid of the now unused AdditionalInfoRole.
Sat, Aug 17, 10:32 AM
ervin committed R4:f59b5898cd29: Switch ItemDelegate to the finer grained additional info roles (authored by ervin).
Switch ItemDelegate to the finer grained additional info roles
Sat, Aug 17, 10:32 AM
ervin closed D23182: Switch ItemDelegate to the finer grained additional info roles.
Sat, Aug 17, 10:32 AM
ervin committed R4:ad302efdbb2c: Add finer grained roles for the additional info (authored by ervin).
Add finer grained roles for the additional info
Sat, Aug 17, 10:32 AM
ervin committed R4:8b76dac7e3d2: Have all the relevant PageModel use defaultTaskData (authored by ervin).
Have all the relevant PageModel use defaultTaskData
Sat, Aug 17, 10:32 AM
ervin closed D23181: Add finer grained roles for the additional info.
Sat, Aug 17, 10:32 AM
ervin closed D23180: Have all the relevant PageModel use defaultTaskData.
Sat, Aug 17, 10:31 AM
ervin committed R4:ee8efa8446cb: Rename dataForTaskWithProject to defaultTaskData (authored by ervin).
Rename dataForTaskWithProject to defaultTaskData
Sat, Aug 17, 10:31 AM
ervin closed D23179: Rename dataForTaskWithProject to defaultTaskData.
Sat, Aug 17, 10:31 AM
ervin committed R4:254b5a0c5cc2: Extend TaskExtraData to support data source and contexts (authored by ervin).
Extend TaskExtraData to support data source and contexts
Sat, Aug 17, 10:31 AM
ervin closed D23178: Extend TaskExtraData to support data source and contexts.
Sat, Aug 17, 10:31 AM
ervin closed D23177: Remove useless include.
Sat, Aug 17, 10:31 AM
ervin committed R4:fc05d79cb60e: Remove useless include (authored by ervin).
Remove useless include
Sat, Aug 17, 10:31 AM

Aug 16 2019

ervin requested review of D23199: Rename childTask to isChildTask in TaskExtraData.
Aug 16 2019, 12:36 PM

Aug 15 2019

ervin requested review of D23183: Get rid of the now unused AdditionalInfoRole.
Aug 15 2019, 2:42 PM
ervin requested review of D23182: Switch ItemDelegate to the finer grained additional info roles.
Aug 15 2019, 2:41 PM
ervin requested review of D23181: Add finer grained roles for the additional info.
Aug 15 2019, 2:41 PM
ervin requested review of D23180: Have all the relevant PageModel use defaultTaskData.
Aug 15 2019, 2:41 PM
ervin requested review of D23179: Rename dataForTaskWithProject to defaultTaskData.
Aug 15 2019, 2:41 PM
ervin requested review of D23178: Extend TaskExtraData to support data source and contexts.
Aug 15 2019, 2:41 PM
ervin requested review of D23177: Remove useless include.
Aug 15 2019, 2:40 PM

Jul 20 2019

ervin accepted D22578: Remove stylesheet in PageView so it reacts to colors and fonts changes.
Jul 20 2019, 3:16 PM
ervin added a comment to D22578: Remove stylesheet in PageView so it reacts to colors and fonts changes.

We want nothing, right? No close icon, but also no lines connecting parent and child?

Jul 20 2019, 3:15 PM
ervin added a comment to D22578: Remove stylesheet in PageView so it reacts to colors and fonts changes.

Oh, right, so it follows styling but just doesn't react to change. It's minor enough that I'd be willing to just ignore it. Otherwise we're good for the proxy style route...

Jul 20 2019, 2:50 PM
ervin added a comment to D22578: Remove stylesheet in PageView so it reacts to colors and fonts changes.

Honestly, I'm not too thrilled about that. I'm surprised about the mentioned bugs from stylesheets though, I thought it was proxying to the real style nowadays?

Jul 20 2019, 1:59 PM

Jun 25 2019

ervin committed R4:d78532fb1ecd: Adjust the context list property (authored by ervin).
Adjust the context list property
Jun 25 2019, 7:04 AM
ervin committed R4:9b07ef185e9b: Implement TaskQueries::findContexts() (authored by ervin).
Implement TaskQueries::findContexts()
Jun 25 2019, 7:04 AM
ervin closed D22058: Implement TaskQueries::findContexts().
Jun 25 2019, 7:04 AM
ervin closed D22057: Adjust the context list property.
Jun 25 2019, 7:04 AM
ervin committed R4:33eb3ad4a1b0: Remove useless call to setPayload (authored by ervin).
Remove useless call to setPayload
Jun 25 2019, 7:04 AM
ervin closed D22056: Remove useless call to setPayload.
Jun 25 2019, 7:04 AM

Jun 24 2019

ervin updated the diff for D22058: Implement TaskQueries::findContexts().

Addressing dfaure's comments

Jun 24 2019, 5:38 PM
ervin added a comment to D22057: Adjust the context list property.

Did the arc amend locally to reflect the description change, that should address your comment.

Jun 24 2019, 5:33 PM
ervin updated the summary of D22057: Adjust the context list property.
Jun 24 2019, 5:31 PM
ervin added a comment to D22057: Adjust the context list property.

Right, that's because in fact I authored this before your own patch. :-)
It was stuck in my own queue because I wanted to validate it with the following commit which I struggled with. I'll change the description.

Jun 24 2019, 6:44 AM
ervin added a comment to T11080: KDE for Big Enterprises.

. well nothing beyond the "let's have a list of companies which can do KDE stuff".

AFAIK this now exists if some company contacts the board looking for development.

Jun 24 2019, 6:42 AM · Goal Setting 2019

Jun 23 2019

ervin requested review of D22058: Implement TaskQueries::findContexts().
Jun 23 2019, 6:35 PM
ervin requested review of D22057: Adjust the context list property.
Jun 23 2019, 6:35 PM
ervin requested review of D22056: Remove useless call to setPayload.
Jun 23 2019, 6:35 PM
ervin added a comment to T11080: KDE for Big Enterprises.

@ervin could you expand on what you mean. Especially in terms of actions we can undertake.

Jun 23 2019, 4:18 PM · Goal Setting 2019
ervin added a comment to T11054: Text For Everyone: International Input Methods, Emoji 🐉, Word Completion.

I think it'd be a good idea to shamelessly borrow content from Eike's 2017 goal proposal and integrate it here ;-)

Jun 23 2019, 1:11 PM · Goal Setting 2019
ervin added a comment to T11072: Make Plasmashell more stable and predictable.

IMO this should be closed as it's basically a bug report, not really a long-term goal.

Jun 23 2019, 1:03 PM · Goal Setting 2019
ervin added a comment to T11080: KDE for Big Enterprises.

This seems very focused on deployments, which is good in itself. Now with my "I work in dev services" hat on, I think the scope should be slightly extended to also encompassing the amount of people looking for KDE related services beyond deployments.

Jun 23 2019, 1:02 PM · Goal Setting 2019
ervin added a comment to T11081: Finalize the transition to Wayland and embrace the future of desktop.

Although, I can't wait to see us switching to Wayland. I think this is slightly too "focused on one tech" as a goal. I'd rather see a lot of Wayland influence in the T11054 and T11057 goals mentioned than having a Wayland goal on its own which would overlook input methods for instance (which is exactly what the people who already switched for good did AFAICT).

Jun 23 2019, 12:55 PM · Goal Setting 2019
ervin added a comment to T11093: Improve Consistency across the Board.

+1 just for the amount of work you put into the proposal. It's clear you've been thinking about this for quite some time, and the problems are laid out very clearly. I agree with almost everything you say. It's these kinds of little inconsistencies that hurt KDE has a brand and makes the whole KDE ecosystem feel fragmented and unreliable, like nobody's coordinating everything. ...probably because it's true! Just a heads-up though: by far the biggest part of this goal is that coordination. If it's chosen, you're basically signing up to do it. :)

Jun 23 2019, 12:52 PM · Consistency, Goal Setting 2019
ervin added a comment to T11091: Feeling of freedom out of the box.

I don't think it is *all* doable indeed... but if the author of that goal put some more research effort into it to improve the wording it could become a strong follow-up goal to the on-boarding one. Indeed, helping users to turn into contributors would be really nice. Even though some of the point in there are a bit shoot-to-the-moon like, some others are actually very doable I think and would help a lot. Please, take time to improve it, I think it could pay off. ;-)

Jun 23 2019, 12:46 PM · Goal Setting 2019
ervin added a comment to T11077: Alternative to QML and V4 engine.

I agree with the other comments, and would go even one step further: anything which is aiming at improving performance and at the same time pointing finger to a particular component or framework should come with measurements. That's how profiling anything starts.

Jun 23 2019, 12:43 PM · Goal Setting 2019
ervin added a comment to T11075: KDE prioritizing privacy and security as an integral part of KDE ecosystem.

That would be a nice follow-up to the privacy goal. The wording still is a bit weak though. I might be slightly confused but I read it a bit like "be more like Qubes" which won't be enough to attract votes to that goal. I'd advise giving more details on how our world would look if the goal was reached. Also I suspect it would work only by further integration with the underlying platform: how would that be achieved? what would be needed or missing? The list of existing libraries fall a bit short there.

Jun 23 2019, 12:40 PM · Goal Setting 2019
ervin added a comment to T11096: First-class user & developer documentation centralized on a portal.

I agree with Lydia here, maybe it's too early to get in technical details on how to achieve it. It's maybe better for that one to focus on the constraints we want to have and the success criteria.

Jun 23 2019, 12:36 PM · Goal Setting 2019
ervin added a comment to T11099: Service based multimedia desktop.

I'm afraid I don't actually understand what's being proposed here. :)

Jun 23 2019, 12:31 PM · Goal Setting 2019
ervin added a comment to T11117: KDE is All About the Apps.

If 'KDE is All About the Apps', do better incubation of third party applications is part of this goal? Making KDE more attractive and easier to third party applications developers, and how to KDE be more progressive to identify and approach good project to be part of KDE.

Yes good idea, updating the manifesto would be part of that and I've added in:

  • Ensure Incubation process is welcoming in its docs and info on how to approach KDE and become part of KDE, ensure it does not get blocked during its process
Jun 23 2019, 12:29 PM · Goal Setting 2019
ervin added a comment to T11074: Make KDE more Accessible for Everybody.

I make suggestion in T11067 to plasma implement better tilling window management. I am not sure does that help in term of Accessibility(for people with disabilities), but it certainly help in Keyboard navigation and Focus handling (and maybe help in voice inputting). So, it seems that my goal suggestion is sub-task for this goal.

Jun 23 2019, 12:26 PM · Goal Setting 2019

Jun 21 2019

ervin committed R493:d4d1010b5540: Ship the ui.rc file inside a resource (authored by ervin).
Ship the ui.rc file inside a resource
Jun 21 2019, 6:08 AM
ervin closed D21917: Ship the ui.rc file inside a resource.
Jun 21 2019, 6:08 AM

Jun 20 2019

ervin updated the diff for D21917: Ship the ui.rc file inside a resource.

Stupid me! Adding the missing file.

Jun 20 2019, 3:19 PM
ervin requested review of D21917: Ship the ui.rc file inside a resource.
Jun 20 2019, 6:21 AM

May 21 2019

ervin committed R475:2945fd477335: Ship the ui.rc file inside a resource (authored by ervin).
Ship the ui.rc file inside a resource
May 21 2019, 4:30 PM

May 20 2019

ervin accepted D21057: Fix task losing context when editing it in the context page.
May 20 2019, 9:12 AM

Apr 7 2019

ervin closed D20356: Trivial fixes.
Apr 7 2019, 6:40 PM · KDE PIM
ervin committed R172:b1565118d342: Trivial fixes (authored by ervin).
Trivial fixes
Apr 7 2019, 6:40 PM
ervin requested review of D20356: Trivial fixes.
Apr 7 2019, 2:31 PM · KDE PIM

Mar 25 2019

ervin accepted D19957: New page: all tasks.
Mar 25 2019, 9:55 AM
ervin added a comment to D20028: IMAPResource: Defer task if we get disconnected during login.

Looks fine to me.

Mar 25 2019, 8:13 AM · KDE PIM
ervin added a comment to D19957: New page: all tasks.

I agree moving the promote implementation in the base class could make sense now. Rather in a separate commit though.

Mar 25 2019, 8:12 AM

Mar 22 2019

ervin added a comment to D19957: New page: all tasks.

I'm not sure the promotion a problem in practice in this view. Yes, the promoted task would disappear, but you'd have a project appearing instead and its children would still be there I guess. It's what I'd expect.

Mar 22 2019, 10:06 AM

Mar 19 2019

ervin accepted D19871: Fix failing unittests for yearly recurrence.
Mar 19 2019, 9:00 AM
ervin accepted D19868: Workday: don't show project name for child tasks.
Mar 19 2019, 8:59 AM
ervin accepted D19819: Fix findTopLevel() being the same as findInboxTopLevel().
Mar 19 2019, 8:58 AM

Mar 18 2019

ervin requested changes to D19819: Fix findTopLevel() being the same as findInboxTopLevel().

Makes me wonder if we shouldn't also fix findInboxTopLevel() indeed your improved findTopLevel() makes a better job at verifying the related-to field doesn't contain a broken reference to a parent... which the inbox doesn't (and should). Would be a separate patch I guess.

Mar 18 2019, 10:32 AM
ervin accepted D19810: Add support for yearly recurrence..

Hehe, clearly I don't have the use, hence the oversight. Thanks!

Mar 18 2019, 10:23 AM
ervin accepted D19809: ItemDelegate: don't replace the user's text upon dataChanged().

It almost asks for unit testing the behavior... but that looks really gruesome to test, so except if you got an idea let's get it merged.

Mar 18 2019, 10:20 AM

Mar 3 2019

ervin accepted D19481: Rename NewProjectDialog to NameAndDataSourceDialog.
Mar 3 2019, 9:55 AM

Mar 2 2019

ervin accepted D19470: Remove now unused Widgets::MessageBox::askTextInput.
Mar 2 2019, 3:30 PM
ervin accepted D19239: migrator: make --forceMigratingTags do the whole migration again.
Mar 2 2019, 3:30 PM
ervin accepted D19238: Fix interoperability issue with kolab server which uppercases all properties.
Mar 2 2019, 3:29 PM
ervin accepted D19217: Fix uids for contexts created by the migrator.
Mar 2 2019, 3:29 PM