ervin (Kevin Ottens)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2015, 10:18 AM (145 w, 1 d)
Availability
Available

Recent Activity

Thu, Nov 2

ervin added a comment to D8567: Emit signals when a screen is added or removed.

Looks good to me too but want to give the plasma team the last say.

Thu, Nov 2, 12:08 PM · Plasma
ervin accepted D8566: Add API to retrieve the screen id for a screen name.
Thu, Nov 2, 12:06 PM · Plasma, Frameworks
ervin accepted D8450: User can now hide an entire places group from KFilePlacesView.
Thu, Nov 2, 10:46 AM · Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.

Couple more changes needed.

Thu, Nov 2, 10:42 AM · Frameworks
ervin accepted D8366: Factoring out lists of url data within KFilePlacesModelTest.
Thu, Nov 2, 10:35 AM · Frameworks

Tue, Oct 31

ervin added a comment to D8567: Emit signals when a screen is added or removed.

Looks good to me, but I'm giving time for the Plasma team to see it.

Tue, Oct 31, 2:10 PM · Plasma
ervin requested changes to D8566: Add API to retrieve the screen id for a screen name.
Tue, Oct 31, 2:09 PM · Plasma, Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.
Tue, Oct 31, 2:08 PM · Frameworks
ervin requested changes to D8450: User can now hide an entire places group from KFilePlacesView.

At least the unit test would be welcome, I let you decide on the other comment.

Tue, Oct 31, 12:21 PM · Frameworks
ervin accepted D8348: Add a section for removable devices.
Tue, Oct 31, 11:47 AM · Frameworks
ervin requested changes to D8367: Hidding place groups implementation in KFilePlacesModel.
Tue, Oct 31, 11:46 AM · Frameworks
ervin requested changes to D8348: Add a section for removable devices.

Found a small one after all.

Tue, Oct 31, 11:32 AM · Frameworks
ervin requested changes to D8366: Factoring out lists of url data within KFilePlacesModelTest.
Tue, Oct 31, 11:27 AM · Frameworks
ervin accepted D8348: Add a section for removable devices.
Tue, Oct 31, 11:25 AM · Frameworks
ervin requested changes to D8332: Added baloo urls into places model.

All the fiddling with URLs makes me wonder if that wouldn't be better done on the KIO implementations side... but that's out of scope for that patch I think.

Tue, Oct 31, 10:40 AM · Frameworks
ervin added a comment to D8243: Implement support for categories on KfilesPlacesView.

Great work BTW, this looks really nice now.

Tue, Oct 31, 9:00 AM · Frameworks
ervin accepted D8243: Implement support for categories on KfilesPlacesView.
Tue, Oct 31, 9:00 AM · Frameworks
ervin added a comment to T7116: Streamlined onboarding of new contributors.

Ah my apologies, I thought the goal here was to capture the whole spectrum of contributors. Of course if the goal was to focus on non-coding contributors then this is fine.

Tue, Oct 31, 6:58 AM · Goal settings 2017

Mon, Oct 30

ervin added a comment to D8243: Implement support for categories on KfilesPlacesView.

Looks fine code wise now, just a couple more tweaks to make those sections look closer to what Dolphin got.

Mon, Oct 30, 2:51 PM · Frameworks
ervin added a comment to T7116: Streamlined onboarding of new contributors.

I'll sound like a broken record but: if we don't solve the "how difficult it is to build something and patch it" *first* all the nice things mentioned here with mentoring etc. (which require people we don't have BTW) won't get us far. People will try, fail immediately because it's too hard and leave again.
Seen that enough with my students the past few years.

Mon, Oct 30, 6:53 AM · Goal settings 2017

Fri, Oct 20

ervin added a comment to T7116: Streamlined onboarding of new contributors.

Yes, it'd be nice to see them finally merging, we're late in the discussion phase now. Also as a bonus, it would be awesome if the consolidated proposal could contain aspects coming from the talk we held with David Faure this year about the developer story. That'd make for a very strong one then, and would probably add at least David's name in the list of people willing to put work into it. ;-)

Fri, Oct 20, 6:18 AM · Goal settings 2017

Oct 18 2017

ervin committed R223:43199ae48116: Mention the share menu in the documentation (authored by ervin).
Mention the share menu in the documentation
Oct 18 2017, 2:55 PM
ervin closed D8263: Mention the share menu in the documentation.
Oct 18 2017, 2:55 PM · Okular
ervin committed R223:a5da013a4da2: Add a "share" menu to Okular (authored by ervin).
Add a "share" menu to Okular
Oct 18 2017, 2:55 PM
ervin closed D8244: Add a "share" menu to Okular.
Oct 18 2017, 2:55 PM · Okular
ervin committed R495:a823d325b295: Add API to control the disabled plugins (authored by ervin).
Add API to control the disabled plugins
Oct 18 2017, 2:02 PM
ervin closed D8341: Add API to control the disabled plugins.
Oct 18 2017, 2:02 PM
ervin updated the diff for D8341: Add API to control the disabled plugins.

Addresses apol's comment

Oct 18 2017, 11:02 AM
ervin added inline comments to D8341: Add API to control the disabled plugins.
Oct 18 2017, 11:01 AM

Oct 17 2017

ervin updated the diff for D8341: Add API to control the disabled plugins.

Address aacid's comment

Oct 17 2017, 9:45 AM
ervin added inline comments to D8341: Add API to control the disabled plugins.
Oct 17 2017, 9:44 AM
ervin created D8341: Add API to control the disabled plugins.
Oct 17 2017, 8:55 AM
ervin abandoned D8262: Add a new platform constraint for filtering plugins.

OK, looks like we got an agreement so abandoning that change, a new one will be uploaded.

Oct 17 2017, 8:52 AM

Oct 16 2017

ervin updated the diff for D8263: Mention the share menu in the documentation.

Trying to address Jack Ostroff's comment.

Oct 16 2017, 9:09 AM · Okular
ervin added a comment to D8263: Mention the share menu in the documentation.

Wasn't sure mentioning a technology like KPurpose directly wouldn't be considered like jargon... I can change it indeed.

Oct 16 2017, 8:59 AM · Okular

Oct 14 2017

ervin added a comment to D8263: Mention the share menu in the documentation.

This is introduced by another patch which is through review as well.
The "Share" menu will show up and will always contain at least a couple of actions, but the exact list of actions is unknown, it depends on which plugins for KPurpose are available in the system and the settings the admins might have put in place.

Oct 14 2017, 8:41 AM · Okular

Oct 13 2017

ervin added a comment to D8262: Add a new platform constraint for filtering plugins.

So what about the blacklist API with a default of {"saveasplugin"} in the case of a desktop build? It already gets de facto a default with the changes from Dan.

Oct 13 2017, 11:31 AM
ervin added a comment to D8243: Implement support for categories on KfilesPlacesView.

A couple more changes needed.

Oct 13 2017, 8:58 AM · Frameworks
ervin requested changes to D8243: Implement support for categories on KfilesPlacesView.

You probably missed my comment on the previous iteration:
"Note that the summary part of the commit is now wrong (it still refers to KCategorizedView).
Also, KFilePlacesModelTest needs to be adjusted to take into account the new behavior."

Oct 13 2017, 8:39 AM · Frameworks
ervin added a comment to D8262: Add a new platform constraint for filtering plugins.

Perhaps I should have named that form-factor. I personally think it makes sense to go about it this way, especially in the case of convergence where the form factor might change and thus the save as action appear in different places (although granted the current implementation doesn't go that far). Beside on desktop a "Save As" action in a share menu is totally foreign while on mobile it's the other way around.

Oct 13 2017, 8:08 AM

Oct 12 2017

ervin created D8263: Mention the share menu in the documentation.
Oct 12 2017, 11:52 AM · Okular
ervin created D8262: Add a new platform constraint for filtering plugins.
Oct 12 2017, 11:37 AM
ervin added a comment to D8243: Implement support for categories on KfilesPlacesView.

One more thing, the way the sections are currently done, if I drag the first item of a section the visual feedback I get also includes the section itself giving the feeling that the section itself is being moved. Also I can drag from the section title itself which is a problem too.

Oct 12 2017, 6:56 AM · Frameworks
ervin requested changes to D8243: Implement support for categories on KfilesPlacesView.

Note that the summary part of the commit is now wrong (it still refers to KCategorizedView).

Oct 12 2017, 6:49 AM · Frameworks

Oct 11 2017

ervin updated the diff for D8244: Add a "share" menu to Okular.

Addressing extra comment

Oct 11 2017, 3:45 PM · Okular
ervin updated the diff for D8244: Add a "share" menu to Okular.

Address aacid's comments

Oct 11 2017, 3:37 PM · Okular
ervin updated the diff for D8244: Add a "share" menu to Okular.

Making the purpose dependency optional

Oct 11 2017, 3:24 PM · Okular
ervin created D8244: Add a "share" menu to Okular.
Oct 11 2017, 12:53 PM · Okular

Sep 4 2017

ervin accepted D7683: Don't leak the Akonadi::Monitor.
Sep 4 2017, 11:16 AM
ervin requested changes to D7683: Don't leak the Akonadi::Monitor.

I think the mistake was not passing the MonitorImpl to the Monitor at construction time. Could you please do that instead?

Sep 4 2017, 5:52 AM

Aug 27 2017

ervin added a comment to T6857: Falkon Incubation.

I think you're right, there's also the continuity agreement ("If the authors of the software abandon it or disappear, they agree to transfer the trademark to the next maintainer"), but really it's more a "we trust the word" of the current maintainer, not something very formal.

Aug 27 2017, 5:57 PM · Falkon

Aug 26 2017

ervin committed R4:512e15c42b4b: Stop redirecting akonaditest output (authored by ervin).
Stop redirecting akonaditest output
Aug 26 2017, 9:14 PM

Aug 20 2017

ervin accepted D7366: Fix crash on startup when m_task is null..
Aug 20 2017, 8:55 PM
ervin accepted D7358: Fix compilation with -DQT_NO_URL_CAST_FROM_STRING..
Aug 20 2017, 8:55 PM
ervin accepted D7357: Add some missing reserve() calls.
Aug 20 2017, 8:54 PM
ervin abandoned D93: Prepare scripting feature - add an action in order to open ScriptEditor.

Closing by lack of activity.

Aug 20 2017, 8:53 PM · Zanshin
ervin commandeered D93: Prepare scripting feature - add an action in order to open ScriptEditor.
Aug 20 2017, 8:53 PM · Zanshin
ervin set the repository for D7366: Fix crash on startup when m_task is null. to R4 Zanshin.
Aug 20 2017, 8:53 PM
ervin set the repository for D7358: Fix compilation with -DQT_NO_URL_CAST_FROM_STRING. to R4 Zanshin.
Aug 20 2017, 8:52 PM

Aug 16 2017

ervin committed R4:4044038f8756: Speed up ArtifactEditorModelTest with a shorter autoSaveDelay (authored by ervin).
Speed up ArtifactEditorModelTest with a shorter autoSaveDelay
Aug 16 2017, 11:04 PM
ervin committed R4:bb84d78e6a5e: Prevent emitting result twice when second subjob has an error (authored by ervin).
Prevent emitting result twice when second subjob has an error
Aug 16 2017, 11:04 PM
ervin closed D7342: Speed up ArtifactEditorModelTest with a shorter autoSaveDelay by committing R4:4044038f8756: Speed up ArtifactEditorModelTest with a shorter autoSaveDelay.
Aug 16 2017, 11:04 PM
ervin closed D7311: Prevent emitting result twice when second subjob has an error by committing R4:bb84d78e6a5e: Prevent emitting result twice when second subjob has an error.
Aug 16 2017, 11:04 PM
ervin committed R4:d96e8b148361: Allow the editor model to add/remove attachments (authored by ervin).
Allow the editor model to add/remove attachments
Aug 16 2017, 11:04 PM
ervin committed R4:dcd76b0372c2: EditorView allows to add/remove attachments (authored by ervin).
EditorView allows to add/remove attachments
Aug 16 2017, 11:04 PM
ervin closed D7308: EditorView allows to add/remove attachments by committing R4:dcd76b0372c2: EditorView allows to add/remove attachments.
Aug 16 2017, 11:04 PM
ervin closed D7307: Allow the editor model to add/remove attachments by committing R4:d96e8b148361: Allow the editor model to add/remove attachments.
Aug 16 2017, 11:04 PM
ervin closed D7301: Ensure the Serializer deals with recurrence properly by committing R4:21f94dcddf88: Ensure the Serializer deals with recurrence properly.
Aug 16 2017, 11:04 PM
ervin committed R4:21f94dcddf88: Ensure the Serializer deals with recurrence properly (authored by ervin).
Ensure the Serializer deals with recurrence properly
Aug 16 2017, 11:04 PM
ervin committed R4:fe3a441392e0: Expose recurrence to the editor model (authored by ervin).
Expose recurrence to the editor model
Aug 16 2017, 11:04 PM
ervin committed R4:6b4c5b5eff48: Add a combo box to EditorView to control recurrence (authored by ervin).
Add a combo box to EditorView to control recurrence
Aug 16 2017, 11:04 PM
ervin committed R4:1f6eb0c85525: Add recurrence support to Akonadi::Serializer (authored by ervin).
Add recurrence support to Akonadi::Serializer
Aug 16 2017, 11:04 PM
ervin closed D7300: Add a combo box to EditorView to control recurrence by committing R4:6b4c5b5eff48: Add a combo box to EditorView to control recurrence.
Aug 16 2017, 11:04 PM
ervin closed D7299: Expose recurrence to the editor model by committing R4:fe3a441392e0: Expose recurrence to the editor model.
Aug 16 2017, 11:04 PM
ervin closed D7298: Add recurrence support to Akonadi::Serializer by committing R4:1f6eb0c85525: Add recurrence support to Akonadi::Serializer.
Aug 16 2017, 11:03 PM
ervin committed R4:5357ae956f8e: Add recurrence support to the Task Domain (authored by ervin).
Add recurrence support to the Task Domain
Aug 16 2017, 11:03 PM
ervin committed R4:33d4e876f9c9: Allow to open attachments by double-click (authored by ervin).
Allow to open attachments by double-click
Aug 16 2017, 11:03 PM
ervin closed D7266: Add recurrence support to the Task Domain by committing R4:5357ae956f8e: Add recurrence support to the Task Domain.
Aug 16 2017, 11:03 PM
ervin closed D7265: Allow to open attachments by double-click by committing R4:33d4e876f9c9: Allow to open attachments by double-click.
Aug 16 2017, 11:03 PM
ervin committed R4:db8db78e8393: EditorView now displays attachments (authored by ervin).
EditorView now displays attachments
Aug 16 2017, 11:03 PM
ervin committed R4:9a7e6b42bc26: Editor model exposes task attachments with QAIM (authored by ervin).
Editor model exposes task attachments with QAIM
Aug 16 2017, 11:03 PM
ervin closed D7263: Editor model exposes task attachments with QAIM by committing R4:9a7e6b42bc26: Editor model exposes task attachments with QAIM.
Aug 16 2017, 11:03 PM
ervin closed D7264: EditorView now displays attachments by committing R4:db8db78e8393: EditorView now displays attachments.
Aug 16 2017, 11:03 PM
ervin committed R4:b2e2595c7f55: Have AkonadiSerializer process Attachments (authored by ervin).
Have AkonadiSerializer process Attachments
Aug 16 2017, 11:03 PM
ervin closed D7262: Have AkonadiSerializer process Attachments by committing R4:b2e2595c7f55: Have AkonadiSerializer process Attachments.
Aug 16 2017, 11:03 PM
ervin committed R4:74ebf4497e66: Add Attachment(s) to the Task part of the Domain (authored by ervin).
Add Attachment(s) to the Task part of the Domain
Aug 16 2017, 11:03 PM
ervin closed D7261: Add Attachment(s) to the Task part of the Domain by committing R4:74ebf4497e66: Add Attachment(s) to the Task part of the Domain.
Aug 16 2017, 11:03 PM
ervin updated the diff for D7342: Speed up ArtifactEditorModelTest with a shorter autoSaveDelay.

Addressing dfaure's comment

Aug 16 2017, 10:32 PM
ervin added a comment to D7342: Speed up ArtifactEditorModelTest with a shorter autoSaveDelay.

Well, can't be const but OK. :-)

Aug 16 2017, 10:26 PM
ervin updated the diff for D7307: Allow the editor model to add/remove attachments.

Addressing dfaure's comment

Aug 16 2017, 7:47 PM
ervin abandoned D4225: Add information about build and test zanshin into HACKING file.

Doesn't look like my comments are going to be addressed, closing it for now.

Aug 16 2017, 8:10 AM · Zanshin
ervin commandeered D4225: Add information about build and test zanshin into HACKING file.
Aug 16 2017, 8:10 AM · Zanshin
ervin abandoned D3435: Support gcc < 5.

Doesn't look like my comments are going to be addressed, closing it for now.

Aug 16 2017, 8:09 AM
ervin commandeered D3435: Support gcc < 5.
Aug 16 2017, 8:09 AM
ervin abandoned D4458: Improvement to the diff made by Florimond on the HACKING file.

Doesn't look like my comments are going to be addressed, closing it for now.

Aug 16 2017, 8:07 AM
ervin commandeered D4458: Improvement to the diff made by Florimond on the HACKING file.
Aug 16 2017, 8:06 AM
ervin abandoned D4459: Scripting Interface.

Doesn't look like my comments are going to be addressed, closing it for now.

Aug 16 2017, 8:06 AM · Zanshin
ervin commandeered D4459: Scripting Interface.
Aug 16 2017, 8:06 AM · Zanshin
ervin abandoned D4841: scipt_manager.

Doesn't look like my comments are going to be addressed, closing it for now.

Aug 16 2017, 8:06 AM · Zanshin
ervin commandeered D4841: scipt_manager.
Aug 16 2017, 8:05 AM · Zanshin