- User Since
- Feb 5 2015, 10:18 AM (220 w, 1 d)
Sun, Apr 7
Mar 25 2019
Looks fine to me.
I agree moving the promote implementation in the base class could make sense now. Rather in a separate commit though.
Mar 22 2019
I'm not sure the promotion a problem in practice in this view. Yes, the promoted task would disappear, but you'd have a project appearing instead and its children would still be there I guess. It's what I'd expect.
Mar 19 2019
Mar 18 2019
Makes me wonder if we shouldn't also fix findInboxTopLevel() indeed your improved findTopLevel() makes a better job at verifying the related-to field doesn't contain a broken reference to a parent... which the inbox doesn't (and should). Would be a separate patch I guess.
Hehe, clearly I don't have the use, hence the oversight. Thanks!
It almost asks for unit testing the behavior... but that looks really gruesome to test, so except if you got an idea let's get it merged.
Mar 3 2019
Mar 2 2019
Thanks, I like having dirty and broken data at places.
NameAndDataSourceDialog it is then.
Admittedly I'm confused by some of the changes in the XML
I'd also expect a way to express that a todo has a bunch of contexts? Like we have "withParentUid". You didn't feel that need yet? It's kind of surprising me.
Couples of comments, but they are for different commits, they don't need to be done in this commit.
Feb 3 2019
Feb 1 2019
Jan 29 2019
Slightly torn about that one since we stop checking that we won't die on other data types... But I guess that's a necessary evil for now.
Jan 14 2019
Jan 12 2019
Jan 9 2019
Addresses David's comment.
Yes. A student project which never got completed. The same team did the workday view though. ;-)